fluid-work IRC Logs-2012-10-30

Owned by Fluid IRC Log Bot
Last updated: Oct 30, 2012Version comment
8 min read

[09:09:04 CDT(-0500)] <heidiv> hi anastasiac! could you help me find where the inline width for the video player is being injected?

[09:09:14 CDT(-0500)] <heidiv> the style="width:300px"

[09:10:23 CDT(-0500)] <anastasiac> ah, yes, heidiv, that's a tricky one. Try the VideoPlayer_media.js file, and double-check if mediaelement.js or captionator (in the lib folder) are doing anything funky

[09:10:27 CDT(-0500)] <heidiv> i'm wondering if px vs em is what's causing the issue in safari with it being too small when txt is resized

[09:10:42 CDT(-0500)] <heidiv> i'll take a look!

[09:10:58 CDT(-0500)] <anastasiac> mediaelement.js should only be doing anything in IE8, heidiv, but I wonder if it's causing other troubles

[09:11:07 CDT(-0500)] <anastasiac> and captionator might be misbehaving

[09:12:44 CDT(-0500)] <anastasiac> heidiv, it looks like VideoPlayer.js is extracting the width from the video itself, for some reason, you might want to check there

[09:13:00 CDT(-0500)] <heidiv> anastasiac aha… ok

[09:13:29 CDT(-0500)] <heidiv> anastasiac is there a tool for safari for editing css , like fire bug?

[09:14:01 CDT(-0500)] <heidiv> oops, never mind…inspector does let me do that

[09:14:11 CDT(-0500)] <anastasiac> heidiv, my copy of Safari has a "Develop" menu, where you can show a Web Inspector, which is like Firebug

[09:14:13 CDT(-0500)] <anastasiac> do you have that?

[09:14:45 CDT(-0500)] <heidiv> yep, just turned it on in prefs… thanks (smile)

[09:15:04 CDT(-0500)] <anastasiac> k

[09:41:02 CDT(-0500)] <michelled> good morning heidiv, were you looking for me?

[09:41:47 CDT(-0500)] <heidiv> hiya m… yeah i'm poking around the vid player code, but A helped me out. i'm looking at the resize function

[09:42:08 CDT(-0500)] <heidiv> i think it's the root of 4815 and 4819

[09:45:10 CDT(-0500)] <heidiv> jvass did my vol slider comment make sense?

[09:45:56 CDT(-0500)] <jvass> heidiv, from what i understand the colour of the slider menu background is actually a border that's why a border can't be added to it?

[09:46:09 CDT(-0500)] <heidiv> jvass yes, exactly

[09:46:55 CDT(-0500)] <michelled> heidiv: and I guess the markup isn't under our control because it's a jquery slider?

[09:47:00 CDT(-0500)] <heidiv> appears it is a jquery widget and so mucking around with changing the html might be iffy

[09:47:14 CDT(-0500)] <heidiv> we could try, but not sure it's worth the hassle

[09:47:52 CDT(-0500)] <heidiv> i'm wondering if there's a third colour we could introduce into the theme palettete ?

[09:48:03 CDT(-0500)] <heidiv> palette ? sp? ha

[09:48:36 CDT(-0500)] <heidiv> or, is it okay to make the top/bottom same colour… does that convey info information?

[09:48:44 CDT(-0500)] <heidiv> *enough info

[09:49:14 CDT(-0500)] <jvass> so it won't be possible to change that, so that the volume slider is styled more like the other menus?

[09:49:59 CDT(-0500)] <heidiv> we can change all of the colours, but i think that's it

[09:50:23 CDT(-0500)] <heidiv> perhaps a themed gradient image? like the gold one currently in use could still work with y on b

[09:50:33 CDT(-0500)] <heidiv> and we'd make others for the other themes?

[09:50:38 CDT(-0500)] <heidiv> know what i mean?

[09:51:31 CDT(-0500)] <jvass> heidiv, i'm not quite sure what you mean?

[09:52:07 CDT(-0500)] <heidiv> jvass so right now the bottom half is styled with background: -moz-linear-gradient(90deg, #FFCC00, #F8E211) repeat scroll 0 0 transparent;

[09:52:58 CDT(-0500)] <heidiv> i wonder if we can just change the colours here, for each theme - it would appear different than the top colour, yet still be within the theme's colour range. hope i'm making sense.

[09:54:11 CDT(-0500)] <jvass> oh okay, I don't think we should us gradients for the high contrast themes because we haven't introduced them anywhere else

[09:54:35 CDT(-0500)] <heidiv> jvass yeah. so would the top/bottom being the same colour be ok? or is that losing too much information?

[09:56:07 CDT(-0500)] <jvass> heidiv, um i could get a repeating pattern background for the top part, would that be possible?

[09:56:53 CDT(-0500)] <heidiv> jvass, for the bottom i think, yeah

[09:57:08 CDT(-0500)] <heidiv> checking if we could do top…

[09:58:02 CDT(-0500)] <heidiv> jvass yes we can change the top to a bg image

[09:58:36 CDT(-0500)] <jvass> heidiv, oh good i'll get you that image

[09:59:05 CDT(-0500)] <heidiv> jvass perfect - thanks, good idea!

[10:10:47 CDT(-0500)] <heidiv> michelled anastasiac have we tried using http://jqueryui.com/resizable/ anywhere

[10:12:18 CDT(-0500)] <heidiv> just came across it when looking at px->em conversion. looks neat

[10:17:27 CDT(-0500)] <anastasiac> heidiv, interesting, no I don't think we've used that; at least, not that I know of. I wonder if it's keyboard accessible (wink)

[10:17:44 CDT(-0500)] <jvass> heidiv, i just noticed the width of the volume slider menu doesn't scale with the button size when text size is increased. would that be related to the colour issue?

[10:18:23 CDT(-0500)] <heidiv> anastasiac i'm guessing not, but that would be cool if we could make it so !

[10:18:39 CDT(-0500)] <heidiv> jvass i think it's a different issue - perhaps file a jura?

[10:18:50 CDT(-0500)] <heidiv> jira

[10:19:08 CDT(-0500)] <jvass> okay

[11:01:04 CDT(-0500)] <jvass> heidiv, i was just thinking would it be possible to get the effect of a border using two drop-shadows for the outside and two inset drop-shadows for the inside?

[11:01:37 CDT(-0500)] <heidiv> jvass i believe that only works on firefox?

[11:02:57 CDT(-0500)] <heidiv> looking at http://robertnyman.com/2010/03/16/drop-shadow-with-css-for-all-web-browsers/

[11:07:25 CDT(-0500)] <jvass> hm, the shadow won't be blurred, so it would be okay for IE as well?

[11:08:06 CDT(-0500)] <michelled> heidiv: take a look at this page for compatibility: http://caniuse.com/#feat=css-boxshadow

[11:15:00 CDT(-0500)] <heidiv> jvass michelled …the thing is, if it doesn't work, you wouldn't see any top half at all.

[11:18:22 CDT(-0500)] <heidiv> it's pretty well supported tho, and looks like there's IE hacks

[11:18:35 CDT(-0500)] <heidiv> brb lunch

[11:28:52 CDT(-0500)] <jvass> heidiv, maybe we could still have still have the patterned bg image in case it isnt supported?

[11:28:53 CDT(-0500)] <jvass> my worry is that if there isn't an outside border the slider menu could blend into the scrubber

[11:30:27 CDT(-0500)] <heidiv> jvass we can put a border around the scrubber

[11:32:14 CDT(-0500)] <heidiv> michelled caniuse.com is a great resource, thanks

[11:33:23 CDT(-0500)] <jvass> heidiv, isn't there a border already on the scrubber?

[11:33:51 CDT(-0500)] <heidiv> yeah we can change its colour

[11:34:25 CDT(-0500)] <heidiv> i'll try the shadow thing for a theme and see how it looks, one sec

[11:34:49 CDT(-0500)] <jvass> heidiv, oh sorry i meant the timeline

[11:36:51 CDT(-0500)] <heidiv> jvass are we talking about the timelines or volume slider

[11:37:20 CDT(-0500)] <jvass> when the video is played past the volume sider, the two black backgrounds blend into each other i h

[11:37:33 CDT(-0500)] <jvass> i hope that made sense, ill send a screen shot

[11:39:45 CDT(-0500)] <heidiv> ah, i see. i'm also noticing the volume button background doesn't change when using the vol slider, but it does in your mockups

[11:41:14 CDT(-0500)] <heidiv> jvass so the edges of the volume slider need a border to not blend in with timeline

[11:41:35 CDT(-0500)] <jvass> heidiv, yes http://issues.fluidproject.org/secure/attachment/13042/vp-volume.tiff

[11:43:20 CDT(-0500)] <heidiv> jvass and in that image, the volume button should be inverted colours, right?

[11:43:50 CDT(-0500)] <heidiv> did you make a jira for how it's nudged over a little?

[11:44:08 CDT(-0500)] <jvass> heidiv, yep (smile)

[11:44:23 CDT(-0500)] <heidiv> k i'll make one for the button too (smile)

[11:45:05 CDT(-0500)] <jvass> thanks heidiv!

[11:50:45 CDT(-0500)] <heidiv> jvass okay i'll try the shadow trickery and see what happens

[12:34:23 CDT(-0500)] <heidiv> anastasiac easy way to turn off control-hiding on vid player?

[12:34:26 CDT(-0500)] <heidiv> for dev

[12:36:17 CDT(-0500)] <anastasiac> heidiv, comment out the call to hideControllers on line 414 of VideoPlayer.js; then, after first hover, controllers never disappear

[12:36:30 CDT(-0500)] <heidiv> anastasiac thanks!

[12:42:44 CDT(-0500)] <colinclark> yura: Do you think that, with Bosmon's code review help, you'll be ready for a potential GPII 0.1 code free on November 12?

[12:42:54 CDT(-0500)] <colinclark> Specifically, for the work that introduces flat preferences throughout the system?

[12:43:49 CDT(-0500)] <yura> colinclark: i think so i will have something in my pull request today

[12:43:58 CDT(-0500)] <heidiv> jvass i've set an inset for the top half of the vol slider, but not finding a way to put a border around the entire thing, to separate it from the timeline...

[12:44:28 CDT(-0500)] <colinclark> yura: Okay, great

[12:44:38 CDT(-0500)] <colinclark> let's try to sit down this week and talk through some of that stuff

[12:48:38 CDT(-0500)] <heidiv> jvass tho it might be related to it being off centre with the button… something funky's going on

[12:48:57 CDT(-0500)] <heidiv> perhaps i'll solve that issue there instead of w the contrast issue

[12:57:06 CDT(-0500)] <jvass> heidiv, having a drop shadow won't work as a border for the entire volume menu?

[12:59:20 CDT(-0500)] <heidiv> jvass it seems i can't have both an inset and an outset shadow at the same time?

[12:59:46 CDT(-0500)] <heidiv> box-shadow lets me set either or...

[13:02:51 CDT(-0500)] <heidiv> jvass know what i mean?

[13:05:12 CDT(-0500)] <jvass> heidiv, ah yes, that's too bad - I'll just get you the image for top part of the slider then and the shadow could be used for the outside?

[13:05:29 CDT(-0500)] <heidiv> jvass: got it! "outline"

[13:06:03 CDT(-0500)] <jvass> heidiv, oh great!

[13:06:06 CDT(-0500)] <jvass> (smile)

[13:06:19 CDT(-0500)] <heidiv> high five

[13:44:42 CDT(-0500)] <heidiv> michelled is there a list of the browsers the vidplayer needs to support

[13:46:34 CDT(-0500)] <michelled> heidiv: we don't have an official list yet but I'd say we are targeting latest Chrome, Safari, FF and IE8+

[13:50:26 CDT(-0500)] <thealphanerd> colinclark: hows it going?

[13:51:08 CDT(-0500)] <thealphanerd> I hav esome ideas I want to run by you when you have a chance

[14:01:12 CDT(-0500)] <heidiv> this is interesting. a css-emulator (style hacks) for older IEs, replicating css3 stuff: http://css3pie.com/

[14:03:02 CDT(-0500)] <heidiv> jvass it looks like inset box-shadows can't be replicated in IE8… so we should prob have those backgrounds as a back up.

[14:06:24 CDT(-0500)] <heidiv> we'd have to add an "if IE8" stylesheet

[14:06:27 CDT(-0500)] <heidiv> yuck

[14:07:35 CDT(-0500)] <jvass> heidiv, ill export them now, hm

[14:07:51 CDT(-0500)] <jvass> hm, could we have them not just for IE8

[14:08:53 CDT(-0500)] <heidiv> yeah, and then the border disappears for the top half, in IE8, but with a patterned bg, it would still look ok

[14:09:12 CDT(-0500)] <heidiv> like it wouldn't blend in

[14:09:43 CDT(-0500)] <jvass> heidiv, yeah that sounds good

[14:09:48 CDT(-0500)] <heidiv> k

[14:09:48 CDT(-0500)] <colinclark> thealphanerd: fire away

[14:09:51 CDT(-0500)] <heidiv> k

[14:11:13 CDT(-0500)] <heidiv> jvass did you make a jira for the volume slider being nudged over a bit

[14:11:50 CDT(-0500)] <jvass> heidiv, oh no, i havent

[14:12:10 CDT(-0500)] <heidiv> jvass k i will, np

[14:12:20 CDT(-0500)] <jvass> thanls

[14:12:23 CDT(-0500)] <jvass> thanks*

[14:21:51 CDT(-0500)] <heidiv> michelled can i add stuff to the floe iteration plan? some volume slider issues (while i'm at it) FLUID-4829 and 4828

[14:26:33 CDT(-0500)] <jvass> heidiv, here's the bg images http://wiki.fluidproject.org/download/attachments/29950286/sliderbg.zip?version=1&amp;modificationDate=1351625019807

[14:31:04 CDT(-0500)] <michelled> heidiv: yep, those look completely related to the other issue

[14:31:07 CDT(-0500)] <michelled> go for it!

[14:33:27 CDT(-0500)] <heidiv> thanks jvass!

[14:43:46 CDT(-0500)] <heidiv> jvass hate to bug you but the bg images shouldn't be transparent cos then the timeline shows up behind it

[14:44:26 CDT(-0500)] <heidiv> or, the time scrubber info i mean

[14:44:37 CDT(-0500)] <jvass> heidiv, oh right! sorry i'll change that!

[14:44:43 CDT(-0500)] <heidiv> thanks!

[14:51:23 CDT(-0500)] <jvass> heidiv, updated! http://wiki.fluidproject.org/download/attachments/29950286/sliderbg.zip

[14:51:33 CDT(-0500)] <heidiv> sweet, thanks again!

[16:43:48 CDT(-0500)] <heidiv> michelled jvass the player is different than j's mockups for some things: the timeline is above controls instead of within, the volume slider default is different colours etc. are we still sticking close to the mockups or are there newer ones that maybe i'm missing.

[16:45:22 CDT(-0500)] <heidiv> i think i might just be looking at an oldy