fluid-work IRC Logs-2012-10-04

[09:42:10 CDT(-0500)] <michelled> anastasiac: I've been looking a little more at FLUID-4792 because the fix just feels weird to me

[09:42:22 CDT(-0500)] <michelled> I think there's an issue with when displayTranscript gets called

[09:42:37 CDT(-0500)] <michelled> it shouldn't be called every time we click on a language

[09:42:50 CDT(-0500)] <michelled> we should only have to do that once I think

[09:43:25 CDT(-0500)] <michelled> or rather, the functionality inside displayTranscript shouldn't happen every time.

[09:43:50 CDT(-0500)] <michelled> if you set a breakpoint in that function, you'll see that it doesn't get called when you toggle show and hide transcripts

[09:46:17 CDT(-0500)] <anastasiac> michelled, ok, I'll have a look. Do you want to put these comments on the pull request?

[09:46:32 CDT(-0500)] <michelled> sure

[10:47:42 CDT(-0500)] <anastasiac> michelled, that pull request for 4792 has been updated now

[10:47:50 CDT(-0500)] <michelled> thx anastasiac

[14:11:28 CDT(-0500)] <michelled> alexn: I'm looking at one of your pull requests and I have a question

[14:11:44 CDT(-0500)] <alexn> michelled: sure

[14:11:54 CDT(-0500)] <alexn> michelled: which pull request is it ?

[14:11:55 CDT(-0500)] <michelled> https://github.com/fluid-project/videoPlayer/pull/56/files

[14:12:14 CDT(-0500)] <michelled> on line 453, I'm wondering why you are using 'apply' instead of calling the function directly

[14:14:18 CDT(-0500)] <alexn> michelled: I need to spend some time to refresh my memory. so far I remember that I had a way of calling but Colin advised to use apply which was a great improvement… I just need to put all pieces together in my head for this example

[14:14:59 CDT(-0500)] <alexn> michelled: give me few minutes since I'm in a middle of something here

[14:15:06 CDT(-0500)] <michelled> take your time - I know that this was a while ago

[14:22:10 CDT(-0500)] <alexn> michelled: unfortunately it was long time ago. But from what I remember you have to call this function for the existing video in our videoPlayer. It should not be just any tag as on line 42 but the tag which has the real video. Apply is a great way to pass "this" which points to the video.

[14:22:48 CDT(-0500)] <alexn> michelled: does it make any sense or I just added more questions than answers

[14:24:06 CDT(-0500)] <alexn> basically at lines 41-44 requestFullScreen will be have a proper RequestFullScreenFunction depending on the browser type

[14:24:22 CDT(-0500)] <alexn> and then we would call this resolved function for the video we have in a videoPlayer

[14:24:24 CDT(-0500)] <michelled> that makes sense alexn

[14:25:33 CDT(-0500)] <alexn> michelled: I had an implementation which would actually call a specific function without apply. But after code review colin pointed out to me an easier and better way of doing the same thing through apply()

[14:25:56 CDT(-0500)] <michelled> cool