fluid-work IRC Logs-2012-10-22

[07:15:54 CDT(-0500)] * jhernandez waves helloooo!

[09:41:46 CDT(-0500)] <michelled> hey anastasiac: I'm just looking at your pull request for http://issues.fluidproject.org/browse/FLUID-4811 and I was wondering if you tested it cross browser

[09:42:33 CDT(-0500)] <anastasiac> hm… I did test with a couple of browsers, michelled, but probably not all of them. Are you seeing problems?

[09:42:56 CDT(-0500)] <michelled> no, I haven't tested it yet - which browsers did you look at?

[09:43:41 CDT(-0500)] <anastasiac> FF on Mac, IE9, I believe… I should have tested them all, I'll do that now.

[09:44:35 CDT(-0500)] <michelled> thx

[09:54:14 CDT(-0500)] <anastasiac> michelled, I've tested 4811 in FF, Safari, Chrome and IE9 - controls enlarge propertly. This has exposed a problem with small videos, but I'll file a fresh JIRA for that.

[09:54:45 CDT(-0500)] <michelled> thx anastasiac

[11:51:07 CDT(-0500)] <michelled> alexn1: when you closed this ticket, did you ensure that the correct aria is being created for the required fields? https://www.assembla.com/spaces/iskme/tickets/665

[11:52:53 CDT(-0500)] <alexn1> michelled: this is the ticket for displaying an asterisk in UI for the required field. The issue you are talking about is https://www.assembla.com/spaces/iskme/tickets/609 and https://www.assembla.com/spaces/iskme/tickets/647

[11:53:47 CDT(-0500)] <michelled> alexn1: according to Andrey's comment on the ticket, 665 was caused by the changes to add aria for required

[11:54:12 CDT(-0500)] <michelled> alexn1: can you ensure that what ever fix was done didn't undo the aria work anastasiac had done?

[11:57:23 CDT(-0500)] <michelled> anastasiac: can you answer alexn1's question on this ticket? https://www.assembla.com/spaces/iskme/tickets/802

[12:01:02 CDT(-0500)] <alexn1> michelled: I will take a look into 665 but I'm pretty sure that all aria changes are still present. Some of the fields were missing classes to display an asterisk. But it is fixed in the current OER version. However aria-required or required attributes are not present anywhere in OER Commons (tickets 609 and 647 should address that)

[12:02:09 CDT(-0500)] <anastasiac> alexn, I've just commented on 802, with a screenshot. I do see the branding image interface on the Describe screen, under the abstract, for a resource I drafted on the production site.

[12:02:16 CDT(-0500)] <anastasiac> alexn1: ^

[12:03:23 CDT(-0500)] <michelled> thx alexn1!

[12:08:02 CDT(-0500)] <anastasiac> michelled, I've issued a pull request for FLUID-4812 and updated the iteration page

[12:08:12 CDT(-0500)] <michelled> thx anastasiac

[12:12:06 CDT(-0500)] <Justin_o> yura: you know how for listeners and invokers you can change the arguments..

[12:12:25 CDT(-0500)] <Justin_o> yura: do you know if there is a way to put one of those passed in values into an object.. when it is being passed in

[12:12:59 CDT(-0500)]

[12:13:02 CDT(-0500)] <Justin_o> yura: ^

[12:16:21 CDT(-0500)] <yura> Justin_o: yes definitely

[12:16:53 CDT(-0500)] <Justin_o> yura: great.. thanks

[12:21:54 CDT(-0500)] <alexn1> anastasiac: thx a lot! maybe it is present only on production but not on staging… I will take a second look

[12:46:00 CDT(-0500)] <michelled> anastasiac: I pushed your 4811 branch - can you just check all your changes got in ok?

[12:46:08 CDT(-0500)] <michelled> github seems to think there are still differences

[12:46:16 CDT(-0500)] <anastasiac> k

[12:47:37 CDT(-0500)] <anastasiac> michelled, diff looks ok to me (i.e. no diff with my branch) and the VP looks good

[12:47:53 CDT(-0500)] <michelled> great - thanks for checking

[13:14:16 CDT(-0500)] <michelled> anastasiac: I was looking at your pull request for FLUID-4812. It looks like the issue was introduced here: https://github.com/fluid-project/videoPlayer/commit/1114fb14b06e624bfaa0d6f07440778e582b3cb5

[13:14:37 CDT(-0500)] <michelled> anastasiac: can you make sure we haven't lost any functionality with the new change?

[13:15:10 CDT(-0500)] <anastasiac> michelled, I did test extensively to make sure everything still works: cross browser, unit tests, manual tests. I'm unable to produce any strange or unexpected behaviour.

[13:15:26 CDT(-0500)] <michelled> ok, great - thanks

[13:28:44 CDT(-0500)] <anastasiac> michelled, my FLUID-4811 seems to have introduced a small styling bug in the transcript area: the close button is now below the drop-down I'll file a JIRA. Sorry about that...

[13:48:08 CDT(-0500)] <anastasiac> michelled, I've issued a pull request for FLUID-4816, the above-mentioned transcript area close button positioning problem

[14:38:46 CDT(-0500)] <michelled> anastasiac: In this pull request I'd done a little clean up of the integration tests - some linting and simplification to initVideoPlayer. any chance you and roll these into your 4812 branch where you refactor that code out into TestUtils?

[14:38:58 CDT(-0500)] <michelled> https://github.com/fluid-project/videoPlayer/pull/71/files

[14:39:07 CDT(-0500)] <anastasiac> sure, michelled

[14:39:12 CDT(-0500)] <michelled> thx!

[14:44:09 CDT(-0500)] <anastasiac> michelled, did you merge the latest trunk into your branch for that pull request?

[14:44:23 CDT(-0500)] <anastasiac> s/trunk/master/

[14:44:47 CDT(-0500)] <michelled> anastasiac: no

[14:44:54 CDT(-0500)] <anastasiac> ok

[14:45:29 CDT(-0500)] <michelled> anastasiac: I guess the diff should show you the minor changes - there's just no need to have initVideoPlayer not take any parameter and then parse them out

[14:45:35 CDT(-0500)] <michelled> overly complex for no gain

[14:45:40 CDT(-0500)] <anastasiac> k

[14:50:59 CDT(-0500)] <anastasiac> michelled, changes pushed

[14:51:04 CDT(-0500)] <michelled> thx anastasiac

[15:01:58 CDT(-0500)] <anastasiac> michelled, I've pushed those changes you commented on in the pull request

[15:02:06 CDT(-0500)] <michelled> thx anastasiac

[15:10:07 CDT(-0500)] <michelled> anastasiac: thanks for making those changes - 4812 looks good and is now pushed

[15:10:17 CDT(-0500)] <anastasiac> thanks, michelled