fluid-work IRC Logs-2012-10-17

Owned by Fluid IRC Log Bot
Last updated: Oct 17, 2012Version comment
5 min read

[08:26:05 CDT(-0500)] <Justin_o> cindyli, jhung: I've added a capture.html page that will be used for selecting the type of capture. This has been added as the default start page for the server too. My changes have been pushed up to my bitbucket repos

[08:26:22 CDT(-0500)] <cindyli> ok, thanks, Justin_o

[08:27:45 CDT(-0500)] <Justin_o> jhung: do you have error messages we can display when the export or deletion of images fail

[08:31:28 CDT(-0500)] <jhung> justin_o: no. They are unhandled at the moment. There are Jiras for it.

[08:32:06 CDT(-0500)] <jhung> justin_o: I think we can leave it for the time being.

[08:32:10 CDT(-0500)] <Justin_o> jhung: okay.

[08:32:12 CDT(-0500)] <jhung> thoughts?

[08:32:22 CDT(-0500)] <Justin_o> jhung: we can make generic ones for now if you want

[09:08:04 CDT(-0500)] <jhung> justin_o, cindyli: I'm getting a 404 Not Found error when trying to load Exporter using localhost:8080

[09:08:19 CDT(-0500)] <jhung> any idea?

[09:08:28 CDT(-0500)] <cindyli> jhung: do you have the exporter server started?

[09:38:08 CDT(-0500)] <michelled> hey colinclark: I think today is the day to merge demo into master!

[09:38:26 CDT(-0500)] <michelled> 259 files changed and almost 500 commits later!

[09:38:35 CDT(-0500)] <colinclark> wow!

[09:38:38 CDT(-0500)] <colinclark> Sounds promising

[09:38:48 CDT(-0500)] <michelled> yes (smile)

[09:39:10 CDT(-0500)] <michelled> colinclark: there are a few outstanding pull requests to demo, but I'm thinking we can just reissue them to master

[09:39:30 CDT(-0500)] <michelled> and there are still lots of rough edges in the video player

[09:39:46 CDT(-0500)] <michelled> but it's looking better and we now have tests the very basic start at a manual test plan

[09:40:13 CDT(-0500)] <michelled> anastasiac, alexn1, cindyli, colinclark: any reason I shouldn't merge demo into master today?

[09:40:38 CDT(-0500)] <michelled> here's the pull request that does the merge: https://github.com/fluid-project/videoPlayer/pull/75

[09:41:21 CDT(-0500)] <michelled> colinclark: I don't expect you to review that request - I figure I can handle it myself since most of the individual commits in it were already reviewed

[09:41:31 CDT(-0500)] <colinclark> yes, that seems reasonable

[09:41:45 CDT(-0500)] <colinclark> I'll defer to the other folks, but it sounds like it's a good time

[09:42:05 CDT(-0500)] <colinclark> I think the biggest question from here will be how to ramp up code quality to the standards we'd expect from a "master branch"

[09:42:16 CDT(-0500)] <colinclark> and I guess we've been doing that incrementally in the demo branch

[09:42:22 CDT(-0500)] <michelled> yes, we have

[09:42:41 CDT(-0500)] <michelled> we still have a ways to go, but I don't think we are gaining anything anymore by having the split

[09:43:27 CDT(-0500)] <colinclark> no, exactly

[09:43:41 CDT(-0500)] <colinclark> if anything, we're doing ourselves a big disservice by staying in this strange other world

[09:43:49 CDT(-0500)] <michelled> yes

[09:44:05 CDT(-0500)] <anastasiac> it seems to me that what's in the demo branch is way ahead of what's in master, and while it still has bugs, it is, in effect, our "master" branch.

[09:44:10 CDT(-0500)] <michelled> the one thing I couldn't compromise on was the Captionator fork, now that we've cleaned that up a lot I'm happier

[09:45:19 CDT(-0500)] <michelled> we still need to get that request into the project repo and move over to it instead of using the fork in my repo, but I'll prioritize that high once we do the merge

[10:03:30 CDT(-0500)] <anastasiac> michelled, I've updated my outstanding pull requests (2) to be against master now

[10:06:25 CDT(-0500)] <michelled> thx anastasiac

[11:08:43 CDT(-0500)] <michelled> anastasiac: http://build.fluidproject.org/videoPlayer

[11:33:37 CDT(-0500)] <Bosmon> michelled - congrats on the long-awaited GIANT MERGE!

[11:33:52 CDT(-0500)] <michelled> thanks Bosmon! it's very satisfying

[11:33:59 CDT(-0500)] <michelled> now there is a lot of cleanup to do (smile)

[11:36:12 CDT(-0500)] <michelled> anastasiac: you meant to close this one, right? https://github.com/fluid-project/videoPlayer/pull/77

[11:36:46 CDT(-0500)] <anastasiac> yes, michelled, it was issued against demo; it's been re-issued

[11:36:56 CDT(-0500)] <michelled> thx

[12:56:22 CDT(-0500)] <michelled> colinclark, Bosmon: any chance one of you could cast an eye on this pull request? the broken integration tests are annoying: https://github.com/fluid-project/videoPlayer/pull/71/files

[12:59:23 CDT(-0500)] <Bosmon> michelled - I think we can't have a component which stores an HTML "TimeRanges" object in its model

[12:59:28 CDT(-0500)] <Bosmon> Such an object is not model-like

[12:59:42 CDT(-0500)] <Bosmon> As well as coupling too tightly to a particular technology

[13:06:35 CDT(-0500)] <michelled> Bosmon: I did find that surprising in the model - and particular so because it wasn't made clear that was what it was.

[13:07:14 CDT(-0500)] <michelled> Bosmon: I guess I can pull that out of the model and put it into the component

[13:08:01 CDT(-0500)] <michelled> I don't know this code well so this will be a good opportunity for me to get more familiar with it

[13:08:14 CDT(-0500)] <Bosmon> michelled - to me, it looks like this belongs hidden somewhere similar to the "html5MediaTimer"

[13:08:24 CDT(-0500)] <Bosmon> Emphasising the fact that this is a piece of HTML5-specific technology

[13:08:37 CDT(-0500)] <Bosmon> If any part of it needs to be surfaced in the model, it should be done so as plain JSON objects

[13:09:26 CDT(-0500)] <michelled> my hunch is that it doesn't need to be surfaced - that it was stuck in the model for convenience

[13:09:30 CDT(-0500)] <Bosmon> ok, cool

[13:09:51 CDT(-0500)] <michelled> thanks for looking!

[13:24:40 CDT(-0500)] <michelled> anastasiac: so, how do feel about the master branch now? do you think we are ready to point the other demo url to it also?

[13:25:08 CDT(-0500)] <anastasiac> michelled, can you clarify what you mean by "the other demo url"?

[13:26:00 CDT(-0500)] <michelled> build.fluidproject.org/videodemo

[13:26:09 CDT(-0500)] <michelled> which is currently serving a nightly build of the demo branch

[13:26:19 CDT(-0500)] <anastasiac> I'm wondering if we need to keep the url at all?

[13:26:20 CDT(-0500)] <michelled> I'm on a mission to delete the demo branch (smile)

[13:26:50 CDT(-0500)] <michelled> anastasiac: we need to keep it because we've distributed it so widely

[13:27:03 CDT(-0500)] <michelled> Jutta is probably demoing with it today

[13:27:57 CDT(-0500)] <anastasiac> If that's the case, then I don't see much reason NOT to point it at master, unless we are worried that master will, as future changes go in, become inappropriate for demos

[13:28:35 CDT(-0500)] <anastasiac> but assuming that we're going to become even more diligent with our testing now that we're working in master (we are, right?) then I think we should NOT keep the demo url pointed at demo

[13:28:37 CDT(-0500)] <michelled> no, that's not the issue - I just want to be sure that the merge was clean

[13:28:42 CDT(-0500)] <anastasiac> it will become outdated

[13:28:45 CDT(-0500)] <anastasiac> ah

[13:28:51 CDT(-0500)] <anastasiac> oh, yes, it seems quite fine

[13:29:00 CDT(-0500)] <anastasiac> I haven't seen any differences between the two at all

[13:29:04 CDT(-0500)] <michelled> great, thanks for testing it

[13:40:12 CDT(-0500)] <anastasiac> fluid-everyone: is anyone interested in our community workshop today? the topic is "designing web navigation"

[13:43:10 CDT(-0500)] <cindyli> i'm interested, anastasiac

[13:45:30 CDT(-0500)] <anastasiac_> cindyli, we're gathering in the collar room

[13:45:50 CDT(-0500)] <cindyli> lol. i see ok

[14:06:52 CDT(-0500)] <jessm> http://hydra.mobiforge.com/ see your pages on diff. mobile browsers

[14:57:56 CDT(-0500)] <anastasiac> jessm: very neat, thanks

[15:24:52 CDT(-0500)] <michelled> hey Bosmon, I updated this pull request with the ability to run sync tests as well as async tests and renamed the clear function for consistency. https://github.com/fluid-project/videoPlayer/pull/74

[15:28:00 CDT(-0500)] <michelled> Bosmon: I'm not sure what I should do about cleaning up at the appropriate time without using teardown

[23:12:27 CDT(-0500)] <thealphanerd> Bosmon: you around?

[23:13:01 CDT(-0500)] <Bosmon> THER ALPHER *NNERDD*!!

[23:13:29 CDT(-0500)] <thealphanerd> hehe

[23:13:34 CDT(-0500)] <thealphanerd> do you know who Gareth Loy is?

[23:46:56 CDT(-0500)] <Bosmon> I don't know him

[23:50:00 CDT(-0500)] <Bosmon> If you like him, you might also appreciate this guy:

[23:50:00 CDT(-0500)] <Bosmon> http://dmitri.tymoczko.com/