fluid-work IRC Logs-2009-03-18

Owned by Fluid IRC Log Bot
Last updated: Mar 18, 2009Version comment
20 min read

[08:19:16 EDT(-0400)] * laurelw (n=Laurel@142.150.154.178) has joined #fluid-work
[08:22:50 EDT(-0400)] * michelled (n=michelle@CPE001310472ade-CM0011aefd3ca8.cpe.net.cable.rogers.com) has joined #fluid-work
[08:53:42 EDT(-0400)] * athena (n=athena@99.129.100.66) has joined #fluid-work
[08:54:39 EDT(-0400)] * Justin_o (n=Justin@142.150.154.171) has joined #fluid-work
[08:55:57 EDT(-0400)] <michelled> Justin_o: I broke some tests last night when I committed
[08:56:08 EDT(-0400)] <michelled> I should know better then to commit when my brain is tired
[08:56:11 EDT(-0400)] <michelled> I'm about it fix them
[08:56:20 EDT(-0400)] <Justin_o> okay... thanks...
[08:57:56 EDT(-0400)] <Justin_o> michelled: were the tests in both UIEnhancer and UI Options unit tests?
[08:58:06 EDT(-0400)] <michelled> yes
[08:58:43 EDT(-0400)] <michelled> and I just realized that the sakai example will not work exactly correctly either. I changed the name of an option but forgot to change the uses
[08:58:44 EDT(-0400)] <michelled> doh
[08:59:59 EDT(-0400)] <Justin_o> oh well... at least you know what the problem is..
[09:06:57 EDT(-0400)] * anastasiac (n=stasia@142.150.154.189) has joined #fluid-work
[09:14:46 EDT(-0400)] * clown (n=clown@bas1-cooksville17-1279271466.dsl.bell.ca) has joined #fluid-work
[09:18:55 EDT(-0400)] <clown> good morning anastasiac. Just letting someone know (on the 7th floor) that I'm working from home this morning. I'll be sometime after 12 noon.
[09:19:12 EDT(-0400)] <anastasiac> clown, thanks for the heads-up
[09:19:19 EDT(-0400)] <clown> wlcm
[09:19:56 EDT(-0400)] <Justin_o> clown: were you and antranig able to fix all of those jira's you were working on yesterday
[09:20:31 EDT(-0400)] <clown> Justin_o:
[09:21:12 EDT(-0400)] <clown> Justin_o: I was going to look at a deployment (the build site) to see how the changes looked (sometime today).
[09:22:16 EDT(-0400)] <Justin_o> that should work good... i need to get someone to review the committ anyways... and then if you don't mind closing them after you have a look at it (provided it is fixed)
[09:22:19 EDT(-0400)] <clown> I was waiting for the checkin to percolate to somewhere that was a real -live example. Am I mistaken in thinking that will happen.
[09:22:20 EDT(-0400)] <clown> ?
[09:22:55 EDT(-0400)] <Justin_o> it should be up on the build site now... you were working on the image reorderer i believe
[09:23:35 EDT(-0400)] <Justin_o> during bug parade, we just have the commits reviewed before the jira can be closed
[09:24:13 EDT(-0400)] <clown> experiencing some lag ... sure will have look. Should I check anything other than the image reorderer? This weird <img> within a <div role="img"> markup doesn't happen anywhere else does it?
[09:24:42 EDT(-0400)] <clown> I guess I should look at another example (say list reordering) to make sure that markup isn't changed.
[09:25:05 EDT(-0400)] <Justin_o> hmm.... i suppose it will happen here http://build.fluidproject.org/fluid/sample-code/shared/portal/portal.html
[09:25:10 EDT(-0400)] <michelled> Justin_o: I just committed the fix for the tests. you might want to rebuild. The sakai example contrast drop down will not be fully populated until my next commit.
[09:25:41 EDT(-0400)] <Justin_o> clown: there is an image reorderer portlet there, not sure how it gets put in the portlet though...
[09:26:02 EDT(-0400)] <Justin_o> michelled: okay... thanks for the update
[09:26:44 EDT(-0400)] <clown> well, what shouldn't happen is that the portlet's themselves shouldn't be marked up as "<div role="img" ...>", whereas the thumbnails within a portlet should.
[09:27:19 EDT(-0400)] <Justin_o> clown
[09:27:22 EDT(-0400)] <Justin_o> interesting
[09:28:16 EDT(-0400)] <clown> yeah, I'm saying that the aria markup isn't the same for each case in which the reorderer is used. So, what we changed yesterday should only affect some markup and not others.
[09:28:38 EDT(-0400)] <Justin_o> ah.. okay...
[09:28:41 EDT(-0400)] <athena> would it be helpful to have updated html for those portal mockups?
[09:28:48 EDT(-0400)] <clown> thus, a proper to check is to see that it affected only those cases where it should have (my that sounds tautological).
[09:30:21 EDT(-0400)] <Justin_o> clown: i think i understand what your saying... it should only affect the case of the reordering of images.... such as in the image reorderer example...and not have leaked out to any other of our reordering examples
[09:30:24 EDT(-0400)] <clown> athena, maybe not; not sure. I would want to know that the markup didn't change for them since antranig's checkin.
[09:30:45 EDT(-0400)] <clown> Justin_o: right.
[09:31:35 EDT(-0400)] <athena> i was asking in part because we've changed some of our DOM structure and added FSS classes and such - but if it's just a general example and is good enough for examples/testing as is, then that's totally cool (smile)
[09:32:33 EDT(-0400)] <Justin_o> clown: i just did a quick look and it seems that only the div containg the image and it's name has the role="img ... on it
[09:32:41 EDT(-0400)] <clown> athena, I think so.
[09:33:03 EDT(-0400)] <athena> ok
[09:33:33 EDT(-0400)] <Justin_o> athena: thanks for the offer... i think there may have been some brief talk about the usage of some of our examples... so we may end up updating this at some time... not sure though
[09:33:37 EDT(-0400)] <clown> athena: my doubt is do to my not having working on this stuff for quite a while.
[09:33:45 EDT(-0400)] <athena> (smile)
[09:34:05 EDT(-0400)] <athena> that all sounds totally reasonable
[09:34:49 EDT(-0400)] <clown> Justin_o: main thumbnail <div> with role="img" is good. but there were other changes that had to happen in concert – see the JIRAs for details (alas, I don't remember the numbers off hand, and I'm at home at the moment).
[09:35:11 EDT(-0400)] <Justin_o> clown: thanks... no problem... i have them all
[09:35:40 EDT(-0400)] <clown> Yes, you are the Czar, Justin_o
[09:36:07 EDT(-0400)] <Justin_o> well... for now anyways (tongue)
[09:36:55 EDT(-0400)] * sgithens (n=sgithens@in-143-221.dhcp-149-166.iupui.edu) has joined #fluid-work
[09:43:41 EDT(-0400)] <clown> Justin_o: how many browsers should I check? Is FF3 sufficient? (makes the assumption that if the markup is correct in one browser, it will be for all).
[09:44:41 EDT(-0400)] <Justin_o> clown: this is our current browser support http://wiki.fluidproject.org/display/fluid/Browser+Support
[09:44:56 EDT(-0400)] <Justin_o> I suppose you can cut out the non-aria compliant browsers
[09:45:27 EDT(-0400)] <Justin_o> and just test under one OS if there are multiples (e.g. FF3 only on one platform)
[09:46:10 EDT(-0400)] <Justin_o> how many would that leave you with
[09:46:38 EDT(-0400)] <clown> yes, it's tricky. Strictly speaking, this is merely dom manipulations, so it should work in all supported browsers. But, if the browser isn't going to publish the information (not aria compliant), then it doesn't matter if it's right or wrong.
[09:47:10 EDT(-0400)] <clown> I think I should look at FF2, since it does its aria markup differently.
[09:47:24 EDT(-0400)] <Justin_o> that's seems like a good idea...thanks
[09:47:52 EDT(-0400)] <clown> I should look at IE8 too, since it is the only IE that supports aria, but I can't do that until I get into work (no VMware here).
[09:48:59 EDT(-0400)] <Justin_o> thanks... in worst case scenario if you can't test in IE 8 that's okay, because we aren't officially supporting it till after it is out of pre-release status... but it would be better to have it working now than to have to fix it again later
[09:50:21 EDT(-0400)] <Justin_o> michelled: do you remember what this jira is about... i was looking through some old ones and was wondering if it can be closed or not. http://issues.fluidproject.org/browse/FLUID-667
[09:57:39 EDT(-0400)] <michelled> Justin_o: do these tests pass in IE now?
[09:58:14 EDT(-0400)] <michelled> basically, there are a bunch of our tests that must have their markup visible for the test to pass. It's reasonable
[09:58:18 EDT(-0400)] <michelled> not a bug
[09:58:41 EDT(-0400)] <michelled> it just makes the test a bit ugly but we get used to it. think lightbox tests
[09:58:47 EDT(-0400)] <Justin_o> ah okay.... so that's why in some cases you see the items on the test page and others you don't
[09:58:53 EDT(-0400)] <michelled> ya
[09:59:09 EDT(-0400)] <Justin_o> so you think it's reasonable to close as a won't fix
[09:59:16 EDT(-0400)] <michelled> we start out by hiding the test markup and when we hit one of the 'must be visible' sorts of things we make it visible
[09:59:24 EDT(-0400)] <michelled> perhaps we should just start out visible
[09:59:39 EDT(-0400)] <michelled> ya, close it
[10:00:12 EDT(-0400)] <Justin_o> okay.. .thanks ... and you are probably right... write the tests as visible and make them hidden if possible
[10:00:13 EDT(-0400)] * jessm (n=Jess@c-71-232-3-4.hsd1.ma.comcast.net) has joined #fluid-work
[10:06:52 EDT(-0400)] * fj4000 (n=Jacob@142.150.154.106) has joined #fluid-work
[10:15:45 EDT(-0400)] * colinclark (n=colin@bas2-toronto09-1176406320.dsl.bell.ca) has joined #fluid-work
[10:22:19 EDT(-0400)] <fj4000> Hi athena
[10:22:26 EDT(-0400)] <athena> morning fj4000
[10:22:28 EDT(-0400)] <fj4000> I have some questions for you
[10:22:30 EDT(-0400)] <athena> sure
[10:23:07 EDT(-0400)] <fj4000> i was taking a peak at the irc logs from the other day, and saw that I might be of help to uPortal?
[10:23:18 EDT(-0400)] <fj4000> something to do with wireframes, or some IU?
[10:23:22 EDT(-0400)] <fj4000> *UI
[10:23:55 EDT(-0400)] <athena> yes! so i think basically we're looking to create a small portlet that will allow people to register their uportal installations with jasig
[10:24:07 EDT(-0400)] <athena> we've written up some requirements and a first stab at a jsp page
[10:24:19 EDT(-0400)] <athena> i think the whole front-end will really just be a form followed by a confirmation screen
[10:24:35 EDT(-0400)] <athena> unfortunately it looks like eric isn't around yet - i had a question or two for him about it
[10:24:46 EDT(-0400)] <fj4000> I see
[10:25:00 EDT(-0400)] <athena> but generally we want to collect a little information like the portal's name and demo url and some contact info
[10:25:17 EDT(-0400)] <fj4000> if I go throught the jsp, will I see the basics there?
[10:25:24 EDT(-0400)] <athena> and then let people pick what information they're willing to send back, and whether they're willing to allow jasig to publish that info
[10:25:27 EDT(-0400)] <athena> yep
[10:25:38 EDT(-0400)] <athena> and there's a confluence page describing the info and behavior
[10:25:45 EDT(-0400)] <fj4000> is there validation for the form?
[10:25:50 EDT(-0400)] <fj4000> ok
[10:26:41 EDT(-0400)] <athena> http://www.ja-sig.org/wiki/display/UPC/Automated+Portal+Registration
[10:26:53 EDT(-0400)] <athena> i think there probably should be, although that isn't something that we've discussed yet
[10:27:04 EDT(-0400)] <athena> i'd imagine we'd want to validate things like email address, at least
[10:28:42 EDT(-0400)] <athena> the question i had for eric was whether we intend to collect (or offer to collect) data at all if the user doesn't want to be published in the deployers list
[10:29:04 EDT(-0400)] <fj4000> ok, so what I gather I can do to help is to give the generated markup a look, and provide a CSS file to provide a basic style for it, and the end result could act as a prototype
[10:29:18 EDT(-0400)] <athena> that'd be great (smile)
[10:29:24 EDT(-0400)] <fj4000> cool
[10:29:30 EDT(-0400)] <athena> and actually, i'm sort of hoping we may not even need much in the way of css
[10:29:47 EDT(-0400)] <fj4000> i wouldnt think so if you already have the fss in place
[10:29:50 EDT(-0400)] <athena> right
[10:29:57 EDT(-0400)] <athena> and have a default stylesheet
[10:30:00 EDT(-0400)] * clown (n=clown@bas1-cooksville17-1279271466.dsl.bell.ca) has left #fluid-work
[10:30:18 EDT(-0400)] <athena> i don't know if we should use the jsr168 css classes for now for the form fields or whether fss defines styles for those
[10:30:38 EDT(-0400)] <fj4000> you could use both I think, or either
[10:30:48 EDT(-0400)] <athena> ok
[10:31:06 EDT(-0400)] <athena> i guess basically we just need to make sure both classes are styled similarly in the portal's css
[10:31:34 EDT(-0400)] <fj4000> Gary and I are still supposed to create a guideline for the 168 stuff, so Im not sure how that would work in the end
[10:31:34 EDT(-0400)] <athena> i think my preference would be to use FSS where possible, but provide reasonable, consistent defaults in the portal stylesheets for non-jasig portlets that choose to use JSR168 classes
[10:31:54 EDT(-0400)] <fj4000> yes, that approach will likely be covered in the guideline
[10:32:06 EDT(-0400)] <athena> awesome (smile)
[10:32:24 EDT(-0400)] <athena> and this portlet is something that will be in uportal only, so i don't think we need to worry about what happens if people install it in other portals
[10:32:32 EDT(-0400)] <fj4000> ok
[10:32:39 EDT(-0400)] <fj4000> so its a portlet in itslef then
[10:32:41 EDT(-0400)] <fj4000> got it
[10:32:52 EDT(-0400)] <athena> yep
[10:32:56 EDT(-0400)] <athena> but a "framework" portlet
[10:33:15 EDT(-0400)] <athena> meaning it's part of uportal's source code and lives within its web context, rather than being a separate application
[10:33:58 EDT(-0400)] <fj4000> i see
[10:34:12 EDT(-0400)] <fj4000> as for its appearance and placement, will it look like all the others?
[10:34:24 EDT(-0400)] <fj4000> i only have those "utility portlets" to use as reference
[10:37:39 EDT(-0400)] <athena> yes, it should look like the others
[10:38:12 EDT(-0400)] <athena> if you have a running instance of up3 around somewhere, it should wind up looking like anything that's already in there (well, ok, except for all the stuff we wrote that has no ui, maybe (smile) )
[10:39:18 EDT(-0400)] <athena> but generally those utility portlets are just using the default css
[10:46:16 EDT(-0400)] <michelled> fj4000, Justin_o: I'm thinking we won't be able to take UI Options out of preview without tweaking the current contrast themes. Essentially the white text is almost impossible to read at times.
[10:46:39 EDT(-0400)] <fj4000> which text?
[10:47:27 EDT(-0400)] <michelled> some of the title in low contrast
[10:47:50 EDT(-0400)] <michelled> the titles in medium contrast grey scale
[10:48:21 EDT(-0400)] <michelled> some of the titles in high contrast inverted
[10:48:49 EDT(-0400)] <Justin_o> i see what you are saying... it's like lite grey text on slightly darker grey background
[10:49:16 EDT(-0400)] <Justin_o> these are things that will vary with the contrast ratio of the monitor it is viewed on...
[10:50:07 EDT(-0400)] <Justin_o> i'll do a quick look to see if there is a common contrast ratio for computer lcd monitors
[10:51:35 EDT(-0400)] <Justin_o> michelled: fj4000 is on the phone right now... he said he can make some tweaks
[10:51:50 EDT(-0400)] <michelled> is that good with you?
[10:51:58 EDT(-0400)] <michelled> we'd need a new JIRA added to the bug parade
[10:52:08 EDT(-0400)] <Justin_o> that should be okay...
[10:52:16 EDT(-0400)] <michelled> thanks
[10:52:23 EDT(-0400)] <Justin_o> no problem
[11:01:19 EDT(-0400)] <Justin_o> michelled, fj4000: http://issues.fluidproject.org/browse/FLUID-2378
[11:01:49 EDT(-0400)] <michelled> thx Justin_o
[11:02:05 EDT(-0400)] <Justin_o> np
[11:33:31 EDT(-0400)] * ecochran (n=ecochran@dhcp-169-229-212-2.LIPS.Berkeley.EDU) has joined #fluid-work
[11:43:56 EDT(-0400)] * EricDalquist (n=dalquist@bohemia.doit.wisc.edu) has joined #fluid-work
[11:48:31 EDT(-0400)] <fj4000> anyone feel like reviewing my commit for 2378?
[12:09:03 EDT(-0400)] <michelled> fj4000: I have a few reviews for you on my todo list. Just trying to get the API for UI Options stable first
[12:09:08 EDT(-0400)] * Justin_o (n=Justin@142.150.154.171) has joined #fluid-work
[12:09:55 EDT(-0400)] <fj4000> cool, thanks
[12:10:10 EDT(-0400)] <fj4000> im just reviewing the list of ui options bugs, seeing where I could be most helpful
[12:12:04 EDT(-0400)] <ecochran> Justin_o: I just found a problem with ARIA in the Uploader that Mr. Clark says should be a blocker
[12:12:27 EDT(-0400)] <ecochran> the ARIA feedback for the total-progress bar got lost
[12:12:36 EDT(-0400)] <ecochran> FLUID-2379
[12:12:47 EDT(-0400)] <Justin_o> ecochran: okay... i'll add that one on to the page...
[12:12:50 EDT(-0400)] <Justin_o> thanks
[12:13:35 EDT(-0400)] <Justin_o> sorry... should have said bug parade instead of page... don't know where that came from
[12:14:01 EDT(-0400)] <ecochran> Justin_o: np
[12:14:40 EDT(-0400)] <ecochran> Justin_o: are all checkins going through patch review, or just big changes?
[12:15:14 EDT(-0400)] <michelled> ecochran - all the check ins for a specific JIRA issue goes through patch review once the issue has been resolved
[12:15:36 EDT(-0400)] <michelled> so you can accumulate a few check ins for a singe issue before getting it reviewed
[12:15:47 EDT(-0400)] <Justin_o> michelled: thanks
[12:15:53 EDT(-0400)] <ecochran> michelled: thanks... even things like linting?
[12:15:58 EDT(-0400)] <ecochran> just checking
[12:15:58 EDT(-0400)] <michelled> I'm likely going to get colinclark to pair with me in order to review the API changes for UI Options and UI Enhancer
[12:16:27 EDT(-0400)] <michelled> well, someone should go through everything that was committed against the linting issue before it gets closed
[12:16:29 EDT(-0400)] <michelled> so yes
[12:17:14 EDT(-0400)] <michelled> fj4000: thanks - let me know if any of the issues are really clear.
[12:17:27 EDT(-0400)] <michelled> and don't forget to update - I'm making quite a few changes.
[12:17:29 EDT(-0400)] <fj4000> michelled: sure
[12:17:32 EDT(-0400)] <fj4000> ok
[12:17:34 EDT(-0400)] <fj4000> thanks
[12:35:04 EDT(-0400)] * lessthanzero (n=FatalRem@CPE001ff342457c-CM001ac352aefc.cpe.net.cable.rogers.com) has joined #fluid-work
[12:46:27 EDT(-0400)] * colinclark (n=colin@bas2-toronto09-1176406320.dsl.bell.ca) has joined #fluid-work
[12:47:15 EDT(-0400)] * colinclark (n=colin@bas2-toronto09-1176406320.dsl.bell.ca) has joined #fluid-work
[12:49:03 EDT(-0400)] <ecochran> colinclark: I have a stumper... I was doing one last check on my updated ARIA code and I noticed that one (and only one) of the 3 aria attributes that I'm changing is not getting changed!
[12:49:51 EDT(-0400)] <colinclark> ecochran: Which one?
[12:50:04 EDT(-0400)] <ecochran> aria-valuetext
[12:50:23 EDT(-0400)] <ecochran> it get initialized
[12:50:27 EDT(-0400)] <ecochran> but doesn't get updated
[12:52:26 EDT(-0400)] <ecochran> colinclark: you're going to love this! it gets init'd to empty ("")
[12:52:29 EDT(-0400)] <colinclark> hmm
[12:52:39 EDT(-0400)] <ecochran> if I change it to init to "foo" then it gets updated
[12:52:56 EDT(-0400)] <colinclark> got code?
[12:53:02 EDT(-0400)] <ecochran> sure do
[12:53:11 EDT(-0400)] <ecochran> want to screenshare
[12:56:07 EDT(-0400)] <ecochran> colinclark: now, I can't reproduce it... grumble
[12:56:24 EDT(-0400)] <ecochran> I switched it back to an empty string and it kept working
[12:57:11 EDT(-0400)] * michelled (n=michelle@CPE001310472ade-CM0011aefd3ca8.cpe.net.cable.rogers.com) has joined #fluid-work
[12:58:50 EDT(-0400)] * EricDalquist (n=dalquist@bohemia.doit.wisc.edu) has joined #fluid-work
[12:59:25 EDT(-0400)] <michelled> fj4000: is there any difference between the table of contents file that you added to the sakai example and the template?
[13:01:56 EDT(-0400)] <michelled> Justin_o: standup?
[13:02:10 EDT(-0400)] <Justin_o> michelled: just loading up your computer
[13:20:11 EDT(-0400)] <colinclark> Justin_o: So it looks like Opera will refuse to save cookies on file:// URLs.
[13:20:26 EDT(-0400)] <colinclark> Have you tried it on the daily build server, and is it still an issue there?
[13:21:50 EDT(-0400)] <fj4000> michelled: not really
[13:21:53 EDT(-0400)] <Justin_o> colinclark: yes
[13:21:58 EDT(-0400)] <Justin_o> it is still an issue there
[13:22:01 EDT(-0400)] <colinclark> how odd
[13:22:14 EDT(-0400)] <fj4000> if there is a better way to pull it in another way, we should do it
[13:22:34 EDT(-0400)] <colinclark> has anyone poked around in the browser's cookies and checked if it's actually being set?
[13:22:52 EDT(-0400)] <Justin_o> jacob and i looked at our cookies and there it wasn't present
[13:23:11 EDT(-0400)] <colinclark> I gather Opera has some kind of advanced cookie management...
[13:23:24 EDT(-0400)] <colinclark> is it possible that it ships by default in a way that forbids cookies from JavaScript?
[13:23:45 EDT(-0400)] <Justin_o> hmm... i'll try to dig into that... it is set to accept all cookies...
[13:24:41 EDT(-0400)] <colinclark> Justin_o: Can you fire me a URL to test with?
[13:24:47 EDT(-0400)] <Justin_o> sure
[13:25:00 EDT(-0400)] <Justin_o> http://build.fluidproject.org/fluid/sample-code/shared/sakai/sakai.html#
[13:27:00 EDT(-0400)] <colinclark> The text box slider seems like it's working strangely...
[13:27:06 EDT(-0400)] <colinclark> I can't type in a number and have it change.
[13:27:10 EDT(-0400)] <colinclark> Perhaps that's a known issue
[13:27:13 EDT(-0400)] <fj4000> michelled: if you dont mind, could you review my commit for 2365 since I think you know a better solution for it anyways
[13:27:36 EDT(-0400)] <Justin_o> colinclark: if you tab out of the textfield it will change, hitting enter won't change it
[13:27:56 EDT(-0400)] <colinclark> ok, so i guess that's a known bug?
[13:29:00 EDT(-0400)] <michelled> fj4000: is that the commit where you added the table of contents file?
[13:29:07 EDT(-0400)] <michelled> it's not yet linked in JIRA
[13:29:12 EDT(-0400)] <michelled> I'll look at that for sure
[13:29:26 EDT(-0400)] <fj4000> michelled: yup
[13:29:30 EDT(-0400)] <michelled> thanks for isolating the issue - makes it easier for me
[13:29:51 EDT(-0400)] <michelled> I'm feeling really overwhelmed with everything that needs to happen with UIOptions and UIEnhancer for bug parade
[13:30:03 EDT(-0400)] <fj4000> michelled: i understand
[13:30:09 EDT(-0400)] <fj4000> every time I look at the list
[13:30:17 EDT(-0400)] <fj4000> I want to crawl into a cave
[13:30:32 EDT(-0400)] <Justin_o> michelled, fj4000: I'm sorry...
[13:30:37 EDT(-0400)] <fj4000> lol
[13:30:42 EDT(-0400)] <michelled> ha
[13:30:50 EDT(-0400)] <anastasiac> Justin_o: I've reviewed FLUID-2304, and commented on the JIRA - looks good.
[13:30:51 EDT(-0400)] <fj4000> better to find the bugs now, than in production!
[13:31:01 EDT(-0400)] <Justin_o> anastasiac: thanks
[13:31:06 EDT(-0400)] <michelled> for sure!
[13:31:15 EDT(-0400)] <Justin_o> definitely
[13:31:19 EDT(-0400)] <colinclark> michelled: Sounds like it's time to cut back your feature set.
[13:31:22 EDT(-0400)] <michelled> I only want to bring UI Options out of Preview if it's really solid
[13:31:36 EDT(-0400)] <colinclark> No reason to feel overwhelmed, so focus on the things you can make solid and forget the rest if you need to.
[13:32:08 EDT(-0400)] <michelled> colinclark - there are still several days of bug parade left. and some bugs are ok to ship with.
[13:32:30 EDT(-0400)] <colinclark> totally
[13:32:56 EDT(-0400)] * clown (n=clown@142.150.154.101) has joined #fluid-work
[13:35:11 EDT(-0400)] <anastasiac> michelled, I've had a look at the UI Enhancer API page
[13:35:11 EDT(-0400)] <Justin_o> michelled: i am looking at the code for the cookie... is it a sub component
[13:35:16 EDT(-0400)] <anastasiac> the structure looks good
[13:35:27 EDT(-0400)] <anastasiac> I think it will need some more text explaining a few things
[13:35:50 EDT(-0400)] <anastasiac> also: I'm not sure if the dependencies are right - I imagine it depends on its own file? (wink)
[13:35:57 EDT(-0400)] <michelled> Justin_o: yes, a sub component
[13:35:58 EDT(-0400)] <anastasiac> and not sure it depends on UIOptions.js
[14:17:53 EDT(-0400)] <fj4000> michelled: is it ok if I investigate FLUID-2347
[14:56:29 EDT(-0400)] * michelled (n=michelle@CPE001310472ade-CM0011aefd3ca8.cpe.net.cable.rogers.com) has joined #fluid-work
[14:57:26 EDT(-0400)] <michelled> anastasiac: sorry I didn't notice your earlier comments
[14:57:34 EDT(-0400)] <anastasiac> michelled, np
[14:57:40 EDT(-0400)] <michelled> yes, I didn't actually get to the dependencies part of the API page
[14:57:50 EDT(-0400)] <michelled> I was more interested in the naming and the actually API
[14:57:53 EDT(-0400)] <anastasiac> k, I thought that might be the case
[14:58:06 EDT(-0400)] <michelled> there is certainly lots of text that still needs to be written
[14:58:16 EDT(-0400)] <michelled> it might happen after bug parade
[14:58:22 EDT(-0400)] <anastasiac> indeed (smile)
[15:08:24 EDT(-0400)] <fj4000> athena: I have some content for you, if your ready to discuss it
[15:08:31 EDT(-0400)] <fj4000> pls ping me when you have the chance
[15:09:30 EDT(-0400)] <athena> hey
[15:10:29 EDT(-0400)] <colinclark> Justin_o: Eli and I have done some code clean up and minor refactoring for an issue he committed right before bug parade...
[15:10:34 EDT(-0400)] <colinclark> FLUID-2355
[15:11:11 EDT(-0400)] <colinclark> Now, it is a little more than linting, but largely just helps make the code cleaner and more maintainable.
[15:11:24 EDT(-0400)] <colinclark> How should I handle this patch for bug parade?
[15:25:17 EDT(-0400)] <michelled> laurelw: are you thinking of putting UI Options into the website?
[15:32:15 EDT(-0400)] <Justin_o> colinclark: sorry... just got back from talking with clown
[15:32:20 EDT(-0400)] <colinclark> np
[15:33:11 EDT(-0400)] <Justin_o> colinclark: i guess i'll talk to you about your question first and then I have a question for you as well
[15:33:56 EDT(-0400)] <colinclark> ok, sure
[15:34:02 EDT(-0400)] <colinclark> whichever one is more important
[15:34:39 EDT(-0400)] <Justin_o> hmm... so it was basically code clean up
[15:35:34 EDT(-0400)] <colinclark> Yeah, it's code cleanup, some refactoring. Removing some stray dom fascism and generally just simplifying things
[15:35:48 EDT(-0400)] <colinclark> A big method broken out into a couple of smaller ones, some renaming, etc.
[15:35:57 EDT(-0400)] <michelled> sounds like some good changes
[15:37:27 EDT(-0400)] <Justin_o> colinclark: hmm.. it does sound good... did you want me to create a seperate jira for it... or do you think it could still fit in the realm of the general code cleanup
[15:37:57 EDT(-0400)] <colinclark> No, I think we should probably have a separate JIRA for it, or perhaps file it under the 2355 issue.
[15:38:01 EDT(-0400)] <colinclark> let me just look that one up again
[15:38:54 EDT(-0400)] <colinclark> http://issues.fluidproject.org/browse/FLUID-2355
[15:39:02 EDT(-0400)] <colinclark> It's still open.
[15:39:17 EDT(-0400)] <colinclark> I suspect we're going to hear from either Erin or Daphne that they want a "resume all" button added before this feature is finished
[15:39:21 EDT(-0400)] <colinclark> So it's probably bug parade fodder.
[15:39:32 EDT(-0400)] <colinclark> I'll trade you FLUID-2355 for the Flash-related issues. (wink)
[15:40:00 EDT(-0400)] <Justin_o> seems fare... that's something like 1 for 4
[15:40:02 EDT(-0400)] <colinclark> And michelled, I'll trade you some more tests on UIOptions for reviewing this patch when it's ready
[15:40:15 EDT(-0400)] <colinclark> Justin_o: It's a good deal. (smile)
[15:40:56 EDT(-0400)] <michelled> sounds good colinclark
[15:41:42 EDT(-0400)] <michelled> I sent a summary of our conversation (Justin_o and fj4000) to the list
[15:41:52 EDT(-0400)] <Justin_o> michelled: thanks
[15:41:56 EDT(-0400)] <michelled> np
[15:41:59 EDT(-0400)] <fj4000> saw it
[15:42:00 EDT(-0400)] <fj4000> thanks
[15:42:25 EDT(-0400)] <colinclark> thanks, i look forward to reading it... sorry i had to bail from the meeting
[15:42:26 EDT(-0400)] <michelled> please chime in if I missed stuff or wasn't clear
[15:42:40 EDT(-0400)] <michelled> thanks for forcing us to meet colinclark (wink)
[15:42:51 EDT(-0400)] <colinclark> (wink)
[15:43:40 EDT(-0400)] <Justin_o> colinclark: i'll update the bug parade shortly... to add this jira and remove those other uploader ones
[15:43:50 EDT(-0400)] <colinclark> great, thanks
[15:44:01 EDT(-0400)] <colinclark> there might be one other we have a patch for...
[15:44:06 EDT(-0400)] <colinclark> let me just check before you remove them all
[15:44:16 EDT(-0400)] <Justin_o> okay... let me know when you're ready
[15:44:26 EDT(-0400)] <colinclark> eli has been waiting on me to review a patch where we add an ARIA labelledby property to the flash button
[15:44:27 EDT(-0400)] <Justin_o> I also wanted to talk to you about something I was speaking to the clown about
[15:44:34 EDT(-0400)] <colinclark> it won't fix the issue, but is a good start
[15:44:37 EDT(-0400)] <colinclark> sure, fire away
[15:44:42 EDT(-0400)] <Justin_o> sounds like a good start.
[15:44:47 EDT(-0400)] <Justin_o> okay... well similar thing act ually
[15:44:56 EDT(-0400)] <Justin_o> http://issues.fluidproject.org/browse/FLUID-2376
[15:44:58 EDT(-0400)] <michelled> anyone mind if I rebuild the nightly?
[15:45:06 EDT(-0400)] <Justin_o> michelled: i don't mind
[15:45:40 EDT(-0400)] <Justin_o> colinclark: basically the aria spec has changed the names from grab to grabbed and also the states
[15:46:01 EDT(-0400)] <colinclark> yack!
[15:46:06 EDT(-0400)] <colinclark> what's supported in Firefox 3.0?
[15:46:13 EDT(-0400)] <colinclark> -grab or -grabbed?
[15:46:31 EDT(-0400)] <Justin_o> from what I gathered in the conversation is that currently they are both supported
[15:46:36 EDT(-0400)] <colinclark> aha
[15:46:41 EDT(-0400)] <colinclark> and in ff 2?
[15:46:45 EDT(-0400)] <colinclark> any support for it?
[15:47:14 EDT(-0400)] <Justin_o> have to double check on that one, but maybe not, since it is unsupported by mozilla now.
[15:47:26 EDT(-0400)] <Justin_o> so i'm guessing... that if it isn't supported in FF2 we should hold off
[15:48:24 EDT(-0400)] <Justin_o> if we do go ahead with this, clown said he would work on it
[15:48:48 EDT(-0400)] <Justin_o> he also suggested unit tests for aria support, but won't be able to help with that for the end of bug parade
[15:52:09 EDT(-0400)] <colinclark> one sec, sorry for the delay
[15:52:17 EDT(-0400)] <Justin_o> np
[16:03:09 EDT(-0400)] <Justin_o> my mail.app is not liking me much today... is anyone having problems with the bug parade updates that I have been sending out... fj4000 has for, anyone else
[16:04:02 EDT(-0400)] <fj4000> Justin_o: im just getting cut off mail....hopefully my migration helps
[16:05:05 EDT(-0400)] <Justin_o> fj4000: that's good... right now my mail.app is trying to hypnotize me with a spinning beach ball
[16:20:55 EDT(-0400)] <michelled> evil mail app - DO NOT HYPNOTIZE THE KING
[16:21:23 EDT(-0400)] <michelled> Justin_o - the last update I got from you was 10
[16:21:37 EDT(-0400)] <Justin_o> did it look okay?
[16:21:56 EDT(-0400)] <michelled> yes
[16:22:18 EDT(-0400)] <michelled> fj4000: I just committed a fix for 2365. can you test it and code review it?
[16:23:54 EDT(-0400)] <fj4000> I will try - im just trying to get some patches to justin to test
[16:24:05 EDT(-0400)] <Justin_o> michelled: that's good... after fighting with the bug parade, i think i have it under control now... i'll be sending out an update after going over those uploader things with colin
[16:24:10 EDT(-0400)] <michelled> no rush. I assigned it to you
[16:24:36 EDT(-0400)] <michelled> I just thought it would make sense for you to code review it since you started the fix
[16:37:50 EDT(-0400)] <Justin_o> michelled: have you noticed that opera is throwing errors whenever you change an option now
[16:45:00 EDT(-0400)] <michelled> nope - I don't test regularly in opera
[16:46:34 EDT(-0400)] <michelled> (sad)
[16:49:00 EDT(-0400)] <fj4000> michelled: i tested your commit for 2365 - the table of contents bug, right?
[16:49:09 EDT(-0400)] <michelled> ya
[16:49:19 EDT(-0400)] <fj4000> it seems im getting the old 404 again
[16:51:42 EDT(-0400)] <michelled> really? glarg
[16:52:06 EDT(-0400)] <fj4000> it looks like it
[16:52:11 EDT(-0400)] <michelled> I think you'll have to show me tomorrow. It works fine on my machine. Perhaps we should rebuild the nightly and see if it works there
[16:52:26 EDT(-0400)] <fj4000> let me see if Im running in server mode or not
[16:52:29 EDT(-0400)] <fj4000> it could be me
[16:53:31 EDT(-0400)] <fj4000> ach
[16:53:40 EDT(-0400)] <fj4000> I think I see something michelled : the path
[16:53:56 EDT(-0400)] <michelled> which path?
[16:53:57 EDT(-0400)] <colinclark> Justin_o: I looked at the Uploader Flash JIRAs, and we don't quite have one for this particular issue.
[16:53:57 EDT(-0400)] <fj4000> its looking for:
[16:53:58 EDT(-0400)] <fj4000> FLUID-trunk/src/fluid-components/html/templates/TableOfContents.html
[16:54:07 EDT(-0400)] <fj4000> and I have
[16:54:08 EDT(-0400)] <fj4000> FLUID-trunk/src/webapp/fluid-components/html/templates/TableOfContents.html
[16:54:21 EDT(-0400)] <fj4000> its the "webapp" folder
[16:54:26 EDT(-0400)] <fj4000> its missing for me
[16:54:31 EDT(-0400)] <colinclark> At the moment, we've ones related to keyboard a11y, etc. This is a workaround that might provide better spoken feedback about the flash button to AT users with Firefox.
[16:54:37 EDT(-0400)] <michelled> that shouldn't be hardcoded anywhere
[16:54:43 EDT(-0400)] <michelled> I used a relative path
[16:54:44 EDT(-0400)] <fj4000> thats what Im thinking
[16:54:49 EDT(-0400)] <fj4000> so im very confused now
[16:54:54 EDT(-0400)] <colinclark> Let's boot the existing Flash-related JIRAs, and if this patch shows any promise, we can add a specific issue to the bug parade for it.
[16:54:58 EDT(-0400)] <colinclark> Justin_o: Seem reasonable?
[16:55:07 EDT(-0400)] <fj4000> colinclark: hes in a meeting
[16:55:19 EDT(-0400)] <colinclark> fj4000: ok, thanks
[16:55:24 EDT(-0400)] <colinclark> he'll see this when he gets back
[16:55:36 EDT(-0400)] <colinclark> sorry for confusing you with other comments in the midst of your conversation
[16:55:37 EDT(-0400)] <colinclark> (tongue)
[16:55:52 EDT(-0400)] <fj4000> (tongue) like you said, its the nature of the beast
[16:56:06 EDT(-0400)] <fj4000> michelled: any ideas how the path could change like that/
[16:56:08 EDT(-0400)] <fj4000> ?
[16:56:45 EDT(-0400)] <michelled> no, perhaps you can look for a path that contains webapp. But I don't recall a path like that.
[16:58:14 EDT(-0400)] <michelled> I going offline for a bit. if you're still seeing the issue tomorrow we can look at it together.
[17:03:11 EDT(-0400)] <Justin_o> colinclark: sorry... just talking to clown again about the aria stuff
[17:03:18 EDT(-0400)] <colinclark> Justin_o: No worries
[17:04:14 EDT(-0400)] <colinclark> so as for that aria stuff...
[17:04:14 EDT(-0400)] <Justin_o> it seems like the aria stuff i mentioned to you before will be a bigger issue when IE8 and safari 4 come out. as they won't support the old style
[17:04:20 EDT(-0400)] <colinclark> aha
[17:04:21 EDT(-0400)] <colinclark> ok
[17:04:38 EDT(-0400)] <colinclark> If we were to hold off on it until Infusion 1.1, do you foresee any problems?
[17:04:45 EDT(-0400)] <colinclark> or 1.01 or whatever we'll call the next release
[17:05:08 EDT(-0400)] <Justin_o> i think it will be okay.
[17:05:19 EDT(-0400)] <colinclark> I'm of two minds about this... on one hand, it's a pretty serious issue.
[17:05:28 EDT(-0400)] <colinclark> On the other hand, it doesn't affect any of our A-Grade browsers.
[17:05:35 EDT(-0400)] <colinclark> So it's one of these ticking clocks...
[17:05:42 EDT(-0400)] <colinclark> The longer we wait, the worse it gets
[17:05:54 EDT(-0400)] <colinclark> In my mind, it's a nice one to have.
[17:06:07 EDT(-0400)] <colinclark> If clown thinks he has the cycles to implement it, that would be awesome.
[17:06:27 EDT(-0400)] <colinclark> I think most committers are stretched pretty thin at the moment, so my only fear is pairing him up with a friend to help with the owrk.
[17:06:33 EDT(-0400)] <Justin_o> so did you want to have it on the bug parade and assigned to clown
[17:06:34 EDT(-0400)] <clown> colinclark, Justin_o: I'm going to ask David about the nature of support for aria-grab/aria-grabbed in FF2.
[17:06:39 EDT(-0400)] <Justin_o> if he doesn'
[17:06:44 EDT(-0400)] <colinclark> clown: That'd be great.
[17:06:57 EDT(-0400)] <Justin_o> clown: thanks
[17:07:01 EDT(-0400)] <colinclark> Justin_o: Put it on the bug parade. If clown has time to rock it, we'll be insanely happy.
[17:07:06 EDT(-0400)] <clown> alas, he's not online at the moment – will try again tomorrow morning.
[17:07:07 EDT(-0400)] <colinclark> If not, it can be postponed for next release.
[17:07:11 EDT(-0400)] <colinclark> No worries.
[17:07:17 EDT(-0400)] <Justin_o> sounds good to me
[17:07:18 EDT(-0400)] <Justin_o> thanks
[17:07:24 EDT(-0400)] <clown> what am I rocking?
[17:07:32 EDT(-0400)] <clown> who's baby?
[17:07:32 EDT(-0400)] <Justin_o> that other jira you filed
[17:07:37 EDT(-0400)] <clown> ah, okay.
[17:07:37 EDT(-0400)] <Justin_o> about aria grabbed
[17:08:10 EDT(-0400)] <colinclark> lol
[17:09:18 EDT(-0400)] <Justin_o> colinclark: I'm going to slip in FLUID-2379 into the bug parade as well. I think we may have talked about this before, but I can't remember
[17:11:17 EDT(-0400)] <colinclark> Justin_o: Definitely. That's a show stopper if I've ever seen one.
[17:11:35 EDT(-0400)] <colinclark> And tremendously embarrassing. I'm so sorry for that regression.
[17:12:26 EDT(-0400)] <Justin_o> no problem... i'm going to send out an update to the bug parade shortly and then call it a night
[17:20:32 EDT(-0400)] <Justin_o> colinclark: can you add the aria role to the flash button as part of FLUID-2379 or does it need a new one
[17:21:41 EDT(-0400)] <colinclark> FLUID-2379 is more specific, but we could just expand it to include the labelledby property
[17:21:47 EDT(-0400)] <colinclark> we're still not certain this will work, but it's worth a shot
[17:23:05 EDT(-0400)] <Justin_o> i agree... definitely worth a shot... i think i'll just add a comment to expand FLUID-2379 so the bug parade list doesn't seem as long (tongue)
[17:24:16 EDT(-0400)] <colinclark> Justin_o: great, thanks
[17:24:27 EDT(-0400)] <Justin_o> no problem
[17:27:35 EDT(-0400)] * Justin_o (n=Justin@142.150.154.171) has left #fluid-work
[17:52:03 EDT(-0400)] * clown (n=clown@142.150.154.101) has left #fluid-work
[18:32:24 EDT(-0400)] * EricDalquist (n=dalquist@bohemia.doit.wisc.edu) has joined #fluid-work
[18:52:20 EDT(-0400)] * fj40001 (n=Jacob@142.150.154.106) has joined #fluid-work
[20:01:12 EDT(-0400)] * EricDalquist (n=EricDalq@adsl-76-208-69-153.dsl.mdsnwi.sbcglobal.net) has joined #fluid-work
[22:12:35 EDT(-0400)] * colinclark (n=colin@bas2-toronto09-1176406320.dsl.bell.ca) has joined #fluid-work
[23:09:15 EDT(-0400)] * colinclark (n=colin@bas2-toronto09-1176406320.dsl.bell.ca) has joined #fluid-work