fluid-work IRC Logs-2009-03-16

fluid-work IRC Logs-2009-03-16

[04:00:04 EDT(-0400)] * jayshao (n=jayshao@ool-45731411.dyn.optonline.net) has joined #fluid-work
[08:10:32 EDT(-0400)] * athena (n=athena@99.129.100.66) has joined #fluid-work
[08:33:09 EDT(-0400)] * laurelw (n=Laurel@142.150.154.178) has joined #fluid-work
[08:56:30 EDT(-0400)] * Justin_o (n=Justin@142.150.154.171) has joined #fluid-work
[09:00:27 EDT(-0400)] * anastasiac (n=stasia@142.150.154.189) has joined #fluid-work
[09:16:12 EDT(-0400)] * fj4000 (n=Jacob@142.150.154.106) has joined #fluid-work
[09:38:31 EDT(-0400)] * clown (n=clown@142.150.154.101) has joined #fluid-work
[09:44:04 EDT(-0400)] * michelled (n=team@142.150.154.193) has joined #fluid-work
[09:45:51 EDT(-0400)] * colinclark (n=colin@bas2-toronto09-1176406320.dsl.bell.ca) has joined #fluid-work
[09:51:17 EDT(-0400)] <colinclark> heya
[09:51:26 EDT(-0400)] <colinclark> Justin_o: Quick question for you.
[09:51:31 EDT(-0400)] <Justin_o> colinclark: sure
[09:51:34 EDT(-0400)] <colinclark> Your email to Eli about Upoader...
[09:51:38 EDT(-0400)] <Justin_o> yes
[09:51:49 EDT(-0400)] <colinclark> You said "It looks to me like it last pulled code on February 20."
[09:51:56 EDT(-0400)] <Justin_o> yes
[09:52:15 EDT(-0400)] <colinclark> Does that just mean that changes haven't been made to Uploader between Feb. 20 and last week when you did the upgrade?
[09:54:22 EDT(-0400)] <Justin_o> um.... hmm... well what i mean is that from continuum it appears to be building the uploader server version, but the last version of code that it pulled in for uploader seems to have been on February 20... for example the updates that Eli made to progress.js on February 26 and onward aren't there
[09:55:07 EDT(-0400)] <Justin_o> it is also still pointing at 1.3.1 as well
[09:55:45 EDT(-0400)] <colinclark> Justin_o: Meaning the build is broken?
[09:56:26 EDT(-0400)] <colinclark> Hey, on another note, are you guys going to meet in Breeze in a few minutes to welcome Jonathan back?
[09:56:39 EDT(-0400)] <colinclark> anastasiac, michelled, Justin_o, etc.
[09:56:52 EDT(-0400)] * EricDalquist (n=dalquist@bohemia.doit.wisc.edu) has joined #fluid-work
[09:57:08 EDT(-0400)] <Justin_o> yes to the first question... sure for the second one... maybe we could do a mini standup ?
[09:57:44 EDT(-0400)] <anastasiac> colinclark - breeze is good
[09:57:55 EDT(-0400)] <colinclark> Justin_o: Yeah, that would be cool
[09:58:23 EDT(-0400)] <Justin_o> colinclark: as for it not pointing at 1.3.2... i guess this may be because i needed to update something somewhere else besides trunk and missed it
[09:58:40 EDT(-0400)] <colinclark> hmmm
[09:58:49 EDT(-0400)] <colinclark> Justin_o: Yes, the image-gallery needs to be updated
[09:59:15 EDT(-0400)] <colinclark> In fact, it should be broken if it was actually pulling in changes from components trunk
[09:59:41 EDT(-0400)] <Justin_o> ah okay...
[10:00:12 EDT(-0400)] <Justin_o> i'll have to find out how to update the image-gallery
[10:59:16 EDT(-0400)] * colinclark (n=colin@142.150.154.101) has joined #fluid-work
[11:20:13 EDT(-0400)] * ecochran (n=ecochran@adsl-70-137-150-13.dsl.snfc21.sbcglobal.net) has joined #fluid-work
[11:32:31 EDT(-0400)] <colinclark> Justin_o, ecochran: Okay, I've figured out the problem with the image-gallery linking against an old version of Infusion.
[11:33:05 EDT(-0400)] <colinclark> When we cut the 0.8 release, we upgraded our Maven version number to 1.0-SNAPSHOT, but we forgot to update the gallery's pom.xml file.
[11:33:18 EDT(-0400)] <colinclark> So it's doing exactly what it's told... using the release version of Infusion 0.8.
[11:33:23 EDT(-0400)] <colinclark> oops
[11:35:26 EDT(-0400)] <colinclark> I'll update both the pom file and AddImages.html, which is importing the old version of jquery as well.
[11:36:10 EDT(-0400)] <ecochran> colinclark: let me know when it's up
[11:38:12 EDT(-0400)] <colinclark> ecochran: Yeah, I also double checked the Release Process document and it does mention this, so that's good.
[11:38:32 EDT(-0400)] <ecochran> colinclark: sorry that I didn't make the checkin
[11:38:38 EDT(-0400)] <colinclark> no worries
[11:38:40 EDT(-0400)] <colinclark> it's easy to forget
[11:40:56 EDT(-0400)] <ecochran> colinclark, Justin_o : OK, the crash was introduced in revision 6621, the latest
[11:41:13 EDT(-0400)] * jayshao_ (n=jayshao@ool-45731411.dyn.optonline.net) has joined #fluid-work
[11:41:22 EDT(-0400)] <ecochran> so now I can focus a bit
[11:41:53 EDT(-0400)] <ecochran> that revision was pretty much just adding some style to the total progress bar, interesting.
[11:45:44 EDT(-0400)] * jayshao_ (n=jayshao@ool-45731411.dyn.optonline.net) has joined #fluid-work
[11:53:20 EDT(-0400)] <colinclark> ecochran: Ok, code is in. I'm rebuilding the gallery now.
[12:02:09 EDT(-0400)] <colinclark> ecochran: Build is updated. I can't reproduce the issue you're seeing.
[12:03:08 EDT(-0400)] <ecochran> colinclark: OK, I can
[12:03:16 EDT(-0400)] <ecochran> so it's something with my FF, not my build
[12:03:19 EDT(-0400)] <colinclark> ah, but i'm using flash 9
[12:03:26 EDT(-0400)] <ecochran> OK, try Flash 10
[12:03:29 EDT(-0400)] <colinclark> i'll try it in my VM
[12:03:35 EDT(-0400)] <ecochran> it's definitely Flash 10
[12:03:41 EDT(-0400)] <ecochran> thanks
[12:04:15 EDT(-0400)] <ecochran> I thank you, my FF thanks you (poor baby, falsely impugned)
[12:04:57 EDT(-0400)] <ecochran> colinclark: I think that I've figured it out
[12:05:26 EDT(-0400)] <ecochran> colinclark and Justin_o : what is causing the crash is that I'm changing the class of the container of the Flash object
[12:05:35 EDT(-0400)] <ecochran> I've narrowed the crash down to that bit of code
[12:05:52 EDT(-0400)] <colinclark> Line number?
[12:07:57 EDT(-0400)] <ecochran> colinclark: 394
[12:08:18 EDT(-0400)] <ecochran> more like the parent's parent
[12:08:28 EDT(-0400)] <ecochran> looking at it now a little more closely
[12:08:36 EDT(-0400)] <ecochran> Uploader.js
[12:08:38 EDT(-0400)] <colinclark> what file?
[12:08:42 EDT(-0400)] <colinclark> ah
[12:08:43 EDT(-0400)] <colinclark> thanks
[12:09:19 EDT(-0400)] <colinclark> There's a bug on that line of code...
[12:09:23 EDT(-0400)] <colinclark> but it wouldn't cause the error.
[12:10:00 EDT(-0400)] <colinclark> The DOM Binder always passes you back a jQuery instance, so you needn't wrap in a $() call
[12:10:14 EDT(-0400)] * michelled loves the DOM Binder
[12:11:06 EDT(-0400)] <ecochran> colinclark: missed that
[12:14:16 EDT(-0400)] * apetro (n=apetro@wsip-98-174-242-39.ph.ph.cox.net) has joined #fluid-work
[12:18:30 EDT(-0400)] <ecochran> colinclark: have any good ideas? could this be a race condition between us manipulating the DOM and the Flash component being refreshed by SWFUpload?
[12:18:53 EDT(-0400)] <ecochran> sad that the only manipulation that we're doing is changing a class name.
[12:19:06 EDT(-0400)] <ecochran> brb
[12:26:58 EDT(-0400)] <ecochran> colinclark: I think that the actual blow up is happening on line 412, same thing just at a different point in the flow
[12:28:15 EDT(-0400)] <colinclark> ecochran: So remind me why this code changed?
[12:28:50 EDT(-0400)] <ecochran> colinclark: adding a style to the totalprogress bar to indicate that the progress completed per the storyboard
[12:29:15 EDT(-0400)] <ecochran> the line that offends is a line that switches it back when we start uploading again
[12:41:40 EDT(-0400)] <ecochran> colinclark: if I step through, it doesn't seem to crash, just gets stuck without good feedback when I call the Flash file
[12:47:51 EDT(-0400)] <colinclark> ecochran: Today's your last day to work on features.
[12:48:10 EDT(-0400)] <colinclark> So check the time and make a call on whether you think this is good parade material, or if you have to fix it now to keep going.
[12:49:06 EDT(-0400)] <ecochran> colinclark: yep... it's just making it hard to work on the error code... so I'll have to comment out the problem and then come back to it instead of leave it in
[12:49:44 EDT(-0400)] <colinclark> ecochran: That sounds wise, yes.
[12:50:14 EDT(-0400)] <colinclark> I can't get it to crash my browser on FF3/Flash 10/Windows XP, but it does cause things to hang in the classic SWFUpload sort of way.
[12:50:40 EDT(-0400)] <ecochran> colinclark: that's better
[12:50:46 EDT(-0400)] <colinclark>
[12:51:00 EDT(-0400)] <ecochran> so that Mac is the crasher
[12:51:18 EDT(-0400)] <ecochran> OK, moving on... grumble grumble grumble
[13:04:07 EDT(-0400)] <michelled> standup anyone? echochran?
[13:04:19 EDT(-0400)] <michelled> ecochran ^
[13:04:59 EDT(-0400)] <ecochran> yep, sorry
[13:05:14 EDT(-0400)] <michelled> np
[13:09:06 EDT(-0400)] * apetro_ (n=apetro@wsip-98-174-242-39.ph.ph.cox.net) has joined #fluid-work
[14:01:16 EDT(-0400)] * Topic is 'Bug Parade Tomorrow!' set by michelled on 2009-03-16 14:01:16 EDT(-0400)
[14:12:28 EDT(-0400)] <colinclark> Hey everyone...
[14:12:44 EDT(-0400)] <colinclark> Bosmon and I were just talking about the semantics for Infusion's preventable events.
[14:13:05 EDT(-0400)] <colinclark> When we wrote the API initially, we got it backwards.
[14:13:27 EDT(-0400)] <colinclark> If you are writing an event handler that wants to prevent an event from occurring, you return boolean true from it.
[14:13:41 EDT(-0400)] <colinclark> The DOM does this the other way...
[14:14:03 EDT(-0400)] <colinclark> an event returns boolean false if it wants to prevent bubbling and stop propagation.
[14:14:54 EDT(-0400)] <colinclark> So we are floating the idea of flipping the API to be consistent with the DOM for Infusion 1.0
[14:14:58 EDT(-0400)] <colinclark> This is a big API change, to be fair.
[14:15:12 EDT(-0400)] <colinclark> But I think it makes sense, and our own use of preventable events is extremely limited.
[14:15:26 EDT(-0400)] <colinclark> So it's probably not going to have a huge impact on our users.
[14:15:33 EDT(-0400)] <colinclark> Any thoughts/complaints/etc?
[14:15:40 EDT(-0400)] * Bosmon (n=Bosmon@bas2-toronto09-1176406320.dsl.bell.ca) has joined #fluid-work
[14:15:55 EDT(-0400)] <colinclark> michelled, anastasiac, fj4000, etc. ? ^
[14:16:22 EDT(-0400)] * fj4000 just reading up
[14:16:53 EDT(-0400)] <michelled> that makes sense to me
[14:16:59 EDT(-0400)] <fj4000> this makes waay more sense
[14:17:05 EDT(-0400)] <anastasiac> I vaguely remember thinking that "true" for prevent seemed a bit backward
[14:17:12 EDT(-0400)] <Bosmon> Ah well
[14:17:24 EDT(-0400)] <Bosmon> Somehow, it was what I thought I remembered, of the DOM model
[14:17:26 EDT(-0400)] <fj4000> going forward, it would help on the uptake
[14:18:48 EDT(-0400)] <Bosmon> The only place of interest is the "editHandler" for InlineEdit
[14:18:53 EDT(-0400)] <anastasiac> we'd have to ensure that this change is clearly and prominantly mentioned in the readme, etc.
[14:19:00 EDT(-0400)] <Bosmon> It has various return values, which,I guess noone has ever paid attention to
[14:20:17 EDT(-0400)] <Bosmon> For example, when we call it ourselves, we do this
[14:20:17 EDT(-0400)] <Bosmon> that.edit();
[14:20:18 EDT(-0400)] <Bosmon> return false;
[14:20:49 EDT(-0400)] <Bosmon> Similarly in "finish"
[14:21:38 EDT(-0400)] <Bosmon> Somewhat unhappily, I have flipped all these values round, and the tests all pass....
[14:24:57 EDT(-0400)] <Bosmon> fj4000 may be interested in this comment I just read in a mail thread: "Interesting fact: First
[14:24:57 EDT(-0400)] <Bosmon> Direct now run two ways of accessing accounts, one for IE and one for
[14:24:57 EDT(-0400)] <Bosmon> Web browsers."
[14:25:20 EDT(-0400)] <fj4000> wtf?!
[14:26:23 EDT(-0400)] <fj4000> is that http://www.firstdirect.com/ ?
[14:27:08 EDT(-0400)] <Bosmon> Probably, yes
[14:27:08 EDT(-0400)] <fj4000> if so, we need to get some ppl over there to slap them around
[14:27:23 EDT(-0400)] <Bosmon> Why?
[14:27:52 EDT(-0400)] <fj4000> they shouldnt even consider IE in the first place
[14:27:57 EDT(-0400)] <Bosmon> !
[14:28:00 EDT(-0400)] <fj4000> just stick to "web browsers"
[14:28:06 EDT(-0400)] <Bosmon> ha
[14:59:54 EDT(-0400)] * ecochran (n=ecochran@dwin-wlan-17.AirBears.Berkeley.EDU) has joined #fluid-work
[15:37:12 EDT(-0400)] * ecochran (n=ecochran@dwin-wlan-17.AirBears.Berkeley.EDU) has joined #fluid-work
[15:37:46 EDT(-0400)] * ecochran_ (n=ecochran@dhcp-169-229-212-2.LIPS.Berkeley.EDU) has joined #fluid-work
[15:50:47 EDT(-0400)] * ecochran_ (n=ecochran@dhcp-169-229-212-2.LIPS.Berkeley.EDU) has joined #fluid-work
[16:16:27 EDT(-0400)] * laurelw (n=Laurel@142.150.154.178) has left #fluid-work
[19:55:57 EDT(-0400)] * colinclark (n=colin@bas2-toronto09-1176406320.dsl.bell.ca) has joined #fluid-work
[22:48:29 EDT(-0400)] * Bosmon (n=Bosmon@bas2-toronto09-1176406320.dsl.bell.ca) has left #fluid-work