fluid-work IRC Logs-2009-03-20

Owned by Fluid IRC Log Bot
Last updated: Mar 20, 2009Version comment
16 min read

[08:21:06 EDT(-0400)] * laurelw (n=Laurel@142.150.154.178) has joined #fluid-work
[08:25:07 EDT(-0400)] * laurelw (n=Laurel@142.150.154.178) has left #fluid-work
[08:36:44 EDT(-0400)] * Justin_o (n=Justin@142.150.154.171) has joined #fluid-work
[08:53:55 EDT(-0400)] * anastasiac (n=stasia@142.150.154.189) has joined #fluid-work
[08:55:55 EDT(-0400)] * fj4000 (n=Main@CPE0018f85ab63e-CM001692f5798c.cpe.net.cable.rogers.com) has joined #fluid-work
[09:05:29 EDT(-0400)] <fj4000> Justin_o: I just verified 2385 as "magically done"
[09:05:39 EDT(-0400)] <fj4000> I cant reproduce on my IE6 anymore
[09:05:53 EDT(-0400)] <fj4000> that sounded wierd
[09:08:58 EDT(-0400)] <fj4000> As well, can we discuss the scope of 2121? I think we can make a compromise there
[09:16:16 EDT(-0400)] <Justin_o> hi... let me just take a look at 2121
[09:16:40 EDT(-0400)] <Justin_o> fj4000: what were your thoughts
[09:17:11 EDT(-0400)] <fj4000> if you open the dialog now, it focuses the close button
[09:17:31 EDT(-0400)] <fj4000> from there, you can easily focus the contents
[09:17:49 EDT(-0400)] <fj4000> is that going to be "good enough"?
[09:18:39 EDT(-0400)] <Justin_o> fj4000: I was talking with clown yesterday about that, and he felt that it should probably be on the accordion
[09:19:05 EDT(-0400)] <fj4000> ok, then we need to write some post-render function to do this
[09:19:25 EDT(-0400)] <fj4000> since the content doest exist at the time the dialog is instantiated, i dont think
[09:19:26 EDT(-0400)] <Justin_o> to push focus
[09:19:40 EDT(-0400)] <Justin_o> because of the ajax call?
[09:20:00 EDT(-0400)] <fj4000> more than the ajax call, once that is complete, the renderer is called
[09:20:15 EDT(-0400)] <fj4000> and once that is done, then we have our accordion with options
[09:20:29 EDT(-0400)] <Justin_o> The accordion should exist though, cause it contains the html template for the renderer
[09:20:37 EDT(-0400)] <fj4000> thats the time we can put focus where it belongs, I think
[09:20:40 EDT(-0400)] <fj4000> ok, let me take a peek
[09:21:01 EDT(-0400)] <Justin_o> i guess it would be the header for the accordion should exist
[09:21:08 EDT(-0400)] <Justin_o> it may not be an accordion yet
[09:21:20 EDT(-0400)] * athena (n=athena@99.129.100.66) has joined #fluid-work
[09:27:37 EDT(-0400)] <Justin_o> fj4000: how is going?
[09:28:01 EDT(-0400)] <fj4000> how is what going?
[09:28:10 EDT(-0400)] <Justin_o> 2121
[09:28:20 EDT(-0400)] <Justin_o> you were taking a look at the code i guess
[09:28:55 EDT(-0400)] <fj4000> im still working on it
[09:29:03 EDT(-0400)] <Justin_o> okay...
[09:29:06 EDT(-0400)] <fj4000> putting focus on the accordion after render doesnt work
[09:29:17 EDT(-0400)] <fj4000> since its not an accodion yet (tongue)
[09:29:29 EDT(-0400)] <fj4000> i need to find a post-accordion listenener
[09:30:58 EDT(-0400)] <Justin_o> there is only a change event... not sure if that will fire on instantiation
[09:31:08 EDT(-0400)] <fj4000> i didnt think so
[09:40:46 EDT(-0400)] * michelled (n=team@142.150.154.193) has joined #fluid-work
[09:41:07 EDT(-0400)] <michelled> fj4000: did you ask the King about the issue you were working on yesterday?
[09:41:19 EDT(-0400)] <fj4000> ?
[09:41:40 EDT(-0400)] <michelled> at the end of the day yesterday you created a patch and wanted to put it into bug parade
[09:41:46 EDT(-0400)] <michelled> I think it made large fonts more usable
[09:41:54 EDT(-0400)] <fj4000> no, I just put that on the jira ticket
[09:42:05 EDT(-0400)] <fj4000> figured once we finish the blockers, we could get to it
[09:42:10 EDT(-0400)] <michelled> can you draw his attention to it? I forget what the number was
[09:42:37 EDT(-0400)] <fj4000> Justin_o, michelled: http://issues.fluidproject.org/browse/FLUID-2386
[09:42:53 EDT(-0400)] <michelled> thx
[09:42:59 EDT(-0400)] <fj4000> np
[09:43:17 EDT(-0400)] <michelled> does it solve the overlapping text issue?
[09:43:33 EDT(-0400)] <Justin_o> fj4000: this will resize the dialog so that it is usable at large font sizes?
[09:43:36 EDT(-0400)] <fj4000> do you have a jira i could look at?
[09:43:51 EDT(-0400)] <fj4000> Justin_o: yes, to a degree
[09:43:59 EDT(-0400)] <fj4000> its the fix you started a while back
[09:44:06 EDT(-0400)] <michelled> hmmm... I thought you were working on that
[09:44:07 EDT(-0400)] <fj4000> using ems for size instead of px
[09:44:25 EDT(-0400)] * clown (n=clown@142.150.154.101) has joined #fluid-work
[09:44:26 EDT(-0400)] <fj4000> michelled: i dont remember the jira
[09:44:35 EDT(-0400)] <michelled> there was no JIRA
[09:44:38 EDT(-0400)] <Justin_o> okay... i think that makes sense to have on the bug parade
[09:44:44 EDT(-0400)] <michelled> I think I must have misunderstood you yesterday
[09:44:49 EDT(-0400)] <Justin_o> i'll add it... maybe you could review the patch michelled
[09:45:04 EDT(-0400)] <michelled> sure
[09:45:31 EDT(-0400)] <fj4000> michlled: this prevents text from overlapping, yes, but i dont know if it addresses the specific issue you were thinking of
[09:47:31 EDT(-0400)] <fj4000> michelled: can I punt FLUID-2339 to you?
[09:50:08 EDT(-0400)] <michelled> fj4000: I'll try but I'm having a lot of trouble with vm ware. I tried to just recreate a couple of the IE issues yesterday and my machine crashed
[09:50:23 EDT(-0400)] <michelled> that's why I was hoping you could look at the IE issues
[09:50:29 EDT(-0400)] <fj4000> ok, if it doesnt work, I will start on them
[09:50:33 EDT(-0400)] <michelled> is the error still happening?
[09:50:36 EDT(-0400)] <michelled> on the nightly?
[09:56:17 EDT(-0400)] <fj4000> Justin_o: ok, i got focus to work
[09:56:29 EDT(-0400)] <fj4000> but in IE, I need to make it more obvious I think
[09:57:03 EDT(-0400)] <michelled> fj4000: your fix looks good
[09:57:07 EDT(-0400)] <Justin_o> okay... good job... thanks
[09:57:12 EDT(-0400)] <michelled> it certainly fixes some of the issues we're seeing
[09:57:18 EDT(-0400)] <fj4000> michelled: great
[09:57:30 EDT(-0400)] <fj4000> this is the patch you mean?
[09:57:33 EDT(-0400)] <michelled> Justin_o suggested we ship 1.0 with a smaller max for font size
[09:57:35 EDT(-0400)] <michelled> yes
[09:57:46 EDT(-0400)] <fj4000> I agree
[09:57:47 EDT(-0400)] <michelled> so he's going to find what that size is and I'll change to that
[09:57:51 EDT(-0400)] <fj4000> 200 is ginormous
[09:58:00 EDT(-0400)] <michelled> then we can can open an issue for 1.1 that will allow the 200 pt
[09:58:18 EDT(-0400)] <michelled> it is but it is a must of a11y
[09:58:24 EDT(-0400)] <michelled> for
[09:58:33 EDT(-0400)] <fj4000> agreed
[09:58:40 EDT(-0400)] <fj4000> I guess Laurie would be able to help
[09:58:57 EDT(-0400)] <michelled> well, she said she wanted 200
[09:59:10 EDT(-0400)] <michelled> I dont think she can help with making that usable. (sad)
[10:11:29 EDT(-0400)] <fj4000> would anyone be able to review my commit for 2121?
[10:13:45 EDT(-0400)] <fj4000> michelled: she said 200 was the way to go? Wow
[10:15:51 EDT(-0400)] <michelled> yes, in fact she may have wanted even larger. She has told me in the past that there are many people with low vision that use their computers with about 3 or 4 characters visible at a time
[10:16:10 EDT(-0400)] <michelled> now, I would think that these people would use something like zoom text to accomplish that
[10:16:26 EDT(-0400)] <michelled> but I think it would be good for us to be able to support it.
[10:17:12 EDT(-0400)] <michelled> you should get clown to give you a demo of web 4 all sometime.
[10:17:55 EDT(-0400)] * clown reading the log...
[10:18:07 EDT(-0400)] <michelled> fj4000: the previous patch didn't apply well so I've made the changes manually. You'll need to take a look after I commit to make sure I caught everything
[10:18:20 EDT(-0400)] <Justin_o> michelled: did you happen to review and commit 2386 yet.. i've added it to the bug parade
[10:18:32 EDT(-0400)] <michelled> clown, I was just saying that many people need extremely large fonts and that your demo of web 4 all is a good one to see that
[10:18:34 EDT(-0400)] <fj4000> ok, I will update
[10:18:42 EDT(-0400)] <michelled> I haven't comitted yet (tongue)
[10:18:46 EDT(-0400)] <michelled> I'll let you know
[10:18:50 EDT(-0400)] <Justin_o> thanks
[10:18:51 EDT(-0400)] <fj4000> ok
[10:19:12 EDT(-0400)] <fj4000> michelled: I have a question
[10:19:28 EDT(-0400)] <fj4000> if you reviewed the patch and you think its good, should I just commit it then?
[10:19:29 EDT(-0400)] * michelled listens
[10:19:39 EDT(-0400)] <fj4000> since I can get it to work, I think
[10:19:40 EDT(-0400)] <michelled> I'm about ready to commit
[10:19:54 EDT(-0400)] <clown> michelled: i see. there is the demo machine in the demo room. let me know if you (someone) want's me to show it.
[10:20:18 EDT(-0400)] <michelled> perhaps next week when fj4000 is here in person.
[10:20:24 EDT(-0400)] <michelled> I think Justin_o wanted to see it too
[10:20:27 EDT(-0400)] <michelled> thanks clown
[10:20:30 EDT(-0400)] <fj4000> yes, I would like to
[10:20:33 EDT(-0400)] <Justin_o> michelled: i was just going to say that
[10:20:52 EDT(-0400)] <clown> no problem
[10:20:57 EDT(-0400)] <Justin_o> thanks
[10:24:38 EDT(-0400)] * colinclark (n=colin@bas2-toronto09-1176406320.dsl.bell.ca) has joined #fluid-work
[10:26:05 EDT(-0400)] <colinclark> Justin_o: I'm looking at FLUID-224, the new build scripts now.
[10:26:18 EDT(-0400)] <Justin_o> colinclark: yes.
[10:26:31 EDT(-0400)] <colinclark> An interesting issue came up. I introduced a stupid bug awhile back that affects the build: http://issues.fluidproject.org/browse/FLUID-2275
[10:27:02 EDT(-0400)] <Justin_o> ah... so you are saying that this would need to be fixed first?
[10:27:26 EDT(-0400)] <michelled> fj4000: did you commit that patch then?
[10:27:46 EDT(-0400)] <michelled> I have a whole ton of conflicts and once I resolved them I don't appear to have any changes
[10:27:48 EDT(-0400)] <michelled> glarg
[10:28:07 EDT(-0400)] <fj4000> ach - I think I had to in my last commit
[10:28:22 EDT(-0400)] <colinclark> Justin_o: Well, it can be fixed alongside. It's just that I can't build a self-contained Rich Text Inline Edit package with this bug in the system.
[10:28:28 EDT(-0400)] <fj4000> I didnt split file into separate changes
[10:28:35 EDT(-0400)] <fj4000> they all got caught into one
[10:29:11 EDT(-0400)] <Justin_o> colinclark: okay.. so I'll add that one to the bug parade
[10:29:21 EDT(-0400)] <colinclark> Justin_o: I feel funny about adding stuff to the bug parade like that.
[10:29:29 EDT(-0400)] <colinclark> I think you made a good call with the uploader issue.
[10:29:37 EDT(-0400)] <Justin_o> thanks
[10:29:42 EDT(-0400)] <colinclark> FLUID-2275 is one that burned us back in 0.7
[10:30:08 EDT(-0400)] <colinclark> If it gets included in Fluid-all.js, every page that does not have TinyMCE attached to it will cause an error.
[10:30:33 EDT(-0400)] <colinclark> Sorta the wrong way to do it... we should only invoke TinyMCE if it's actually there. (wink)
[10:30:57 EDT(-0400)] <Justin_o> that makes sense.
[10:31:10 EDT(-0400)] <colinclark> fj4000, athena: Any news on the Jasig registration portlet? How'd it go?
[10:31:31 EDT(-0400)] <athena> i think it went ok, thanks!
[10:32:12 EDT(-0400)] <athena> seems to be working ok
[10:32:20 EDT(-0400)] <colinclark> Did you guys get a chance to do some UI/styling tweaking on it together?
[10:32:34 EDT(-0400)] <fj4000> I handed off some basic fss changes
[10:32:50 EDT(-0400)] <fj4000> nothing major, just some simple formatting
[10:33:09 EDT(-0400)] <colinclark> Cool
[10:34:11 EDT(-0400)] <colinclark> Justin_o: Let's leave FLUID-2275 off unless it becomes obvious that we can't live with a bug like this.
[10:34:31 EDT(-0400)] <Justin_o> okay... i can make it a blocker for 1.1 if that makes sense
[10:34:41 EDT(-0400)] <colinclark> I think we can probably ship with a known issue about needing to separately link to jquery.tinymce.js for Rich Text Inline Edit
[10:34:45 EDT(-0400)] <colinclark> Justin_o: Sure, that makes sense.
[10:34:53 EDT(-0400)] <colinclark> I'm a bit worried about these build scripts.
[10:35:04 EDT(-0400)] <Justin_o> something wrong...
[10:35:20 EDT(-0400)] <colinclark> The logic for powering a modular build is fairly involved, and Ant-while better than Maven-can still sometimes be challenging to express these kinds of things in.
[10:35:26 EDT(-0400)] <colinclark> It's expressly not a scripting language.
[10:35:50 EDT(-0400)] <colinclark> When Ant first came out, that was something I was pretty enthusiastic about. It was a way of expressing builds, not of scripting them using imperative logic.
[10:36:09 EDT(-0400)] <athena> colin, yes, fj4000's help was very much appreciated (smile)
[10:36:26 EDT(-0400)] <colinclark> But over time, it's had a number of imperative features added to it. Makes life more complex, especially when it's all written in XML.
[10:36:30 EDT(-0400)] <colinclark> athena: Awesome. (smile)
[10:36:43 EDT(-0400)] <colinclark> Just checking in. Didn't want that ball to drop before today's release.
[10:37:56 EDT(-0400)] <colinclark> Justin_o: Simon Wang's patch works, but it's not really scalable over the long term. He pointed that out to us as an issue back in Berkeley.
[10:38:10 EDT(-0400)] <colinclark> It basically has a gigantic "if" statement for each component.
[10:38:22 EDT(-0400)] <colinclark> So to add new components to the system, you have to do a lot of very evil cutting and pasting.
[10:39:05 EDT(-0400)] <Justin_o> i remember him talking about the structure of our repository...
[10:39:12 EDT(-0400)] <colinclark> Yep.
[10:39:25 EDT(-0400)] <colinclark> His initial suggestion was to have all of a component's dependencies self-contained.
[10:39:31 EDT(-0400)] <fj4000> michelled: can you confirm I can close http://issues.fluidproject.org/browse/FLUID-2386 ?
[10:39:50 EDT(-0400)] <colinclark> But the problem with that is that we'd have to have multiple copies of the same file scattered throughout SVN. Not workable.
[10:39:51 EDT(-0400)] <michelled> ya, I was just doing some testing on that and 2121
[10:39:57 EDT(-0400)] <fj4000> thanks!
[10:40:00 EDT(-0400)] <michelled> I'll comment on the issues when I'm done
[10:40:20 EDT(-0400)] <fj4000> cool
[10:40:23 EDT(-0400)] <colinclark> So it's occurring to me that fj4000's proposed directory restructuring is sorely needed.
[10:40:37 EDT(-0400)] <fj4000> i was thinking about this last week ^
[10:40:58 EDT(-0400)] <fj4000> i thought it might not get any attention until after 1.0
[10:41:04 EDT(-0400)] <colinclark> There's a part of me that thinks pre-1.0 is the perfect time for this sort of thing, but it's also very disruptive in the midst of bug parade.
[10:41:10 EDT(-0400)] <fj4000> yes
[10:41:14 EDT(-0400)] <fj4000> a bit of a danger
[10:41:20 EDT(-0400)] <colinclark> I'll see how the build scripts go today and how badly the new directory structure is needed.
[10:41:51 EDT(-0400)] <fj4000> ok
[10:41:56 EDT(-0400)] <colinclark> At worse, we could consider a kind of "everything but build" freeze where all hands are on deck for a day to help restructure SVN and ensure that our build packages are working properly.
[10:42:31 EDT(-0400)] <Justin_o> colinclark: how long do you think it will take
[10:42:45 EDT(-0400)] <colinclark> directory restructuring, etc?
[10:42:47 EDT(-0400)] <Justin_o> we have one more day of bug parade next week and 4 days of testing scheduled
[10:42:50 EDT(-0400)] <Justin_o> yes
[10:43:11 EDT(-0400)] <colinclark> i imagine that if we know exactly how we'd like it to look, it's probably a day's work.
[10:43:26 EDT(-0400)] <colinclark> actually making the moves isn't hard. being really thorough about ensuring that all files link against the structure is important
[10:44:17 EDT(-0400)] <Justin_o> right... so it would have to fall somewhere between bug parade and testing... i suppose if we can get enough help testing, we can shorten that by a day...
[10:44:34 EDT(-0400)] <Justin_o> or if enough bugs are fixed by the end of day tomorrow we can shorten bug parade
[10:46:05 EDT(-0400)] <colinclark> Justin_o: I wouldn't take away your testing time...
[10:46:17 EDT(-0400)] <colinclark> And I suspect I'd be skewered if we took away parade time. (wink)
[10:46:30 EDT(-0400)] <colinclark> We'd just have to push release by a day, I suppose.
[10:46:58 EDT(-0400)] <colinclark> Still thinking this all through.
[10:47:04 EDT(-0400)] <Justin_o> colinclark: is it a good idea to release on April 1st?
[10:47:10 EDT(-0400)] <colinclark> lol
[10:47:14 EDT(-0400)] <colinclark> maybe not
[10:48:07 EDT(-0400)] <Justin_o> I've been hoping that I would be able to get testing help from the design team (not sure if they have time) and then try to get testing done a day early so that we have more time for the release
[10:48:27 EDT(-0400)] <colinclark> Justin_o: I think that makes a lot of sense. I'll ask Jess about it.
[10:48:34 EDT(-0400)] <Justin_o> colinclark: thanks
[10:53:23 EDT(-0400)] * EricDalquist (n=dalquist@bohemia.doit.wisc.edu) has joined #fluid-work
[11:03:33 EDT(-0400)] <Justin_o> fj4000: i was just testing FLUID-2121
[11:03:55 EDT(-0400)] <Justin_o> i noticed that in FF2 on winxp the dialog won't resize imediately.. you have to click or tab to something
[11:05:28 EDT(-0400)] <Justin_o> fj4000: do you have any ideas on that
[11:17:24 EDT(-0400)] <fj4000> ouch, no
[11:17:28 EDT(-0400)] <fj4000> I diddnt see that
[11:17:36 EDT(-0400)] <fj4000> can you show me in person?
[11:17:50 EDT(-0400)] <Justin_o> yes... but i'm a little far from you (tongue)
[11:18:01 EDT(-0400)] <Justin_o> you have your screen sharing thing
[11:19:31 EDT(-0400)] <Justin_o> fj4000: guess what, it's working now...
[11:19:43 EDT(-0400)] <Justin_o> don't know what happened htere
[11:19:46 EDT(-0400)] <fj4000> jeez
[11:19:53 EDT(-0400)] <fj4000> ok, I have a theory about this
[11:19:59 EDT(-0400)] <fj4000> since i noticed it in IE6
[11:20:04 EDT(-0400)] <fj4000> but then it was gone too
[11:20:31 EDT(-0400)] <fj4000> I think its hanging on the ajax + call back part
[11:20:36 EDT(-0400)] <fj4000> but thats just a hunch
[11:20:52 EDT(-0400)] <Justin_o> maybe...
[11:20:54 EDT(-0400)] <Justin_o> could be
[11:21:12 EDT(-0400)] <Justin_o> oh well...i'm going to close 2121 now
[11:21:32 EDT(-0400)] <Justin_o> sorry.. wrong jira...
[11:42:16 EDT(-0400)] * Justin_o (n=Justin@142.150.154.171) has left #fluid-work
[11:43:05 EDT(-0400)] * ecochran (n=ecochran@dhcp-169-229-212-50.LIPS.Berkeley.EDU) has joined #fluid-work
[11:43:57 EDT(-0400)] * Justin_o (n=Justin@142.150.154.171) has joined #fluid-work
[11:58:30 EDT(-0400)] * jayshao (n=jayshao@204.142.89.146) has joined #fluid-work
[12:07:31 EDT(-0400)] <anastasiac> fj4000 or fj40001 (whichever you are): got a moment?
[12:07:48 EDT(-0400)] <anastasiac> questions regarding fluid.components.ui-options.css
[12:12:02 EDT(-0400)] <clown> Justin_o: I discussed the aria-grab(bed) issue with David vis-a-vis FF3 and FF2.
[12:12:56 EDT(-0400)] <clown> bottom line: FF3 is supporting only "aria-grabbed". FF2 doesn't even support "aaa:grab".
[12:13:25 EDT(-0400)] <clown> see https://bugzilla.mozilla.org/show_bug.cgi?id=474340
[12:13:26 EDT(-0400)] <Justin_o> clown: really... so it is a necessary switch then
[12:14:18 EDT(-0400)] <clown> yeah. if we use "aria-grabbed" and its value space, then, it will go in as "aaa:grab" if run in FF2, but it won't mean anything.
[12:16:09 EDT(-0400)] <Justin_o> so the grab role is really only supported in FF3 at the moment then anyways
[12:16:18 EDT(-0400)] <michelled> fj4000: are you working on 2339? I can debug it on Justin's window's machine. I'll assign it to me.
[12:18:08 EDT(-0400)] <Justin_o> clown: did you still want to work on that one? Also did you see my comment above?
[12:19:46 EDT(-0400)] * colinclark (n=colin@142.150.154.101) has joined #fluid-work
[12:19:50 EDT(-0400)] <clown> Justin_o: the correct way of putting it is: FF3 publishes the grabbed state to the platform a11y API. I assume the same is true of IE8, and Safari 4 (when it gets finished). (acutally ,probably opera and ultimately Chrome too). FF2 doesn't publish the info for this aria state.
[12:20:19 EDT(-0400)] <Justin_o> clown: thanks
[12:20:45 EDT(-0400)] <clown> re: working on it: sure, I think I can spare some time this afternoon.
[12:20:57 EDT(-0400)] <Justin_o> clown: thanks a lot
[12:25:48 EDT(-0400)] <fj4000> anastasiac, michelled: Im back from daycare now
[12:44:11 EDT(-0400)] <anastasiac> fj4000, I just file FLUID-2388 about the issue we've found
[12:44:39 EDT(-0400)] <fj4000> ok
[12:47:55 EDT(-0400)] * colinclark (n=colin@142.150.154.101) has joined #fluid-work
[12:51:31 EDT(-0400)] <fj4000> anastasiac: i just put a patch up there, so we can apply it when bug parade is complete.
[12:58:09 EDT(-0400)] <anastasiac> wow - fj4000, that was quick!!
[12:58:23 EDT(-0400)] <fj4000> (smile)
[12:59:00 EDT(-0400)] <fj4000> now we need to test it to see if it works!
[13:21:00 EDT(-0400)] <anastasiac> fj4000, tested your patch, and commented on the JIRA with a new screen shot
[13:21:03 EDT(-0400)] <anastasiac> we're getting there!
[13:25:36 EDT(-0400)] <Justin_o> michelled: http://issues.fluidproject.org/browse/FLUID-2389 is the jira for maximum minimum text
[13:25:58 EDT(-0400)] <michelled> thanks
[13:34:21 EDT(-0400)] <Justin_o> anastasiac: any chance you might have time to do some code reviews
[13:34:49 EDT(-0400)] <anastasiac> Justin_o, yes - I was looking at the bug parade updates, and seeing the list of "needs review"
[13:34:54 EDT(-0400)] <anastasiac> I'll have a look this afternoon
[13:35:00 EDT(-0400)] <Justin_o> thanks a lot
[14:29:40 EDT(-0400)] * colinclark (n=colin@142.150.154.101) has joined #fluid-work
[14:29:51 EDT(-0400)] * laurelw (n=Laurel@142.150.154.178) has joined #fluid-work
[15:01:08 EDT(-0400)] <anastasiac> Justin_o: I've reviewed FLUID-2258 and commented on the JIRA - might need a bit more attention
[15:03:59 EDT(-0400)] <Justin_o> anastasiac: thanks... i think those extra classes had to do with a fix for FLUID-2359 that got rolled into this one
[15:04:23 EDT(-0400)] <anastasiac> ok, cook - if you're ok with that rolling, then I'm ok with it (smile)
[15:04:28 EDT(-0400)] <anastasiac> "cool"
[15:05:27 EDT(-0400)] <Justin_o> fj4000: can you take a look at the comments for FLUID-2258
[15:05:39 EDT(-0400)] <fj4000> sure
[15:06:24 EDT(-0400)] <Justin_o> also if a commit is intended for multiple jira's please mark it on the commit and the jiras... thanks
[15:06:42 EDT(-0400)] <fj4000> yes - I forgot about the multiple jiras thing
[15:07:17 EDT(-0400)] <Justin_o> yah... thought so, no problem... I'm going to re-open FLUID-2258 and then you can resolve again after you make the recommended changes
[15:07:28 EDT(-0400)] <fj4000> which would be?
[15:07:39 EDT(-0400)] <Justin_o> they are on the jira...
[15:07:49 EDT(-0400)] <Justin_o> nothing too major, shouldn't take too long
[15:07:56 EDT(-0400)] <fj4000> i read them - dont understand #1
[15:08:10 EDT(-0400)] <fj4000> before you reopen it, I would like to ask anastasiac
[15:08:18 EDT(-0400)] <Justin_o> sure
[15:08:47 EDT(-0400)] <anastasiac> fj4000:
[15:08:51 EDT(-0400)] <fj4000> anastasiac: see above ... the q is "moving the link to the article desribing the issue to this JIRA"
[15:08:58 EDT(-0400)] <fj4000> what would the link be in this case?
[15:09:00 EDT(-0400)] <anastasiac> your fix to FLUID-2258 is to remove some styles
[15:09:07 EDT(-0400)] <anastasiac> but you didn't remove them, you only commented them out
[15:09:16 EDT(-0400)] <anastasiac> it they're not to be used, they should probably actually just be removed
[15:09:25 EDT(-0400)] <fj4000> thats the thing
[15:09:33 EDT(-0400)] <fj4000> michelle and I already talked about this
[15:09:41 EDT(-0400)] <fj4000> they were left in
[15:09:51 EDT(-0400)] <fj4000> to be a reminder for me to investigate further
[15:09:59 EDT(-0400)] <fj4000> b/c its still unclear why this happened
[15:10:15 EDT(-0400)] <fj4000> so I fugured I would comment out the whole thing, and add another comment
[15:10:17 EDT(-0400)] <anastasiac> ah - ok, then in that case, I think it's fine to leave them in and commented
[15:10:32 EDT(-0400)] <anastasiac> I'll comment on the JIRA
[15:10:36 EDT(-0400)] <anastasiac> for the record (smile)
[15:10:36 EDT(-0400)] <fj4000> thanks
[15:10:40 EDT(-0400)] <colinclark> I really don't want to ship commented-out code/styles in the release...
[15:10:49 EDT(-0400)] <colinclark> so as long as you're planning to address this before the end of bug parade.
[15:10:59 EDT(-0400)] <fj4000> should the build take care of that colinclark?
[15:11:04 EDT(-0400)] <michelled> no
[15:11:07 EDT(-0400)] <fj4000> comments are stripped on minifcation?
[15:11:20 EDT(-0400)] <colinclark> fj4000: Comments are stripped, but that's not the point.
[15:11:22 EDT(-0400)] <michelled> they are on minification, but we ship unminified too
[15:11:40 EDT(-0400)] <fj4000> what do we do about all our "TODO" commments?
[15:11:51 EDT(-0400)] <fj4000> same procedure?
[15:11:53 EDT(-0400)] <michelled> I think todo comments are useful
[15:12:01 EDT(-0400)] <fj4000> then I will change this to a TODO
[15:12:03 EDT(-0400)] <fj4000> siimple
[15:12:04 EDT(-0400)] <michelled> they let the next person reading the code see what's happening
[15:12:06 EDT(-0400)] <fj4000> in needs to stay
[15:12:25 EDT(-0400)] <michelled> especially if they mention a JIRA number
[15:12:39 EDT(-0400)] <anastasiac> Justin_o, I've made more comments to FLUID-2258
[15:12:44 EDT(-0400)] <colinclark> If you're worried about forgetting to cycle back on this, you need a JIRA for the issue.
[15:12:50 EDT(-0400)] <colinclark> Way better than leaving stuff in, commented out.
[15:13:00 EDT(-0400)] <Justin_o> anastasiac: thanks
[15:13:03 EDT(-0400)] <fj4000> not cycling back, just inderstanding what was removed and why
[15:13:06 EDT(-0400)] <michelled> and you can put your implementation notes as a comment on the JIRA
[15:13:09 EDT(-0400)] <fj4000> and where it goes back
[15:13:25 EDT(-0400)] <colinclark> fj4000: I'm not sure what you mean.
[15:13:54 EDT(-0400)] <fj4000> im thinking it was important to have that one line in where it was, b/c it did specific stuff
[15:14:12 EDT(-0400)] <fj4000> by taking it out, im not sure why the problem went away, but I think old ones will come back
[15:14:35 EDT(-0400)] <fj4000> so I would like to have a TODO comment to figure out what I should do moving forward
[15:14:48 EDT(-0400)] <michelled> that would work
[15:14:51 EDT(-0400)] <colinclark> fj4000: That sounds like all the more reason why a JIRA is actually the best place for this information. There's clearly background information associated with it.
[15:15:05 EDT(-0400)] <colinclark> So then, as michelled says, your comment can directly reference the JIRA issue.
[15:15:52 EDT(-0400)] <fj4000> yes
[15:16:00 EDT(-0400)] <fj4000> it needs some more info
[15:16:16 EDT(-0400)] <fj4000> but my thing is I would like to keep it....unless its not acceptable
[15:16:30 EDT(-0400)] <michelled> it will still exist in svn (tongue)
[15:16:35 EDT(-0400)] <fj4000> very true
[15:16:46 EDT(-0400)] <fj4000> whatever is best practice, we can do here
[15:16:55 EDT(-0400)] <fj4000> ive just seen it go both ways
[15:16:58 EDT(-0400)] <colinclark> I think it's fine to leave it in if it's clearly explained and points to a JIRA
[15:17:01 EDT(-0400)] <colinclark> We've done this in the past.
[15:17:03 EDT(-0400)] <michelled> do you know what old bugs have come back?
[15:17:27 EDT(-0400)] * michelled is thinking those would be the ideal JIRAs to link to
[15:17:31 EDT(-0400)] <colinclark> Just keep in mind that commented-out code on its own tends to look like its author didn't know what was going on, so just commented something out, found it work, and left it at that.
[15:17:47 EDT(-0400)] <fj4000> I havent seen any yet, but try creating a linearized layout with absolutely positioned items in there, and I think you find some
[15:18:04 EDT(-0400)] <michelled> there is something to warning future people not to do something. although I may do that with words rather then code
[15:18:47 EDT(-0400)] <Justin_o> fj4000: okay.. so sounds like i need to re-open so you can get the proper comments in there... it can be code reviewed again, after that... and then i'll test and close
[15:18:59 EDT(-0400)] <fj4000> k
[15:25:16 EDT(-0400)] * anastasiac (n=team@142.150.154.189) has joined #fluid-work
[15:39:41 EDT(-0400)] <michelled> fj4000: question for you. as you know UI Enhancer's implementation uses a lot of FSS. We used to clear out all the 'font' and 'layout' FSS classes before applying the styling in UI Enhancer. This was not the correct behaviour as laurelw and anastasiac found when they tried to integrate UI Options into the web site. I just committed a fix that pulls only the classes the UI Enhancer uses and only pulls them off the body. The question is: should I b
[15:40:09 EDT(-0400)] <fj4000> i was just reading up on this (smile)
[15:40:22 EDT(-0400)] <fj4000> glad we're discussing it
[15:40:29 EDT(-0400)] <michelled> FLUID-2367
[15:40:35 EDT(-0400)] <michelled> but there's not much on the issue
[15:41:07 EDT(-0400)] <fj4000> I think your question got cut off ^^
[15:41:20 EDT(-0400)] <michelled> what did you see to?
[15:41:30 EDT(-0400)] <michelled> The question is: should I be cleaning the entire document or is pulling the classes of the body good enough?
[15:41:34 EDT(-0400)] <fj4000> ah
[15:42:22 EDT(-0400)] <fj4000> can we skype this? I just want to make sure I understand the issue thoroughly
[15:42:28 EDT(-0400)] <michelled> sounds good
[15:56:18 EDT(-0400)] <anastasiac> Justin_o, I've commented on FLUID-2307 - looks good to me.
[15:56:33 EDT(-0400)] <Justin_o> thank you
[16:09:49 EDT(-0400)] * laurelw (n=Laurel@142.150.154.178) has left #fluid-work
[16:22:02 EDT(-0400)] <anastasiac> Justin_o, I've reviewed and commented on FLUID-2313
[16:22:31 EDT(-0400)] <Justin_o> thank you
[16:23:13 EDT(-0400)] <fj4000> michelled: so to recap and put our thoughts here, we're going to parse the DOM and remove class names identified in a class name map.
[17:03:25 EDT(-0400)] <michelled> yes, and specifically the classes related to 'textFont', 'textSpacing' and 'theme' in the class name map that is in UI Enhancer
[17:03:57 EDT(-0400)] <michelled> oh ya, and fl-layout-linear and fl-no-background-images
[17:25:15 EDT(-0400)] * clown (n=clown@142.150.154.101) has left #fluid-work
[17:28:21 EDT(-0400)] * apetro (n=apetro@wsip-98-174-242-39.ph.ph.cox.net) has joined #fluid-work