fluid-work IRC Logs-2011-12-05

[09:20:13 CST(-0600)] <anastasiac> jvass, regarding Fluid Studios: Would it be possible to create versions of the various icons (e.g. login, etc) in black and in yellow (and white for the blue 'back' arrow)? These would be swapped in when we switch to the white-on-black, yellow-on-black and black-on-yellow themes. I'm not sure what we should do with the actual "fluid studios" logo...

[09:33:29 CST(-0600)] <jvass> anastasiac: okay, I will do that now

[09:33:44 CST(-0600)] <anastasiac> thanks, jvass

[09:42:46 CST(-0600)] <cindyli> michelled, anastasiac, i sent a pull request to format the archive page. it also has a few other small fixes mentioned last friday. https://github.com/fluid-project/studios.fluidproject.org/pull/8

[09:43:04 CST(-0600)] <michelled> thx cindyli

[09:43:11 CST(-0600)] <cindyli> np

[09:43:29 CST(-0600)] <colinclark> michelled, anastasiac, cindyli: I also made two small pull requests over the weekend

[09:43:48 CST(-0600)] <colinclark> And made a new project in JIRA for the Studios, with a "website" component

[09:43:57 CST(-0600)] <colinclark> So my pull requests are STUDIO-1 and STUDIO-2

[09:44:53 CST(-0600)] <michelled> thx colinclark - I'm looking at them now

[09:45:34 CST(-0600)] <anastasiac> michelled, colinclark, I wonder: should we move our two existing studios-related JIRAs into the new Studios project?

[09:46:00 CST(-0600)] <anastasiac> ah, you've replicated them there already

[09:46:12 CST(-0600)] <anastasiac> oh, wait, not

[09:46:15 CST(-0600)] <anastasiac> sorry

[09:46:21 CST(-0600)] <colinclark>

[09:46:37 CST(-0600)] * anastasiac should finish her coffee

[09:46:37 CST(-0600)] <colinclark> anastasiac: What are your thoughts about migrating the existing issues?

[09:47:33 CST(-0600)] <anastasiac> well, it makes sense for studios-related JIRAs to be in the studios project, but I worry about existing commits and the JIRA numbers in their logs

[09:47:41 CST(-0600)] <anastasiac> I don't know if the association would be lost

[09:49:56 CST(-0600)] <cindyli> probably another rebase after migrating the jiras over, if only 4 of us are aware of and using the studio github repo

[09:50:15 CST(-0600)] <cindyli> relatively easy to us re-clone the repo

[09:50:48 CST(-0600)] <cindyli> anastasia, what else in fluid studio can i help with? styling? i guess you probably have gone quite far with styling.

[09:51:20 CST(-0600)] <michelled> anastasiac, cindyli: I think JIRA will redirect to the correct number

[09:51:27 CST(-0600)] <colinclark> Seems to me that the Studios are orthogonal to Infusion

[09:51:44 CST(-0600)] <colinclark> Completely different code base, project, goals, etc.

[09:52:04 CST(-0600)] <colinclark> In which case, it's probably confusing to have Studios-related tickets filed against Infusion

[09:52:08 CST(-0600)] <colinclark> What do you all think?

[09:52:31 CST(-0600)] <colinclark> Was there any reason we didn't set up a new project originally?

[09:52:43 CST(-0600)] <anastasiac> no, no reason

[09:53:20 CST(-0600)] <anastasiac> I think we should move the JIRAs over, especially if we won't have to rebase the repo

[09:53:33 CST(-0600)] <anastasiac> it makes sense for them to exist in the studios project and not in infusion

[09:54:11 CST(-0600)] <anastasiac> cindyli, right now I'm working on making sure the styling of the site is right in the different UIO high-contrast themes

[09:54:55 CST(-0600)] <colinclark> ok, sounds good to me

[09:54:58 CST(-0600)] <cindyli> ok, anastasiac, i'm thinking where i can jump in

[09:55:04 CST(-0600)] <anastasiac> not sure...

[09:55:11 CST(-0600)] <cindyli> lol

[09:55:19 CST(-0600)] <anastasiac> michelled was going to look into why the 'display prefs' button was pushing the content downward

[09:55:26 CST(-0600)] <anastasiac> causing a gap above the sidebar background

[09:55:32 CST(-0600)] <anastasiac> maybe you could look into that?

[09:55:48 CST(-0600)] <anastasiac> assuming michelled hasn't solved it yet...

[09:56:21 CST(-0600)] <cindyli> i see

[09:56:21 CST(-0600)] <michelled> nope, not yet - I got distracted by the jumpy UIO

[09:56:39 CST(-0600)] <cindyli> ok, i will have a look on the gap issue

[09:56:39 CST(-0600)] <anastasiac> also, I guess you have a queue of pull requests now, michelled

[09:57:01 CST(-0600)] <michelled> yep, I do

[10:01:34 CST(-0600)] <jvass> anastasiac, I updated the images file on the wiki with the icon variations

[10:01:43 CST(-0600)] <anastasiac> jvass, I also remembering you offering to try to improve the styling of the "show display preferences" button on the Studios page… maybe move it to the sidebar?

[10:01:46 CST(-0600)] <anastasiac> thanks, jvass!

[10:01:49 CST(-0600)] <anastasiac> that was quick

[10:05:09 CST(-0600)] <jvass> anastasiac, yeah I was thinking of having it styled similar to the log in button, would you like me to add it to the mockups

[10:05:30 CST(-0600)] <anastasiac> jvass, that would be great, thanks! and the icons look great

[10:06:05 CST(-0600)] <jvass> anastasiac: thanks

[10:19:37 CST(-0600)] <michelled> cindyli: I think we should try Bosmon's suggestion of using his branch of UIO instead of the released version to see if it fixes the jumping issue

[10:20:01 CST(-0600)] <cindyli> ok, michelled

[10:25:13 CST(-0600)] <michelled> colinclark: when you built MyInfusion for the studios, what did you include?

[10:25:25 CST(-0600)] <colinclark> oh, that's a very good question

[10:25:37 CST(-0600)] <colinclark> It's a UIO-only build

[10:28:06 CST(-0600)] <michelled> colinclark: I'm trying to decide whether to create a read me in the infusion directory or whether it's better to just add to the one in the themes directory: https://github.com/fluid-project/studios.fluidproject.org/blob/development/wp-content/themes/fluid-studios/README.txt

[10:28:52 CST(-0600)] <colinclark> You want to make note of the version and contents of MyInfusion int he README, michelled?

[10:28:54 CST(-0600)] <colinclark> is that the idea?

[10:29:12 CST(-0600)] <michelled> yes, I want it to be clear what versions of everything we've used

[10:29:17 CST(-0600)] <colinclark> If so, I think I'd probably just use this README… putting everything in one place makes it less likely that we'll forget to update it

[10:29:27 CST(-0600)] <colinclark> That sounds very sensible

[10:29:53 CST(-0600)] <michelled> colinclark: you built with the 1.4 release?

[10:30:10 CST(-0600)] <colinclark> yup, I used http://builder.fluidproject.org

[10:30:14 CST(-0600)] <colinclark> So convenient!

[10:33:03 CST(-0600)] <colinclark> michelled: Sorry, I should have thought to make note of these details in the README

[10:45:47 CST(-0600)] <colinclark> Connect problems on my end again today

[10:45:53 CST(-0600)] <colinclark> My standup update:

[10:46:09 CST(-0600)] <colinclark> I made some little, hopefully helpful pull requests over the weekend for the Studios

[10:46:18 CST(-0600)] <colinclark> these are analogous to the ones I made Friday night to FSSFive

[10:46:29 CST(-0600)] <colinclark> Today, it's still this RFP into its new template

[10:46:54 CST(-0600)] <colinclark> will try to get some screenshots or a working demo for Jan for the Infusion authoring prototype

[10:47:16 CST(-0600)] <colinclark> I'll be at the dentist's for a few hours this afternoon, then in the office afterwards

[10:47:18 CST(-0600)] <colinclark> Exciting stuff

[10:58:55 CST(-0600)] <michelled> anastasiac, cindyli: FLUID-4566 is now STUDIO-3

[10:59:12 CST(-0600)] <anastasiac> michelled, thanks

[10:59:13 CST(-0600)] <cindyli> thanks, michelled

[10:59:49 CST(-0600)] <colinclark> Thanks for your code reviews and pushes, michelled

[11:00:18 CST(-0600)] <michelled> np

[11:00:30 CST(-0600)] <michelled> also FLUID-4565 is STUDIO-4

[11:02:22 CST(-0600)] <michelled> anastasiac: were there any other studio JIRAs in Infusion?

[11:02:43 CST(-0600)] <anastasiac> michelled, nope: those were the only two

[11:03:00 CST(-0600)] <michelled> thx

[11:05:02 CST(-0600)] <anastasiac> cindyli, I remember you worked on the styling of the back button - is that in your pull request, or is it not ready yet?

[11:05:22 CST(-0600)] <cindyli> no, it's in another branch

[11:05:26 CST(-0600)] <anastasiac> ok

[11:05:44 CST(-0600)] <cindyli> i thought you may want to merge with your styling change, anastasiac

[11:05:55 CST(-0600)] <anastasiac> and cindyli, I'm trying out your latest pull request, and I'm not seeing a 'back' button on the single post pages

[11:05:55 CST(-0600)] <cindyli> i'm sure there will be conflict

[11:06:11 CST(-0600)] <anastasiac> I will merge the styling changes for the back button, then, cindyli

[11:06:14 CST(-0600)] <cindyli> let me check, anastasiac

[11:06:23 CST(-0600)] <cindyli> thanks

[11:07:59 CST(-0600)] <cindyli> right, the 'back' button is missing. i'm sending a pull request soon to fix it

[11:17:00 CST(-0600)] <cindyli> anastasiac, michelled, the fix that includes the 'back' button into the single post page goes in the pull request 8

[11:17:06 CST(-0600)] <cindyli> https://github.com/fluid-project/studios.fluidproject.org/pull/8

[11:17:22 CST(-0600)] <anastasiac> thanks, cindyli

[11:18:03 CST(-0600)] <cindyli> np

[11:39:34 CST(-0600)] <michelled> anastasiac: you made a list of things we needed to do for the studios on Friday - is that up somewhere?

[11:40:09 CST(-0600)] <anastasiac> no, only in my notebook

[11:40:13 CST(-0600)] <anastasiac> checking it now

[11:41:02 CST(-0600)] <anastasiac> michelled, I think almost everything on the list is in (or getting into) my branch at the moment

[11:42:50 CST(-0600)] <anastasiac> cindyli, one thing we spoke about on Friday was some way to limit the length of the titles that authors enter as they create a page. You thought that this should be configurable?

[11:43:25 CST(-0600)] <cindyli> yes, anastasiac, forgot that

[11:43:36 CST(-0600)] <cindyli> let me have a look

[12:18:13 CST(-0600)] <cindyli> anastasiac, do you think how long is the proper default length for post titles? 100?

[12:18:37 CST(-0600)] <anastasiac> ah, good question, cindyli. I wonder if jvass can help figure this one out...

[12:20:42 CST(-0600)] <cindyli> jvass might be away from the desk. using 100 for now.

[12:21:07 CST(-0600)] <anastasiac> cindyli, sounds good. Once we know how to do it, we can always tweak it if the designers want us to

[12:21:19 CST(-0600)] <cindyli> exactly. thanks, anastasiac

[12:22:30 CST(-0600)] <anastasiac> michelled, do you have an ETA for merging cindy's pull request? I've merged it into my branch, but I'm not sure if I should submit a pull request until after you push hers...

[12:22:54 CST(-0600)] <michelled> I pushed hers

[12:22:59 CST(-0600)] <anastasiac> oh!

[12:23:12 CST(-0600)] <anastasiac> ok, I didn't see any email, sorry to bug you

[12:23:18 CST(-0600)] <michelled> unless there was one I missed?

[12:23:25 CST(-0600)] <anastasiac> #8?

[12:23:27 CST(-0600)] <michelled> np - I should have mentioned it in the channel

[12:23:43 CST(-0600)] <michelled> yes I pushed 8 - actually twice because I pushed and then cindyli updated it

[12:25:22 CST(-0600)] <cindyli> ah, sorry, michelled, for making you pushing twice. btw, i also don't get email on the merge of the pull request. is there a setting somewhere in the github that we missed

[12:25:53 CST(-0600)] <michelled> not sure - I'll take a look

[12:28:47 CST(-0600)] <cindyli> michelled, anastasiac, i sent another pull request to restrict the length of the post title: https://github.com/fluid-project/studios.fluidproject.org/pull/9

[12:31:48 CST(-0600)] <michelled> cindyli: it looks like justin_o set up a post receive hook for the Infusion repo. I'll send him a message asking about it.

[12:32:53 CST(-0600)] <cindyli> good to know

[12:38:18 CST(-0600)] <anastasiac> michelled, I've submitted a pull request for more styling fixes, including cindyli's styling of the back buttons and better style changes with the UIO high-contrast themes: https://github.com/fluid-project/studios.fluidproject.org/pull/10

[12:38:30 CST(-0600)] <anastasiac> we're getting close now...

[12:38:34 CST(-0600)] <michelled> ok, looking at it

[12:43:39 CST(-0600)] <anastasiac> michelled, I just added a commit to the pull request: two small styling changes

[12:43:53 CST(-0600)] <michelled> thx

[13:28:19 CST(-0600)] <anastasiac> cindyli, michelled and I just sat down with jvass and went over the current state of the studios styling. We identified a few things that need adjustment, and michelled will be updating JIRA shortly (with comments on STUDIO-3 as well as possible all-new JIRAs)

[13:28:54 CST(-0600)] <anastasiac> one issue we found is a problem with the aspect ration of the thumbnails on the main page, cindyli. I adjusted your constants to 420x160, but wordpress isn't playing nice

[13:29:14 CST(-0600)] <anastasiac> I couldn't see anything wrong with your code, so it might be a bug in wordpress, but maybe you could have a look?

[13:29:38 CST(-0600)] <anastasiac> the thumbnails are showing up square (160x160) instead of rectangular, cindyli

[13:30:04 CST(-0600)] <cindyli> trying, anastasiac

[13:37:26 CST(-0600)] <michelled> anastasiac, cindyli: the notes of what's left is on the JIRA: http://issues.fluidproject.org/browse/STUDIO-3

[13:41:55 CST(-0600)] <cindyli> anastasiac: it seems that the cropping done by wordpress is not able to crop out a rectangular thumbnail if the image comes in square originally.

[13:42:20 CST(-0600)] <cindyli> there's another way to make wordpress perform better but still not perfect

[13:42:37 CST(-0600)] <cindyli> anastasiac: can you try in these steps and see if it looks better?

[13:43:11 CST(-0600)] <cindyli> 1. go to themes/fluid-studios/functions.php, comment out line 13, 14, where the thumbnail width and height get set

[13:44:04 CST(-0600)] <cindyli> 2. login wordperss as admin -> dashboard -> settings -> media, set "thumbnail size" to 420 * 160

[13:44:12 CST(-0600)] <cindyli> 3. back to index page and refresh

[14:02:45 CST(-0600)] <anastasiac> cindyli, I tried your suggestion to adjust the wordpress thumbnail size instead of in functions.php - it doesn't seem to be working. The images are fixed at 250x250

[14:03:22 CST(-0600)] <cindyli> anastasiac: did you comment the thumbnail size setting in functions.php?

[14:03:35 CST(-0600)] <anastasiac> yes, lines 13 and 14

[14:04:04 CST(-0600)] <anastasiac> I think those settings in the media settings are for when the author elects to insert a thumbnail into their post

[14:04:07 CST(-0600)] <anastasiac> does it work for you?

[14:04:36 CST(-0600)] <cindyli> yes, it does give me a better arrangement although not perfect yet

[14:04:37 CST(-0600)] <cindyli> your images are in square or rectangle originally?

[14:04:47 CST(-0600)] <anastasiac> it's square, at 250x250

[14:04:55 CST(-0600)] <cindyli> right. that's the point

[14:04:56 CST(-0600)] <anastasiac> oh, wait, you said originall

[14:05:10 CST(-0600)] <anastasiac> the images I uploaded are random size, mostly some form of rectangular

[14:05:11 CST(-0600)] <cindyli> yes, originally

[14:05:18 CST(-0600)] <cindyli> i see

[14:05:55 CST(-0600)] <cindyli> ok, more trying

[14:23:27 CST(-0600)] <anastasiac> cindyli, I'm thinking a bit about the images on the front page… we'd like to take advantage of wordpress' cropping, but as for what size they are displayed on the front page, that really should be controlled using CSS. Right now, wordpress is actually hardcoding the dimensions right into the <img> tag, which is not good.

[14:24:28 CST(-0600)] <cindyli> ok, anastasiac

[14:27:24 CST(-0600)] <cindyli> um.. let me see if we still can make use of featured image but using css to control the thumbnail size

[14:53:12 CST(-0600)] <cindyli> anastasiac: some findings with thumbnail display. wordpress crops the image and generates the thumbnail version when the image gets uploaded. So the later change on the pre-defined thumbnail width/height breaks the display of the thumbnails that were uploaded before the change

[14:53:31 CST(-0600)] <cindyli> you can try by re-uploading and re-setting the featured image

[14:53:41 CST(-0600)] <anastasiac> ah, hm. ok, I'll try that

[14:53:53 CST(-0600)] <michelled> cindyli: I was looking at your pull request for limiting the size of the title - any chance we can limit it as they are entering rather than showing an error message after the fact?

[14:55:01 CST(-0600)] <cindyli> michelled: do you mean that the users are not able to input the string that is longer than the liimit?

[14:55:24 CST(-0600)] <cindyli> like restricitng the valid length of the input field?

[14:55:40 CST(-0600)] <michelled> yes

[14:55:48 CST(-0600)] <cindyli> michelled: ok, let me try

[14:56:31 CST(-0600)] <anastasiac> cindyli, the image size works now, with newly uploaded image. But the size is still hard-coded into the HTML… We're going to have to find a way to fix that at some point, if we can...

[15:10:52 CST(-0600)] <cindyli> yes, anastasiac, wordpress provides a way to apply user-defined classes onto the post thumbnail <img> tag. i tried but noticed the user-set width/height does not overwrite the wordpress generated ones. sad…

[15:11:43 CST(-0600)] <anastasiac> no, css won't override hard-coded dimensions. We need a way to remove the html attributes

[15:12:44 CST(-0600)] <cindyli> ah, ah, that sounds even more challenging

[15:25:11 CST(-0600)] <michelled> anastasiac, cindyli: please comment on my pull request if you see anything I shouldn't be doing: https://github.com/fluid-project/studios.fluidproject.org/pull/11

[15:25:27 CST(-0600)] <cindyli> ok, michelled

[15:26:29 CST(-0600)] <cindyli> i'm closing my pull request 9 that's to restrict the post title length. i will send in another pull request soon that uses michelled's suggested way

[15:38:08 CST(-0600)] <cindyli> michelled: i've sent another pull request on controlling the length of the post title - https://github.com/fluid-project/studios.fluidproject.org/pull/12

[15:39:00 CST(-0600)] <anastasiac> michlled, I've commented on some of your pull request. Let me know if it doesn't make any sense.

[15:44:41 CST(-0600)] <cindyli> michelled: i have no comment on your pull request. :-P

[15:55:47 CST(-0600)] <michelled> thx anastasiac - I've pushed a new version and commented on your comments

[15:55:56 CST(-0600)] <anastasiac> k

[16:06:42 CST(-0600)] <anastasiac> michelled, I've issued a pull request to fix up the sidebar issues: https://github.com/fluid-project/studios.fluidproject.org/pull/13

[16:06:59 CST(-0600)] <anastasiac> I'm not quite sure of the appropriateness of the changes I made in the last commit, so extra attention there would be good

[16:08:52 CST(-0600)] <anastasiac> michelled, I've also pushed what I've got so far for a small-screen theme (i.e. phone in portrait mode). The branch is called STUDIO-5-mobile-theming. No pull request yet, it's still very much in progress, but since I won't be in tomorrow, I didn't want to leave anything I'm working on un-available.

[16:13:20 CST(-0600)] <michelled> thx anastasiac - I'll have a look tomorrow