fluid-work IRC Logs-2011-12-07

Owned by Fluid IRC Log Bot
Last updated: Dec 07, 2011Version comment
4 min read

[15:00:47 CST(-0600)] <peterjhart> I believe I found a bug in Fluid 1.4.0 in uPortal4. Is this the right place to talk about it?

[15:06:02 CST(-0600)] <jessm> peterjhart: yes, or you can submit the bug to our issue tracker: http://issues.fluidproject.org

[15:18:50 CST(-0600)] <peterjhart> I don't have a Jira account

[15:20:14 CST(-0600)] <peterjhart> fluid.reorderer.labeller.renderLabel() passes a jQuery object to fluid.dom.getElementText() instead of a DOM object.

[15:20:18 CST(-0600)] <peterjhart> Anyone seen that before?

[15:21:34 CST(-0600)] <jessm> colinclark: any thoughts? ^

[15:32:41 CST(-0600)] <colinclark> hi, sorry, just catching up

[15:33:13 CST(-0600)] <colinclark> peterjhart: That issue sounds vaguely familiar

[15:33:18 CST(-0600)] <colinclark> I'll have a quick look at the code

[15:33:28 CST(-0600)] <colinclark> but in the meantime, can you tell me any more about when you're seeing this issue?

[15:41:52 CST(-0600)] <peterjhart> colinclark: when a user signs in to uPortal4, this bug shows up on every page view (at least in FF firebug). I think this is because it has to do with reordering portlets in uPortal

[15:42:37 CST(-0600)] <colinclark> athena: Is this an issue you've encountered before?

[15:42:44 CST(-0600)] <peterjhart> fluid.reorderer.labeller.renderLabel() calls getElementText() and passes it this: fluid.unwrap(labelSource)

[15:43:00 CST(-0600)] <peterjhart> I looks like fluid.unwrap() passes back a jQuery object

[15:43:17 CST(-0600)] * athena looks up

[15:43:26 CST(-0600)] <athena> i haven't seen it no

[15:43:37 CST(-0600)] <athena> we have a nightly build up, if anyone wants to take a look

[15:43:46 CST(-0600)] <athena> https://up40-nightly.jasig.org/

[15:43:51 CST(-0600)] <peterjhart> getElementText() takes that object and tries to get childNodes, which isn't a property of jQuery

[15:44:22 CST(-0600)] <athena> by the way colinclark, i watched a cool lecture last night for school on accessibility and cloud-based services and integrating things like mechanical turk

[15:44:49 CST(-0600)] <colinclark> Reorderer looks pretty hot in your nightly build, athena

[15:45:22 CST(-0600)] <peterjhart> initially, I am not able to duplicate the problem in the nightly :{color}

[15:45:22 CST(-0600)] <colinclark> athena: Did the show cover Jeff Bigham at Rochester, athena?

[15:45:35 CST(-0600)] <athena> it was delivered by him, in fact (smile)

[15:45:37 CST(-0600)] <athena> really enjoyed it

[15:45:40 CST(-0600)] <colinclark> He's so awesome!

[15:45:49 CST(-0600)] <athena> yeah it was terrific!

[15:45:52 CST(-0600)] <colinclark> You'd like him

[15:45:56 CST(-0600)] <athena> archive is public if you want to see it

[15:45:57 CST(-0600)] <athena> http://norfolk.cs.washington.edu/htbin-post/unrestricted/colloq/details.cgi?id=987

[15:45:59 CST(-0600)] <athena> yeah i'd imagine so

[15:46:35 CST(-0600)] <colinclark> peterjhart: Do you have a public URL where I could see the issue in action?

[15:49:58 CST(-0600)] <peterjhart> http://ci.openccc.net/uPortal tester :: test1234

[15:50:36 CST(-0600)] <peterjhart> I see the line that is causing me the problem in the nightly. Hmm

[15:51:08 CST(-0600)] <colinclark> Is there maybe something different about your markup

[15:51:09 CST(-0600)] <colinclark> ?

[15:51:25 CST(-0600)] <colinclark> I have this vague memory of problems with the Reorderer in cases where a label wasn't correctly specified in the markup

[15:51:27 CST(-0600)] <colinclark> which is still a bug

[15:51:34 CST(-0600)] <colinclark> but a bug in the sense that it should throw an error

[15:51:43 CST(-0600)] <colinclark> since the label is used for accessibility purposes, if I remember correctly

[15:52:35 CST(-0600)] <colinclark> peterjhart: Will I see the error when I use the "Customize" menu?

[15:52:54 CST(-0600)] <peterjhart> when you sign in

[15:52:58 CST(-0600)] <peterjhart> it happens on page load

[15:53:02 CST(-0600)] <peterjhart> any page

[15:53:06 CST(-0600)] <peterjhart> after signin

[15:53:08 CST(-0600)] <colinclark> ah, yes

[15:55:57 CST(-0600)] <colinclark> peterjhart: I'm just doing some testing

[16:13:56 CST(-0600)] <colinclark> peterjhart: Yes, it looks to me like your draggable port let doesn't have a title

[16:14:05 CST(-0600)] <colinclark> Which is used for the accessible labels on each item

[16:14:17 CST(-0600)] <colinclark> among other things, these are used by screen readers to help describe the user interface

[16:14:27 CST(-0600)] <colinclark> I don't know if this is specifically mentioned in our documentation

[16:15:08 CST(-0600)] <colinclark> Let me just work out what you'd need to do to fix

[16:16:30 CST(-0600)] <colinclark> If I remember correctly, the Reorderer's "grabHandle" element needs to have some text in it, representing the label of the portlet

[16:16:39 CST(-0600)] <colinclark> this could, if you needed, hidden from view

[16:17:03 CST(-0600)] <colinclark> or it might be the title of your portlet; in this case, perhaps "Welcome to OpenCCC"

[16:18:50 CST(-0600)] <peterjhart> ok

[16:19:13 CST(-0600)] <peterjhart> I am glad it can be fixed by different markup

[16:19:24 CST(-0600)] <colinclark> I'll make your site more accessible, to boot

[16:19:29 CST(-0600)] <peterjhart> thanks for looking into it for me.

[16:19:42 CST(-0600)] <colinclark> if you don't want a label on your dragHandle

[16:19:49 CST(-0600)] <colinclark> you can specify a different selector to the Reorderer

[16:19:58 CST(-0600)] <colinclark> called "labelSource"

[16:20:08 CST(-0600)] <colinclark> which could point to any element, visible or not, with the title for your portlet

[16:20:55 CST(-0600)] <colinclark> So, you might use this in the case where you really don't want any kind of grabHandle

[16:21:27 CST(-0600)] <colinclark> Based on what I see in your portal design, if you want your portlets to be draggable, you might want to include some specific visual affordance that they are indeed draggable

[16:21:32 CST(-0600)] <colinclark> like in athena's build of uP4

[16:21:50 CST(-0600)] <colinclark> But if that's something you really don't want to have, you can just pass that "labelSource" selector to the Reorderer

[17:59:38 CST(-0600)] <peterjhart> I got it working in my dev again. Thanks everyone for helping. athena: This happens when you hide the portlet window chrome.

[18:00:09 CST(-0600)] <athena> ah, interesting

[18:00:16 CST(-0600)] <athena> there something we need to fix there?

[18:01:01 CST(-0600)] <peterjhart> Yep. Reorderer doesn't work when you take the chrome off.

[18:01:32 CST(-0600)] <peterjhart> I guess you couldn't reorder it anyway.... Hmm.

[18:04:11 CST(-0600)] <athena> does the reorderer just not work for that item, or can you not reorder any of the items on the page?

[18:07:52 CST(-0600)] <peterjhart> specifically, the reorderer has an exception on page load when there is a portlet without window chrome. But, without window chrome, there is nothing to click and drag. Our client only needs reordering to work in the fragment editor. Is there a way to set that easily?

[18:13:35 CST(-0600)] <athena> i'm wondering if at least in the fragment editor we need to add an alternate drag handle for portlets w/ no chrome

[18:13:46 CST(-0600)] <athena> and beyond that, certainly the page shouldn't error out

[18:13:49 CST(-0600)] <athena> could you file a bug in JIRA?

[18:14:08 CST(-0600)] <peterjhart> which one? Jasig?

[18:14:15 CST(-0600)] <athena> yep (smile)