fluid-work IRC Logs-2011-12-15

[08:29:12 CST(-0600)] <kasper> yura1, ping

[08:56:42 CST(-0600)] <yura1> kasper:

[08:56:43 CST(-0600)] <yura1> hi

[08:57:16 CST(-0600)] <yura1> kasper: you should also join our #fluid-tech channel , we discuss sum fun stuff there sometimes

[09:04:34 CST(-0600)] <cindyli> michelled, anastasiac, the pull request for IE8 styling issue is ready for review: https://github.com/fluid-project/studios.fluidproject.org/pull/32

[09:05:06 CST(-0600)] <michelled> thx cindyli

[09:05:10 CST(-0600)] <cindyli> np

[09:06:47 CST(-0600)] <michelled> cindyli: why did you need to change from using 'bloginfo' to 'echo'?

[09:07:28 CST(-0600)] <cindyli> michelled: bloginfo is a function that's being called over and over again, which is unnecessary considering the performance

[09:07:50 CST(-0600)] <michelled> echo is more performant?

[09:08:45 CST(-0600)] <michelled> cindyli: ^

[09:08:59 CST(-0600)] <cindyli> well, the point is not at the 'echo', it's to save the function returned value into a var and access that var afterwards using 'w=echo'

[09:09:08 CST(-0600)] <cindyli> typo, 'echo'*

[09:10:46 CST(-0600)] <michelled> cindyli: I'm confused - I don't see anywhere that assigns the results of the call to echo to a var

[09:11:37 CST(-0600)] <cindyli> wp-content/themes/fluid-studios/header.php

[09:11:37 CST(-0600)] <cindyli> line 22

[09:11:41 CST(-0600)] <cindyli> michelled: ^

[09:12:32 CST(-0600)] <michelled> oh, so the call to echo is actually using the variable (smile)

[09:12:37 CST(-0600)] <cindyli> exactly

[09:12:37 CST(-0600)] <michelled> thx for explaining cindyli

[09:12:39 CST(-0600)] <cindyli> n

[09:12:41 CST(-0600)] <cindyli> np

[09:13:01 CST(-0600)] <michelled> cindyli: it looks like you took out the link to the Neuton font - was that intentional?

[09:13:21 CST(-0600)] <cindyli> michelled: that has been moved into style-media.css

[09:14:03 CST(-0600)] <michelled> why was it moved cindyli?

[09:14:09 CST(-0600)] <cindyli> along with "@media"s. As mentioned in the pull request - "The mix of the regular css classes and https://github.com/import, https://github.com/media keywords in one single css file is not handled properly in IE8."

[09:14:49 CST(-0600)] <michelled> ok, thanks cindyli

[09:14:52 CST(-0600)] <cindyli> np

[09:18:55 CST(-0600)] <michelled> cindyli: what about stylesheet_url?

[09:20:14 CST(-0600)] <cindyli> michelled: since we now have 2 stylesheets, which i think different calls to retrieve them only introduces confusing

[09:20:52 CST(-0600)] <michelled> can you point me to where they are being included?

[09:21:28 CST(-0600)] <cindyli> header.php, line 40, 41

[09:22:09 CST(-0600)] <michelled> cindyli: shouldn't the inclusion of style_media be in an if?

[09:22:24 CST(-0600)] <michelled> if not IE < 9?

[09:23:02 CST(-0600)] <cindyli> no, it needs to be there at the presence of any browser

[09:23:29 CST(-0600)] <cindyli> what i did was to split one style.css into two: style.css & style_media.css

[09:23:37 CST(-0600)] <michelled> so IE just doesn't like them in a single file/

[09:23:38 CST(-0600)] <michelled> ?

[09:23:43 CST(-0600)] <michelled> it's fine with them split out into 2 files?

[09:23:45 CST(-0600)] <cindyli> yes, exactly

[09:23:48 CST(-0600)] <michelled> wow

[09:24:01 CST(-0600)] <cindyli> interesting, right? took me a while to figure out

[09:24:26 CST(-0600)] <michelled> that's crazy! I'm glad you figured it out

[09:25:16 CST(-0600)] <cindyli> i'm glad too. (smile)

[09:26:22 CST(-0600)] <colinclark> woah, weird new TextMate

[09:26:26 CST(-0600)] <colinclark> No more drawer

[09:51:47 CST(-0600)] <michelled> cindyli: what are you working on at the moment?

[09:58:45 CST(-0600)] <cindyli> michelled: in priority order - 1. studio-31 pul request: use proper js function; 2. limit post title length - I've found a way but will need you and anastasiac to have a look on the way that the error is prompted; 3. studio-25 - haven't started yet

[10:02:01 CST(-0600)] <cindyli> michelled: just noticed that you've merged studio-31 pul request into the project repo? should I write a proper js function for the go-back link?

[10:03:10 CST(-0600)] <michelled> cindyli: I think it's worth doing, don't you? I merged in your changes so we could test the dev site in IE

[10:03:32 CST(-0600)] <cindyli> cool. michelled. proceeding..

[10:15:59 CST(-0600)] <anastasiac> cindyli, I have a question about the difference between a PageEnhancer and a UIEnhancer. I know our demos and tests for FatPanelUIOptions work with a PageEnhancer on the page. Should they also work with a regular UIEnhancer, or does the PageEnhancer offer something special that FatPanelUIOptions needs?

[10:26:52 CST(-0600)] <cindyli> anastasiac: one difference is that pageEnhancer registers its child, UIEnhancer, into staticEnvironment

[10:27:08 CST(-0600)] <cindyli> i think all our demos should use pageEnhancer tho

[10:27:29 CST(-0600)] <anastasiac> ah, interesting. So if I wanted to use UIEnhancer, I'd have to register the enhancer into the environment… that explains the errors I'm seeing

[10:28:08 CST(-0600)] <cindyli> what errors are you seeing? with fluid studios? anastasiac

[10:29:07 CST(-0600)] <anastasiac> yes, cindyli, I'm trying to apply the global theme to the html element instead of the body. PageEnhancer defaults to body, so I have to use UIEnhancer instead.

[10:29:24 CST(-0600)] <cindyli> i see

[10:32:07 CST(-0600)] <cindyli> anastasiac: you need UIEnhancer in this case, or i'm thinking maybe you can still use pageEnhancer by overridding the UIEnhancer container to a specific html element

[10:41:53 CST(-0600)] <cindyli> anastasiac: by looking into the code, overriding the UIEnhancer container seems not practical. The munging on container was not built into enhancer

[10:42:15 CST(-0600)] <anastasiac> cindyli, do you mean uienhancer, or page enhancer?

[10:42:25 CST(-0600)] <cindyli> page enhancer

[10:42:44 CST(-0600)] <anastasiac> right, that's why I'm trying to use uienhancer directly, instead of page enhancer

[10:51:46 CST(-0600)] <anastasiac> so michelled and cindyli: it seems you currently can't put the uienhancer on the html element because the way it calculates text size in px assumes that the 'container' has a parent, which <html> doesn't

[10:53:11 CST(-0600)] <cindyli> anastasiac: i wonder how your container can be <html> element?

[10:53:37 CST(-0600)] <anastasiac> cindly, I deliberately set the container to html - that's the whole reason I'm using uienhancer instead of page enhancer

[10:53:54 CST(-0600)] <anastasiac> I'm trying to apply the themes to the entire document, not just the <body> element

[10:54:19 CST(-0600)] <anastasiac> I think I'll try michelled's suggestion of a hook into an event, and not use UIO's theme switching

[10:57:03 CST(-0600)] <cindyli> ok, anastasiac. i'm still curious why entire document? anything in <header> that needs to be manipulated?

[10:57:46 CST(-0600)] <anastasiac> no, I'm trying to add the background pattern to the space off to the right of the "show prefs" button by placing it on the entire HTML

[10:58:02 CST(-0600)] <anastasiac> that works, but when you switch themes in uio, it doesn't get rid of the pattern

[11:02:41 CST(-0600)] <cindyli> ah. ok

[11:40:30 CST(-0600)] greggy Is

[12:46:49 CST(-0600)] <cindyli> michelled, anastasiac, i just submitted a pull request to deal with the issue that the "go back" link only steps back one level - https://github.com/fluid-project/studios.fluidproject.org/pull/35

[12:47:35 CST(-0600)] <michelled> thx cindyli

[12:47:39 CST(-0600)] <cindyli> np

[12:47:51 CST(-0600)] <cindyli> michelled, anastasiac, do you have a minute to have a look and discuss about the behaviour of the plugin that's to control the post title length at my desk?

[12:48:21 CST(-0600)] <michelled> cindyli: anastasiac is on a call

[12:48:27 CST(-0600)] <michelled> we can chat once she's done

[12:48:37 CST(-0600)] <cindyli> sounds good

[13:42:36 CST(-0600)] <anastasiac> cindlyli, I have a question about the UIO "onUIOptionsRefresh" option: Should this event fire any time an option is changed using a FatPanel control?

[13:43:38 CST(-0600)] <anastasiac> cindyli: ^

[13:44:12 CST(-0600)] <cindyli> anastasiac: let me find out

[13:44:39 CST(-0600)] <anastasiac> cindyli, it seems to me that it should fire when a setting is changed, but it's not - only on save or reset

[13:44:48 CST(-0600)] <anastasiac> but I could be misunderstanding

[13:44:57 CST(-0600)] <cindyli> ah, interesting

[13:47:17 CST(-0600)] <cindyli> anastasiac: yes, it's only fired at save or reset, which seems making sense by what it does. this event refreshes the UIO interface itself which only supposed to happen when the settings are confirmed and saved

[13:48:05 CST(-0600)] <anastasiac> ah, ok, so it's not about refreshes to the page, but refreshes to the UIO only. Ok, then listening to modelChanged is what I should be doing (and am)

[13:48:11 CST(-0600)] <anastasiac> thanks for the double-check, cindyli

[13:48:17 CST(-0600)] <cindyli> np, anastasiac

[13:59:01 CST(-0600)] <anastasiac> michelled, I've issued a pull request for STUDIO-36, putting the background pattern on the right side of the page

[13:59:09 CST(-0600)] <anastasiac> https://github.com/fluid-project/studios.fluidproject.org/pull/36

[14:02:05 CST(-0600)] <michelled> thx anastasiac

[14:17:44 CST(-0600)] <michelled> colinclark: when you get a chance can you look at my studios pull request?

[14:18:11 CST(-0600)] <michelled> It's for STUDIO-35 which are several styling tweaks as requested by jvass

[14:32:38 CST(-0600)] <michelled> colinclark: hang on a moment - there's another tweak that jameswy has asked for - I'm doing it as part of STUIO-35 as well

[14:34:42 CST(-0600)] <colinclark> sure

[14:57:28 CST(-0600)] <michelled> colinclark: ok, I've pushed up the fix that jameswy asked for

[14:57:41 CST(-0600)] <michelled> when you have a chance please review the pull request

[14:58:02 CST(-0600)] <colinclark> ok

[15:14:00 CST(-0600)] <michelled> colinclark: I've got another pull request for you to look at - just adding in a favicon - STUDIO-32

[15:47:06 CST(-0600)] <colinclark> ok