fluid-work IRC Logs-2011-12-06

Owned by Fluid IRC Log Bot
Last updated: Dec 06, 2011Version comment

[10:05:07 CST(-0600)] <cindyli> michelled: i tried Bosmon's branch, which does solve the jumping issue but introduces a blank gap above the UIO menu bar

[10:08:31 CST(-0600)] <michelled> cindyli: can you look into what's causing the white space?

[10:08:57 CST(-0600)] <michelled> we will eventually be merging that branch into the main repo so we'll need to solve this problem at some point

[10:09:07 CST(-0600)] <cindyli> michelled: ya, looking into, i guess might be something like the iframe height

[10:09:22 CST(-0600)] <michelled> what JIRA are you working off?

[10:09:35 CST(-0600)] <cindyli> STUDIO-3

[10:09:46 CST(-0600)] <michelled> can you create a new JIRA for the jumping issue?

[10:10:17 CST(-0600)] <cindyli> ok, michelled

[10:10:19 CST(-0600)] <michelled> I'm going to create some for the stuff that's left in STUDIO-3 and close STUDIO-3 - it's getting too confusing to see what's left

[10:10:35 CST(-0600)] <cindyli> that makes sense

[11:13:36 CST(-0600)] <cindyli> michelled: forgot to mention, i've created STUDIO-6 for the jumping issue

[11:33:39 CST(-0600)] <michelled> thx!

[11:50:32 CST(-0600)] <michelled> cindyli: anastasiac's fix for the top white space is here: https://github.com/acheetham/studios.fluidproject.org/blob/ba3b7f60799e0b515af1a99696671167e5c9b29d/wp-content/themes/fluid-studios/style.css#L408-410

[11:50:51 CST(-0600)] <cindyli> cool

[11:50:56 CST(-0600)] <michelled> cindyli: it's not related to fixing the positioning of the footer but is in the same pull request

[11:51:16 CST(-0600)] <cindyli> i see

[13:09:53 CST(-0600)] <kasper> colinclark: is jutta gonna be joining the ISO meeting today?

[13:14:39 CST(-0600)] <kasper> yura1, can you kick colin? (smile)

[13:14:56 CST(-0600)] <yura1> if only he was here, i think he went for lunch

[13:15:14 CST(-0600)] <kasper> oh ok.. do you have any idea whether Jutta will be joining the ISO meeting today?

[13:15:18 CST(-0600)] <kasper> by any chance

[13:16:39 CST(-0600)] <kasper> yura1, nevermind - we gave up (smile)

[13:17:22 CST(-0600)] <yura1> kasper: sorry not sure

[13:17:46 CST(-0600)] <kasper> hehe, np .. I'm gonna have a hard time blaming this one on you (though I wish I could)

[13:46:14 CST(-0600)] <cindyli> Bosmon: r u there?

[14:01:12 CST(-0600)] <Bosmon> Hi cindyli

[14:19:22 CST(-0600)] <cindyli> Bosmon: the UIO inside sakai integration demo from your 4525 branch is broken. seems due to the missing of "FatPanelUIOptions.css"

[15:18:37 CST(-0600)] <cindyli> michelled: i won't be in tomorrow, so wanna update you with where I am. unfortunately, not much progress. I found that the gap above the UIO menu is very likely from the iframe 'cuz once deleting the iframe from DOM, the gap is gone. However, haven't figured out where in the iframe that causes the gap.

[15:20:12 CST(-0600)] <michelled> thanks cindyli

[15:20:26 CST(-0600)] <cindyli> np, michelled

[15:20:29 CST(-0600)] <michelled> can you push everything you've got to your github and comment on the JIRA with your status?

[15:20:38 CST(-0600)] <michelled> cindyli: that way someone else can pick it up

[15:20:40 CST(-0600)] <cindyli> sure

[15:21:32 CST(-0600)] <Bosmon> cindyli - thanks for the note, I'll add it into my branch

[15:21:47 CST(-0600)] <cindyli> np, thanks, Bosmon

[15:21:57 CST(-0600)] <Bosmon> It's odd though... I don't think I invented that CSS file, did I?

[15:22:08 CST(-0600)] <cindyli> no, it was there before

[15:22:32 CST(-0600)] <cindyli> the bug probably has been there for a while. :-P

[15:22:55 CST(-0600)] <Bosmon> Ok, that makes sense

[15:23:20 CST(-0600)] <Bosmon> cindyli - the gap issue - does it only appear in the wordpress context?

[15:23:28 CST(-0600)] <Bosmon> I don't think I see a gap in our demos?

[15:23:33 CST(-0600)] <cindyli> no, Bosmon, in the sakai demo as well

[15:23:41 CST(-0600)] <cindyli> not in UIO regular demo tho

[15:23:46 CST(-0600)] <Bosmon> That's pretty interesting

[15:23:50 CST(-0600)] <cindyli> ya

[15:23:55 CST(-0600)] <Bosmon> I will take a look when I add that CSS file back in

[15:24:02 CST(-0600)] <cindyli> thanks, Bosmon

[15:24:12 CST(-0600)] <Bosmon> Does the gap appear constantly, or only when the page is first opened?

[15:24:30 CST(-0600)] <cindyli> Bosmon: only at first opened.

[15:24:37 CST(-0600)] <Bosmon> Interesting...

[15:24:46 CST(-0600)] <Bosmon> So when you open the panel for the first time, the gap closes up permanently?

[15:24:51 CST(-0600)] <Bosmon> Or does it close up once page load is finished?

[15:25:35 CST(-0600)] <cindyli> Bosmon: with your branch, the gap stays there without closing up

[15:25:54 CST(-0600)] <cindyli> unless, the UIO panel gets opened and closed,

[15:25:59 CST(-0600)] <cindyli> the gap will be gone

[15:26:17 CST(-0600)] <Bosmon> Ok, thanks

[15:26:39 CST(-0600)] <cindyli> it's 'cuz the old implementation was, the div that contains the iframe was set with "display: none" at the page open

[15:27:38 CST(-0600)] <Bosmon> Right

[15:27:40 CST(-0600)] <cindyli> but this "display: none" has been removed from your branch, at the first page open. this styling is put back after the slidingPanel hide() is performed

[15:27:53 CST(-0600)] <Bosmon> Oh, I see

[15:27:59 CST(-0600)] <Bosmon> I'm not sure that should happen....

[15:28:12 CST(-0600)] <cindyli> what should happen?

[15:28:22 CST(-0600)] <cindyli> the initial setting of "display:none"?

[15:28:28 CST(-0600)] <Bosmon> Well, I removed all explicit hide/show from the SlidingPanel implementation

[15:28:41 CST(-0600)] <Bosmon> So there shouldn't be this inconsistency

[15:28:46 CST(-0600)] <Bosmon> At the very least, the gap should stay there all the time (smile)

[15:29:14 CST(-0600)] <Bosmon> Perhaps the built-in jQuery effect of "slideUp" is for the element to become hidden at the end?

[15:29:30 CST(-0600)] <cindyli> ah, that's a possibility

[15:29:36 CST(-0600)] <Bosmon> Ok, looks like it is

[15:29:41 CST(-0600)] <Bosmon> The jQuery source has: slideUp: genFx("hide", 1),

[15:29:48 CST(-0600)] <cindyli> wu hu

[15:30:17 CST(-0600)] <Bosmon> Ok, this makes sense of what is happening, but doesn't bring us that much closer to a solution...

[15:30:27 CST(-0600)] <Bosmon> But in theory, given our own demo is working fine, this should be relatively simple

[15:31:09 CST(-0600)] <cindyli> i do hope. but i couldn't find where the gap comes from

[15:31:55 CST(-0600)] <Bosmon> I had to remove the "display: none" from the initial markup since it caused a horrifying timing issue

[15:32:09 CST(-0600)] <Bosmon> On FF in particular, the iframe existed in a crazy kind of "half-allocated state"

[15:32:24 CST(-0600)] <Bosmon> It had JS which had initialised but had not got the data structures for its DOM allocated

[15:32:31 CST(-0600)] <Bosmon> So any CSS operations would fail with a hard exception

[15:33:49 CST(-0600)] <cindyli> i see

[15:34:08 CST(-0600)] <Bosmon> I don't know how we got around this issue before, but the timings with this new implementation are very different from with the "other world" version

[15:34:14 CST(-0600)] <Bosmon> And in general lots of things happen much faster

[15:34:43 CST(-0600)] <cindyli> sounds a worthy trade-off

[15:34:52 CST(-0600)] <Bosmon> I remember immediately after the release, we found some issues with the FatPanel simply not opening at all

[15:35:04 CST(-0600)] <Bosmon> Which may have resulted from a probabilistic triggering of this issue

[15:35:35 CST(-0600)] <Bosmon> Anyway, thanks for testing out the branch

[15:35:42 CST(-0600)] <Bosmon> Hopefully I'll have something to report before tomorrow

[15:35:48 CST(-0600)] <cindyli> lol

[15:35:52 CST(-0600)] <cindyli> no pressure ..