fluid-work IRC Logs-2010-10-29

[08:47:49 CDT(-0500)] <golam> testing http://webchat.freenode.net/
[08:54:19 CDT(-0500)] <Justin_o> golam: looks like it's working
[08:55:39 CDT(-0500)] <Justin_> Golam: looks like it's also working from my phone. Which is kind of cool.
[08:55:40 CDT(-0500)] <golam> Justin_o: cool ..there was no setup time
[08:56:28 CDT(-0500)] <Justin_o> golam: do you get notifications when someone pings you?
[08:56:43 CDT(-0500)] <golam> I just hear a noise
[08:57:12 CDT(-0500)] <golam> but I am sure there is some sort of popup
[08:58:48 CDT(-0500)] <golam> Justin_o: we should add this to our wiki
[08:59:24 CDT(-0500)] <Justin_o> golam: not a bad idea... if you have time, can you also double check if it is accessible
[09:00:24 CDT(-0500)] <golam> Justin_o: accessible? to check for aria options
[09:03:40 CDT(-0500)] <Justin_o> golam: when you get to checking out pager with a screen reader, you can see if the screen reader works okay with it as well... just a quick test, nothing exhaustive...
[09:03:58 CDT(-0500)] <Justin_o> more a curiosity thing.. so you don't have to do it
[09:04:01 CDT(-0500)] <golam> ok cool
[09:04:29 CDT(-0500)] <golam> I will check for accessibility
[09:04:59 CDT(-0500)] <Justin_o> golam: thanks...
[09:05:16 CDT(-0500)] <golam> if I am on different tab then it's highlights the tab for me
[09:05:52 CDT(-0500)] <golam> the tabs within the irc web app
[09:06:38 CDT(-0500)] <Justin_o> golam: that's cool...
[13:12:46 CDT(-0500)] <jhung> jameswy: meet in a few mins?
[13:13:09 CDT(-0500)] <jameswy> jhung: sure--can you ping erin too? (she's not on here)
[13:17:24 CDT(-0500)] <jhung> to everyone - Open invitation to join James, Erin, and I to chat about the design updates to the layout and list reorderers, and the keyboard plugin demo. We'll be meeting at 2:30p ET. Let me know if you're interested. Will meet either in Skype (jhung_ca) or in the Breeze room.
[15:41:12 CDT(-0500)] <Justin_o> Bosmon2: harris has been looking into those broken keyboard a11y unit tests...
[15:41:16 CDT(-0500)] <harris> Bosmon2: ping
[15:41:54 CDT(-0500)] <Bosmon2> Hi there harris
[15:42:00 CDT(-0500)] <Bosmon2> Just looking at your comments on this issue and the impl
[15:42:15 CDT(-0500)] <harris> hey antranig
[15:43:30 CDT(-0500)] <harris> yea, if you have a minute, i was wondering if you can advice me on this
[15:44:56 CDT(-0500)] <Bosmon2> My fix for FLUID-3721 was really terrible and something which should never have been done
[15:45:06 CDT(-0500)] <Bosmon2> But does seem to expose a genuine unclarity in the intent of the component....
[15:46:14 CDT(-0500)] <Bosmon2> Oh dear
[15:46:20 CDT(-0500)] <Bosmon2> I had forgotten how badly these test cases were written...
[15:46:58 CDT(-0500)] <Bosmon2> Just as a guide, please never use such a style with global utility functions exposing a shared singleton state
[15:47:05 CDT(-0500)] <Bosmon2> We should rewrite them at some point
[15:47:18 CDT(-0500)] <harris> mm, so this is just the testcases' problem?
[15:47:23 CDT(-0500)] <Bosmon2> I'm not sure yet
[15:48:01 CDT(-0500)] <harris> i traced it to jquery.keyboard-a11y.js, line 475; where it says "activeItemIndex: NO_SELECTION"
[15:48:52 CDT(-0500)] <harris> the variable was set to NO_SELECTION, which is -32768, and then "that" was passed to tabKeyHandler() function; which then was called in cleanUpWhenLeavingContainer() function.
[15:49:43 CDT(-0500)] <harris> which then it's not going into the condition in jquery.keyboard-a11y.js, line 276. (newly added in the trunk compared to 1.2.1)
[15:50:09 CDT(-0500)] <harris> if you simply comment line 276 and 286 out, the test cases run fine.
[15:52:19 CDT(-0500)] <Bosmon2> Yes
[15:52:24 CDT(-0500)] <Bosmon2> I think there really is an issue with the test cases
[15:52:51 CDT(-0500)] <Bosmon2> Since the operation of "getFirstMenuItem().focus()" should be in fact focusing the first element
[15:52:55 CDT(-0500)] <Bosmon2> But you can see that in fact it is not
[15:53:14 CDT(-0500)] <Bosmon2> So I think my conditional is actually exposing a fault in the test case implementation... not quite sure what it is yet though
[15:54:18 CDT(-0500)] <harris> Bosmon2: mm...
[15:59:03 CDT(-0500)] <harris> Bosmon2: For JIRA 3798, do you think I should fix the testcases then?
[15:59:55 CDT(-0500)] <Bosmon2> Ok, it looks like this "quickMakeSelectable" function is the problem
[16:00:10 CDT(-0500)] <Bosmon2> it is actually constructing a selectable with no elements
[16:00:33 CDT(-0500)] <harris> oh?
[16:00:55 CDT(-0500)] <Bosmon2> Well... all of these tests are really terribly designed in any case
[16:00:58 CDT(-0500)] <Bosmon2> It is no surprise
[16:10:21 CDT(-0500)] <Bosmon2> Ok, So I have made a small commit to fix the test cases
[16:10:29 CDT(-0500)] <Bosmon2> But I think we should leave a standing task to reorganise these in the future
[16:15:10 CDT(-0500)] <harris> Bosmon2: okay.
[16:15:16 CDT(-0500)] <harris> Bosmon2: Thanks!