fluid-work IRC Logs-2009-02-13
- Fluid IRC Log Bot
[07:23:27 EST(-0500)] * phiggins (n=dante@c-68-34-199-67.hsd1.tn.comcast.net) has joined #fluid-work <fj4000> ____:focus <colinclark> elemToFocusOnEvent: <colinclark> focusWithEvent
[07:55:32 EST(-0500)] * laurelw (n=Laurel@142.150.154.178) has joined #fluid-work
[08:23:16 EST(-0500)] * Justin_o (n=Justin@142.150.154.171) has joined #fluid-work
[09:09:34 EST(-0500)] * fj4000 (n=Main@CPE00095bc35ea1-CM001692f5798c.cpe.net.cable.rogers.com) has joined #fluid-work
[09:36:34 EST(-0500)] * EricDalquist (n=dalquist@bohemia.doit.wisc.edu) has joined #fluid-work
[09:43:19 EST(-0500)] * clown (n=clown@142.150.154.101) has joined #fluid-work
[09:50:49 EST(-0500)] * ecochran (n=ecochran@adsl-70-137-175-79.dsl.snfc21.sbcglobal.net) has joined #fluid-work
[09:50:59 EST(-0500)] <ecochran> Justin_o: g'morning
[09:51:12 EST(-0500)] <Justin_o> hello ecochran
[09:51:18 EST(-0500)] <ecochran> Justin_o: You can add 2008 to the needs review list
[09:51:39 EST(-0500)] <ecochran> Colin said that he'd get to it this morning
[09:52:17 EST(-0500)] <Justin_o> Yes... i realized that i forgot to add that after I sent it out sorry... i was going to add it after I closed 822 but the testing is taking me a little longer than I had expected
[09:52:35 EST(-0500)] <ecochran> Justin_o: np
[09:52:49 EST(-0500)] * anastasiac (n=team@142.150.154.189) has joined #fluid-work
[09:59:55 EST(-0500)] <Justin_o> ecochran: I have noticed that in IE and Opera for small files it doesn't seem to stop.... I'm not sure if this is because it is uploading so fast or if there is some other issue. If i try with a large file it will stop
[09:59:59 EST(-0500)] <Justin_o> have you noticed this at all
[10:01:03 EST(-0500)] <ecochran> ecochran: I have seen that but thought that it was just uploading too fast.
[10:01:22 EST(-0500)] <ecochran> Justin_o: I keep calling myself out, sorry
[10:01:45 EST(-0500)] <Justin_o> 
[10:01:50 EST(-0500)] <ecochran> Justin_o: what happens if you have a very long list of files?
[10:02:25 EST(-0500)] <Justin_o> i tried that and it worked... but I just noticed that a large file snuck into the mix... i'm going to try it again though...
[10:03:24 EST(-0500)] <Justin_o> i saw that you had created a bug for the issue of no feedback... i think this issue will be helped once that is taken care of
[10:04:33 EST(-0500)] <ecochran> Justin_o later this morning, when I get to the office, I'll look at the code again to see if there is a way to tighten up the timing.
[10:05:14 EST(-0500)] <Justin_o> ecochran: thanks... i guess i'll leave it open till then
[10:05:49 EST(-0500)] <ecochran> Justin_o: no promises... at the moment I don't have any brilliant ideas
[10:07:04 EST(-0500)] <Justin_o> no problem.. it seems to work with a larger list... it may be that the stop upload button isn't getting the click fast enough... i notice that if i stop it and then start again I had to click it twice (in IE 7 flash 10 )
[10:09:06 EST(-0500)] <Justin_o> ecochran: ^
[10:09:18 EST(-0500)] <ecochran> Justin_o: another thing to test is whether errors work the same as success with stopping the queue... you can test that by trying to upload the same files twice
[10:09:55 EST(-0500)] <Justin_o> yep... actually that's what i've been doing the second half of my testing (because I ran out of images)
[10:09:58 EST(-0500)] <Justin_o> same idea though
[10:10:12 EST(-0500)] <ecochran> Justin_o: I'm thinking about the double-click problem. That's seriously confusing, but I good thing to think about
[10:10:45 EST(-0500)] <Justin_o> i'm thinking that the first time that I clicked on it, maybe it didn't have the event bound to it
[10:11:12 EST(-0500)] <Justin_o> but i'm not sure
[10:12:39 EST(-0500)] <ecochran> Justin_o: and you're saying that you've only seen this on IE7/Flash10?
[10:13:06 EST(-0500)] <ecochran> 100% repro on that config?
[10:14:09 EST(-0500)] <ecochran> Justin_o: the event should already be bound to the button
[10:14:24 EST(-0500)] <Justin_o> I've seen it on Opera and IE the only place that i didn't notice was ie on w2k
[10:14:36 EST(-0500)] <ecochran> we've got two different buttons that get hidden and shown
[10:14:50 EST(-0500)] <Justin_o> i only tested the large list in IE 7 flash 10
[10:15:04 EST(-0500)] <Justin_o> afterwards i found the same on Opera in the same environment
[10:15:28 EST(-0500)] <Justin_o> i see... so the button is changed, not the event bound to it... got it
[10:15:34 EST(-0500)] <Justin_o> so it should be okay
[10:15:58 EST(-0500)] <ecochran> Justin_o: No, that makes the behavior even more confusing
[10:16:31 EST(-0500)] <ecochran> Justin_o: We do some disabling and enabling of the button for other states so I'm thinking that there is some leakage there
[10:16:49 EST(-0500)] <ecochran> Justin_o: OK, later, I have to jump in a shower and feed Hannah
[10:17:00 EST(-0500)] <Justin_o> okay... talk to you later
[10:17:02 EST(-0500)] <ecochran> More from the office in about an hour
[11:19:12 EST(-0500)] * mtheoryx83 (n=mtheoryx@c-98-228-108-233.hsd1.in.comcast.net) has joined #fluid-work
[11:31:52 EST(-0500)] * JASIGLogBot (n=PircBot@jasig.Princeton.EDU) has joined #fluid-work
[11:31:52 EST(-0500)] * Topic is 'Bug Parade February 11 - 16 http://issues.fluidproject.org/secure/IssueNavigator.jspa?mode=hide&requestId=10129' set by Justin_o on 2009-02-11 08:26:18 EST(-0500)
[11:34:28 EST(-0500)] * ecochran (n=ecochran@dhcp-169-229-212-104.LIPS.Berkeley.EDU) has joined #fluid-work
[11:38:39 EST(-0500)] * colinclark (n=colin@142.150.154.101) has joined #fluid-work
[11:38:58 EST(-0500)] <colinclark> so fj4000.
[11:39:03 EST(-0500)] <fj4000> Justin_o: finished reviewing 2018
[11:39:21 EST(-0500)] <colinclark> I don't want you to feel stuck on this dialog/ajax problem. How is it going, and how can those of us here in the channel help?
[11:39:28 EST(-0500)] <Justin_o> fj4000: thanks... did you mark your comments on the jira?
[11:39:44 EST(-0500)] <fj4000> Justin_o: yes - colinclark: yes
[11:41:50 EST(-0500)] <fj4000> colinclark - actually, I spent the last couple hours on other work (website, finguring out how to use the revision graph to review commits, etc) so I need to get back to it
[11:43:11 EST(-0500)] <colinclark> fj4000: Ok. someone here can help if you're stuck.
[11:43:33 EST(-0500)] <colinclark> We can pull Bosmon or ecochran or anastasiac or someone in if necessary. 
[11:43:39 EST(-0500)] <fj4000> k
[11:45:06 EST(-0500)] <ecochran> fj4000, colinclark : I can probably help after I looks at some interesting Uploader regressions, an hour or so?
[11:45:19 EST(-0500)] <colinclark> ecochran: Sounds great.
[11:45:20 EST(-0500)] <ecochran> or is this a higher priority
[11:45:56 EST(-0500)] <ecochran> Justin_o: do you have any more info for me on the double-click or the small files issues?
[11:47:04 EST(-0500)] <ecochran> colinclark: is giving fj4000 a hand a higher priority? 'Cause what I'm doing may be frosting on the cake at this point. Justin_o and I are still figuring out what's up.
[11:47:42 EST(-0500)] <colinclark> ecochran: Who I am to second-guess the King's priorities.
[11:48:04 EST(-0500)] <colinclark> Give fj4000 a bit of time to get back into it.
[11:48:05 EST(-0500)] <ecochran> OK, I'll let Justin_o tell me if he'd like me to switch horses
[11:48:11 EST(-0500)] <colinclark> If he's still stuck, then perhaps you can jump in.
[11:54:25 EST(-0500)] <Justin_o> ecochran: i think colinclark's prioritization makes sense...
[11:55:57 EST(-0500)] <Justin_o> I think I told you all that I know about the issue. Basically small files seem to upload so fast that you don't have a chance for the stop to happen.... with many files, after you stop, it seems that you need to click twice to get it to stop again.
[11:56:02 EST(-0500)] <Justin_o> ecochran: ^
[11:56:28 EST(-0500)] <ecochran> Justin_o: great, thanks. I'm looking now
[11:56:57 EST(-0500)] <Justin_o> ecochran: thanks... let me know if you need me to check anything out about it in particular
[12:10:29 EST(-0500)] <fj4000> Justin_o, ecochran: if either of you can help me, at this point I just dont know what the problem is with IE....I have a test patch to illustrate the issue that I can email
[12:10:59 EST(-0500)] <Justin_o> sure... please e-mail it out
[12:11:56 EST(-0500)] <fj4000> ok
[12:13:10 EST(-0500)] * apetro (n=apetro@wsip-98-174-242-39.ph.ph.cox.net) has joined #fluid-work
[12:15:52 EST(-0500)] * apetro_ (n=apetro@wsip-98-174-242-39.ph.ph.cox.net) has joined #fluid-work
[12:17:02 EST(-0500)] <ecochran> Justin_o, colinclark : I'm getting a script error when I try to use the Uploader off my server in IE... I'm looking into it now. If there is a problem it's probably in the code that's in the 2008 patch. I'll let you know shortly. IE... grumble grumble grumble
[12:17:31 EST(-0500)] <colinclark> ecochran: Urg. Good luck, dude. I'm sure you'll get it.
[12:22:15 EST(-0500)] <ecochran> colinclark: have a min?
[12:22:25 EST(-0500)] <colinclark> ecochran: On a call, but I will shortly.
[12:22:56 EST(-0500)] <ecochran> colinclark: that'd help, I've got something deeply puzzling and I need another set of eyes.
[12:26:25 EST(-0500)] <anastasiac> Justin_o: I'll have a go at reviewing FLUID-2150
[12:26:53 EST(-0500)] <Justin_o> anastasiac: thanks
[12:27:58 EST(-0500)] <colinclark> ecochran: sure, no problem
[12:28:32 EST(-0500)] <ecochran> colinclark: let me know when you're ready
[12:30:40 EST(-0500)] <Justin_o> fj4000: where does that file go
[12:30:43 EST(-0500)] <Justin_o> which directory
[12:30:51 EST(-0500)] <Justin_o> nevermind... found it
[12:40:22 EST(-0500)] * athena7 (n=athena7@12.164.139.7) has joined #fluid-work
[12:42:21 EST(-0500)] <athena7> hi all - i had some questions about the fluid skinning system, if anyone might be able to answer them
[12:43:09 EST(-0500)] <Justin_o> fj4000 would probably be the best person to ask, but he may be away at the moment
[12:43:28 EST(-0500)] <colinclark> athena7: Fire away and, at worst, we can ping fj4000 when he gets back.
[12:43:33 EST(-0500)] <athena7> ok
[12:44:17 EST(-0500)] <athena7> i don't have a lot of details for you, but it seems like some of the FSS styles cause some divs to contract slightly and briefly display scrollbars when a form is submitted
[12:44:25 EST(-0500)] <athena7> is this anything you've seen in the past?
[12:45:07 EST(-0500)] <fj4000> colinclark, athena7 can I help with something?
[12:45:22 EST(-0500)] <athena7> heya
[12:45:37 EST(-0500)] <fj4000> hi
[12:46:27 EST(-0500)] <fj4000> fss issues with scrolling?
[12:48:02 EST(-0500)] <athena7> yes, it seems that scrollbars briefly appear in some areas when a form is submitted
[12:48:15 EST(-0500)] <athena7> i wasn't sure if that was anything you all had seen before
[12:48:33 EST(-0500)] <athena7> i haven't experimented with it much, and i'm not the one that applied the CSS, so i don't have as many details as i otherwise would
[12:48:38 EST(-0500)] <fj4000> do you have a link? We have seen this before
[12:48:45 EST(-0500)] <athena7> i don't
[12:49:05 EST(-0500)] <fj4000> is it only a tiny bit of scrolling?
[12:49:09 EST(-0500)] <athena7> it'd be really nice if we had a public build to work on some of this stuff together
[12:49:10 EST(-0500)] <athena7> yep
[12:49:21 EST(-0500)] <fj4000> and only on form buttons?
[12:49:25 EST(-0500)] <athena7> is there likely something we're doing wrong?
[12:49:36 EST(-0500)] <fj4000> no, your not doing anything wrong
[12:49:49 EST(-0500)] <athena7> i'm not sure if it's buttons . . . it definitely seems to happen only on form submit though
[12:50:09 EST(-0500)] <fj4000> so, without seeing anything, I have a very rough notion
[12:50:26 EST(-0500)] <fj4000> try putting the following style on all the buttons that cause the issue :
[12:50:59 EST(-0500)]
[12:51:07 EST(-0500)] <fj4000> where ___ is the selector for your button
[12:51:40 EST(-0500)] <fj4000> FF has a small outline bug that might be causing this (unless its not FF specific)
[12:53:21 EST(-0500)] <athena7> interesting
[12:53:24 EST(-0500)] <athena7> i'll definitely try that out
[12:53:32 EST(-0500)] <athena7> i think it's more than just buttons though
[12:53:39 EST(-0500)] <athena7> divs, maybe?
[12:53:54 EST(-0500)] <fj4000> you put focus on divs?
[12:54:04 EST(-0500)] <athena7> let me look at the html
[12:54:45 EST(-0500)] <fj4000> any element that has focus, inside a container with overflow:auto that is a snug fit might show this bug
[12:55:14 EST(-0500)] <athena7> let me do a quick test to make sure which parts we're seeing it in
[12:55:38 EST(-0500)] <fj4000> ok
[12:55:50 EST(-0500)] <athena7> need to start up a different tomcat instance
[12:56:00 EST(-0500)] <athena7> seems like i always have too much going on at once
[12:59:34 EST(-0500)] <athena7> ok, yep
[12:59:40 EST(-0500)] <athena7> we're seeing it with the following html: http://uportal.pastebin.com/m10ee4f35
[12:59:57 EST(-0500)] <athena7> whenever the link is clicked, that area shows a scrollbar briefly before the window reloads
[13:01:18 EST(-0500)] <fj4000> are you using the latest nightly for the fss layout file?
[13:01:20 EST(-0500)] <athena7> no
[13:01:30 EST(-0500)] <athena7> i can do an update tonight though and see if it fixes our problems
[13:01:38 EST(-0500)] <athena7> does that sound like a good plan?
[13:01:41 EST(-0500)] <fj4000> there was a fix employed, where all the fl-containers dont use overflow:auto
[13:01:43 EST(-0500)] <fj4000> yes
[13:01:46 EST(-0500)] <athena7> excellent
[13:01:47 EST(-0500)] <athena7> thanks!
[13:01:51 EST(-0500)] <fj4000>
[13:01:52 EST(-0500)] <athena7> i'll definitely try that out then
[13:01:57 EST(-0500)] <athena7> thanks much for the help
[13:02:00 EST(-0500)] <fj4000> I hope that helps - pls let me know
[13:02:06 EST(-0500)] <athena7> by the way, are any of you fluid types on jasig-ue?
[13:02:31 EST(-0500)] <fj4000> I get mail from that list, yes
[13:02:48 EST(-0500)] <fj4000> several others here do as well I believe
[13:03:55 EST(-0500)] <athena7> awesome
[13:04:08 EST(-0500)] <athena7> there's been some conversation going on about CSS in portlets
[13:04:12 EST(-0500)] <athena7> i'm about to send a response
[13:04:45 EST(-0500)] <athena7> but if anyone here has opinions or input, it'd be great to have people involved who are more knowledgeable about UE topics
[13:15:29 EST(-0500)] <Justin_o> fj4000: and I have been talking about what to do with the ui options dialog
[13:15:30 EST(-0500)] <colinclark> athena7: I have it in my stack of emails to read and respond to, but haven't had a chance.
[13:15:36 EST(-0500)] <colinclark> Anything in particular I can help with?
[13:15:41 EST(-0500)] <athena7> yeah, that's where i've been at too colinclark
[13:15:47 EST(-0500)] <athena7> i finally got a response together this morning
[13:15:50 EST(-0500)] <colinclark>
[13:16:10 EST(-0500)] <athena7> so hard to respond to anything right now - i think i'm going to be swamped at least through the jasig conference
[13:16:49 EST(-0500)] <fj4000> Justin_o: did you come to a conclusion?
[13:17:26 EST(-0500)] <Justin_o> fj4000: not really... i'll list our options
[13:17:44 EST(-0500)] <colinclark> athena7: I know the feeling.
[13:17:47 EST(-0500)] <athena7> i bet
[13:17:55 EST(-0500)] <colinclark> I'm still trying to get some time to put together a good jQuery workshop.
[13:18:12 EST(-0500)] <colinclark> I think it will be fun, it's just a matter of carving out the time to write a bunch of sample code for hands-on exercises.
[13:18:16 EST(-0500)] <athena7> yeah
[13:18:20 EST(-0500)] <athena7> well, you're ahead of me
[13:18:24 EST(-0500)] <Justin_o> 1) we keep the original behaviour and not have focus placed on the first focusable item in the dialog after it opens, 2) we have a modal dialog that breaks IE 3) we have a non-modal dialog and try to force focus on the first focusable item
[13:18:29 EST(-0500)] <Justin_o> anything else fj4000
[13:18:33 EST(-0500)] <athena7> i'm creating the functionality we're going to present on
[13:19:03 EST(-0500)] <colinclark> athena7:
[13:19:18 EST(-0500)] <athena7> well i could have committed some of it last night if svn was up! it wasn't my fault!
[13:19:21 EST(-0500)] <athena7> but yeah
[13:20:36 EST(-0500)] <fj4000> Justin_o: sounds about right
[13:20:56 EST(-0500)] <ecochran> colinclark: I may not need you right away. I'm still seeing odd behavior if I go straight to the AddImages page, but if I go through the top of the Image Gallery, it loads OK
[13:21:08 EST(-0500)] <colinclark> ok
[13:21:11 EST(-0500)] <colinclark> lemme know
[13:21:38 EST(-0500)] <fj4000> Jusint_o: there another little htich
[13:21:43 EST(-0500)] <Justin_o> okay
[13:21:44 EST(-0500)] <fj4000> if the dialog is non modal
[13:21:49 EST(-0500)] <ecochran> colinclark: by the way, in a superstitious attempt to fix the problem, I changed
[13:21:51 EST(-0500)] <ecochran> ../../fluid-components/html/templates/Uploader.html #uploader-contents
[13:21:52 EST(-0500)] <ecochran> to
[13:21:58 EST(-0500)] <ecochran> ../../fluid-components/html/templates/Uploader.html#uploader-contents
[13:22:00 EST(-0500)] <fj4000> then tab focus can be all over the place when cycled through the page
[13:22:08 EST(-0500)] <ecochran> no space before the #
[13:22:14 EST(-0500)] <fj4000> thats one major benefit of it being modal
[13:22:20 EST(-0500)] <ecochran> and it it didn't work
[13:22:30 EST(-0500)] <Justin_o> fj4000: for sure... did the original behavior also use a non-modal dialog
[13:22:34 EST(-0500)] <ecochran> that space is odd but seems to be neccessary
[13:22:38 EST(-0500)] <fj4000> yes
[13:22:43 EST(-0500)] <ecochran> I'll look at that later as well
[13:22:50 EST(-0500)] <colinclark> ecochran: Yeah, it's the standard syntax for jQuery.load(), if I remember correctly.
[13:23:02 EST(-0500)] <ecochran> really, a space?
[13:23:06 EST(-0500)] <ecochran> colinclark: OK
[13:23:16 EST(-0500)] <Justin_o> i'm thinking that it is an imporvement if focus at least starts on the dialog...
[13:23:17 EST(-0500)] <colinclark> ecochran: http://docs.jquery.com/Ajax/load#urldatacallback
[13:23:21 EST(-0500)] <Justin_o> not the ideal solution though
[13:23:36 EST(-0500)] <fj4000> ok, I'll take it as far as I can
[13:23:40 EST(-0500)] <colinclark> ecochran: "The syntax looks something like "url #some > selector". Default selector "body>*" always applies."
[13:23:44 EST(-0500)] <Justin_o> thanks...
[13:23:52 EST(-0500)] <fj4000> Justin_o: thanks again for the hlpe
[13:23:55 EST(-0500)] <fj4000> *help
[13:23:58 EST(-0500)] <Justin_o> if someone else has thoughts please let fj4000 know
[13:24:02 EST(-0500)] <Justin_o> np
[13:24:13 EST(-0500)] <ecochran> colinclark: cool, in all my years writing URLs, I just assumed that spaces were bad
[13:24:23 EST(-0500)] <ecochran> thx
[13:24:29 EST(-0500)] <colinclark> ecochran: Well, that's the thing...
[13:24:30 EST(-0500)] <ecochran> off to figure this bug out
[13:24:33 EST(-0500)] <colinclark> It's not a URL.
[13:24:42 EST(-0500)] <colinclark> It's URL, then a space, then a jQuery selector.
[13:24:50 EST(-0500)] <ecochran> got it
[13:24:55 EST(-0500)] <colinclark> So don't read it as "anchor uploader-contents"
[13:24:57 EST(-0500)] <colinclark> but rather
[13:25:01 EST(-0500)] <colinclark> "id uploader-contents"
[13:25:02 EST(-0500)] <ecochran> too bad the syntax is so close, confusing
[13:25:06 EST(-0500)] <colinclark> if you know what I mean
[13:25:11 EST(-0500)] <ecochran> yeah, got it
[13:25:15 EST(-0500)] <colinclark> yeah, I have no idea why they didn't just create a separate argument
[13:25:17 EST(-0500)] <colinclark> seems silly to me
[13:25:24 EST(-0500)] <ecochran> agreed!
[13:31:23 EST(-0500)] <ecochran> Justin_o: I've got some more info on the little oddities of Pausing
[13:31:32 EST(-0500)] <Justin_o> really
[13:31:38 EST(-0500)] <Justin_o> something interesting
[13:32:32 EST(-0500)] <ecochran> Justin_o: I can't reproduce the little files problem by more than 1 file which is expected, what I mean is that occasionally if I click while file 1 is uploading it wont stop until after file 2 (I added some debug code to test this)
[13:32:47 EST(-0500)] <ecochran> being off by 1 file is a timing problem
[13:33:14 EST(-0500)] <ecochran> just the click slipping between events and then doesn't get "picked up" until the next round
[13:33:39 EST(-0500)] <ecochran> not dissimilar to the actual Pause bug only on a smaller scale and no hanging
[13:33:56 EST(-0500)] <ecochran> However...
[13:34:30 EST(-0500)] <ecochran> the double click problem is real but, as far as I can see, isolated
[13:34:36 EST(-0500)] <ecochran> let me explain
[13:35:38 EST(-0500)] <ecochran> what happens is that if you click Start and then click Stop right away, the first click tells the cycle to "Stop" but unfortunately the cycle is still starting up, so it doesn't know how to stop
[13:36:06 EST(-0500)] <ecochran> it's like putting the breaks on when the car is still in Park
[13:36:20 EST(-0500)] <ecochran> if you wait just a moment then everything is fine
[13:36:50 EST(-0500)] <ecochran> I think that I can fix this, some of it is the optics of the Stop button being available before the process has really gotten into gear
[13:36:58 EST(-0500)] <Justin_o> ah
[13:37:14 EST(-0500)] <ecochran> does this line up with what you've seen?
[13:37:37 EST(-0500)] <Justin_o> sounds like it... although i notice that when I hit stop and there are four small files it will still do them all
[13:38:45 EST(-0500)] <Justin_o> ecochran: I'm trying to figure out how often someone would encounter these issues
[13:38:45 EST(-0500)] <ecochran> Justin_o and Everyone: By the way... the Companion.JS tool from the folks who brought us Debugbar for IE works great for a JS console on IE
[13:39:08 EST(-0500)] <Justin_o> ecochran: you have a link?
[13:39:13 EST(-0500)] <ecochran> Justin_o: I'm thinking, not often, but I'm the developer
[13:39:19 EST(-0500)] <ecochran> one sec
[13:39:22 EST(-0500)] <Justin_o> thanks
[13:39:39 EST(-0500)] <ecochran> http://www.my-debugbar.com/wiki/CompanionJS/HomePage
[13:39:50 EST(-0500)] <Justin_o> I was also thinking that it might be rare... if I recall corectly the designers were saying that people didn't often stop the upload anyways
[13:42:03 EST(-0500)] <ecochran> Justin_o: I think that the use case of a user clicking "Start" and then suddenly saying "Oops!" is a real use case... however in most cases it would take them a second or two to do the "Oops"
[13:42:14 EST(-0500)] <ecochran> OK, maybe a half a second
[13:42:36 EST(-0500)] <ecochran> but a quarter second is all that's needed for the cycle to get to the right place to be stoppable
[13:43:20 EST(-0500)] <Justin_o> with that said i'm thinking it will be okay for this release and then try to get it cleaned up for 1.0 not sure if everyone would agree on that
[13:43:50 EST(-0500)] * simonwang (n=chatzill@swang.itservices.ubc.ca) has joined #fluid-work
[13:44:04 EST(-0500)] <simonwang> Hi anastasiac
[13:44:06 EST(-0500)] <ecochran> Justin_o: works for me. I can fix it as part of the effort to get the Pause user feedback correct
[13:44:38 EST(-0500)] <ecochran> Justin_o: want to talk it over quick with Mr. colinclark since he's the other keeper of this code
[13:44:42 EST(-0500)] <ecochran> ?
[13:44:56 EST(-0500)] <Justin_o> probably a good idea
[13:45:04 EST(-0500)] <Justin_o> he's stepped out though
[13:45:20 EST(-0500)] <Justin_o> we'll have to catch him when he gets back
[13:46:05 EST(-0500)] <ecochran> Justin_o: OK
[13:46:10 EST(-0500)] * colinclark is back.
[13:46:16 EST(-0500)] <colinclark> and super hungry
[13:46:32 EST(-0500)] <ecochran> Justin_o: I got to say, I think that other than these little timing issues, this is looking really good on IE7!
[13:46:39 EST(-0500)] <simonwang> anastasiac: the reason fluid uportal test site failed to restart was caused by the conflicts between the old and new versions
[13:46:55 EST(-0500)] <ecochran> as they say on Buffy... Yeah Us!
[13:47:02 EST(-0500)] <anastasiac> hi, simonwang - thanks for the update
[13:47:05 EST(-0500)] <anastasiac> what is the fix
[13:47:16 EST(-0500)] <anastasiac> ?
[13:47:26 EST(-0500)] <Justin_o> ecochran: I agree
[13:48:01 EST(-0500)] <simonwang> After run ant clean, ant deploy-war and ant initportal it worked.
[13:48:40 EST(-0500)] <anastasiac> ok, excellent! thanks so much!
[13:48:52 EST(-0500)] <ecochran> colinclark: can you do a quicklook at the last little interchange between Justin_o and I and give your quick opinion. Justin_o and I are feeling like we're done!
[13:49:14 EST(-0500)] <ecochran> sorry to distract from your food!
[13:49:14 EST(-0500)] <simonwang> anastasiac: I also ran the stop_deploy_resetdb_start.sh again to make sure everything works fine.
[13:49:20 EST(-0500)] <anastasiac> excellent!
[13:49:33 EST(-0500)] <anastasiac> now I just have to get the image gallery portlet back in there
[13:50:34 EST(-0500)] <simonwang> anastasiac: I will contact Gary to continue the Announcement portlet setup. If you need my help please feel free to let me know.
[13:50:47 EST(-0500)] <anastasiac> I will do that, thanks!
[13:51:07 EST(-0500)] <anastasiac> let me know how things are going with the Announcements portlet
[13:52:15 EST(-0500)] <ecochran> Justin_o: did we lose colinclark again?
[13:52:37 EST(-0500)] <ecochran>
[13:52:47 EST(-0500)] <Justin_o> we did ... he just got back again... i imagine he is catching up
[13:53:05 EST(-0500)] <simonwang> anastasiac: I will have you posted.
[13:55:25 EST(-0500)] <anastasiac> Justin_o: FLUID-1954 was not in bug parade, but Simon has gotten it working, and I'd like to commit the script changes to SVN
[13:55:57 EST(-0500)] * colinclark is eating and catching up.
[13:55:57 EST(-0500)] <Justin_o> anastasiac: just going to double check what fluid-1954 is
[13:56:06 EST(-0500)] <anastasiac>
[13:56:09 EST(-0500)] <colinclark> The life of a penguin is very interesting.
[13:56:58 EST(-0500)] <Justin_o> adding http://issues.fluidproject.org/browse/FLUID-1954 to the bug parade
[13:57:06 EST(-0500)] <anastasiac> thanks
[13:58:01 EST(-0500)] <colinclark> ecochran, Justin_o: So the summary is that there are a couple of fairly minor or subtle issues; the core is worked out, and we'll punt the rest until 1.0?
[13:58:39 EST(-0500)] <ecochran> yep
[13:58:46 EST(-0500)] <ecochran> colinclark: that sums it up
[13:59:16 EST(-0500)] <ecochran> the bugs are subtle and (we're guessing) hard to stumble upon
[13:59:44 EST(-0500)] <Justin_o> or at least not likely
[14:00:34 EST(-0500)] <colinclark> ecochran, Justin_o: You've got good points. +1
[14:02:05 EST(-0500)] <ecochran> colinclark Justin_o : thx
[14:03:59 EST(-0500)] <Justin_o> ecochran: did you have anything else that you needed to commit for 822 or can I go ahead and close it
[14:04:49 EST(-0500)] <ecochran> Justin_o: no, we're good
[14:05:21 EST(-0500)] <ecochran> and Justin_o and colinclark: I can not repeat this bug where I couldn't load Uploader from my server
[14:05:29 EST(-0500)] <Justin_o> ecochran: thanks
[14:05:37 EST(-0500)] <ecochran> suddenly everything started working again
[14:06:05 EST(-0500)] <Justin_o> was it that server caching problem?
[14:06:26 EST(-0500)] <ecochran> but what was happening was that the AJAX call that includes the Uploader.html code was not doing so, so the progressive enhancement code would die
[14:06:40 EST(-0500)] <colinclark> ecochran: I've occasionally seen this in my local server builds too.
[14:07:17 EST(-0500)] <colinclark> Required rebuilding, but that was it.
[14:07:51 EST(-0500)] <Justin_o> colinclark, ecochran: that's not a problem with our war file is it
[14:08:06 EST(-0500)] <colinclark> Justin_o: Nope, I don't think so.
[14:08:17 EST(-0500)] <Justin_o> okay... thanks... i was worried
[14:09:03 EST(-0500)] <ecochran> colinclark: what was odd, was that entering the app from the root instead of the AddImages page seemed to clear it up
[14:09:16 EST(-0500)] <ecochran> almost like the app didn't initialize correctly
[14:10:46 EST(-0500)] <fj4000> does anyone know if there is a renderer method signalling when the renderer is "done" ?
[14:10:59 EST(-0500)] <fj4000> does such an event exist?
[14:14:57 EST(-0500)] <colinclark> fj4000: Hmmm. Why do you need it?
[14:15:46 EST(-0500)] <fj4000> i shouldnt, but it turns out there is another error in the page
[14:16:02 EST(-0500)] <Bosmon> The renderer is not anything asynchronous
[14:16:03 EST(-0500)] <fj4000> once UI Options finishes "rendering", IE barfs a jquery error
[14:16:08 EST(-0500)] <Bosmon> You invoke it, and it finishes
[14:16:24 EST(-0500)] <fj4000> yes, and once it finishes, I need the new ids
[14:16:33 EST(-0500)] <Bosmon> The asynchrony you will be seeing is just the asynchrony of the AJAX fetch
[14:17:06 EST(-0500)] <fj4000> before it renders, there are valueless selects, once it finishes those are trasformed and I need to fetch them - but only after they are rendered
[14:17:28 EST(-0500)] <Bosmon> OK, well, that is an event issue for the overall component
[14:17:31 EST(-0500)] <Bosmon> UIOptions...
[14:17:36 EST(-0500)] <Bosmon> But what do you plan to do with them?
[14:17:40 EST(-0500)] <ecochran> colinclark and Justin_o : pending colinclark finding any problems in the FLUID-2008 patch, I am free to help with anything that anyone needs
[14:18:05 EST(-0500)] <colinclark> ecochran: k, taking a look
[14:18:08 EST(-0500)] <colinclark> is that on the jira?
[14:18:16 EST(-0500)] <fj4000> your right Bosmon in that it should be handled by UI Options, its just that UI Options is throwing and error
[14:18:41 EST(-0500)] <fj4000> and so I would like to try to solve bug 1 before going on to solve bug 2
[14:19:06 EST(-0500)] <fj4000> if UI Options didnt throw an error in IE, it would probably do what im trying to do on its own
[14:19:15 EST(-0500)] <Bosmon> OK
[14:19:17 EST(-0500)] <ecochran> colinclark: it is
[14:19:22 EST(-0500)] <Bosmon> Seems FEES is away ....
[14:19:22 EST(-0500)] <fj4000> which is to draw focus to the first element in UI Options
[14:19:24 EST(-0500)] <colinclark> great
[14:19:27 EST(-0500)] <fj4000> yes 
[14:19:30 EST(-0500)] <colinclark> Bosmon: Yeah, FEES is off today.
[14:19:33 EST(-0500)] <Bosmon> OK, I can try to look at it
[14:19:34 EST(-0500)] <fj4000> and im in a little deep
[14:19:39 EST(-0500)] <fj4000> thank you
[14:19:41 EST(-0500)] <Bosmon> Does it fail as it stands in trunk?
[14:19:52 EST(-0500)] <colinclark> Bosmon: Thanks, dude. I know you're under the gun with Pager, too.
[14:19:59 EST(-0500)] <fj4000> im going to check, I will ping you
[14:20:06 EST(-0500)] <colinclark> Which reminds me, I assume you're not on vacation on Monday like many of us are?
[14:20:09 EST(-0500)] <fj4000> yes, im sorry to bog you down with this
[14:20:27 EST(-0500)] <Bosmon> I will be in on Monday, yes
[14:20:35 EST(-0500)] <Bosmon> What do you have, Canadian anti-snow day?
[14:21:01 EST(-0500)] <colinclark> Bosmon: lol
[14:21:11 EST(-0500)] <colinclark> It's a provincial holiday. "Family Day"
[14:21:26 EST(-0500)] <colinclark> Which translates as "We need a day off in the midst of freezeing February."
[14:21:33 EST(-0500)] <Bosmon> Oh, I heard of that
[14:21:34 EST(-0500)] <fj4000> Bosmon: yes, the bug is in trunk
[14:21:39 EST(-0500)] <Bosmon> Anyway, which page should I load to see it explode in IE?
[14:21:54 EST(-0500)] <fj4000> if you view the UI Options template html file , you should see an error on line 2220 in jequery
[14:21:55 EST(-0500)] <colinclark> I think it's President's Day in the US?
[14:21:57 EST(-0500)] <fj4000> jQuery
[14:22:58 EST(-0500)] <Bosmon> ?
[14:23:07 EST(-0500)] <Bosmon> html\templates\UIOptions.html?
[14:23:10 EST(-0500)] <fj4000> colinclark for some people Family Day translated in to : Mcguinty needed a political ploy for votes 
[14:23:19 EST(-0500)] <fj4000> Bosmon yup
[14:23:30 EST(-0500)] <Bosmon> Don't I need to do anything with it to make it fail?
[14:23:35 EST(-0500)] <Bosmon> Since it seems to work fine for me...
[14:23:40 EST(-0500)] <fj4000> really??
[14:23:43 EST(-0500)] <Bosmon> Yes
[14:23:47 EST(-0500)] <fj4000> it fails on load here....
[14:23:58 EST(-0500)] <fj4000> ok, maybe I need to update something
[14:24:00 EST(-0500)] <Bosmon> For me, it is fine
[14:24:04 EST(-0500)] <Bosmon> This is IE6
[14:24:22 EST(-0500)] <Bosmon> I guess THE KING would have flagged something if it had a problem that bad...
[14:24:40 EST(-0500)] <fj4000> can you try ie 7?
[14:24:46 EST(-0500)] <Bosmon> I can't, unfortunately
[14:25:25 EST(-0500)] * phiggins (n=dante@c-68-34-199-67.hsd1.tn.comcast.net) has joined #fluid-work
[14:25:39 EST(-0500)] <fj4000> this is beyond me....now im the only one getting cryptic IE errors.....
[14:26:06 EST(-0500)] <fj4000> Justin_o: can you replicate this or is it just my worst day ever?
[14:26:58 EST(-0500)] <Justin_o> fj4000: sorry... just getting caught up on the channel here
[14:27:11 EST(-0500)] <Justin_o> you want to know if it fails from the build site in ie6?
[14:27:20 EST(-0500)] <fj4000> no, from trunk
[14:27:30 EST(-0500)] <Justin_o> okay... let me give it a try
[14:27:36 EST(-0500)] <fj4000> can you load the UI Options template from trunk in IE?
[14:28:46 EST(-0500)] <Justin_o> ecochran: did you want to do some code reviews or take on FLUID-2165
[14:29:44 EST(-0500)] <ecochran> Justin_o: you tell me, what would be the biggest help?
[14:30:34 EST(-0500)] <Justin_o> ecochran: maybe start with 2165, i think it is one of the last remaining blockers.... and i'm hoping it won't take very long
[14:30:34 EST(-0500)] <Justin_o> thanks
[14:30:51 EST(-0500)] <ecochran> Justin_o: OK, I'm on it
[14:30:58 EST(-0500)] <Justin_o> thanks
[14:31:00 EST(-0500)] <anastasiac> Justin_o, I've reviewed FLUID-2150 - it looks good to me.
[14:31:09 EST(-0500)] <Justin_o> anastasiac: thank you
[14:36:34 EST(-0500)] <anastasiac> Justin_o, I can review FLUID-2084 now
[14:36:53 EST(-0500)] <Justin_o> thanks
[14:39:14 EST(-0500)] <Justin_o> fj4000, Bosmon: it doesn't seem to throw an error in IE6 but the dialog is broken on the sakai page
[14:39:41 EST(-0500)] <fj4000> in IE 7 too? so its just me?
[14:40:13 EST(-0500)] <anastasiac> Justin_o: fj4000's patch on FLUID-2084 looks fine to me
[14:40:16 EST(-0500)] <anastasiac> he should commit it
[14:40:28 EST(-0500)] <Justin_o> thanks
[14:40:37 EST(-0500)] <fj4000> thanks anastasiac
[14:40:38 EST(-0500)] <Justin_o> fj4000: ^
[14:41:19 EST(-0500)] <Justin_o> fj4000: it does have the error in IE 7
[14:41:39 EST(-0500)] <fj4000> ok, so im not crazy then?
[14:41:52 EST(-0500)] <Justin_o> i don't think so
[14:42:00 EST(-0500)] <fj4000> lol - well played
[14:42:09 EST(-0500)] <fj4000> not sure, eh?
[14:42:12 EST(-0500)] <fj4000> neither am I
[14:43:26 EST(-0500)] <Justin_o> i'm not sure what's causing it... i haven't had a chance to really look into it though... sorry
[14:44:38 EST(-0500)] <fj4000> ok, so I can continue to work on 2121 knowing this is a different bug to fix with michelle
[14:45:05 EST(-0500)] <fj4000> but this will probably effect 2121
[14:45:42 EST(-0500)] <Justin_o> yah... i'm not sure
[14:45:52 EST(-0500)] <Justin_o> it could be part of 2121 or it may not be...
[14:47:27 EST(-0500)] <anastasiac> Justin_o: I can review FLUID-1941, if no one else has done it yet
[14:47:51 EST(-0500)] <Justin_o> i don't think anyone has
[14:49:16 EST(-0500)] <anastasiac> k
[14:50:23 EST(-0500)] <Bosmon> Which Sakai page
[14:50:37 EST(-0500)] <Justin_o> the sakai mock-up
[14:51:00 EST(-0500)] <Justin_o> http://build.fluidproject.org/fluid/sample-code/shared/sakai/sakai.html
[14:53:06 EST(-0500)] <ecochran> Justin_o: got distracted... I'm going to go grab a burrito and then get onto FLUID-2165
[14:53:15 EST(-0500)] <Justin_o> sure... thanks
[14:53:27 EST(-0500)] <colinclark> ecochran: You should get fish tacos instead.
[14:53:30 EST(-0500)] <colinclark>
[14:54:12 EST(-0500)] <ecochran> colinclark: I wish for fish... but no fish tacos here
[14:54:33 EST(-0500)] <colinclark> damn
[14:54:33 EST(-0500)] <ecochran> My choices are limited, especially since it's raining out
[14:54:35 EST(-0500)] <colinclark> none here either
[14:54:40 EST(-0500)] <ecochran> damn
[14:54:52 EST(-0500)] <ecochran> I thought that I could channel your taste buds!
[14:55:01 EST(-0500)] <colinclark> I was sort of hoping my comment might inspire Bosmon to sing.
[14:55:05 EST(-0500)] <colinclark> Alas, no.
[14:55:21 EST(-0500)] <ecochran> Sadly the fish taco in Newport Beach are not enough of a draw for a road trip
[14:55:36 EST(-0500)] <anastasiac> Justin_o: I have another thought on FLUID-2150 - I see you haven't closed it, which might be good
[14:55:39 EST(-0500)] <ecochran> But you guys are going to mail me some BBQ from Dallas, right?
[14:56:05 EST(-0500)] <Justin_o> anastasiac: i was just going to start testing it, but i guess i'll hold off
[14:56:14 EST(-0500)] <Bosmon>
[14:56:21 EST(-0500)] <colinclark> mmm
[14:56:28 EST(-0500)] <colinclark> veggie bbq is somehow less exciting
[14:56:31 EST(-0500)] <ecochran> meat coma!
[14:56:33 EST(-0500)] <anastasiac> well, I'm not sure it's a bug, so maybe you should have a quick look
[14:56:52 EST(-0500)] <anastasiac> the wireframe says "Reset sets the selections back to what they were at the point of integration. There will be mini-resets that will work on individual settings.
[14:56:54 EST(-0500)] <ecochran> colinclark: oh yes... veggie BBQ... sad
[14:57:04 EST(-0500)] <colinclark> ecochran: Is it likely that they will have fish tacos in Dallas?
[14:57:04 EST(-0500)] <ecochran> colinclark: gotta go miss the lunch rush
[14:57:08 EST(-0500)] <colinclark> k
[14:57:13 EST(-0500)] <anastasiac> When I try reset, it not only resets the settings, but also does a "save and apply" to the whole site
[14:57:16 EST(-0500)] <ecochran> colinclark: could be, could be
[14:57:23 EST(-0500)] <anastasiac> I wasn't expecting that, and don't think it's right
[14:57:25 EST(-0500)] <ecochran> Dallas is very red meat
[14:57:40 EST(-0500)] <colinclark> i'm doomed
[14:57:51 EST(-0500)] <ecochran> colinclark: fish tacos = commie conspiracy
[14:57:56 EST(-0500)] <colinclark> lol
[14:58:07 EST(-0500)] <colinclark> well, then I hate fish tacos.
[14:58:17 EST(-0500)] <colinclark> ok, i'm lying
[14:58:26 EST(-0500)] <anastasiac> colinclark loved the fish tacos in New York...
[14:58:33 EST(-0500)] <ecochran> too late, you're going to get searched at the airport now
[14:58:35 EST(-0500)] <colinclark> they were so good!
[14:58:39 EST(-0500)] <anastasiac> they were...
[14:58:46 EST(-0500)] <colinclark> not as good as in newport, but pretty wicked
[14:58:53 EST(-0500)] <colinclark> i think i ate almost all of them myself in nyc
[14:59:02 EST(-0500)] <Bosmon> So, the sakai thing seems to be failing on finding something with class ".fl-hook-preview-content"
[15:00:16 EST(-0500)] <Bosmon> The full selector is selector ".uiOptions .fl-hook-preview-frame.contents(undefined)" String
[15:00:53 EST(-0500)] <Bosmon> And the issue seems to be that the previewFrame is in a different frame... for which the contents are somehow being fetched inappropriately
[15:00:57 EST(-0500)] <Justin_o> fj4000: FLUID-2084 is still happening on the renderer version of pager... I have added the link to the jira
[15:01:10 EST(-0500)] <fj4000> ok
[15:01:11 EST(-0500)] <Bosmon> var previewFrame = that.locate("previewFrame").contents();
[15:01:14 EST(-0500)] * clown (n=clown@142.150.154.101) has joined #fluid-work
[15:01:14 EST(-0500)] <Bosmon> There is this line here
[15:01:19 EST(-0500)] <Bosmon> Which I am not convinced is portable
[15:01:40 EST(-0500)] <Bosmon> It is returning an invalid element
[15:03:54 EST(-0500)] <fj4000> Justin_o: this had a copy of the problem
[15:04:01 EST(-0500)] <fj4000> can I just commit the same change?
[15:04:13 EST(-0500)] <fj4000> and have someone review my commit?
[15:05:04 EST(-0500)] <Justin_o> fj4000: figured it would be the same change... yep... just commit and get anastasiac or someone to review it again
[15:05:12 EST(-0500)] <fj4000> ok
[15:06:14 EST(-0500)] <fj4000> there is another folder (sakai-site-setting) which may also have this issue...pls let me know if you find one
[15:06:19 EST(-0500)] <Justin_o> fj4000: do you remember what the correct functionality of the reset button is
[15:06:32 EST(-0500)] <Justin_o> okay
[15:06:45 EST(-0500)] <fj4000> for UI Options?
[15:07:35 EST(-0500)] <anastasiac> Justin_o: I've filed a new UI Options bug: http://issues.fluidproject.org/browse/FLUID-2241
[15:07:37 EST(-0500)] <fj4000> anastasiac would you mind reviewing my second commit for 2084?
[15:07:46 EST(-0500)] <anastasiac> you can decide if it's bug parade-worthy
[15:07:48 EST(-0500)] <Bosmon> I don't see any frames at all in this markup
[15:07:55 EST(-0500)] <Bosmon> So I'm not sure how it could ever work
[15:07:59 EST(-0500)] <anastasiac> fj4000 - sure - it's committed, rigth?
[15:08:11 EST(-0500)] <fj4000> yup
[15:08:18 EST(-0500)] <Bosmon> Does it work in any browser?
[15:08:18 EST(-0500)] <Justin_o> anastasiac: thanks... i'll take a look
[15:08:28 EST(-0500)] <fj4000> Bosmon: which frames are you looking for?
[15:08:29 EST(-0500)] <Justin_o> fj4000: yes... for UI Options
[15:08:37 EST(-0500)] <fj4000> there is an iframe for the preview window
[15:08:47 EST(-0500)] <Bosmon> Ah, I see
[15:08:51 EST(-0500)] <fj4000> Justin_o: im sorry I dont off the top of my head
[15:08:55 EST(-0500)] <Bosmon> It loads the markup containing the frame itself dynamically...
[15:09:31 EST(-0500)] <fj4000> Bosmon: are you looking at the sakai demo?
[15:11:09 EST(-0500)] * laurelw (n=Laurel@142.150.154.178) has left #fluid-work
[15:11:35 EST(-0500)] <Bosmon> yes
[15:11:53 EST(-0500)] <anastasiac> fj4000: Regarding FLUID-2084: Did you double-check whether or not the third pager demo (sakai_site_settings) exhibits the same symptoms?
[15:12:11 EST(-0500)] <Justin_o> fj4000: sakai-site-setting seems okay
[15:12:21 EST(-0500)] <fj4000> I looked, its a more complex demo, so it wasnt as easy to find
[15:12:35 EST(-0500)] <fj4000> thanks Justin_o
[15:12:51 EST(-0500)] <anastasiac> ok, Justin_o, FLUID-2084 looks good
[15:12:58 EST(-0500)] <fj4000> thanks very much
[15:13:08 EST(-0500)] <fj4000> I hope thats the last of it
[15:14:48 EST(-0500)] <Bosmon> ok, yeah it finds the frame
[15:14:53 EST(-0500)] <Bosmon> But the call to "content()" is invalid
[15:15:56 EST(-0500)] <Bosmon> Interestingly "contents()" does actually return without error
[15:16:02 EST(-0500)] <Bosmon> But it returns a node which is invalid
[15:16:13 EST(-0500)] <Bosmon> Any operation on the node will explode later
[15:17:06 EST(-0500)] <Bosmon> This problem does look as if it has the potential to break UIOptions on any kind of IE, but perhaps it depends on some other conditions too
[15:17:31 EST(-0500)] <colinclark> Bosmon: Justin_o says the Pager examples are looking really good. But also mentioned that you have more work to do before the bugs are squashable. What's on deck for you after you've finished this issue with fj4000?
[15:19:05 EST(-0500)] <fj4000> Bosmon: was this a change between the last and current version of jQuery?
[15:19:27 EST(-0500)] <fj4000> b/c I thought content() was the right method.....
[15:21:23 EST(-0500)] <anastasiac> Justin_o: I've fixed FLUID-2150, and Resolved the issue. I've assigned it to michelled, because I think she should have a look, and confirm if she agrees.
[15:21:48 EST(-0500)] <Justin_o> anastasiac: okay.. thnkas
[15:22:46 EST(-0500)] <Justin_o> anastasiac: if you have time can you review 2218
[15:26:59 EST(-0500)] <anastasiac> Justin_o: will review 2218
[15:28:18 EST(-0500)] * phiggins (n=dante@c-68-34-199-67.hsd1.tn.comcast.net) has joined #fluid-work
[15:29:01 EST(-0500)] <Justin_o> thank you
[15:32:30 EST(-0500)] <anastasiac> Justin_o: 2218 has been reviewed and commented on: it looks good to me.
[15:32:53 EST(-0500)] <Justin_o> thanks anastasiac
[15:42:10 EST(-0500)] <anastasiac> Justin_o: 1941 needs review, right?
[15:42:35 EST(-0500)] <Justin_o> yes
[15:43:01 EST(-0500)] <anastasiac> did I already offer to review that? It looks familiar, but I don't see my comments on it
[15:43:12 EST(-0500)] <Justin_o> i think you did
[15:43:17 EST(-0500)] <anastasiac> oh
[15:43:19 EST(-0500)] <Justin_o> not sure if you got around to reviewing
[15:48:20 EST(-0500)] <colinclark> ecochran: Are you back yet?
[15:48:33 EST(-0500)] <ecochran> colinclark: I am back
[15:48:57 EST(-0500)] <colinclark> So FLUID-2008 raises some interesting questions that hadn't occurred to me when we initially discussed it.
[15:49:07 EST(-0500)] <colinclark> I think this is generally the right approach.
[15:49:17 EST(-0500)] <ecochran> colinclark: listening
[15:49:28 EST(-0500)] <colinclark> We might debate the name of the "elementToFocusOnEvent" option, but let's set that aside for a second.
[15:49:57 EST(-0500)] <ecochran> yeah wasn't thrilled with that
[15:50:10 EST(-0500)] <colinclark> I notice that we implement this sort of pattern for three of our events: afterFileDialog, afterUploadStart, and afterUploadStop.
[15:50:21 EST(-0500)] <ecochran> yes
[15:50:25 EST(-0500)] <colinclark> Which makes total sense, because these are the three events that are at issue with the actual FLUID-2008 bug.
[15:50:33 EST(-0500)] <ecochran> yes
[15:50:52 EST(-0500)] <colinclark> But then, by creating this sort of an option, will our users be confused or frustrated if they try to do something like, say, this:
[15:51:15 EST(-0500)] <ecochran> i know where you
[15:51:19 EST(-0500)] <ecochran> re going
[15:51:23 EST(-0500)]
[15:51:25 EST(-0500)] <colinclark> and it doesn't work?
[15:51:32 EST(-0500)] <ecochran> yep
[15:51:58 EST(-0500)] <colinclark> anastasiac similarly assumed she might be able to have very broad control using this kind of an option.
[15:51:58 EST(-0500)] <ecochran> I had a comment in there for a little while which said that the listener already had to be implemented to look for the option
[15:52:05 EST(-0500)] <Bosmon> By an amazing stroke of synchronicity, I am surveying with some dismay exactly the same issue as it arises in pager
[15:52:06 EST(-0500)] <colinclark> ecochran: Right.
[15:52:18 EST(-0500)] <colinclark> Bosmon: This issue of focusing specific elements?
[15:52:19 EST(-0500)] <anastasiac> Justin_o: I've commented on 1941 - it's fine, except for an issue that is covered by 2241
[15:52:19 EST(-0500)] <Bosmon> It looks like our early survey of "flapjax" may not be entirely mistimed....
[15:52:22 EST(-0500)] <Bosmon> No, not that one
[15:52:29 EST(-0500)] <colinclark> Bosmon: Which one?
[15:52:39 EST(-0500)] <Bosmon> Well, I mean, your issue, I think, is a subcase of a wider class of issue
[15:52:46 EST(-0500)] <colinclark> Bosmon: Yes, I think it is.
[15:52:55 EST(-0500)] <Bosmon> An issue of "mutual exclusion in a potentially unbounded and dynamically configured case"
[15:53:04 EST(-0500)] <Bosmon> er "space"
[15:53:08 EST(-0500)] <colinclark> lol
[15:53:11 EST(-0500)] <Bosmon> So, I am about to write our first "thinger"
[15:53:12 EST(-0500)] <colinclark> that's one way of putting it, yes
[15:53:16 EST(-0500)] <Bosmon> I have no idea what to call these things
[15:53:19 EST(-0500)] <Justin_o> anastasiac: thanks
[15:53:22 EST(-0500)] <Bosmon> But it is somewhat of flapjackery
[15:53:25 EST(-0500)] <colinclark> ecochran: More immediately, I think we can go with this for 0.8
[15:53:41 EST(-0500)] <colinclark> But we probably need to file a bug with it, addressing the fact that it's essentially an incomplete feature as-is.
[15:53:51 EST(-0500)] <colinclark> ecochran: Does that seem like a reasonable way of approaching it?
[15:53:59 EST(-0500)] <ecochran> colinclark: cool, do you have a better name for the option and/or should i put the dorky comment back
[15:54:03 EST(-0500)] <ecochran> colinclark: yes
[15:54:10 EST(-0500)] <colinclark> ecochran: Yeah, let's come up with another name.
[15:54:28 EST(-0500)] <colinclark> I think there are two concerns with it now:
[15:54:30 EST(-0500)] <colinclark> "elem"
[15:54:31 EST(-0500)] <Bosmon> Call it "thinger"
[15:54:35 EST(-0500)] <Bosmon> Just like my one
[15:54:38 EST(-0500)] <ecochran> I could reference the new JIRA in the comment
[15:54:46 EST(-0500)] <ecochran> thinger? I'm lost
[15:54:58 EST(-0500)] <colinclark> suggests that it might be an element, but there's a contract that forces it to be a "selector name"
[15:55:14 EST(-0500)] <ecochran> yes, true
[15:55:16 EST(-0500)] <colinclark> the other half "OnEvent" might lead you to believe that it will always affect a "before" event
[15:55:23 EST(-0500)] <colinclark> these are little details, to be sure
[15:55:30 EST(-0500)] <colinclark> anastasiac: Any good naming ideas?
[15:55:38 EST(-0500)] <colinclark> Perhaps someone can top "Thinger/"
[15:55:39 EST(-0500)] <colinclark> ?
[15:55:39 EST(-0500)] * anastasiac catches up
[15:55:41 EST(-0500)] <colinclark>
[15:55:50 EST(-0500)] <Bosmon> "Thinger2"
[15:55:55 EST(-0500)] <colinclark> lol
[15:56:07 EST(-0500)] <colinclark> as it stands, this is an option that lets users specify an event name and a selector name
[15:56:30 EST(-0500)] <colinclark> and the element pointed to by the selector name will be focused upon that event firing
[15:56:35 EST(-0500)] <colinclark> if this makes any sense at all
[15:56:40 EST(-0500)] <colinclark> it is getting late on a friday afternoon
[15:56:51 EST(-0500)] <ecochran> focusReferenceForElementAtEventHorizon
[15:56:53 EST(-0500)] <colinclark> So far, our top candidate appears to be "Thinger2"
[15:56:57 EST(-0500)] <colinclark> ecochran: lol
[15:57:00 EST(-0500)] <anastasiac> on vs. after: the focus actually happens after whatever event handler is fired, right?
[15:57:10 EST(-0500)] <anastasiac> be it an onEvent or an afterEvent?
[15:57:14 EST(-0500)] <Bosmon> There is no meaning to "after an event handler"
[15:57:20 EST(-0500)] <ecochran> that is correct
[15:57:28 EST(-0500)] <Bosmon> Since the ordering of events with respect to a particular handler is undetermined
[15:57:29 EST(-0500)] <ecochran> yes, not after
[15:57:31 EST(-0500)] <ecochran> when
[15:57:34 EST(-0500)] <colinclark> anastasiac: it happens "upon" an event being fired
[15:57:44 EST(-0500)] <Bosmon> "with"
[15:57:45 EST(-0500)] <Bosmon>
[15:57:47 EST(-0500)] <colinclark> sure
[15:57:50 EST(-0500)] <ecochran> around
[15:57:54 EST(-0500)] <Bosmon> No, around is bad
[15:57:56 EST(-0500)] <colinclark> bosmon's point about it being undetermined is right
[15:58:08 EST(-0500)] <Bosmon> "Around" means something to some people....
[15:58:11 EST(-0500)] <colinclark> focusSelectorNameAtEvent
[15:58:12 EST(-0500)] <anastasiac> "upon" sounds fine
[15:58:23 EST(-0500)] <anastasiac> "focusSelectorNameUponEvent"?
[15:58:26 EST(-0500)] <ecochran> colinclark: pretty good
[15:58:26 EST(-0500)] <Bosmon> "with"
[15:58:31 EST(-0500)] <Bosmon>
[15:58:41 EST(-0500)] <colinclark> focusWithEvent
[15:58:43 EST(-0500)] <colinclark> focusAtEvent
[15:58:45 EST(-0500)] <colinclark> focusUponEvent
[15:58:53 EST(-0500)] <colinclark> focusAt
[15:58:58 EST(-0500)] <colinclark> Thinger3
[15:58:59 EST(-0500)] <ecochran> focusUponEvent
[15:58:59 EST(-0500)] <Bosmon> At or With are ok
[15:59:09 EST(-0500)] <ecochran> focusAtEvent
[15:59:16 EST(-0500)] <ecochran> no, with!
[15:59:17 EST(-0500)] <Bosmon> I am not keen on "Upon" since it still leave a bit of residual confusion with "on"
[15:59:22 EST(-0500)] <colinclark> Bosmon: I agree
[15:59:24 EST(-0500)] <ecochran> focudWithEvent
[15:59:32 EST(-0500)] <ecochran> focusWithEvent
[15:59:40 EST(-0500)] <colinclark> ecochran: I'm leaning towards you, there
[15:59:46 EST(-0500)] <Bosmon> "With" is nicely vague
[15:59:54 EST(-0500)] <colinclark> although it does feel backwards, given the format of the option
[16:00:02 EST(-0500)] <Bosmon> In that it brings no further guarantee other than a general association
[16:00:08 EST(-0500)] <Bosmon> What is the format of the option?
[16:00:11 EST(-0500)]
[16:00:28 EST(-0500)] <colinclark> which i believe is correct
[16:00:32 EST(-0500)] <colinclark> you can only focus on thing at a time
[16:00:34 EST(-0500)] <ecochran> eventWillFocus
[16:00:41 EST(-0500)] <Bosmon> Noooooooooooooo
[16:00:44 EST(-0500)] <colinclark> lol
[16:00:49 EST(-0500)] <Bosmon> The return of the ETERNAL EVIL
[16:01:11 EST(-0500)] <colinclark> Bosmon: Just wait 'til we have to write some iPhone code for Engage...
[16:01:19 EST(-0500)] <colinclark> you'll be seeing wills and dids everywhere!
[16:01:19 EST(-0500)] <colinclark>
[16:01:22 EST(-0500)] <Bosmon>
[16:01:30 EST(-0500)] <colinclark> well, it's not true
[16:01:36 EST(-0500)] <colinclark> since our iphone app will be so skinny
[16:01:48 EST(-0500)] <colinclark> anyway, so far focusWithEvent is seeming like the front runner
[16:01:59 EST(-0500)] <anastasiac> Justin_o: is 2180 in need of review?? it's not even mentioned in the bug parade emails
[16:02:04 EST(-0500)] <colinclark> any other ideas?
[16:02:07 EST(-0500)] <anastasiac> I can't review it, I finished it, but...
[16:02:11 EST(-0500)] <ecochran> if we're lucky this will only livbe for one release
[16:02:14 EST(-0500)] <ecochran> live
[16:02:22 EST(-0500)] <Bosmon> ecochran: What will it die in favour of?
[16:02:56 EST(-0500)] <ecochran> Bosmon: I think that colinclark is suggesting that we write something more generalizable
[16:02:57 EST(-0500)] <colinclark> Do you think it seems like a common pattern across components, eventually?
[16:03:04 EST(-0500)] <ecochran> not that that will improve the naming
[16:03:26 EST(-0500)] <ecochran> colinclark: I'm not sure, we've done it twice now, yes?
[16:03:26 EST(-0500)] <colinclark> the friday trees are getting in the way of the forest for me today
[16:03:26 EST(-0500)] <Bosmon> Well, the main standing hazard with this kind of this is to resolve priority
[16:03:36 EST(-0500)] <Bosmon> Which, perhaps, should be simply done using the existing options merge system
[16:03:45 EST(-0500)] <colinclark> yep
[16:03:47 EST(-0500)] <Bosmon> The way you have written it seems to suggest that could happen naturally
[16:03:48 EST(-0500)] <ecochran> I was going to ask about that but not until after the release
[16:03:49 EST(-0500)] <Justin_o> anastasiac: yes.... i'll add that one on
[16:04:04 EST(-0500)] <ecochran> that's the problem
[16:04:21 EST(-0500)] <colinclark> ecochran: Let's go with focusWithEvent and we can file a bug to go with it, basically saying it's "incomplete" and a candidate for generalization
[16:04:43 EST(-0500)] <ecochran> colinclark: yes, should I add in a comment?
[16:05:20 EST(-0500)] <Bosmon> colinclark: OK, but I'm still not clear which generalization axis you are looking to?
[16:05:38 EST(-0500)] <colinclark> Bosmon: That was my point about the friday trees
[16:05:41 EST(-0500)] <colinclark> I'm not quite sure at this point
[16:05:46 EST(-0500)] <colinclark> It's actually a specific case of a larger issues
[16:05:48 EST(-0500)] <colinclark> issue
[16:05:56 EST(-0500)] <colinclark> about things that cut across events
[16:06:06 EST(-0500)] <colinclark> things you'd like to attach to the event stream
[16:06:28 EST(-0500)] <colinclark> Bosmon: Do you have any thoughts on this? I mean, it's a common thing we do in code
[16:06:29 EST(-0500)] <Bosmon> How does this "cut across" them - is it the fact that you want to impose a "natural association" between keys in this structure and event names?
[16:06:38 EST(-0500)] <colinclark> but it doesn't quite feel general enough to be generalized completely
[16:06:51 EST(-0500)] <colinclark> even the more specific case
[16:07:05 EST(-0500)] <colinclark> it's quite common to focus something as the result of a fluid event firing in a component
[16:07:25 EST(-0500)] <colinclark> and, assuming decent dom agnosticism
[16:08:00 EST(-0500)] <colinclark> it probably makes sense for us to allow users to make decisions about what gets focused, when
[16:08:07 EST(-0500)] <colinclark> but again, that seems like one specific case of something else
[16:08:11 EST(-0500)] <colinclark> if you see what i'm saying
[16:08:38 EST(-0500)] <Bosmon> Yes, it is not quite clear which categories of things this is a special case of are the most important
[16:09:02 EST(-0500)] <Justin_o> just sent out an update to the bug parade...
[16:09:05 EST(-0500)] <Justin_o> on the fluid-work list
[16:09:22 EST(-0500)] <colinclark> Bosmon: yep, exactly
[16:09:27 EST(-0500)] <colinclark> Justin_o: cool, thanks
[16:09:35 EST(-0500)] <colinclark> Justin_o: I guess you're winding down for the day.
[16:09:43 EST(-0500)] <Justin_o> pretty much yes
[16:09:46 EST(-0500)] <colinclark> If Antranig has any Monday commits, I am willing to review them.
[16:09:54 EST(-0500)] <Justin_o> thank you
[16:10:02 EST(-0500)] <colinclark> Bosmon: ^ Is that cool?
[19:16:24 EST(-0500)] * JASIGLogBot (n=PircBot@jasig.Princeton.EDU) has joined #fluid-work
[19:16:24 EST(-0500)] * Topic is 'Bug Parade February 11 - 16 http://issues.fluidproject.org/secure/IssueNavigator.jspa?mode=hide&requestId=10129' set by Justin_o on 2009-02-11 08:26:18 EST(-0500)
[19:38:52 EST(-0500)] * apetro_ (n=apetro@12.164.139.7) has joined #fluid-work
[20:07:47 EST(-0500)] * EricDalquist (n=EricDalq@76.210.77.201) has joined #fluid-work
[23:48:21 EST(-0500)] * apetro (n=apetro@ip68-3-207-51.ph.ph.cox.net) has joined #fluid-work