fluid-work IRC Logs-2010-11-08

Owned by Fluid IRC Log Bot
Last updated: Nov 08, 2010Version comment
5 min read

[10:06:56 CST(-0600)] <jamon> restarting it
[10:08:47 CST(-0600)] <jamon> anastasiac: back
[10:09:00 CST(-0600)] <anastasiac> thanks so much, jamon!
[10:14:32 CST(-0600)] <Justin_o> mlam: after you get this next inlineEdit patch in.. jhung will take a look at the demo in a screen reader
[10:15:41 CST(-0600)] <mlam> ok, i'm just posting the patch up on jira now (FLUID-3821)
[10:15:59 CST(-0600)] <Justin_o> mlam: thanks... i'll take a look at it when it's up
[10:17:37 CST(-0600)] <mlam> Justin_o: it's up on the jira
[10:17:47 CST(-0600)] <Justin_o> mlam: thanks
[10:18:39 CST(-0600)] <mlam> np
[11:11:38 CST(-0600)] <michelled> harriswong: I finally saw the output from your php test harness work - nice job!
[11:17:21 CST(-0600)] <harriswong> michelled: thanks! (big grin)
[11:40:03 CST(-0600)] <harriswong> jhung: I set the dragbar as the grabHandle, so users can only drag the portlets with the dragbar. Problem is when i do a mouseover, only the dragbar is highlighted but not the whole portlet. This would look different than your design, do you still want me to make the dragbar the grabHandle?
[11:45:23 CST(-0600)] <jhung> harriswong: hmm.. let me think.
[11:49:14 CST(-0600)] <jhung> harriswong: applying the hover style to just the drag bar is not ideal because it doesn't show to the user what will be moved when dragged. COnversely, we don't want to make the entire portlet draggable either.
[11:52:51 CST(-0600)] <harriswong> jhung: i also want to avoid writing more js to the demo just for styling.
[11:53:24 CST(-0600)] <jhung> harriswong: Okay.
[11:54:14 CST(-0600)] <harriswong> jhung: i think the layout reorderer have the "hover" property related to the "grabHandle". When I define the grabHandle, only that is draggable and thus the hover css will get automatically applied to just the grabHandle.
[11:54:19 CST(-0600)] <jhung> harriswong: Then the hover style should place a border around the entire portlet regardless if the bar or content area is being hovered.
[11:54:46 CST(-0600)] <jhung> harriswong, But on hover over the drag bar, we'll have to make sure to change the cursor style to a drag / grabber.
[11:55:39 CST(-0600)] <harriswong> jhung: can I then still drag the portlet without using the dragbar?
[11:56:00 CST(-0600)] <jhung> harris: no. Dragging only allowed using the drag bar.
[11:56:11 CST(-0600)] <jhung> harris, does that work?
[11:56:37 CST(-0600)] <jhung> harriswong, it'll be simmilar behaviour as the current uPortal demo http://build.fluidproject.org/uPortal
[11:58:04 CST(-0600)] <harriswong> jhung: how come i can't drag them on that page?
[11:58:29 CST(-0600)] <jhung> harriswong: you should be able to using the drag bar. ONly certain portlets can be dragged.
[11:58:50 CST(-0600)] <jhung> harriswong: you need to login.
[11:59:47 CST(-0600)] <harriswong> jhung: yep, but it doesn't have the hover effect.
[12:01:03 CST(-0600)] <harriswong> jhung: I think I can do that np without the hover effect. But if I add the "hover" into the styles:{}, it automatically maps it to the grabHandle selector. In this case, it will automatically add the border to just the grabHandler
[12:01:47 CST(-0600)] <jhung> harriswong: Okay. Then skip the hover styles then.
[12:02:28 CST(-0600)] <harriswong> jhung: ok, but when I click on it, it wil still add the border to it.
[12:02:32 CST(-0600)] <jhung> harriswong: We can easily add the hover style for the grab bar in if needed.
[12:02:58 CST(-0600)] <jhung> harriswong: to which the grab bar or to the portlet?
[12:04:57 CST(-0600)] <harriswong> jhung: on select/click, border is added to the portlet, which is what we want.
[12:05:41 CST(-0600)] <jhung> harriswong: yep that's great!
[12:05:44 CST(-0600)] <harriswong> jhung: and when mouseover the dragbar, cursor turns to the "move" icon
[12:06:10 CST(-0600)] <jhung> harriswong: cool. That's what we want.
[12:12:24 CST(-0600)] <mlam> heidi_: got a sec?
[12:12:33 CST(-0600)] <heidi_> mlam : yep what's up
[12:13:06 CST(-0600)] <mlam> we have a style to highlight the inline edit component on mouse hover and focus
[12:13:15 CST(-0600)] <heidi_> yep
[12:13:52 CST(-0600)] <mlam> now that the textEditButton image is a background image...on hover, the highlighting style dominates and goes over the pencil icon
[12:14:16 CST(-0600)] <mlam> is there any way around this to keep the pencil image visible on hover? or are we stuck so long as the image remains in the background?
[12:14:22 CST(-0600)] <heidi_> mlam are the latest changes commited?
[12:14:33 CST(-0600)] <mlam> no , they're not
[12:14:42 CST(-0600)] <mlam> would you want me to send you a patch?
[12:14:54 CST(-0600)] <heidi_> ok let me d/l the styelsheet from that jira
[12:14:59 CST(-0600)] <heidi_> and apply it
[12:14:59 CST(-0600)] <mlam> ok
[12:15:03 CST(-0600)] <mlam> coolio
[12:15:06 CST(-0600)] <heidi_> i think it was fine, so i'm not sure what changed
[12:15:12 CST(-0600)] <heidi_> re: hover
[12:15:15 CST(-0600)] <heidi_> let me check
[12:15:19 CST(-0600)] <mlam> k
[12:15:40 CST(-0600)] <heidi_> mlam do you have that jira #
[12:15:46 CST(-0600)] <mlam> 3821
[12:15:52 CST(-0600)] <heidi_> tanks
[12:17:44 CST(-0600)] <heidi_> mlam what was the issue i attached the css to
[12:18:41 CST(-0600)] <mlam> Oops, sorry, 3801
[12:24:36 CST(-0600)] <heidi_> mlam hover is fine for me
[12:24:40 CST(-0600)] <heidi_> are you using that css file?
[12:24:43 CST(-0600)] <heidi_> clear cache etc
[12:26:41 CST(-0600)] <mlam> Ok, that's good then.
[12:27:03 CST(-0600)] <heidi_> ill test again once your work is committed ?
[12:27:10 CST(-0600)] <heidi_> or rather, when yr patch is ready
[12:27:26 CST(-0600)] <mlam> I've done some refactoring , and I think the side effect of the refactoring is the issue I was describing
[12:28:57 CST(-0600)] <mlam> heidi_: for sure, thanks.
[12:29:05 CST(-0600)] <heidi_> np
[12:32:51 CST(-0600)] <mlam> heidi_: your CSS change is awesome, it's just raised questions about how we've implemented the functionality of the existing code
[12:33:02 CST(-0600)] <heidi_> oo nice (wink)
[13:09:26 CST(-0600)] <Bosmon2> Hi there colinclark - here are two JIRAs I resolved recently that I would like some review for:
[13:09:37 CST(-0600)] <Bosmon2> http://issues.fluidproject.org/browse/FLUID-3825
[13:10:46 CST(-0600)] <Bosmon2> http://issues.fluidproject.org/browse/FLUID-3819
[13:11:26 CST(-0600)] <Bosmon2> I'd also like to revive our discussions about http://issues.fluidproject.org/browse/FLUID-3487 if we can - this is really a proxy for the "create new framework files" issue
[13:11:42 CST(-0600)] <colinclark> I'm in a meeting at the moment, but I'd be happy to chat a bit later
[13:12:00 CST(-0600)] <Bosmon2> We had got to the point where we were considering the creation of "fluidRequests.js" and "fluidView.js"
[13:12:20 CST(-0600)] <Bosmon2> The former seems pretty well-defined, especially with all the fluid.fetchResources work I just committed - but the latter is still a bit woolly
[13:29:56 CST(-0600)] <harriswong> jhung, justin_o: I have uploaded patch#4 with some of the discussed changes for http://issues.fluidproject.org/browse/FLUID-3754
[13:31:01 CST(-0600)] <Justin_o> harriswong: thanks... i'll take a look at the patch
[13:40:09 CST(-0600)] <jhung> harriswong: I'll take a look at it now.
[13:55:28 CST(-0600)] <jhung> harriswong: Looking good! I'll modify the contents of the portlets now and upload a patch.
[13:57:39 CST(-0600)] <harriswong> jhung: okay!
[14:06:35 CST(-0600)] <Justin_o> harriswong: i think the border sticks out a bit into the margins... too
[14:06:59 CST(-0600)] <Justin_o> so when you highlight something it pushes the other portlets
[14:08:11 CST(-0600)] <harriswong> justin_oon : safari?
[14:08:17 CST(-0600)] <harriswong> justin_o: on safari?
[14:08:33 CST(-0600)] <Justin_o> firefox{color}
[14:13:27 CST(-0600)] <jhung> harriswong: I've uploaded patch #5 to http://issues.fluidproject.org/browse/FLUID-3754. Just changes to HTML, no styling.
[15:19:15 CST(-0600)] <kasper1> justin_o: got a minute for some quick questions?