fluid-work IRC Logs-2010-11-12

Owned by Fluid IRC Log Bot
Last updated: Nov 12, 2010Version comment
22 min read

[08:48:04 CST(-0600)] <colinclark> hey mlam
[08:48:14 CST(-0600)] <mlam> hey colinclark
[08:48:16 CST(-0600)] <colinclark> running a bit late this morning--had to get up early to run an errand for darcie
[08:48:23 CST(-0600)] <colinclark> any luck figuring out why our button is getting disabled?
[08:48:34 CST(-0600)] <mlam> np
[08:48:48 CST(-0600)] <mlam> I played around a lot with the button, and i found that i can bind any class to it, except for a selector
[08:49:07 CST(-0600)] <colinclark> Any selector, or the browseButton selector?
[08:49:18 CST(-0600)] <jhung> harriswong: is cindyli in the office?
[08:50:04 CST(-0600)] <mlam> i only tried the browseButton selector, but i can quickly try another selector
[08:50:14 CST(-0600)] <mlam> i'm expecting the same result tho
[08:50:16 CST(-0600)] <mlam> gimme 2 secs
[08:50:18 CST(-0600)] <harriswong> jhung: yes.
[08:50:28 CST(-0600)] <harriswong> jhung: she is talking to justin_o atm though
[08:50:38 CST(-0600)] <colinclark> mlam: I betcha anything works except the browse button selector
[08:50:51 CST(-0600)] <jhung> harriswong: okay. Thanks. Just ask her to drop into IRC when she's free.
[08:50:55 CST(-0600)] <colinclark> I doubt it's magic. There must be code that is disabling that button
[08:51:00 CST(-0600)] <colinclark> (smile)
[08:51:02 CST(-0600)] <harriswong> jhung: will do~
[08:52:16 CST(-0600)] <cindyli> hi jhung, u r looing fo rme?
[08:52:30 CST(-0600)] <jhung> cindyli: yep.
[08:53:00 CST(-0600)] <jhung> cindyli: wondering if there's an update on the Delete function for the demo? I'm looking to integrate early if possible.
[08:53:17 CST(-0600)] <cindyli> jhung: justin_o and i are working on that
[08:53:27 CST(-0600)] <cindyli> jhung: not ready yet
[08:53:38 CST(-0600)] <mlam> colinclark: you're right
[08:53:42 CST(-0600)] <jhung> cindyli: okay. Keep me posted. (smile)
[08:54:11 CST(-0600)] <colinclark> mlam: So now the question is, why?
[08:54:21 CST(-0600)] <cindyli> jhung: sure
[08:54:28 CST(-0600)] <jhung> cindyli, justin_o: heidi and I removed a lot of mark-up from the HTML, so I think we'll have to be careful when we put this all together. (smile)
[08:54:40 CST(-0600)] <mlam> looking more into it now
[08:55:00 CST(-0600)] <cindyli> jhung: ok. thx
[09:07:29 CST(-0600)] <mlam> colinclark: you're right again. if i force a call to enable the browse button, it works
[09:07:47 CST(-0600)] <colinclark> mlam: It's never magic (smile)
[09:07:50 CST(-0600)] <colinclark> mlam: So where's it getting disabled?
[09:08:03 CST(-0600)] <mlam> I think we just need to fire the appropriate events so that the button gets enabled
[09:09:52 CST(-0600)] <colinclark> Okay, tell me more
[09:09:59 CST(-0600)] <colinclark> when does the button need to get enabled?
[09:10:07 CST(-0600)] <colinclark> in other words, what events cause it to be enabled?
[09:10:10 CST(-0600)] <colinclark> and why?
[09:10:16 CST(-0600)] <colinclark> Ah!
[09:10:34 CST(-0600)] <jhung> heidi_: I have the User Role working again in the demo. Also scrubbed the JSON file to remove any valid domain names in email addresses.
[09:10:39 CST(-0600)] <colinclark> Isn't there an event that the strategy is supposed to fire when it is "ready"?
[09:10:45 CST(-0600)] <heidi_> jhung excellent
[09:10:51 CST(-0600)] <jhung> heidi_: also removed the "Status" column. I didn't think it was necessary.
[09:10:51 CST(-0600)] <colinclark> I vaguely remember that SWFUpload takes awhile to initialize, and then it fires a ready event
[09:10:58 CST(-0600)] <heidi_> jhung that sounds fine ya
[09:10:59 CST(-0600)] <colinclark> which is probably when we enable the button!
[09:11:02 CST(-0600)] <colinclark> mlam: Jackpot!
[09:11:16 CST(-0600)] <mlam> haha, you're answering your own questions before i can answer
[09:11:30 CST(-0600)] <mlam> yes, there's an event listener for when the uploader is loaded
[09:11:32 CST(-0600)] <colinclark> mlam: First event in the list of Uploader events
[09:11:40 CST(-0600)] <colinclark> afterReady: null
[09:11:54 CST(-0600)] <colinclark> try firing that event in at the end of the html5Strategy's setup method
[09:12:00 CST(-0600)] <colinclark> Presumably that is when we're actually ready (smile)
[09:12:04 CST(-0600)] <colinclark> lemme know how it goes
[09:12:13 CST(-0600)] <colinclark> i'll finish getting ready so we can actually pair on it soon
[09:12:20 CST(-0600)] <mlam> ok, cool
[09:14:05 CST(-0600)] <jhung> heidi_: I'm going to add a comments column now...
[09:14:16 CST(-0600)] <heidi_> jhung okay
[09:21:50 CST(-0600)] <justin_o_> jhung: just wondering if we actually need the delete option
[09:22:10 CST(-0600)] <justin_o_> so far it doesn't look like the pager itself actually supports this...
[09:22:22 CST(-0600)] <jhung> justin_o: oh.
[09:22:49 CST(-0600)] <jhung> justin_o: hmmm. The motivation was to show how changes to the model get updated automatically.
[09:23:19 CST(-0600)] <jhung> justin_o: but if this doesn't work, then technically this isn't a feature we can / should show. (smile)
[09:23:50 CST(-0600)] <justin_o_> jhung: i think the sorting and number of items per page would do this
[09:24:05 CST(-0600)] <justin_o_> what model are you trying to show case by the way.. the components state model or data model
[09:25:04 CST(-0600)] <jhung> justin_o: both I guess. Delete an item from the database, and have it remove itself from the UI.
[09:26:09 CST(-0600)] <justin_o_> jhung: I see... i could be wrong but it seems you would have to reinitialize the pager at this time to get this to work
[09:26:22 CST(-0600)] <justin_o_> anastasiac: do you know if that is true?
[09:27:21 CST(-0600)] <anastasiac> Justin_o, I don't know for sure, but it sounds quite possibly true. There may be some kind of re-render option, though?
[09:28:11 CST(-0600)] <justin_o_> anastasiac: ah... there could be... i'll take a look.. thanks
[09:30:17 CST(-0600)] <justin_o_> anastasiac, jhung: there is one which looks to be part of the onModelChange listener, but I don't seem to see a clear way of removing data from the model... cindyli and I looked at it and we could probably manually remove the objects from the dataModel and manually fire the onModelChange event.. but there doesn't seem to be a any direct way to say delete item x from the model.. as the model remains the same no matter the sort order, we would probably hav
[09:30:17 CST(-0600)] <justin_o_> search the model for the correct item to delete
[09:33:45 CST(-0600)] <jhung> justin_o: hmmm. Okay. This is interesting as this is functionality to be implemented in the future redesign as well. Perhaps for this demo we can live without, but we should show modification of the data model and view model somehow in the future.
[09:34:19 CST(-0600)] <justin_o_> jhung: makes sense
[09:34:43 CST(-0600)] <justin_o_> jhung: so cindyli should remove the delete button then from the demo?
[09:35:57 CST(-0600)] <jhung> justin_o, cindyli: Leave it in the HTML. Heidi and I will remove it.
[09:36:18 CST(-0600)] <jhung> justin_o, cindyli: so there is nothing to merge at the moment from your side, correct?
[09:36:40 CST(-0600)] <cindyli> jhung: the js file is ready if u remove delete from ur design
[09:36:49 CST(-0600)] <cindyli> jhung: how should we merge?
[09:39:11 CST(-0600)] <cindyli> jhung: i create a patch and put up on jira, get someone to review and commit, u then check out and merge with ur working copy?
[09:39:46 CST(-0600)] <jhung> cindyli: yes a patch and attach to Jira would be good. Can you give me an idea of what has been modified?
[09:42:14 CST(-0600)] <cindyli> jhung: iste_setting_members.js has been changed: 1. have js function into demo name space, 2. enable "email" column as sortable.
[09:42:42 CST(-0600)] <jhung> cindyli. Cool thanks!
[09:42:47 CST(-0600)] <cindyli> jhung: also demo.html, the js line to initialize pager needs to be adjusted to call demo.initPager()
[09:43:00 CST(-0600)] <jhung> okay.
[09:45:04 CST(-0600)] <justin_o_> jhung, cindyli: will you also be changing the names of the files and moving them?
[09:45:55 CST(-0600)] <cindyli> jhung: yes, i think. these files are going to overwrite the ones in demos/pager folder?
[09:47:16 CST(-0600)] <jhung> cindyli, justin_o: yes. They will be moved. Currently Heidi and I have done this in our working copies. We'll merge your changes in and commit soon.
[09:47:35 CST(-0600)] <justin_o_> jhung: ah okay.. and you have removed the sakai branding?
[09:48:21 CST(-0600)] <jhung> justin_o: yes. and a lot of other stuff (valid email addresses, YUI styling, the site_settings stuff from the JS and JSON file etc.).
[09:48:37 CST(-0600)] <heidi_> hey cindyli , the styles .fl-theme-hc .fl-pager .fl-pager-data .fl-pager-asc and -desc in Pager.css (component) aren't used - can you see a place to add them in the .js? the arrows for sorting up/down
[09:49:12 CST(-0600)] <cindyli> jhung: sure
[09:49:55 CST(-0600)] <cindyli> heidi_: is fl-pager-disabled removed? it's being used in js
[09:50:26 CST(-0600)] <heidi_> what does it do?
[09:51:42 CST(-0600)] <cindyli> heidi_: unsortableHeader, but since none of headers are unsortable now, before email column was, i will remove it. thx
[09:52:14 CST(-0600)] <heidi_> i'm confused
[09:52:24 CST(-0600)] <heidi_> the arrows don't appear to be used at all, am i wrong?
[09:53:00 CST(-0600)] <heidi_> the new 'comments' section won't be sortable cindyli so leave it in
[09:54:27 CST(-0600)] <cindyli> heidi_: ic. i am talking about the un-used styles. what's changed for arrows?
[09:55:48 CST(-0600)] <heidi_> cindyli the up/down arrows for sorting cols don't appear to be used by the component - can you add it in?
[09:56:02 CST(-0600)] <heidi_> the css is in the stylesheet already, just need to be implemented
[09:56:44 CST(-0600)] <cindyli> cindyli: ok. i'll check
[09:59:18 CST(-0600)] <golam> michelled: you wanted to see me
[09:59:37 CST(-0600)] <michelled> ya, I want to work with you - I'm coming over in a couple minutes (smile)
[09:59:38 CST(-0600)] <golam> should I come over
[09:59:43 CST(-0600)] <golam> cool
[10:01:42 CST(-0600)] <cindyli> heidi_: what are the names of the sorting up/down images
[10:02:02 CST(-0600)] <cindyli> heidi_: r they in sakai pager folder?
[10:02:04 CST(-0600)] <heidi_> they're in the .css file... they are
[10:02:10 CST(-0600)] <heidi_> in the pager css file
[10:02:23 CST(-0600)] <heidi_> Pager.css, at the bottom
[10:02:47 CST(-0600)] <heidi_> for the component itself
[10:02:58 CST(-0600)] <justin_o_> heidi_: in the high contrast theme?
[10:03:06 CST(-0600)] <cindyli> heidi_: which css? demos/pager/css/pager.css?
[10:03:15 CST(-0600)] <cindyli> heidi_: or, sakai pager css
[10:03:22 CST(-0600)] <heidi_> components/pager/css
[10:03:46 CST(-0600)] <cindyli> heidi_: ic thx
[10:03:54 CST(-0600)] <heidi_> the arrows should be used by the component, but i don't think they are
[10:05:13 CST(-0600)] <cindyli> heidi_: from what i see, they are the defailt ones being used
[10:06:00 CST(-0600)] <heidi_> cindyli okay my bad!
[10:06:05 CST(-0600)] <heidi_> good they are, thanks for checking
[10:06:16 CST(-0600)] <cindyli> heidi_: great. thx
[10:06:22 CST(-0600)] <heidi_> i have to figure out why they're not working for our demo then
[10:06:49 CST(-0600)] <heidi_> cindyli is it just for high contrast theme?
[10:07:08 CST(-0600)] <heidi_> n/m
[10:08:03 CST(-0600)] <heidi_> jhung need to edit the html - did you edit it?
[10:08:37 CST(-0600)] <jhung> heidi: patch coming right up!
[10:08:56 CST(-0600)] <jhung> heidi: didn't touch the css.
[10:19:45 CST(-0600)] <cindyli> jhung, heidi_: should i copy the scripts from intergration-demos/sakai/ to demos/pager/ and create patch from there?
[10:20:25 CST(-0600)] <jhung> No. Leave it in the integration folder for now. Heidi and I will do the move to the demo folder.
[10:20:44 CST(-0600)] <cindyli> jhung, heidi_: alrite. patch coming soon
[10:20:46 CST(-0600)] <jhung> So create the patch inside the integration folder.
[10:20:48 CST(-0600)] <jhung> thanks!
[10:21:53 CST(-0600)] <cindyli> jhung: what's the jira for this?
[10:23:29 CST(-0600)] <jhung> cindyli: http://issues.fluidproject.org/browse/FLUID-3822
[10:29:24 CST(-0600)] <cindyli> jhung: thx
[10:52:27 CST(-0600)] <cindyli> jhung, heidi_: the patch for js has been attached into jira. Cheers!. let me know if more change or my help is needed. thx
[10:52:53 CST(-0600)] <jhung> cindyli: thanks!
[10:53:30 CST(-0600)] <jhung> totally off topic, but on topic about CATTs. http://www.youtube.com/watch?v=2XID_W4neJo&amp;feature=player_embedded A cat tries to fit into a box that's too small. (tongue)
[11:05:44 CST(-0600)] <jhung> justin_o, cindyli: We can't seem to sort using the email column. I think this is a known issue?
[11:05:49 CST(-0600)] <jhung> Can it be fixed?
[11:06:19 CST(-0600)] <cindyli> jhung: i fixed that
[11:06:35 CST(-0600)] <cindyli> jhung: have u tried the patch?
[11:06:36 CST(-0600)] <jhung> okay. In your patch or committed to SVN?
[11:06:42 CST(-0600)] <cindyli> jhung: patch
[11:06:50 CST(-0600)] <jhung> cindyli: Just about to merge...
[11:06:59 CST(-0600)] <cindyli> jhung: good
[11:12:55 CST(-0600)] <Justin_o> jhung: it had been intentionally disabled in the demo before... i think to highlight that you could turn sorting off of certain columns
[11:13:15 CST(-0600)] <jhung> justin_o: ah okay.
[11:13:36 CST(-0600)] <jhung> got it.
[11:47:50 CST(-0600)] <jhung> cindyli, justin_o, heidi: javascript successfully merged. Going to grab lunch now. Back in a bit.
[11:48:23 CST(-0600)] <Justin_o> jhung_: great
[12:23:08 CST(-0600)] <Bosmon> Justin_o, colinclark: Do you have time shortly to talk about file reorganisation?
[12:46:04 CST(-0600)] <colinclark> Bosmon: Urg
[12:46:07 CST(-0600)] <colinclark> that again
[12:46:08 CST(-0600)] <colinclark> (wink)
[12:46:21 CST(-0600)] <justin_o_> Bosmon: sure
[12:46:43 CST(-0600)] <colinclark> I think I'm going to have to pass--heads down with mlam on the Uploader
[12:46:52 CST(-0600)] <Bosmon> So, I think the case for creating "fluidRequests.js" is fairly clear
[12:47:19 CST(-0600)] <Bosmon> The remaining question is whether to create one or two further files than that for stuff broadly named "fluidView.js"
[12:47:35 CST(-0600)] <Bosmon> And we had got to the point of observing that in jquery.keyboard-a11y.js there is some code that should not be there
[12:47:56 CST(-0600)] <justin_o_> Bosmon: when you are working on restructuring the files can you also update the dependency files
[12:48:06 CST(-0600)] <Bosmon> The fact that we are presumably still "preparing that code for submission to jQuery" implies that the code there needs to be free of a dependence on Fluid.js
[12:48:11 CST(-0600)] <Bosmon> Justin_o: certainly (tongue)
[12:48:36 CST(-0600)] <Bosmon> Given that the immediate driver for this work is still "promote fluid.deadMansBlur to framework" this implies we should just deal with that side of the issue for nwo
[12:48:48 CST(-0600)] <Bosmon> It looks like fluid.deadMansBlur is also essentially free of a dependence on Fluid.js
[12:49:09 CST(-0600)] <Bosmon> So this material would go "into the same file" as well as the extraneous material from jquery.keyboard-a11y.js
[12:49:32 CST(-0600)] <Bosmon> And we would punt the remaining part of the issue to a future release - that is, "remove material from Fluid.js which has a dependence on the DOM"
[12:49:36 CST(-0600)] <justin_o_> Bosmon: so all of the functions in this new file will not be dependent on fluid.js at all?
[12:49:44 CST(-0600)] <Bosmon> That is what I am proposing
[12:50:12 CST(-0600)] <Bosmon> The only remaining wrinkle is what to call this new file
[12:50:30 CST(-0600)] <Bosmon> Since I think it would be better to keep the name "fluidView.js" for the file to be created in the next release out of Fluid.js material
[12:50:39 CST(-0600)] <Bosmon> Especially since it would contain functions like "fluid.initView"
[12:50:47 CST(-0600)] <justin_o_> Bosmon: what is in there, generally speaking, besides the DMB
[12:51:38 CST(-0600)] <Bosmon> Justin_o: basically things in jquery.keyboard-a11y that are not directly related to its function - things like the "global focus manager" and fluid.enabled
[12:52:40 CST(-0600)] <Bosmon> This new file is unfortunately going to be a real ragbag of stuff
[12:52:49 CST(-0600)] <Bosmon> "Things that depend on the DOM, but do not depend on Fluid.js"
[12:55:15 CST(-0600)] <justin_o_> Bosmon: a slight digression... i think for the dependency files instead of just having one module for core, we may now want to break it up a bit more
[12:55:50 CST(-0600)] <justin_o_> so this new file may be something that is in the new module as well.. that way users who just want core features and don' t need the rest won't have to take them
[12:56:03 CST(-0600)] <justin_o_> this doesn't really help with the naming issue though
[12:56:52 CST(-0600)] <Bosmon> Ok.... do "modules" have names too?
[12:56:55 CST(-0600)] <justin_o_> Bosmon: yes
[12:57:51 CST(-0600)] <Bosmon> So, one suggestion for a name: "fluidDocument.js"
[12:58:45 CST(-0600)] <justin_o_> Bosmon: also wondering... are these functions in a way like a jquery plugin.. so they are useful but not necessarily part of the core
[12:58:53 CST(-0600)] <heidi_> jhung let me know when new css/html is committed
[12:59:11 CST(-0600)] <jhung> heidi: Just about to write the log note now. (smile)
[12:59:18 CST(-0600)] <heidi_> k (smile)
[12:59:30 CST(-0600)] <justin_o_> Bosmon: I guess i'm also unclear if this will become a storage shed for code that we don't want to put in fluid.js
[13:01:45 CST(-0600)] <Bosmon> Well, I suppose it will, in some ways
[13:02:45 CST(-0600)] <jhung> heidi: sigh. May take a little longer. A commit was done to the demo since our last checkout. Will need to merge and then try again.
[13:02:50 CST(-0600)] <Bosmon> Although it would be essentially impossible for anyone not to include this file, if it defined fluid.enabled
[13:03:00 CST(-0600)] <Bosmon> Since actually any use of keyboard-a11y actually depends on that
[13:04:16 CST(-0600)] <Bosmon> Well, to be honest, we should really make that an "optional callout"
[13:04:17 CST(-0600)] <justin_o_> Bosmon: shouldn't the plugin be usable without any other file dependencies, other than jquery itself of course.. since people may want to just use it as a jquery plugin
[13:04:26 CST(-0600)] <Bosmon> In the way we are doing with lots of other "reverse dependencies"
[13:04:45 CST(-0600)] <Bosmon> For example, in the way that Fluid.js uses fluid.expandOptions if it can find IoC loaded, but ignores it if it is not
[13:04:45 CST(-0600)] <heidi_> jhung what commit?
[13:04:56 CST(-0600)] <jhung> heidi_: I'm checking now
[13:05:31 CST(-0600)] <jhung> heidi_: I don't see any commits since 3 days ago. Probably some SVN weirdness. Going to get clean copy and copy our files, then commit.
[13:06:05 CST(-0600)] <heidi_> cool
[13:06:11 CST(-0600)] <heidi_> im playing w/ screen reader
[13:09:17 CST(-0600)] <jhung> heidi_, justin_o, cindyli, golam: new version of Pager demo is in SVN. Very nearly done.
[13:09:29 CST(-0600)] <golam> cool
[13:09:44 CST(-0600)] <justin_o_> Bosmon: sorry... i feel like i'm jumping around a bit.. just thinking about the name fluidDocuments.js i'm not sure how something like the DMB would fit under a name like this..
[13:10:04 CST(-0600)] <justin_o_> jhung: that's great, what's left?
[13:10:30 CST(-0600)] <jhung> heidi: When you shrink the window, the page links container gets too small. Can you increase the size so it looks better on a small screen? Maybe give it a min-width too?
[13:11:04 CST(-0600)] <jhung> justin_o: going over my to-do list now...
[13:12:20 CST(-0600)] <Bosmon> Justin_o: "fluidDocument.js" - since it contains utilities for dealing with the case where you have a "document"
[13:12:35 CST(-0600)] <jhung> justin_o: I can't get the display All to work.
[13:12:37 CST(-0600)] <Bosmon> I'm not sure I like "fluidDOM.js" since it doesn't really operate on the "DOM" as such
[13:12:42 CST(-0600)] <Bosmon> And we already have a "fluidDOMUtilities.js"
[13:13:13 CST(-0600)] <jhung> heidi: do the annotations say anything interesting when hovered? Should we improve the text there?
[13:13:30 CST(-0600)] <jhung> ^heidi_
[13:16:12 CST(-0600)] <justin_o_> Bosmon: i see... do you think that a user would understand the different intentions... meaning would they know to look into fluidDomUtilities.js vs fluidDocuments.js for function x
[13:16:42 CST(-0600)] <justin_o_> i guess i'm not sure if there is enough distinction in the name
[13:18:14 CST(-0600)] <heidi_> jhung it doesn't specify the current page #
[13:18:54 CST(-0600)] <jhung> heidi_: Can you be specific?
[13:19:15 CST(-0600)] <Bosmon> justin_o_: I'm not sure they would.... on the other hand they shouldn't look into fluidDOMUtilities for anything.... most of the stuff in there is pretty esoteric (tongue)
[13:19:19 CST(-0600)] <heidi_> also items per page looks weird in safari
[13:19:31 CST(-0600)] <jhung> heidi_: always starts on page 4 for me.
[13:19:40 CST(-0600)] <Bosmon> But hopefully people are not "looking in files" for things anyway, but rather reading our documentation (tongue)
[13:19:41 CST(-0600)] <heidi_> what does?
[13:19:57 CST(-0600)] <jhung> heidi_: the demo. When you reload, it starts on page 4.
[13:20:07 CST(-0600)] <heidi_> for me too
[13:21:51 CST(-0600)] <jhung> heidi_: I'm going to start documenting these tasks...
[13:22:51 CST(-0600)] <jhung> golam: can you pass me a link to your Pager a11y patch?
[13:23:38 CST(-0600)] <heidi_> okay ill make a list of things w/ screen reader
[13:23:46 CST(-0600)] <heidi_> we should check ie8 too jhung
[13:23:53 CST(-0600)] <golam> jhung: http://issues.fluidproject.org/secure/attachment/11339/FLUID-3828.v2.patch
[13:24:09 CST(-0600)] <heidi_> nice i should apply that too - is it waiting for review?
[13:24:37 CST(-0600)] <golam> heidi_: yes, I am working on the testcases, should be done today
[13:24:48 CST(-0600)] <heidi_> cool
[13:25:00 CST(-0600)] <jhung> heidi_: looks fine in IE8.
[13:25:17 CST(-0600)] <heidi_> jhung check safari... a little weird top right
[13:25:28 CST(-0600)] <golam> jhung, heidi_: that patch is for both FLUID-3828 and FLUID-3829
[13:25:58 CST(-0600)] <jhung> heidi_: I don't have safari. Skype and screen share?
[13:26:10 CST(-0600)] <jhung> thanks golam.
[13:28:13 CST(-0600)] <golam> jhung: welcome
[13:31:20 CST(-0600)] <justin_o_> Bosmon: hopefully yes (smile)
[13:32:02 CST(-0600)] <justin_o_> Bosmon: so maybe i'll rephrase the question a bit.. in six months from now when one of us wants to add a new function will we put it in the correct place?
[13:40:46 CST(-0600)] <jhung> cindyli: ping
[13:41:01 CST(-0600)] <cindyli> jhung: yes
[13:41:55 CST(-0600)] <jhung> cindyli: we have 2 issues. Do you have time to look at it?
[13:42:03 CST(-0600)] <cindyli> jhung: sure
[13:42:30 CST(-0600)] <jhung> update your pager demo so you can see what I'm talking about...
[13:42:51 CST(-0600)] <jhung> 1. the demo always starts on Page 4.
[13:43:08 CST(-0600)] <jhung> 2. Selecting display items to "All" in the drop-down doesn't work.
[13:43:53 CST(-0600)] <cindyli> jhung: should start on page 1? will look into the "all" problem
[13:44:19 CST(-0600)] <jhung> cindyli: Yes. Should start on page 1.
[13:44:24 CST(-0600)] <jhung> Thanks!!
[13:44:29 CST(-0600)] <cindyli> jhung: np
[13:52:01 CST(-0600)] <heidi_> this text is a tad awkward "Current page 4 and range 31 - 40 of 187 items"
[13:53:07 CST(-0600)] <jhung> golam: the patch doesn't apply cleanly. Mostly it's the HTML merging that is the issue since the new demo structure has changed a little.
[13:53:23 CST(-0600)] <heidi_> i suggest "Page 4. Viewing records 31 to 40 of 187 items" or something
[13:53:28 CST(-0600)] <jhung> golam: can you create a new patch based on the latest demo code in SVN?
[13:53:44 CST(-0600)] <golam> jhung: ok I will
[13:54:10 CST(-0600)] <jhung> golam: I think it's only the JS file and the HTML that need to be patched. The CSS file we've fixed the same issue.
[13:54:33 CST(-0600)] <heidi_> golam can you make that change ^
[13:55:05 CST(-0600)] <golam> heidi_: ok I will
[13:55:09 CST(-0600)] <heidi_> maybe
[13:55:25 CST(-0600)] <heidi_> "Viewing page 4. Showing records 31 to 40 of 187 items."
[13:55:28 CST(-0600)] <heidi_> golam ^
[13:56:10 CST(-0600)] <golam> heidi_: i will change the message as well
[13:56:15 CST(-0600)] <heidi_> cool ty!
[13:58:37 CST(-0600)] <Bosmon> justin_o_: Hopefully to us the descriptions of the files are clear (tongue)
[13:58:47 CST(-0600)] <Bosmon> "Utilities which depend on the document that don't depend on Fluid.js"
[14:02:24 CST(-0600)] <justin_o_> Bosmon: hopefully... i'm not sure i would remember, but i'm not sure i should be adding code into those files anyways (tongue)
[14:06:13 CST(-0600)] <cindyli> jhung: unfortunately, pager doesn't seem to support page size "all"
[14:08:20 CST(-0600)] <jhung> cindyli: Hmmm... okay. Probably functionality we'll want to add in the future. We can fake it by supplying the exact number of all records, but that's not being honest. (big grin)
[14:09:05 CST(-0600)] <jhung> cindyli: thanks for looking into that. I'll remove "All" from the demo. Any luck with the Page 4 issue?
[14:09:12 CST(-0600)] <cindyli> jhung: agree. or we don't provide "all" selection
[14:09:44 CST(-0600)] <cindyli> jhung: yes, in demo-pager.js, remove line 74
[14:11:27 CST(-0600)] <cindyli> jhung: i also noticed a bug in page size drop down, pager.html, line 62, <option value="30">50</option>
[14:11:27 CST(-0600)] <cindyli> the option value needs to be 50 <option value="50">50</option>
[14:11:34 CST(-0600)] <jhung> cindyli: perfect thanks!
[14:11:43 CST(-0600)] <cindyli> jhung: do u want me to put up a patch, or this description is enough?
[14:11:44 CST(-0600)] <jhung> cindyli: I just saw that now too. It's been fixed. (big grin)
[14:11:52 CST(-0600)] <cindyli> jhung: great
[14:11:58 CST(-0600)] <jhung> No need to patch. I'll commit it.
[14:12:04 CST(-0600)] <cindyli> jhung: great thx
[14:12:24 CST(-0600)] <jhung> cindyli: I should be the one thanking you! (smile)
[14:12:42 CST(-0600)] <cindyli> jhung: npnp~~~
[14:17:01 CST(-0600)] <golam> jhung, heidi_: can you guys hover over page links on FireFox
[15:03:11 CST(-0600)] <golam> jhung: do you get any "Error on page" when you click on page link using IE8
[15:05:15 CST(-0600)] <jhung> golam: No. IE8 is mostly fine.
[15:05:32 CST(-0600)] <jhung> there's just a minor styling bug, but otherwise okay.
[15:06:28 CST(-0600)] <golam> jhung: For some reason I don't hear "Current page" when hover over current page link
[15:07:02 CST(-0600)] <jhung> golam: I don't have your patch. Is it up?
[15:07:05 CST(-0600)] <jhung> the new one.
[15:07:57 CST(-0600)] <golam> jhung: no
[15:08:23 CST(-0600)] <golam> jhung: I did the upadate and made one change to the html
[15:08:49 CST(-0600)] <golam> I have added ancor to the <li class="flc-pager-pageLink-disabled"><a href="#">2</a></li>
[15:13:59 CST(-0600)] <golam> jhung: everything works fine with Firefox and JAWS and NVDA
[15:15:29 CST(-0600)] <golam> jhung, justin_o: getting "fade in null or not an object error on line 291 in jquery.tooltip.js" using IE8 and doesn't say "Current page" when hover over visited page link using keyboard
[15:16:54 CST(-0600)] <golam> justin_o, jhung: I will add the patch to the jira FLUID-3828 so you guys can experience what I am experiencing
[15:17:23 CST(-0600)] <jhung> golam: thanks!
[15:17:39 CST(-0600)] <jessm> heidi_: jhung: cindyli: how's the pager demo going?
[15:18:20 CST(-0600)] <heidi_> jessm going good. just check screen reader stuff. styles are done i think? right jhung
[15:18:59 CST(-0600)] <jhung> heidi, jessm: yep. functionally it's nearly complete. Styling is done. Some bugs to iron out, but it's shaping up well.
[15:19:28 CST(-0600)] <jhung> jessm: we're going to address some issues with golam's a11y fixes now.
[15:20:01 CST(-0600)] <jessm> geat
[15:20:05 CST(-0600)] <jessm> great
[15:20:06 CST(-0600)] <jessm> (smile)
[15:20:08 CST(-0600)] <jhung> jessm: there's a weird IE8 focusing issue where you can mouse focus every element and it gets a black border, but it appears to be something to do with FSS' reset style.
[15:20:40 CST(-0600)] <jessm> jhung: can you reproduce the issue outside of that demo? with FSS reset style in general?
[15:21:12 CST(-0600)] <heidi_> golam, cindyli, do you know why this is randomly in the page: <p class="fl-offScreen-hidden" id="fluid-id-9">Current page </p>
[15:21:39 CST(-0600)] <jhung> heidi and I tried looking for other implementations in our demos. The only one that had an issue was Progress which showed the same black focus border around the whole demo container.
[15:21:58 CST(-0600)] <colinclark> jhung: that's the issue that the uniconers were mentioning the other day in our FSS meeting
[15:22:07 CST(-0600)] <colinclark> the aggressiveness of our focus styling in the rest file
[15:22:09 CST(-0600)] <colinclark> reset
[15:22:18 CST(-0600)] <jhung> colinclark: yep.
[15:22:40 CST(-0600)] <golam> heidi_: when hover over current page link you will hear "page link 4 current page"
[15:22:49 CST(-0600)] <heidi_> golam no it's not that
[15:23:08 CST(-0600)] <jhung> jessm: so we
[15:23:17 CST(-0600)] <jhung> 're getting very close. It's usable now.
[15:23:43 CST(-0600)] <heidi_> golam it's a hidden <p> tag stuck before the number of items per page thing
[15:23:48 CST(-0600)] <golam> justin_o, jhung: http://issues.fluidproject.org/secure/attachment/11341/FLUID-3828.v3.patch
[15:23:57 CST(-0600)] <heidi_> it gets inserted by the js
[15:24:04 CST(-0600)] <colinclark> Does anyone else notice that, since our move to OCAD, the SVN server hangs for a long time after each commit?
[15:24:28 CST(-0600)] <golam> heidi_: that was part of FLUID-3829
[15:24:41 CST(-0600)] <heidi_> golam it doesn't do anything tho ?
[15:25:03 CST(-0600)] <heidi_> golam, it's not on the page link
[15:25:06 CST(-0600)] <heidi_> it's a random p tag
[15:25:20 CST(-0600)] <golam> heidi_: that's the bug we are trying to fix with the new demo
[15:26:01 CST(-0600)] <golam> heidi_: if you use mozilla jaws and nvda it working with the new demo
[15:26:09 CST(-0600)] <heidi_> it works how?
[15:26:14 CST(-0600)] <heidi_> like what's the order
[15:26:55 CST(-0600)] <jessm> heidi_: jhung: cindyli: anything to look at?
[15:27:00 CST(-0600)] <jessm> is it up on daily?
[15:27:13 CST(-0600)] <heidi_> golam, i see it is connected to <li id="page-link:disabled1" class="flc-pager-pageLink-disabled fl-pager-currentPage" aria-describedby="fluid-id-9">1</li>
[15:27:45 CST(-0600)] <heidi_> it's just weird for a screen reader to go through, but hear "current page" at the end
[15:27:52 CST(-0600)] <cindyli> jessm: it's in svn, probably not daily yet
[15:27:57 CST(-0600)] <heidi_> at the end of the page link list
[15:28:10 CST(-0600)] <colinclark> We can rebuild the daily if you want to see it in action, jessm
[15:28:22 CST(-0600)] <jessm> colinclark: coolio
[15:28:27 CST(-0600)] <jessm> would love to page right now (smile)
[15:28:31 CST(-0600)] <colinclark> Does anyone mind if I rebuild daily?
[15:28:35 CST(-0600)] <heidi_> golam is that how all tooltips work?
[15:28:38 CST(-0600)] <colinclark> Any kingly concerns, Justin_o?
[15:28:50 CST(-0600)] <golam> heidi_: tooltips still in progress
[15:29:04 CST(-0600)] <heidi_> okay you're working on it (smile) i'll stop being confusing
[15:29:36 CST(-0600)] * colinclark is going to rebuild
[15:29:47 CST(-0600)] <golam> heidi_: but for now we are giving some kind of feedback to the user when they hover over current page link
[15:30:36 CST(-0600)] <heidi_> golam why not just have "current page" after the number of the current page, in a hidden style
[15:30:38 CST(-0600)] <jhung> golam: just applied the patch. Going through it now in IE8.
[15:30:51 CST(-0600)] <heidi_> vs. a <p> tag at the very end of the list... it's confusing on a screenreader
[15:31:00 CST(-0600)] <jhung> jessm: sorry. Was in the middle of applying golam's patch. (big grin) Thanks colinclark for rebuilding the site.
[15:31:14 CST(-0600)] <golam> heidi_: if we take away the anchor from the current visiting link then we completely skip over the current visiting link
[15:32:49 CST(-0600)] <heidi_> golam could you do like <a href="#">4 <span (hide styles)>- current page</span></a>
[15:33:36 CST(-0600)] <golam> heidi_: we add a aria-describeby to the current page anchor and aria-describeby has an id which you will see matches the id of the <p>
[15:34:15 CST(-0600)] <heidi_> golam yeah i see that... i'm just saying that when you go through w/ a screen reader, you hear that <p> tag, in its random location, after the page list
[15:34:42 CST(-0600)] <heidi_> does that happen with jaws and nvda
[15:35:45 CST(-0600)] <colinclark> jhung: Does this look like the right version? http://build.fluidproject.org/infusion/demos/pager/demo.html
[15:35:45 CST(-0600)] <golam> heidi_: I will do some more test but right now having some issues with IE8 with that particular fix
[15:36:56 CST(-0600)] <jhung> colinclark: Yes. But you have to make sure to clear cache / refresh a couple times.
[15:37:15 CST(-0600)] <colinclark> Justin_o: Quick question? How do I find something in the incubator?
[15:37:34 CST(-0600)] <justin_o_> colinclark: you mean on the build site?
[15:37:43 CST(-0600)] <colinclark> justin_o_: yep, sorry
[15:37:46 CST(-0600)] <jhung> golam: having problems in IE8. Keep getting an "Invalid character" errir,
[15:37:52 CST(-0600)] <jhung> *error
[15:38:48 CST(-0600)] <golam> heidi_: it should work with nvda+jaws and firefox
[15:39:26 CST(-0600)] <golam> jhung: does it say where
[15:40:11 CST(-0600)] <jhung> golam: nevermind. It's IE8 being stupid. I dragged the HTML to the IE8 toolbar, and it physically moved the file into IE8's favourites folder.
[15:40:14 CST(-0600)] <justin_o_> colinclark: i think it's supposed to be something like http://build.fluidproject.org/incubator/videoPlayer/html/VideoPlayer.html
[15:40:29 CST(-0600)] <justin_o_> but it doesn't seem to be working
[15:40:39 CST(-0600)] <justin_o_> jamon: do you know the correct url?
[15:41:52 CST(-0600)] <cindyli> jhung: heidi_: anything else u want from me? if not, i'm leaving
[15:42:32 CST(-0600)] <jhung> cindyli: I think we're okay. Heidi_, anything you can think of?
[15:44:06 CST(-0600)] <heidi_> have a good weekend cindyli !
[15:44:26 CST(-0600)] <jhung> cindyli: thanks for your help today! Have a good weekend!
[15:44:44 CST(-0600)] <cindyli> my pleasure, have a good weekend!
[15:46:05 CST(-0600)] <golam> jhung: cool, do you get any IE8 warning messages
[15:46:45 CST(-0600)] <jhung> golam: working better now. Had to revert my code then apply your patch. Testing now in IE8 + NVDA.
[15:47:40 CST(-0600)] <jhung> golam: all I need to do now is add <li class="flc-pager-pageLink-disabled"><a href="#">2</a></li> to the HTML file right?
[15:48:10 CST(-0600)] <golam> yes, but that should be there in the patch
[15:53:40 CST(-0600)] <jhung> golam: I've applied your patch and NVDA doesn't read anything back useful when focusing the pager links. It just says: "1 link. 2 link" etc.
[15:54:25 CST(-0600)] <golam> jhung: I am found that too
[15:54:52 CST(-0600)] <golam> jhung: does it say the "summary"
[15:55:37 CST(-0600)] <golam> jhung: did you notice any warning message with IE8?
[15:57:30 CST(-0600)] <jhung> golam: no it does not read the summary after changing pages.
[15:57:51 CST(-0600)] <jhung> golam: yes. I am seeing that fade is null error now.
[15:59:39 CST(-0600)] <golam> jhung: there is a bug when using NVDA+IE8+aria-live
[16:00:13 CST(-0600)] <golam> jhung: the "summery" is inside the live region
[16:00:23 CST(-0600)] <jhung> golam: okay.
[16:01:59 CST(-0600)] <golam> jhung: trying to figure out why in IE8 we are getting the "fade is null error now"
[16:05:12 CST(-0600)] <golam> jhung: which version of JAWS do you have?
[16:05:58 CST(-0600)] <jhung> sorry golam, I have to run. a little fam emergency came up.
[16:06:16 CST(-0600)] <golam> jhung: ok np
[16:07:25 CST(-0600)] <heidi_> golam how's it going? i'm going to sign off soon but do you need any help?
[16:08:02 CST(-0600)] <colinclark> heidi_, golam: I notice we've lost jhung
[16:08:11 CST(-0600)] <colinclark> But can you guys give a quick update on where we're at?
[16:08:17 CST(-0600)] <colinclark> michelled: you're working on pager too, right?
[16:08:27 CST(-0600)] <colinclark> What is still on our plate for Monday, etc.?
[16:08:32 CST(-0600)] <heidi_> colin i'm not sure - i think golam is fixing up some screen reader things
[16:08:35 CST(-0600)] <michelled> yes colinclark
[16:08:46 CST(-0600)] <michelled> but I'll be very busy on Monday with cspace I think
[16:08:53 CST(-0600)] <colinclark> ok
[16:08:57 CST(-0600)] <michelled> I'm going to try to hand off what I've got to Golam on Monday
[16:09:22 CST(-0600)] <colinclark> ok
[16:09:36 CST(-0600)] <colinclark> heidi_: so you're not sure what's left on your plate?
[16:09:57 CST(-0600)] <heidi_> colin we cleaned up styles and i did a little screen reader testing but golam's fixing stuff
[16:10:16 CST(-0600)] <heidi_> so i can help more with whatever needs attention on mon
[16:10:38 CST(-0600)] <colinclark> But you don't know of anything else that needs attention, beyond the fixes golam is working on?
[16:12:27 CST(-0600)] <colinclark> heidi_, golam, michelled: I'd suggest that our next step, first thing on Monday, is to get together and make a list of to dos left before we're ready
[16:12:45 CST(-0600)] <michelled> makes sense colinclark
[16:12:47 CST(-0600)] <colinclark> If we don't know what needs to be done, how will we know when we're done? (wink)
[16:15:06 CST(-0600)] <golam> colinclark: having some issues with IE8, it is showing warning message "fade is null error now"
[16:15:45 CST(-0600)] <colinclark> ok
[16:15:55 CST(-0600)] <colinclark> anything else we can think of in terms of problems, next steps, etc?
[16:18:17 CST(-0600)] <heidi_> i can take a look at screen reader stuff once gollam's patch is ready
[16:18:23 CST(-0600)] <heidi_> signing off - happy weekend all
[16:19:34 CST(-0600)] <golam> colinclark: I don't know if the error is some thing to do with screen reader not able to announce the current page
[16:19:58 CST(-0600)] <colinclark> ok
[16:21:21 CST(-0600)] <golam> colinclark: worse case scenario with latest jaws+firefox works
[16:21:33 CST(-0600)] <colinclark> okay, good to know
[16:21:43 CST(-0600)] <colinclark> let's all check in on Monday morning and figure out what our next steps are
[16:21:53 CST(-0600)] <golam> colinclark: sounds good
[16:32:49 CST(-0600)] <mlam> colinclark: i'll be online on and off tomorrow, but i'll be uploading on sunday
[16:32:59 CST(-0600)] <colinclark> mlam: have you committed?
[16:33:06 CST(-0600)] <mlam> i have
[16:33:12 CST(-0600)] <mlam> not the id stuff yet
[16:33:22 CST(-0600)] <colinclark> does the id stuff work?
[16:33:34 CST(-0600)] <mlam> no, it didn't
[16:33:37 CST(-0600)] <colinclark> ok
[16:33:38 CST(-0600)] <mlam> i was going to try again tmr
[16:33:41 CST(-0600)] <colinclark> ok
[16:33:49 CST(-0600)] <mlam> once it works, i'll commit
[16:34:28 CST(-0600)] <colinclark> k