fluid-work IRC Logs-2010-11-22

Owned by Fluid IRC Log Bot
Last updated: Nov 22, 2010Version comment
11 min read

[08:55:27 CST(-0600)] <cindyli> jamon: http://forge.fluidproject.org is down
[08:57:22 CST(-0600)] <jamon> cindyli: it is up, i'm working on it, only misbehaving inside our private network
[08:57:40 CST(-0600)] <cindyli> jamon: great. thx
[08:59:04 CST(-0600)] <greggy> jamon: lost atutor.ca again
[09:00:19 CST(-0600)] <jamon> greggy: same issue as cindyli, something internal, it resolves from outside
[09:00:21 CST(-0600)] <jamon> i'm working on it
[09:00:26 CST(-0600)] <greggy> jamon: k
[09:08:18 CST(-0600)] <jessm> jhung: will you have time to talk to me and Justin_o in a few?
[09:08:26 CST(-0600)] <jhung> sure
[09:54:22 CST(-0600)] <heidi_> jhung are you free to chat about inline edit for a sec?
[10:00:34 CST(-0600)] <jessm> heidi_: join me and Justin_o on skype now?
[10:00:43 CST(-0600)] <heidi_> sure ready
[10:04:53 CST(-0600)] <jhung> heidi: chat after?
[10:05:38 CST(-0600)] <jhung> anastasiac: Just checking in on the keyboard a11y demo. Is there anything I can help with / look at?
[10:06:47 CST(-0600)] <anastasiac> jhung, the demo could use another design iteration. I changed the highlight to something more usefully visible, but garish. colinclark also mentioned that he'd like to see the thumbnails along the top instead of the side. Plus anything else you'd like to improve (smile)
[10:07:23 CST(-0600)] <anastasiac> jhung, maybe selector naming conventions?
[10:07:53 CST(-0600)] <jhung> anastasiac: okay. I'll take the latest trunk version then and send around any updates to the design
[10:08:00 CST(-0600)] <anastasiac> thanks
[10:08:41 CST(-0600)] <jhung> anastasiac: as for selector naming conventions - I may not get around to that, but will take a look if I have time.
[10:08:50 CST(-0600)] <anastasiac> (smile)
[10:10:11 CST(-0600)] <Justin_o> mlam: hello... just wondering if you could tell jessm and I where you're at with the uploader today?
[10:10:26 CST(-0600)] <mlam> sure
[10:11:01 CST(-0600)] <mlam> I have the image gallery running with the html5 uploader. I'm still working on sending files to the image gallery server
[10:12:02 CST(-0600)] <heidi_> hey mlam, does trunk/src/webapp/tests/manual-tests/html/InlineEdit.html look okay in your IE8?
[10:12:06 CST(-0600)] <heidi_> if you have ie8...
[10:12:42 CST(-0600)] <mlam> lemme check... .but there should be one test that fails,right?
[10:12:59 CST(-0600)] <heidi_> it doesn't load at all for me really
[10:13:26 CST(-0600)] <heidi_> i'm also noticing that on FF, when you click the box w/o invitation text, the style sticks even after you leave it
[10:14:04 CST(-0600)] <Justin_o> mlam: okay... so it's just getting the back end connected then?
[10:14:09 CST(-0600)] <mlam> Justin_o: yes
[10:14:59 CST(-0600)] <Justin_o> heidi_: you're right.. not sure what's up with that
[10:15:13 CST(-0600)] <Justin_o> mlam: okay...
[10:15:24 CST(-0600)] <mlam> heidi_: the manual test is running fine in ie8
[10:16:45 CST(-0600)] <heidi_> mlam. odd, i get an error
[10:16:48 CST(-0600)] <heidi_> on line 117
[10:17:01 CST(-0600)] <heidi_> "expected identifier, string or number"
[10:20:04 CST(-0600)] <mlam> heidi_: I'm not getting the same bug as you with the invitation styling, but i did notice something else. When I click on the "Untitled" text, the text disappears
[10:20:50 CST(-0600)] <heidi_> mlam are you looking at demo or tests/manual-tests/html/InlineEdit.html
[10:20:55 CST(-0600)] <heidi_> i don't see an untitled...
[10:21:35 CST(-0600)] <mlam> sorry, the demo. for the manual-tests, everything is working fine for me in both IE8 and FF
[10:22:09 CST(-0600)] <heidi_> mlam untitled on demo disappears for me too
[10:24:07 CST(-0600)] <heidi_> mlam on manual-test, click in box without text, then click out. does a grey box stay?
[10:24:21 CST(-0600)] <heidi_> i think it's just the focus css justin_o
[10:24:41 CST(-0600)] <mlam> heidi_: ya, it does
[10:24:54 CST(-0600)] <heidi_> it seems weird, but i think it's right
[10:26:38 CST(-0600)] <Justin_o> heidi_, mlam : by the way, the untitled disappearing should happen.. as i changed it to be the invitation text. jhung has some styling tweaks to make it more identifiable as such
[10:26:46 CST(-0600)] <mlam> yah, if i put text in the empty field, the styling goes away
[10:27:01 CST(-0600)] <heidi_> ah ok
[10:27:02 CST(-0600)] <mlam> ohh ok
[10:27:16 CST(-0600)] <heidi_> still weird i'm getting a js bug in ie
[10:28:18 CST(-0600)] <heidi_> so mlam in IE, you can't click on the box w/o invitation text right? (http://issues.fluidproject.org/browse/FLUID-3635)
[10:28:37 CST(-0600)] <mlam> yah, that's right
[10:29:11 CST(-0600)] <heidi_> k
[10:29:21 CST(-0600)] <mlam> i'm trying to figure out why you have an error with the inline edit manual test page . i've cleared my cache, restarted my VM and still works fine
[11:00:15 CST(-0600)] <heidi_> mlam when i change the default view text to "", it works okay in IE
[11:00:29 CST(-0600)] <heidi_> so i think that bug might be a result of the old manual-tests html ?
[11:00:40 CST(-0600)] <heidi_> ^ justin_o
[11:01:16 CST(-0600)] <mlam> it very well could be. if it is as old as it's thought to be ,then it's a pretty fair assumption
[11:02:42 CST(-0600)] <Justin_o> heidi_: hmm.. not sure why that would cause it
[11:03:14 CST(-0600)] <heidi_> the styling is a little off (when default text is ""), so that you have to click the pencil vs the dotted line
[11:03:36 CST(-0600)] <heidi_> (in ie)
[11:03:53 CST(-0600)] <heidi_> the focus styling is a bug tho, in ff
[11:04:05 CST(-0600)] <heidi_> ill make a jira for both
[11:04:32 CST(-0600)] <Justin_o> heidi_: okay.. sorry .. i thought you meant that was why you were getting an error
[11:04:56 CST(-0600)] <heidi_> justin_o the unclickable-ness of the empty inline edit is i think a bug from the old manual-test html
[11:05:12 CST(-0600)] <heidi_> when i set default text to "" in the simple inline edit demo, it works
[11:05:17 CST(-0600)] <Justin_o> heidi_: okay.. got it... so it works fine in the demo in ie8?
[11:05:32 CST(-0600)] <Justin_o> okay.. that's godo
[11:05:32 CST(-0600)] <heidi_> justin_o yep except for the styling being off
[11:05:45 CST(-0600)] <Justin_o> heidi_: okay
[11:05:59 CST(-0600)] <Justin_o> heidi_: when would you like to talk about the builder stuff?
[11:06:21 CST(-0600)] <heidi_> justin_o anytime !
[11:06:49 CST(-0600)] <heidi_> basically not sure what to tweak to add description as part of the clickable region
[11:07:28 CST(-0600)] <Justin_o> heidi_: okay.. i'll try to look through the code a bit again.. it's been quite a while since i've looked at the js ... so it may take a bit
[11:07:42 CST(-0600)] <heidi_> justin_o , np ill file those jiras in the meantime
[11:08:03 CST(-0600)] <Justin_o> heidi_: thanks
[11:09:44 CST(-0600)] <Justin_o> heidi_: i'm checking out the code now, but i'm guessing there may not be a facility for it in the builder at the moment. It may just be working off of the clicks on the checkboxes... which works with the module titles because they are in the checkboxes label
[11:10:03 CST(-0600)] <heidi_> ah, i see
[11:10:24 CST(-0600)] <heidi_> extending the label to incl descriptions weird right?
[11:12:02 CST(-0600)] <Justin_o> heidi_: maybe
[11:12:34 CST(-0600)] <Justin_o> i'm not entirely sure.. haven't though too much about it.. i suppose they are both labelling the checkbox, when you think of it..
[11:12:47 CST(-0600)] <Justin_o> although the description is just that, an extended description
[11:15:19 CST(-0600)] <Justin_o> heidi_: it doesn't look like there are any click handlers specified
[11:15:56 CST(-0600)] <Justin_o> we could try to add one that programatically clicks the input field, although i'm not sure that will work in IE8 as the unit tests are failing on something similar to this
[11:16:05 CST(-0600)] <heidi_> hmm..
[11:16:24 CST(-0600)] <heidi_> we could adapt the hover style so that the label/descript are separated somehow
[11:16:29 CST(-0600)] <heidi_> to make it clearer
[11:16:38 CST(-0600)] <Justin_o> i see
[11:16:43 CST(-0600)] <Justin_o> so that they do not appear to be clickable
[11:16:54 CST(-0600)] <heidi_> yeah...
[11:17:16 CST(-0600)] <heidi_> tho i like descrip being included in hover
[11:17:22 CST(-0600)] <heidi_> easier to see
[11:17:23 CST(-0600)] <Justin_o> heidi_: we may want to see what james and jhung think
[11:17:30 CST(-0600)] <Justin_o> heidi_: that's true
[11:17:54 CST(-0600)] <heidi_> justin_o builder is being redesigned for 1.4 ?
[11:18:51 CST(-0600)] <jhung> heidi_ justin_o: reading log now..
[11:19:25 CST(-0600)] <heidi_> jhung its for http://issues.fluidproject.org/browse/FLUID-3842
[11:21:40 CST(-0600)] <jhung> heidi_: I see. I think it makes sense to make all text clickable.
[11:24:05 CST(-0600)] <heidi_> justin_o consider http://issues.fluidproject.org/browse/FLUID-3860 for bug parade ?
[11:31:53 CST(-0600)] <Justin_o> heidi_, jhung: jameswy's suggestion was to make it clickable if possible. Even if that meant putting it in the label, providing it didn't cause any issues... if that doesn't work, to fall back to the option of making the description appear differently so that it doesn't appear clickable
[11:32:23 CST(-0600)] <heidi_> sounds right
[11:34:35 CST(-0600)] <jhung> justin_o: I don't have any problems with using descriptions as labels. Actually may make more sense because now an AT would actually read off the entire description when focus is placed on a checkbox.
[11:35:04 CST(-0600)] <jhung> we may have to condense some of the text, but I think that's more of an issue for the redesign.
[11:35:14 CST(-0600)] <Justin_o> jhung: that's a good point..
[11:35:33 CST(-0600)] <Justin_o> jhung, heidi_: do you know if it is valid to have html tags in the label?
[11:37:25 CST(-0600)] <heidi_> justin_o not sure will google it up
[11:37:51 CST(-0600)] <Justin_o> heidi_: i'm trying to check too.. i'll let you know if i find anything
[11:38:07 CST(-0600)] <heidi_> justin_o so i added FLUID-3860 and FLUID-3861
[11:43:59 CST(-0600)] <Justin_o> heidi_: thanks.. just taking a look at them now
[11:45:30 CST(-0600)] <Justin_o> cindyli: did you file a jira for that reorderer issue you found?
[11:47:24 CST(-0600)] <cindyli> Justin_o: yes, working on that, setting up the test demo first
[11:50:58 CST(-0600)] <Justin_o> cindyli: ah right.. thanks
[11:57:44 CST(-0600)] <heidi_> justin_o putting <div> inside a label doesn't validate
[11:58:38 CST(-0600)] <Justin_o> heidi_: really
[11:58:47 CST(-0600)] <Justin_o> are labels inline elements?
[11:59:13 CST(-0600)] <heidi_> The mentioned element is not allowed to appear in the context in which you've placed it; the other mentioned elements are the only ones that are both allowed there and can contain the element mentioned. This might mean that you need a containing element, or possibly that you've forgotten to close a previous element.
[11:59:13 CST(-0600)] <heidi_> One possible cause for this message is that you have attempted to put a block-level element (such as "<p>" or "<table>") inside an inline element (such as "<a>", "<span>", or "<font>").
[11:59:49 CST(-0600)] <heidi_> looks like it
[12:00:55 CST(-0600)] <Justin_o> heidi_: could we put it into another type of element, say a span and make it display: block?
[12:01:42 CST(-0600)] <heidi_> justin_o span works fine
[12:02:39 CST(-0600)] <heidi_> doing that doesn't seem to make the descrip clickable tho!
[12:03:10 CST(-0600)] <cindyli> Justin_o: the new jira for reorderer issue is FLUID-3862
[12:42:16 CST(-0600)] <Justin_o> cindyli: thanks
[12:42:27 CST(-0600)] <Justin_o> heidi_: really.. any luck
[12:42:38 CST(-0600)] <Justin_o> with anything else
[12:43:50 CST(-0600)] <heidi_> justin_o it no longer renders properly when i change div to span and move </label> to include descrip
[12:43:59 CST(-0600)] <heidi_> does js need that template to work?
[12:44:03 CST(-0600)] <heidi_> brb lunch..
[12:46:09 CST(-0600)] <Justin_o> heidi_: okay we can chat when you get back
[12:55:39 CST(-0600)] <heidi_> justin_o back... looking at js
[12:56:03 CST(-0600)] <Justin_o> heidi_: did the descriptions not render out?
[12:56:15 CST(-0600)] <heidi_> that's right, just the headings
[12:56:57 CST(-0600)] <Justin_o> heidi_: okay.. so what you'll have to do is put the heading in some element as well... instead of it just being test in the label
[12:57:00 CST(-0600)] <heidi_> i.e changing the html doesn't do anything, so it's in the js somewhere
[12:57:26 CST(-0600)] <heidi_> hmm
[12:57:52 CST(-0600)] <Justin_o> so in the template you have something like <label> module name </lable> <p> description</p> not sure if this is the correct tag
[12:58:14 CST(-0600)] <Justin_o> and now you have it like this instead <label> module name <span>description</span></label>
[12:58:17 CST(-0600)] <Justin_o> is that correct?
[12:58:21 CST(-0600)] <heidi_> justin_o changing the template doesn't do anything tho
[12:58:24 CST(-0600)] <heidi_> yeah that's right
[13:01:29 CST(-0600)] <Justin_o> okay... and the descriptions are no longer present?
[13:03:23 CST(-0600)] <heidi_> right
[13:05:02 CST(-0600)] <heidi_> justin_o i don't understand the js well enough to tweak whatever needs tweaking.
[13:08:07 CST(-0600)] <jhung> anastasiac: I've attached a design update to the Keyboard a11y plugin jira: http://issues.fluidproject.org/browse/FLUID-3799
[13:08:26 CST(-0600)] <jhung> ^Take a look at the 3rd attached image.
[13:09:05 CST(-0600)] <Justin_o> heidi_: okay... how about i try to tweak something there and send you a patch... and if it works you can fix up the styling?
[13:09:16 CST(-0600)] <heidi_> justin_o cool
[13:12:35 CST(-0600)] <Justin_o> jamon: I don't think all of our e-mails are working. For example I don't think I've gotten any jira update e-mails today, eventhough there have been changes
[13:15:27 CST(-0600)] <anastasiac> jhung, thanks
[13:15:43 CST(-0600)] <anastasiac> jhung, do you have time to implement any of it, or are you swamped with other stuff?
[13:16:44 CST(-0600)] <anastasiac> actually, it doesn't look too bad, I can probably manage it (wink)
[13:19:52 CST(-0600)] <jhung> anastasiac: I may have time later today or tomorrow to help. I want to get some work done on the the new pager demo first.
[13:20:14 CST(-0600)] <anastasiac> k, no prob. I'll have a go, and if I get stuck, you can help
[13:21:09 CST(-0600)] <heidi_> anastasiac i can help if you need a hand!
[13:22:27 CST(-0600)] <anastasiac> heidi_, can you have a look at the third attachment to http://issues.fluidproject.org/browse/FLUID-3799, and see if you can update the keyboard-a11y demo in trunk to match the changes? thumbs along the top, and different selection/highlight styling... that'd be great!
[13:23:01 CST(-0600)] <jhung> Heidi_: if you need any clarification on the styling or interaction, let me know!
[13:23:16 CST(-0600)] <heidi_> anastasiac - cool , i'll do that. thanks jhung
[13:23:32 CST(-0600)] <anastasiac> thanks so much, heidi_!
[13:27:17 CST(-0600)] <jamon> Justin_o: k, checking
[13:41:01 CST(-0600)] <Justin_o> heidi_: I'm sending you a patch over IM for the builder
[13:41:11 CST(-0600)] <Justin_o> it was just a change to the html
[13:41:20 CST(-0600)] <heidi_> really?
[13:41:27 CST(-0600)] <heidi_> cool ill take a look in a sec
[13:41:49 CST(-0600)] <Justin_o> basically i moved the description into the label, and put the label text into a span... also i moved the class off of the label onto the span..
[13:42:28 CST(-0600)] <Justin_o> I added in a class name to the span for styling as well.. as it doesn't look so great at the moment.. but I think you can probably get that fixed up in no time
[13:43:45 CST(-0600)] <heidi_> justin_o , great ! will do that
[13:43:56 CST(-0600)] <Justin_o> heidi_: thanks.. is it working for you?
[13:44:13 CST(-0600)] <heidi_> applying patch.. have to rename my dir
[13:44:22 CST(-0600)] <Justin_o> heidi_: okay
[13:45:52 CST(-0600)] <heidi_> jamon the servers have blocked me again
[13:46:30 CST(-0600)] <jamon> heidi_: grr, ok
[13:49:07 CST(-0600)] <jamon> heidi_: just confirming, it is only source.fluid blocking you right?
[13:49:15 CST(-0600)] <heidi_> yep
[13:49:36 CST(-0600)] <heidi_> jamon fluidproject.org too... any fluid server i think?
[13:52:42 CST(-0600)] <jamon> heidi_: should be working now
[13:53:13 CST(-0600)] <heidi_> jamon no luck
[13:53:59 CST(-0600)] <jamon> heidi_: now?
[13:54:20 CST(-0600)] <heidi_> jamon yes! thanks
[13:55:01 CST(-0600)] <jamon> heidi_: i rotated out the log file with the failed authentication entries
[13:55:19 CST(-0600)] <heidi_> jamon does it say why this keeps happening?
[13:56:14 CST(-0600)] <jamon> heidi_: yes, the logfile gets re-read and since the block is missing for your ip, it gets readded
[13:56:23 CST(-0600)] <heidi_> ahh
[13:56:32 CST(-0600)] <jamon> this way, with your ssh key in place now, it won't happen since you shouldn't fail logging in more than once
[13:56:58 CST(-0600)] <heidi_> jamon yeah, and i've set my filezilla to not re-try!
[13:57:11 CST(-0600)] <jamon> that would probably do it (smile)
[13:57:16 CST(-0600)] <jamon> thanks heidi_
[13:59:19 CST(-0600)] <heidi_> justin_o descrips clickable! fixng css now
[14:01:52 CST(-0600)] <heidi_> justin_o if you add a <br /> between spans, and set the description padding to 0px, that works - wanna do that or should i add to your patch?
[14:03:18 CST(-0600)] <Justin_o> heidi_: do you mind adding to my patch and posting it to the jira
[14:03:35 CST(-0600)] <heidi_> justin_o will do
[14:03:41 CST(-0600)] <heidi_> on quick call w/ jen
[14:03:45 CST(-0600)] <heidi_> so after that
[14:06:11 CST(-0600)] <Justin_o> okay
[14:12:27 CST(-0600)] <jamon> Justin_o: looks like your mail came through
[14:12:33 CST(-0600)] <jamon> Justin_o: mind checking?
[14:13:15 CST(-0600)] <Justin_o> jamon: fluid-work is fine, but not getting anything still from jira
[14:13:24 CST(-0600)] <Justin_o> nothing since the 19th
[14:18:42 CST(-0600)] <jamon> Justin_o: i just tested with http://issues.fluidproject.org/secure/admin/SendTestMail.jspa works fine
[14:19:04 CST(-0600)] <jamon> mind trying to do something that would send a notification Justin_o and i can watch the logs?
[14:19:31 CST(-0600)] <Justin_o> jamon: okay... i'll try to do something...
[14:20:30 CST(-0600)] <Justin_o> jamon: actually heidi_ is going to add a patch soon, so we should be able to see from that
[14:20:51 CST(-0600)] <Justin_o> heidi_: could you let us know when the patch is up, jamon is going to check the logs about why the jira e-mails don't seem to be going through
[14:21:02 CST(-0600)] <heidi_> cool, making it now
[14:21:13 CST(-0600)] <Justin_o> heidi_: thanks
[14:21:17 CST(-0600)] <heidi_> tho actually, going to check IE first
[14:21:26 CST(-0600)] <Justin_o> heidi_: (smile) good idea
[14:31:10 CST(-0600)] <heidi_> justin_o second line of descrip goes under checkbox in IE... hm
[14:57:56 CST(-0600)] <heidi_> justin_o patch added to 3842
[14:59:52 CST(-0600)] <heidi_> justin_o when i add a patch, should i be updating the jira status/assigning ?
[15:17:27 CST(-0600)] <Justin_o> heidi_: I think it's okay.. maybe ping the list about needing a review