fluid-work IRC Logs-2010-11-29

Owned by Fluid IRC Log Bot
Last updated: Nov 29, 2010Version comment
9 min read

[08:38:46 CST(-0600)] <heidi_> justin_o still stuck on FLUID-3635 & FLUID-3801 , but let me know if you want me to keep at these or if there are higher priority bug parade issues i can help with!
[08:39:27 CST(-0600)] <heidi_> i'm also going to switch to working on UI Options at some point too, but let me know what you think
[08:39:45 CST(-0600)] <Justin_o> heidi_: i think those are okay for now... i'm going to take a look at the bug parade again now and updated too...
[08:39:46 CST(-0600)] <Justin_o> okay
[08:40:13 CST(-0600)] <heidi_> thanks
[08:45:16 CST(-0600)] <Justin_o> heidi_: did you create a patch for FLUID-3861?
[08:45:42 CST(-0600)] <Justin_o> heidi_: never mind i think i found it
[08:45:52 CST(-0600)] <heidi_> justin_o yep it's attached to the issue
[08:46:08 CST(-0600)] <Justin_o> heidi_: thanks
[09:11:48 CST(-0600)] <Justin_o> mlam: is FLUID-3855 ready for review?
[09:12:25 CST(-0600)] <mlam> I dont' think so
[09:12:33 CST(-0600)] <Justin_o> okay.. thanks
[09:12:46 CST(-0600)] <mlam> I posted the patch to share with jhung and heidi_, but I need to go back and check to see if the tests work
[09:13:13 CST(-0600)] <Justin_o> mlam: okay... good to know.. thanks
[09:13:32 CST(-0600)] <jhung> mlam: let me know when it's up and I can take a look at it.
[09:14:07 CST(-0600)] <mlam> jhung: the programmatic fix is working. I think you should be able to test that it's working properly. I just have to check the unit tests, and maybe even add one.
[09:14:49 CST(-0600)] <jhung> okay
[09:15:00 CST(-0600)] <anastasiac> heidi_, thanks for that permission change on the dev.handbook site - it worked
[09:15:10 CST(-0600)] <heidi_> ah cool (smile)
[09:15:19 CST(-0600)] <heidi_> how are you liking mediawiki?
[09:19:03 CST(-0600)] <jhung> mlam: what jira was it again?
[09:19:04 CST(-0600)] <anastasiac> heidi_, ok so far. I can't figure out how up upload an image - any suggestions?
[09:19:14 CST(-0600)] <mlam> FLUID-3855
[09:19:40 CST(-0600)] <mlam> Justin_o: There's already a test in place for the style. I think the patch is ready for review
[09:19:49 CST(-0600)] <Justin_o> mlam: okay.. thanks
[09:20:49 CST(-0600)] <Justin_o> jamon_: it seems like our uPortal nightly build has been failing
[09:20:57 CST(-0600)] <heidi_> anastasiac , try going to Special:Upload
[09:21:42 CST(-0600)] <anastasiac> heidi_, thanks - I supsected there was some such magic link, but I hadn't found out what it was yet - pretty obvious, I should have just tried it (smile)
[09:21:49 CST(-0600)] <heidi_> hehe
[09:22:16 CST(-0600)] <jamon_> Justin_o: k
[09:24:29 CST(-0600)] <jamon_> Justin_o: do you know who wrote all the scripts used for the builder? guessing anastasiac and nakul?
[09:24:43 CST(-0600)] <jamon_> er, for the uportal builder?
[09:25:08 CST(-0600)] <anastasiac> jamon_, you mean the continuum daily build tasks? I was involve with some of them, yes
[09:25:44 CST(-0600)] <jamon_> anastasiac: i'm poking around a bit now, if i can't get it to build/restart in a bit, i might need a hand
[09:26:13 CST(-0600)] <anastasiac> jamon_, sure - I might be able to help - I should be available shortly
[09:28:55 CST(-0600)] <jessm> heidi_: ping
[09:29:01 CST(-0600)] <heidi_> hey jessm
[09:29:52 CST(-0600)] <jessm> heidi_: i just updated the news item on the Floe site – a couple of observations: 1. the date didn't auto-update – i had to change the date manually and 2, can you check to make sure my HTML isn't awful and tell me how to make it better if needed? it's just an <a href>
[09:30:10 CST(-0600)] <heidi_> sure, let me take a look
[09:32:05 CST(-0600)] <heidi_> jessm looks good. did you delete the old news item/replace it with this one?
[09:32:12 CST(-0600)] <heidi_> vs just adding a new item
[09:32:53 CST(-0600)] <heidi_> that might be why you had to edit the date
[09:33:16 CST(-0600)] <jessm> heidi_: i did – didn't actually see how to add another – when i inquired last week i thought you said they weren't archived. i must have misunderstood
[09:33:20 CST(-0600)] <jessm> i can put the other one back
[09:33:39 CST(-0600)] <jessm> heidi_: how do i "add another one"?
[09:33:56 CST(-0600)] <mlam> Justin_o: just spoke with michelle, I'm going to go ahead and dive into the inline edit issues that were brought up during the code review. sound good?
[09:34:00 CST(-0600)] <heidi_> jessm content management->create content->news
[09:34:27 CST(-0600)] <Justin_o> mlam: yep that sounds good
[09:34:34 CST(-0600)] <jessm> heidi_: alright – i'll try to put the other one in there and then add a new one – so the notion of archiving DOES happen then
[09:34:44 CST(-0600)] <jessm> perhaps i confused the issue by calling it archiving
[09:34:54 CST(-0600)] <heidi_> jessm the old issues are kept yes
[09:34:58 CST(-0600)] <heidi_> er, news items
[09:35:07 CST(-0600)] <heidi_> sorry if i confused!
[09:38:48 CST(-0600)] <anastasiac> jamon_, are you making any headway on the uportal issue? I could have a look, if you like
[09:39:28 CST(-0600)] <jamon_> anastasiac: uportal_update_to_trunk.sh ran ok
[09:39:32 CST(-0600)] <jamon_> still checking
[09:41:27 CST(-0600)] <jessm> well, good then!
[09:41:30 CST(-0600)] <jessm> glad we did that
[09:41:36 CST(-0600)] <heidi_> (smile)
[09:41:55 CST(-0600)] <jessm> heidi_: and the syntax of my href is ok?
[09:42:05 CST(-0600)] <heidi_> jessm yep
[09:42:09 CST(-0600)] <jamon_> anastasiac: i think it's just that ERROR # 1 : error stopping hsql.
[09:42:37 CST(-0600)] <jamon_> er, that uportal_stop_tomcat.sh failed to kill the running instance, the uportal tomcat is still running after that script
[09:43:05 CST(-0600)] <anastasiac> jamon_, so the fix might be to just kill it, kill hsql, and pick up from there
[09:43:38 CST(-0600)] <jamon_> anastasiac: hmm, didn't work
[09:45:57 CST(-0600)] <mlam> michelled: are you going to review the patch for FLUID-3855 today?
[09:46:31 CST(-0600)] <michelled> mlam: do you need it reviewed before you can continue on inline edit fixes?
[09:47:08 CST(-0600)] <michelled> I have some cspace work I need to do today so I intending on doing Floe reviews tomorjrow
[09:47:30 CST(-0600)] <mlam> it would just make things a little easier so that i can separate the fix for the FLUID-3855 jira from the code review work
[09:48:00 CST(-0600)] <mlam> but i can continue working on the changes without the patch being committed
[09:48:02 CST(-0600)] <michelled> can you apply the 3855 patch in your space and I'll come over and look at it there - that is save me a little time
[09:48:31 CST(-0600)] <mlam> ok, sure
[10:03:47 CST(-0600)] <anastasiac> jamon_, my notes say we had left the credential as is
[10:04:53 CST(-0600)] <jamon_> anastasiac: i can telnet to the hsql on port 8887
[10:04:56 CST(-0600)] <jamon_> so it is there
[10:05:17 CST(-0600)] <jamon_> not sure how to test it from here, short of building some awful java app
[10:05:40 CST(-0600)] <anastasiac> jamon_, no - I'm looking at the uportal commits, to see what might have changed
[10:05:53 CST(-0600)] <jamon_> k
[10:23:50 CST(-0600)] <anastasiac> jamon_, do you know anything about hsqldb lock files? I'm stabbing in the dark, but maybe...
[10:24:10 CST(-0600)] <jamon_> anastasiac: i can look through and see if there are any
[10:24:32 CST(-0600)] <anastasiac> there is one, I'm wondering if it's not being properly released at some point, jamon_
[10:28:02 CST(-0600)] <jhung> Anyone here have experience with using Grid Reorderer?
[10:46:35 CST(-0600)] <mlam> heidi_: the patch that michelled helped me commit this morning may have fixed the issue with editing empty text in IE8. i'm just going to double check for you now
[10:46:52 CST(-0600)] <heidi_> awesome, i can update and get it?
[10:46:59 CST(-0600)] <mlam> yefws
[10:47:04 CST(-0600)] <mlam> hahah whoops
[10:47:04 CST(-0600)] <mlam> yes
[10:47:07 CST(-0600)] <mlam> it's in trunk
[10:48:52 CST(-0600)] <heidi_> cool ill check it out too
[10:49:50 CST(-0600)] <heidi_> mlam if the contents are changed to a space, it breaks
[10:49:52 CST(-0600)] <heidi_> in ie
[10:50:26 CST(-0600)] <mlam> ohh, i see. so it's a better solution, but not a full one (sad)
[10:50:29 CST(-0600)] <heidi_> mlam but if it's totally empty with no invite text, it works! just looks of, but we can fix that
[10:50:44 CST(-0600)] <heidi_> what fixed it?
[10:51:05 CST(-0600)] <mlam> we injected text into an empty inline edit with "Edit this" in italics
[10:51:33 CST(-0600)] <heidi_> mlam actually i was just looking on how to change that text or erase it - is that no longer possible?
[10:51:48 CST(-0600)] <mlam> maybe what we can do is trim the text, and if it's still empty, then we can reinject the text.
[10:52:06 CST(-0600)] <heidi_> yeah
[10:52:10 CST(-0600)] <mlam> It's definitely possible to change that text.
[10:52:12 CST(-0600)] <heidi_> what if defaultViewText="" tho?
[10:52:35 CST(-0600)] <mlam> then we're back to square one.
[10:53:05 CST(-0600)] <heidi_> mlam i think this might be used more often, where someone just wants a blank underlined area, like in forms etc
[10:54:15 CST(-0600)] <heidi_> mlam what's interesting is that it works until you click in/out of it, with defaultviewtext=""
[10:54:37 CST(-0600)] <heidi_> or wait. ie caching...
[10:57:25 CST(-0600)] <mlam> hmmm...yah...this one is so tricky.
[11:01:05 CST(-0600)] <anastasiac> heidi_, would you have some time this afternoon for a skype chat about the work you did in mediawiki for the handbook?
[11:01:22 CST(-0600)] <heidi_> anastasiac - sure
[11:01:40 CST(-0600)] <anastasiac> cool - I need to eat something, then run an errand, but maybe in an hour or so
[11:01:41 CST(-0600)] <anastasiac> ?
[11:05:54 CST(-0600)] <heidi_> anastasiac sure
[11:51:38 CST(-0600)] <heidi_> mlam i think if we moved the -invitation style to be on the <p> instead of the containing span it'd work w/o inline-block
[11:52:00 CST(-0600)] <heidi_> would that mess up other stuff?
[11:54:04 CST(-0600)] <mlam> Hmm....I can try it out and see what happens
[11:54:13 CST(-0600)] <heidi_> mlam it's okay ill test here first
[11:54:34 CST(-0600)] <heidi_> trying moving it to displayview style and making it -invitation:hover
[12:02:54 CST(-0600)] <mlam> heidi_: it didn't work.
[12:03:00 CST(-0600)] <mlam> the invitation style is still too short
[12:03:11 CST(-0600)] <heidi_> mlam yeah, i'm trying something else that's working, just fine-tuning
[12:51:07 CST(-0600)] <Bosmon2> anastasiac, colinclark, Justin_o: I am thinking I will need to make some changes to the area of the framework at "fluid.messageLocator"
[12:51:22 CST(-0600)] <Bosmon2> This function was documented as existing, but not in sufficient detail that anyone could use it successfully
[12:51:30 CST(-0600)] <Bosmon2> I am wondering whether this would count as an API change
[12:52:29 CST(-0600)] <colinclark> Bosmon2: Sounds like it does
[12:52:39 CST(-0600)] <colinclark> But talk us through what you're thinking nonetheless
[12:54:23 CST(-0600)] <jhung> anastasiac: do you have any experience with grid reorderer?
[12:54:56 CST(-0600)] <anastasiac> jhung, yes, but on a call right now
[12:55:00 CST(-0600)] <Bosmon2> So the API here is a bit "vestigial" in that the return value for fluid.messageLocator is simply a function rather than a "little component"
[12:55:05 CST(-0600)] <Bosmon2> We didn't really have little components in those days
[12:55:13 CST(-0600)] <jhung> anastasiac: cool. Ping me when you're free.
[12:55:24 CST(-0600)] <Bosmon2> So, it has become pretty urgent in CSpace to be able to support what you could call "hierarchical message bundles"
[12:55:50 CST(-0600)] <Bosmon2> You can see that the demand is fairly clear since we didn't really think through our strategy with "strings" yet.... it has so far been just left as a "point of expansion"
[12:56:18 CST(-0600)] <Bosmon2> But it should be possible for a component to say, "I define my own strings here which can be configured, but for any message key which isn't found here, please defer to the following bundle"
[12:57:06 CST(-0600)] <Bosmon2> Unfortunately fluid.messageLocator is hardwired to perform the resolution in one step - if it can't find a message key, it returns a particular kind of hardwired failure string rather than a special code which might allow it to cooperate with another locator
[12:58:50 CST(-0600)] <Bosmon2> I guess one way out is to package "backward-looking functionality" under this same name, but move the implementation to something like "fluid.messageResolver"
[12:59:00 CST(-0600)] <Bosmon2> Although the naming of these things has always confused me
[12:59:08 CST(-0600)] <colinclark> I was just going to ask about that possibility
[12:59:13 CST(-0600)] <colinclark> how has the naming confused you?
[12:59:33 CST(-0600)] <Bosmon2> Actually the configuration accepted by the renderer is called "messageSource"
[12:59:39 CST(-0600)] <Bosmon2> Which was always expected to be "one of a number of things"
[12:59:47 CST(-0600)] <Bosmon2> So perhaps this is actually less confusing than it might be
[13:11:16 CST(-0600)] <anastasiac> jhung, I'm off my call now
[13:25:47 CST(-0600)] <jhung> anastasiac: Do you have a few mins to skype?
[13:26:05 CST(-0600)] <anastasiac> indeed, jhung
[13:52:46 CST(-0600)] <anastasiac> jhung, it looks like the new 'disableWrap' option is supported by the gridReorderer as well as the layoutReorderer. I'm going to test that, but the code looks that way
[13:55:08 CST(-0600)] <jhung> amastasiac: cool. I think we'll keep wrapping on for now. Not sure if it makes much sense to have an option to enable disable wrapping in our demos.
[13:55:22 CST(-0600)] <anastasiac> jhung, confirmed. The current demo actually disables wrap using the option
[13:55:46 CST(-0600)] <anastasiac> but for such a small selection, wrapping is probably fine
[14:12:53 CST(-0600)] <colinclark> mlam: remind me why we made the image gallery listen for onFileComplete instead of afterFileComplete?
[14:12:57 CST(-0600)] <colinclark> (in your patch)
[14:14:06 CST(-0600)] <mlam> the afterFileComplete event clears the currentBatch , so in the image-gallery itself, we'll never have access to the batch information once the event gets fired
[14:16:03 CST(-0600)] <colinclark> oh, hmm
[14:17:35 CST(-0600)] <colinclark> I don't see where that actually happens
[17:24:52 CST(-0600)] <shw> hi
[17:31:53 CST(-0600)] <colinclark> shw: Hello
[17:32:13 CST(-0600)] <shw> hi Colin.
[17:32:56 CST(-0600)] <shw> I'm curious if this is the right place to talk about sakai and infusion integration?