fluid-work IRC Logs-2010-11-25

Owned by Fluid IRC Log Bot
Last updated: Nov 25, 2010Version comment
6 min read

[09:30:23 CST(-0600)] <justin_o> heidi_: hello, i was talking to jameswy this morning about inlineEdit. were you still interested in moving away from using inline-block?
[09:30:56 CST(-0600)] <jameswy> heidi_: say yes! (big grin)
[09:31:01 CST(-0600)] <heidi_> justin_o that might have to happen but need to look into it more. doing AODA training now - long! what does james hahaha
[09:31:25 CST(-0600)] <heidi_> yeah i mean, inline-block caused probs in keyboard a11y demo too so i think it could be a consistent IE8 prob
[09:31:56 CST(-0600)] <justin_o> heidi_: jameswy isn't happy with some of the styling effects that it is having in inlineEdit
[09:32:05 CST(-0600)] <justin_o> jameswy: what was the jira number again that you commented on
[09:32:28 CST(-0600)] <heidi_> FLUID-3635 is the big bug
[09:32:31 CST(-0600)] <justin_o> heidi_: anastasiac did the aoda training faster by just using the accessible version which is just a text file.. not sure if that would help you or not
[09:32:43 CST(-0600)] <justin_o> I know it took me forever when i went through the flash version
[09:32:54 CST(-0600)] <heidi_> cool ill check hat out for the other 2 mods
[09:32:58 CST(-0600)] <anastasiac> heidi_, justin_o, it's not so much text file, but text websites
[09:32:59 CST(-0600)] <heidi_> i am sort of enjoying it haha
[09:33:04 CST(-0600)] <anastasiac> you still need all the 'next' buttons
[09:33:14 CST(-0600)] <anastasiac> but yes, still time consuming
[09:35:08 CST(-0600)] <justin_o> heidi_: so for the issue james was mentioning.. he wanted all the text to be underlined, even when spread across multiple lines... and the undo should always show up right beside the pencil
[09:36:40 CST(-0600)] <jameswy> heidi_, justin_o: 3801
[09:38:43 CST(-0600)] <heidi_> checkin
[09:40:31 CST(-0600)] <heidi_> okay looks like several issues...
[09:44:35 CST(-0600)] <heidi_> i agree w yr comments jameswy
[09:45:13 CST(-0600)] <heidi_> i think we should make these changes before trying to figure out what's up with IE maybe
[09:45:49 CST(-0600)] <heidi_> i can work on that justin_o
[09:46:24 CST(-0600)] <justin_o> heidi_: thanks
[09:47:17 CST(-0600)] <justin_o> heidi_: are you still working on the opencaps stuff?
[09:47:24 CST(-0600)] <heidi_> justin_o nope
[09:47:31 CST(-0600)] <heidi_> just finishing AODA and then ill start on this
[09:47:46 CST(-0600)] <justin_o> heidi_: okay... thanks..
[09:48:08 CST(-0600)] <heidi_> justin_o is there any other inline edit stuff going on that i should wait for
[09:50:36 CST(-0600)] <justin_o> heidi_: i'm not sure.. there were some things that michelle had mentioned but i doubt they will get looked at much today
[09:51:13 CST(-0600)] <heidi_> okay
[09:51:20 CST(-0600)] <heidi_> but those reviewed patches are committed and stuff?
[10:20:02 CST(-0600)] <justin_o> heidi_: yep.. all the stuff that michelle looked at had already been committed
[10:20:12 CST(-0600)] <heidi_> k cool'
[12:12:03 CST(-0600)] <harriswong> justin_o: I have uploaded a patch for http://issues.fluidproject.org/browse/FLUID-3862.
[12:20:44 CST(-0600)] <Bosmon> Thanks harris - your patch looks like it could be correct
[12:20:52 CST(-0600)] <Bosmon> Could you supply a test case for the functionality that it fixes?
[12:21:34 CST(-0600)] <Bosmon> Although we were recently discussing deprecating the "reverse" merge policy in this release
[12:21:55 CST(-0600)] <Bosmon> The reorderer is the only component that uses it, and it will become obsolete once the IoC system can include "priority merging"
[12:23:29 CST(-0600)] <harriswong> Bosmon: ok. I will create/modify the test cases related to this and upload it to the jira.
[12:53:37 CST(-0600)] <heidi_> man, it's hailing here
[13:01:43 CST(-0600)] <heidi_> mlam , if there's a paragraph of txt for inline edit and i click on it, it changes to one line while editing
[13:01:58 CST(-0600)] <heidi_> i guess because it's a text input not textarea
[13:02:22 CST(-0600)] <mlam> Yah, jameswy made a comment on the FLUID-3801 JIRA this morning about that
[13:03:00 CST(-0600)] <colinclark> Typically, one would not use a simple text Inline Editor for paragraphs of text...
[13:03:13 CST(-0600)] <colinclark> Rich text Inline Edit or one with a text area would be more appropriate
[13:03:17 CST(-0600)] <colinclark> It's up to the implementer
[13:03:34 CST(-0600)] <heidi_> k
[13:09:08 CST(-0600)] <heidi_> colinclark when will rich text be released as stable
[13:09:30 CST(-0600)] <colinclark> Like, when will it be at production status?
[13:09:39 CST(-0600)] <heidi_> yep!
[13:09:46 CST(-0600)] <colinclark> I dunno exactly
[13:09:56 CST(-0600)] <heidi_> i like it, it's neat
[13:10:04 CST(-0600)] <colinclark> justin_o might have it on his roadmap, but it's not something that's been really hot on our list so far
[13:10:14 CST(-0600)] <colinclark> People use it in production now quite a bit, as far as I know
[13:10:56 CST(-0600)] <colinclark> Though its API is a little less than ideal at the moment, so we'll probably clean that up, making it much easier to plug in new rich text editors.
[13:13:34 CST(-0600)] <justin_o> colinclark, heidi_ : I don't think we have it in the plans for the next couple of releases
[13:22:20 CST(-0600)] <heidi_> justin_o mlam it'd be cool to allow <textarea class="flc-inlineEdit-text"></textarea> someday
[13:22:45 CST(-0600)] <justin_o> heidi_: technically you can do that now
[13:22:48 CST(-0600)] <heidi_> it seems to work, just needs styling...
[13:22:53 CST(-0600)] <justin_o> yep
[13:23:11 CST(-0600)] <heidi_> but it still switches to one-line during editing
[13:23:14 CST(-0600)] <justin_o> and the display text may not be as you'd expect
[13:23:17 CST(-0600)] <justin_o> yes
[13:23:34 CST(-0600)] <justin_o> that's because it follows the standard html way of rendering
[13:23:48 CST(-0600)] <justin_o> heidi_: i was thinking that someone may be able to use a <pre> tag
[13:23:58 CST(-0600)] <justin_o> for the display... i think that will keep it's formatting
[13:24:08 CST(-0600)] <heidi_> what do you mean standard html way of rendering
[13:24:49 CST(-0600)] <heidi_> what would <pre> do?
[13:26:40 CST(-0600)] <harriswong> heidi_: i think it preserves spaces and line breaks, also displaying element in a fixed width font.
[13:27:22 CST(-0600)] <heidi_> hm,how would you use it?
[13:48:31 CST(-0600)] <heidi_> hey mlam, what am i doing wrong if i add another <p> after the first one (in simple demo), like: <p class="flc-inlineEdit-text fl-inlineEdit-title"></p><p class="flc-inlineEdit-text">another one</p>
[13:48:53 CST(-0600)] <heidi_> maybe i should read documentation first
[13:50:03 CST(-0600)] <heidi_> what happens is they are both active when i choose one, and neither are editable
[13:50:10 CST(-0600)] <heidi_> i must be doing something wrong
[13:52:06 CST(-0600)] <mlam> Hey heidi_, i'm not sure what would happen. I'd have to try it out. Want me to give it a shot?
[13:52:25 CST(-0600)] <heidi_> i think i need to specify containers or something in the js ... reading doc
[13:52:46 CST(-0600)] <heidi_> sorry to distract prematurely mlam!
[13:53:32 CST(-0600)] <mlam> haha it's ok
[13:53:35 CST(-0600)] <heidi_> i'm not sure how to implement it...
[13:53:51 CST(-0600)] <heidi_> does each <p> need its own container?
[13:54:34 CST(-0600)] <mlam> Yes, every <p> needs its own container. I'm not sure what the effect of adding in an additional text selector would be. I'd have to try it out
[13:55:30 CST(-0600)] <heidi_> mlam then where do you specify the container to the js?
[13:56:27 CST(-0600)] <mlam> heidi_: the <div> wrapping the inlineEdit text is the container
[13:56:32 CST(-0600)] <heidi_> mlam i think i see, you have to create a function for each container in the js or something
[13:57:10 CST(-0600)] <heidi_> ah, and "simpleEditTitle" is defined in the js or something
[13:57:23 CST(-0600)] <mlam> heidi_: check the inlineEdit.js file in the demos folder...and you'll see how the container is created
[13:57:44 CST(-0600)] <heidi_> yeah. so every inline edit area needs this..
[13:59:41 CST(-0600)] <heidi_> i think what i want is fluid.inlineEdits(componentContainer, options); ? instead of fluid.inlineEdit(
[14:01:14 CST(-0600)] <mlam> the manual test for inline edit is an example of the fluid.inlineEdits....but yes, the inlineEdits is what ur looking for
[14:03:06 CST(-0600)] <heidi_> thanks mlam
[14:03:45 CST(-0600)] <mlam> np heidi_, sorry for the short answers .... my brain is in "Uploader Land"
[14:03:53 CST(-0600)] <heidi_> i hear ya (wink)
[15:08:28 CST(-0600)] <Bosmon> Thanks, harriswong
[15:10:23 CST(-0600)] <heidi> mlam i forget, did we decide that all the inline styles are being created by the ".css()" call ? ie. the style="" throughout inline edit
[15:12:01 CST(-0600)] <mlam> No, we didn't decide yet....maybe we can ask justin tomorrow if we should clean it all up
[15:35:13 CST(-0600)] <harriswong> Bosmon: I have added testcases to http://issues.fluidproject.org/browse/FLUID-3862.