fluid-work IRC Logs-2012-08-24

Owned by Fluid IRC Log Bot
Last updated: Aug 24, 2012Version comment

[08:22:02 CDT(-0500)] <michelled> alexn1: if you are fixing an issue in the tooltip, you'll need a JIRA for that work

[08:22:19 CDT(-0500)] <michelled> it would be related to the video player JIRA issue

[08:22:42 CDT(-0500)] <alexn1> michelled: ok and then submit a pull request to Infusion against master ?

[08:22:51 CDT(-0500)] <michelled> yep

[08:22:59 CDT(-0500)] <alexn1> michelled: ok will do. thx a lot !

[08:23:04 CDT(-0500)] <michelled> np

[08:49:42 CDT(-0500)] <alexn1> michelled: I submitted my pull request https://github.com/fluid-project/infusion/pull/238 (smile)

[08:52:38 CDT(-0500)] <michelled> thanks alexn1

[09:11:00 CDT(-0500)] <michelled> alexn1: I was just looking at your pull request and I'm wondering if there's another way to do this. it feels like we know too much about the implementation details

[09:11:54 CDT(-0500)] <michelled> alexn1: did you get a chance to look at the underlying jquery UI tooltip plugin to see if there's an API to update the content dynamically?

[09:12:07 CDT(-0500)] <alexn1> michelled: way of doing without .html() right ? I tried to search for the solution but it is the only one I could find

[09:12:21 CDT(-0500)] <alexn1> michelled: I checked it but unfortunately could not find one

[09:12:32 CDT(-0500)] <alexn1> apparently it is a known problem for many people

[09:12:38 CDT(-0500)] <michelled> alexn1: did you check to see if the tooltip plugin has been updated since we last pulled it?

[09:12:55 CDT(-0500)] <alexn1> here is an example of people having the same issue http://stackoverflow.com/questions/6650853/jquery-tools-tooltip-change-title

[09:13:18 CDT(-0500)] <alexn1> I was checking on the jquery tools website but I will double check one more time

[09:13:26 CDT(-0500)] <michelled> alexn1: did you try using the bodyHandler option? http://docs.jquery.com/Plugins/Tooltip/tooltip#options

[09:14:07 CDT(-0500)] <alexn1> michelled: nope. looking into it

[09:56:06 CDT(-0500)] <alexn1> michelled: jquery ui tooltip which we are using does not have bodyHandler

[09:56:56 CDT(-0500)] <alexn1> michelled: there are other jquery tooltip plugins which have it but not the one we are using. I tried to play with content function trying different things but it does not work for me.

[09:58:32 CDT(-0500)] <michelled> alexn1: is it because we haven't updated recently?

[09:58:45 CDT(-0500)] <alexn1> it just not part of it

[09:58:53 CDT(-0500)] <alexn1> it is other jquery plugins which have this setting

[09:58:59 CDT(-0500)] <alexn1> *jquery tooltip plugins

[09:59:13 CDT(-0500)] <alexn1> but not jquery ui tools tooltip which we are using

[10:00:38 CDT(-0500)] <alexn1> this is the tooltip plugin which has this property http://bassistance.de/jquery-plugins/jquery-plugin-tooltip/

[10:01:22 CDT(-0500)] <alexn1> but not the http://wiki.jqueryui.com/w/page/12138112/Tooltip

[10:11:08 CDT(-0500)] <michelled> alexn1: ok, let's have a quick conversation with Justin_o about this on Monday

[10:12:57 CDT(-0500)] <alexn1> michelled: sounds good. I tried lots of different things with content function of the tooltip we are using but no success

[10:13:17 CDT(-0500)] <alexn1> we should definitely chat about this on monday

[10:13:23 CDT(-0500)] <michelled> we should document this somewhere so we don't forget

[10:13:33 CDT(-0500)] <michelled> I'll comment on the pull request and you can reply with your findings

[10:46:08 CDT(-0500)] <alexn1> michelled: https://github.com/anvk/OER-Commons/tree/OER-725 this is one of them. but it is a small problem. I also was looking into 733 and 734 but they are not so obvious as I expected. I want to double check few things before I submit 733 for your review since I do not like the fix too much

[10:49:34 CDT(-0500)] <michelled> ok alexn1 sounds good

[10:55:45 CDT(-0500)] <michelled> alexn1: what did you use as your base branch for 725?

[10:55:55 CDT(-0500)] <alexn1> staging

[10:56:16 CDT(-0500)] <alexn1> if you git checkout staging

[10:56:23 CDT(-0500)] <alexn1> and then diff with my branch you will see the changes

[10:56:26 CDT(-0500)] <alexn1> there are few lines

[10:59:16 CDT(-0500)] <alexn1> michelled: I have 2 more pull requests https://github.com/fl