fluid-work IRC Logs-2012-08-28

Owned by Fluid IRC Log Bot
Last updated: Aug 28, 2012Version comment
3 min read

[09:04:12 CDT(-0500)] <alexn1> michelled: I made few more changes as we discussed yesterday https://github.com/anvk/OER-Commons/compare/ISKME:staging...anvk:OER-745

[09:11:11 CDT(-0500)] <michelled> thx alexn1

[09:14:00 CDT(-0500)] <alexn1> michelled: also this commit will show the major change since yesterday https://github.com/anvk/OER-Commons/commit/e1c07e63667ebce58b0c4270987573adcc1c380c

[09:54:38 CDT(-0500)] <anastasiac> michelled, I've got a pull request that fixes the tab order of the video player controls: https://github.com/fluid-project/videoPlayer/pull/48

[10:03:11 CDT(-0500)] <michelled> thx anastasiac

[10:05:49 CDT(-0500)] <michelled> alexn1: I haven't tested your fix, but if you have tested it in the target browsers, I think you should go ahead with the pull request to staging. I think this is a good improvement to your code.

[10:06:56 CDT(-0500)] <alexn1> michelled: I will. If you come up with more ideas on how to dehydrate the code or possibly improve it, let me know. Always (smile) glad to learn from your feedback

[10:07:19 CDT(-0500)] <michelled> ok alexn1

[10:13:59 CDT(-0500)] <michelled> anastasiac: what browsers did you test your fixes on for 4777?

[10:14:37 CDT(-0500)] <anastasiac> FF and chrome, michelled. I'm having trouble, in general, in IE, independent of my changes

[10:15:24 CDT(-0500)] <michelled> anastasiac: yeah, I really should pick up cindy's branch at some point which improves a lot of things about IE

[10:15:51 CDT(-0500)] <anastasiac> michelled, if it helps keyboard a11y, that would be great. most of the time, I can't tab past the first control or two

[10:15:56 CDT(-0500)] <anastasiac> but it's in consistent

[10:16:16 CDT(-0500)] <michelled> I think it does help keyboard a11y but I'm not sure how far she got

[10:16:30 CDT(-0500)] <michelled> anastasiac: do you think you could write a reasonable test for the focus order?

[10:17:01 CDT(-0500)] <anastasiac> michelled, I was wondering about that. I'm not sure how to test that. any ideas?

[10:18:23 CDT(-0500)] <michelled> it's a good question. I'm not really sure - I guess we could trigger some tabs and see what gets focus.

[10:18:36 CDT(-0500)] <michelled> but I think it would be a really brittle test

[10:18:45 CDT(-0500)] <michelled> we haven't really had much success with that, have we?

[10:18:54 CDT(-0500)] <michelled> Justin_o: have you had any success in automated tests for tab order?

[10:18:55 CDT(-0500)] <anastasiac> no, keyboard-a11y testing has never been easy

[10:19:37 CDT(-0500)] <michelled> btw anastasiac - the component is so much easier to use now - the combination of focus styling and tab order really helps

[10:19:52 CDT(-0500)] <anastasiac> yeah, I find the focus styling helps a lot (smile)

[10:20:01 CDT(-0500)] <Justin_o> michelled: you mean automatically tabbing through elements, simulating the keyboard?

[10:21:26 CDT(-0500)] <anastasiac> Justin_o, yes, that's what we mean

[10:22:00 CDT(-0500)] <Justin_o> anastasiac, michelled: no i haven't had any success with that.. haven't tried it in a while though, but what i found is that the browser ignores those synthetic events

[10:22:24 CDT(-0500)] <anastasiac> yeah, we've had trouble simulating keystrokes in unit tests before

[10:22:27 CDT(-0500)] <Justin_o> the only thing the would work was some sort of robot to call real system events

[10:22:51 CDT(-0500)] <michelled> we've had this conversation a number of times, haven't we?

[10:23:07 CDT(-0500)] <michelled> oh well, I guess to leave it up to manual testing to catch this type of regression

[10:23:22 CDT(-0500)] <michelled> maybe next year we should have a gsoc project to build us some robot tests (wink)

[10:23:29 CDT(-0500)] <anastasiac> (smile)

[10:24:51 CDT(-0500)] <Justin_o> michelled: sounds like a good idea.. we should start tracking these ideas somewhere so we don't forget them

[10:26:42 CDT(-0500)] <michelled> anastasiac: I pushed your pull request

[10:27:14 CDT(-0500)] <anastasiac> thanks, michelled. If I ever manage to tab into the VideoPlayer in IE, I'll be sure to test it :-/

[14:24:41 CDT(-0500)] <anastasiac> jameswy, I've assigned FLUID-4778 to you with a question about keystrokes for the VideoPlayer. Could you please respond on the JIRA and assign it back to me?

[14:32:00 CDT(-0500)] <jameswy> anastasiac: Will do.

[14:32:05 CDT(-0500)] <anastasiac> thanks