fluid-work IRC Logs-2011-02-07

Owned by Fluid IRC Log Bot
Last updated: Feb 07, 2011Version comment
17 min read

[08:32:11 CST(-0600)] <heidi_> hey colinclark, i wrote the refreshView func for scroller but need some guidance on where it goes, and how it's called
[08:32:28 CST(-0600)] <heidi_> then i'll git it up (wink)
[08:32:53 CST(-0600)] <colinclark> ok
[08:33:00 CST(-0600)] <colinclark> fire away
[08:33:49 CST(-0600)] <heidi_> i think i'm confused about the namespacing for it. so it's going to live in FluidView.js
[08:34:18 CST(-0600)] <heidi_> fluid.scrollable.refreshView = function(that) { - is that correct? where that has the scrollable
[08:34:23 CST(-0600)] <colinclark> Nope
[08:34:29 CST(-0600)] <heidi_> didn't think so...
[08:34:37 CST(-0600)] <colinclark> So, that's a "free function"
[08:34:48 CST(-0600)] <colinclark> A plain old function, not attached to any object
[08:34:55 CST(-0600)] <colinclark> You've put it in the "fluid.scrollable" namespace
[08:35:04 CST(-0600)] <heidi_> but its specific to scroller no?
[08:35:26 CST(-0600)] <colinclark> There are lots of times when this is a good thing to do, especially when you have multiple implementations of a function, as we have elsewhere in that code
[08:35:36 CST(-0600)] <colinclark> but what you want is a public method on your scrollable object
[08:35:45 CST(-0600)] <heidi_> ya
[08:36:01 CST(-0600)] <heidi_> but also don't want to bump into any other refreshViews out there
[08:36:53 CST(-0600)] <colinclark> Which other refreshViews could you bump into?
[08:38:40 CST(-0600)] <colinclark> This page describes how to create public methods. I'm not sure the narrative is quite accurate, but the code samples are...
[08:38:41 CST(-0600)] <colinclark> http://wiki.fluidproject.org/display/fluid/The+creator+function%2C+and+the+%27that%27+object
[08:38:45 CST(-0600)] <heidi_> colinclark i thought other views have refreshViews
[08:38:51 CST(-0600)] <colinclark> heidi_: They do
[08:39:04 CST(-0600)] <colinclark> So, when I say "a public method," I mean something fairly specific
[08:39:28 CST(-0600)] <colinclark> A method is, in terms of object-oriented terminology, a function that is scoped specifically to an object
[08:39:49 CST(-0600)] <heidi_> right right
[08:40:06 CST(-0600)] <colinclark> So, if you scope it correctly, there's no way one object's method could bump into another object's method
[08:40:08 CST(-0600)] <heidi_> so that.refreshView() would be it ?
[08:40:09 CST(-0600)] <colinclark> by nature of what they are
[08:40:16 CST(-0600)] <colinclark> they are things you call on the object itself
[08:40:20 CST(-0600)] <colinclark> yes, that's right, heidi_
[08:41:09 CST(-0600)] <heidi_> cool, got it. gotta remember simplest is usually rightest
[08:42:20 CST(-0600)] <colinclark> anastasiac: This conversation might be something to consider when you're revisiting this particular piece of documentation
[08:42:39 CST(-0600)] <anastasiac> colinclark, I've already made a note of it in my notes (smile)
[08:43:48 CST(-0600)] <heidi_> colinclark could i borrow your js book this week?
[08:43:54 CST(-0600)] <colinclark> Yeah
[08:43:57 CST(-0600)] <colinclark> Which one, heidi_?
[08:44:01 CST(-0600)] <heidi_> oreillys?
[08:44:14 CST(-0600)] <heidi_> or any other you recommend
[08:44:15 CST(-0600)] <colinclark> So, there are two books worth reading
[08:44:21 CST(-0600)] <colinclark> Unfortunately one of them isn't particularly good
[08:44:29 CST(-0600)] <colinclark> it's worth reading, but with a grain of salt
[08:44:39 CST(-0600)] <colinclark> the other one is entirely a goldmine, but it's packed pretty densely
[08:44:49 CST(-0600)] <colinclark> So the first is the "Rhino Book"
[08:44:55 CST(-0600)] <colinclark> By David Flanagan
[08:45:07 CST(-0600)] <colinclark> There's a lot in it, and it teaches you some pretty suspect stuff
[08:45:20 CST(-0600)] <colinclark> but it will provide you with a relatively comprehensive view of the language
[08:45:38 CST(-0600)] <colinclark> the second-the gem-is called "JavaScript: The Good Parts," by Douglas Crockford
[08:45:51 CST(-0600)] <colinclark> It teaches you all the bugs and problems in the language, and how to avoid them
[08:46:06 CST(-0600)] <colinclark> leaving you with a subset of JavaScript that is really great, reliable, and cool
[08:46:08 CST(-0600)] <heidi_> both sounds good
[08:46:32 CST(-0600)] <colinclark> I guess you could try the Crockford book first, and then see if it's too much to start with
[08:46:39 CST(-0600)] <colinclark> I can't remember who has it
[08:46:43 CST(-0600)] <colinclark> maybe yura?
[08:46:55 CST(-0600)] <heidi_> ill ask him when he gets in
[08:47:34 CST(-0600)] <colinclark> speak of the devil
[08:47:41 CST(-0600)] <colinclark> hey yura_, I can't remember...
[08:47:47 CST(-0600)] <colinclark> do you have the Crockford book at the moment?
[08:48:03 CST(-0600)] <yura_> colinclark: yes i have it at home, should i bring it to the office ?
[08:48:16 CST(-0600)] <colinclark> If you're done with it for a bit, heidi_ is looking to read it
[08:48:28 CST(-0600)] <colinclark> When are you in next, heidi_? Wednesday?
[08:48:32 CST(-0600)] <heidi_> yep
[08:48:39 CST(-0600)] <heidi_> is that cool yura_ ?
[08:49:08 CST(-0600)] <yura_> heidi_: sure , ill bring it tomorrow
[08:49:22 CST(-0600)] <heidi_> yura_ cool ill grab it wed when i'm in - thanks!
[08:50:35 CST(-0600)] <colinclark> thanks, yura_
[08:50:44 CST(-0600)] <yura_> np
[08:51:13 CST(-0600)] <colinclark> This is the book, in case anyone wants to order it. It's fairly cheap...
[08:51:15 CST(-0600)] <colinclark> http://www.amazon.ca/JavaScript-Good-Parts-Douglas-Crockford/dp/0596517742/ref=sr_1_1?ie=UTF8&amp;qid=1297090252&amp;sr=8-1
[08:51:47 CST(-0600)] <heidi_> when's the o'reilly infusion book coming out? (wink)
[08:52:46 CST(-0600)] <colinclark> we have plans (smile)
[08:53:11 CST(-0600)] <heidi_> wicked. colinclark do we have the o'reilly html 5 book?
[08:53:41 CST(-0600)] <colinclark> nope
[08:53:48 CST(-0600)] <heidi_> k
[08:54:17 CST(-0600)] <colinclark> you know about mark pilgrim's HTML5 book?
[08:54:35 CST(-0600)] <colinclark> http://diveintohtml5.org/
[08:54:52 CST(-0600)] <colinclark> kind of a nice looking book
[08:55:23 CST(-0600)] <heidi_> oh looks cool - thanks, bookmarking
[09:27:46 CST(-0600)] <anastasiac> Justin_o, regarding FLUID-4036, removing rsf:id dependencies from Pager: Is this still on the roadmap for 1.3.1?
[09:28:00 CST(-0600)] <Justin_o> anastasiac: at the moment yes
[09:28:41 CST(-0600)] <anastasiac> ok, thanks. The tutorial explains the rsf:ids, so I'll hold off on considering the tutorial complete until the code is updated and I adjust the tutorial
[09:30:05 CST(-0600)] <Justin_o> anastasiac: thanks... i'm going to try to work some more on it today
[09:50:41 CST(-0600)] <mlam> Justin_o: how do you avoid pushing the .project file from a local repository into a remote repository that's created from git?
[09:51:19 CST(-0600)] <Justin_o> mlam: you can set up the .gitignore
[09:51:31 CST(-0600)] <Justin_o> you can do it globally or per repo
[09:52:37 CST(-0600)] <Justin_o> mlam: assuming you want to do this globally you would do the following
[09:52:56 CST(-0600)] <Justin_o> git config --global core.excludedsfile ~/.gitignore
[09:53:11 CST(-0600)] <Justin_o> and then in that .gitignore file have a line like
[09:53:17 CST(-0600)] <Justin_o> .project
[09:54:22 CST(-0600)] <mlam> does that config command need to be run on a fresh clone?
[09:54:36 CST(-0600)] <Justin_o> not if you do it globally
[09:54:49 CST(-0600)] <Justin_o> if you take out the --global you would call it from within the repo
[09:56:47 CST(-0600)] <mlam> I ran the command, yet when I do a git checkout, the .project file still shows. It shouldn't be displayed, right?
[09:57:12 CST(-0600)] <Justin_o> no.. it will still be in the filesystem.. it just won't track changes
[10:10:42 CST(-0600)] * Topic is 'This channel is logged – for details see: http://wiki.fluidproject.org/display/fluid/IRC+Channel' set by jessm on 07:30:00 CST(-0600)
[10:11:16 CST(-0600)] <heidi_> so my update is putting up a fix for an IE6 scroller issue, then documentation all the way... ttys
[10:25:36 CST(-0600)] <colinclark> mlam: I've closed FLUID-4017--both your patches are in
[10:25:45 CST(-0600)] <mlam> thanks colin
[10:25:48 CST(-0600)] <colinclark> Can you file a separate JIRA ticket for the test failure, and I'll commit that whenever
[10:25:59 CST(-0600)] <mlam> ok
[10:26:43 CST(-0600)] <mlam> colinclark: is it ok if i combine the fixed test with my patch for FLUID-3886?
[10:27:03 CST(-0600)] <colinclark> If it's easier, sure
[10:27:09 CST(-0600)] <mlam> ok, cool
[10:50:24 CST(-0600)] <colinclark> hey heidi_, I have a question about your patch to FLUID-3837
[10:50:28 CST(-0600)] <colinclark> -j is the latest version, right?
[10:50:38 CST(-0600)] <heidi_> let me look..
[10:51:09 CST(-0600)] <heidi_> colinclark , yes -j
[10:51:31 CST(-0600)] <colinclark> Okay, it looks to me like it contains all the changes from the last version of the patch, which I committed back on January 27
[10:51:56 CST(-0600)] <colinclark> Looks like I committed the -f patch with a few modifications.
[10:52:21 CST(-0600)] <colinclark> But your -f patch seems to be trying to add things like the scrollTo plugin, etc.
[10:52:36 CST(-0600)] <heidi_> the -j is ?
[10:53:36 CST(-0600)] <colinclark> I think, so
[10:53:44 CST(-0600)] <colinclark> sorry, yes, the -j patch
[10:55:48 CST(-0600)] <heidi_> ok... um. what's the best way to do this now?
[10:56:50 CST(-0600)] <colinclark> Well, I need a patch that will apply cleanly
[10:57:15 CST(-0600)] <colinclark> Do you know what changes you made between the time I committed your last patch and when you created the -j patch?
[10:58:39 CST(-0600)] <heidi_> colinclark -j would have been just Uploader.css and Uploader.html
[10:58:49 CST(-0600)] <heidi_> within those, i'm not sure
[11:01:21 CST(-0600)] <colinclark> eek
[11:01:32 CST(-0600)] <colinclark> ok, we can figure this out
[11:02:17 CST(-0600)] <jhung> cindyli1 and harriswong: both of you have worked on Builder before, right?
[11:02:41 CST(-0600)] <harriswong> jhung: yes
[11:02:43 CST(-0600)] <cindyli1> cindyli1: yes
[11:03:02 CST(-0600)] <jhung> thanks! I'm writing an email and just wanted to make sure I put both of you on it. (smile)
[11:03:16 CST(-0600)] <cindyli1> jhung: ok
[11:48:06 CST(-0600)] <heidi_> hey Justin_o how come my terminal doesn't have pretty git colours (red, green, etc). is it a setting?
[11:48:38 CST(-0600)] <colinclark> heidi_: There's a slide in Justin_o's deck that has the colour settings
[11:49:16 CST(-0600)] <heidi_> thanks colinclark - will look it up. i'm committing my changes to fluid-4037 branch now
[11:49:22 CST(-0600)] <colinclark> cool
[11:49:28 CST(-0600)] <colinclark> and then you'll push the branch, heidi_?
[11:49:54 CST(-0600)] <heidi_> colinclark i added my two files, now committing... is that right?
[11:50:07 CST(-0600)] <colinclark> add, commit, and push
[11:50:18 CST(-0600)] <colinclark> So remember that committing only applies to your local repository
[11:50:26 CST(-0600)] <colinclark> pushing sends those changes up to the github repo
[11:50:32 CST(-0600)] <heidi_> colinclark commit is just for me, and push is for all?
[11:50:37 CST(-0600)] <heidi_> ah
[11:50:39 CST(-0600)] <colinclark> yes
[11:52:08 CST(-0600)] <heidi_> colinclark what would my alias be?
[11:52:41 CST(-0600)] <colinclark> heidi_: I have no idea
[11:52:41 CST(-0600)] <colinclark> w
[11:52:45 CST(-0600)] <colinclark> what's the context?
[11:52:58 CST(-0600)] <heidi_> To do this, you run git push [alias] [branch]
[11:53:25 CST(-0600)] <colinclark> That'd be an alias to a remote repository
[11:53:25 CST(-0600)] <colinclark> b
[11:53:26 CST(-0600)] <colinclark> ut r
[11:53:39 CST(-0600)] <colinclark> but remember that Git will set one up automatically for you
[11:53:53 CST(-0600)] <colinclark> So, every repo you clone will have a remote set up for you called "origin"
[11:53:59 CST(-0600)] <colinclark> which points back to the repository you cloned it from
[11:54:14 CST(-0600)] <colinclark> So if you want to push your changes back there, you should just be able to run "git push"
[11:54:21 CST(-0600)] <colinclark> and it defaults to pushing up to "origin"
[11:54:40 CST(-0600)] <heidi_> aha
[11:54:45 CST(-0600)] <heidi_> okay that did something
[11:54:49 CST(-0600)] <colinclark> Once you're done that, maybe have take another look through Justin's slide deck, which has illustrations for many of these points
[11:56:54 CST(-0600)] <colinclark> heidi_: Couple minor details...
[11:57:10 CST(-0600)] <colinclark> Don't forget to use JIRA prefixes for each of your commits, just like you'd do with SVN
[11:57:26 CST(-0600)] <colinclark> even if it's redundant, they're needed so that JIRA can track commits we make to Git
[11:57:31 CST(-0600)] <heidi_> ok
[11:57:52 CST(-0600)] <colinclark> But it looks like your push worked!
[11:58:00 CST(-0600)] <heidi_> right on
[11:59:04 CST(-0600)] <colinclark> Justin_o: Do you know how heidi_ can go back and fix her commit log?
[12:00:15 CST(-0600)] <Justin_o> colinclark: yes.. let me look that up again
[12:01:33 CST(-0600)] <Justin_o> colinclark, heidi_ : this shows how to do it for the last commit
[12:01:34 CST(-0600)] <Justin_o> http://stackoverflow.com/questions/179123/how-do-i-edit-an-incorrect-commit-message-in-git
[12:01:45 CST(-0600)] <Justin_o> basically use git commit --amend
[12:02:47 CST(-0600)] <heidi_> justin_o git commit --amend "new msg" ?
[12:03:16 CST(-0600)] <heidi_> -m 'new msg'
[12:03:44 CST(-0600)] <Justin_o> heidi_: i would guess it would just open the editor again, if you don't use the -m
[12:06:18 CST(-0600)] <heidi_> don't think that did it..
[12:09:33 CST(-0600)] <heidi_> colinclark i think i did an unnecessary pull in there, but the msg is updated
[12:16:46 CST(-0600)] <colinclark> thanks, heidi_
[12:19:34 CST(-0600)] <heidi_> colinclark there are a couple "is this right?" comments in my code ... i'm guessing this is okay to do within our git code-trading process?
[12:22:33 CST(-0600)] <mlam> colinclark: I've just completed a pull request for FLUID-3886 and FLUID-4053.
[12:23:53 CST(-0600)] <mlam> Justin_o: is there an option on github to direct your pull requests to a specific person?
[12:24:35 CST(-0600)] <Justin_o> mlam: not that I know of
[12:25:05 CST(-0600)] <mlam> ok
[12:28:14 CST(-0600)] <Justin_o> mlam: http://help.github.com/pull-requests/
[12:28:46 CST(-0600)] <Justin_o> I suppose you can add it in the description
[12:54:42 CST(-0600)] <anastasiac> colinclark, did you just update FLUID-1796 "Document Fluid's use of MVC"?
[12:54:54 CST(-0600)] <colinclark> ?
[12:54:57 CST(-0600)] <anastasiac> JIRA says it was an 'anonymous' change
[12:55:06 CST(-0600)] <anastasiac> ok, so it wasn't you...
[12:55:33 CST(-0600)] <colinclark> what's the change?
[12:55:33 CST(-0600)] <anastasiac> someone set the status to "needs commit" but JIRA won't say who... odd...
[12:55:42 CST(-0600)] <anastasiac> I didn't know you could do taht!
[12:56:24 CST(-0600)] <anastasiac> and "needs commit" doesn't make much sense in this case, given that the work isn't complete
[12:57:47 CST(-0600)] <anastasiac> Justin_o, do you know how someone could anonymously change the status of a JIRA?
[12:57:58 CST(-0600)] <Justin_o> anastasiac: didn't know that
[13:02:52 CST(-0600)] <anastasiac> hm... can't figure out how to reset it to 'open'...
[13:24:51 CST(-0600)] <colinclark> michelled, heidi_, mlam: Can we check in here real quick about Uploader?
[13:25:05 CST(-0600)] <mlam> yup for sure
[13:25:07 CST(-0600)] <heidi_> yep
[13:25:30 CST(-0600)] <colinclark> I'm getting ready to hand off the Uploader code review to michelled for a few days
[13:25:54 CST(-0600)] <michelled> ok
[13:26:01 CST(-0600)] <colinclark> I need to spend some time working on UI Options research, which will be pretty important for the 1.4 release as well as an upcoming GPII architecture meeting later this week.
[13:26:17 CST(-0600)] <colinclark> So, I just want to check in about each of the patches that are on deck
[13:26:39 CST(-0600)] <colinclark> Heidi, you pushed some changes to our FLUID-4037 fork. I'll take a look at those now and give you some suggestions.
[13:26:46 CST(-0600)] <colinclark> michelled, I'll give you write access to that fork, too.
[13:27:01 CST(-0600)] <heidi_> sounds good
[13:27:08 CST(-0600)] <colinclark> heidi_: The next thing to look at is, I think, a couple of patches from you...
[13:27:29 CST(-0600)] <colinclark> let me just get all the numbers straight
[13:28:16 CST(-0600)] <colinclark> Okay, so FLUID-4029 and FLUID-3837 are dependent upon each other, right heidi_?
[13:28:44 CST(-0600)] <colinclark> michelled: The problem at the moment with FLUID-3837 is that we have a patch that hasn't been tracking the state of master, so it's out of date and won't apply correctly
[13:28:48 CST(-0600)] <heidi_> 3837 reqs 4029
[13:28:54 CST(-0600)] <colinclark> great, thanks
[13:29:18 CST(-0600)] <colinclark> So, I committed heidi_'s FLUID-3837-f patch on January 27
[13:29:21 CST(-0600)] <heidi_> colinclark i can look into recreating the clean up patch
[13:29:33 CST(-0600)] <colinclark> The latest patch, version -j, contains all of -f as well as some new changes
[13:29:59 CST(-0600)] <colinclark> heidi_: That would be great
[13:30:12 CST(-0600)] <heidi_> k
[13:30:31 CST(-0600)] <colinclark> you should be able to do some strategic diffing to get it sorted out
[13:30:48 CST(-0600)] <colinclark> michelled: FLUID-4039 and FLUID-3837 should go in together
[13:30:58 CST(-0600)] <colinclark> heidi_: Does that cover all your patches?
[13:31:35 CST(-0600)] <colinclark> sorry, ran out of batteries
[13:31:54 CST(-0600)] <colinclark> sorry if I missed your response, heidi_
[13:32:08 CST(-0600)] <heidi_> was waiting for ya - the scrolling table demo one
[13:32:12 CST(-0600)] <heidi_> finding jira..
[13:32:21 CST(-0600)] <heidi_> oh wait that's 4037, duh
[13:32:34 CST(-0600)] <heidi_> so yes, those 3
[13:32:47 CST(-0600)] <colinclark> Okay
[13:32:49 CST(-0600)] <colinclark> So, to summarize
[13:33:05 CST(-0600)] <colinclark> 1. I will review FLUID-4037 and provide feedback or push the changes
[13:33:23 CST(-0600)] <colinclark> 2. heidi_ will create a new version of FLUID-3837 based on the latest state of the project repo
[13:33:36 CST(-0600)] <colinclark> 3. michelled will commit FLUID-4029 and FLUID-3837 together
[13:33:45 CST(-0600)] <colinclark> Seem about right?
[13:34:16 CST(-0600)] <mlam> colinclark: maybe michelled could help me with the pull request for FLUID-3886 and FLUID-4053?
[13:34:46 CST(-0600)] <heidi_> sounds good cc
[13:34:46 CST(-0600)] <colinclark> mlam: +1
[13:35:02 CST(-0600)] <mlam> ok. the pull request is already in place. the patch is relatively small as well
[13:35:48 CST(-0600)] <michelled> mlam: is it a single pull request or are the JIRAs separate?
[13:35:55 CST(-0600)] <mlam> a single pull
[13:36:07 CST(-0600)] <mlam> the 2nd JIRA was a 2 character change
[13:36:10 CST(-0600)] <colinclark> michelled: FLUID-4053 is a little fix to get a failing test to pass
[13:36:26 CST(-0600)] <colinclark> definitely worth a close review, but I thought it was small enough to combine with the FLUD-3886 fix
[13:36:32 CST(-0600)] <colinclark> mlam: Is that it for your JIRAs?
[13:36:56 CST(-0600)] <mlam> I have a major that i'm working on. FLUID-3900. Trying to get it finished before thursday
[13:37:03 CST(-0600)] <colinclark> cool
[13:37:12 CST(-0600)] <colinclark> So, to summarize:
[13:37:32 CST(-0600)] <colinclark> 1. michelled will review and pull mlam's changes for FLUID-3886 and FLUID-4053
[13:37:38 CST(-0600)] <colinclark> 2. mlam will continue coding on FLUID-3900
[13:37:46 CST(-0600)] <colinclark> Is that about right?
[13:38:01 CST(-0600)] <michelled> yep
[13:38:05 CST(-0600)] <mlam> yes
[13:38:19 CST(-0600)] <colinclark> cool!
[13:38:23 CST(-0600)] <mlam> michelled: I can sit with you while you review if that makes things easier
[13:38:43 CST(-0600)] <colinclark> anastasiac: You brought up documentation for Model Transformation and Progressive Enhancement at standup today
[13:38:43 CST(-0600)] <michelled> mlam: I'll let you know
[13:38:52 CST(-0600)] <mlam> ok
[13:39:02 CST(-0600)] <anastasiac> colinclark, yes
[13:39:12 CST(-0600)] <colinclark> First question: what's the hurry?
[13:39:19 CST(-0600)] <colinclark> You seemed to suggest it was a big one
[13:40:16 CST(-0600)] <anastasiac> sorry if I sounded over-concerned. We want those docs completed for 1.3.1, which is expected to be next week. I just thought it would be better to mention it now rather than next Monday
[13:40:43 CST(-0600)] <colinclark> ok
[13:40:45 CST(-0600)] <colinclark> So, it's on my list
[13:40:47 CST(-0600)] <colinclark> I haven't forgotten about it
[13:41:22 CST(-0600)] <colinclark> I can't get to it until after the GPII architecture meeting, which is scheduled for Friday afternoon
[13:41:41 CST(-0600)] <colinclark> So let's schedule it as a big one for Monday
[13:42:06 CST(-0600)] <colinclark> I hate to have left it this long, but we've got a lot on our plates
[13:42:10 CST(-0600)] <anastasiac> colinclark, as I mentioned: I know you've got a lot on your plate. I'd be happy to convert misc. bullet points into english, if you'd rather just brain dump
[13:42:34 CST(-0600)] <anastasiac> I could also look at the code and learn in that way
[13:42:45 CST(-0600)] <anastasiac> but I'd bet you could brain dump quicker than that (wink)
[13:43:06 CST(-0600)] <colinclark> I'm not too worried about the writing itself, it's more just chiseling out enough time to get started
[13:46:26 CST(-0600)] <colinclark> heidi_: A couple quick questions about your FLUID-4037 patch
[13:46:32 CST(-0600)] <heidi_> yep
[13:46:37 CST(-0600)] <colinclark> First, have you tried the scrollable table in IE 7 and 8?
[13:46:44 CST(-0600)] <colinclark> Do the styles work nicely there?
[13:46:55 CST(-0600)] <heidi_> yes, but let me quickly look again
[13:47:29 CST(-0600)] <heidi_> the changes i pushed would only affect ie6
[13:48:09 CST(-0600)] <colinclark> right
[13:48:28 CST(-0600)] <colinclark> So I just thought it was worth checking with you that it was good in IE 7 + 8 without this behaviour
[13:48:47 CST(-0600)] <heidi_> it was before yep
[13:48:55 CST(-0600)] <heidi_> ill check now just to be sure
[13:51:06 CST(-0600)] <colinclark> cool, thanks
[13:51:08 CST(-0600)] <colinclark> just in case
[13:59:26 CST(-0600)] <heidi_> colinclark reinstalling ie8... i think it's checking every file on the computer for viruses? taking forevs
[13:59:37 CST(-0600)] <colinclark> gross
[13:59:42 CST(-0600)] <colinclark> I tend to have several VMs
[13:59:52 CST(-0600)] <colinclark> one for each version of IE
[13:59:58 CST(-0600)] <colinclark> they don't play very nice together
[14:00:07 CST(-0600)] <heidi_> yeah i had deleted it before to try install ie6 but learned yeah, impossible
[14:00:22 CST(-0600)] <heidi_> got an ie6 vm now
[14:00:46 CST(-0600)] <colinclark> cool
[14:15:03 CST(-0600)] <colinclark> heidi_: Have you ever used JSLint before?
[14:15:11 CST(-0600)] <heidi_> colinclark yes
[14:15:18 CST(-0600)] <colinclark> cool
[14:15:31 CST(-0600)] <colinclark> So, there are a few errors in your FLUID-4037 fix that would have been caught by JSLint
[14:15:39 CST(-0600)] <heidi_> my bad - what were they?
[14:15:42 CST(-0600)] <colinclark> Two key things:
[14:15:46 CST(-0600)] <colinclark> if ($.browser.msie && $.browser.version=="6.0") {
[14:15:56 CST(-0600)] <colinclark> You're using the "==" operator instead of "==="
[14:16:01 CST(-0600)] <heidi_> ah
[14:16:05 CST(-0600)] <colinclark> Are you familiar with the difference between the two in JavaScript?
[14:16:24 CST(-0600)] <heidi_> i think i knew it like last month, but remind me
[14:16:30 CST(-0600)] <colinclark> you're also missing a semicolon on line 162 of FluidView.js--something I do all the time, too
[14:16:41 CST(-0600)] <colinclark> So, in JavaScript, "==" is coercive
[14:16:48 CST(-0600)] <colinclark> meaning it will change the type of the things being compared
[14:16:58 CST(-0600)] <colinclark> and so it will give some pretty misleading answers
[14:17:12 CST(-0600)] <colinclark> it's a bug that they tried to fix in the language, but Microsoft refused to let them
[14:17:16 CST(-0600)] <colinclark> so, for example
[14:17:23 CST(-0600)] <colinclark> 1 == "1"
[14:17:28 CST(-0600)] <colinclark> will actually return true
[14:17:34 CST(-0600)] <colinclark> even though they're clearly totally different types of variables
[14:17:55 CST(-0600)] <colinclark> whereas 1 === "1" returns false
[14:18:19 CST(-0600)] <colinclark> So the simple rule of thumb is to never use ==
[14:18:25 CST(-0600)] <colinclark> JSLint will catch it for you
[14:18:31 CST(-0600)] <heidi_> okay cool
[14:18:59 CST(-0600)] <colinclark> There was a bunch of other linting in the file... I've cleaned it up and will push it to the branch (I've also updated to the latest from the project repo)
[14:19:10 CST(-0600)] <colinclark> Can you lint your changes once I've done that, heidi_?
[14:19:31 CST(-0600)] <heidi_> sure
[14:19:35 CST(-0600)] <colinclark> as for this question:
[14:19:36 CST(-0600)] <colinclark> that.scrollable.css("height", "") // `that.scrollable.removeAttr("style"); better?
[14:19:40 CST(-0600)] <colinclark> I think you've got it right
[14:19:48 CST(-0600)] <colinclark> you don't want to remove the whole style attribute
[14:19:50 CST(-0600)] <heidi_> yeah, incase there are other inlines
[14:19:56 CST(-0600)] <colinclark> you got it
[14:20:05 CST(-0600)] <colinclark> So, I'd say toss your comments and you're good to go
[14:20:16 CST(-0600)] <heidi_> what about the default max-height val?
[14:20:31 CST(-0600)] <heidi_> if it's not set in the css or the object init
[14:20:33 CST(-0600)] <colinclark> hmm
[14:20:34 CST(-0600)] <colinclark> good question
[14:23:09 CST(-0600)] <colinclark> Okay, so max-height is probably something we want to support a default for
[14:23:21 CST(-0600)] <colinclark> I guess there are two scenarios, right heidi_?
[14:23:27 CST(-0600)] <colinclark> 1. The user could have specified max-height in their CSS
[14:23:31 CST(-0600)] <colinclark> in which case, we grab it and use it
[14:23:58 CST(-0600)] <colinclark> if not, we should allow users to set a default
[14:23:58 CST(-0600)] <heidi_> yep
[14:24:13 CST(-0600)] <heidi_> right now a default is set in fss-layout.css
[14:24:17 CST(-0600)] <heidi_> but not sure that's good enough
[14:24:32 CST(-0600)] <colinclark> how come?
[14:24:45 CST(-0600)] <colinclark> i think you're probably right, I just want to understand your reasoning
[14:24:54 CST(-0600)] <heidi_> maybe they're not using fss
[14:25:08 CST(-0600)] <heidi_> just the scrollTo stuff
[14:25:20 CST(-0600)] <heidi_> hm, that doesn't make total sense
[14:25:34 CST(-0600)] <colinclark> So, here's an interesting question for you...
[14:26:33 CST(-0600)] <colinclark> what good is the css option we current have, now that you've made this change?
[14:26:41 CST(-0600)] <colinclark> Previously, we were letting people supply a height with it
[14:26:55 CST(-0600)] <colinclark> but now we are overriding it with something dynamic
[14:27:00 CST(-0600)] <colinclark> Although I guess this is only for IE6
[14:27:02 CST(-0600)] <heidi_> it should've been a max-height
[14:27:10 CST(-0600)] <heidi_> we're not over-riding it
[14:27:18 CST(-0600)] <colinclark> I guess the good news is that it can be anything (smile)
[14:27:29 CST(-0600)] <colinclark> Okay, well, this needs a bit more thought
[14:27:37 CST(-0600)] <colinclark> Can you spend a bit of time thinking through it, heidi_?
[14:27:39 CST(-0600)] <heidi_> you wouldn't want to set a height for uploader because then it wouldn't grow
[14:28:01 CST(-0600)] <colinclark> michelled might have some thoughts on it
[14:28:05 CST(-0600)] <colinclark> in the meantime, I'll push up my changes
[14:28:15 CST(-0600)] <heidi_> think through what exactly?
[14:28:16 CST(-0600)] <colinclark> and then if you could lint and push those changes, that'd be great
[14:28:27 CST(-0600)] <colinclark> How you are going to handle options for max-height
[14:29:11 CST(-0600)] <heidi_> if fss-layout is enough of a default
[14:29:58 CST(-0600)] <colinclark> I'm not sure that it is
[14:30:16 CST(-0600)] <colinclark> based on the conversation we had last week, thinking through the different cases for how someone might like to set these sorts of things
[14:30:44 CST(-0600)] <colinclark> your idea, if I remember correctly, was that it made sense to support these things either from code or from overriding the CSS
[14:31:24 CST(-0600)] <heidi_> it's just for the issue where neither are given.
[14:32:32 CST(-0600)] <heidi_> which could happen if you're scrollable isn't our scrolling table
[14:32:36 CST(-0600)] <heidi_> *your
[14:33:17 CST(-0600)] <colinclark> I'm really late
[14:33:33 CST(-0600)] <colinclark> Think about it, heidi_. If you're stuck, I'm sure michelled will have some time to think through it with you.
[14:33:43 CST(-0600)] <heidi_> thanks for the help colin
[14:33:48 CST(-0600)] <colinclark> Sorry I can't stay to chat more about it--it's interesting stuff
[14:51:49 CST(-0600)] <colinclark> Okay heidi_, I'm on the way out now, but I've updated the infusion-FLUID-4037 fork to be in sync with the project repository
[14:52:01 CST(-0600)] <colinclark> so you'll need to pull down the changes into your local clone
[14:52:09 CST(-0600)] <colinclark> both the master and FLUID-4037 branches are up to date
[14:52:16 CST(-0600)] <heidi_> colinclark okay, and ill lint and update my two files and push it back up
[14:52:20 CST(-0600)] <colinclark> great
[14:52:24 CST(-0600)] <colinclark> see you tomorrow
[14:52:29 CST(-0600)] <heidi_> seeya
[14:53:17 CST(-0600)] <golam> michelled: here is the patch for layout reorderer. The patch has passed both FF3.6.13 and IE8. http://issues.fluidproject.org/secure/attachment/11634/FLUID-3946.v5.patch
[14:53:49 CST(-0600)] <michelled> thx - I'll take a look at it tomorrow
[14:54:17 CST(-0600)] <golam> michelled: ok thanks