fluid-work IRC Logs-2011-02-16

Owned by Fluid IRC Log Bot
Last updated: Feb 16, 2011Version comment
24 min read

[08:21:19 CST(-0600)] <kasper> Justin_o, sorry for not getting back to you yesterday
[08:23:02 CST(-0600)] <kasper> does tomorrow suit you better too (like colin)? If so, meeting then will work for me.. If not, and if it still works for you, we can talk today whenever suits you
[08:27:46 CST(-0600)] <Justin_o> kasper: i should be able to do tomorrow
[08:27:59 CST(-0600)] <kasper> justin_o: ok, lets do it then instead
[08:28:25 CST(-0600)] <kasper> Justin_o: if you figure out a time with colin, and then just let me know.. would that work
[08:29:54 CST(-0600)] <Justin_o> kasper okay thanks.. i'm probably going to be running around a bit today for the testing and other release stuff.. please ping me again if you don't hear back from either of us
[08:31:16 CST(-0600)] <kasper> coolio, will do! thanks
[09:21:59 CST(-0600)] <colinclark> So heidi, can I help with the process of removing the scrollable table stuff?
[09:22:06 CST(-0600)] <colinclark> You got part way through it last night, I noticed
[09:22:14 CST(-0600)] <heidi> colinclark yep
[09:22:25 CST(-0600)] <colinclark> I looked at your branch and decided to wait on it until you were around so it would be easy to ask you questions
[09:22:25 CST(-0600)] <heidi> need to get scrollTo working again
[09:22:40 CST(-0600)] <colinclark> What is happening currently?
[09:23:21 CST(-0600)] <heidi> colinclark i tried to replace the fluid.scrollingTable with fluid.scrollable but wasn't successful (it's not working) ... in filequeueview.js
[09:23:29 CST(-0600)] <colinclark> What's it doing?
[09:23:37 CST(-0600)] <colinclark> Errors? Not scrolling? Something else?
[09:23:47 CST(-0600)] <heidi> colinclark just not jumping to the right place (when you upload a file, or add a file)
[09:23:59 CST(-0600)] <colinclark> Okay, no errors, but no scrolling
[09:24:02 CST(-0600)] <colinclark> should be easy enough to fix
[09:24:10 CST(-0600)] <colinclark> So your changes to the markup and CSS and the like...
[09:24:19 CST(-0600)] <colinclark> you did all these by hand, right?
[09:24:31 CST(-0600)] <colinclark> As opposed to checking out to a previous revision of those files?
[09:24:47 CST(-0600)] <heidi> colinclark yes by hand
[09:24:53 CST(-0600)] <colinclark> That's good
[09:25:00 CST(-0600)] <heidi> it woulda been too crazy to go back
[09:25:21 CST(-0600)] <colinclark> So you feel like the markup and CSS is as clean as it was before, with the exception of having to add this extra table, right?
[09:25:31 CST(-0600)] <heidi> colinclark yep
[09:25:35 CST(-0600)] <colinclark> awesome
[09:25:42 CST(-0600)] <colinclark> okay, so this should be pretty straightforward
[09:25:45 CST(-0600)] <colinclark> I'll have a look now
[09:25:54 CST(-0600)] <heidi> cool, can you tell me what i did wrong?
[09:26:09 CST(-0600)] <colinclark> sure!
[09:26:26 CST(-0600)] <colinclark> michelled: While I'm doing this, do you have time to just scan through my FLUID-3900 branch and have a look at the changes?
[09:26:38 CST(-0600)] <colinclark> I can walk you through them as soon as I'm done with heidi's code
[09:27:05 CST(-0600)] <michelled> colinclark: I'll take a look in a moment
[09:27:25 CST(-0600)] <colinclark> thanks!
[09:36:03 CST(-0600)] <colinclark> So heidi, using the scrollTo plugin, what kind of markup do we need to have set up to scroll our queue table?
[09:36:41 CST(-0600)] <colinclark> We've still got two divs wrapping the table--those are required?
[09:36:51 CST(-0600)] <heidi> we do?
[09:36:59 CST(-0600)] <heidi> looking...
[09:37:01 CST(-0600)] <justin_o_> colinclark: did you have a chance to fix up the sakai-master repo
[09:37:04 CST(-0600)] <justin_o_> ?
[09:37:08 CST(-0600)] <colinclark> justin_o_: no
[09:37:24 CST(-0600)] <heidi> colinclark i don't see the wrapping divs in uploader
[09:37:29 CST(-0600)] <colinclark> justin_o_: Do you have time to go ahead and do it? I'm sorry, I didn't get home last night until about 11 pm
[09:37:52 CST(-0600)] <colinclark> Lines 57 and 58 in Uploader.html, heidi?
[09:38:42 CST(-0600)] <heidi> oh strange...hang on a sec..
[09:38:49 CST(-0600)] <justin_o_> colinclark: i don't mind to fix it up
[09:38:54 CST(-0600)] <heidi> colinclark yes yes, we need thos
[09:39:04 CST(-0600)] <colinclark> justin_o_: thanks.
[09:39:08 CST(-0600)] <heidi> it's like the old way with scroller and a scroller-inner
[09:39:14 CST(-0600)] <colinclark> heidi: ok
[09:39:22 CST(-0600)] <colinclark> and what do we think will happen with this setup in IE6?
[09:39:32 CST(-0600)] <heidi> they are not fss-y
[09:39:47 CST(-0600)] <colinclark> Are we still going to need to manually recalculate height every time a file is added or removed from the queue?
[09:39:59 CST(-0600)] <heidi> we are still setting the height so that fix should still be working, in refreshview
[09:40:11 CST(-0600)] <colinclark> heidi: Right, I'm asking if it's still needed
[09:40:32 CST(-0600)] <heidi> colinclark yes, max-height doesn't work in ie6
[09:41:40 CST(-0600)] <colinclark> And there's no way to do this without max-height?
[09:41:58 CST(-0600)] <colinclark> I'm just trying to figure out, given our much simpler styling in this case, whether there's a simpler way to do all this
[09:42:14 CST(-0600)] <heidi> colinclark setting a height value = static height. we want our scrollable area to grow when files are added
[09:42:52 CST(-0600)] <colinclark> i understand that
[09:42:54 CST(-0600)] <heidi> when we reach that max-height, for ie6 we can then set the static height and the area will grow
[09:43:06 CST(-0600)] <heidi> with a scroller
[09:43:43 CST(-0600)] <heidi> setting a 'height' value on the scrollable is the fix, not sure how to simplify that
[09:44:27 CST(-0600)] <colinclark> ok
[09:48:48 CST(-0600)] <colinclark> So heidi, I think the reason you weren't seeing it scroll is the exact same reason why it wasn't scrolling before
[09:49:17 CST(-0600)] <colinclark> You were setting the scrollable element as the queue's container, not the element wrapping it
[09:49:45 CST(-0600)] <colinclark> Looks like our little scrollable table utility is indeed useful
[09:49:47 CST(-0600)] <heidi> ah, what is the queue's container then?
[09:49:59 CST(-0600)] <jhung> justin_o: who was working on Rich Text inline Edit?
[09:50:21 CST(-0600)] <colinclark> Here's what I'm going to do, heidi:
[09:50:37 CST(-0600)] <colinclark> 1. Roll back FluidView.js to before you removed scrollableTable()
[09:50:48 CST(-0600)] <colinclark> 2. Move both scrollable and scrollableTable() into Uploader
[09:54:13 CST(-0600)] <heidi> colinclark okay, so scrollableTable will add those fl-uploader-scrollable divs
[09:54:24 CST(-0600)] <colinclark> yep
[09:54:29 CST(-0600)] <heidi> gotcha
[09:56:28 CST(-0600)] <harriswong> colinclark: for src/webapp/components/uploader/js/HTML5UploaderSupport.js, i found that my commit (7fff720bdb140048e099f6996b6023cb26d2cbb2) had somehow reverted some(or all)l your changes at 55f86bb406038a481ebc30eb57e803f5c5c87c34
[09:56:37 CST(-0600)] <colinclark> eek
[09:57:07 CST(-0600)] <harriswong> colinclark: I have no idea how that happened, actually i am not even sure if it reverted it. they just don't look right.
[09:57:16 CST(-0600)] <michelled> Justin_o, colinclark: for a point release, don't you think we should update the fluid_version in the build.properties file?
[09:57:35 CST(-0600)] <colinclark> michelled: yes, absolutely
[09:57:54 CST(-0600)] <michelled> anastasiac: I meant to include you on that question ^
[09:57:59 CST(-0600)] <harriswong> colinclark: I am thinking maybe i should just revert my local to infusion head, and add my changes back manually.
[09:58:16 CST(-0600)] <michelled> Justin_o: are we planning to update the readme? I think we should
[09:58:25 CST(-0600)] <colinclark> harriswong: +1
[09:58:30 CST(-0600)] <colinclark> michelled: +1
[09:58:45 CST(-0600)] <colinclark> It needs to be updated for the fixes in Uploader, at very least, michelled
[09:59:05 CST(-0600)] <anastasiac> michelled, yes, we should - I missed that, I'm sorry. I'll push that now.
[09:59:37 CST(-0600)] <Justin_o> michelled: anastasiac is looking into that i believe
[09:59:57 CST(-0600)] <michelled> ok, thanks. anastasiac will you also be updating the uploader readme?
[10:00:02 CST(-0600)] <colinclark> michelled: I'll do that
[10:00:45 CST(-0600)] <michelled> anastasiac: I think the comment at the top of Fluid.js should also be change to say 1.3.1
[10:00:53 CST(-0600)] <anastasiac> k
[10:01:05 CST(-0600)] <colinclark> The PERMACOMMENT, as Justin_o calls it
[10:07:34 CST(-0600)] <anastasiac> michelled, I've pushed those version changes to my branch in github
[10:10:57 CST(-0600)] <colinclark> heidi: One thing I noticed you missed in the cleanup--unit tests for the scrollable table stuff
[10:11:16 CST(-0600)] <colinclark> I'll move them over along with the other change
[10:12:00 CST(-0600)] <heidi> colinclark thanks - i got a little fuzzy around 8pm
[10:12:08 CST(-0600)] <colinclark> understandable
[10:12:14 CST(-0600)] <colinclark> it gets even fuzzier at 2 am, I'll tell ya (tongue)
[10:12:21 CST(-0600)] <heidi> haha, yikes
[10:12:28 CST(-0600)] <colinclark> My boat club meeting went super late
[10:12:43 CST(-0600)] <colinclark> because people were arguing over voting on a 20th anniversary celebration lunch!
[10:12:43 CST(-0600)] <heidi> nice (smile)
[10:12:46 CST(-0600)] <colinclark> it was insane
[10:12:50 CST(-0600)] <heidi> hahaa...ah
[10:13:01 CST(-0600)] <colinclark> a bunch of retirees vehemently arguing over "catered" vs. "potluck"
[10:13:45 CST(-0600)] <heidi> haha... good times
[10:13:54 CST(-0600)] <Justin_o> colinclark: what did you vote for?
[10:13:55 CST(-0600)] <heidi> who won?
[10:14:02 CST(-0600)] <colinclark> I tried to abstain
[10:14:15 CST(-0600)] <harriswong> Justin_o: how exactly do you checkout just one file from upstream..thanks
[10:14:16 CST(-0600)] <colinclark> In the end, the chaos pushed me to vote for a potluck
[10:14:37 CST(-0600)] <colinclark> And the Forces of Potluck won out int he end
[10:14:47 CST(-0600)] <heidi> potlucks cheaper and more fun
[10:14:48 CST(-0600)] <colinclark> Watch out, Tea Party, here comes the Potluck Party
[10:14:52 CST(-0600)] <heidi> haha
[10:15:34 CST(-0600)] <Justin_o> harriswong: just double checked this with michelled
[10:15:49 CST(-0600)] <Justin_o> so it's git checkout <commit hash> <file>
[10:18:27 CST(-0600)] <harriswong> Justin_o: getting an error on pathspec did not match any file(s) known to git. Is it because I appended upstream/master to it?
[10:19:47 CST(-0600)] <Justin_o> just add the local path to the file
[10:19:53 CST(-0600)] <Justin_o> don't worry about the upstream branch
[10:29:28 CST(-0600)] <Justin_o> michelled: in git if you do git commit --author you can specify an author
[10:29:57 CST(-0600)] <Justin_o> and it should be in the format "Real Name <email@example.com>"
[10:30:12 CST(-0600)] <michelled> good to know Justin_o
[10:31:04 CST(-0600)] <jessm> is anyone able to hit the standup url?
[10:31:41 CST(-0600)] <jessm> oh weird, it's working now
[10:32:42 CST(-0600)] <jhung> jessm: are you able to connect to Breeze?
[10:32:49 CST(-0600)] <jessm> i just was, yes
[10:32:57 CST(-0600)] <jessm> no one else is in there
[10:32:58 CST(-0600)] <jhung> We're stuck here.
[10:33:11 CST(-0600)] <jessm> strange
[10:33:24 CST(-0600)] <jessm> i kept hitting the url and it let me in
[10:34:10 CST(-0600)] <jessm> should we do standup in here everyone?
[10:36:22 CST(-0600)] <michelled> jessm, colinclark: we're unable to reach yorku's connect room.
[10:36:28 CST(-0600)] <jessm> ok
[10:36:40 CST(-0600)] <jessm> michelled: can you tell everyone we can do standup in here?
[10:36:50 CST(-0600)] <michelled> sure.
[10:37:48 CST(-0600)] <jessm> michelled_: yeah, the breeze room just kicked me out
[10:37:59 CST(-0600)] <heidi> shall we go down the list on the side ?
[10:38:38 CST(-0600)] <jameswy> This is pseudo-asynchronous, so I think we can all just spit it out when we're ready to.
[10:39:07 CST(-0600)] <anastasiac> I'm working on some of the release-related JIRAs: updating version numbers, and looking at the readme. I'll be pinging people to double-check the 'what's new' info
[10:39:18 CST(-0600)] <cindyli> working on achecker guideline-view report
[10:39:40 CST(-0600)] <Justin_o> It's testing day, if you have time to help out with testing, please do. We still have a bit more work for uploader including getting the daily build working. But other than that it's all open. Please see http://wiki.fluidproject.org/display/fluid/Release+Testing+Tasks and feel free to ask me any questions you might have
[10:39:56 CST(-0600)] <jessm> i'm doing planning for CFI and have been doing some planning with Iris this a.m. I might have some time to help with testing this p.m.
[10:40:06 CST(-0600)] <anastasiac> i'll do some testing today, too
[10:40:06 CST(-0600)] <heidi> yesterday i worked on a couple uploader/scroller bugs: one is a blocker that we don't have enough time to fix... it's more involved. so colin and i are reverting some of our scroller-table functionality, and saving the rest for 1.4. today i'm testing.
[10:40:07 CST(-0600)] <Justin_o> jessm: thanks
[10:40:33 CST(-0600)] <clown> 1. Adpating code to find new location of preferences schemas: Found out where the schemas are currently located, and am now figuring out how to deal with that. Involves a makefile directive.
[10:40:34 CST(-0600)] <clown> 2. Reading over responses to the HTML5 editor's objections to ARIA, to see if I can add anything. Current responses are quite good. I may not have much to add. (And reading over the objections is sometimes mind boggling...).
[10:41:19 CST(-0600)] <jameswy> My update: Primarily working UI options design (and struggling with colour schemes, among other things!). Also had a chat with jhung and jessm about the future of demos and their presentation. Will be working with jhung later this week or next on an overall information architecture of all our content to better fit the demos. Would love it if you could join us when we do, anastasiac.
[10:41:44 CST(-0600)] <yura_> i m started looking into the upload part of media record, yesterday finished integrating with Chris (Caret) media in cspace and also fixed the displaying of current user in cspace
[10:41:45 CST(-0600)] <harriswong> #FLUID-3878 still, reverting HTML5UploadSupport.js to head, and merging my commit in manually. Ran my test on Eric's code for 4045, seems fine; ran all combination then browser crashed.
[10:41:51 CST(-0600)] <anastasiac> jameswy, definitely
[10:42:01 CST(-0600)] <colinclark> For me, I'm finish up some tweaks to heidi's FLUID-4061 blocker for Uploader, then I'll push. I'll run michelled_ quickly through my changes for FLUID-3900, and then I'll push that. And then testing is full-on. (smile)
[10:42:22 CST(-0600)] <jhung1> had a chat w jessm and jameswy about how to structure work for the "demo portal". I started to edit the original redesign notes for the demo portal and update it to be more component-centric (instead of demo centric). This morning I am working on release testing - currently Rich Text Editor for Win7.
[10:42:41 CST(-0600)] <anastasiac> colinclark, Bosmon2, just a reminder that there are some 1.3.1 documentation tasks on your plates
[10:42:47 CST(-0600)] <michelled_> I just pushed anastasiac's changes for FLUID-4062. I'll be looking at colinclark's branch now for FLUID-3900. My new favourite git command is: git reset --hard <commit hash>
[10:42:50 CST(-0600)] <colinclark> lol
[10:42:54 CST(-0600)] <Justin_o> colinclark: great... i think we'll have the daily build for the image-gallery up around noon
[10:42:56 CST(-0600)] <golam> I am still working on converting Inline edit manual testcases to automated testcases. Had a chat with Michelle yesterday and she suggested few other testcases that I should write. I am working on them right now. I am planning to complete them today. Also we have closed JIRA 3946 to fix tabbing issues.
[10:43:05 CST(-0600)] <colinclark> anastasiac must think my memory is really short (tongue)
[10:43:17 CST(-0600)] <anastasiac> (smile)
[10:43:55 CST(-0600)] <colinclark> So heidi, I'm wondering about naming for these scrollable styles in Uploader
[10:44:09 CST(-0600)] <heidi> colinclark ya?
[10:44:09 CST(-0600)] <colinclark> I've just realized that they flipped
[10:44:17 CST(-0600)] <colinclark> The inner element is no longer the scroller
[10:44:19 CST(-0600)] <colinclark> despite being named so
[10:44:26 CST(-0600)] <heidi> you're right
[10:44:27 CST(-0600)] <colinclark> It's the -container that is actually the scroller
[10:45:38 CST(-0600)] <heidi> colinclark -scroller doesn't really need to be there. let me play for a sec
[10:46:52 CST(-0600)] <heidi> i'm trying to recall what the significance of -inner was before
[10:47:38 CST(-0600)] <heidi> colinclark are you finding sometimes the uploading x of y is incorrect in the status? sometimes ill upload the first file and it says "uploading 2 of"
[10:48:20 CST(-0600)] <colinclark> heidi: I fixed that last night
[10:48:26 CST(-0600)] <heidi> ah cool
[10:48:29 CST(-0600)] <colinclark> It was a regression in a fix from mlam last week
[10:48:32 CST(-0600)] <colinclark> It'll be in momentarily
[10:48:44 CST(-0600)] <colinclark> glad you noticed it too (smile)
[10:50:08 CST(-0600)] <heidi> colinclark i'm guessing the -inner div is an IE necessity but just testing it out...
[10:50:37 CST(-0600)] <Justin_o> golam, harriswong: when you guys are at a place where you can set your current work aside, it might be good to switch to testing the 1.3.1 release
[10:51:13 CST(-0600)] <golam> Justin_o: sounds good
[10:52:54 CST(-0600)] <Justin_o> golam: thanks
[10:53:15 CST(-0600)] <harriswong> Justin_o: k.
[10:53:19 CST(-0600)] <colinclark> heidi: Here are my tweaks to your FLUID-4061 work: https://github.com/colinbdclark/infusion/tree/FLUID-4061
[10:53:27 CST(-0600)] <colinclark> Feel free to have a look through them and see what I've done
[10:53:50 CST(-0600)] <heidi> colinclark will do
[10:53:53 CST(-0600)] <colinclark> The only thing we need to figure out is that inner wrapper (do we need it? what should we call it?) and then I'll go ahead and push the changes to the project repo
[10:54:01 CST(-0600)] <colinclark> michelled_: While we're waiting, can I walk you through FLUID-3900?
[10:54:15 CST(-0600)] <colinclark> And then I'll try to hop into the office for my 1 pm meeting
[10:54:15 CST(-0600)] <heidi> i think w can ditch it but i want to make sure... it was there before for a reason, surely
[10:54:20 CST(-0600)] <colinclark> yeah
[10:54:45 CST(-0600)] <colinclark> heidi: Can you give my version of FLUID-4061 a decent cross-browser run-through while you're looking at it?
[10:55:00 CST(-0600)] <heidi> colinclark yes.
[10:55:05 CST(-0600)] <colinclark> thanks so much
[10:55:14 CST(-0600)] <colinclark> i really appreciate it
[10:55:59 CST(-0600)] <michelled_> colinclark: ya, let's do that
[10:56:15 CST(-0600)] <colinclark> skype, or here in the channel, michelled_?
[10:56:28 CST(-0600)] <michelled_> skype might be faster - let me start it up
[10:56:37 CST(-0600)] <colinclark> k
[10:58:16 CST(-0600)] <colinclark> michelled_: So this is what we're looking at: https://github.com/colinbdclark/infusion/commits/FLUID-3900
[10:59:58 CST(-0600)] <colinclark> michelled_: This was my first commit: https://github.com/colinbdclark/infusion/commit/71031f7aca3bae0cc56be9cbeea3754838458eba
[11:08:59 CST(-0600)] <heidi> colinclark what you did looks good/makes sense.
[11:16:14 CST(-0600)] <colinclark> ok
[11:16:19 CST(-0600)] <michelled_> Justin_o: colinclark just took me through his commits for 3900 and it's good to go. He's going to update a comment and then push to the infusion project repo
[11:16:20 CST(-0600)] <colinclark> any insights into the wrappers, heidi?
[11:16:37 CST(-0600)] <heidi> colinclark i think it's fine like you have it - i believe inner is needed for scrollTo to work
[11:16:44 CST(-0600)] <colinclark> ok
[11:16:49 CST(-0600)] <heidi> so ill test it
[11:16:51 CST(-0600)] <colinclark> So will we rename the classes?
[11:16:58 CST(-0600)] <colinclark> fl-scrollable-scroller
[11:17:05 CST(-0600)] <colinclark> and fl-scrollable-innerwrapper
[11:17:07 CST(-0600)] <colinclark> or something like that?
[11:17:09 CST(-0600)] <heidi> yeah let's do that
[11:17:14 CST(-0600)] <heidi> -inner is good
[11:17:15 CST(-0600)] <colinclark> maybe just fl-scrollable-wrapper
[11:17:17 CST(-0600)] <colinclark> inner
[11:17:19 CST(-0600)] <colinclark> okay
[11:17:27 CST(-0600)] <colinclark> i'll do that now and push again
[11:17:29 CST(-0600)] <colinclark> then you can test
[11:17:40 CST(-0600)] <colinclark> Justin_o: So heidi is going to do some quick tests of our FLUID-4061 fix
[11:17:59 CST(-0600)] <colinclark> I'll update the comment for FLUID-3900 and then push
[11:18:01 CST(-0600)] <heidi> colinclark did you want to rename first?
[11:18:06 CST(-0600)] <colinclark> and we'll be good to go
[11:18:09 CST(-0600)] <colinclark> heidi: yep, that's what i mean
[11:18:12 CST(-0600)] <colinclark> doing that now
[11:18:25 CST(-0600)] <heidi> cool, then i'll update my branch and test
[11:18:27 CST(-0600)] <michelled_> Justin_o: there are a couple of little fixes that will go in with commit https://github.com/colinbdclark/infusion/commit/71031f7aca3bae0cc56be9cbeea3754838458eba - colinclark has commented appropriately on github.
[11:19:05 CST(-0600)] <colinclark> In one case, the "little fix" would have undoubtedly been a blocker uncovered in QA, Justin_o (wink)
[11:19:19 CST(-0600)] <Justin_o> colinclark: thanks for the proactive fix
[11:19:27 CST(-0600)] <colinclark> (smile)
[11:20:22 CST(-0600)] <harriswong> colinclark: I have this error uploading 10 files on the buildsite: http://build.fluidproject.org/infusion/demos/uploader/html/uploader.html. uncaught exception: [Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIDOMFile.size]" nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)" location: "JS frame :: http://build.fluidproject.org/infusion/components/uploader/js/HTML5UploaderSupport.js :: anonymous :: line 1"
[11:21:20 CST(-0600)] <colinclark> that's interesting
[11:21:32 CST(-0600)] <colinclark> let's hold off on worrying about it until we get the two other Uploader fixes in
[11:26:22 CST(-0600)] <colinclark> ack, i think i just flipped the network graph again
[11:26:27 CST(-0600)] <colinclark> git sucks (tongue)
[11:30:36 CST(-0600)] <harriswong> colinclark, justin_o: should i hold off for 3878? and 4045?
[11:31:56 CST(-0600)] <harriswong> colinclark, justin_o: for 3878. if there are changes for uploader, i guess that means i will have to merge those changes into my branch again before i push it to github. And since it's not going to be included into 1.3.1, should I just push this thread aside?
[11:33:03 CST(-0600)] <colinclark> heidi: I've updated my FLUID-4061 with the new class names
[11:33:06 CST(-0600)] <colinclark> it's all yours
[11:33:11 CST(-0600)] <heidi> colinclark thanks buddy
[11:35:30 CST(-0600)] <Justin_o> harriswong: those will not make it into 1.3.1
[11:35:37 CST(-0600)] <Justin_o> so you can hold off till post release
[11:36:14 CST(-0600)] <harriswong> Justin_o: k then.
[13:02:31 CST(-0600)] <colinclark> jameswy: I just heard from Monica Contreras that there is a tour coming by at about 4 pm today
[13:02:35 CST(-0600)] <colinclark> I don't know who or for how long
[13:02:48 CST(-0600)] <colinclark> Can you be ready to talk about interesting Fluid things if the need arises?
[13:02:59 CST(-0600)] <colinclark> I think Jan will probably greet them and everything else
[13:03:07 CST(-0600)] <jameswy> colinclark: Yep, sure thing.
[13:03:13 CST(-0600)] <colinclark> thanks, sorry about that
[13:03:30 CST(-0600)] <jameswy> np.
[13:27:30 CST(-0600)] <Justin_o> fluid-everyone: dev meeting today?
[13:27:39 CST(-0600)] <Justin_o> any topics that you want to cover?
[13:27:42 CST(-0600)] <colinclark> yay dev meeting
[13:27:45 CST(-0600)] <colinclark> I'd like to ask a Git question
[13:27:49 CST(-0600)] <colinclark> and chat about 1.3.1
[13:28:08 CST(-0600)] <Justin_o> okay...
[13:28:13 CST(-0600)] <Justin_o> who do we have remote today?
[13:28:14 CST(-0600)] <michelled> I wouldn't mind doing the meeting in the channel unless people really want in person
[13:28:28 CST(-0600)] <michelled> in person + skype that is
[13:28:31 CST(-0600)] <Justin_o> michelled: either way is fine by me
[13:29:29 CST(-0600)] <michelled> I changed my mind. it's probably easier to talk about things in person - that way I can use my hands in my oh so useful way (smile)
[13:29:33 CST(-0600)] <michelled> brb
[13:31:51 CST(-0600)] <michelled_> fluid-everyone: is there anyone besides colinclark who wants to be skyped in?
[13:31:59 CST(-0600)] <michelled_> Justin_o is going to skype you in colinclark
[13:32:28 CST(-0600)] <michelled_> anastasiac, Bosmon2, golam: dev meeting is starting (smile)
[13:35:23 CST(-0600)] <justin_o_> colinclark: i'm trying to skype you in for the dev meeting
[14:40:54 CST(-0600)] <colinclark> Hey cindyli: Do you want to have that little Uploader test server you wrote in your own Github repo, I shall I?
[14:40:57 CST(-0600)] <colinclark> I'm fine either way
[14:41:18 CST(-0600)] <colinclark> Bosmon2: You there?
[14:41:40 CST(-0600)] <cindyli> colinclark: sure. anything i can help?
[14:42:02 CST(-0600)] <cindyli> colinclark: i see, into my own github. alrite. will do it
[14:42:06 CST(-0600)] <Bosmon2> Hi, I am here
[14:42:07 CST(-0600)] <colinclark> okay
[14:42:17 CST(-0600)] <colinclark> so here's that code, cindyli: https://github.com/fluid-project/misc/tree/uploader
[14:42:26 CST(-0600)] <colinclark> Justin_o might have advice on the best way to split it off
[14:42:39 CST(-0600)] <cindyli> colinclark: ok thx
[14:42:42 CST(-0600)] <colinclark> Bosmon2: I'm just looking at Justin_o's email about the misc repo
[14:42:50 CST(-0600)] <colinclark> Couple of things
[14:43:01 CST(-0600)] <colinclark> "extremal pager"
[14:43:06 CST(-0600)] <colinclark> Do you want it?
[14:43:16 CST(-0600)] <justin_o_> colinclark, anastasiac: i think you guys forgot to update the pom file for image gallery when you were doing the version number change
[14:43:25 CST(-0600)] <colinclark> Also, your "oh lord, how long" tests (smile)
[14:43:39 CST(-0600)] <colinclark> Do you want them, or should I take them, Bosmon2?
[14:43:49 CST(-0600)] <colinclark> justin_o_: I didn't do a version number change
[14:43:51 CST(-0600)] <colinclark> was that this morning?
[14:43:55 CST(-0600)] <anastasiac> justin_o, yes, I forgot that one
[14:43:59 CST(-0600)] <anastasiac> I'll do that now
[14:44:02 CST(-0600)] <colinclark> ah, okay
[14:44:06 CST(-0600)] <colinclark> thanks anastasiac
[14:44:16 CST(-0600)] <Bosmon2> Well, I should take these
[14:44:23 CST(-0600)] <Bosmon2> Sorry I didn't do anything about misc repo yet
[14:44:24 CST(-0600)] <colinclark> okay, great
[14:44:28 CST(-0600)] <colinclark> what about the batched pager?
[14:44:33 CST(-0600)] <Bosmon2> Although I wish it were possible to have a kind of "scratchpad"
[14:44:49 CST(-0600)] <colinclark> I think we need to create a wiki page with links to these sorts of things
[14:44:49 CST(-0600)] <Bosmon2> I mean... I want these... but I'm not sure I want them cluttering up my personal list of visible repos
[14:45:29 CST(-0600)] <colinclark> I'm not sure what other solutions we have
[14:45:33 CST(-0600)] <colinclark> can you think of anything?
[14:45:56 CST(-0600)] <anastasiac> Justin_o_, that's the "image-gallery2" project in github, right?
[14:46:00 CST(-0600)] <justin_o_> Bosmon2, colinclark: I'm not sure we want them in our fluid-project repo at this time...
[14:46:04 CST(-0600)] <justin_o_> anastasiac: yes that is correct
[14:46:12 CST(-0600)] <colinclark> justin_o_: I agree with you on that one
[14:46:21 CST(-0600)] <colinclark> justin_o_: Do you know where Neeti's phonegap stuff ended up?
[14:47:03 CST(-0600)] <justin_o_> colinclark: hmm... if it's not in misc, them we may have not brought it over
[14:47:24 CST(-0600)] <colinclark> justin_o_: Did clown weigh in on what he wants to do with his tabindex and dom mutation test pages?
[14:47:37 CST(-0600)] <colinclark> justin_o_: Okay, that's probably one we should create a repository for
[14:47:50 CST(-0600)] <justin_o_> colinclark: i did talk to him about moving it over a week or so ago, not sure if he has or not
[14:47:58 CST(-0600)] <colinclark> I'm not quite sure where to put it, since I'm not sure it should clutter up the project repo either
[14:48:14 CST(-0600)] <colinclark> I guess we should call it engage-2dbarcode-experiments or something to that effect?
[14:48:18 CST(-0600)] <colinclark> Bosmon2: Does that seem about right? ^
[14:48:34 CST(-0600)] <Bosmon2> For the name, yes
[14:48:53 CST(-0600)] <colinclark> justin_o_: After the 1.3.1 release, can you take a look at doing that migration?
[14:48:59 CST(-0600)] <Bosmon2> Do we have any other options, than attaching them as a repo to fluid-project, and attaching them as a repo to us as individuals?
[14:49:15 CST(-0600)] <colinclark> Not that I know of Bosmon2. Do you know of anything, justin_o_?
[14:51:49 CST(-0600)] <colinclark> jhung: I really like your bug finding summaries on the mailing list
[14:51:59 CST(-0600)] <colinclark> Really helpful as a way of seeing how testing is coming along
[14:53:03 CST(-0600)] <justin_o_> colinclark: not that i can think of.. we could just leave it in svn too if no one is going to do any work on it
[14:53:11 CST(-0600)] <justin_o_> it will still be preserved there in history
[14:53:32 CST(-0600)] <justin_o_> other than that, i'm not sure.. unless you want to maintain this misc repo and just have all the different things as branches
[14:54:18 CST(-0600)] <clown> colinclark, Justin_o: re: my tabindex and dom mutation test pages – yes, I plan to get them. But haven't found a spare moment to do so yet. Do you have a drop dead date?
[14:54:34 CST(-0600)] <jhung> colinclark: no prob. I figure it'll help others too hopefully by not reproducing bugs.
[14:55:29 CST(-0600)] <justin_o_> clown: currently that is Feb 23
[14:56:11 CST(-0600)] <clown> justin_o: a week? Okay, I'll try to get to it by then.
[14:56:47 CST(-0600)] <justin_o_> clown: thanks
[14:56:55 CST(-0600)] <Bosmon2> Ok - I guess I can just create a "junk user" to host these repos
[14:57:08 CST(-0600)] <Bosmon2> A "user to own junk"
[14:57:10 CST(-0600)] <clown> justin_o_: wlcm
[15:08:34 CST(-0600)] <justin_o_> anastasiac: did you just send a pull request for your update to the pom file
[15:08:43 CST(-0600)] <anastasiac> yes
[15:09:21 CST(-0600)] <justin_o_> anastasiac: is someone looking into that or would you like me to handle it
[15:09:23 CST(-0600)] <heidi> colinclark are you able to run ie6 where you are? the versions of windows here aren't 'verified' and i can't seem to get them verified, so i can't install virtual pic... ugh
[15:09:49 CST(-0600)] <colinclark> I'll give it a shot
[15:10:07 CST(-0600)] <colinclark> We'll have to get you set up with a Virtual Box conversion of our VMWare images
[15:10:13 CST(-0600)] <anastasiac> justin_o_, michelled handled the first pass, so I'll let the two of you fight over it (smile)
[15:10:18 CST(-0600)] <colinclark> I've had success converting Linux images in the past
[15:10:20 CST(-0600)] <justin_o_> anastasiac: thanks
[15:10:30 CST(-0600)] <justin_o_> michelled: did you want to handle anastasiac's latest pull request
[15:10:32 CST(-0600)] <colinclark> never tried it with Windows, though, heidi
[15:10:36 CST(-0600)] <justin_o_> we need it to get the image gallery running
[15:10:37 CST(-0600)] <heidi> there must be virtualbox versions of ie6
[15:10:46 CST(-0600)] <heidi> looking...
[15:11:38 CST(-0600)] <anastasiac> Justin_o_, should testing be done on the build site right now?
[15:11:49 CST(-0600)] <heidi> "Update: Microsoft’s images are broken, and don’t work on anything except VirtualPC now. Mac and Linux users are out of luck for the time being." boo
[15:11:51 CST(-0600)] <justin_o_> anastasiac: yes... you can test off the build site
[15:11:58 CST(-0600)] <anastasiac> k, thanks
[15:12:36 CST(-0600)] <justin_o_> heidi: so virtualBox is just blocking them from running now?
[15:13:12 CST(-0600)] <heidi> justin_o i'm guessing the downloadable disk images from microsoft (they have one for each browser) won't load on vb
[15:13:35 CST(-0600)] <michelled> justin_o_: sure if you don't mind
[15:13:37 CST(-0600)] <heidi> justin_o oh, the windows version on the two machines near me won't let me download virtual machine
[15:14:31 CST(-0600)] <justin_o_> heidi: really
[15:14:34 CST(-0600)] <anastasiac> heidi, I'm getting a failing unit test in FluidView tests, related to the scrollableTable - is this related to something you're still working on?
[15:15:18 CST(-0600)] <heidi> hey anastasiac , we've got a branch that's going in soon that reverts scrollable table stuff
[15:15:25 CST(-0600)] <heidi> colinclark removed those tests i think
[15:15:42 CST(-0600)] <anastasiac> ok, I suspected that might be the case. I'll ignore it, and re-test once the changes are reverted.
[15:15:45 CST(-0600)] <anastasiac> thanks, heidi
[15:15:49 CST(-0600)] <heidi> thanks, almost done
[15:17:29 CST(-0600)] <Bosmon2> Justin_o, yura_: A super-quick git question
[15:17:44 CST(-0600)] <Bosmon2> IURA is trying to clone my personal Infusion repo - and has found that branches have not been cloned with it
[15:17:47 CST(-0600)] <Bosmon2> That seems surprising to me
[15:17:59 CST(-0600)] <Bosmon2> If it is really true... he should be able to just "pull" the branches individually, right?
[15:18:33 CST(-0600)] <colinclark> heidi: scrolling to isn't working on IE 6
[15:18:37 CST(-0600)] <colinclark> I wonder what we are doing wrong?
[15:18:50 CST(-0600)] <heidi> darn...hmm
[15:19:03 CST(-0600)] <heidi> colinclark is height set inline?
[15:19:18 CST(-0600)] <heidi> ie. is refreshview being called
[15:19:51 CST(-0600)] <colinclark> It sure looks like it, yes
[15:19:55 CST(-0600)] <colinclark> since the area is nicely scrollable
[15:20:04 CST(-0600)] <heidi> ah, scrollTo not working
[15:20:05 CST(-0600)] <colinclark> we're just not scrolling to the bottom when we add a new file
[15:20:17 CST(-0600)] <justin_o_> Bosmon2: if you do git branch -a
[15:20:22 CST(-0600)] <justin_o_> you should be able to see them
[15:20:52 CST(-0600)] <justin_o_> what i usually do to get a specific branch is just checkout the one i want, then create a branch off of it
[15:21:06 CST(-0600)] <heidi> colinclark everything looks fine on mac ff/safari, win ff, ie7, ie8
[15:22:34 CST(-0600)] <colinclark> you know what's interesting, heidi?
[15:22:42 CST(-0600)] <colinclark> it looks like it is scrolling to the bottom
[15:22:48 CST(-0600)] <colinclark> and then snapping back up to the top at the end
[15:22:55 CST(-0600)] <heidi> oh ie6
[15:23:35 CST(-0600)] <heidi> one thing our list does (and did in 1.3, i checked) is if you select a file, and go down the list, it goes around to the first file when you reach the bottom. not sure if it's related
[15:23:41 CST(-0600)] <colinclark> Okay, it is a sequence thing
[15:23:57 CST(-0600)] <colinclark> It makes sense, logically
[15:24:17 CST(-0600)] <colinclark> Have a look at the implementation for addFile on line 196 of FileQueueView.js, heidi
[15:24:25 CST(-0600)] <colinclark> We'll see if we can break it down and explain the behaviour to ourselves
[15:24:30 CST(-0600)] <colinclark> just so we know for sure what's going on
[15:24:45 CST(-0600)] <heidi> k loading up
[15:24:56 CST(-0600)] <colinclark> So, in this function we call scrollTo() first, then refreshView() on the FileQueueView
[15:25:23 CST(-0600)] <colinclark> And FileQueueView's refreshView() method calls Scrollable.refreshView()
[15:25:31 CST(-0600)] <colinclark> which changes the height of the scrollable area
[15:25:52 CST(-0600)] <colinclark> I assume that, when updating the height, IE is scrolling the view back up to the top
[15:26:05 CST(-0600)] <heidi> ah, that makes sense
[15:26:11 CST(-0600)] <colinclark> So if we were to scrollTo() as the last action in addFile(), it should work
[15:26:13 CST(-0600)] <colinclark> (and it does) (smile)
[15:26:18 CST(-0600)] <heidi> yahoo!
[15:26:23 CST(-0600)] <colinclark> cool
[15:26:30 CST(-0600)] <colinclark> I'll run all the tests and then push
[15:26:32 CST(-0600)] <Bosmon2> Justin_o - bizarrely enough, this seems to require a use of "git checkout" (tongue)
[15:26:33 CST(-0600)] <Bosmon2> http://stackoverflow.com/questions/67699/how-do-i-clone-all-remote-branches-with-git
[15:26:39 CST(-0600)] <heidi> thanks colinclark
[15:27:16 CST(-0600)] <colinclark> The styling isn't awesome in IE6, heidi
[15:27:26 CST(-0600)] <colinclark> I don't know how much of this is old news
[15:27:30 CST(-0600)] <colinclark> vs. new regressions
[15:27:32 CST(-0600)] <heidi> what's ugly?
[15:27:50 CST(-0600)] <colinclark> The total progress bar shows up only on half of the footer
[15:28:20 CST(-0600)] <heidi> hmmm
[15:28:43 CST(-0600)] <colinclark> I'll just check the 1.3 demo and see if it's the same
[15:28:53 CST(-0600)] <heidi> colinclark do you think the progress change to calc innerWidth vs width could mess up ie6?
[15:29:18 CST(-0600)] <heidi> there's one small thing in ie7 - a top border on the table missing
[15:29:59 CST(-0600)] <colinclark> heidi: This was also a bug in 1.3
[15:30:11 CST(-0600)] <heidi> the progress bar?
[15:30:21 CST(-0600)] <colinclark> yes
[15:30:29 CST(-0600)] <colinclark> So I think we'll leave it for this one
[15:30:29 CST(-0600)] <heidi> phew
[15:30:32 CST(-0600)] <colinclark> it's too bad
[15:30:36 CST(-0600)] <colinclark> but definitely an old bug, heidi
[15:30:37 CST(-0600)] <colinclark> (smile)
[15:31:37 CST(-0600)] <anastasiac> Justin_o_, just double-checking: if the build site suddenly goes down, that's just you working on it, right?
[15:32:15 CST(-0600)] <anastasiac> specifically, build site looks funny, demos inaccessible
[15:32:17 CST(-0600)] <justin_o_> anastasiac: oops sorry forgot about that
[15:32:30 CST(-0600)] <justin_o_> we'll have that back up in a moment or two
[15:32:36 CST(-0600)] <anastasiac> (smile)
[15:33:25 CST(-0600)] <colinclark> michelled: Unit testing advice?
[15:34:11 CST(-0600)] <justin_o_> anastasiac: on a more pleasant note, i pushed your pull request in
[15:34:28 CST(-0600)] <anastasiac> thanks (smile)
[15:36:12 CST(-0600)] <michelled> colinclark: did you already ask something? I haven't been watching the channel
[15:36:27 CST(-0600)] <colinclark> i was waiting for you to respond, michelled
[15:36:32 CST(-0600)] <michelled> :0
[15:36:38 CST(-0600)] <colinclark> I have a test that seems to fail in IE
[15:36:46 CST(-0600)] <colinclark> due to the fact that IE6 generally sucks, I believe
[15:36:57 CST(-0600)] <colinclark> I could special case it
[15:36:58 CST(-0600)] <michelled> is it only failing in IE6?
[15:37:01 CST(-0600)] <colinclark> or I could toss the test
[15:37:01 CST(-0600)] <colinclark> yes
[15:37:17 CST(-0600)] <michelled> does the actual behaviour work in IE6?
[15:37:58 CST(-0600)] <colinclark> Well, it's sort of fuzzy that way
[15:38:10 CST(-0600)] <colinclark> the actually behaviour is to set some arbitrary inline CSS values on startup
[15:38:29 CST(-0600)] <colinclark> the particular style I'm testing with seems to not quite do the right thing in IE6
[15:39:27 CST(-0600)] <colinclark> I think perhaps the whole test is just stupid
[15:39:44 CST(-0600)] <colinclark> and moot given that we're no longer introducing this as a general-purpose feature
[15:40:46 CST(-0600)] <heidi> colinclark can you change one line for me in uploader.css (or should i?) , move line 17 to line 14. so border shows up under header in IE7
[15:42:37 CST(-0600)] <colinclark> michelled: I'm going to take both the behaviour and the test out
[15:42:42 CST(-0600)] <colinclark> it just doesn't make sense in this context anymore
[15:42:45 CST(-0600)] <colinclark> heidi: Yes, I can do that
[15:42:51 CST(-0600)] <anastasiac> Justin_o_, would i be better off testing a copy of infusion from my hard-drive?
[15:42:58 CST(-0600)] <colinclark> Can you make me a patch real quick, just to make it easy?
[15:43:02 CST(-0600)] <anastasiac> instead of the build server?
[15:43:12 CST(-0600)] <justin_o_> anastasiac: at this moment yes.. sorry about that
[15:43:17 CST(-0600)] <michelled> colinclark: sounds good (smile)
[15:43:20 CST(-0600)] <justin_o_> trying to get it all working properly (sad)
[15:43:41 CST(-0600)] <anastasiac> np, so long as i know, and so long as that's acceptable
[15:46:10 CST(-0600)] <justin_o_> i think it's fine as long as your copy is up-to-date
[15:46:12 CST(-0600)] <justin_o_> anastasiac: ^
[15:46:34 CST(-0600)] <anastasiac> justin_o_, not to worry - I'm pulling from upstream regularly (smile)
[15:48:05 CST(-0600)] <heidi> colinclark was the patch thing for me or someone else?
[15:48:14 CST(-0600)] <colinclark> that was for you heidi
[15:48:15 CST(-0600)] <colinclark> sor
[15:48:18 CST(-0600)] <heidi> okee
[15:48:18 CST(-0600)] <colinclark> ry
[15:48:28 CST(-0600)] <colinclark> lots of chat today
[15:48:39 CST(-0600)] <colinclark> is chat ever a noun?
[15:48:44 CST(-0600)] <colinclark> or is only ever a verb?
[15:48:56 CST(-0600)] <heidi> it's a noun too
[15:51:24 CST(-0600)] <heidi> colinclark learning git patch making over here...
[15:52:50 CST(-0600)] <heidi> suggestions?
[15:52:58 CST(-0600)] <heidi> i made a change to my local copy of your branch
[15:54:24 CST(-0600)] <heidi> michelled i think git diff origina/FLUID-4061 while i'm checkout in my local FLUID-4061 did it
[15:55:06 CST(-0600)] <heidi> and > filename.patch
[15:55:20 CST(-0600)] <colinclark> yep, that seems about right
[15:55:33 CST(-0600)] <heidi> err.... no
[15:55:38 CST(-0600)] <heidi> has extra changes in there
[15:56:40 CST(-0600)] <michelled> I know if you use git diff <commit hash> <commit hash> it will work
[15:56:47 CST(-0600)] <michelled> I haven't tried with branch names
[15:57:16 CST(-0600)] <heidi> but i think its my fault, i think that was still right
[15:58:03 CST(-0600)] <heidi> success... comin atcha c
[16:01:19 CST(-0600)] <colinclark> vmware is driving me completely insane
[16:01:34 CST(-0600)] <heidi> colinclark http://issues.fluidproject.org/browse/FLUID-4061
[16:01:42 CST(-0600)] <colinclark> thx
[16:03:21 CST(-0600)] <justin_o_> fluid-everyone: you can test from the build site again
[16:03:26 CST(-0600)] <justin_o_> it's back up now.. sorry about the delay
[16:05:26 CST(-0600)] <colinclark> heidi, justin_o_: My machine has ground to a halt and I've got to leave for a bit. It looks like I'll have to get FLUID-4061 into the project repo later tonight
[16:05:36 CST(-0600)] <heidi> thanks c
[16:05:57 CST(-0600)] <justin_o_> colinclark: okay
[16:06:20 CST(-0600)] <justin_o_> we're still working on the daily build for the image gallery, but it's almost done
[16:16:01 CST(-0600)] <justin_o_> fluid-everyone: the daily build is up
[16:16:10 CST(-0600)] <justin_o_> and the uploader server is now working as well
[16:16:12 CST(-0600)] <justin_o_> thanks jamon
[16:16:34 CST(-0600)] <jamon> so we won't touch it until after 1.3.1, unless a build isn't running for some reason