fluid-work IRC Logs-2011-02-25

Owned by Fluid IRC Log Bot
Last updated: Feb 25, 2011Version comment
6 min read

[08:23:09 CST(-0600)] <kasper> morning yura_
[08:23:22 CST(-0600)] <yura_> kasper: hi
[08:23:49 CST(-0600)] <kasper> saw your comments on my git commit
[08:23:53 CST(-0600)] <kasper> or pull request even
[08:24:09 CST(-0600)] <kasper> and answered (some of) them
[08:24:19 CST(-0600)] <yura_> kasper: ya saw that
[08:24:57 CST(-0600)] <kasper> so, for a thing like my passing an object with the hide variable, rather than simply the hide variable
[08:25:14 CST(-0600)] <kasper> is this something I should change, and then recommit/repull request?
[08:26:58 CST(-0600)] <yura_> kasper: well I wanted to look at why the thing is a string, but yes, i m not sure why you need it there
[08:27:06 CST(-0600)] <yura_> and we probably need a test case for that
[08:27:33 CST(-0600)] <kasper> yeah
[08:31:02 CST(-0600)] <kasper> is there anywhere in particular I would put a test? – or should I create a new header-test file?
[08:31:43 CST(-0600)] <kasper> yura_, ^
[08:32:13 CST(-0600)] <Justin_o> kasper: yura_ just stepped out for coffee
[08:32:26 CST(-0600)] <kasper> Justin_o: oki doki.. Thanks justing
[08:32:34 CST(-0600)] <kasper> justin* (smile)
[08:33:05 CST(-0600)] <Justin_o> kasper: no problem... were you able to get the doh.robot test working? I chatted with yura a bit about it earlier this week
[08:33:48 CST(-0600)] <kasper> Justin_o, nope – tried to hook it up to infusions event system, but rather unsuccessfully
[08:34:13 CST(-0600)] <kasper> Justin_o: was actually considering poking you and/or colin about it
[08:34:55 CST(-0600)] <kasper> since i spent most of a week on getting that test to work – or rather getting the stall for xhr calls to work
[08:35:43 CST(-0600)] <Justin_o> kasper: so we were also talking a bit about it at our last dev meeting..
[08:35:59 CST(-0600)] <Justin_o> oh so are able to test the page now?
[08:36:05 CST(-0600)] <kasper> nope
[08:36:08 CST(-0600)] <kasper> never worked
[08:36:11 CST(-0600)] <Justin_o> ah
[08:36:33 CST(-0600)] <Justin_o> so one thing we were thinking is that you can place then entire doh.robot code into some callback or something
[08:37:06 CST(-0600)] <Justin_o> meaning that you wait until you are ready to start testing, and when you know you are ready, then you execute the robot test code
[08:37:34 CST(-0600)] <Justin_o> i'm not sure i'm explaining this well
[08:38:06 CST(-0600)] <kasper> I think I get the idea
[08:38:23 CST(-0600)] <kasper> .. I'm not sure it'll work for all our cases though
[08:38:45 CST(-0600)] <kasper> .. so for checking that things are properly loaded, reacting to clicks, etc might be doable this way
[08:39:06 CST(-0600)] <kasper> but things like checking page is properly saved
[08:39:21 CST(-0600)] <Justin_o> hmm.. i was thinking this more for the initial load..
[08:39:34 CST(-0600)] <Justin_o> i think the individual tests have timeouts as well...
[08:39:54 CST(-0600)] <kasper> that's true
[08:40:07 CST(-0600)] <Justin_o> have you determined what the maximum acceptable wait time is?
[08:40:20 CST(-0600)] <Justin_o> you could say that if saving takes longer than x minutes, then it's a fail regardless
[08:41:20 CST(-0600)] <kasper> justin_o: not really - we do have some goals, in terms of what an acceptable load time is
[08:42:21 CST(-0600)] <kasper> but for the acceptance testing, I might want to allow a bit longer for pageloads, as to fail on functional errors, rather than network delays/server speed
[08:42:36 CST(-0600)] <kasper> I'm not sure what is normal practice to do
[08:43:46 CST(-0600)] <Justin_o> kasper: i guess it depends... but i think at some point cspace will have to decide what is acceptable for time.. one could consider a really long page load to be a failure.. since the user may think the page has hung and etc. slow loading pages really do hamper the workflow.. our wiki here has been pretty slow lately and it drives us all crazy
[08:46:31 CST(-0600)] <yura_> hey kasper
[08:46:32 CST(-0600)] <yura_> sorry (smile)
[08:47:09 CST(-0600)] <kasper> justin_o: anyway, the placing the entire doh code in a callback is a good idea.. I'll give that a go today or monday
[08:47:12 CST(-0600)] <kasper> yura_, np
[08:47:50 CST(-0600)] <yura_> kasper: so i think you can just put it in createNewTests.hs
[08:47:52 CST(-0600)] <yura_> js
[08:47:58 CST(-0600)] <kasper> ok cool
[09:12:31 CST(-0600)] <harriswong> Justin_o, michelled: Is there anymore testing to do for the release?
[09:13:02 CST(-0600)] <Justin_o> harriswong: not just yet, but there will be when we get the builder up
[09:13:06 CST(-0600)] <Justin_o> to date
[09:13:25 CST(-0600)] <harriswong> Justin_o: ok.
[09:20:09 CST(-0600)] <Justin_o> harriswong: what was this issue about again
[09:20:10 CST(-0600)] <Justin_o> http://issues.fluidproject.org/browse/FLUID-4109
[09:21:31 CST(-0600)] <Justin_o> heidi_: can you tell me about http://issues.fluidproject.org/browse/FLUID-4061
[09:22:01 CST(-0600)] <heidi_> hey Justin_o that's the one we backed out of the release
[09:22:18 CST(-0600)] <heidi_> we'll try to work on for 1.4
[09:22:22 CST(-0600)] <Justin_o> heidi_: would you be able to update the jira for that one
[09:22:25 CST(-0600)] <heidi_> sure
[09:25:39 CST(-0600)] <Justin_o> heidi_: thanks
[09:26:37 CST(-0600)] <harriswong> Justin_o: Loading up the layoutReorderer will generate the "demo is not defined" error
[09:27:58 CST(-0600)] <Justin_o> wondering why we decided this wasn't a blocker
[09:27:59 CST(-0600)] <Justin_o> do you remember
[09:28:38 CST(-0600)] <Justin_o> ah i remember now
[09:28:50 CST(-0600)] <Justin_o> the actual script tag for the demo's js file was missing
[09:29:01 CST(-0600)] <Justin_o> harriswong: is that correct?
[09:29:39 CST(-0600)] <harriswong> Justin_o: yep, and I hvae to add the script tag in manually for it to work. I think you said this might be something related to the urlrewrite during the build process
[09:29:54 CST(-0600)] <Justin_o> harriswong: yes.. that's correct.. thanks
[09:30:08 CST(-0600)] <harriswong> Justin_o: np!!
[10:21:56 CST(-0600)] <golam> Justin_o: IE6 Pager, Uploader, Uportal have issues when loading the demo page.
[10:22:10 CST(-0600)] <Justin_o> golam: what's wrong
[10:22:29 CST(-0600)] <golam> Justin_o: the demo codes are not showing
[10:22:41 CST(-0600)] <Justin_o> so like what we saw yesterday?
[10:22:56 CST(-0600)] <golam> Justin_o: yes
[10:23:28 CST(-0600)] <Justin_o> okay.. can you poke mlam to give it a quick test to make sure they work in his ie6
[10:24:45 CST(-0600)] <golam> Justin_o, mlam: I will
[10:27:35 CST(-0600)] <mlam> The code view panel doesn't display anything for the uploader and pager in IE6, but there are no issues with the uPortal demo for me
[10:43:26 CST(-0600)] <Justin_o> mlam: thanks.. the missing code is a known issue
[10:45:26 CST(-0600)] <mlam> ok
[10:46:43 CST(-0600)] <golam> Justin_o: is there any other tests you want me do?
[10:47:33 CST(-0600)] <golam> Justin_o: if not them I will do some jslnt recommended clean up for inline edit.
[10:48:02 CST(-0600)] <golam> Justin_o: I meant inline edit test cases
[11:17:35 CST(-0600)] <Justin_o> golam: thanks
[11:17:47 CST(-0600)] <Justin_o> we will have some builder tests later, but have to get it working first (smile)
[14:56:02 CST(-0600)] <Justin_o> heidi_: hello do you have time to help us with some stuff
[14:56:25 CST(-0600)] <heidi_> trying to finish something for smriti but can help if you need ppl!
[14:57:44 CST(-0600)] <Justin_o> heidi_: we're just trying to prime the cache for the builder
[14:57:50 CST(-0600)] <Justin_o> builder.fluidproject.org
[14:58:04 CST(-0600)] <Justin_o> if you could make some builds that you think our users would try
[14:59:49 CST(-0600)] <heidi_> k
[15:02:43 CST(-0600)] <Justin_o> heidi_: thakns
[15:02:44 CST(-0600)] <Justin_o> thanks
[15:04:18 CST(-0600)] <golam> Justin_o: I have downloaded the complete package and compared against an existing package and they seem to have all the necessary files.
[15:04:52 CST(-0600)] <Justin_o> golam: thanks
[15:05:47 CST(-0600)] <Justin_o> golam: can you also try making some builds to prime the cache
[15:06:01 CST(-0600)] <golam> ok
[15:08:40 CST(-0600)] <golam> Justin_o: demo folder are missing from the src. Is that expected?
[15:09:30 CST(-0600)] <Justin_o> golam: yes.. no demo folders and no tests
[15:09:41 CST(-0600)] <golam> Justin_o: sounds good
[15:21:30 CST(-0600)] <mlam> michelled: Justin_o: everything seems to be fine so far
[15:23:56 CST(-0600)] <Justin_o> mlam: great (smile)
[15:24:04 CST(-0600)] <michelled> cool. mlam: does this page look right to you? http://wiki.fluidproject.org/display/fluid/Fluid+Infusion+-+Current+Release
[15:25:43 CST(-0600)] <mlam> yes, and the links look good.
[15:35:48 CST(-0600)] <golam> Justin_o: the src package also has all the files
[15:39:55 CST(-0600)] <Justin_o> golam: great thanks
[15:46:36 CST(-0600)] <Justin_o> fluid-everyone: we've officially release infusion 1.3.1 now thanks for all the help with development and testing.
[15:47:24 CST(-0600)] <mlam> sweet!
[15:47:41 CST(-0600)] <michelled> (smile)
[15:47:58 CST(-0600)] <michelled> there are still some clean up tasks and prep tasks for 1.4 but we can do those next week
[15:48:11 CST(-0600)] <michelled> and I'm determined to clean up this release process documentation
[15:49:55 CST(-0600)] <golam> great