fluid-work IRC Logs-2011-02-17

Owned by Fluid IRC Log Bot
Last updated: Feb 17, 2011Version comment
23 min read

[07:59:06 CST(-0600)] <kasper> morning justin_o
[07:59:24 CST(-0600)] <kasper> I looked at the code on github
[08:00:36 CST(-0600)] <Justin_o> kasper: hi kasper good morning
[08:00:38 CST(-0600)] <kasper> I think I remember some other code you had laying around.. What is on github now looks like tests for fluid and the beginning of either a new robot, or an ultra-ultra thin wrapper around the robot
[08:01:06 CST(-0600)] <kasper> but didn't you also have some code that were parts of getting the robot to work with jqunit?
[08:01:09 CST(-0600)] <Justin_o> kasper: yes you are correct.. that is the much older code
[08:01:25 CST(-0600)] <Justin_o> i'll have to dig around to see where that newer version went to
[08:01:57 CST(-0600)] <kasper> which is the older code? - ultra thin wrapper or jqunit wrapper?
[08:02:11 CST(-0600)] <kasper> btw, did you get to talk to colin about whether he could meet today
[08:03:18 CST(-0600)] <Justin_o> the jqunit wrapper is the newer stuff, but not in git hub at the moment... i'll try to find where it went to
[08:03:28 CST(-0600)] <kasper> cool, tahnks
[08:03:41 CST(-0600)] <Justin_o> as for talking to colin, sorry didn't get a chance yet.. i'll send him an e-mail now
[08:04:22 CST(-0600)] <kasper> cool, thanks
[08:35:28 CST(-0600)] <heidi_> anastasiac thanks for that email - sounds like Bosmon2 is looking for what i was looking for - some dev intro documentation to help lead you into creating components. thanks for this ! my page was just a super rough start, but this helps
[08:36:10 CST(-0600)] <anastasiac> heidi, yes, you may have seen the thread between Bosmon2 and eric on fluid-work - that's what got Bos thinking
[08:36:15 CST(-0600)] <anastasiac> and your page is a great start!
[08:36:52 CST(-0600)] <heidi_> cool (smile)
[08:57:04 CST(-0600)] <jhung> Hi all, I'm testing uploader. The following unit test link appears broken? http://build.fluidproject.org/infusion/tests/component-tests/uploader/html/Scroller-test.html
[08:57:14 CST(-0600)] <jhung> (broken as in the link isn't working)
[08:57:55 CST(-0600)] <jhung> anyone have the correct URL for it?
[08:59:05 CST(-0600)] <Justin_o> heidi_: when you were working on changing the scrolling for the file queue did you delete the scroller test?
[08:59:24 CST(-0600)] <heidi_> Justin_o i think colinclark did in his branch
[09:00:01 CST(-0600)] <Justin_o> heidi_: was this supposed to go back in after the revert?
[09:00:03 CST(-0600)] <harriswong> jhung: where do you see in the testplan that asks to check for data showing for the sorted column?
[09:00:35 CST(-0600)] <heidi_> justin_o oh this one looks different - yes it was deleted because it tests the old scroller component, now replaced with scrollTo which doesn't need a test
[09:00:40 CST(-0600)] <harriswong> jhung: for 4071
[09:00:54 CST(-0600)] <Justin_o> heidi_: thanks
[09:04:16 CST(-0600)] <jhung> harriswong: gimme a sec...
[09:04:48 CST(-0600)] <jhung> Test 6: change the sort, then hover.
[09:05:29 CST(-0600)] <jhung> harriswong: maybe the title of the bug should be more clear.
[09:05:42 CST(-0600)] <jhung> the sorting is correct, it's the tooltip that is displaying the wrong data.
[09:06:59 CST(-0600)] <harriswong> jhung: nope, i think it's fine. i misunderstood test 6. I thought all it requires is to have first and last items of the page showing up, doesn't have to be from the sorted column.
[09:08:24 CST(-0600)] <jhung> harriswong: Yeah. I think the test plan needs to be updated.
[09:08:34 CST(-0600)] <jhung> I can do that now.
[09:08:58 CST(-0600)] <harriswong> jhung: I am adding FF3.6 IE8 from XP onto your jira. I believe it would be so for safari too
[09:09:47 CST(-0600)] <jhung> k.
[09:10:42 CST(-0600)] <Justin_o> jhung: i'm not sure what the intended behaviour is.. the pager actually only seems to support tooltips based on the content of a single column
[09:11:24 CST(-0600)] <jhung> justin_o: I wasn't sure about it either so I chatted with jameswy about it yesterday. It makes sense to have the sort column drive the tooltip text.
[09:12:00 CST(-0600)] <Justin_o> jhung: agreed... could you and jameswy double check the design docs about it on the wiki too.. not sure if those will need to be updated or not
[09:13:33 CST(-0600)] <cindyli> Justin_o: i wanna backup https://github.com/fluid-project/misc/tree/uploader, which is a branch of "fluid-project/misc", into my github. i forked this project but a bit worry that my fork will be gone once this project is obsolete and removed. so, i'm thinking the safer way might be make my own github branch and copy in "uploader" branch. am i right?
[09:14:27 CST(-0600)] <Justin_o> cindyli: i'm not sure what the effect will be on yours if i were to remove the original repo
[09:14:40 CST(-0600)] <harriswong> justin_o: there is a typo on http://build.fluidproject.org/unit-tests.html, "Fluid View tetsts".
[09:14:40 CST(-0600)] <Justin_o> but what i did for the stuff i wanted was to clone the fluid-project/misc
[09:14:55 CST(-0600)] <Justin_o> create my own repo in git hub, and just push the branches i wanted up to it
[09:15:33 CST(-0600)] <harriswong> justin_o: also, http://build.fluidproject.org/infusion/tests/framework-tests/core/html/FluidView-test.html is failing, I am wondering if this is because it hasn't been setup properly?
[09:15:44 CST(-0600)] <Justin_o> harriswong: thanks.. i'll look at fixing that typo
[09:16:16 CST(-0600)] <Justin_o> heidi_: do you have any thoughts on why that is failing
[09:16:33 CST(-0600)] <heidi_> reading..
[09:16:35 CST(-0600)] <cindyli> Justin_o: push the branches, first is to fetch the "uploader" branch of even "misc" into my local. having trouble with that, i created an upstream pointing to "fluid-project/misc", but "git fech" gives ssl certificate problem.
[09:18:14 CST(-0600)] <heidi_> yeah
[09:18:17 CST(-0600)] <Justin_o> harriswong: can you make a note that you need to retest it
[09:18:38 CST(-0600)] <cindyli> Justin_o: i think i was. what i did:
[09:18:38 CST(-0600)] <cindyli> git remote add uploader https://github.com/fluid-project/misc.git
[09:18:38 CST(-0600)] <cindyli> git fetch uploader --> ssl problem
[09:18:47 CST(-0600)] <jhung> justin_o: the pager design does seem to imply that the tooltip text be driven by the sort column (see http://wiki.fluidproject.org/display/fluid/Pager+Storycards), but I'm having trouble tracking down the wireframe.
[09:18:50 CST(-0600)] <cindyli> Justin_o: wrong?
[09:18:51 CST(-0600)] <harriswong> Justin_o: noted.
[09:19:38 CST(-0600)] <harriswong> jhung: would it be a problem to switch the tooltips to column-based now that people are used to it?
[09:21:32 CST(-0600)] <jhung> harriswong: That's a good question. I don't think it's a problem, but I don't want to assume.
[09:21:33 CST(-0600)] <Justin_o> cindyli: i think i'll have to come over and see
[09:21:47 CST(-0600)] <jhung> harriswong: I think the best way to do this is to make it configurable.
[09:22:42 CST(-0600)] <jhung> harriswong: actually, it doesn't make sense to display the tooltip based on the column not being sorted.
[10:07:39 CST(-0600)] <heidi_> Justin_o what does check shipped examples mean again?
[10:09:41 CST(-0600)] <Justin_o> heidi_: that means make sure that all of the examples/demos are working
[10:10:17 CST(-0600)] <Justin_o> there's no specific testplans for these.. just play around a bit and make sure there no obvious errors and etc.
[10:10:57 CST(-0600)] <heidi_> Justin_o okee doke. does it include screen readers etc
[10:11:18 CST(-0600)] <Justin_o> heidi_: not specifically, but you're more than welcome to do so
[10:15:27 CST(-0600)] <colinclark> Justin_o: I feel like we're getting closer to the prospect of having an A-Grade screen reader list
[10:15:27 CST(-0600)] <colinclark> It opens up a huge can of worms, though
[10:15:27 CST(-0600)] <colinclark> What other ATs, aside from screen readers, would be A-Grade?
[10:15:27 CST(-0600)] <colinclark> etc
[10:15:27 CST(-0600)] <colinclark> But I can imagine that after 1.3, we're probably in a position where we want to qualify the Infusion components with NVDA at very least
[10:15:28 CST(-0600)] <colinclark> We put so much effort into supporting NVDA that we don't want to regress
[10:16:49 CST(-0600)] <Justin_o> colinclark: interesting... would we only qualify against the latest stable NVDA
[10:16:51 CST(-0600)] <Justin_o> ?
[10:17:08 CST(-0600)] <colinclark> That seems like a reasonable approach
[10:18:26 CST(-0600)] <Justin_o> so i guess we could start with, as you say, an A-Grade screen reader list.. which would consist of just latest stable NVDA
[10:18:37 CST(-0600)] <Justin_o> i think that should be fine as a start
[10:18:39 CST(-0600)] <colinclark> I wonder if we should conceive of it differently...
[10:18:43 CST(-0600)] <colinclark> I realized I used the word "A-Grade"
[10:18:49 CST(-0600)] <colinclark> but I wonder if it's something else
[10:19:04 CST(-0600)] <Justin_o> it could just be a note
[10:19:16 CST(-0600)] <colinclark> Like, our philosophy is that Infusion components should be flexible and standards-compliant enough to support a whole diverse array of assistive technologies
[10:19:38 CST(-0600)] <Justin_o> right and we just verify this with NVDA?
[10:19:41 CST(-0600)] <colinclark> and we also think that testing, advice, and design help related to specific ATs is a really important way for people to get involved in our community
[10:20:33 CST(-0600)] <colinclark> So it's almost like "AT testing starting points"
[10:20:39 CST(-0600)] <colinclark> where we contribute NVDA testing
[10:20:46 CST(-0600)] <colinclark> and encourage others to contribute others
[10:20:56 CST(-0600)] <colinclark> I don't know if this fully makes sense
[10:21:29 CST(-0600)] <colinclark> We want to simultaneously keep our testing surface manageable for a small team, and also not be exclusive to certain ATs
[10:22:01 CST(-0600)] <colinclark> If we're going to "support" a specific AT, I think it serves us well to support free and open solutions before contributing to the Freedom Scientific Monolith
[10:24:35 CST(-0600)] <EricDalquist> thanks for the detailed response Bosmon2 unfortunately I had to read it 3 times to grasp it all (baby inspired sleep deprivation will do that to you)
[10:24:59 CST(-0600)] <EricDalquist> I had been thinking that moving the state of that checkbox into a JS model was going to be the solution here
[10:25:18 CST(-0600)] <Justin_o> colinclark: that makes sense
[10:25:36 CST(-0600)] <colinclark> EricDalquist: I often have to read Bosmon2's emails a few times (tongue)
[10:25:52 CST(-0600)] <EricDalquist> lol, ok so it isn't just the lack of sleep then? (wink)
[10:26:10 CST(-0600)] <Justin_o> i'm not entirely sure how to organize it just yet with the community though, but we should look at this for 1.4 for sure
[10:26:22 CST(-0600)] <colinclark> Justin_o: Yeah, 1.4 sounds like a great time for it.
[10:26:35 CST(-0600)] <colinclark> That said, though, I think we should make sure we test Uploader with NVDA
[10:26:57 CST(-0600)] <colinclark> One of my concerns with the table switchover is that we might have regressed in terms of how we handle the various tables
[10:27:06 CST(-0600)] <colinclark> I vaguely remember setting at least one of them to have a "presentation" role
[10:27:11 CST(-0600)] <colinclark> Which I can imagine got removed at some point
[10:27:18 CST(-0600)] <colinclark> Does that make sense, Justin_o?
[10:27:25 CST(-0600)] <colinclark> heidi_: I just applied your FLUID-4061 patch
[10:27:28 CST(-0600)] <Justin_o> colinclark: yep.. it does
[10:27:42 CST(-0600)] <colinclark> Looks like it didn't quite generate right, but it was easy to trim off the first path segment
[10:27:49 CST(-0600)] <colinclark> Git was doing it's "compare a to b" thing
[10:27:54 CST(-0600)] <heidi_> thanks colin
[10:27:58 CST(-0600)] <colinclark> heidi_: Just to be sure, this patch fixes an IE7 bug?
[10:28:10 CST(-0600)] <colinclark> Or how should I test it out?
[10:28:18 CST(-0600)] <heidi_> an IE7 style yes, a border on top of the queue
[10:28:24 CST(-0600)] <heidi_> below the header
[10:28:42 CST(-0600)] <colinclark> EricDalquist: BTW, I think Bosmon2 is in a meeting, so he might be a bit distracted for a couple minutes
[10:28:59 CST(-0600)] <EricDalquist> no problem
[10:29:21 CST(-0600)] <kasper> colinclark,justin_o: sorry to be pushing for this, but did you find out whether you have time for a call today
[10:29:47 CST(-0600)] <colinclark> kasper: Today's a little whacked for me today, but you and Justin_o should go ahead
[10:29:56 CST(-0600)] <colinclark> I can catch up with you guys after the meeting
[10:30:04 CST(-0600)] <kasper> sure
[10:30:20 CST(-0600)] <colinclark> I'd really like to join you--one of my favourite topics
[10:31:14 CST(-0600)] <kasper> colinclark: atm, it's one of my least favourite topics - but that's just cause doh.robot is frustrating the *%@# out of me (smile)
[10:31:20 CST(-0600)] <colinclark> lol
[10:31:24 CST(-0600)] <colinclark> yeah, I'm not surprised
[10:33:59 CST(-0600)] <EricDalquist> does FSS have any pre-defined table column width classes?
[10:34:06 CST(-0600)] <EricDalquist> I didn't see that mentioned in the wiki
[10:40:45 CST(-0600)] <heidi_> colinclark 4061 looking good on IE7
[10:43:09 CST(-0600)] <colinclark> heidi_: Excellent!
[10:43:39 CST(-0600)] <colinclark> I'll push it to the project repo now, and we'll be good to go
[10:43:52 CST(-0600)] <heidi_> let the testing begin
[10:44:23 CST(-0600)] <heidi_> EricDalquist checking FSS, on sec..
[10:45:59 CST(-0600)] <heidi_> EricDalquist nothing specific for tables - what kind of styles were you looking for? like a way to define all col widths in one place or specify a width on each <td> ?
[10:46:45 CST(-0600)] <heidi_> for each, <td>, you could use .fl-container- styles at the top of fss-layout
[10:49:57 CST(-0600)] <Justin_o> kasper: i think i'm free at 1pm my time or sometime between 2:30 and 3:00 my time.. how is that for you?
[10:50:43 CST(-0600)] <EricDalquist> ok
[10:50:49 CST(-0600)] <EricDalquist> that sounds like what I was looking for
[10:50:51 CST(-0600)] <kasper> Justin_o: either one will work for me.. If you dont got any preferences, lets say 1pm
[10:51:46 CST(-0600)] <Justin_o> kasper: okay.. let's go with 1pm then
[10:54:25 CST(-0600)] <clown> colinclark: Starting point for the HTML5 and ARIA discussion: http://www.w3.org/2002/09/wbs/40318/issue-129-objection-poll/results
[10:54:49 CST(-0600)] <colinclark> Thanks clown
[10:54:55 CST(-0600)] <clown> wlcm
[10:54:58 CST(-0600)] <kasper> justin_o: cool
[10:56:23 CST(-0600)] <harriswong> justin_o: one of "Dead man's blur" tests failed on IE8. http://build.fluidproject.org/infusion/tests/framework-tests/core/html/FluidView-test.html
[10:56:48 CST(-0600)] <harriswong> justin_o: InlineEdit #31 undo control fails as well: http://build.fluidproject.org/infusion/tests/component-tests/inlineEdit/html/InlineEdit-test.html
[10:57:36 CST(-0600)] <Justin_o> harriswong: the ie8 undo one is a known issue
[10:57:41 CST(-0600)] <Justin_o> it's a problem with ie8
[10:58:39 CST(-0600)] <Justin_o> harriswong: is the first link you sent me correct?
[10:59:09 CST(-0600)] <harriswong> Justin_o: yes
[11:00:37 CST(-0600)] <harriswong> justin_o: Fluid View Tests: Dead man's blur test - nonExcluded component one (1, 2, 3) [nonExcluded component one - Blur handler has not executed]
[11:02:23 CST(-0600)] <Justin_o> thanks harris
[11:02:32 CST(-0600)] <Justin_o> Bosmon2: any thoughts on the issue harris just mentioned
[11:04:08 CST(-0600)] <heidi_> harriswong does refreshing the page fix it?
[11:05:11 CST(-0600)] <harriswong> heidi_: for Fluid-view-test dead man blur, nope.
[11:05:39 CST(-0600)] <harriswong> heidi_: btw, i notice scrollable is gone now
[11:05:58 CST(-0600)] <heidi_> harriswong yep it's been moved to uploader
[11:06:19 CST(-0600)] <anastasiac> heidi_, is 4061 the work that's being backed out for 1.3.1 i.e. is that issue still present in 1.3.1?
[11:11:28 CST(-0600)] <heidi_> anastasiac nope, backing out fixes it
[11:11:49 CST(-0600)] <anastasiac> oh, so 4061 will be resolved for 1.3.1, then?
[11:12:10 CST(-0600)] <heidi_> anastasiac, yeah maybe we should just change the affects to 1.4 , but maybe that's not possible
[11:12:35 CST(-0600)] <anastasiac> ok, thanks heidi_ - I'm updating the list of "known issues" right now
[11:12:41 CST(-0600)] <heidi_> cool
[11:22:44 CST(-0600)] <anastasiac> colinclark, I've pushed my updates to the readme to a branch in my public repo (FLUID-4065). I'm having trouble figuring out how to give you write access to that branch - do you know?
[11:22:56 CST(-0600)] <colinclark> yes
[11:23:04 CST(-0600)] <colinclark> In the administration section of Github
[11:23:46 CST(-0600)] <anastasiac> add you to "collaborators"?
[11:24:46 CST(-0600)] <anastasiac> ok, done
[11:28:13 CST(-0600)] <justin_o> colinclark: just double checking is the uploader all ready for testing now?
[11:28:43 CST(-0600)] <colinclark> justin_o: Yep
[11:28:45 CST(-0600)] <colinclark> we're ready to go
[11:30:19 CST(-0600)] <justin_o> colinclark: great thanks
[11:30:27 CST(-0600)] <justin_o> i'll rebuild the image gallery now
[11:31:03 CST(-0600)] <colinclark> thanks, justin_o
[12:00:45 CST(-0600)] <kasper> justin_o: I'm on skype now and ready whenever it suits you
[12:00:55 CST(-0600)] <justin_o> okay.. be on shortly
[12:26:40 CST(-0600)] <heidi_> justin_o , we need to remove the link on the demo portal page to the scrollableTable demo
[12:26:55 CST(-0600)] <heidi_> we're gonna wait till 1.4 for it
[12:27:19 CST(-0600)] <justin_o> ah
[12:27:37 CST(-0600)] <justin_o> that's on the demo/index.html page?
[12:37:09 CST(-0600)] <heidi_> justin_o yep
[12:37:34 CST(-0600)] <justin_o> okay... can you make a jira for that and make it a blocker
[12:37:39 CST(-0600)] <justin_o> anastasiac: ^
[12:38:36 CST(-0600)] <anastasiac> justin_o, is build.fluidproject.org not using the latest code??
[12:39:13 CST(-0600)] <harriswong> justin_o: RendererUtilities test fails on http://build.fluidproject.org/infusion/tests/framework-tests/renderer/html/RendererUtilities-test.html
[12:39:59 CST(-0600)] <harriswong> justin_o: #4, Renderer component tests: FLUID-3819 test: messagekey with no value (1, 2, 3). Nonexisting string relative should be notified. Expected: "[No messagecodes provided]" Result: "[No messagecodes provided][No messagecodes provided]" Diff: "[No messagecodes provided][No messagecodes provided]"
[12:40:17 CST(-0600)] <harriswong> justin_o: IE 7
[12:40:30 CST(-0600)] <anastasiac> ok, now I'm even more confused: justin_o, heidi_: I don't see any link to a scrollableTable demo on the demo portal page
[12:40:34 CST(-0600)] <anastasiac> what am I missing??
[12:41:04 CST(-0600)] <heidi_> anastasiac it's under the FSS demo
[12:41:12 CST(-0600)] <anastasiac> ah
[12:41:27 CST(-0600)] <anastasiac> gotcha
[12:41:31 CST(-0600)] <heidi_> (wink)
[12:44:38 CST(-0600)] <anastasiac> heidi_, when I look at the uploader in safari, I can't see the delete buttons. I don't see a JIRA for this - is this a known issue?
[12:45:21 CST(-0600)] <heidi_> anastasiac i'm guessing you added a file with a long name? ill check if this happens in 1.3
[12:46:00 CST(-0600)] <anastasiac> ah, yes - I'll try again. Is there a jira for that issue, heidi_?
[12:47:02 CST(-0600)] <anastasiac> heidi_, for the link to the scrollableTable demo: http://issues.fluidproject.org/browse/FLUID-4074
[12:48:06 CST(-0600)] <heidi_> anastasiac can you make a jira for the file name not wrapping? it's okay in 1.3 so it was my bad
[12:48:17 CST(-0600)] <justin_o> harriswong: thanks for the update
[12:48:22 CST(-0600)] <anastasiac> heidi_, will do
[12:48:46 CST(-0600)] <justin_o> fluid-everyone: I was chatting a bit with Bosmon2 about the dead man's blur failing unit test in ie 8
[12:49:20 CST(-0600)] <justin_o> so this is partially because of refactoring that happened for dead mans blur. It was going to be part of 1.3 but then we pulled it and it was recommitted after that release
[12:50:27 CST(-0600)] <justin_o> so Bosmon2 can make the test pass, but it isn't really a "real world" test case, so it may or may not actually indicate in practice if this will actually work
[12:50:53 CST(-0600)] <justin_o> so the question would be should we back the changes out again, should we fix up the test case so it at least passes, or some other idea
[12:52:32 CST(-0600)] <Bosmon2> Well, we can't back the changes out again
[12:52:38 CST(-0600)] <Bosmon2> They are working, and the original implementation wasn't
[12:52:48 CST(-0600)] <Bosmon2> Even if the test cases passed
[12:53:21 CST(-0600)] <michelled> Bosmon2: do you feel that the test is worthwhile even if it's not a real world test case?
[12:53:33 CST(-0600)] <Bosmon2> Well, justin_o and I had an interesting philosophical debate about this
[12:53:37 CST(-0600)] <justin_o> Bosmon2: this is somewhat ironic in that the failing test are for working code, but the passing tests were for none working code
[12:53:40 CST(-0600)] <Bosmon2> I guess I could paste some of it in here (smile)
[12:54:24 CST(-0600)] <anastasiac> heidi_, http://issues.fluidproject.org/browse/FLUID-4075
[12:54:39 CST(-0600)] <anastasiac> justin_o, would the JIRA I pasted above be a blocker for 1.3.1?
[12:54:43 CST(-0600)] <heidi_> thanks anastasiac - i guess i'll just put patches up for these fixes?
[12:55:00 CST(-0600)] <Bosmon2> (11:20:26) Justin Obara: is that more moral since then we can assert that the correct behaviour happens in other browsers
[12:55:00 CST(-0600)] <Bosmon2> (11:20:32) AntranigBasman: not really
[12:55:00 CST(-0600)] <Bosmon2> (11:20:38) AntranigBasman: The only point of this implementation is to work on IE (smile)
[12:55:00 CST(-0600)] <Bosmon2> (11:20:38) Justin Obara: rather than making it a test that isn't as usefull everywhere
[12:55:00 CST(-0600)] <Bosmon2> (11:20:43) Justin Obara: oh
[12:55:01 CST(-0600)] <Bosmon2> (11:20:44) Justin Obara: i see
[12:55:01 CST(-0600)] <Bosmon2> (11:21:00) AntranigBasman: IE is the whole reason that it is so baroque and confused, and that there is anything to test at all (tongue)
[12:55:02 CST(-0600)] <Bosmon2> (11:23:46) Justin Obara: but the test will actually not prove anything?
[12:55:02 CST(-0600)] <Bosmon2> (11:24:28) AntranigBasman: Ok, I exaggerated a little... it clearly doesn't prove NOTHING
[12:55:03 CST(-0600)] <Bosmon2> (11:24:42) AntranigBasman: As I said before, it does at least verify that there IS a a code path which can successfully execute (tongue)
[12:55:03 CST(-0600)] <Bosmon2> (11:24:58) AntranigBasman: It verifies the component exists, and responds to its API
[12:55:04 CST(-0600)] <Bosmon2> (11:25:12) Justin Obara: okay.. so it proves that there is at least one path that works, but doesn't assert that other paths won't fail
[12:55:04 CST(-0600)] <Bosmon2> (11:25:32) AntranigBasman: Basically it cannot provide any useful assurance that the component really works in reality
[12:55:05 CST(-0600)] <Bosmon2> (11:25:46) AntranigBasman: But I don't think that is the same as saying "proves nothing" (tongue)
[12:55:08 CST(-0600)] <anastasiac> heidi_, not sure what the new protocol is with git now (smile)
[12:55:23 CST(-0600)] <heidi_> i think 4075 is blockery cos it impedes functionality (deleting the file)
[12:55:34 CST(-0600)] <colinclark> anastasiac, heidi_: Either a patch or a pull request is perfectly cool
[12:55:37 CST(-0600)] <colinclark> whichever you prefer
[12:55:43 CST(-0600)] <heidi_> cool
[12:55:58 CST(-0600)] <colinclark> Is FLUID-4075 a new one for 1.3.1?
[12:57:03 CST(-0600)] <anastasiac> colinclark, yes, I just found it
[12:57:13 CST(-0600)] <justin_o> anastasiac: was it because of the long file name?
[12:57:18 CST(-0600)] <anastasiac> yes
[12:57:18 CST(-0600)] <justin_o> that is an old issue
[12:57:23 CST(-0600)] <michelled> justin_o, Bosmon2: it sounds like that test is almost useless. do you think we are carrying much of a maintenance burden by keeping it around?
[12:57:26 CST(-0600)] <justin_o> i should see if i can track it down
[12:57:36 CST(-0600)] <anastasiac> oh - I didn't see it, and heidi_ said it wasn't present in 1.3... sorry about that
[12:57:48 CST(-0600)] <justin_o> heidi_: it wasn't in 1.3?
[12:57:55 CST(-0600)] <heidi_> justin_o it wraps in 1.3
[12:58:04 CST(-0600)] <justin_o> which browser?
[12:58:14 CST(-0600)] <heidi_> FF3.6
[12:58:42 CST(-0600)] <anastasiac> also Safari
[12:58:58 CST(-0600)] <heidi_> basically there's a no-wrap style on line 87 in uploader.css that needs to be removed. that's all
[12:59:41 CST(-0600)] <anastasiac> so justin_o, this is new - should we consider it a blocker for 1.3.1?
[13:00:11 CST(-0600)] <colinclark> justin_o: I think we should probably defer to jameswy on this one
[13:00:17 CST(-0600)] <colinclark> But it seems an awful lot like a blocker to me
[13:00:24 CST(-0600)] <justin_o> fluid-everyone: the image-gallery has died again. Seems to be failing on a checkout and I'm not sure how to get it back up again. I'll have to talk to jamon when he's around
[13:00:47 CST(-0600)] <colinclark> justin_o: Do you want me to set up a local build somewhere of the gallery?
[13:00:55 CST(-0600)] <justin_o> colinclark: sure thanks
[13:02:42 CST(-0600)] <jameswy> colinclark, justin_o, heidi_: FLUID-4075 definitely sounds like a blocker to me.
[13:03:24 CST(-0600)] <jameswy> Just tried it out myself... pretty big impediment to key features.
[13:03:36 CST(-0600)] <heidi_> thankfully easily fixable
[13:05:04 CST(-0600)] <anastasiac> ok, making it a blocker
[13:05:26 CST(-0600)] <colinclark> heidi_: You make the fix, I'll review your pull request
[13:05:52 CST(-0600)] <harriswong> justin_o: http://build.fluidproject.org/infusion/components/uploader/html/Uploader.html, after browsing files, the button remained as "Browse file", not "Add more", is this intentional
[13:06:03 CST(-0600)] <heidi_> im on it
[13:06:28 CST(-0600)] <colinclark> harriswong: Which browser?
[13:06:38 CST(-0600)] <harriswong> colinclark: ff3/6
[13:06:42 CST(-0600)] <harriswong> 3.6*
[13:06:53 CST(-0600)] <colinclark> I'm not seeing that. How do I reproduce?
[13:07:41 CST(-0600)] <justin_o> harriswong: are you in ie
[13:07:51 CST(-0600)] <justin_o> just saw your next message sorry
[13:11:03 CST(-0600)] <justin_o> Bosmon2, michelled: did you guys decide on something for the DMB unit tests?
[13:11:38 CST(-0600)] <michelled> justin_o: do you think we are carrying much of a maintenance burden by keeping it around?
[13:11:57 CST(-0600)] <justin_o> it's an interesting question
[13:12:16 CST(-0600)] <heidi_> folks, i have a branch ready for 4075, how do i do a pull request again?
[13:12:19 CST(-0600)] <justin_o> maybe, i'm also some what worried that since it isn't real world, it is a bit deceptive and may lead to confusion later
[13:12:26 CST(-0600)] <justin_o> michelled, Bosmon2 ^
[13:12:36 CST(-0600)] <michelled> ya, it sounds to me like we should get rid of it
[13:12:40 CST(-0600)] <justin_o> there's a pull request bottom at the top
[13:12:45 CST(-0600)] <michelled> a test we can't trust doesn't seem worth keeping
[13:12:45 CST(-0600)] <justin_o> button
[13:12:47 CST(-0600)] <heidi_> oh right, on the site
[13:12:50 CST(-0600)] <heidi_> thanks justin
[13:13:27 CST(-0600)] <justin_o> michelled: Bosmon2 was arguing that it does at least prove one case passes, albeit maybe not a real world case
[13:13:52 CST(-0600)] <heidi_> colinclark pull request ready
[13:14:07 CST(-0600)] <heidi_> ill do the same for 4074
[13:18:20 CST(-0600)] <jhung> I have a question for Uploader experts.
[13:18:28 CST(-0600)] <colinclark> fire away, jhung
[13:18:32 CST(-0600)] <michelled> justin_o: I don't get it. there is a particular case for which we have code and a test but we don't think it will ever get exercised in the real world?
[13:18:42 CST(-0600)] <jhung> Is there a filesize limit on the demo on the build site?
[13:19:00 CST(-0600)] <jhung> ^colinclark
[13:19:20 CST(-0600)] <colinclark> jhung: To be specific, can you give me a URL to the page you're testing with?
[13:19:53 CST(-0600)] <jhung> colinclark: when you have an opportunity - http://build.fluidproject.org/infusion/components/uploader/html/Uploader.html
[13:20:59 CST(-0600)] <justin_o> michelled: i think that the work around to get it to pass would cause that
[13:21:22 CST(-0600)] <colinclark> jhung: There's no file limit on that page, no
[13:24:33 CST(-0600)] <harriswong> justin_o, colinclark, jhung: in addition, my problem occurs only when you select multiple files at the first time.
[13:24:57 CST(-0600)] <harriswong> justin_o, colinclark, jhung: the upload button won't work as well.
[13:28:02 CST(-0600)] <jhung> colinclark: thanks. I found a funny bug where I can upload files larger than 20MB in FF3.6, but not in IE8.
[13:28:16 CST(-0600)] <jhung> harriswong: really? I had no problems attaching multiple files.
[13:28:33 CST(-0600)] <colinclark> heidi_: I've pushed your FLUID-4075. It looks good.
[13:28:48 CST(-0600)] <heidi_> colinclark sweet. 4074 is there too
[13:32:42 CST(-0600)] <justin_o> Bosmon2: i think, if everyone else agrees, that you can just fix the DMB test to make it pass...
[13:32:44 CST(-0600)] <colinclark> heidi_: I pushed FLUID-4074, too
[13:32:53 CST(-0600)] <heidi_> tanks
[13:32:56 CST(-0600)] <justin_o> at least then we can tests that the underlying code is functioning
[13:32:59 CST(-0600)] <colinclark> justin_o and anastasiac: Heidi's two bugs are now fixed in the project repository
[13:33:07 CST(-0600)] <justin_o> colinclark: thanks
[13:33:13 CST(-0600)] <justin_o> i'll rebuild
[13:33:13 CST(-0600)] <anastasiac> thanks, colinclark
[13:33:28 CST(-0600)] <colinclark> justin_o: Are we still Gallery free at this point?
[13:33:45 CST(-0600)] <justin_o> colinclark: i think so.. i'll try running it again
[13:34:11 CST(-0600)] <anastasiac> heidi_, do you want to resolve 4074 and 4075? I'll confirm, and close
[13:34:23 CST(-0600)] <heidi_> anastasiac sure thang
[13:34:59 CST(-0600)] <heidi_> anastasiac done
[13:35:07 CST(-0600)] <anastasiac> thanks
[13:35:08 CST(-0600)] <Bosmon2> justin_o: OK
[13:35:29 CST(-0600)] <colinclark> jhung: Can you tell me again about the file limit issues you're seeing?
[13:38:08 CST(-0600)] <jhung> colinclark: In FF3.6, I can queue a file that is 22MB. In IE8, selecting the same file results in the file not appearing in the queue.
[13:38:15 CST(-0600)] <colinclark> ok
[13:38:25 CST(-0600)] <colinclark> I think this is actually a known issue
[13:38:25 CST(-0600)] <justin_o> harriswong: did you make a jira for the first failed unit test you found?
[13:38:39 CST(-0600)] <justin_o> Bosmon2: we need a blocker for the issue if harriswong didn't file one yet
[13:38:46 CST(-0600)] <colinclark> There seems to be a default upload limit set on the uploader of around 20 Mb
[13:39:03 CST(-0600)] <colinclark> I have no idea why, and I wonder if it is really not a very good default...
[13:39:07 CST(-0600)] <harriswong> justin_o: no i haven't
[13:39:10 CST(-0600)] <colinclark> Another example of ancient history
[13:39:26 CST(-0600)] <colinclark> jhung: You seem to be seeing a different in file limits between Flash and HTML5
[13:39:32 CST(-0600)] <colinclark> and I vaguely remember a bug about this from 1.3
[13:39:54 CST(-0600)]