fluid-work IRC Logs-2008-11-27

[00:39:15 EST(-0500)] * apetro (n=apetro@ip68-3-207-51.ph.ph.cox.net) has joined #fluid-work
[09:08:05 EST(-0500)] * colinclark (n=colin@bas1-toronto09-1279621226.dsl.bell.ca) has joined #fluid-work
[09:15:21 EST(-0500)] * jacobfarber1 (n=Main@CPE00095bc35ea1-CM001692f5798c.cpe.net.cable.rogers.com) has joined #fluid-work
[09:15:51 EST(-0500)] * Justin_o (n=Justin@142.150.154.101) has joined #fluid-work
[09:32:48 EST(-0500)] * anastasiac (n=team@142.150.154.160) has joined #fluid-work
[09:45:14 EST(-0500)] * clown (n=clown@guiseppi.atrc.utoronto.ca) has joined #fluid-work
[10:03:48 EST(-0500)] * colinclark (n=colin@bas1-toronto09-1279621226.dsl.bell.ca) has joined #fluid-work
[10:11:46 EST(-0500)] <anastasiac> jacobfarber1, could you put some time estimates on FLUID-1834/35/36 in JIRA?
[10:12:12 EST(-0500)] <anastasiac> sorry, never mind 1835 - it's resolved
[10:12:52 EST(-0500)] <jacobfarber1> its ok?
[10:13:27 EST(-0500)] <anastasiac> Don't know, haven't looked at it, but given that it's resolved, it doesn't need an estimate. If it's reopened, you can add one
[10:13:35 EST(-0500)] <anastasiac> but the other two do
[10:14:09 EST(-0500)] <anastasiac> I just want us to have a good idea of the work left for 0.6, so we need estimates on the JIRAs
[10:15:43 EST(-0500)] <jacobfarber1> i just updated them
[10:17:08 EST(-0500)] <jacobfarber1> anastasiac: for 1842, I think this (like the other skins) will be undergoing constant improvement....so the estimate I gave is a little useless
[10:17:22 EST(-0500)] <jacobfarber1> sorry, I meant 1836
[10:40:24 EST(-0500)] * apetro (n=apetro@ip68-3-207-51.ph.ph.cox.net) has joined #fluid-work
[11:05:07 EST(-0500)] * colinclark (n=colin@142.150.154.101) has joined #fluid-work
[11:35:26 EST(-0500)] * michelled (n=team@142.150.154.197) has joined #fluid-work
[11:35:47 EST(-0500)] * Topic is 'Happy American Thanksgiving!' set by michelled on 2008-11-27 11:35:47 EST(-0500)
[14:27:54 EST(-0500)] <colinclark> jacobfarber: You had an Uploader 2 question?
[14:27:57 EST(-0500)] <jacobfarber1> small question
[14:27:58 EST(-0500)] <jacobfarber1> yes
[14:28:09 EST(-0500)] <jacobfarber1> in the uploader springboard, I have 2 of them
[14:28:22 EST(-0500)] <jacobfarber1> the only selector diff is the container ID
[14:28:37 EST(-0500)] <jacobfarber1> so im trying to see how far I can go with the defaults
[14:28:48 EST(-0500)] <jacobfarber1> here's the problem:
[14:29:06 EST(-0500)] <colinclark> ok
[14:29:09 EST(-0500)] <jacobfarber1> on upload, the queue is updated on both uploaders
[14:29:21 EST(-0500)] <jacobfarber1> not just the one in focus
[14:29:33 EST(-0500)] <jacobfarber1> so is that a selector scoping issue?
[14:30:13 EST(-0500)] <jacobfarber1> or is it something I've done wrong?
[14:30:33 EST(-0500)] <anastasiac> it certainly sounds like a selector scoping issue
[14:30:36 EST(-0500)] <colinclark> wow
[14:30:39 EST(-0500)] <anastasiac> that shouldn't be happening
[14:30:46 EST(-0500)] <colinclark> yes, that sounds odd.
[14:30:49 EST(-0500)] <jacobfarber1> you see what im looking at?
[14:30:52 EST(-0500)] <colinclark> I'm so glad you're making this springboard!
[14:30:56 EST(-0500)] <jacobfarber1>
[14:31:00 EST(-0500)] <jacobfarber1> there is another q
[14:31:32 EST(-0500)] <jacobfarber1> but this is something we've talked about before, but im just not 100% comfortable with the current implementation (if that makes any sense)
[14:31:39 EST(-0500)] <colinclark> ok
[14:31:40 EST(-0500)] <jacobfarber1> its the file queue rows
[14:31:43 EST(-0500)] <colinclark> yes
[14:31:49 EST(-0500)] <jacobfarber1> our default is
[14:31:52 EST(-0500)] <colinclark> Tell me about your discomfort.
[14:31:53 EST(-0500)] <colinclark>
[14:31:56 EST(-0500)] <jacobfarber1> "tr:not(#queue-row-tmplt)"
[14:32:01 EST(-0500)] <colinclark> yep
[14:32:02 EST(-0500)] <jacobfarber1> why not something like
[14:32:28 EST(-0500)]

[14:32:42 EST(-0500)] <jacobfarber1> whereas you dont need to worry about the tag type?
[14:32:57 EST(-0500)] <colinclark> jacobfarber: That's exactly how it's handled at the moment.
[14:33:11 EST(-0500)] <jacobfarber1> sorry, im looking at http://wiki.fluidproject.org/display/fluid/Uploader2+API
[14:33:12 EST(-0500)] <colinclark> Eli found that performance was significantly reduced using this strategy.
[14:33:26 EST(-0500)] <jacobfarber1> really?
[14:33:36 EST(-0500)] <colinclark> Apparently so, yes. I didn't see the actual numbers.
[14:33:47 EST(-0500)] <jacobfarber1> i changed it locally, didnt get anything different
[14:34:02 EST(-0500)] <colinclark> This is exactly the sort of reason why you might choose to actually customize the default selectors according to your own markup.
[14:34:04 EST(-0500)] <jacobfarber1> pretty sweet component overall
[14:34:14 EST(-0500)] <jacobfarber1> yes
[14:34:16 EST(-0500)] <colinclark> The defaults need to strike a balance between performance and flexibility...
[14:34:26 EST(-0500)] <jacobfarber1> but im trying to see how flexible we can be
[14:34:28 EST(-0500)] <colinclark> where we hit the limit on that, you can always pass in your own selector.
[14:34:34 EST(-0500)] <colinclark> Do you know how to do that?
[14:34:37 EST(-0500)] <jacobfarber1> yes
[14:34:41 EST(-0500)] <colinclark> Yes, it's good to see how flexible we can be.
[14:34:41 EST(-0500)] <jacobfarber1> im trying not to though
[14:34:46 EST(-0500)] <colinclark>
[14:35:01 EST(-0500)] <jacobfarber1> we should investigate this like michelle and i did the seek and destroy stuff
[14:35:17 EST(-0500)] <jacobfarber1> b/c i really dont get a penaly locally, even with a horrible selector
[14:35:23 EST(-0500)] <jacobfarber1> *penalty
[14:35:27 EST(-0500)] <colinclark> this is interesting.
[14:35:32 EST(-0500)] <colinclark> I wonder how Eli decided it was too slow.
[14:35:43 EST(-0500)] <jacobfarber1> im really not sure
[14:35:53 EST(-0500)] <colinclark> We should probably chat with him next week about the performance. Let me look up what he said and see if there were any insights.
[14:35:55 EST(-0500)] <jacobfarber1> but i dont have it scoped to a tr, and its still sweet
[14:36:02 EST(-0500)] <jacobfarber1> ok
[14:36:05 EST(-0500)] <colinclark> Even with a large queue?
[14:36:07 EST(-0500)] <jacobfarber1> that would be helpful
[14:36:15 EST(-0500)] <jacobfarber1> i can try with a huge one
[14:36:18 EST(-0500)] <jacobfarber1> we'll see
[14:36:57 EST(-0500)] <jacobfarber1> thanks for the help!
[14:37:00 EST(-0500)] <colinclark> try with a huge one, yes
[14:37:04 EST(-0500)] <colinclark> lemme know how it goes
[14:37:08 EST(-0500)] <jacobfarber1> will do
[14:37:30 EST(-0500)] <jacobfarber1> i will actually benchmark it for everyone
[14:38:11 EST(-0500)] <jacobfarber1> hehehe
[14:38:23 EST(-0500)] <jacobfarber1> so no selecting 1070 images, just FYI
[14:50:47 EST(-0500)] * michelled (n=team@142.150.154.197) has joined #fluid-work
[14:50:47 EST(-0500)] * colinclark (n=colin@142.150.154.101) has joined #fluid-work
[14:50:47 EST(-0500)] * apetro (n=apetro@ip68-3-207-51.ph.ph.cox.net) has joined #fluid-work
[14:50:47 EST(-0500)] * clown_afk (n=clown@guiseppi.atrc.utoronto.ca) has joined #fluid-work
[14:50:47 EST(-0500)] * anastasiac (n=team@142.150.154.160) has joined #fluid-work
[14:50:47 EST(-0500)] * Justin_o (n=Justin@142.150.154.101) has joined #fluid-work
[14:50:47 EST(-0500)] * jacobfarber1 (n=Main@CPE00095bc35ea1-CM001692f5798c.cpe.net.cable.rogers.com) has joined #fluid-work
[14:50:47 EST(-0500)] * lessthanzero (n=FatalRem@CPE001ff342457c-CM001ac352aefc.cpe.net.cable.rogers.com) has joined #fluid-work
[14:55:23 EST(-0500)] <michelled> jacobfarber1: I just sent a message to the list explaining FLUID-1842
[14:56:34 EST(-0500)] <michelled> hopefully it provides everyone with an overview of what UI Options will eventually become
[15:00:20 EST(-0500)] <jacobfarber1> i just saw it
[15:00:27 EST(-0500)] <jacobfarber1> thanks
[15:00:46 EST(-0500)] <jacobfarber1> michelled: sorry for the delayed response
[15:03:35 EST(-0500)] <michelled> np
[15:03:43 EST(-0500)] <michelled> that's the nature of IRC
[15:03:46 EST(-0500)] <michelled>
[15:05:42 EST(-0500)] <jacobfarber1> michelled, colinclark, anastasiac: so I ran some benchmarks....
[15:06:08 EST(-0500)] <jacobfarber1> here was my code to test selector speed
[15:06:23 EST(-0500)] <jacobfarber1> (function (){
[15:06:23 EST(-0500)] <jacobfarber1> var rows, start, end;
[15:06:23 EST(-0500)] <jacobfarber1> start = new Date().getTime();
[15:06:23 EST(-0500)] <jacobfarber1> for (var i=0; i<=99; i++){
[15:06:23 EST(-0500)] <jacobfarber1> rows = $("tr:not(#queue-row-tmplt)","#simple_uploader");
[15:06:24 EST(-0500)] <jacobfarber1> }
[15:06:26 EST(-0500)] <jacobfarber1> end = new Date().getTime();
[15:06:28 EST(-0500)] <jacobfarber1> console.log(end-start, rows);
[15:06:30 EST(-0500)] <jacobfarber1> })();
[15:06:55 EST(-0500)] <jacobfarber1> and the results were like Colin and Eli mentioned, with a twist
[15:08:11 EST(-0500)] <jacobfarber1> the existing row selector $("tr:not(#queue-row-tmplt)" return 2 extra items that were unwanted
[15:08:28 EST(-0500)] <jacobfarber1> but with an overall time that was 3.3 x faster than
[15:08:35 EST(-0500)] <jacobfarber1> a more flexible selector such as
[15:08:43 EST(-0500)] <jacobfarber1> $(".row","#simple_uploader")
[15:09:00 EST(-0500)] <jacobfarber1> in the real world scenario
[15:09:30 EST(-0500)] <jacobfarber1> where we're not running the same selector 100x over, for a queue of 30 pictures
[15:09:46 EST(-0500)] <jacobfarber1> this meant the curent selector got 32 items in 1.5 ms
[15:10:06 EST(-0500)] <jacobfarber1> and the other selector got 30 items in 4ms or so
[15:12:21 EST(-0500)] <jacobfarber1> so, do you guys feel the speed gain is worth prefixing it with a tag?
[15:16:36 EST(-0500)] <colinclark> wow
[15:16:37 EST(-0500)] <colinclark> sorry
[15:16:40 EST(-0500)] <colinclark> we've been distracted
[15:23:33 EST(-0500)] <colinclark> jacobfarber1: I guess in part it's a question of user perception.
[15:23:40 EST(-0500)] <colinclark> Does it feel slow?
[15:24:18 EST(-0500)] <colinclark> My sense from Eli was that he noticed it because it felt noticeably slower.
[15:24:32 EST(-0500)] <colinclark> Anyway, I hate to run but I've got a rehearsal in 6 minutes
[15:24:32 EST(-0500)] <colinclark>
[18:46:03 EST(-0500)] * phiggins (n=dante@c-68-34-199-67.hsd1.tn.comcast.net) has joined #fluid-work