fluid-work IRC Logs-2011-01-31

Owned by Fluid IRC Log Bot
Last updated: Jan 31, 2011Version comment
16 min read

[08:33:07 CST(-0600)] <jhung> jameswy: ping
[08:33:13 CST(-0600)] <jameswy> jhung: pong
[08:33:36 CST(-0600)] <jhung> You have time this morning to go over the observations from Builder Walkthrus?
[08:34:13 CST(-0600)] <jameswy> jhung: Absolutely. When would you like to chat?
[08:34:40 CST(-0600)] <jhung> jameswy: as soon as possible. There's a bit of information and some good ideas to discuss.
[08:35:39 CST(-0600)] <jameswy> jhung: Sure--ring me in 10 minutes? Just finishing up a couple of emails.
[08:36:09 CST(-0600)] <jhung> Sure. Just finishing up the notes anyway. I'll ping you.
[08:51:44 CST(-0600)] <jhung> jameswy: ping you in 5mins?
[08:52:44 CST(-0600)] <jameswy> jhung: Sure
[10:39:50 CST(-0600)] <jhung> anastasiac, jameswy: let me know when you're going to talk about documentation.
[10:42:53 CST(-0600)] <anastasiac> jhung, will do. likely later today, or tomorrow
[10:45:40 CST(-0600)] <jhung> anastasiac: okay. I'd like to talk about demo portal stuff anyway. Doesn't have to be in the same conversation.
[10:45:50 CST(-0600)] <jhung> let me know if you have time today to chat about that.
[11:40:42 CST(-0600)] <anastasiac> jameswy, jhung: I've just emailed the list about two new mind-maps posted to the wiki. These will be the basis for the new IA for the docs, so please let me know if you have any thoughts.
[12:08:56 CST(-0600)] <jhung> anastasiac: thanks! I'll take a look at those shortly.
[13:13:42 CST(-0600)] <jhung> ping anastasiac.
[13:13:52 CST(-0600)] <anastasiac> jhung, pong
[13:14:02 CST(-0600)] <jhung> Do you have time to chat?
[13:14:18 CST(-0600)] <anastasiac> sure
[13:14:37 CST(-0600)] <anastasiac> in irc, or skype?
[13:14:50 CST(-0600)] <anastasiac> jhung ^
[13:15:12 CST(-0600)] <jhung> anastasiac, skype is easier I think.
[13:59:19 CST(-0600)] <colinclark> mlam: I missed a message from you this morning
[13:59:25 CST(-0600)] <colinclark> About a JIRA ticket or something?
[14:00:08 CST(-0600)] <mlam> Oh right. I was going to see if you wanted me to take FLUID-3999 from you (Disabling the Add More button while uploading)
[14:00:40 CST(-0600)] <mlam> I've been poking around some just to see if there was something i could do about it, but still no luck.
[14:03:48 CST(-0600)] <colinclark> Ok
[14:03:55 CST(-0600)] <colinclark> If you're stuck, I can take a look at it
[14:04:02 CST(-0600)] <colinclark> though I'm happy for you to take it on, too
[14:04:03 CST(-0600)] <colinclark> either way
[14:04:22 CST(-0600)] <colinclark> How did it go with looking at unit testing for the XHR code in the HTML5 remote object?
[14:06:13 CST(-0600)] <mlam> I had a question about MockJax. If it's a plain mock ajax request, will it still carry the onreadystate listener?
[14:10:32 CST(-0600)] <colinclark> My memory of MockJax was that it was actually mocking jQuery's ajax() method, no?
[14:10:44 CST(-0600)] <colinclark> Seems to me that we couldn't use it, anyway
[14:10:58 CST(-0600)] <mlam> and in terms of FLUID-3999, I've disabled anything and everything within the browseButtonView , yet the "Add More" button can still be activated by the mouse and keyboard. I can still keep poking around with it some more though.
[14:11:44 CST(-0600)] <colinclark> You'll probably be less frustrated and more productive looking at something else
[14:11:52 CST(-0600)] <colinclark> testing or another one of the blockers/criticals
[14:11:57 CST(-0600)] <colinclark> I found 3999 pretty frustrating (wink)
[14:12:27 CST(-0600)] <mlam> colinclark: I also thought about testing the order of events for synchronous uploading, but i'm not sure if that would be useful.
[14:12:45 CST(-0600)] <mlam> FLUID-3999 is the last blocker
[14:13:16 CST(-0600)] <colinclark> I think there are some good criticals to pick up
[14:13:25 CST(-0600)] <colinclark> Tell me more about what you mean in terms of testing the order of events
[14:13:48 CST(-0600)] <mlam> criticals for the uploader? or for other components?
[14:14:49 CST(-0600)] <mlam> In a case where we are uploading 2 files, we ensure that the onFileComplete event is fired before the next onFileStart event is fired.
[14:15:12 CST(-0600)] <colinclark> criticals for the uploader
[14:15:20 CST(-0600)] <colinclark> mlam: That makes a lot of sense to me
[14:15:33 CST(-0600)] <colinclark> but again, you'll need to mock up an XHR
[14:16:10 CST(-0600)] <mlam> Yah
[14:20:33 CST(-0600)] <mlam> colinclark: I think we've knocked off all the criticals for the upcoming 1.3.1 release
[14:20:42 CST(-0600)] <colinclark> Really?
[14:21:06 CST(-0600)] <colinclark> Wow, I'm way behind
[14:21:10 CST(-0600)] <colinclark> let me take a look at the filter
[14:22:01 CST(-0600)] <colinclark> Why not start on FLUID-3900?
[14:22:28 CST(-0600)] <colinclark> And then dive into expanding Uploader test coverage as much as you can
[14:23:18 CST(-0600)] <mlam> Ok, sure
[14:29:21 CST(-0600)] <colinclark> hey heidi_
[14:29:25 CST(-0600)] <colinclark> a quick question for you
[14:29:27 CST(-0600)] <colinclark> if you have time
[14:29:30 CST(-0600)] <heidi_> yep shoot
[14:29:51 CST(-0600)] <colinclark> How come you chose to rename the table scrolling styles for the FSS?
[14:30:00 CST(-0600)] <colinclark> You used to have them as fl-table-scrollable-*
[14:30:05 CST(-0600)] <colinclark> and now they're fl-scrollableTable-*
[14:30:14 CST(-0600)] <heidi_> because fss was fl-thing
[14:30:35 CST(-0600)] <heidi_> and the thing is specifically a scrollableTable
[14:31:11 CST(-0600)] <heidi_> and then -container and -scrollable seemed more obvious
[14:31:32 CST(-0600)] <colinclark> ok
[14:31:37 CST(-0600)] <colinclark> So, a question
[14:31:47 CST(-0600)] <colinclark> What if the FSS were to add some new table-related styles in the future?
[14:32:11 CST(-0600)] <colinclark> Would this change be sort of weird, in that we would probably have fl-table-foo styles as well as fl-scrollableTable-*?
[14:32:44 CST(-0600)] <heidi_> mm, thinking...
[14:32:50 CST(-0600)] <colinclark> I guess I'm wondering if there's a kind of namespacing in the FSS that we should follow
[14:32:54 CST(-0600)] <heidi_> what would foo be?
[14:33:04 CST(-0600)] <colinclark> Who knows?
[14:33:08 CST(-0600)] <colinclark> I don't think it really matters
[14:33:16 CST(-0600)] <colinclark> but we could make something up to illustrate the argument
[14:33:36 CST(-0600)] <colinclark> the point being, if we introduce any table-related styles into the FSS, wouldn't we want to nest them inside an fl-table "namespace/"
[14:33:39 CST(-0600)] <colinclark> ?
[14:33:55 CST(-0600)] <heidi_> right... thinking
[14:34:34 CST(-0600)] <heidi_> colinclark yeah that might be better
[14:34:56 CST(-0600)] <colinclark> I mean, you could argue that these are the styles for the fluid.scrollableTable component
[14:34:59 CST(-0600)] <colinclark> and so the naming is apt
[14:35:20 CST(-0600)] <colinclark> But we might equally argue that there's nothing specific to the scrollableTable about these styles
[14:35:35 CST(-0600)] <colinclark> anyone can use them, regardless of whether they use our little convenience function or not
[14:35:52 CST(-0600)] <colinclark> which makes me think maybe the original naming scheme was pretty good
[14:37:02 CST(-0600)] <heidi_> yeah the matching with the component name wasn't why i did it... i think it was to simplify 'thing' but maybe it really doesn't simplify.
[14:37:48 CST(-0600)] <heidi_> what was .fl-scrollableTable-scrollable before? fl-table-scrollable-area ?
[14:38:22 CST(-0600)] <colinclark> yep
[14:39:15 CST(-0600)] <heidi_> okay, let's switch it back. it leaves it more open
[14:39:21 CST(-0600)] <heidi_> sorry about that
[14:40:14 CST(-0600)] <heidi_> -area seems vague to me maybe
[14:41:17 CST(-0600)] <heidi_> once you figure out '-scrollable' is part of the 'thing' -area seems kinda lost
[14:43:34 CST(-0600)] <heidi_> reading http://wiki.fluidproject.org/display/fluid/Class+Name+Conventions
[14:43:45 CST(-0600)] <colinclark_> ack, sorry
[14:43:49 CST(-0600)] <colinclark_> my network connection just totally died
[14:43:51 CST(-0600)] <colinclark_> for no reason
[14:44:08 CST(-0600)] <colinclark> heidi_: I can see how -area might be a bit confusing
[14:44:13 CST(-0600)] <colinclark> any other ideas for a name?
[14:44:36 CST(-0600)] <heidi_> fl-table-scrollable ...-scrollable is too weird myabe
[14:44:48 CST(-0600)] <heidi_> fl-table-scrollable-scroll ?
[14:44:50 CST(-0600)] <heidi_> hm
[14:46:12 CST(-0600)] <colinclark> that seems okay
[14:46:19 CST(-0600)] <colinclark> fl-table-scrollable-scroll
[14:46:51 CST(-0600)] <heidi_> i was just feeling that 'thing' should be one piece
[14:47:04 CST(-0600)] <heidi_> but actually scrollable is a role
[14:47:08 CST(-0600)] <heidi_> so it's cool
[14:47:28 CST(-0600)] <heidi_> scroller?
[14:48:38 CST(-0600)] <colinclark> can you show me in long form?
[14:51:44 CST(-0600)] <heidi_> fl-table-scrollable-container & fl-table-scrollable-scroller
[14:53:02 CST(-0600)] <heidi_> or scroll. what do you think
[14:59:45 CST(-0600)] <colinclark> heidi_: I'm fine with either
[14:59:50 CST(-0600)] <colinclark> anastasiac: You're good at names
[14:59:53 CST(-0600)] <colinclark> These new FSS styles:
[15:00:05 CST(-0600)] <colinclark> We have two required elements, both of which wrap a table
[15:00:11 CST(-0600)] <colinclark> The first is just a dumb wrapper
[15:00:22 CST(-0600)] <colinclark> the second represents the element that is actually scrollable
[15:00:43 CST(-0600)] <colinclark> thoughts on either of heidi_'s suggestions, or alternatives?
[15:00:54 CST(-0600)] * anastasiac muses
[15:01:23 CST(-0600)] <anastasiac> the scroller is inside the container?
[15:01:28 CST(-0600)] <heidi_> yep
[15:02:11 CST(-0600)] <anastasiac> the names makes sense to me - I saw them before I read colinclark's description, and my first assumption was that the scroller was inside the container; "container" has that sense to it
[15:02:19 CST(-0600)] <anastasiac> these are only for tables?
[15:02:30 CST(-0600)] <anastasiac> the scroller can't be used for something else?
[15:02:42 CST(-0600)] <heidi_> just for tables.... it makes the thead fixed and tbody scrollable
[15:02:57 CST(-0600)] <heidi_> and it's done this sort of weird way with wrapper divs for cross-browser support
[15:02:58 CST(-0600)] <colinclark> yep
[15:03:14 CST(-0600)] <colinclark> ordinary things, you'd just set a fixed height and set the overflow on the element and you're done
[15:03:23 CST(-0600)] <anastasiac> well, I think fl-table-scrollable-container & fl-table-scrollable-scroller make sense to me
[15:03:32 CST(-0600)] <heidi_> thanks anastasiac !
[15:03:38 CST(-0600)] <anastasiac> pretty self-explanatory
[15:05:06 CST(-0600)] <colinclark> heidi_: Can you whip up a new patch for me, just so I don't make any mistakes accidentally?
[15:05:29 CST(-0600)] <heidi_> colinclark sure
[15:05:39 CST(-0600)] <colinclark> Thanks, sorry for the extra work
[15:05:48 CST(-0600)] <colinclark> I like the patch otherwise, it's good
[15:05:52 CST(-0600)] <mlam> colinclark: we want to keep the behaviour of the SWF uploader's stop functionality the same, right? FLUID-3900 should only apply to the HTML5 uploader?
[15:06:00 CST(-0600)] <colinclark> mlam: I dunno
[15:06:10 CST(-0600)] <colinclark> Find out what SWFUpload does when you try to interrupt it in mid-flow
[15:06:19 CST(-0600)] <colinclark> If it doesn't explode, then we want it to apply everywhere
[15:06:30 CST(-0600)] <colinclark> if it explodes, then yes, only to the HTML 5 version
[15:06:37 CST(-0600)] <mlam> there's a comment in the code, claiming that the SWF uploader does in fact explode.
[15:06:55 CST(-0600)] <mlam> Ok, cool
[15:07:00 CST(-0600)] <colinclark> mlam: This is the problem with comments in code
[15:07:10 CST(-0600)] <colinclark> You never know if they're right or not
[15:07:12 CST(-0600)] <mlam> legacy?
[15:07:14 CST(-0600)] <mlam> right
[15:07:20 CST(-0600)] <colinclark> especially if they don't specify a particular version (smile)
[15:07:27 CST(-0600)] <mlam> ok, gotcha
[15:07:28 CST(-0600)] <colinclark> For the record, it could well have been me who wrote said comment (tongue)
[15:07:58 CST(-0600)] <colinclark> This is sort of like the "owning it" thing I was talking to Heidi about the other day--question everything in the Uploader. It needs it.
[15:08:04 CST(-0600)] <mlam> I'll verify the truth to that comment anyways (smile)
[15:08:21 CST(-0600)] <colinclark> wicked (smile)
[15:08:43 CST(-0600)] <jamon> ping fluid-everyone: hoping to freeze svn tomorrow or wed., anyone object to tomorrow?
[15:09:31 CST(-0600)] <colinclark> jamon: How are we doing on the Git migration?
[15:09:37 CST(-0600)] <colinclark> All the issues worked out now?
[15:09:49 CST(-0600)] <jamon> colinclark: staging everything here: https://github.com/jobara/
[15:09:55 CST(-0600)] <jamon> take a look around
[15:10:10 CST(-0600)] <colinclark> wow, look at all that *-temp
[15:10:12 CST(-0600)] <colinclark> exciting
[15:10:18 CST(-0600)] <jamon> that will all change of course once we do the final conversion after freezing
[15:10:24 CST(-0600)] <colinclark> for sure
[15:10:36 CST(-0600)] <colinclark> Looks like michelled
[15:10:41 CST(-0600)] <colinclark> 's name didn't get mapped, maybe?
[15:11:04 CST(-0600)] <jamon> hmm, Justin_o was wondering about joseph as well
[15:11:11 CST(-0600)] <jamon> we'll investigate
[15:11:18 CST(-0600)] <colinclark> this is so exciting
[15:11:22 CST(-0600)] <colinclark> okay, so in terms of freezing
[15:11:32 CST(-0600)] <jamon> michelled, clown, what email addresses did you use for github? ping Justin_o or me via idrc chat
[15:11:34 CST(-0600)] <colinclark> heidi_, mlam, golam: You're all working with patches at the moment, right?
[15:11:42 CST(-0600)] <mlam> Yes
[15:11:48 CST(-0600)] <colinclark> harriswong: You too, right?
[15:11:52 CST(-0600)] <clown> jamon, looking...
[15:11:54 CST(-0600)] <golam> colinclark: yes
[15:12:01 CST(-0600)] <heidi_> yep
[15:12:09 CST(-0600)] <colinclark> anastasiac and michelled: You're not working on any in-progress code at the moment, right?
[15:12:12 CST(-0600)] <mlam> It's ok though, I can just make my final checkout tonight before i leave so i'm caught up with trunk. My patch should be pretty isolated anyways
[15:12:23 CST(-0600)] <harriswong> colinclark: yep, working on tests
[15:12:26 CST(-0600)] <anastasiac> colinclark, nope
[15:12:49 CST(-0600)] <colinclark> Bosmon: You're the only one with a live branch at the moment, I believe
[15:13:45 CST(-0600)] <colinclark> I shouldn't have any trouble picking up the patches from heidi_, harriswong, golam, and mlam and just applying them to a Git repo instead of committing them to SVN, so we're cool there.
[15:14:04 CST(-0600)] <colinclark> I think the only person we should be concerned about in terms of freezing is Bosmon, and I know he's super-keen to just do the switch
[15:14:17 CST(-0600)] <michelled> colinclark: I am but I'll make a patch and apply it on git after the move
[15:14:32 CST(-0600)] <michelled> I'm sort of writing a line of code here and there
[15:14:33 CST(-0600)] <colinclark> So, let's assume that if we don't hear anything from Bosmon in the next little while that either tomorrow or Wednesday are fine, jamon and Justin_o. Seem cool?
[15:14:39 CST(-0600)] <colinclark> michelled: Cool, you're lucky
[15:14:41 CST(-0600)] <colinclark> what are you coding?
[15:14:59 CST(-0600)] <michelled> dynamic reorderer test so I ditch the manual test
[15:15:02 CST(-0600)] <colinclark> ah, nice
[15:15:04 CST(-0600)] <justin_o_> colinclark: thanks
[15:15:08 CST(-0600)] <jamon> we're good for tomorrow if possible then colinclark, and wed. if Bosmon is in the midst of a big patch/merge
[15:15:16 CST(-0600)] <justin_o_> michelled: could you let me know what e-mail you used to sign up to github with..
[15:15:29 CST(-0600)] <colinclark> jamon: Let's assume tomorrow
[15:15:30 CST(-0600)] <justin_o_> i think that could be why it didn't map to your github account
[15:15:37 CST(-0600)] <jamon> excellent
[15:15:41 CST(-0600)] <colinclark> ooh, look, you've even got some little branches in here
[15:15:44 CST(-0600)] <colinclark> mfss-firefox!
[15:15:45 CST(-0600)] <colinclark> (smile)
[15:16:05 CST(-0600)] <jamon> justin_o_ claims he will work on that soon (wink)
[15:16:48 CST(-0600)] <colinclark> justin_o_ / jamon: Can you explain the different tags? Seems like we have, in some cases, multiple tags with the same version but a revision number at the end
[15:17:02 CST(-0600)] <jamon> colinclark: we're about to delete those
[15:17:05 CST(-0600)] <Bosmon> colinclark: You're referring to my kettle branch?
[15:17:10 CST(-0600)] <colinclark> ah, okay jamon
[15:17:13 CST(-0600)] <colinclark> Bosmon: Yepper
[15:17:17 CST(-0600)] <Bosmon> I'm happy to migrate that over separately later
[15:17:22 CST(-0600)] <Bosmon> We shouldn't hold up the main migration for that
[15:17:24 CST(-0600)] <colinclark> okay
[15:17:38 CST(-0600)] <colinclark> So, SVN'll freeze sometime tomorrow
[15:17:49 CST(-0600)] <jamon> got it
[15:18:02 CST(-0600)] <colinclark> I think it would be a good idea for everyone to have a peek at the new repositories for jamon and justin_o_ and make sure they all look good
[15:18:43 CST(-0600)] <colinclark> Github's paging isn't super awesome (sad)
[15:18:58 CST(-0600)] <jamon> colinclark: do a git clone on the repositories then (wink)
[15:19:34 CST(-0600)] <Bosmon> I wonder if github is written in PHP
[15:19:38 CST(-0600)] <Bosmon> It is so damn slow a lot of the time
[15:21:05 CST(-0600)] <jamon> osx users might prefer gitx if gui is a requirement: http://gitx.frim.nl/seeit.html
[15:22:32 CST(-0600)] <colinclark> Bosmon: It's a Rails app
[15:22:41 CST(-0600)] <colinclark> http://en.wikipedia.org/wiki/GitHub
[15:23:42 CST(-0600)] <jamon> they're running nginx for http servers at least
[15:24:27 CST(-0600)] <heidi_> i see You do not have access to any of this organization's repositories (or there aren't any).
[15:24:48 CST(-0600)] <jamon> heidi_: url?
[15:25:00 CST(-0600)] <colinclark> This is super exciting
[15:25:02 CST(-0600)] <heidi_> do i have to pull a repos ?
[15:25:06 CST(-0600)] <heidi_> colinclark that patch is up btw
[15:25:11 CST(-0600)] <colinclark> thanks heidi_
[15:25:13 CST(-0600)] <heidi_> jamon just https://github.com/organizations/fluid-project when i login
[15:25:29 CST(-0600)] <heidi_> but i think i have to do something to see it?
[15:25:44 CST(-0600)] <jamon> heidi_: if you want to check stuff not using the website, do git clone first, using a repository from https://github.com/jobrara/
[15:26:08 CST(-0600)] <jamon> heidi_: right now we're staging things there before doing a final freeze and set of pushes to the fluid-project account
[15:26:47 CST(-0600)] <heidi_> maybe i should read more first, i have no idea what i'm doing ha
[15:27:39 CST(-0600)] <jamon> heidi_: lots to learn, i think i understand about 1/1000th of what's possible with git
[15:28:20 CST(-0600)] <jamon> heidi_: use the command line, like with svn, "git help foo", it has extensive built in documentation, also http://git-scm.com/documentation
[15:29:11 CST(-0600)] <colinclark> justin_o_: You've got a little typo in your group names for the organization
[15:29:21 CST(-0600)] <heidi_> jamon so when colin asked us to take a look at the new respos, the new repos is github.com/jobara ?
[15:29:46 CST(-0600)] <jamon> heidi_: yes, just to explore a bit, tomorrow we will switch to the other url you were using
[15:29:48 CST(-0600)] <heidi_> that url is a 404 for me, maybe i have to follow jobara
[15:29:49 CST(-0600)] <heidi_> ?
[15:29:58 CST(-0600)] <colinclark> heidi_: That's justin_o_'s page on Github
[15:30:02 CST(-0600)] <colinclark> and he has a bunch of repos there
[15:30:15 CST(-0600)] <heidi_> how do i make it not 404y
[15:30:35 CST(-0600)] <colinclark> it's a typo, heidi_
[15:30:37 CST(-0600)] <jamon> heidi_: https://github.com/jobara/
[15:30:48 CST(-0600)] <heidi_> jamon that doc link is good, thanks
[15:30:52 CST(-0600)] <heidi_> ah, duhh thanks
[15:31:16 CST(-0600)] <justin_o_> fluid-everyone: please look at all the repos at the link that jamon just sent out.. let us know if you see anything wrong
[15:31:56 CST(-0600)] <anastasiac> justin_o: "sent out" via email?
[15:32:43 CST(-0600)] <colinclark> anastasiac: https://github.com/jobara/
[15:32:51 CST(-0600)] <colinclark> without the extra "r"
[15:32:52 CST(-0600)] <colinclark> (smile)
[15:33:30 CST(-0600)] <colinclark> justin_o_: I guess we should do something about the VideoPlayer repo
[15:33:47 CST(-0600)] <colinclark> It seems fairly insane to be carrying around the sample videos in Git
[15:34:27 CST(-0600)] <colinclark> I'd be fine if you just toast them (and their history) and I will modify the VideoPlayer to do something a bit more sensible
[15:35:00 CST(-0600)] <justin_o_> colinclark: okay.. will do
[15:35:03 CST(-0600)] <anastasiac> justin_o_: the documentation repo contains code used for a workshop - should that go in the workshops repo?
[15:35:08 CST(-0600)] <colinclark> I guess we have the same problem for the media on the Engage site, justin_o_
[15:35:13 CST(-0600)] <justin_o_> anastasiac: which one is that?
[15:35:29 CST(-0600)] <justin_o_> colinclark: okay, but is that one more necessary or not.. since it is the actual site?
[15:35:30 CST(-0600)] <anastasiac> it's an autocomplete widget created for collectionspace
[15:35:46 CST(-0600)] <justin_o_> anastasiac: that was for a workshop?
[15:35:56 CST(-0600)] <anastasiac> according to the commit log, yes (smile)
[15:36:12 CST(-0600)] <colinclark> anastasiac: Don't you use snippets of that code all over the place in your IoC documention? (tongue)
[15:36:34 CST(-0600)] <anastasiac> yes, I do - but then we'd put all of Infusion in the documentation repo (smile)
[15:36:46 CST(-0600)] <anastasiac> point taken - I guess I'm just not clear on what the docs repo is intended for
[15:37:36 CST(-0600)] <colinclark> urg
[15:38:22 CST(-0600)] <colinclark> At this point, it's a place to put all the stuff from incubator and scratchpad that we wanted to keep alive in order to use it for documentation in the future
[15:38:39 CST(-0600)] <anastasiac> ah, excellent; ok, that clarifies
[15:39:20 CST(-0600)] <colinclark> I remember we chatted about this last week sometime
[15:39:26 CST(-0600)] <colinclark> can't find the relevant log at the moment
[15:39:50 CST(-0600)] <colinclark> But I can imagine we'll eventually have some kind of a branch of infusion that contains "on their way" bits of new sample code, examples, etc.
[15:40:43 CST(-0600)] <anastasiac> I do remember the chat - I was just thrown by the name, that's all.
[15:55:30 CST(-0600)] <colinclark> heidi_: Another question, now that I'm testing your patch
[15:55:37 CST(-0600)] <heidi_> yep
[15:55:48 CST(-0600)] <colinclark> How come you decided to create a separate demo for the scrollable table, as a opposed to including it in the existing fss-layout demo?
[15:57:09 CST(-0600)] <heidi_> colinclark i think because i don't like the fss layout demo, but that's not a great reason. i suppose it should be moved in
[15:57:20 CST(-0600)] <colinclark> It seems like a good place for it
[15:57:28 CST(-0600)] <colinclark> Why don't you like the FSS layout demo?
[15:58:06 CST(-0600)] <heidi_> colinclark the css tab is a nightmare
[15:58:27 CST(-0600)] <heidi_> it's hard to pick out what applies to what you want
[15:58:42 CST(-0600)] <colinclark> yeah, it is a bit weird
[15:59:01 CST(-0600)] <heidi_> for scrollable table, you have to set the container and column widths
[15:59:05 CST(-0600)] <heidi_> and that happens outside of fss
[15:59:11 CST(-0600)] <colinclark> right
[15:59:29 CST(-0600)] <colinclark> So, where in the FSS layout demo, the overrides are really just about the demo itself
[15:59:33 CST(-0600)] <colinclark> making it rainbow-y
[15:59:50 CST(-0600)] <colinclark> in this case, it really matters that you override these things
[16:00:03 CST(-0600)] <colinclark> unless you want, say, a 160px table, or whatever the default height is
[16:00:08 CST(-0600)] <heidi_> i just thought it was clearer
[16:00:14 CST(-0600)] <colinclark> I guess the other thing that nags at me with this demo is that it seems a bit unpolished
[16:00:16 CST(-0600)] <heidi_> and that fss-layout is messy
[16:00:20 CST(-0600)] <heidi_> the demo rather
[16:00:28 CST(-0600)] <colinclark> the scrollbar floats oddly to the right and it's pretty bare bones, stylistically
[16:00:45 CST(-0600)] <heidi_> screenshot?
[16:01:17 CST(-0600)] <heidi_> i like bare bones styling for styling demos
[16:01:24 CST(-0600)] <heidi_> or do you mean the content?
[16:02:24 CST(-0600)] <colinclark> Well, both
[16:02:37 CST(-0600)] <colinclark> I guess part of the goal for a demo is to have it look "hot"
[16:02:43 CST(-0600)] <colinclark> Desirable to the user
[16:02:56 CST(-0600)] <colinclark> Here's what I'm thinking, heidi_
[16:03:02 CST(-0600)] <colinclark> Why don't I go ahead and commit this
[16:03:09 CST(-0600)] <heidi_> we could add an fss theme to it
[16:03:23 CST(-0600)] <colinclark> and then maybe you can sit down with Jonathan and/or James to talk about how to take it to the next level
[16:03:31 CST(-0600)] <colinclark> You guys can talk over some of these core questions
[16:03:40 CST(-0600)] <colinclark> Should it be a separate demo? How should it look? What sort of content should it show?
[16:03:41 CST(-0600)] <colinclark> etc.
[16:03:57 CST(-0600)] <heidi_> ok
[16:04:20 CST(-0600)] <colinclark> I guess there's one other issue to think about
[16:04:33 CST(-0600)] <colinclark> there's no direct dependency between fluid.scrollableTable() and these FSS styles
[16:04:46 CST(-0600)] <colinclark> If you want a one line "set it up and forget," you can use scrollableTable()
[16:04:50 CST(-0600)] <colinclark> or you can just wrap your table and off you go
[16:04:57 CST(-0600)] <colinclark> This is, in the end, a really fairly trivial feature
[16:05:07 CST(-0600)] <colinclark> Both the FSS styles and the fluid.scrollableTable() don't do much
[16:05:13 CST(-0600)] <colinclark> so we don't really need to worry too much
[16:06:09 CST(-0600)] <colinclark> But these are questions we should be clear on, nonetheless
[16:11:59 CST(-0600)] <heidi_> colinclark i don't think the last patch included the link to it on the main demo page. forgot it when i remade
[16:12:14 CST(-0600)] <colinclark> ok
[16:13:00 CST(-0600)] <Bosmon> Oh, justin_o has gone
[16:13:12 CST(-0600)] <Bosmon> Just for reference folks, the answer to the question I asked the other day is "git describe"
[16:13:23 CST(-0600)] <Bosmon> Where the question was... "how do I tell which tag I have just checked out" (tongue)
[16:13:43 CST(-0600)] <Bosmon> I don't see a good reason why git status and git describe are two different commands
[16:13:45 CST(-0600)] <Bosmon> But there it is
[16:17:55 CST(-0600)] <colinclark> cool, Bosmon
[16:18:14 CST(-0600)] <colinclark> heidi_: So do you want to post a new patch, or just tell me the changes I should make?
[16:19:27 CST(-0600)] <colinclark> hey, by the way, Bosmon, I was thinking that we should drop support for Maven and the war build for an upcoming release
[16:19:30 CST(-0600)] <heidi_> colinclark on line 39 of demos/index.html could you add , <a href="fss/scrollableTable/demo.html">Scrollable Table</a> after the mobile link
[16:19:32 CST(-0600)] <colinclark> do you have any complaints about this idea?
[16:19:37 CST(-0600)] <colinclark> heidi_: Yep
[16:19:39 CST(-0600)] <heidi_> thanks
[16:32:25 CST(-0600)] <colinclark> heidi_: One other little bit of code review advice, looking at your scrollable table demo
[16:32:27 CST(-0600)] <colinclark> You do this:
[16:32:28 CST(-0600)] <colinclark> var scrollableTable = fluid.scrollableTable($("#demo-table"));
[16:32:53 CST(-0600)] <colinclark> You should be able to pass along anything "jQueryable" to scrollableTable()
[16:32:57 CST(-0600)] <colinclark> meaning, a selector is fine, too
[16:32:59 CST(-0600)] <colinclark> and a bit faster
[16:33:09 CST(-0600)] <colinclark> var scrollableTable = fluid.scrollableTable("irc://irc.freenode.net/#demo-table"(wink);
[16:33:19 CST(-0600)] <colinclark> eek, funny paste job there
[16:33:26 CST(-0600)] <heidi_> i was gonna say haha
[16:33:35 CST(-0600)] <heidi_> so what would be better?
[16:33:39 CST(-0600)] <colinclark> I guess my client thinks it's an IRC channel name
[16:33:46 CST(-0600)] <colinclark> Just the selector is faster
[16:33:54 CST(-0600)] <heidi_> ah
[16:34:02 CST(-0600)] <heidi_> ok
[16:34:08 CST(-0600)] <colinclark> simpler
[16:34:15 CST(-0600)] <colinclark> it all works
[16:34:21 CST(-0600)] <colinclark> you could pass almost anything in and it would work (smile)
[16:34:42 CST(-0600)] <heidi_> i thought it was expecting a jquery object
[16:34:49 CST(-0600)] <heidi_> but i'm obv misunderstanding something..