fluid-work IRC Logs-2010-07-19

Owned by Fluid IRC Log Bot
Last updated: Jul 19, 2010Version comment
5 min read

[03:44:02 CDT(-0500)] * kasper (~kasper@0x5552c030.adsl.cybercity.dk) has joined #fluid-work
[04:46:31 CDT(-0500)] * denbuzze (~anonymous@ginger.caret.cam.ac.uk) has joined #fluid-work
[07:34:24 CDT(-0500)] * Justin_o (~Justin@142.150.154.171) has joined #fluid-work
[07:42:15 CDT(-0500)] * jessm (~Jess@c-68-40-84-116.hsd1.mi.comcast.net) has joined #fluid-work
[07:56:56 CDT(-0500)] * anastasiac (~team@142.150.154.193) has joined #fluid-work
[08:04:57 CDT(-0500)] * sgithens (~sgithens@2001:18e8:3:443:223:aeff:fe01:c4d) has joined #fluid-work
[08:05:04 CDT(-0500)] * colinclark (~colin@bas2-toronto09-1176131242.dsl.bell.ca) has joined #fluid-work
[08:31:20 CDT(-0500)] * EricDalquist (~apollo@adsl-75-50-88-216.dsl.mdsnwi.sbcglobal.net) has joined #fluid-work
[08:31:46 CDT(-0500)] * EricDalquist (~apollo@adsl-75-50-88-216.dsl.mdsnwi.sbcglobal.net) has left #fluid-work
[08:46:05 CDT(-0500)] * jhung (~Jon@H233.C205.cci.switchworks.net) has joined #fluid-work
[08:47:44 CDT(-0500)] * clown (~clown@142.150.154.202) has joined #fluid-work
[09:09:16 CDT(-0500)] * athena (~athena@c-76-121-97-221.hsd1.wa.comcast.net) has joined #fluid-work
[09:45:54 CDT(-0500)] * michelled (~michelled@142.150.154.141) has joined #fluid-work
[09:52:40 CDT(-0500)] * mackrauss (~Armin@142.150.154.103) has joined #fluid-work
[09:53:03 CDT(-0500)] * mackrauss (~Armin@142.150.154.103) has left #fluid-work
[10:01:32 CDT(-0500)] * bsparks (~bsparks@wsip-72-215-204-133.ph.ph.cox.net) has joined #fluid-work
[10:27:11 CDT(-0500)] <colinclark> Justin_o: What's the latest with http://issues.fluidproject.org/browse/DECA-81?
[10:27:38 CDT(-0500)] <colinclark> I had implemented it last week, but were we going to change the size we wanted to make these images?
[10:29:42 CDT(-0500)] <Justin_o> colinclark: i changed it from 900 to 800 on friday
[10:29:52 CDT(-0500)] <colinclark> Ah, excellent
[10:29:58 CDT(-0500)] <colinclark> So does that means it can be resolved?
[10:30:16 CDT(-0500)] * yura_ (~yura@142.150.154.163) has joined #fluid-work
[10:30:19 CDT(-0500)] <Justin_o> colinclark: i think so
[10:30:29 CDT(-0500)] <colinclark> Cool
[10:30:38 CDT(-0500)] <colinclark> I see your change and, obviously, it looks good
[10:32:04 CDT(-0500)] <colinclark> Justin_o: I've marked it as resolved, and I guess it's due to be reviewed for the parade
[11:13:56 CDT(-0500)] * bsparks (~bsparks@wsip-72-215-204-133.ph.ph.cox.net) has joined #fluid-work
[11:16:28 CDT(-0500)] * elicochran (~elicochra@dhcp-169-229-212-70.LIPS.Berkeley.EDU) has joined #fluid-work
[11:31:07 CDT(-0500)] * colinclark (~colin@142.150.154.103) has joined #fluid-work
[11:46:20 CDT(-0500)] * michelled_ (~michelled@142.150.154.103) has joined #fluid-work
[11:46:30 CDT(-0500)] * jhung (~Jon@H233.C205.cci.switchworks.net) has joined #fluid-work
[11:49:58 CDT(-0500)] <Justin_o> jhung, colinclark: Okay so i've done a bit of investigation for DECA-54
[11:50:20 CDT(-0500)] <Justin_o> it is because on keydown the value of evt.ctrlKey is still false... on keyup it gets set to true
[11:50:36 CDT(-0500)] <colinclark> interesting
[11:53:02 CDT(-0500)] * mackrauss (~Armin@142.150.154.103) has joined #fluid-work
[11:53:22 CDT(-0500)] * mackrauss (~Armin@142.150.154.103) has left #fluid-work
[11:54:36 CDT(-0500)] <jhung> justin_o: What is your feeling on getting it fixed for this release?
[11:55:17 CDT(-0500)] <Justin_o> jhung: i'm not sure at the moment. The other issue is that it would be change in infusion.
[11:58:13 CDT(-0500)] <jhung> Justin_o: ah.
[11:58:51 CDT(-0500)] <jhung> justin_o: then I don't think it's worth fixing right now, but should be addressed after release so we're not trying to fix it during Deca 0.5 / 0.6
[12:00:15 CDT(-0500)] <Justin_o> jhung: that's a good point
[12:18:40 CDT(-0500)] * athena (~athena@c-76-121-97-221.hsd1.wa.comcast.net) has joined #fluid-work
[12:27:09 CDT(-0500)] <colinclark> jhung: Were you going to pastebin me your change to the stitching call?
[12:27:17 CDT(-0500)] <jhung> ah
[12:27:20 CDT(-0500)] <colinclark> I'll take a quick peek, and then we can just push it right to the master
[12:27:22 CDT(-0500)] <jhung> colinclark: forgot.
[12:27:25 CDT(-0500)] <colinclark> saves me some time (smile)
[12:27:31 CDT(-0500)] <colinclark> no worries, lots to do
[12:29:37 CDT(-0500)] * jhung1 (~decapod@H233.C205.cci.switchworks.net) has joined #fluid-work
[12:29:42 CDT(-0500)] <jhung1> colinclark: http://pastebin.com/1k6ewfYX
[12:38:42 CDT(-0500)] * jameswy (~jameswy@142.150.154.115) has joined #fluid-work
[12:43:30 CDT(-0500)] <colinclark> jhung: ah, this is awesome
[12:43:52 CDT(-0500)] <colinclark> you just made me realize that there is probably the last command still using os.system
[12:43:57 CDT(-0500)] * michelled (~michelled@142.150.154.141) has joined #fluid-work
[12:44:03 CDT(-0500)] <colinclark> I think I'll do a quick refactoring while I'm looking at it
[12:44:48 CDT(-0500)] <colinclark> Your code looks just fine, I'd just rather use Popen() ubiquitously
[12:45:04 CDT(-0500)] <jhung> colinclark: Cool.
[13:06:29 CDT(-0500)] * mackrauss (~Armin@87.91.194.91.static.giga-dns.com) has joined #fluid-work
[13:21:46 CDT(-0500)] * mackrauss_ (~Armin@142.150.154.103) has joined #fluid-work
[13:22:10 CDT(-0500)] * mackrauss_ (~Armin@142.150.154.103) has left #fluid-work
[13:47:10 CDT(-0500)] <Justin_o> colinclark, jhung: I was looking into DECA-54 a bit. So the problem is indeed that the ctrlKey property is not set to true on the event object. However, if another key is pressed at the same time it is updated to true, and if the ctrl key is pressed by itself its keycode is correct. So i can write a function that can test the event with a return that looks like return event.ctrlKey || event.keyCode === fluid.reorderer.keys.ctrl;
[13:47:38 CDT(-0500)] <Justin_o> This works for adding the styling but the issue of removing the styling still persists
[13:48:08 CDT(-0500)] <Justin_o> that last issue is that the drag styling doesn't remove itself on keyup of the ctrl key
[13:50:30 CDT(-0500)] <jhung> Justin_o: So it's only a 50% fix at the moment? Do we know if anyone else has encountered this and provided a fix? Feels like we're coding a work-around.
[13:50:49 CDT(-0500)] <jhung> Not sure if we like to maintain that kind of code.
[13:52:28 CDT(-0500)] <Justin_o> jhung: not sure... it is a bit of a workaround... basically it is just more specific... in that it should return the same value as before except that in the case where the ctrlKey property is not set to true, but the key is down, it will also be handeled
[13:52:41 CDT(-0500)] <Justin_o> the other half i'm not sure about
[13:52:47 CDT(-0500)] <Justin_o> being the removal of the style
[13:57:02 CDT(-0500)] <Justin_o> my guess... although i haven't yet verified this is that linux works opposite of the other os's in that on keydown ctrlKey is false and keyup ctrlKey is true... i'm guessing the other os's will do the inverse...
[14:01:17 CDT(-0500)] <Justin_o> colinclark, jhung: okay just did a quick test in firefox on macos and the keyup and keydown is opposite
[14:04:55 CDT(-0500)] <jhung> justin_o: Ok. So at this point we can fix for the keydown event, but not the keyup?
[14:10:49 CDT(-0500)] <colinclark> jhung: The new sample images look nice
[14:11:01 CDT(-0500)] <colinclark> And they are all correctly oriented, so I guess that confirms that stitching works with -Rnn
[14:11:08 CDT(-0500)] <colinclark> I will write a unit test to be completely sure
[14:11:20 CDT(-0500)] <colinclark> And the giant Export spinner is great!
[14:15:17 CDT(-0500)] <jhung> colinclark: That spinner is James' work. I agree, it looks good.
[14:32:26 CDT(-0500)] <Justin_o> jhung: well... actually i think the fix i was hypothesizing will end up causing all of the os's to display the error of removing the styling
[14:32:47 CDT(-0500)] <Justin_o> so i think it would be an all or nothing fix
[14:32:55 CDT(-0500)] <jhung> yikes.
[14:33:24 CDT(-0500)] <jhung> justin_o: then let's put it off until after release. We need to do a bit more digging I think.
[14:33:54 CDT(-0500)] <Justin_o> jhung: yah
[14:37:50 CDT(-0500)] <colinclark> jhung: I've just pushed a fix for DECA-50
[14:38:05 CDT(-0500)] <colinclark> Identical to yours except using Popen() instead of os.system() and with a unit test
[14:38:14 CDT(-0500)] <colinclark> Can you check that it looks good?
[14:39:53 CDT(-0500)] <colinclark> jhung: I've resolved it, so if it seems to work well, take a peek at the code to make sure it looks right and then we'll consider it reviewed for the bug parade
[14:40:15 CDT(-0500)] <jhung> colinclark: will do.
[14:40:21 CDT(-0500)] <colinclark> thanks, i appreciate it
[14:44:20 CDT(-0500)] * denbuzze (~anonymous@cpc1-cmbg7-0-0-cust61.cmbg.cable.ntl.com) has joined #fluid-work
[14:46:33 CDT(-0500)] * sgithens (~sgithens@149-166-10-223.dhcp-in.iupui.edu) has joined #fluid-work
[14:49:50 CDT(-0500)] <jhung> colinclark: confirmed fixed. Closed Deca-50.
[14:51:44 CDT(-0500)] <jhung> justin_o, jameswy, colinclark: my progress is slow on the test plan. I can use a hand if any of you have free cycles.
[15:04:27 CDT(-0500)] <Justin_o> jhung: sorry... i am just on my way out... you can send me an e-mail though and i'll take a look tomorrow morning
[15:06:48 CDT(-0500)] * Justin_o (~Justin@142.150.154.171) has left #fluid-work
[15:20:19 CDT(-0500)] * anastasiac (~team@142.150.154.193) has left #fluid-work
[17:37:34 CDT(-0500)] * bsparks1 (~bsparks@wsip-72-215-204-133.ph.ph.cox.net) has joined #fluid-work
[18:15:28 CDT(-0500)] * jhung (~Jon@H233.C205.cci.switchworks.net) has joined #fluid-work
[18:19:13 CDT(-0500)] * jhung (~Jon@H233.C205.cci.switchworks.net) has left #fluid-work
[19:00:18 CDT(-0500)] * jhung (~Jon@H233.C205.cci.switchworks.net) has joined #fluid-work
[20:02:54 CDT(-0500)] * EricDalquist (~apollo@adsl-75-50-88-216.dsl.mdsnwi.sbcglobal.net) has joined #fluid-work