fluid-work IRC Logs-2012-09-25

[08:56:35 CDT(-0500)] <kasper> good morning mr. JURA

[08:56:38 CDT(-0500)] <kasper> (yura)

[09:00:16 CDT(-0500)] <yura> kasper:

[09:05:28 CDT(-0500)] <kasper> so I finally go around to looking at my old pull request you commented

[09:05:35 CDT(-0500)] <kasper> https://github.com/GPII/universal/pull/48

[09:05:52 CDT(-0500)] <kasper> yura ^

[09:06:28 CDT(-0500)] <kasper> problem is if I do not include the test-framework in universal, then I'm not able to include it in the Linux/Windows branch

[09:06:32 CDT(-0500)] <kasper> as far as I can tell

[09:07:17 CDT(-0500)] <yura> ya i think as far as i remember you could load necessary files explicitly

[09:08:25 CDT(-0500)] <kasper> yes, but unless I use the full path, I dont believe node's module search will find the testFramework module

[09:09:11 CDT(-0500)] <kasper> (this is for linux and windows – in universal it finds the testFramework just fine)

[09:11:19 CDT(-0500)] <kasper> yura: I might be doing something stupid / missing something obvious

[09:59:24 CDT(-0500)] <alexn> colinclark: ayt?

[09:59:32 CDT(-0500)] <colinclark> alexn: marginally

[09:59:35 CDT(-0500)] <colinclark> what's on your mind?

[10:00:02 CDT(-0500)] <alexn> did you have any chance to review those 2 pull requests ? https://github.com/fluid-project/videoPlayer/pull/62 and https://github.com/fluid-project/videoPlayer/pull/58

[10:00:08 CDT(-0500)] <alexn> just asking

[10:00:11 CDT(-0500)] <colinclark> If you did...

[10:00:14 CDT(-0500)] <colinclark> Sorry

[10:00:16 CDT(-0500)] <colinclark> If I did...

[10:00:18 CDT(-0500)] <colinclark> you'd know

[10:00:26 CDT(-0500)] <alexn>

[10:00:38 CDT(-0500)] <colinclark> I'll see what I can do this afternoon

[10:00:50 CDT(-0500)] <colinclark> I've had constant meetings for the past few days

[10:00:58 CDT(-0500)] <alexn> yeah no worries. I just wanted to verify that I did not miss anything

[10:01:16 CDT(-0500)] <alexn> you always have a lot on your plate

[10:04:33 CDT(-0500)] <yura> kasper: so you mean the comment in XMLSettingsHandlerTests ?

[10:04:47 CDT(-0500)] <colinclark> alexn: Did you use some code to generate the new timestamps in these files? https://github.com/fluid-project/videoPlayer/pull/62/files

[10:05:49 CDT(-0500)] <alexn> colinclark: yes I did

[10:05:55 CDT(-0500)] <colinclark> where is that code?

[10:06:03 CDT(-0500)] <alexn> I was reusing the same function from captionator. Let me find it.

[10:08:33 CDT(-0500)] <alexn> colinclark: I just used the same one as Captionator so that times would be aligned with the ones which exist in Amara https://github.com/fluid-project/videoPlayer/blob/demo/lib/captionator/js/captionator.js#L110-L117

[10:11:27 CDT(-0500)] <colinclark> so how did you use this function, specifically?

[10:12:29 CDT(-0500)] <colinclark> did you write a little program that read the universal subtitles JSON and called your unisubJSONtoVTT() function?

[10:13:12 CDT(-0500)] <alexn> well it was a quick script written and it was more like my copy-paste the reply from Amara into JSON object and parsing it