fluid-work IRC Logs-2010-03-05

[18:25:58 EST(-0500)] <colinclark> i assume
[18:26:02 EST(-0500)] <yura> oh ok
[18:26:22 EST(-0500)] <Bosmon5> But the warning is puzzling
[18:26:49 EST(-0500)] <Bosmon5> Probably not relevant...
[18:30:09 EST(-0500)] <colinclark> Bosmon5: quick question
[18:30:13 EST(-0500)] <colinclark> what does clean() return?
[18:30:15 EST(-0500)] <colinclark> A dom element?
[18:30:37 EST(-0500)] <Bosmon5> Actually an array of them
[18:30:49 EST(-0500)] <colinclark> k
[18:31:03 EST(-0500)] <Bosmon5> It is a little confusing, since I mistook it for a jquery at first
[18:33:48 EST(-0500)] <yura> interesting , not sure if it matters: when you click cantel at the comment entry you get back to exhibit view but if you click back there you get back to the comment entry
[18:35:29 EST(-0500)] <yura> another thing is that when you scroll down and then go to a different page, your scroll position stays the same (doesnt go back to top)
[18:36:01 EST(-0500)] * yura (~Fluid@142.150.154.164) has left #fluid-work
[18:36:15 EST(-0500)] * yura (~Fluid@142.150.154.164) has joined #fluid-work
[18:37:02 EST(-0500)] <colinclark> interesting
[18:37:05 EST(-0500)] <colinclark> i guess that makes sense
[18:37:13 EST(-0500)] <colinclark> yura: it's probably getting late for you
[18:37:21 EST(-0500)] <colinclark> feel free to head home whenever you need to
[18:38:10 EST(-0500)] <yura> alright then , ill see you guys tomorrow
[18:38:20 EST(-0500)] <colinclark> See you soon!
[18:38:23 EST(-0500)] <colinclark> thanks again, yura
[18:38:27 EST(-0500)] <yura> thanks
[18:38:34 EST(-0500)] <colinclark> Bosmon5: Here's what I can tell you, and it's nearly meaningless
[18:38:42 EST(-0500)] * yura (~Fluid@142.150.154.164) has left #fluid-work
[18:38:58 EST(-0500)] <colinclark> If I inject the body in a timeout of 100ms it consistently works
[18:39:21 EST(-0500)] * yura (~Fluid@142.150.154.164) has joined #fluid-work
[18:39:42 EST(-0500)] <yura> colinclark: I forgot to lock the iphones before anastasia left , what should i do?
[18:39:51 EST(-0500)] <colinclark> yura: take 'em home
[18:39:56 EST(-0500)] <colinclark> if that's ok with you
[18:39:58 EST(-0500)] <yura> ok
[18:40:05 EST(-0500)] <yura> ill bring them tomorrow then
[18:40:17 EST(-0500)] <yura> see ya
[18:40:18 EST(-0500)] * yura (~Fluid@142.150.154.164) has left #fluid-work
[18:41:04 EST(-0500)] <Bosmon5> Colinclark - awful
[18:41:12 EST(-0500)] <colinclark> yeah, it's pretty bad
[18:41:25 EST(-0500)] <Bosmon5> I think we might need to steal that code snippet I saw
[18:41:51 EST(-0500)] <Bosmon5> I believe script elements can actually have onload handlers
[18:41:55 EST(-0500)] <colinclark> interesting
[18:42:20 EST(-0500)] <colinclark> i think we can and should fix yura's scrolling issue pretty easily
[18:42:31 EST(-0500)] <colinclark> don't quite understand the comment one, but it should be easy enough to reproduce
[18:42:41 EST(-0500)] <Bosmon5> Jquery just might not be doing all we need here... although you would think eval-ing something was pretty synchronous
[18:50:13 EST(-0500)] <colinclark> it's hard when we're so close here
[18:55:59 EST(-0500)] <colinclark> ok, scrolling is fix
[18:56:03 EST(-0500)] <colinclark> can't reproduce the comments issue
[18:56:11 EST(-0500)] <colinclark> i guess that really just leaves us with this one
[18:56:34 EST(-0500)] <colinclark> Bosmon5: If we can't freeze tonight, it's going to basically be up to you and Fish, I'm afraid
[18:56:40 EST(-0500)] <colinclark> To deal with all the logistics, cut a release, etc.
[18:56:59 EST(-0500)] <Bosmon5> ;(
[18:57:02 EST(-0500)] <colinclark> I'm gonna flip home around
[18:57:14 EST(-0500)] <colinclark> And then i'll try to leave you some instructions on how to cut and deploy the release
[18:57:23 EST(-0500)] <colinclark> but jamon knows enough to handle part of it if necessary
[18:57:33 EST(-0500)] <colinclark> I'll send an email to the list about this issue
[18:57:46 EST(-0500)] <colinclark> i'll be in the office tomorrow, but I've really got to get my Jasig presentations done
[18:59:18 EST(-0500)] <Bosmon5> OK
[19:00:14 EST(-0500)] * michelled (~michelled@CPE001310472ade-CM0011aefd3ca8.cpe.net.cable.rogers.com) has joined #fluid-work
[19:11:29 EST(-0500)] <Bosmo1> Ah
[19:11:32 EST(-0500)] <Bosmo1> It is only Thursday
[19:11:34 EST(-0500)] <Bosmo1> I thought it was Friday somehow
[19:24:37 EST(-0500)] * michelled (~michelled@CPE001310472ade-CM0011aefd3ca8.cpe.net.cable.rogers.com) has joined #fluid-work
[20:30:34 EST(-0500)] * athena (~athena@ip72-208-30-180.ph.ph.cox.net) has joined #fluid-work
[00:05:06 EST(-0500)] * athena7 (~athena@ip72-208-30-180.ph.ph.cox.net) has joined #fluid-work
[04:17:21 EST(-0500)] * denbuzze (~anonymous@ginger.caret.cam.ac.uk) has joined #fluid-work
[04:20:19 EST(-0500)] * boyan (~boyan@62.44.108.2) has joined #fluid-work
[06:02:01 EST(-0500)] * sveto (~sveto@62.44.108.2) has joined #fluid-work
[07:47:33 EST(-0500)] * boyan (~boyan@62.44.108.2) has joined #fluid-work
[07:47:33 EST(-0500)] * athena (~athena@ip72-208-30-180.ph.ph.cox.net) has joined #fluid-work
[08:08:14 EST(-0500)] * athena7 (~athena@ip72-208-30-180.ph.ph.cox.net) has joined #fluid-work
[08:10:44 EST(-0500)] * jameswy (~anon@bas7-toronto01-1242513550.dsl.bell.ca) has joined #fluid-work
[08:11:11 EST(-0500)] * Justin_o (~Justin@142.150.154.171) has joined #fluid-work
[08:27:13 EST(-0500)] * colinclark (~colin@bas2-toronto09-1176394708.dsl.bell.ca) has joined #fluid-work
[08:54:12 EST(-0500)] * anastasiac (~team@142.150.154.193) has joined #fluid-work
[08:55:06 EST(-0500)] * jhung (~Lynnette@H41.C195.cci.switchworks.net) has joined #fluid-work
[09:12:46 EST(-0500)] * colinclark (~colin@bas2-toronto09-1176394708.dsl.bell.ca) has joined #fluid-work
[09:14:37 EST(-0500)] * yura (~Fluid@142.150.154.164) has joined #fluid-work
[09:15:27 EST(-0500)] <colinclark> jameswy: Rumor has it that Bosmon found a fix for our final Engage 0.3b3 blocker late last night
[09:15:46 EST(-0500)] <colinclark> I haven't seen a patch yet, but my hope is that we might be able to start QA at the tail end of today
[09:16:22 EST(-0500)] <jameswy> colinclark: awesome! Looking forward to it.
[09:18:01 EST(-0500)] <colinclark> jameswy: In the meantime, the daily build is now featuring the Screen Navigator and is insanely faster.
[09:18:25 EST(-0500)] <colinclark> A few rough edges related to rendering-related flicker that we can fix for 0.3 final with a nice spinner and the like.
[09:19:04 EST(-0500)] <jameswy> colinclark: I was trying it out yesterday, and it the performance difference was indeed incredible. You guys did a wicked awesome job.
[09:19:24 EST(-0500)] <colinclark> thanks
[09:19:54 EST(-0500)] <colinclark> wish it could have been sooner, but it was a big job to preserve the integrity of the app while moving it into such a strange AJAXy environment
[09:26:46 EST(-0500)] * laurel (~Laurel@142.150.154.178) has joined #fluid-work
[09:30:37 EST(-0500)] <laurel> jameswy - I may have some time for testing if needed
[09:31:10 EST(-0500)] <jameswy> laurel: Great! It doesn't look like we'll get to it till late today or Monday though.
[09:31:39 EST(-0500)] <laurel> ah well, let me know if you have something that needs to be done.
[09:32:01 EST(-0500)] <jameswy> laurel: Sure thing. Thanks.
[09:51:59 EST(-0500)] * clown (~clown@142.150.154.101) has joined #fluid-work
[09:54:15 EST(-0500)] * colinclark (~colin@bas2-toronto09-1176394708.dsl.bell.ca) has joined #fluid-work
[09:57:38 EST(-0500)] * jameswy1 (~anon@bas7-toronto01-1242513550.dsl.bell.ca) has joined #fluid-work
[10:03:43 EST(-0500)] * sveto (~sveto@62.44.108.2) has left #fluid-work
[10:04:45 EST(-0500)] * boyan (~Administr@cms.studgrad.net) has joined #fluid-work
[10:18:18 EST(-0500)] * denbuzze (~anonymous@ginger.caret.cam.ac.uk) has joined #fluid-work
[10:20:37 EST(-0500)] * EricDalquist (~dalquist@2607:f388:e:0:221:9bff:fe37:e768) has joined #fluid-work
[10:27:35 EST(-0500)] * colinclark (~colin@142.150.154.101) has joined #fluid-work
[10:27:58 EST(-0500)] * colinclark (~colin@142.150.154.101) has joined #fluid-work
[10:29:34 EST(-0500)] * athena (~athena@wsip-72-215-204-133.ph.ph.cox.net) has joined #fluid-work
[10:46:06 EST(-0500)] <yura> hey everyone, I m sure you've noticed a slight regression on a home page where there are now only 2 items per row. this happens becuase a "common" navigationlist css is overriding the styling on the home page even though the page doesn't use nav list. there are several ways to approach that and i was wondering if anyone has an opinion
[10:47:21 EST(-0500)] <yura> easiest way is to override the styling on the home page to fix it. the proper way, i think, is to properly scope the nav list css but that would require updating all the markup where the nav list is used as part of it
[10:56:28 EST(-0500)] * justin_o (~jmo@142.150.154.101) has joined #fluid-work
[10:56:32 EST(-0500)] <colinclark> yura: I like the sound of the latter solution
[10:56:42 EST(-0500)] <colinclark> yura: How will the Nav List markup have to changed?
[10:57:01 EST(-0500)] * colinclark 's grammar sucks today
[10:57:10 EST(-0500)] <colinclark> How will the Nav List markup have to be changed?
[10:59:01 EST(-0500)] <yura> will in order to skope it we would need to put some extra fl class on the nav list container i think, it will work for all pages that pull nav list markup. but for the ones that already have it in the markup (artifact, browse) that fl class should be added as well
[11:02:04 EST(-0500)] <colinclark> yura: What do you think? It sounds like the right way to go
[11:02:43 EST(-0500)] <yura> yes, it will require some thorough testing to make sure everything is updated
[11:02:52 EST(-0500)] <yura> ok ill work on it
[11:04:46 EST(-0500)] <colinclark> thanks, yura
[11:29:28 EST(-0500)] * mackrauss (~Armin@user145-41.wireless.utoronto.ca) has joined #fluid-work
[11:36:43 EST(-0500)] * boyan (~Administr@cms.studgrad.net) has left #fluid-work
[11:44:22 EST(-0500)] * justin_o (~jmo@142.150.154.101) has joined #fluid-work
[11:48:39 EST(-0500)] * laurel (~Laurel@142.150.154.178) has left #fluid-work
[12:14:56 EST(-0500)] * justin_o (~jmo@142.150.154.101) has joined #fluid-work
[12:21:44 EST(-0500)] <yura> colinclark: this is the fix for the home page styling regression : http://issues.fluidproject.org/browse/ENGAGE-495
[12:46:55 EST(-0500)] * colinclark (~colin@142.150.154.101) has joined #fluid-work
[12:58:35 EST(-0500)] <Bosmon> Hi yura - are you there?
[12:58:45 EST(-0500)] <yura> Bosmon: yes, hi
[12:58:58 EST(-0500)] <Bosmon> I am going to try to make a patch for the AWFUL ISSUE, would you be able to test it?
[12:59:07 EST(-0500)] <yura> yes
[12:59:10 EST(-0500)] <yura> definetely
[12:59:11 EST(-0500)] <Bosmon> It is sort of preliminary since it is full of scads of debugging stuff
[12:59:15 EST(-0500)] <yura> ok
[12:59:20 EST(-0500)] <Bosmon> But if it works I can polish it up a bit
[12:59:31 EST(-0500)] <yura> ok
[13:00:02 EST(-0500)] <Bosmon> The fix is really bizarre, since it seems to involve waiting for events on the DOCUMENT Amazingly practically every resources out there explaining how to dynamically inject scripts on Safari is wrong...
[13:00:19 EST(-0500)] <Bosmon> Do we have a separate JIRA for that issue?
[13:00:26 EST(-0500)] <Bosmon> Cool, thanks
[13:00:42 EST(-0500)] * elicochran (~elicochra@dhcp-169-229-212-100.LIPS.Berkeley.EDU) has joined #fluid-work
[13:01:14 EST(-0500)] <yura> i think it's 494
[13:04:18 EST(-0500)] <Bosmon> ah ok
[13:04:22 EST(-0500)] <Bosmon> I just made 496...
[13:06:29 EST(-0500)] <yura> alright, so you will attach a patch?
[13:14:42 EST(-0500)] <Bosmon> ok, sorry... looks likes the fix is not 100% reliable
[13:14:47 EST(-0500)] <Bosmon> But I think I know how to fix it...
[13:15:44 EST(-0500)] <yura> sure
[13:19:49 EST(-0500)] * justin_o_ (~jmo@142.150.154.101) has joined #fluid-work
[13:21:14 EST(-0500)] * athena (~athena@wsip-72-215-204-133.ph.ph.cox.net) has joined #fluid-work
[13:45:53 EST(-0500)] * michelled (~michelled@CPE001310472ade-CM0011aefd3ca8.cpe.net.cable.rogers.com) has joined #fluid-work
[13:50:05 EST(-0500)] * justin_o (~jmo@142.150.154.101) has joined #fluid-work
[13:55:24 EST(-0500)] * denbuzze (~anonymous@ginger.caret.cam.ac.uk) has joined #fluid-work
[13:59:16 EST(-0500)] <Bosmon> The chickens certainly are very sensitive
[13:59:24 EST(-0500)] <Bosmon> It seems that even injecting a CSS file when they are angry will set them off
[14:15:37 EST(-0500)] <Bosmon> ok, yura
[14:15:40 EST(-0500)] <Bosmon> Are you still there?
[14:15:44 EST(-0500)] <yura> yes
[14:15:44 EST(-0500)] <Bosmon> I think I have a fix that works now
[14:15:51 EST(-0500)] <yura> that's good
[14:16:01 EST(-0500)] <yura> i m looking forward to testing it
[14:16:20 EST(-0500)] * jhung (~Lynnette@H41.C195.cci.switchworks.net) has joined #fluid-work
[14:16:52 EST(-0500)] <Bosmon> Incredibly enough this patch involves some CCOMPUTER SCCIENCE!!!
[14:17:01 EST(-0500)] <Bosmon> Did you ever read about this strategy?
[14:17:02 EST(-0500)] <Bosmon> http://en.wikipedia.org/wiki/Continuation-passing_style
[14:18:32 EST(-0500)] <yura> not until now
[14:18:56 EST(-0500)] <Bosmon> I advise you to study it a bit
[14:19:13 EST(-0500)] <Bosmon> Amazingly there is even a "CPS for JAVERSCRIPTERS" page here
[14:19:14 EST(-0500)] <Bosmon> http://marijn.haverbeke.nl/cps/
[14:19:20 EST(-0500)] <yura> thanks
[14:24:34 EST(-0500)] <Bosmon> ok YURA
[14:24:36 EST(-0500)] <Bosmon> http://issues.fluidproject.org/browse/ENGAGE-496
[14:24:42 EST(-0500)] <Bosmon> I have attached the patches to this issue
[14:25:07 EST(-0500)] <yura> Bosmon: thanks, i will give it a try
[14:26:22 EST(-0500)] <michelled> Bosmon, yura, colinclark: are there any other patches that need to get reviewed/committed before we freeze the code?
[14:26:55 EST(-0500)] <colinclark> michelled: yura has a patch that needs to be reviewed and committed
[14:26:59 EST(-0500)] <colinclark> Bosmon: is working on one now?
[14:27:10 EST(-0500)] <yura> colinclark: michelled just commited it
[14:29:16 EST(-0500)] <michelled> Bosmon: did the patches on ENGAGE-434 ever get committed?
[14:32:12 EST(-0500)] <Bosmon> michelled: yes
[14:33:07 EST(-0500)] <yura> Bosmon it seems to work now
[14:33:13 EST(-0500)] <Bosmon> (!U$()"£$("£()U$("£$"£
[14:33:16 EST(-0500)] <Bosmon> YAYAYAYAYAYQ&YWE*QW&*E*W&"Y!£
[14:33:32 EST(-0500)] <yura> but i notice and interesting thing here
[14:34:13 EST(-0500)] <yura> when i navigate to a new page, before it even start loading the new page the old ones styles change
[14:34:18 EST(-0500)] <yura> happens momentarily
[14:34:25 EST(-0500)] <Bosmon> Yeah
[14:34:28 EST(-0500)] <Bosmon> We can fix that
[14:34:46 EST(-0500)] <Bosmon> It is a byproduct of now having TOTAL SERIALISATION amongst head manipulation
[14:35:44 EST(-0500)] <yura> interesting
[14:37:13 EST(-0500)] <Bosmon> Probably the best thing to do is to just apply "hidden" to the whole of body when the new page loads
[14:37:53 EST(-0500)] <yura> hidded to the old page's body?
[14:41:15 EST(-0500)] <colinclark> Might as well show a spinner while we're at it
[14:41:15 EST(-0500)] <colinclark>
[14:41:50 EST(-0500)] <Bosmon> "add a chart"
[14:42:43 EST(-0500)] <Bosmon> yura - you should also notice that you can NOW SEE THE SOURCES of the dynamically loaded files in the Safari debugger
[14:48:17 EST(-0500)] <michelled> Bosmon and I were just talking about ENGAGE-434 - turns out those patches weren't committed yet
[14:48:36 EST(-0500)] <Bosmon> (12:43:59) AntranigBasman: But I have a more "harmless" version of the same stuff that is rolled into the current patch
[14:48:36 EST(-0500)] <Bosmon> (12:44:02) AntranigBasman: That doesn't break trunk
[14:48:45 EST(-0500)] <colinclark> jameswy: If I were looking for a modern Fluid logo suitable for a slide deck, where would I find one?
[14:48:57 EST(-0500)] <Bosmon> So it is possible to enable the "head discarding" algorithm with a single option in engageConfig now
[14:50:33 EST(-0500)] <jameswy> colinclark: right now, the best place to do that is http://wiki.fluidproject.org/display/fluid/Fluid+Engage+logotype – the very bottom has rasters of the Fluid and Fluid Engage logos that we're going to be using.
[14:50:48 EST(-0500)] <colinclark> thanks!
[14:50:54 EST(-0500)] <michelled> Bosmon, once your new patch is in, if I were to commit mobileHome/home.html so that it links against the concatenated files would that work?
[14:51:05 EST(-0500)] <Bosmon> No
[14:51:11 EST(-0500)] <jameswy> Jorge is in the midst of putting a proper logo kit together right now (vector versions, proper png with transparencies)--not sure when he's putting that up.
[14:51:13 EST(-0500)] <Bosmon> You would need to change the option in the config file
[14:51:19 EST(-0500)] <Bosmon> And then also update the list of "known resources"
[14:51:28 EST(-0500)] <Bosmon> Which I haven't updated since you expanded the scope of the minified files
[14:55:02 EST(-0500)] <yura> Bosmon: i dont think i can see the sources in safari, including jquery.ui and dialog
[14:56:56 EST(-0500)] <Bosmon> Hmm
[14:56:59 EST(-0500)] <Bosmon> you're right
[14:57:23 EST(-0500)] <yura> but at least i can see the dialog
[15:10:32 EST(-0500)] <Bosmon> Well
[15:10:36 EST(-0500)] <Bosmon> Shall I commit it then
[15:15:21 EST(-0500)] <michelled> yura, is the bug fixed? should it be committed?
[15:16:30 EST(-0500)] <yura> well the dialog is showing now, so i guess 494 can be fized
[15:16:34 EST(-0500)] <yura> fixed
[15:20:13 EST(-0500)] <michelled> yura, is this JIRA done? http://issues.fluidproject.org/browse/ENGAGE-457
[15:20:43 EST(-0500)] <yura> yes
[15:20:47 EST(-0500)] <yura> should i resolve it?
[15:21:04 EST(-0500)] <michelled> yep
[15:21:26 EST(-0500)] <yura> done
[15:22:19 EST(-0500)] <colinclark> jameswy: nothing transparent and cropped to the actual logo, by chance?
[15:23:03 EST(-0500)] <colinclark> these all have funny gradients behind them
[15:23:06 EST(-0500)] <jameswy> colinclark: unfortunately not right now--we could try pinging Jorge and see if he's almost finished with the logo kit, or if he could just send a vector file over to you guys on Monday.
[15:23:18 EST(-0500)] <colinclark> preso's on sunday
[15:23:24 EST(-0500)] <jameswy> ahhhhg.
[15:23:24 EST(-0500)] <colinclark> i'll stick with the old logo
[15:23:26 EST(-0500)] <colinclark> too bad
[15:23:30 EST(-0500)] <jameswy> Yeah
[15:23:41 EST(-0500)] <michelled> yura, could you actually take a look at the open JIRAS for 0.3b and resolve any that are done?
[15:25:56 EST(-0500)] <yura> michelled: sure, will do
[15:26:03 EST(-0500)] <michelled> thx
[15:40:54 EST(-0500)] <yura> michelled: sorry, is there a filter for that, i seem to find only few that are still open?
[15:41:46 EST(-0500)] <Bosmon> ok, yura, michelled: I have commited my fix package for ENGAGE-496
[15:42:01 EST(-0500)] <Bosmon> Perhaps we can now close that entire network of JIRAs
[15:42:19 EST(-0500)] <Bosmon> And I guess we should concentrate on the "final run" deploying the concat+minify version of the app
[15:46:20 EST(-0500)] <michelled> Bosmon - thanks
[15:46:36 EST(-0500)] <yura> ill be back in 10min
[15:46:56 EST(-0500)] <michelled> these are the files that were added to the concatenated file:
[15:46:57 EST(-0500)] <michelled> "$engage/lib/jquery/datepicker/ui.datepicker-stub.js",
[15:46:57 EST(-0500)] <michelled> "$engage/lib/jquery/datepicker/i18n/jquery.ui.datepicker-en-GB.js",
[15:46:58 EST(-0500)] <michelled> "$engage/lib/jquery/datepicker/i18n/jquery.ui.datepicker-fr.js",
[15:46:58 EST(-0500)] <michelled> "$engage/framework/js/dateUtils.js,components/guestbook/js/guestbook.js"
[15:46:58 EST(-0500)] <michelled>
[15:47:39 EST(-0500)] <Bosmon> ok, thanks
[15:47:47 EST(-0500)] <Bosmon> I guess I will try running the build and see what happens...
[15:48:50 EST(-0500)] <Bosmon> I guess that last line has an $engage in the middle...
[15:50:33 EST(-0500)] <Bosmon> !!!!
[15:50:49 EST(-0500)] <Bosmon> BUILD FAILED
[15:50:49 EST(-0500)] <Bosmon> E:\workspace\fluid-engage-kettle\build-scripts\build.xml:12: Directory E:\workspace\fluid-engage-kettle\pr
[15:50:49 EST(-0500)] <Bosmon> oducts creation was not successful for an unknown reason
[15:51:45 EST(-0500)] <Bosmon> ok.... a "clean" managed to fix that...
[15:52:42 EST(-0500)] <Bosmon> michelled: Do you happen to have a "fixed" version of the mobileHome.html to hand?
[15:53:06 EST(-0500)] <michelled> no, I don't
[15:53:50 EST(-0500)] <michelled> I guess it's now call home.html
[15:54:00 EST(-0500)] <Bosmon> yes
[15:58:09 EST(-0500)] <Bosmon> michelled: can you confirm, "jquery.ba-hashchange.js" is not in the build?
[15:58:21 EST(-0500)] <michelled> it is not
[15:58:32 EST(-0500)] <Bosmon> ok, thanks
[16:07:05 EST(-0500)] <michelled> Bosmon: any luck?
[16:14:00 EST(-0500)] <Bosmon> I am testing now
[16:15:22 EST(-0500)] <Bosmon> Homepage starts up now
[16:17:10 EST(-0500)] <Bosmon> OK
[16:17:17 EST(-0500)] <Bosmon> It is failing to correcty discard references to infusion things...
[16:18:28 EST(-0500)] <Bosmon> michelled: Can you confirm that engageRenderUtils.js is in the build?
[16:19:21 EST(-0500)] <michelled> it should be included
[16:19:32 EST(-0500)] <michelled> framework/js/engageRenderUtils.js
[16:20:51 EST(-0500)] * jameswy (~anon@bas7-toronto01-1242513550.dsl.bell.ca) has joined #fluid-work
[16:23:46 EST(-0500)] <michelled> Bosmon - I just checked the concatenated engage file - engageRenderUtils is there
[16:25:42 EST(-0500)] <Bosmon> thanks
[16:25:58 EST(-0500)] <Bosmon> It seems URLs have actually been wrong all this time, all the same
[16:26:08 EST(-0500)] <Bosmon> Bloody kettle router manages to find anything!
[16:35:05 EST(-0500)] <michelled>
[16:41:24 EST(-0500)] * justin_o (~jmo@142.150.154.101) has joined #fluid-work
[16:50:03 EST(-0500)] <michelled> yura are you still there?
[16:50:08 EST(-0500)] <yura> yes
[16:50:13 EST(-0500)] <yura> i was working on a spinner
[16:50:24 EST(-0500)] <yura> it's close but i dont think you ll pass it
[16:50:37 EST(-0500)] <michelled>
[16:50:44 EST(-0500)] * jhung (~Lynnette@H41.C195.cci.switchworks.net) has left #fluid-work
[16:51:14 EST(-0500)] <Bosmon> Hi yura
[16:51:49 EST(-0500)] <yura> Bosmo
[16:51:53 EST(-0500)] <yura> Bosmon yes
[16:52:01 EST(-0500)] <Bosmon> I have the standalone minified build working
[16:52:07 EST(-0500)] <Bosmon> But when I commit this package, it will cause trunk to break
[16:52:16 EST(-0500)] <Bosmon> There is one wrinkle, that the minifier seems to be barfing on a few files
[16:52:22 EST(-0500)] <Bosmon> In particular the ones we use for date localisation
[16:52:30 EST(-0500)] <yura> oh
[16:52:31 EST(-0500)] <michelled> well, trunk will break when you work in eclipse but the nightly build should still work
[16:52:38 EST(-0500)] <Bosmon> Anyway, if I commit this now, can you run through the standalone build and tell me what you see?
[16:53:20 EST(-0500)] <yura> ya i can, hopefully i can build in linux
[16:53:20 EST(-0500)] <Bosmon> "$engage/lib/jquery/datepicker/i18n/jquery.ui.datepicker-en-GB.js",
[16:53:20 EST(-0500)] <Bosmon> "$engage/lib/jquery/datepicker/i18n/jquery.ui.datepicker-fr.js",
[16:53:29 EST(-0500)] <Bosmon> michelled: The broken files are these ones
[16:53:36 EST(-0500)] <Bosmon> Their material doesn't seem to be in the final build file
[16:54:16 EST(-0500)] <Bosmon> It is either because of their use of ' characters, or because of their use of UTF-8
[16:54:49 EST(-0500)] <Bosmon> This is the start of the errors:
[16:54:50 EST(-0500)] <Bosmon> [echo] Going to minify from ../build/source/src/main/webapp/fluid-engage-core to ../build/mini/src/m
[16:54:51 EST(-0500)] <Bosmon> ain/webapp/fluid-engage-core including *.js
[16:54:51 EST(-0500)] <Bosmon> [apply]
[16:54:51 EST(-0500)] <Bosmon> [apply] [ERROR] 1484:3:illegal character
[16:54:51 EST(-0500)] <Bosmon> [apply]
[16:54:51 EST(-0500)] <Bosmon> [apply] [ERROR] 1484:3:syntax error
[16:54:52 EST(-0500)] <Bosmon> [apply]
[16:54:52 EST(-0500)] <Bosmon> [apply] [ERROR] 1484:4:illegal character
[16:54:53 EST(-0500)] <Bosmon> [apply]
[16:54:54 EST(-0500)] <Bosmon> [apply] [ERROR] 1504:2:illegal character
[16:54:54 EST(-0500)] <Bosmon> [apply]
[16:54:54 EST(-0500)] <Bosmon> [apply] [ERROR] 1504:2:syntax error
[16:54:55 EST(-0500)] <Bosmon> [apply]
[16:54:55 EST(-0500)] <Bosmon> [apply] [ERROR] 1504:3:illegal character
[16:54:56 EST(-0500)] <Bosmon> [apply]
[16:55:09 EST(-0500)] <Bosmon> Did it come through?
[16:55:24 EST(-0500)] <michelled> it came through
[16:55:28 EST(-0500)] <Bosmon> ok
[16:55:44 EST(-0500)] <michelled> I don't get that error and I do see the contents in the concatenated file
[16:55:58 EST(-0500)] <Bosmon> ok
[16:56:04 EST(-0500)] <Bosmon> Perhaps this will work on Linux then
[16:56:05 EST(-0500)] <Bosmon> I will commit it
[16:56:39 EST(-0500)] <michelled> yura, you could run the nightly after Boz commits and test that
[16:56:44 EST(-0500)] <yura> yes
[16:56:57 EST(-0500)] <yura> Bosmon ping me when you want me to rebuild
[16:57:10 EST(-0500)] <Bosmon> Well, run the build on your own machine first...
[16:57:14 EST(-0500)] <Bosmon> Or did you switch to Windows now?
[16:57:34 EST(-0500)] <yura> there's no maven on it though
[16:59:05 EST(-0500)] <Bosmon> Well I'm sure that is easily fixed
[16:59:10 EST(-0500)] <Bosmon> Are you still on Linux?
[16:59:14 EST(-0500)] <yura> yes
[16:59:22 EST(-0500)] <Bosmon> michelled: No mention of "Tuesday" in MyEngage.js - so the date files have not come through
[17:01:08 EST(-0500)] <Bosmon> yura, michelled: I have committed now
[17:01:13 EST(-0500)] <yura> ok
[17:01:14 EST(-0500)] <Bosmon> May God have mercy on our Souls
[17:04:40 EST(-0500)] <yura>
[17:05:08 EST(-0500)] <michelled> I've got "Tuesday" in MyEngage.js
[17:07:43 EST(-0500)] <Bosmon> ok
[17:07:55 EST(-0500)] <michelled> where would I see the date string on the UI?
[17:07:58 EST(-0500)] <Bosmon> Does the WAR work for you?
[17:08:01 EST(-0500)] <michelled> yes
[17:08:10 EST(-0500)] <Bosmon> Well, if you just go to any page that has the guestbook, it will explode if the file is not there
[17:08:27 EST(-0500)] <michelled> so, any page with comments?
[17:08:30 EST(-0500)] <Bosmon> Yes
[17:08:42 EST(-0500)] <michelled> seems to work
[17:08:45 EST(-0500)] <Bosmon>
[17:09:13 EST(-0500)] <michelled> yura, shall we try the nightly?
[17:09:20 EST(-0500)] <yura> sure
[17:09:23 EST(-0500)] <michelled> I would like it if you could look at it on the device
[17:09:37 EST(-0500)] <Bosmon> If it works, it should be VERY fast now
[17:09:46 EST(-0500)] <yura> building
[17:12:07 EST(-0500)] <yura> done
[17:12:15 EST(-0500)] <Bosmon> michelled: Where is the code for the compressor kept
[17:12:20 EST(-0500)] <Bosmon> Is it hidden inside ant somewhere?
[17:13:00 EST(-0500)] <yura> it buidl but doesnt work
[17:13:10 EST(-0500)] <yura> fluid.engage.url is undefined
[17:13:22 EST(-0500)] <yura> fluid.engage.url.setBusy(true);
[17:13:54 EST(-0500)] <Bosmon> Your build must be stale
[17:13:55 EST(-0500)] <michelled> we use the YUI minifier - it's in the infusion build script lib directory
[17:13:57 EST(-0500)] <Bosmon> Did you do a build clean?
[17:14:06 EST(-0500)] <Bosmon> And also, did you clear out the webapp from wherever it was?
[17:14:08 EST(-0500)] <michelled> the nightly does a clean
[17:14:11 EST(-0500)] <Bosmon> That function is now in URLUtilities
[17:14:49 EST(-0500)] <Bosmon> Which should have been part of the build
[17:16:49 EST(-0500)] <Bosmon> What is the nightly build URL?
[17:16:59 EST(-0500)] <michelled> looks like the nightly is getting syntax errors during minification
[17:17:02 EST(-0500)] <yura> http://build.fluidproject.org:8095/engage/home/home.html
[17:17:06 EST(-0500)] <Bosmon> glarg
[17:18:10 EST(-0500)] <Bosmon> Ok
[17:18:22 EST(-0500)] <Bosmon> I'm willing to bet this is because we're not giving YUICompressor a charset parameter
[17:18:24 EST(-0500)] <Bosmon> I will test now
[17:20:43 EST(-0500)] <yura> michelled: i created a patch and attached it to the issue, you might have a better idea or suggestions how to optimize my solution for the spinner http://issues.fluidproject.org/browse/ENGAGE-351
[17:21:02 EST(-0500)] <michelled> thanks
[17:22:00 EST(-0500)] <Bosmon> That appears to make it work
[17:22:05 EST(-0500)] <Bosmon> I will test again now and then commit
[17:22:41 EST(-0500)] <yura> sorry Bosmon, michelled I gotta run right now
[17:23:18 EST(-0500)] <yura> have a good weekend
[17:23:47 EST(-0500)] * yura (~Fluid@142.150.154.164) has left #fluid-work
[17:23:53 EST(-0500)] <Bosmon> OK
[17:23:58 EST(-0500)] <Bosmon> That has fixed the issue
[17:24:04 EST(-0500)] <Bosmon> michelled: Do you know how to set off the build?
[17:24:10 EST(-0500)] <michelled> ya
[17:24:13 EST(-0500)] <michelled> that
[17:24:25 EST(-0500)] <michelled> that's no problem - the issue is that I don't have a device to test with
[17:24:32 EST(-0500)] <Bosmon> ok
[17:27:15 EST(-0500)] * yura_mobile (~yura@24.114.234.32) has joined #fluid-work
[17:27:50 EST(-0500)] <Bosmon> OK, I've committed
[17:27:53 EST(-0500)] <Bosmon> Try building again
[17:28:03 EST(-0500)] <Bosmon> I presume it clears out infusion as well when it cleans
[17:28:12 EST(-0500)] <Bosmon> Since the change is in the infusion buildUtils.xml
[17:28:40 EST(-0500)] <michelled> yep
[17:28:43 EST(-0500)] <michelled> it's building
[17:31:12 EST(-0500)] <michelled> I'm still seeing the syntax errors
[17:31:24 EST(-0500)] <Bosmon> lkejlkwejrlkwer
[17:31:36 EST(-0500)] <Bosmon> I'm sure it can't have done a clean checkout...
[17:31:45 EST(-0500)] * yura_mobile (~yura@24.114.234.32) has joined #fluid-work
[17:31:45 EST(-0500)] <Bosmon> Can you send me the build URL in continuum?