fluid-work IRC Logs-2009-10-05

Owned by Fluid IRC Log Bot
Last updated: Oct 05, 2009Version comment
23 min read

[00:22:16 EDT(-0400)] * JASIGLogBot (n=PircBot@jasig.Princeton.EDU) has joined #fluid-work
[00:22:16 EDT(-0400)] * Topic is 'Bug Parade Infusion 1.1.2 & Engage 0.1: http://issues.fluidproject.org/secure/IssueNavigator.jspa?mode=hide&requestId=10128' set by justin_o on 2009-09-22 10:40:18 EDT(-0400)
[07:13:52 EDT(-0400)] * heidi_ (n=thesumme@bas5-oshawa95-1176457717.dsl.bell.ca) has joined #fluid-work
[08:24:20 EDT(-0400)] * Justin_o (n=Justin@142.150.154.171) has joined #fluid-work
[08:25:32 EDT(-0400)] <Justin_o> just noticed that FLUID-3222 wasn't tagged with the Bug parade comment. I have done that now
[08:29:31 EDT(-0400)] * laurel (n=Laurel@142.150.154.178) has joined #fluid-work
[08:40:51 EDT(-0400)] * athena (n=athena@adsl-75-58-127-15.dsl.wlfrct.sbcglobal.net) has joined #fluid-work
[08:52:26 EDT(-0400)] * jessm (n=Jess@c-71-232-1-65.hsd1.ma.comcast.net) has joined #fluid-work
[08:55:53 EDT(-0400)] * colinclark (n=colin@bas2-toronto09-1176130646.dsl.bell.ca) has joined #fluid-work
[08:59:20 EDT(-0400)] * EricDalquist (n=dalquist@bohemia.doit.wisc.edu) has joined #fluid-work
[09:14:10 EDT(-0400)] <Justin_o> Just to let everyone know, I've started to work on FLUID-3222
[09:15:19 EDT(-0400)] * anastasiac (n=team@142.150.154.189) has joined #fluid-work
[09:19:40 EDT(-0400)] <jessm> Justin_o: you and CC have the bug parade reins now, right?
[09:20:05 EDT(-0400)] <Justin_o> yep...
[09:21:11 EDT(-0400)] * yura (n=yura@142.150.82.121) has joined #fluid-work
[09:31:25 EDT(-0400)] * colinclark (n=colin@bas2-toronto09-1176130646.dsl.bell.ca) has joined #fluid-work
[09:59:25 EDT(-0400)] * fj4000 (n=Jacob@142.150.154.164) has joined #fluid-work
[10:13:17 EDT(-0400)] * Bosmo1 (n=Bosmon@c-24-8-184-141.hsd1.co.comcast.net) has joined #fluid-work
[10:16:42 EDT(-0400)] * colinclark (n=colin@142.150.154.101) has joined #fluid-work
[10:18:37 EDT(-0400)] <laurel> does anybody have a pointer to a wiki page which will help me figure out what lisences are valid for third party modules?
[10:23:41 EDT(-0400)] <colinclark> laurel: Can you explain what you mean?
[10:28:31 EDT(-0400)] <laurel> working on FLUID-3192: " Also make sure thirdparty code is compatibly licensed and a license file is included in the same directory as the code."
[10:28:42 EDT(-0400)] <laurel> I'm hoping there is a reference on the wiki to figure out this
[10:28:57 EDT(-0400)] <laurel> how do I know what is a compatible license
[10:29:02 EDT(-0400)] <colinclark> I can't think of anything specific.
[10:29:12 EDT(-0400)] <colinclark> Compatible licenses...
[10:29:25 EDT(-0400)] <colinclark> Simple rule of thumb: BSD/MIT/Apache OK
[10:29:32 EDT(-0400)] <colinclark> GPL/LPGL NOT OK
[10:29:45 EDT(-0400)] <laurel> ok...I'm actually going to post this on the wik
[10:30:08 EDT(-0400)] * michelled (n=michelle@142.150.154.193) has joined #fluid-work
[10:30:24 EDT(-0400)] <colinclark> laurel: Post what in the wiki?
[10:31:01 EDT(-0400)] <laurel> your simple rules
[10:35:37 EDT(-0400)] <laurel> so fastXmlPull seems to be LGPL??
[10:38:34 EDT(-0400)] <Bosmo1> Well, we had a long interaction with the fastXmlPull authour last year
[10:38:43 EDT(-0400)] <Bosmo1> He has agreed to licence it under an additional licence for us
[10:42:44 EDT(-0400)] <laurel> ok...so I won't worry about that then.
[10:44:39 EDT(-0400)] <Bosmo1> It looks like that one is zlib
[10:45:06 EDT(-0400)] <Bosmo1> Well, I don't imagine that we have taken in any extra 3rd party code for this release?
[10:45:09 EDT(-0400)] <Bosmo1> I can't remember that we have....
[10:47:33 EDT(-0400)] <colinclark> In Infusion, I don't think we have, no.
[10:47:48 EDT(-0400)] <colinclark> Engage probably deserves a license review, but let's focus on Infusion for now.
[10:48:00 EDT(-0400)] <colinclark> Bosmo1: Dev meeting times. There was a thread on the list last week.
[10:48:25 EDT(-0400)] <colinclark> Do you have a preference for a time? We used to have them at 11 am Eastern/9 am Mountain
[10:48:42 EDT(-0400)] <colinclark> But with standup at 11:30 am, it sort of disrupts the flow.
[10:49:20 EDT(-0400)] <colinclark> michelled mentioned a few options:
[10:49:35 EDT(-0400)] <colinclark> * Moving it back to 10 am Eastern/8 am Mountain
[10:49:45 EDT(-0400)] <colinclark> * Ahead to noon Eastern / 10 am Mountain
[10:49:50 EDT(-0400)] <colinclark> And either Monday or Tuesday
[10:50:13 EDT(-0400)] <Bosmo1> ah
[10:50:34 EDT(-0400)] <Bosmo1> I guess 10am Mountain might be a little better
[10:50:44 EDT(-0400)] <Bosmo1> Unless you want to encounter me in my pyjamas (tongue)
[10:50:48 EDT(-0400)] <colinclark> lol
[10:51:03 EDT(-0400)] <colinclark> So Monday works for everyone still?
[10:51:38 EDT(-0400)] <colinclark> yura: So I have tons to chat with you about in regards to Kettle. I had a productive Friday night and Sunday learning more about Kettle. But let's get Infusion "squared away" first and then we can talk through it.
[10:51:52 EDT(-0400)] <michelled> Monday seems fine. I'll move it in the calendar
[10:51:58 EDT(-0400)] <colinclark> k, thanks michelled
[10:52:24 EDT(-0400)] <yura> colinclark: sounds good
[10:52:47 EDT(-0400)] <colinclark> yura: I've got a semi-working refactoring of artifact and browse. Will commit it to a branch when I get a second.
[10:53:02 EDT(-0400)] <colinclark> Bosmo1: Without getting the commit logs, I'm feeling a bit in the dark.
[10:53:17 EDT(-0400)] <colinclark> Do you have a quick second to summarize what issues you worked on over the weekend?
[10:53:46 EDT(-0400)] <yura> colinclark: great, I d love to take a look
[10:54:08 EDT(-0400)] <colinclark> I reviewed and committed Joan's second patch for FLUID-3197. Jacob has taken a look and has pointed out another issue with keyboard nav.
[10:54:30 EDT(-0400)] <laurel> colinclark, Justin_o: FLUID-3192 - checked third party licenses. all ok. where can I help next?
[10:55:40 EDT(-0400)] * jgarciavila (n=quassel@62.97.110.250) has joined #fluid-work
[10:56:26 EDT(-0400)] <Bosmo1> Hi there Colin
[10:56:28 EDT(-0400)] <michelled> hi jgarciavila, you just missed Colin mentioning that he committed your second patch for FLUID-3197
[10:56:33 EDT(-0400)] <colinclark> Bosmo1: Do you have a quick second to summarize what issues you worked on over the weekend?
[10:56:40 EDT(-0400)] <Bosmo1> Yes, sorry, I meant to ping the list, but of course wasn't sure whether I could
[10:56:50 EDT(-0400)] <colinclark> no worries
[10:56:55 EDT(-0400)] <Bosmo1> So, I dealt with FLUID-3121, which is the issue wrt. mishandling of "container" in Reorderer
[10:57:20 EDT(-0400)] <michelled> jgarciavila: we also moved the weekly dev planning meeting to Mondays at 12:00 Eastern
[10:57:27 EDT(-0400)] <michelled> I hope you'll be able to make that time
[10:57:30 EDT(-0400)] <Bosmo1> I think we had already decided that the core issue was in Reorderer itself and its contract - the discussion that Hubick had in the JIRA was assuming that the contract was actually correct and we just wanted to enforce it
[10:58:04 EDT(-0400)] <Bosmo1> I made up a test case which added a listener that did roughly the same as Hubick's and verified that it now works...
[10:58:56 EDT(-0400)] <Bosmo1> I tidied up the "working with afterMove" page a little, and looked over the main ImageReorderer page... but there was too much that needed attention there to look at yesterday
[10:59:26 EDT(-0400)] <Bosmo1> Then I dealt with ENGAGE-96, which is this bizarre issue of the "loss" of the code I am convinced of writing, to correctly rewrite URLs which appear in page heads
[10:59:43 EDT(-0400)] <Bosmo1> Part of the issue there is this confusion between "infusion" and "fluid-infusion" as project and directory names
[11:00:12 EDT(-0400)] <Bosmo1> We seemed to verify it is just not reliable in Eclipse to have a directory name which does not agree with a project name - since try as you like, as soon as you check it out, Eclipse will try to revert to the project name
[11:00:37 EDT(-0400)] <jgarciavila> michelled: 12:00 Eastern is 18:00 CEST?
[11:00:43 EDT(-0400)] <Bosmo1> So wanting to go with a project name of "fluid-infusion" implies that we need to fix up any relative directory structure to also account for it as "fluid-infusion" rather than "infusion"
[11:00:47 EDT(-0400)] <michelled> jgarciavila: yes
[11:01:37 EDT(-0400)] <athena> i have a question about the inline select component, when someone has a moment
[11:02:01 EDT(-0400)] <Bosmo1> Hi athena
[11:02:17 EDT(-0400)] <athena> hey Bosmo1 (smile)
[11:02:26 EDT(-0400)] <athena> thanks for your email - i still owe you a response
[11:02:33 EDT(-0400)] <athena> i've been traveling for the last two weeks
[11:02:54 EDT(-0400)] <colinclark> Bosmo1: Thanks for the update. I'll take a look at my Image Reorderer issues (the broken unit tests and your comment about not using initView()) shortly.
[11:03:05 EDT(-0400)] <athena> i filed FLUID-3219 for the pager permutations issue we discussed
[11:04:54 EDT(-0400)] <jgarciavila> colin: so if Bosmol resolved the FLUID-3121, could you assign me a new jira to work with.
[11:06:47 EDT(-0400)] <michelled> jgarciavila: we are tying up the last little bits before the release.
[11:07:04 EDT(-0400)] <Bosmo1> Perhaps the documentation for FLUID-3122?
[11:10:14 EDT(-0400)] <colinclark> Bosmo1: Just catching up on your externals/project naming issue
[11:10:28 EDT(-0400)] <colinclark> There is a JIRA for this, and perhaps we should just go ahead and make some global directory name changes
[11:10:54 EDT(-0400)] <colinclark> engage-sketches should be called fluid-engage-server and its externals directory and project should be similarly named.
[11:10:55 EDT(-0400)] <colinclark> And so on.
[11:11:03 EDT(-0400)] <Bosmo1> ok
[11:11:13 EDT(-0400)] <colinclark> We'll have to check in with Justin_o about this, though.
[11:11:36 EDT(-0400)] <colinclark> lemme dig up the JIRA issue
[11:12:40 EDT(-0400)] <Justin_o> colinclark: you mean about the directory name...
[11:12:47 EDT(-0400)] <colinclark> Justin_o: yep
[11:14:33 EDT(-0400)] <colinclark> Bosmo1, Justin_o: http://issues.fluidproject.org/browse/ENGAGE-70
[11:14:57 EDT(-0400)] <colinclark> Bosmo1: Can you comment on this issue about how we should ensure that the directory names are the same as the project names?
[11:15:11 EDT(-0400)] <colinclark> And, to be clear, are you really sure you want to prefix every directory and project with fluid-?
[11:16:01 EDT(-0400)] <Bosmo1> Well... that is what I am sure I want to do (tongue)
[11:17:07 EDT(-0400)] <colinclark> Bosmo1: So can we get away with only having these names align within a checkout of fluid-all?
[11:17:24 EDT(-0400)] <Bosmo1> I guess - but where else might they not align?
[11:17:29 EDT(-0400)] <Justin_o> jgarciavila: sorry, trying to catch up on the logs a bit, you could work on FLUID-3195 if you are still looking for tasks
[11:17:35 EDT(-0400)] <colinclark> Or are we going to have to rename https://source.fluidproject.org/svn/fluid/infusion to https://source.fluidproject.org/svn/fluid/fluid-infusion
[11:17:45 EDT(-0400)] <Bosmo1> Ah, I see
[11:17:49 EDT(-0400)] <Bosmo1> No, we shouldn't have to rename that
[11:18:05 EDT(-0400)] <colinclark> So we're all on the same page, you proposal is:
[11:18:13 EDT(-0400)] <Bosmo1> But we would have to make sure that any project "cross-links" were made assuming the fluid- prefix was in place
[11:18:14 EDT(-0400)] <colinclark> fluid-all/
[11:18:31 EDT(-0400)] <colinclark> fluid-infusion/ -> https://source.fluidproject.org/svn/fluid/infusion
[11:18:36 EDT(-0400)] <Bosmo1> So, I left some things behind in the ENGAGE-96 work that still assume the "inter-project relative path" is simply "infusion"
[11:18:38 EDT(-0400)] <jgarciavila> justin: let me take a look at FLUID-3195
[11:19:15 EDT(-0400)] <colinclark> fluid-engage-client/ -> http://source.fluidproject.org/svn/incubator/engage-client/trunk/
[11:19:33 EDT(-0400)] <colinclark> fluid-engage-server/ -> http://source.fluidproject.org/svn/incubator/engage-sketches/
[11:20:00 EDT(-0400)] <colinclark> And to go with this, we'll ensure that the client and server directories are properly named when we promote them from the incubator to core.
[11:20:23 EDT(-0400)] <Bosmo1> That seems fine - I have added this to my comment on the issue
[11:20:42 EDT(-0400)] <Justin_o> jgarciavila: thanks
[11:20:54 EDT(-0400)] <Justin_o> please let us know if you have any questions about it
[11:21:07 EDT(-0400)] <jgarciavila> ok
[11:24:45 EDT(-0400)] <jgarciavila> justin: could you place a comment extending the description of the JIRA. Tasks to be done. Thanks. (FLUID-3195).
[11:28:43 EDT(-0400)] * michelled (n=team@142.150.154.193) has joined #fluid-work
[11:31:15 EDT(-0400)] <jessm> standup
[11:32:39 EDT(-0400)] * elicochran (n=elicochr@dhcp-169-229-212-41.LIPS.Berkeley.EDU) has joined #fluid-work
[11:33:01 EDT(-0400)] <colinclark> jgarciavila, Bosmo1, etc.: Standup is now
[11:33:05 EDT(-0400)] <colinclark> in connect
[11:33:06 EDT(-0400)] <Bosmo1> arg!
[11:34:02 EDT(-0400)] <jgarciavila> in connect
[11:40:10 EDT(-0400)] <Bosmo1> Aha!
[11:40:17 EDT(-0400)] <Bosmo1> The mailing list has just started up
[11:42:15 EDT(-0400)] <colinclark> (smile)
[11:55:07 EDT(-0400)] <colinclark> "Bug freeze: No more bugs will go into the repo today!" (tongue)
[11:55:39 EDT(-0400)] * Justin_o (n=Justin@142.150.154.171) has joined #fluid-work
[11:55:56 EDT(-0400)] <Bosmo1> !!!
[11:55:58 EDT(-0400)] <athena> lol.
[11:56:02 EDT(-0400)] <athena> are you guys still doing bug fixes?
[11:56:11 EDT(-0400)] <Bosmo1> I believe not?
[11:56:20 EDT(-0400)] <athena> ok
[11:56:22 EDT(-0400)] <Bosmo1> Well
[11:56:28 EDT(-0400)] <athena> so any bugs that are still there will probably be in 1.1.2?
[11:56:28 EDT(-0400)] <Bosmo1> I could try to get in a fix for AC's Blocker
[11:56:38 EDT(-0400)] <Bosmo1> It would not take long and the issue is quite serious
[11:57:51 EDT(-0400)] <Bosmo1> http://issues.fluidproject.org/browse/FLUID-3224
[11:58:11 EDT(-0400)] <athena> the issue i probably care most about is http://issues.fluidproject.org/browse/FLUID-3219
[11:58:20 EDT(-0400)] <athena> but we can code around that for the time being if we have to, i think
[11:58:24 EDT(-0400)] <Bosmo1> ack
[11:58:33 EDT(-0400)] <Bosmo1> Yes, Pager work is definitely being pushed out, I'm afraid...
[11:58:38 EDT(-0400)] <athena> sorry about the bold - i hit something weird
[11:58:39 EDT(-0400)] <athena> ok
[11:58:39 EDT(-0400)] <colinclark> athena: We're trying to wrap things up. This has been quite a release cycle for us. (wink)
[11:58:44 EDT(-0400)] <athena> well, just so we know (smile)
[11:58:49 EDT(-0400)] <athena> yeah i get that impression!
[11:59:03 EDT(-0400)] <Bosmo1> We will have a proper and authoritative Pager Spring at November start
[11:59:07 EDT(-0400)] <Bosmo1> er Sprint
[11:59:19 EDT(-0400)] <athena> i'm just trying to figure out what we're going to include in uPortal 3.2
[11:59:25 EDT(-0400)] <athena> i think i actually dreamt about release planning last night
[11:59:27 EDT(-0400)] * athena sighs
[11:59:46 EDT(-0400)] * clown (n=clown@142.150.154.101) has joined #fluid-work
[11:59:47 EDT(-0400)] <Bosmo1> I dreamed about endlessly shifting boxes out of a house last night (tongue)
[12:00:59 EDT(-0400)] <athena> lol
[12:01:01 EDT(-0400)] <athena> are you moved in now?
[12:01:50 EDT(-0400)] * fj4000 (n=Jacob@142.150.154.164) has joined #fluid-work
[12:04:56 EDT(-0400)] <colinclark> Bosmo1: let's leave 3224 for the next release, unless Justin_o feels different.
[12:05:11 EDT(-0400)] <colinclark> I hate to not fix bugs, but we've really got to freeze this code base if we hope to get Engage 0.1 out the door, too. (wink)
[12:05:34 EDT(-0400)] <athena> by the way, colinclark, did i tell you i got all our back-end support for multiple themes fixed last week?
[12:05:40 EDT(-0400)] <athena> clears the way for a fluid-driven mobile theme
[12:05:47 EDT(-0400)] <colinclark> athena: Last I heard, were in the midst of it. Congratulations!
[12:06:21 EDT(-0400)] <athena> hey i'm just excited about having something where we don't have to write tons of css
[12:06:21 EDT(-0400)] <Justin_o> colinclark: i think we can leave FLUID-3224 for after relesae
[12:07:18 EDT(-0400)] <Bosmo1> ok
[12:07:28 EDT(-0400)] <Bosmo1> Praise God, I found my package....
[12:08:19 EDT(-0400)] <colinclark> fj4000 is gonna be excited to work on mFSS with you, then, athena
[12:08:26 EDT(-0400)] <colinclark> Bosmo1: I'm gonna leave that one. (tongue)
[12:08:28 EDT(-0400)] <fj4000> indeeeeed
[12:08:29 EDT(-0400)] <athena> sounds great!
[12:08:41 EDT(-0400)] <athena> fj4000: if you have time, i'd of course really appreciate the help
[12:08:57 EDT(-0400)] <athena> though it already looks better than anything i would have come up with
[12:09:20 EDT(-0400)] <athena> a discussion about within-portlet CSS might also be helpful
[12:09:25 EDT(-0400)] <athena> but none of that is urgent
[12:10:44 EDT(-0400)] <fj4000> athena: im at your service (tongue)
[12:10:56 EDT(-0400)] <athena> awesome (smile)
[12:11:15 EDT(-0400)] <athena> the background is that we've been having a long debate about how to mark up content inside the portlet itself
[12:11:20 EDT(-0400)] <fj4000> do you have my skype nick?
[12:11:30 EDT(-0400)] <athena> nope
[12:11:36 EDT(-0400)] <fj4000> jacob.farber
[12:11:40 EDT(-0400)] <athena> ok
[12:11:49 EDT(-0400)] <athena> mine is "swimathena" (really old nick . . . )
[12:11:57 EDT(-0400)] <fj4000> ok, ill add you
[12:12:02 EDT(-0400)] <athena> thanks!
[12:12:36 EDT(-0400)] <athena> i have to do some catchup on all the stuff i've missed in the last 2 weeks, but i'll have to write up a summary of where we're at tonight
[12:12:47 EDT(-0400)] <Justin_o> yura: would you mind finishing up FLUID-3222
[12:12:47 EDT(-0400)] <fj4000> cool
[12:13:12 EDT(-0400)] <yura> Justin_o: sure not a problem
[12:14:12 EDT(-0400)] <Justin_o> yura: thanks
[12:14:45 EDT(-0400)] <Justin_o> yura: we may not actually need the version number in some of the cases that we have it in engage
[12:14:46 EDT(-0400)] <colinclark> Bosmo1, Justin_o: On the subject of adding JIRA issues, I wonder about this one:
[12:14:48 EDT(-0400)] <colinclark> http://issues.fluidproject.org/browse/ENGAGE-106
[12:15:17 EDT(-0400)] <colinclark> Any thoughts? It's a fix in Infusion required for Engage.
[12:18:13 EDT(-0400)] <Justin_o> colinclark, michelled, and anyone else: are any of you interested in reviewing FLUID-3121
[12:18:24 EDT(-0400)] <Bosmo1> Wel, I assume we should fix it
[12:18:27 EDT(-0400)] <Bosmo1> It is just a 1-line fix
[12:18:34 EDT(-0400)] <colinclark> Justin_o: ^ Thoughts?
[12:18:43 EDT(-0400)] <colinclark> In short, if we don't fix it, we'll have to ship a custom version of Infusion with Engage 0.1
[12:18:50 EDT(-0400)] <Bosmo1> I find it perplexing and perverse that calling toString on a Java object does not have the effect it would on a Javascript object, but there it is....
[12:18:55 EDT(-0400)] <colinclark> It is a change to a fairly core framework function, though.
[12:19:12 EDT(-0400)] <colinclark> Bosmo1: Do you know if there are unit tests that would confirm that my patch is safe?
[12:20:07 EDT(-0400)] <yura> Justin_o: you are right, engage won't need the version
[12:21:05 EDT(-0400)] <Bosmo1> colinclark: I can't imagine it would be possible to write unit tests that it was functional... but there are lots of data binding tests that use parseEL
[12:21:18 EDT(-0400)] <colinclark> Bosmo1: That's perfect.
[12:21:39 EDT(-0400)] <colinclark> So if the binding tests pass, we can confirm that this fix doesn't affect existing code on the client-side.
[12:21:56 EDT(-0400)] <Justin_o> Bosmo1: are there unit tests for kettle?
[12:22:17 EDT(-0400)] <Bosmo1> Justin_o: There are none... since we don't really know how to set up an "environment" for it yet...
[12:22:35 EDT(-0400)] <Justin_o> Bosmo1: okay...
[12:22:39 EDT(-0400)] <Bosmo1> I guess we either need a kind of "Mock Java Host", or even worse, set up some kind of scheme for firing up jsUnit within a Java driver
[12:23:33 EDT(-0400)] <Bosmo1> colinclark: Yes, there are lots of tests within RendererTests.js that will invoke parseEl... not to say, every invocation of invokeGlobalFunction calls it (tongue)
[12:23:49 EDT(-0400)] <Bosmo1> Which, as we know, is called at the startup of every Fluid component...
[12:24:14 EDT(-0400)] <colinclark> Bosmo1: that's what I told Justin. (smile)
[12:24:49 EDT(-0400)] <Bosmo1> colinclark: I am now starting to get mails from you from 2 days ago...
[12:25:02 EDT(-0400)] <colinclark> excellent. finally!
[12:25:35 EDT(-0400)] <Bosmo1> Just a reminder for all of you to take my CARET email address out of whatever address books you have
[12:25:58 EDT(-0400)] <Bosmo1> I won't write my new address here since it will probably be harvested by spambots (tongue)
[12:26:15 EDT(-0400)] <colinclark> ok
[12:26:41 EDT(-0400)] <colinclark> so Bosmo1, you preferred email address is colorado?
[12:26:43 EDT(-0400)] <colinclark> Or ponder?
[12:26:58 EDT(-0400)] <Bosmo1> Well, I guess it depends on the function
[12:27:04 EDT(-0400)] <Bosmo1> colorado for work-related things I suppose
[12:27:28 EDT(-0400)] <Bosmo1> I have successfully managed to change all my Fluid list subscriptions over to that now...
[12:27:45 EDT(-0400)] <Bosmo1> OK, I will set off for the office now
[12:28:09 EDT(-0400)] <colinclark> ok, see you soon
[12:32:46 EDT(-0400)] <Justin_o> colinclark, Bosmo1: I think we should be adding ENGAGE-106 to bug parade
[12:33:12 EDT(-0400)] <colinclark> Justin_o: thanks, let's do it and put it on Bosmo1's to do list
[12:33:13 EDT(-0400)] <colinclark> (wink)
[13:20:27 EDT(-0400)] <colinclark> Justin_o: I just committed my unit test fix for Image Reorderer against FLUID-3122
[13:20:49 EDT(-0400)] <colinclark> It was caused by our change to ImageReorderer.css. So the code was working, but of course since the layout was different, the results of the tests were different.
[13:21:07 EDT(-0400)] <colinclark> I'm going to link the two Image Reorderer issues since they are related in this way
[13:22:05 EDT(-0400)] <Justin_o> colinclark: ah i see... makes sense... I think bosmo1 was also waiting for an explanation to something that he saw in his code reivew
[13:22:17 EDT(-0400)] <Justin_o> he left a comment on FLUID-3131
[13:22:57 EDT(-0400)] <colinclark> Justin_o: Yep, looking at that now.
[13:24:42 EDT(-0400)] <Justin_o> colinclark: thanks
[13:42:23 EDT(-0400)] <fj4000> jessm, michelled, colinclark FLUID-3197 needs another review (warning)
[13:42:38 EDT(-0400)] <fj4000> Justin_o : ^
[13:45:18 EDT(-0400)] <colinclark> Justin_o: I've committed several Image Reorderer changes against both FLUID-3122 and 3131. Here's a summary of what I've done:
[13:45:55 EDT(-0400)] <colinclark> 1. I moved the old ImageReorderer.css file into the unit tests folder since it's now only used by the unit tests
[13:46:08 EDT(-0400)] <colinclark> 2. I've removed the old RSF template for Image Reorderer
[13:46:31 EDT(-0400)] <colinclark> 3. I've updated fluid.reorderImages() based on Antranig's suggestion to use fluid.initView() instead of merging my own options myself, etc.
[13:46:48 EDT(-0400)] <colinclark> But now that I think more clearly about it, I wonder if #1 is a breaker for some people.
[13:46:51 EDT(-0400)] <colinclark> Justin_o: ^
[13:52:00 EDT(-0400)] <yura> colinclark: i was asking Justin if engage components need fluid's version or just fluid?
[13:55:43 EDT(-0400)] <colinclark> yura: You can just link against "fluid," rather than "fluid_1_1"
[13:55:45 EDT(-0400)] <colinclark> or whatever
[13:56:13 EDT(-0400)] <yura> ok thanks
[14:04:38 EDT(-0400)] <colinclark> Justin_o: Ok
[14:05:12 EDT(-0400)] <colinclark> I am now confident that I've done a horrible thing by getting rid of OldImageReorderer.css
[14:05:18 EDT(-0400)] <colinclark> Here's the plan of attack, if you approve:
[14:05:33 EDT(-0400)] <colinclark> 1. Move OldImageReorderer.css back in the core as "ImageReorderer.css"
[14:05:47 EDT(-0400)] <colinclark> 2. Move the new ImageReorderer.css into the demos folder.
[14:06:06 EDT(-0400)] <colinclark> 3. Update the demo portal to explain how this demo uses a new and improved custom style sheet
[14:06:31 EDT(-0400)] <colinclark> 4. Include a README file inside the reorderer/css folder explaining how this CSS is deprecated.
[14:07:00 EDT(-0400)] <colinclark> Justin_o: Seem reasonable?
[14:07:04 EDT(-0400)] <Justin_o> colinclark: okay... that seems like a reasonable approach
[14:07:11 EDT(-0400)] <colinclark> sorry about this (sad)
[14:31:33 EDT(-0400)] <colinclark> Justin_o: Ok, I've committed
[14:31:43 EDT(-0400)] <fj4000> Justin_o: 3209 is now done done
[14:31:47 EDT(-0400)] <colinclark> Someone should review these changes. Maybe Boz?
[14:31:58 EDT(-0400)] <colinclark> And perhaps Jacob real quick, too?
[14:32:35 EDT(-0400)] <Justin_o> colinclark: sounds good
[14:33:08 EDT(-0400)] <fj4000> I can help
[14:37:59 EDT(-0400)] <colinclark> Justin_o: Okay, I've filed a separate issue for the Image Reorderer documentation so that we can wind down FLUID-3122 for bug parade.
[14:38:01 EDT(-0400)] <colinclark> http://issues.fluidproject.org/browse/FLUID-3226
[14:39:16 EDT(-0400)] <Justin_o> great, thanks...
[14:39:48 EDT(-0400)] <colinclark> Ok, so I've marked 3122 and 3131 as resolved.
[14:39:54 EDT(-0400)] <colinclark> I need Antranig to review FLUID-3131
[14:40:02 EDT(-0400)] <colinclark> I'd appreciate Jacob and Antranig both taking a look at FLUID-3122
[14:40:09 EDT(-0400)] <colinclark> fj4000: ^
[14:42:20 EDT(-0400)] <fj4000> Done
[15:01:55 EDT(-0400)] <michelled> fj4000: are you done with all the portal changes?
[15:02:06 EDT(-0400)] <fj4000> yes
[15:02:23 EDT(-0400)] <michelled> cool - I'll work on freezing the final report now
[15:06:52 EDT(-0400)] <colinclark> Justin_o: I've reviewed FLUID-3121. +1, Antranig did a good and thorough job.
[15:10:19 EDT(-0400)] <Justin_o> colinclark: thanks.... is it ready to be closed?
[15:12:11 EDT(-0400)] <colinclark> Justin_o: yes
[15:18:19 EDT(-0400)] <fj4000> colinclark: FLUID-3181 - could you review it?
[15:22:10 EDT(-0400)] <colinclark> fj4000: FLUID-3181: I approve.
[15:22:19 EDT(-0400)] <colinclark> fj4000: Can michelled freeze the Final Report now?
[15:22:35 EDT(-0400)] <fj4000> Yes, if my commits have been reviewd,im all done
[15:22:47 EDT(-0400)] <colinclark> fj4000: You tell me: are all your commits reviewed?
[15:24:42 EDT(-0400)] <colinclark> michelled: You're good to go
[15:24:47 EDT(-0400)] <michelled> thx
[15:40:52 EDT(-0400)] <colinclark> Justin_o: I'm just gonna check the dependency files for each of "my" components
[15:41:33 EDT(-0400)] <Justin_o> colinclark: thanks
[15:59:59 EDT(-0400)] <Justin_o> colinclark: is FLUID-3131 ready for review again
[16:00:46 EDT(-0400)] <colinclark> Justin_o: yep
[16:00:59 EDT(-0400)] <colinclark> I've resolved it, and it's ready for Antranig to take a quick look at. Shouldn't be more than 30 seconds of work
[16:01:29 EDT(-0400)] <Justin_o> colinclark: thanks...
[16:03:19 EDT(-0400)] <michelled> fj4000: could you take a quick look at the final report to see if it looks reasonable?
[16:03:29 EDT(-0400)] <michelled> http://build.fluidproject.org:8095/finalreport/html/index.html
[16:03:46 EDT(-0400)] <fj4000> sure
[16:03:53 EDT(-0400)] <laurel> Justin_o: uploaded a patch to 3192 for all the copyrights.
[16:04:15 EDT(-0400)] <laurel> (except demo's directory which you just did).
[16:04:39 EDT(-0400)] <Justin_o> laurel thanks
[16:05:34 EDT(-0400)] <laurel> can I be useful elsewhere?
[16:05:59 EDT(-0400)] * Bosmon (n=Bosmon@128.138.207.2) has joined #fluid-work
[16:06:07 EDT(-0400)] <michelled> fj4000: do you know where in the demo portal I need to remove the final report specific stuff?
[16:07:23 EDT(-0400)] <fj4000> on the home page
[16:07:28 EDT(-0400)] <fj4000> there is a huge link at the top
[16:07:37 EDT(-0400)] <fj4000> it says "Go Back...."
[16:07:55 EDT(-0400)] <colinclark> Bosmon: you here now?
[16:08:07 EDT(-0400)] <colinclark> Justin_o probably has a few minor reviews for you
[16:08:10 EDT(-0400)] <laurel> jamon: virtual server down??
[16:10:04 EDT(-0400)] <Bosmon> Hi there, I am here
[16:10:28 EDT(-0400)] <colinclark> Bosmon: I made some Image Reorderer-related changes.
[16:10:58 EDT(-0400)] <colinclark> Let me just dig up the tickets
[16:11:09 EDT(-0400)] <colinclark> Ok, so this one is super-easy:
[16:11:10 EDT(-0400)] <colinclark> http://issues.fluidproject.org/browse/FLUID-3131
[16:11:24 EDT(-0400)] <colinclark> I did indeed find no reason not to use fluid.initView(), so I implemented the change.
[16:11:28 EDT(-0400)] <colinclark> Should take a split-second to verify.
[16:12:39 EDT(-0400)] <Justin_o> colinclark: did you need Bosmon to review ENGAGE-106 still as well
[16:13:33 EDT(-0400)] <colinclark> Justin_o: I think Bosmon actually needs to implement ENGAGE-106
[16:13:35 EDT(-0400)] <colinclark> Or I can do it
[16:13:43 EDT(-0400)] <Bosmon> the cast?
[16:13:44 EDT(-0400)] <colinclark> Now that I've got some time.
[16:13:47 EDT(-0400)] <colinclark> Bosmon: Yep.
[16:13:52 EDT(-0400)] <colinclark> Want to apply my patch, or shall I?
[16:13:59 EDT(-0400)] <colinclark> Maybe I'll do it while you review 3131 again?
[16:14:25 EDT(-0400)] <michelled> fj4000: I just committed the change for FLUID-3210. I should have made a patch for forgot to - sorry.
[16:14:35 EDT(-0400)] <michelled> fj4000: can you review it for me?
[16:14:43 EDT(-0400)] <colinclark> Bosmon: ?
[16:14:47 EDT(-0400)] <michelled> fj4000, Justin_o: I think I'm done with 3210
[16:14:50 EDT(-0400)] <fj4000> sure
[16:15:13 EDT(-0400)] <Bosmon> OK, FLUID-3131 looks cool
[16:15:18 EDT(-0400)] <colinclark> Bosmon: great
[16:15:22 EDT(-0400)] <Bosmon> Do I need to do something to the JIRA, or yell something to Jess?
[16:15:31 EDT(-0400)] <Bosmon> Where is that CATT anyway... (tongue)
[16:15:37 EDT(-0400)] <colinclark> Bosmon: to Justin_o, since he's back in his throne full-time now
[16:15:46 EDT(-0400)] <Bosmon> Ah, a single occupant of a dual throne (tongue)
[16:15:51 EDT(-0400)] <Justin_o> Bosmon: if it is reviewed and tested... you can close it
[16:16:02 EDT(-0400)] <colinclark> Bosmon: So a few things to talk about with FLUID-3122 if you have a second
[16:16:19 EDT(-0400)] <Bosmon> ok
[16:16:21 EDT(-0400)] <Bosmon> Go ahead
[16:16:30 EDT(-0400)] <colinclark> First of all, I filed a new bug for the API documentation changes that need to happen, since docs can happen after code freeze.
[16:16:30 EDT(-0400)] <colinclark> http://issues.fluidproject.org/browse/FLUID-3226
[16:16:35 EDT(-0400)] <Bosmon> Justin_o: Surely only ROYALTY can close JIRAs!
[16:17:13 EDT(-0400)] <colinclark> Bosmon: Secondly, I realized that Jacob and I were overly enthusiastic with our new Image Reorderer demo in one particular way.
[16:17:25 EDT(-0400)] <Justin_o> Bosmon: the theme of this release has been "Delegation of royalty" (tongue)
[16:17:42 EDT(-0400)] <colinclark> We actually modified the ImageReorderer.css based on the newer, simpler markup in the demo.
[16:17:48 EDT(-0400)] <colinclark> But of course this causes older users to break.
[16:17:53 EDT(-0400)] <colinclark> For example, that's why the tests were broken.
[16:17:57 EDT(-0400)] <Bosmon> ImageReorderer tests are really pretty scary under Opera 10 (tongue)
[16:18:04 EDT(-0400)] <Bosmon> You see everything whizz about like crazy...
[16:18:12 EDT(-0400)] <colinclark> yeah, that happens everywhere
[16:18:14 EDT(-0400)] <colinclark> kind of cool
[16:18:16 EDT(-0400)] <Bosmon> ah
[16:18:20 EDT(-0400)] <colinclark> So ultimately, there was a backwards compatibility issue there.
[16:18:25 EDT(-0400)] <Bosmon> I'm sure they used to be "quiet"
[16:18:31 EDT(-0400)] <Bosmon> Was it to do with the width specification?
[16:18:39 EDT(-0400)] <colinclark> So, in the end, I restored the core ImageReorderer.css file to the older version.
[16:18:55 EDT(-0400)] <colinclark> And we moved the new ImageReorderer.css into the demo, alongside its markup
[16:18:58 EDT(-0400)] <Bosmon> Yes, I saw the "oldImageReorderer.css" now
[16:19:04 EDT(-0400)] <colinclark> right
[16:19:12 EDT(-0400)] <colinclark> So OldImageReorderer.css is back to being ImageReorderer.css
[16:19:29 EDT(-0400)] <colinclark> so that someone who is already using Image Reorderer won't get a nasty surprise when they upgrade to Infusion 1.1.2
[16:19:55 EDT(-0400)] <colinclark> But, awkwardly, it does mean that we're recommending users who are starting with Image Reorderer for the first time actually get their styles from the demo folder instead.
[16:20:09 EDT(-0400)] <Bosmon> arg
[16:20:14 EDT(-0400)] <Bosmon> What is the nature of the difference?
[16:20:24 EDT(-0400)] <colinclark> Difference in CSS files?
[16:20:27 EDT(-0400)] <Bosmon> yes
[16:20:53 EDT(-0400)] <colinclark> fj4000 can answer that question better than me, but I believe it's just much simpler, and designed to style much simpler markup.
[16:21:02 EDT(-0400)] <colinclark> If you remember, the core markup and CSS for the Image Reorderer predates Fluid itself.
[16:21:23 EDT(-0400)] <colinclark> You might remember Seamus, the excellent designer from Berkeley who moved back to Ireland years ago, designed it way back in the day.
[16:24:24 EDT(-0400)] <Bosmon> Justin_o: Anything on the plate?
[16:24:41 EDT(-0400)] <Bosmon> But I believe we were going to talk FLUID-3122
[16:25:05 EDT(-0400)] <colinclark> Bosmon: I am talking about it
[16:25:11 EDT(-0400)] <Bosmon> Are you?
[16:25:14 EDT(-0400)] <Bosmon> (smile)
[16:25:15 EDT(-0400)] <colinclark> I thought I was
[16:25:16 EDT(-0400)] <colinclark> (tongue)
[16:25:28 EDT(-0400)] <Bosmon> Perhaps you are actually talking about the Egyptian Ibis....
[16:25:37 EDT(-0400)] <colinclark> Hmm
[16:25:47 EDT(-0400)] <colinclark> A surprise to me, if that's the case.
[16:25:48 EDT(-0400)] <Bosmon> I mean, I see the CSS is talked about in the comments
[16:25:55 EDT(-0400)] <Bosmon> But how is this related to the "old id-based scheme"?
[16:26:16 EDT(-0400)] <colinclark> Bosmon: the whole issue was to create a simpler and more approachable way into the Reorderer for our users
[16:26:23 EDT(-0400)] <colinclark> So that was where the new demo came from
[16:27:19 EDT(-0400)] <Bosmon> ok
[16:27:23 EDT(-0400)] <colinclark> Anyway, I guess there's little more to say than to describe the point that we want to eventually promote this demo as the standard way to do things
[16:27:38 EDT(-0400)] <colinclark> but there is no easy way to do so without breaking compatibility for existing users of that CSS
[16:27:49 EDT(-0400)] <colinclark> except to come up with some new name for the new CSS, which strikes me as a bit confusing and problematic
[16:29:35 EDT(-0400)] <Bosmon> What on earth is "jQuery chili" (tongue)
[16:30:39 EDT(-0400)] <athena> i don't know but i bet all the dollar signs make it extra tasty
[16:30:47 EDT(-0400)] <colinclark> lol
[16:30:56 EDT(-0400)] <colinclark> Chilli is the code formatter fj4000 uses in the demo portal
[16:31:01 EDT(-0400)] <Bosmon> aha
[16:31:34 EDT(-0400)] <colinclark> Bosmon: I'm noticing there is a failure in the Renderer tests.
[16:31:39 EDT(-0400)] <Bosmon> oh?
[16:31:53 EDT(-0400)] <colinclark> Selector Render Test module: UILink rendering
[16:32:07 EDT(-0400)] <Bosmon> As a result of ENGAGE-106?
[16:32:26 EDT(-0400)] <colinclark> I'm just checking that
[16:32:39 EDT(-0400)] <Bosmon> I guess it could have been my ENGAGE-96 thing of last night
[16:32:48 EDT(-0400)] <Bosmon> I could swear I ran the tests though...
[16:33:08 EDT(-0400)] <colinclark> Bosmon: yeah, it looks like it's not ENGAGE-106
[16:33:21 EDT(-0400)] <Bosmon> Crikey
[16:33:32 EDT(-0400)] <Bosmon> Yes, they fail for me too....
[16:33:41 EDT(-0400)] <Bosmon> Nasty
[16:35:51 EDT(-0400)] <Bosmon> Gah
[16:35:55 EDT(-0400)] <Bosmon> Terrible, awful carelessness
[16:35:57 EDT(-0400)] <Bosmon> Sorry (tongue)
[16:36:34 EDT(-0400)] <colinclark> Bosmon: No worries
[16:36:48 EDT(-0400)] <colinclark> michelled: I found that the InlineEdit tests are failing in Firefox 2.
[16:37:00 EDT(-0400)] <colinclark> We're not actively supporting FF2, but here's the culprit:
[16:37:01 EDT(-0400)] <colinclark> <span class='flc-undo' aria-live='polite' aria-relevant='all'>
[16:37:14 EDT(-0400)] <colinclark> or, put more clearly:
[16:37:18 EDT(-0400)] <colinclark> var markup = "<span class='flc-undo' aria-live='polite' aria-relevant='all'>"
[16:37:29 EDT(-0400)] <michelled> ack, I should have caught that
[16:37:33 EDT(-0400)] <colinclark> no worries
[16:37:40 EDT(-0400)] <colinclark> michelled: This is exactly something I encountered recently myself.
[16:37:48 EDT(-0400)] <colinclark> I need to take some anchors out of the tab order in the portal
[16:37:53 EDT(-0400)] <colinclark> and the portal JS code itself was emitting JS
[16:38:07 EDT(-0400)] <colinclark> but, just to be safe, I used jQuery to add the necessary attrs
[16:39:31 EDT(-0400)] <Bosmon> Sheesh... suddenly breakpoints are broken again
[16:39:42 EDT(-0400)] <Bosmon> WHY does bloody firebug get like this!!!!
[16:41:27 EDT(-0400)] <Bosmon> ....
[16:41:33 EDT(-0400)] <Bosmon> I just got a new message from Firefox
[16:41:39 EDT(-0400)] <Bosmon> Beginning. "Well, this is embarrassing"
[16:42:06 EDT(-0400)] <elicochran> Bosmon: I LOVE that message
[16:43:19 EDT(-0400)] <michelled> Justin_o, anastasiac, fj4000, colinclark, anyone else who was involved in creating the final report. I think we are now done FLUID-3210 but I'm not sure. I removed the 'back to the final report' from the demo index.html page and fj4000 changed all the 'more info' links to point to the wiki. Is there anything else you know of that needs to be done for this task?
[16:43:33 EDT(-0400)] <Bosmon> Hay Eli (smile)
[16:44:25 EDT(-0400)] <fj4000> i think that was it......
[16:44:42 EDT(-0400)] <Justin_o> i think that was it
[16:44:43 EDT(-0400)] <colinclark> Bosmon: I just got that message today, too. For the first time, in fact.
[16:45:06 EDT(-0400)] <elicochran> Hi Bosmon, sorry that you're struggling with Firebug... no love there.
[16:45:07 EDT(-0400)] <michelled> ok, then I think it can be closed Justin_o. I reviewed what fj4000 did and he reviewed what I did
[16:45:22 EDT(-0400)] <Justin_o> michelled thanks
[16:46:09 EDT(-0400)] <colinclark> michelled: Here's the InlineEdit ARIA issue in FF2, just FYI: http://issues.fluidproject.org/browse/FLUID-3227
[16:46:19 EDT(-0400)] <michelled> thanks
[16:46:24 EDT(-0400)] <laurel> so colinclark: this is what we want for component not dependent on fluid version? fluid = fluid || {};
[16:46:35 EDT(-0400)] <colinclark> laurel:
[16:46:50 EDT(-0400)] <colinclark> You'll want to remove any references to a version of Fluid.
[16:47:14 EDT(-0400)] <colinclark> You really don't even need that Colinist block at the top
[16:47:37 EDT(-0400)] <colinclark> And then in your anonymous closure arguments, you can remove the fluid argument and just freely use "fluid" everywhere.
[16:48:12 EDT(-0400)] <Bosmon> (smile)
[16:48:16 EDT(-0400)] <Bosmon> Even Colin is now a Colinist (smile)
[16:48:56 EDT(-0400)] <Bosmon> OK... shall I make a separate JIRA for the renderer test failure, or continue to commit under ENGAGE-96?
[16:49:59 EDT(-0400)] <colinclark> laurel: For background reading later, this document describes how our versioning approach works in JS:
[16:50:00 EDT(-0400)] <colinclark> http://wiki.fluidproject.org/display/fluid/Versioning+the+Fluid+Framework
[16:53:52 EDT(-0400)] <colinclark> Bosmon: Another small "needs review:" http://issues.fluidproject.org/browse/ENGAGE-106
[16:53:58 EDT(-0400)] <colinclark> I ran all the tests and they are passing.
[16:54:43 EDT(-0400)] <colinclark> We should really fix this issue at its root in Kettle later, so that we don't have to leak any awareness of Rhino into the core framework.
[16:54:56 EDT(-0400)] <colinclark> Not that this one really does, particularly.
[16:55:04 EDT(-0400)] <colinclark> Justin_o: ^
[16:59:23 EDT(-0400)] <Justin_o> Bosmon, colinclark, michelled, fj4000: yura has gone through and checked the dependencies for the components. He has submitted a patch (FLUID-2724) could you all please review the patch with regards to the components you've worked on.
[16:59:46 EDT(-0400)] * laurel (n=Laurel@142.150.154.178) has left #fluid-work
[17:00:26 EDT(-0400)] <colinclark> Justin_o: For sure. On it now for Uploader and Inline Edit
[17:01:24 EDT(-0400)] <Justin_o> colinclark: thanks
[17:03:45 EDT(-0400)] <michelled> Justin_o: the table of contents tests broke in revision 8227
[17:04:55 EDT(-0400)] <michelled> there was a change in the renderer that caused them to break that I believe Bosmon is working on
[17:11:25 EDT(-0400)] <Bosmon> Yes
[17:11:33 EDT(-0400)] <Bosmon> Shall I just commit it under FLUID-96?
[17:12:43 EDT(-0400)] <michelled> hey Bosmon, did you see my comment above about the broken table of contents tests?
[17:12:48 EDT(-0400)] <Bosmon> Yes
[17:13:08 EDT(-0400)] <michelled> ah, great - you have a fix then?
[17:13:20 EDT(-0400)] <Bosmon> Yes
[17:13:30 EDT(-0400)] <Bosmon> Sorry, I meant ENGAGE-96
[17:14:41 EDT(-0400)] <Justin_o> Bosmon: that sounds right, that just needs to be reviewed and tested
[17:16:01 EDT(-0400)] <Bosmon> Justin_o: I need to make a further commit
[17:16:50 EDT(-0400)] <Justin_o> okay....
[17:17:08 EDT(-0400)] <Justin_o> but it just has to be reviewed and tested tonight because of the code freeze in infusion
[17:19:06 EDT(-0400)] <Justin_o> colinclark: did you happen to review any of the commits against FLUID-3215
[17:19:34 EDT(-0400)] <Bosmon> Table of Contents tests now run for me...
[17:19:40 EDT(-0400)] <michelled> yay
[17:19:41 EDT(-0400)] <Bosmon> Although oddly I don't see any of the test output under FF 3.5
[17:21:08 EDT(-0400)] <colinclark> fj4000: FYI, a post-1.1.2 bug for you: http://issues.fluidproject.org/browse/FLUID-3228
[17:21:15 EDT(-0400)] <fj4000> thanks
[17:24:39 EDT(-0400)] <Bosmon> OK, I have reviewed and closed ENGAGE-106
[17:26:08 EDT(-0400)] <colinclark> Bosmon: Thanks, dude.
[17:27:12 EDT(-0400)] <colinclark> Justin_o: I've reviewed portions of FLUID-2724 that are relevant to me
[17:27:21 EDT(-0400)] <colinclark> And in fact made a commit against Uploader's dependency file
[17:27:31 EDT(-0400)] <colinclark> Hopefully that won't wreak havoc on yura's patch
[17:27:35 EDT(-0400)] <Justin_o> colinclark: thanks
[17:27:48 EDT(-0400)] <Justin_o> colinclark: would you also be able to review FLUID-3197
[17:28:30 EDT(-0400)] <colinclark> Justin_o: Yep
[17:32:05 EDT(-0400)] <colinclark> Bosmon: Ok, can you review your part of FLUID-2724?
[17:32:55 EDT(-0400)] <colinclark> Check yura's patch and then double-check the dependencies files for components you lead
[17:33:54 EDT(-0400)] <Bosmon> Yes, I have been looking at it
[17:34:07 EDT(-0400)] <Bosmon> It is somehow puzzling...
[17:35:33 EDT(-0400)] <Bosmon> So, I see "JSON" has been added to the Reorderer
[17:35:47 EDT(-0400)] <Bosmon> Is this because it is newly recognised as a module? Or because there was an error before
[17:36:12 EDT(-0400)] <Justin_o> Bosmon: i wonder if it is pulled in through another dependency
[17:36:32 EDT(-0400)] <colinclark> Bosmon: I suspect it was an error
[17:36:37 EDT(-0400)] <Bosmon> ok
[17:37:20 EDT(-0400)] <Bosmon> It is used in just one place, the afterMoveCallbackUrl branch
[17:37:39 EDT(-0400)] <Bosmon> But I assume we should add JSON to the globals declaration at the top of the file
[17:37:44 EDT(-0400)] <Bosmon> Presumably it currently fails lintng...
[17:38:52 EDT(-0400)] <Bosmon> Somehow JSLint doesn't spot it... perhaps it has a bug (tongue)
[17:39:12 EDT(-0400)] <colinclark> Justin_o: Reviewed +1: http://issues.fluidproject.org/browse/FLUID-3197
[17:39:40 EDT(-0400)] <colinclark> Bosmon: Or perhaps Crockford treats his own libraries with extra privilege.
[17:39:45 EDT(-0400)] <Bosmon> ah,it does spot it... but somehow doesn't complain Global Array, JSON, fluid_1_1, jQuery
[17:39:53 EDT(-0400)] <colinclark> Hey, speaking of JSON, did you know that it's implemented natively in the latest browsers?
[17:39:59 EDT(-0400)] <Bosmon> yes, I had read that
[17:40:06 EDT(-0400)] <Justin_o> colinclark: thanks
[17:40:06 EDT(-0400)] <colinclark> And is actually part of the ES 5 spec?
[17:40:16 EDT(-0400)] <Bosmon> It is certainly better than that highly untrustworthy-looking heap that we have (tongue)
[17:40:37 EDT(-0400)] <colinclark> Bosmon: The DeJSONalizer, you mean? (tongue)
[17:41:35 EDT(-0400)] <Bosmon> shush
[17:41:40 EDT(-0400)] <Bosmon> I am talking about the JSON.js code
[17:41:50 EDT(-0400)] <colinclark> lol
[17:43:57 EDT(-0400)] * clown (n=clown@142.150.154.101) has left #fluid-work
[17:45:43 EDT(-0400)] <Bosmon> OK, my part of FLUID-2724 looks fine
[17:45:51 EDT(-0400)] <Bosmon> Could you give ENGAGE-96 a PENGUIN REVIEW?
[17:46:05 EDT(-0400)] <colinclark> Bosmon: Excellent. I think everyone else has approved, too. Can you commit Yura's 2724 patch?
[17:46:10 EDT(-0400)] <Bosmon> ok
[17:46:14 EDT(-0400)] <colinclark> Bosmon: michelled has reviewed 96
[17:46:21 EDT(-0400)] <Bosmon> After my most recent commit?
[17:46:22 EDT(-0400)] <colinclark> she enjoyed your regexps quite a bite
[17:46:24 EDT(-0400)] <michelled> yes
[17:46:27 EDT(-0400)] <colinclark> Bosmon: yes, just second ago
[17:46:33 EDT(-0400)] <Bosmon> I made a regexp?
[17:46:39 EDT(-0400)] <michelled> it was already there
[17:46:50 EDT(-0400)] <michelled> I think you committed a whitespace change on that line
[17:46:57 EDT(-0400)] <Bosmon> aha
[17:47:01 EDT(-0400)] <michelled> but I tested the renderer and checked that everything still worked
[17:47:10 EDT(-0400)] <michelled> from infusion's point of view
[17:47:36 EDT(-0400)] <Bosmon> cool, thanks
[17:48:02 EDT(-0400)] <michelled> np
[17:48:11 EDT(-0400)] <michelled> good night all
[17:48:20 EDT(-0400)] <Bosmon> Good night, O feeez
[17:48:41 EDT(-0400)] * anastasiac (n=team@142.150.154.189) has left #fluid-work
[17:53:33 EDT(-0400)] <Bosmon> Hmm
[17:53:41 EDT(-0400)] <Bosmon> This has tried to "merge" too cleverly
[17:53:52 EDT(-0400)] <Bosmon> and ended up at a version of 1.1.2-SNAPSHOT
[17:53:54 EDT(-0400)] <Bosmon> Or is this right?
[17:54:22 EDT(-0400)] <Justin_o> i believe the version should be 1.1.2 as that is the version of infusion we will be releasing
[17:54:32 EDT(-0400)] <Bosmon> ok
[17:57:24 EDT(-0400)] <Justin_o> Bosmon: you are working on FLUID-2724 right
[18:05:57 EDT(-0400)] <colinclark> Bosmon: 1.1.2 without the SNAPSHOT, yes
[18:09:49 EDT(-0400)] <colinclark> Justin_o: +1 for http://issues.fluidproject.org/browse/FLUID-3215
[18:10:02 EDT(-0400)] <colinclark> it's not ideal, but we can resolve the issues after this release
[18:16:10 EDT(-0400)] <colinclark> http://issues.fluidproject.org/browse/ENGAGE-70
[18:22:08 EDT(-0400)] <Justin_o> colinclark: i have sent out a message as part of bug parade indicating that infusion trunk is frozen with the exception of changes to the readme, the dos line endings issue, and ENGAGE-70
[18:22:18 EDT(-0400)] <colinclark> thanks
[18:22:22 EDT(-0400)] <colinclark> nice work, king Justin_o
[18:34:41 EDT(-0400)] * Justin_o (n=Justin@142.150.154.171) has left #fluid-work
[19:21:18 EDT(-0400)] <Bosmon> Is there anything we need to do to infusion itself for ENGAGE-70?