fluid-work IRC Logs-2009-10-02

Owned by Fluid IRC Log Bot
Last updated: Oct 02, 2009Version comment
18 min read

[00:24:46 EDT(-0400)] * EricDalquist (n=EricDalq@64.198.210.170) has joined #fluid-work
[03:29:43 EDT(-0400)] * jamon (i=jamon@mantis.openject.com) has joined #fluid-work
[06:36:43 EDT(-0400)] * heidi_ (n=thesumme@bas5-oshawa95-1176457717.dsl.bell.ca) has joined #fluid-work
[08:27:29 EDT(-0400)] * laurel (n=Laurel@142.150.154.178) has joined #fluid-work
[08:43:40 EDT(-0400)] * Justin_o (n=Justin@142.150.154.171) has joined #fluid-work
[08:44:29 EDT(-0400)] * anastasiac (n=stasia@209.90.153.171) has joined #fluid-work
[09:03:50 EDT(-0400)] * jessm (n=Jess@c-71-232-1-65.hsd1.ma.comcast.net) has joined #fluid-work
[09:06:46 EDT(-0400)] * fj4000 (n=Main@CPE0018f85ab63e-CM001692f5798c.cpe.net.cable.rogers.com) has joined #fluid-work
[09:11:27 EDT(-0400)] * elicochran (n=elicochr@adsl-70-137-130-53.dsl.snfc21.sbcglobal.net) has joined #fluid-work
[09:17:07 EDT(-0400)] * yura (n=yura@142.150.82.120) has joined #fluid-work
[09:30:21 EDT(-0400)] * michelled (n=team@142.150.154.193) has joined #fluid-work
[09:44:15 EDT(-0400)] <fj4000> jessm: I committed against FLUID-3181- now requesting a review
[09:46:09 EDT(-0400)] <jessm> fj4000: roger that
[09:47:27 EDT(-0400)] <fj4000> thanks
[09:48:45 EDT(-0400)] <fj4000> laurel: has anyone reviewed 3201?
[09:49:20 EDT(-0400)] <laurel> just a sec...checking.
[09:50:12 EDT(-0400)] <laurel> fj4000 - no I don't think it has been reviewed
[09:50:27 EDT(-0400)] <fj4000> ok, I will review it
[09:52:57 EDT(-0400)] * colinclark (n=colin@bas2-toronto09-1176130646.dsl.bell.ca) has joined #fluid-work
[09:53:20 EDT(-0400)] * clown (n=clown@142.150.154.101) has joined #fluid-work
[09:54:01 EDT(-0400)] <jessm> fj4000: what is up with 3215?
[09:54:40 EDT(-0400)] <fj4000> lemme check
[09:55:29 EDT(-0400)] <colinclark> Justin_o: Tell me about the purported Renderer breakage.
[09:56:23 EDT(-0400)] <Justin_o> colinclark: hello... basically i'd get a 500 error and it said something about a value called "rendered"
[09:56:35 EDT(-0400)] <colinclark> When?
[09:56:42 EDT(-0400)] <colinclark> Can you pastebin the stack trace?
[09:56:45 EDT(-0400)] <Justin_o> when i try to load a page from kettle
[09:56:58 EDT(-0400)] <fj4000> jessm: it looks like a fix is in place
[09:57:02 EDT(-0400)] <Justin_o> I had reverted the render changes and it worked again
[09:57:19 EDT(-0400)] <Justin_o> colinclark: i can update and see if the same error occurs and pastebin it to you
[09:57:41 EDT(-0400)] <fj4000> but i think the idea behind that ticket is to scrub any pages using teh reorderer and ensure they're using the better class names in place of the old ones
[09:57:54 EDT(-0400)] <colinclark> thanks, Justin_o
[09:58:15 EDT(-0400)] <fj4000> i will comment on 3215 jessm
[09:58:24 EDT(-0400)] <fj4000> oh, sorry
[09:58:35 EDT(-0400)] <fj4000> i misread!
[09:59:29 EDT(-0400)] <fj4000> laurel: jessm is curious where we're holding with 3215 and the builder
[09:59:33 EDT(-0400)] <Justin_o> colinclark: this is what firefox outputted http://fluid.pastebin.com/mad9095b
[09:59:39 EDT(-0400)] * athena (i=482479ed@gateway/web/freenode/x-ffmyjibjyfichvmc) has joined #fluid-work
[10:00:54 EDT(-0400)] <Justin_o> colinclark: oh i see now...looks like a type-o in his code
[10:01:07 EDT(-0400)] <laurel> fj4000, jessm: pls give me a moment to collect thoughts...just about to commit a change and in the middle of a different thought.
[10:01:23 EDT(-0400)] <Justin_o> colinclark: looks like he is returning rendered instead of renderer
[10:01:30 EDT(-0400)] <Justin_o> i'll try to change that and see if it works
[10:03:11 EDT(-0400)] <michelled> colinclark, Justin_o: I think we'd better schedule a check in meeting this afternoon. unless you two have a handle on the releases - I feel really out of the loop
[10:03:18 EDT(-0400)] <Justin_o> colinclark: doing that causes the page to output [object Object] instead of rendering the actual page
[10:03:21 EDT(-0400)] <colinclark> michelled: Sure
[10:03:36 EDT(-0400)] <Justin_o> michelled: sounds like a good idea
[10:03:36 EDT(-0400)] <colinclark> In short, we're gonna freeze Infusion today--we're on track for that. Engage, we'll keep open a little longer.
[10:04:02 EDT(-0400)] <michelled> I'll put it at 1:30 in the calendar but we can adjust the time if it makes sense later today.
[10:04:38 EDT(-0400)] * jessm is waiting for completed, cooked thoughts – please don't feel pressured to update before you have them
[10:07:35 EDT(-0400)] <fj4000> jessm, laurel: I reviewed 3201, but it was very awkward- the whole file seemed to have changed, and so I could only read the single function outlined in the bug
[10:08:00 EDT(-0400)] <fj4000> jessm, if its ok with you, I could close it
[10:08:36 EDT(-0400)] <jessm> colinclark: bos and i are just talking – looks like he might be able to help with engage today
[10:09:04 EDT(-0400)] <jessm> michelled: i asked bos to check in with you
[10:09:22 EDT(-0400)] <jessm> colinclark: bos says FLUID-2980 is ready for review – likely by you
[10:09:54 EDT(-0400)] <jessm> fj4000: you want to close 3201 but aren't happy with it?
[10:10:06 EDT(-0400)] <laurel> fj4000: sorry about the 3201 change...i bet it was a line ending issue
[10:10:22 EDT(-0400)] <fj4000> yes, it should have been committed separately, i think
[10:10:26 EDT(-0400)] <fj4000> other than that, its ok
[10:11:11 EDT(-0400)] * colinclark and jessm are distracted by a conference call at the moment. Sorry for the delay in responding.
[10:11:33 EDT(-0400)] <fj4000> brb
[10:11:54 EDT(-0400)] <laurel> fj4000: you are correct in assuming that there was really only that one change in adding the error checking if build.properties was not found or could not be opened for any other reason.
[10:12:37 EDT(-0400)] <laurel> fj4000 and jessm: update on 3201 - I've just completed one commit against that issue
[10:13:06 EDT(-0400)] <jessm> fj4000: laurel just ping me when 3201's status changes to CLOSED
[10:13:27 EDT(-0400)] <laurel> fj4000 did the UI changes, which unfortunately broke the component functionality...so I've fixed it that (by changing the way that the UI was altered).
[10:13:52 EDT(-0400)] <laurel> fj4000 may wish to review the css changes I made just now to ensure he is still happy with the initial layout.
[10:15:05 EDT(-0400)] * Bosmon (n=Bosmon@c-98-245-80-35.hsd1.co.comcast.net) has joined #fluid-work
[10:15:13 EDT(-0400)] <Bosmon> OK
[10:15:16 EDT(-0400)] <laurel> jessm, fj4000: my goal now is to actually get that post build page to load and trigger the actual build...I actually have no idea how to do that. a little concerned because of that....but will work on it.
[10:15:28 EDT(-0400)] <Bosmon> FEEs has pasted to me the chat about the renderer issue, colin and justin
[10:15:37 EDT(-0400)] <Bosmon> Looks like it might be a regression caused by my FLUID-2980 fix
[10:15:54 EDT(-0400)] <Justin_o> Bosmon: found a couple of things...
[10:15:56 EDT(-0400)] <colinclark> cool, thanks for taking a look at it, Bosmon
[10:16:05 EDT(-0400)] <laurel> so that's my update on 3215.
[10:16:10 EDT(-0400)] <laurel> over and out
[10:16:13 EDT(-0400)] <Bosmon> But I missed the "situation"
[10:16:19 EDT(-0400)] <Bosmon> What are you doing when you get the errour/
[10:16:32 EDT(-0400)] <colinclark> errour (tongue)
[10:16:50 EDT(-0400)] <Justin_o> fluidRenderer.js line 1355 returns rendered instead of renderer
[10:16:59 EDT(-0400)] <Bosmon> Oh dear
[10:17:00 EDT(-0400)] <Justin_o> so I changed that
[10:17:12 EDT(-0400)] <Bosmon> Terrible (tongue)
[10:17:17 EDT(-0400)] <Bosmon> I wonder how any of the tests pass...
[10:17:27 EDT(-0400)] <Justin_o> and the pages are displayed with [object object] instead of any content
[10:17:29 EDT(-0400)] <Bosmon> Surely that would stop it ever rendering anything?
[10:17:44 EDT(-0400)] <Bosmon> Ah
[10:17:48 EDT(-0400)] <Bosmon> A direct use of renderTemplates
[10:17:56 EDT(-0400)] <Bosmon> Whereas all the tests test one of the drivers
[10:18:03 EDT(-0400)] <Bosmon> Ok, sorry about that.... has that made all the problems go away?
[10:18:47 EDT(-0400)] <Bosmon> Oh wait
[10:18:50 EDT(-0400)] <Bosmon> That is not right either
[10:18:57 EDT(-0400)] <Bosmon> Let me update and fix it
[10:18:57 EDT(-0400)] <Justin_o> well... it made the 500 error that i guess getting on the page go away... but now am getting the page displaying only [object object] instead of the actual page...
[10:19:04 EDT(-0400)] <Justin_o> okay.. so maybe there is something else
[10:19:27 EDT(-0400)] <Bosmon> Well, the "API" is now different
[10:19:32 EDT(-0400)] <Bosmon> The renderer is now a "that"
[10:19:49 EDT(-0400)] <Bosmon> Oh ok, you didn't do this in trunk
[10:20:08 EDT(-0400)] <Justin_o> no.. i just made the change locally
[10:20:15 EDT(-0400)] <Justin_o> i haven't committed it
[10:20:44 EDT(-0400)] <Bosmon> OK, I have committed a fix
[10:20:47 EDT(-0400)] <Bosmon> Please review (tongue)
[10:21:01 EDT(-0400)] <Justin_o> I'll see if it works
[10:23:13 EDT(-0400)] * Bosmon (n=Bosmon@c-98-245-80-35.hsd1.co.comcast.net) has joined #fluid-work
[10:23:17 EDT(-0400)] <Bosmon> Hi Jess - can you move ENGAGE-90 on to "REVIEW"?
[10:23:29 EDT(-0400)] <Bosmon> Also, in your list, the link for that item is actually to ENGAGE-94
[10:23:31 EDT(-0400)] <jessm> Bosmon: roger that
[10:23:36 EDT(-0400)] <jessm> ah, ok
[10:23:50 EDT(-0400)] <Bosmon> Cheers, dude
[10:25:52 EDT(-0400)] <Justin_o> Bosmon: okay... it's working better... getting a message.fail() error now... but that could be because of something else... i'll have to look into that
[11:02:47 EDT(-0400)] <Bosmon> I am drinking CORFEE out of my FLUID MUGG (tongue)
[11:02:58 EDT(-0400)] <colinclark> excellent
[11:03:02 EDT(-0400)] <colinclark> Did you buy it from CafePress?
[11:03:16 EDT(-0400)] <Bosmon> yes
[11:03:19 EDT(-0400)] <Bosmon> Some time ago (tongue)
[11:03:35 EDT(-0400)] <Bosmon> Another thing I found in the massive cleanup of my house was my stash of Fluid swag (tongue)
[11:04:56 EDT(-0400)] <Bosmon> Holy hell
[11:05:05 EDT(-0400)] <Bosmon> We have ELEVEN candidates for rooms in my house ;P
[11:05:49 EDT(-0400)] <colinclark> ok Bosmon and michelled, give me five minutes and then we should meet to Talk Kettle
[11:06:03 EDT(-0400)] <Bosmon> ok
[11:06:26 EDT(-0400)] <laurel> fj4000, jessm: I just released all the miriad of recent code changes of the Builder to the website test space - felt like I needed to double check that everything still worked before proceeding with the "postBuild" page. Thankfully, I was able to get everything to work again with very little trouble. test site still has old instructions, but that's easy to fix. reminder: URL is http://142.150.154.58/builder/
[11:06:51 EDT(-0400)] <fj4000> thanks -still catching up
[11:08:25 EDT(-0400)] <Bosmon> CO-ON-FI-TE-OR!
[11:09:41 EDT(-0400)] <laurel> Justin_o or someone else who has a moment - still looking for someone to commit 3 patches for http://issues.fluidproject.org/browse/FLUID-3192 (changes to copyright)
[11:37:23 EDT(-0400)] * yura (n=yura@142.150.82.120) has joined #fluid-work
[11:52:15 EDT(-0400)] * Justin_o (n=Justin@142.150.154.171) has joined #fluid-work
[11:52:53 EDT(-0400)] <michelled> yura: should I expect the artifact view to be loading data from couch?
[11:53:37 EDT(-0400)] <yura> michelled: you mean the client one
[12:00:27 EDT(-0400)] <michelled> no, yura, I mean with kettle
[12:00:52 EDT(-0400)] <michelled> I have all the paths being rewritten now and the template is loading with the javascript intact but I'm not getting couch data
[12:01:51 EDT(-0400)] <yura> hmm, doesnt display data or it doesnt pull data?
[12:02:01 EDT(-0400)] <michelled> I'm not sure
[12:02:07 EDT(-0400)] <michelled> I haven't looked into it
[12:02:24 EDT(-0400)] <michelled> so, you're expecting it should both pull and display the data with what's currently in svn?
[12:03:01 EDT(-0400)] <yura> actually no, sorry, the markup for artifact is not at sync with artifact component , i need to commit the changes
[12:05:18 EDT(-0400)] <michelled> when do you expect to commit, yura?
[12:06:16 EDT(-0400)] <yura> i m doing it right now actually
[12:07:53 EDT(-0400)] <michelled> great - ping me when I should update (smile)
[12:08:12 EDT(-0400)] <fj4000> jessm: fyi, 3198 is closed
[12:08:50 EDT(-0400)] <jessm> fj4000: thanks
[12:10:05 EDT(-0400)] <Justin_o> jessm: http://issues.fluidproject.org/browse/FLUID-3212 should also be closed on bug parade now... i have reviewed and tested it
[12:10:09 EDT(-0400)] <jessm> laurel: FYI 3201 and 3215 are in review and open respectively – is this accurate?
[12:10:15 EDT(-0400)] <jessm> Justin_o: thanks
[12:10:18 EDT(-0400)] <laurel> 3215 is not done
[12:10:34 EDT(-0400)] <laurel> 3201 I think fj4000 finished reviewing
[12:11:41 EDT(-0400)] <fj4000> I will close 3201 since i reviewed it
[12:11:50 EDT(-0400)] <yura> michelled: it is working now both on client and kettle
[12:11:54 EDT(-0400)] <jessm> fj4000: so, 3201 is closed?
[12:11:57 EDT(-0400)] <fj4000> yes
[12:12:00 EDT(-0400)] <michelled> thanks yura
[12:12:12 EDT(-0400)] <yura> michelled: let me know if it doesnt work for you
[12:12:20 EDT(-0400)] <michelled> checking now
[12:14:40 EDT(-0400)] * elicochran (n=elicochr@dhcp-169-229-212-41.LIPS.Berkeley.EDU) has joined #fluid-work
[12:14:49 EDT(-0400)] <colinclark> fj4000, laurel: I'm on a call right now
[12:14:53 EDT(-0400)] <colinclark> But I'd like to chat about 3201
[12:14:56 EDT(-0400)] <colinclark> before we close it
[12:15:06 EDT(-0400)] <laurel> ok
[12:15:07 EDT(-0400)] <fj4000> ok
[12:15:14 EDT(-0400)] <fj4000> want to re-open it?
[12:16:42 EDT(-0400)] <colinclark> fj4000: Not sure yet. Just want to check in and hear a bit more about it. Give me about 20 minutes or so.
[12:16:51 EDT(-0400)] <fj4000> ok
[12:17:36 EDT(-0400)] <michelled> yura, still now working for me: http://142.150.154.193:8080/fluid-kettle-0.1-SNAPSHOT/artifact?mmi&amp;Canada
[12:18:30 EDT(-0400)] <michelled> I meant 'not'
[12:19:35 EDT(-0400)] <yura> i m trying to debug, but my firebug is acting funny
[12:20:30 EDT(-0400)] <michelled> thanks for looking at it
[12:21:53 EDT(-0400)] <yura> oh i see what's going on
[12:23:00 EDT(-0400)] <yura> when loadData.json makes ajax call, it looks at window.location.host which is 142.150.154.193:8080 , but you have fluid-kettle-0.1-SNAPSHOT after that
[12:23:08 EDT(-0400)] <yura> michelled: ^
[12:23:21 EDT(-0400)] <michelled> hmmm.. is that configurable?
[12:23:27 EDT(-0400)] <michelled> where does the ajax call happen
[12:23:30 EDT(-0400)] <michelled> ?
[12:23:54 EDT(-0400)] <yura> loadData.json, artifact.html runs demo.loadJson
[12:23:58 EDT(-0400)] <yura> inside ther
[12:24:16 EDT(-0400)] <yura> it is configurable
[12:40:38 EDT(-0400)] <jessm> elicochran: i think i remember seeing you'd reviewed CCs uploader bugs – what's their status? 3115 and 3114?
[12:41:36 EDT(-0400)] <jessm> and is someone reviewing Engage-27? it's looks juicy!
[12:42:03 EDT(-0400)] <colinclark> Quote of the day: "I can't just imagine blue things!"
[12:43:23 EDT(-0400)] <elicochran> jessm: I left a comment on 3114 since that was what the code was checked in on. From my review and quick test, it looks good.
[12:43:42 EDT(-0400)] <elicochran> don't forget 3196
[12:43:54 EDT(-0400)] <elicochran> which is the parent issue for the other two
[12:44:29 EDT(-0400)] <jessm> yikes 3196 isn't on parade
[12:45:15 EDT(-0400)] <jessm> colinclark: elicochran: confirm then that 3114, 3115, and 3196 are closed?
[12:45:40 EDT(-0400)] <elicochran> jessm: I didn't look specifically for the behavior of 3115 (now that I look at it for the first time). I think that I would have noticed it but I was looking at the specific behavior of 3114
[12:46:09 EDT(-0400)] <jessm> ah, so, you'll review 3115 now?
[12:46:45 EDT(-0400)] <elicochran> jessm: looking now
[12:51:36 EDT(-0400)] <elicochran> jessm, colinclark: 3115 looks good (tested against the build server). I'll add a comment to the bug
[12:52:00 EDT(-0400)] <jessm> elicochran: thanks!
[12:53:22 EDT(-0400)] <jessm> elicochran: can you also comment on 3196?
[12:53:31 EDT(-0400)] <elicochran> jessm: certainly
[12:53:41 EDT(-0400)] <jessm> elicochran: thanks muchly!
[13:00:55 EDT(-0400)] <elicochran> jessm: I have commented on the bugs. I didn't resolve them (I usually give the pleasure to the person who wrote the code) but I'll happily click the Resolve link if you want me to.
[13:01:08 EDT(-0400)] <fj4000> Justin_o: I committed my fix for 3218
[13:01:22 EDT(-0400)] <colinclark> Please go ahead and resolve them for me, elicochran. (smile)
[13:01:26 EDT(-0400)] <Justin_o> fj4000: thanks... i'll update and do another review
[13:01:29 EDT(-0400)] <colinclark> I know you love the satisfaction of resolving issues
[13:01:33 EDT(-0400)] <fj4000> thank you
[13:03:05 EDT(-0400)] <elicochran> colinclark: especially when I don't have to do any of the work! Done!
[13:03:25 EDT(-0400)] <colinclark> elicochran: thanks,dude
[13:03:28 EDT(-0400)] <colinclark> mucho appreciated
[13:03:37 EDT(-0400)] <jessm> listen up peeps – cc just had a good idea – can y'all take a moment, heads up, and tell me in the channel which INFUSION bugs you're reviewing and/or working on and/or proposing you'll review and i'll put that info in the next email update
[13:04:07 EDT(-0400)] <colinclark> Justin_o, yura, laurel, anastasiac, michelled, fj4000: ^
[13:04:08 EDT(-0400)] <jessm> fj4000: laurel michelled yura Justin_o ^
[13:04:11 EDT(-0400)] <colinclark> (smile)
[13:04:12 EDT(-0400)] <jessm> doh
[13:04:13 EDT(-0400)] <jessm> booger
[13:04:29 EDT(-0400)] <Justin_o> jessm: i'm reviewing FLUID-3218 and FLUID-3192
[13:05:20 EDT(-0400)] <yura> jessm: this one could be reviewed : http://issues.fluidproject.org/browse/ENGAGE-32
[13:05:46 EDT(-0400)] <jessm> Justin_o: i didn't think 3192 was in review
[13:05:55 EDT(-0400)] <jessm> yura: tahnks – adding that, but which ones are you on now?
[13:06:01 EDT(-0400)] <fj4000> jessm: I just finished 3218, I was looking for work (tongue)
[13:06:22 EDT(-0400)] <jessm> fj4000: is 3218 closed?
[13:06:30 EDT(-0400)] <fj4000> Justin_o is reviewing it
[13:06:35 EDT(-0400)] <jessm> ah, ok
[13:06:48 EDT(-0400)] <fj4000> im free to move on to whatever needs reviewing
[13:06:49 EDT(-0400)] <yura> i m polishing ENGAGE-91, this one is also good for review: http://issues.fluidproject.org/browse/ENGAGE-92
[13:06:56 EDT(-0400)] <elicochran> Justin_o: just an FYI, Flash 10 is particularly crash-y in Safari 4 under Snow Leopard. If you guys see crashes, don't immediately assume that it is the Uploader
[13:07:24 EDT(-0400)] <Justin_o> elicochran: okay... thanks for the update
[13:07:30 EDT(-0400)] <jessm> fj4000: priority is infusion – i'll find you something to review – standby
[13:07:43 EDT(-0400)] <fj4000> jessm: ok
[13:07:59 EDT(-0400)] <yura> http://issues.fluidproject.org/browse/ENGAGE-71 is good for review too
[13:08:07 EDT(-0400)] <jessm> laurel: what are you working on?
[13:08:39 EDT(-0400)] <Justin_o> jessm: just closed FLUID-3218
[13:09:45 EDT(-0400)] <jessm> fj4000: 3157?
[13:09:54 EDT(-0400)] <jessm> it's listed for review
[13:09:57 EDT(-0400)] * fj4000 looks it up
[13:10:04 EDT(-0400)] <laurel> jessm 3215
[13:10:14 EDT(-0400)] <jessm> laurel: what does that mean?
[13:10:26 EDT(-0400)] <jessm> you're working on 3215?
[13:10:29 EDT(-0400)] <laurel> http://issues.fluidproject.org/browse/FLUID-3215
[13:10:38 EDT(-0400)] <jessm> i know the url, thanks LOL
[13:10:50 EDT(-0400)] <laurel> I'm trying to get the second part of the UI to work and still build
[13:11:04 EDT(-0400)] <laurel> finding it a bit challenging.
[13:11:10 EDT(-0400)] <laurel> getting there I think
[13:11:10 EDT(-0400)] <jessm> fj4000: can you review 3157 and help laurel on 3215?
[13:11:28 EDT(-0400)] <fj4000> jessm : yes
[13:11:34 EDT(-0400)] <jessm> fj4000: thanks muchly
[13:11:38 EDT(-0400)] <jessm> (smile)
[13:11:50 EDT(-0400)] <fj4000> jessm: I like your use of muchly
[13:11:58 EDT(-0400)] <jessm> fj4000: (smile)
[13:12:57 EDT(-0400)] <jessm> Justin_o: are you all set with what to review?
[13:13:59 EDT(-0400)] <laurel> fj4000: can we chat skype??
[13:14:06 EDT(-0400)] <fj4000> sure
[13:16:19 EDT(-0400)] <Justin_o> jessm: i think so
[13:31:23 EDT(-0400)] <Justin_o> jessm: I've reviewed the remainder of the patches on FLUID-3192, bug laurel was mentioning that she needs to add another one or so... I've commented on the jira about the ones I've reviewed
[13:32:30 EDT(-0400)] <jessm> k
[13:50:18 EDT(-0400)] <fj4000> laurel: I commented on http://issues.fluidproject.org/browse/FLUID-3157
[13:50:34 EDT(-0400)] * colinclark (n=colin@142.150.154.101) has joined #fluid-work
[13:50:50 EDT(-0400)] <fj4000> basically, i dont understand why you switched the variable from an object to an array
[13:52:18 EDT(-0400)] <fj4000> I could be wrong here, but i think its dangerous to treat an array as a hash when an object is better suited to do this
[13:53:44 EDT(-0400)] <fj4000> laurel: also, have a look at the headers outlined on this page: http://www.higherpass.com/php/tutorials/File-Download-Security/1/
[13:54:00 EDT(-0400)] <fj4000> i think those might help with 3215
[13:54:15 EDT(-0400)] <colinclark> jessm: I chatted with laurel about FLUID-3201 and we're cool here.
[13:54:32 EDT(-0400)] <michelled> jessm: is update 31 the last bug parade update?
[13:54:35 EDT(-0400)] <colinclark> fj4000: You should feel free, if necessary, to punt back patches that have whitespace changes in them if they make it hard for you to review.
[13:54:40 EDT(-0400)] <colinclark> (in the future0
[13:54:47 EDT(-0400)] <fj4000> ok
[13:54:59 EDT(-0400)] <jessm> michelled: yes, update 32
[13:55:00 EDT(-0400)] <jessm> oops
[13:55:01 EDT(-0400)] <fj4000> did you see my comment above, colinclark?
[13:55:01 EDT(-0400)] <jessm> 31
[13:55:13 EDT(-0400)] <colinclark> i dunno, can you send it again, fj4000?
[13:55:28 EDT(-0400)] <fj4000> "...i think its dangerous to treat an array as a hash when an object is better suited to do this"
[13:55:29 EDT(-0400)] * Bosmon (n=Bosmon@ucb-np1-211.colorado.edu) has joined #fluid-work
[13:55:31 EDT(-0400)] <fj4000> in JS
[13:55:41 EDT(-0400)] <colinclark> fj4000: Yes, that's true. What's the context?
[13:55:48 EDT(-0400)] <jessm> k, closing 3201
[13:56:09 EDT(-0400)] <colinclark> thanks, proxy king
[13:56:11 EDT(-0400)] <fj4000> just verifying - looking at rev. 8182 for FLUID-3157
[13:58:52 EDT(-0400)] <colinclark> fj4000: So this is, I think, related to my previous review of the issue.
[13:59:04 EDT(-0400)] <colinclark> If I remember, laurel had a number of functions that referred to an array
[13:59:11 EDT(-0400)] <colinclark> but that was being initialized as an object literal.
[13:59:30 EDT(-0400)] <colinclark> So I asked laurel to look at her data and decide if an array or a hash was more appropriate
[13:59:45 EDT(-0400)] <colinclark> So your job, in reviewing this, is to double-check that she made a good choice here.
[13:59:51 EDT(-0400)] <fj4000> var array = [];
[13:59:51 EDT(-0400)] <fj4000> for (var i = 0; i < model.moduleInfo.length; i++) {
[13:59:51 EDT(-0400)] <fj4000> array[model.moduleInfo[i].moduleValue] = model.moduleInfo[i].moduleName;
[13:59:51 EDT(-0400)] <fj4000> }
[13:59:51 EDT(-0400)] <fj4000> return array;
[14:00:10 EDT(-0400)] <colinclark> So, if it's properly a linear array, then it should be [].
[14:00:11 EDT(-0400)] <fj4000> by using it in this loop, it seems to need to be an object
[14:00:24 EDT(-0400)] <colinclark> If se's keying by another data type, it's probably a hash
[14:00:34 EDT(-0400)] <colinclark> so what are the expected values of moduleValue?
[14:00:40 EDT(-0400)] <fj4000> laurel : ^ ?
[14:00:51 EDT(-0400)] <colinclark> fj4000: That's something you should determine, too
[14:05:51 EDT(-0400)] <fj4000> colinclark: seems like moduleValue is a string...
[14:06:06 EDT(-0400)] <colinclark> fj4000: Ok, that's a problem.
[14:06:16 EDT(-0400)] <fj4000> even as a string of a number, thats a concern, no?
[14:06:26 EDT(-0400)] <colinclark> fj4000: Well
[14:06:28 EDT(-0400)] <colinclark> Not exactly
[14:06:32 EDT(-0400)] <colinclark> But in principle, yes
[14:06:41 EDT(-0400)] <colinclark> JavaScript will coerce the value
[14:06:47 EDT(-0400)] <colinclark> but it suggests that the data isn't actually linear
[14:06:55 EDT(-0400)] <fj4000> ok
[14:06:55 EDT(-0400)] <colinclark> laurel: Can you share your intentions there when you get a chance?
[14:21:56 EDT(-0400)] <colinclark> jessm: Last Infusion issue to file: FLUID-3222
[14:22:07 EDT(-0400)] <colinclark> This is required to cut Infusion 1.1.2 with the correct version number in code.
[14:22:21 EDT(-0400)] <jessm> colinclark: add to parade?
[14:22:23 EDT(-0400)] <colinclark> It's an awkward fix, because it touches every single file, but is fairly simple to implement.
[14:22:27 EDT(-0400)] <colinclark> jessm: Yes please.
[14:22:41 EDT(-0400)] <colinclark> Any one of us can do it, but perhaps it should be done towards the end of the day.
[14:22:46 EDT(-0400)] <colinclark> Thoroughness is key to this one.
[14:23:10 EDT(-0400)] <colinclark> It's the kind of thing I wish elicochran had time to do, because he's so familiar with the process. (wink)
[14:26:42 EDT(-0400)] <laurel> fj4000: I'm pretty sure they are numbers which is why I responded to colinclark's suggestion by changing it to [] but maybe they are string reps of numbers...
[14:26:57 EDT(-0400)] <colinclark> laurel: But will the be in a linear order? Does order matter?
[14:27:05 EDT(-0400)] <laurel> i was aiming for a hash type of thing...lookup table associating a number with a value
[14:27:14 EDT(-0400)] <laurel> order does not matter
[14:27:56 EDT(-0400)] <colinclark> laurel: So if you were aiming for a hash type of thing, why not use a hash?
[14:29:01 EDT(-0400)] <laurel> ok...what is a hash in javascript
[14:29:06 EDT(-0400)] <laurel> is that an object?
[14:29:16 EDT(-0400)] <laurel> or is that an array
[14:29:32 EDT(-0400)] <laurel> or is there a hash data structure I haven't even heard of yet
[14:31:43 EDT(-0400)] <colinclark> laurel: In essence, everything in JS is a hash.
[14:31:49 EDT(-0400)] <colinclark> This is a hash: {}
[14:31:55 EDT(-0400)] <laurel> ok...so what you mean is it is an object
[14:31:58 EDT(-0400)] <colinclark> Objects are just informal collections of key/value pairs
[14:32:02 EDT(-0400)] <colinclark> yes
[14:32:06 EDT(-0400)] <colinclark> objects and hashes are the same thing
[14:32:12 EDT(-0400)] <colinclark> They're called Objects in the language.
[14:32:29 EDT(-0400)] <laurel> ok...when you said hash i thought perhaps you were refering to something I have not yet read.
[14:33:01 EDT(-0400)] <laurel> ok..so I'll go back and fix that issue after I've fixed the current one I'm working on. if I can
[14:33:05 EDT(-0400)] <colinclark> nope. this feature is at the heart of what makes JavaScript awesome as a language
[14:33:07 EDT(-0400)] <colinclark> k, great
[14:33:21 EDT(-0400)] <colinclark> fj4000: That means you can move on to more review
[14:33:23 EDT(-0400)] <fj4000> once thats done, should I continue reviewing?
[14:33:27 EDT(-0400)] <colinclark> yes
[14:33:28 EDT(-0400)] <fj4000> ok
[14:33:39 EDT(-0400)] <colinclark> jessm: Bug parade coordination update for you...
[14:33:56 EDT(-0400)] <colinclark> michelled is reviewing FLUID-2980 (Antranig's Renderer fix)
[14:34:31 EDT(-0400)] <colinclark> I am filing Engage bugs, followed by review of FLUID-3197 (Joan's portal a11y fix)
[14:34:32 EDT(-0400)] <elicochran> colinclark: jessm: FLUID-3222 shouldn't be too bad. Search and Replace, that's how we do it after we cut the tag. The fluid_1_2 is quite unique and only used for namespacing. Of course in that case we assume that we have two or three months for the bugs to shift out. But we haven't had one come up yet.
[14:34:59 EDT(-0400)] <elicochran> sorry, the fluid_1_2 string is quite unique
[14:35:25 EDT(-0400)] <colinclark> Bosmon is reviewing FLUID-3131 and 3122 (my Image Reorderer fixes)
[14:35:38 EDT(-0400)] <colinclark> He'll also fix FLUID-3121 while he's at it.
[14:36:04 EDT(-0400)] <colinclark> elicochran: Cool, that's good to know.
[14:36:44 EDT(-0400)] <elicochran> np
[14:55:07 EDT(-0400)] <jessm> colinclark: i don't have 3121 in review – should it be?
[14:55:24 EDT(-0400)] <colinclark> jessm: Right. 3121 shouldn't be in review, it still needs to be implemented.
[14:55:33 EDT(-0400)] <jessm> k
[14:55:36 EDT(-0400)] <colinclark> Joan was going to do it, but I'm assuming he's off today so Bosmon is gonna fix it.
[14:55:43 EDT(-0400)] <jessm> colinclark: rt
[14:56:01 EDT(-0400)] <colinclark> jessm: Sorry for swamping you with all these little details about parade
[14:56:37 EDT(-0400)] <jessm> colinclark: it's my yob (smile)
[14:56:53 EDT(-0400)] <colinclark> (smile)
[15:09:09 EDT(-0400)] <laurel> Hi all, anyone have a few minutes to test out the newish interface to the builder and provide feedback? http://142.150.154.58/builder/
[15:09:24 EDT(-0400)] <laurel> I think I've managed to implement what was requested.
[15:09:45 EDT(-0400)] <laurel> fj4000 and jessm especially if you have time.
[15:13:40 EDT(-0400)] <jessm> laurel: shouldn't "select none" be "clear all"?
[15:14:04 EDT(-0400)] <michelled> jessm: I'm done my review of 2980. the renderer files are in desperate need of linting but it's really a trivial task so I think it should wait until after the release
[15:14:13 EDT(-0400)] <jessm> laurel: otherwise looks snazzy (smile)
[15:14:52 EDT(-0400)] <jessm> laurel: the link for "creating a fluid custom build" points to the homepage
[15:16:14 EDT(-0400)] <jessm> michelled: so, 2980 is closed?
[15:16:38 EDT(-0400)] <michelled> I'll close it
[15:19:26 EDT(-0400)] * heidi_ (n=thesumme@bas5-oshawa95-1176457717.dsl.bell.ca) has joined #fluid-work
[15:23:25 EDT(-0400)] <laurel> jessm - i didn't do links yet...and wanted to check with you about the links on the download page.
[15:23:47 EDT(-0400)] <laurel> warning to all - nakul is about to re-boot the server that the builder is on
[15:24:01 EDT(-0400)] <laurel> will be back in 10 min or so he said
[15:24:29 EDT(-0400)] <jessm> 10 min for reboot?
[15:24:36 EDT(-0400)] <jessm> or is something else up?
[15:24:51 EDT(-0400)] <laurel> he said he would reboot sometime in the next few minutes
[15:24:52 EDT(-0400)] * Justin_o (n=Justin@142.150.154.171) has joined #fluid-work
[15:25:03 EDT(-0400)] <jessm> laurel: roger that
[15:25:06 EDT(-0400)] <laurel> so I made a judgement call of 10 mins
[15:25:35 EDT(-0400)] <laurel> i'll check the text for accuracy
[15:27:12 EDT(-0400)] <colinclark> laurel, fj4000: +1 on your new UI for the Builder
[15:29:33 EDT(-0400)] <fj4000> I need to give it some polish and shine
[15:29:42 EDT(-0400)] <fj4000> then it should be decent
[15:30:18 EDT(-0400)] <laurel> yes...are you going to do that on the component itself or within the website.
[15:30:26 EDT(-0400)] <laurel> I will check in what I have now.
[15:32:18 EDT(-0400)] <fj4000> I think on the site, since the styles are specific to the site
[15:32:36 EDT(-0400)] <fj4000> we could always make a css file for the component separately
[15:32:54 EDT(-0400)] <laurel> we actually do have a css file for the component separately
[15:33:02 EDT(-0400)] <laurel> and some of your styles are already in there.
[15:34:56 EDT(-0400)] <fj4000> yes, but thats not the place for the site's style overrides
[15:35:00 EDT(-0400)] <laurel> but there are other styles for the same page in the fluid css on the website. A bit mixed up.
[15:35:55 EDT(-0400)] <laurel> ok great
[15:36:26 EDT(-0400)] <laurel> i'll just put the latest html on there...jessm noted a few tweeks
[15:36:49 EDT(-0400)] <laurel> when the server comes back upl.
[15:46:24 EDT(-0400)] <Bosmon> Am I here?
[15:46:35 EDT(-0400)] <colinclark> yes you are
[15:46:59 EDT(-0400)] <Bosmon> cool
[15:48:49 EDT(-0400)] <Bosmon> Are we having our Engage call?
[15:52:31 EDT(-0400)] <michelled> I won't be able to make the Engage call
[15:52:37 EDT(-0400)] <Bosmon> (sad)
[15:52:53 EDT(-0400)] <michelled> you all can feel free to meet but please update me on your decisions/findings
[15:53:26 EDT(-0400)] <michelled> Bosmon: this is the JIRA that we talked about that you were going to take on: http://issues.fluidproject.org/browse/FLUID-3121
[15:53:31 EDT(-0400)] <Bosmon> yes
[15:54:49 EDT(-0400)] <michelled> thanks!
[16:00:17 EDT(-0400)] <colinclark> fj4000: how much time do you have left before you're off for the day?
[16:00:40 EDT(-0400)] <fj4000> 30 mins, I think
[16:00:49 EDT(-0400)] <colinclark> ok
[16:01:00 EDT(-0400)] <fj4000> what can I do for you?
[16:01:29 EDT(-0400)] <colinclark> well, laurel was saying she might need someone to grab that fix for her
[16:01:38 EDT(-0400)] <colinclark> but if you're nearly done, i can pick it up
[16:01:42 EDT(-0400)] <colinclark> let's see how it goes
[16:01:45 EDT(-0400)] <fj4000> you mean the looping stuff?
[16:01:48 EDT(-0400)] <colinclark> fj4000: what's left on your plate?
[16:01:52 EDT(-0400)] <colinclark> yep, that stuff
[16:02:05 EDT(-0400)] <fj4000> i was just reviewing other bits of 3157
[16:02:12 EDT(-0400)] <colinclark> fj4000: carry on (smile)
[16:02:30 EDT(-0400)] <fj4000> is there something else I could help with ?
[16:02:41 EDT(-0400)] <fj4000> i noticed there are a ton of engage reviews required
[16:03:00 EDT(-0400)] <colinclark> fj4000: Those can wait. We're going to freeze Infusion first. Engage'll take another couple days, it looks like
[16:03:05 EDT(-0400)] <fj4000> ok, smart
[16:03:08 EDT(-0400)] <fj4000> will do
[16:05:55 EDT(-0400)] <Bosmon> Can we freeze infusion?
[16:06:09 EDT(-0400)] <Bosmon> I thought we needed to fix ENGAGE-96
[16:13:44 EDT(-0400)] <jessm> Bosmon: engage-96 should affect infusion freeze, should it?
[16:24:20 EDT(-0400)] * elicochran (n=elicochr@dhcp-169-229-212-41.LIPS.Berkeley.EDU) has joined #fluid-work
[16:35:17 EDT(-0400)] <laurel> fj4000: everything is on the website now.
[16:36:21 EDT(-0400)] <laurel> also fj4000 and colinclark, I've attached a patch to 3157 for the object/array issue
[16:36:37 EDT(-0400)] <laurel> if you guys have time to check it out great...if not we'll discuss it Monday.
[16:36:56 EDT(-0400)] <laurel> it is in place on the website, so have confirmed it still "works"
[16:42:28 EDT(-0400)] <laurel> http://issues.fluidproject.org/browse/FLUID-3192 - I just uploaded a final patch file which addresses date changes in copyright.
[16:43:11 EDT(-0400)] <laurel> so jessm: 3157 patch is up for review if people want to check it...very late so I didn't check it in.
[16:43:53 EDT(-0400)] <laurel> http://issues.fluidproject.org/browse/FLUID-3215 - jacob wants to do more tweaking of css, but I'm done.
[16:44:05 EDT(-0400)] <colinclark> catching up on the channel
[16:44:15 EDT(-0400)] <colinclark> jessm: I think we could freeze Infusion without ENGAGE-96.
[16:44:16 EDT(-0400)] <laurel> and 3192 is not done, but I did a bit more and uploaded another patch.
[16:44:21 EDT(-0400)] <laurel> that'
[16:44:23 EDT(-0400)] <jessm> colinclark: gotcha
[16:44:34 EDT(-0400)] <colinclark> The likely fix is inside Infusion, but we could ship Engage with a custom version of Infusion
[16:44:35 EDT(-0400)] <laurel> s it for me. gotta go nowish
[16:44:47 EDT(-0400)] * laurel (n=Laurel@142.150.154.178) has left #fluid-work
[16:46:13 EDT(-0400)] <jessm> i'm guessing this means that 3192 is ready for review
[16:46:25 EDT(-0400)] <jessm> folks, be specific – don't be shy to tell me REVIEW THIS
[16:46:29 EDT(-0400)] <jessm> or CLOSE THIS
[16:46:35 EDT(-0400)] <jessm> i do best with blunt
[17:14:41 EDT(-0400)] * Justin_o (n=Justin@142.150.154.171) has joined #fluid-work
[17:17:09 EDT(-0400)] * colinclark (n=colin@142.150.154.101) has joined #fluid-work
[17:26:49 EDT(-0400)] * colinclark (n=colin@142.150.154.101) has joined #fluid-work
[17:26:49 EDT(-0400)] * elicochran (n=elicochr@dhcp-169-229-212-41.LIPS.Berkeley.EDU) has joined #fluid-work
[17:26:49 EDT(-0400)] * heidi_ (n=thesumme@bas5-oshawa95-1176457717.dsl.bell.ca) has joined #fluid-work
[17:47:34 EDT(-0400)] * elicochran (n=elicochr@dhcp-169-229-212-41.LIPS.Berkeley.EDU) has left #fluid-work
[17:52:07 EDT(-0400)] * anastasiac (n=stasia@209.90.153.171) has left #fluid-work
[17:57:46 EDT(-0400)] * clown (n=clown@142.150.154.101) has left #fluid-work
[18:10:40 EDT(-0400)] <colinclark> Bosmon: You there?
[18:35:37 EDT(-0400)] <Bosmon> Yes
[18:35:40 EDT(-0400)] <Bosmon> I'm here