fluid-work IRC Logs-2008-08-15
[08:05:03 EDT(-0400)] * Justin_o (n=Justin@142.150.154.101) has joined #fluid-work
[09:29:11 EDT(-0400)] * colinclark (n=colin@bas1-toronto09-1279543344.dsl.bell.ca) has joined #fluid-work
[09:43:23 EDT(-0400)] <colinclark> Justin_o: Your browser support page is coming in handy already!
[09:44:00 EDT(-0400)] <Justin_o> colinclark: really, that was quick.. glad it's already helping
[10:08:02 EDT(-0400)] * jacobfarber (n=Jacob@142.150.154.106) has joined #fluid-work
[10:17:33 EDT(-0400)] * anastasiac (n=team@142.150.154.160) has joined #fluid-work
[10:26:44 EDT(-0400)] <Bosmon> Colin and I are just discussing the idiomatism of jquery.get(0) versus jquery[0]
[10:27:13 EDT(-0400)] <Bosmon> We see the former lying around the code a good deal
[10:27:18 EDT(-0400)] <Bosmon> Which I had assumed was for a good reason
[10:49:14 EDT(-0400)] <Bosmon> colinclark, anastasiac: any ideas about the asymmetry in this mouse listener registration?
[10:49:15 EDT(-0400)] <Bosmon> var position = thatReorderer.layoutHandler.dropPosition(target, thatReorderer.activeItem, evt.clientX, evt.pageY);
[10:49:18 EDT(-0400)] <Bosmon> clientX, but pageY
[10:49:27 EDT(-0400)] <Bosmon> Could this be likely to cause a problem where there are horizontal scrollbars?
[10:49:34 EDT(-0400)] <colinclark> Bosmon: I have some vague memory of this being required.
[10:49:40 EDT(-0400)] <colinclark> But I fear Fish probably remembers best.
[10:49:44 EDT(-0400)] <colinclark> anastasiac: Do you remember?
[10:50:18 EDT(-0400)] <anastasiac> no - I recall fish and Joseph being the main people on that code - both not in the office today
[11:00:44 EDT(-0400)] * athena7 (n=athena7@adsl-99-149-83-32.dsl.wlfrct.sbcglobal.net) has joined #fluid-work
[11:04:00 EDT(-0400)] * jessm (n=Jess@c-76-19-199-61.hsd1.ma.comcast.net) has joined #fluid-work
[11:10:02 EDT(-0400)] <Bosmon> Oh dear...
[11:10:18 EDT(-0400)] <Bosmon> It appears that my "new avatar creator" has seemed to be working for a number of unfortunate reasons...
[11:27:42 EDT(-0400)] <athena7> how's the reorderer looking this morning?
[11:45:20 EDT(-0400)] <colinclark> anastasiac: I'm just taking a look at your FLUID-832 patch...
[11:45:39 EDT(-0400)] <colinclark> Were you able to confirm that this change didn't have any side effects in practice?
[11:46:13 EDT(-0400)] * anastasiac double-checks jira
[11:46:23 EDT(-0400)] <jessm> athena7: are we getting the right folks in touch with you? I just happened to see the other day that you were looking for someone in particular
[11:46:28 EDT(-0400)] <colinclark> I think it's a reasonable change, though it seems unfortunate that we have to change the code because of a quirk in our testing environment.
[11:46:36 EDT(-0400)] <colinclark> jessm: Yep, athena7 and I chatted that day.
[11:46:45 EDT(-0400)] <colinclark> And since then, she's been in touch with Justin_o and Bosmon.
[11:46:45 EDT(-0400)] <athena7> yep, thanks jess
[11:46:51 EDT(-0400)] <anastasiac> right - yes, the issue only occurs in the tests. The fix doesn't have any affect on the actual live behaviour
[11:46:53 EDT(-0400)] * jessm shrinks away – ignore me
[11:46:55 EDT(-0400)] <anastasiac> colinclark: ^
[11:46:59 EDT(-0400)] <athena7> turned out i'd run into an incompatibility between fluid and jquery ui 1.5
[11:47:07 EDT(-0400)] <colinclark> jessm: Don't shrink! Stay!
[11:47:12 EDT(-0400)] <athena7> i upgraded to 1.5.1 and everything magically fixed itself
[11:47:14 EDT(-0400)] <anastasiac> jessm, have we already rescheduled stand-ups?
[11:47:18 EDT(-0400)] <anastasiac> or should we be standing up?
[11:47:22 EDT(-0400)] <colinclark> athena7: Ah, good.
[11:47:24 EDT(-0400)] <jessm> lol, we're standing
[11:47:42 EDT(-0400)] <athena7> colin do you think we're at a point it makes sense to pull a revision out of the trunk, or should i hold off?
[11:47:53 EDT(-0400)] <colinclark> We're a little on the bleeding edge as far as jQuery UI goes, since we found a few bugs in 1.5.
[11:48:04 EDT(-0400)] <colinclark> athena7: Probably best answered by Bosmon.
[11:48:13 EDT(-0400)] <athena7> ok
[11:48:14 EDT(-0400)] <colinclark> I hope by the end of the day we should be fairly stable.
[11:48:20 EDT(-0400)] <athena7> sounds good
[12:07:46 EDT(-0400)] <colinclark> anastasiac: For your FLUID-832 patch, you've tested on a variety of browsers?
[12:08:23 EDT(-0400)] <anastasiac> colinclark, yes (though I would still want Justin_o to do his magic after a commit, just to be sure
[12:08:27 EDT(-0400)] <colinclark> k
[12:08:32 EDT(-0400)] <colinclark> +1 from me, then.
[12:08:39 EDT(-0400)] <colinclark> We've done this elsewhere in code, I remember.
[12:09:12 EDT(-0400)] <colinclark> oh, wait a second...
[12:09:12 EDT(-0400)] <Justin_o> anastasiac: just let me know when you are ready for me to test
[12:09:24 EDT(-0400)] <anastasiac> will do, thanks Justin_o
[12:09:36 EDT(-0400)] <colinclark> no no, it looks good
[12:09:37 EDT(-0400)] <colinclark>
[12:09:46 EDT(-0400)] <colinclark> I was just triple-checking.
[12:09:59 EDT(-0400)] <colinclark> anastasiac: Go for it. Nice work.
[12:11:07 EDT(-0400)] * ecochran (n=ecochran@dhcp-169-229-212-46.LIPS.Berkeley.EDU) has joined #fluid-work
[12:12:31 EDT(-0400)] <Bosmon> Don't you think the patch should include a specific comment indicating the issue it fixes?
[12:12:43 EDT(-0400)] <Bosmon> Since "ordinarily" we would expect jQuery's event normalisation to have been successful
[12:12:58 EDT(-0400)] <Bosmon> It seems this patch is going in the plugin purely to make the tests work...
[12:12:58 EDT(-0400)] <colinclark> Bosmon: Yes, I agree.
[12:13:01 EDT(-0400)] <colinclark> That's very good point.
[12:13:42 EDT(-0400)] <Bosmon> This should probably be JIRA'ed upstairs at jquery.simulate also...
[12:13:44 EDT(-0400)] <colinclark> Bosmon: Yes, that's the risk. It's a workaround to deal with limitations in our browser simulation abilitys.
[12:13:47 EDT(-0400)] <colinclark> Which is a total drag.
[12:13:56 EDT(-0400)] <colinclark> Bosmon: Yep, for sure.
[12:29:22 EDT(-0400)] <colinclark> Justin_o: In thinking about athena7's question, I'm wondering how the Layout Customizer is looking today.
[12:29:37 EDT(-0400)] <colinclark> from your perspective.
[12:30:56 EDT(-0400)] <anastasiac> Bosmon, sorry - just catching up
[12:31:15 EDT(-0400)] <Justin_o> colinclark: I did a quick check of the reorderer components this morning. It seemed to be the same as yesterday
[12:31:18 EDT(-0400)] <anastasiac> yes, I will file the issue with jQuery, and reference the ticket in the fix, with an explanation
[12:31:33 EDT(-0400)] <colinclark> Justin_o: So can you summarize yesterday, then?
[12:31:36 EDT(-0400)] <colinclark> I am terribly forgetful.
[12:31:56 EDT(-0400)] <Justin_o> colinclark: sure...
[12:33:00 EDT(-0400)] <Justin_o> 1) IE7 (vista) has a runtime error that causes the lightbox portlet to freeze
[12:33:42 EDT(-0400)] <Bosmon> That wasn't the stray comma that colin caught last night?
[12:34:02 EDT(-0400)] <Justin_o> 2) it appears that the same line causes portlets to freeze if you drop them with the pointer just outside of the drop target.
[12:34:18 EDT(-0400)] <Bosmon> Ah
[12:34:27 EDT(-0400)] <Justin_o> Bosmon: no... that is fluid-1140 and fluid-1137 i believe
[12:35:10 EDT(-0400)] <Justin_o> 3) if you move the lightbox portlet, you can't dnd a nested reorderable (image) to the last position
[12:35:36 EDT(-0400)] <Justin_o> 4) some other items that have to do with when the drop target appears
[12:36:13 EDT(-0400)] <Justin_o> colinclark: would you like the issues numbers?
[12:36:42 EDT(-0400)] <colinclark> sure
[12:37:21 EDT(-0400)] <Justin_o> Fluid-1124
[12:37:21 EDT(-0400)] <Justin_o> Fluid-1125
[12:37:22 EDT(-0400)] <Justin_o> Fluid-1127
[12:37:22 EDT(-0400)] <Justin_o> Fluid-1132
[12:37:22 EDT(-0400)] <Justin_o> Fluid-1137
[12:37:22 EDT(-0400)] <Justin_o> Fluid-1140
[12:38:00 EDT(-0400)] <Justin_o> I believe that Bosmon has set most of them as tasks
[12:38:38 EDT(-0400)] <colinclark> thanks
[12:38:50 EDT(-0400)] <colinclark> athena7: The version running here: http://mercury.unicon.net:8080/uPortal/render.userLayoutRootNode.uP
[12:38:56 EDT(-0400)] <colinclark> Is it the latest version of your integration?
[12:39:38 EDT(-0400)] <athena7> no
[12:40:00 EDT(-0400)] <athena7> i don't have a public test server to post to, unfortunately
[12:40:06 EDT(-0400)] <colinclark> okay, great.
[12:40:11 EDT(-0400)] <athena7> the version i have now i pulled out of trunk a couple days ago
[12:40:21 EDT(-0400)] <colinclark> k
[12:45:14 EDT(-0400)] <colinclark> Justin_o: This little "bug dashboard" you've pasted into the channel is really helpful.
[12:45:49 EDT(-0400)] <colinclark> I'm just going through the issues. athena7, can you summarize any major issues you're seeing in your current integration? Then Justin_o can cross reference them with JIRA issues for us.
[12:46:01 EDT(-0400)] <athena7> i haven't seen any issues so far
[12:46:14 EDT(-0400)] <athena7> hopefully once we get it into the trunk we can get some extra testing help
[12:46:21 EDT(-0400)] <colinclark> yes!
[12:46:31 EDT(-0400)] <colinclark> Justin_o can help test it, too.
[12:46:38 EDT(-0400)] <athena7> that'd be great!
[12:46:52 EDT(-0400)] <athena7> it seems to work pretty well
[12:46:55 EDT(-0400)] <colinclark> Bosmon is putting in some pretty herculean efforts to almost totally rework the drag and drop behaviour to work out all those subtle quirks. So the code is changing constantly.
[12:47:04 EDT(-0400)] <athena7> i can see the performance difference versus some of the older versions
[12:47:07 EDT(-0400)] <athena7> it seems a lot smoother
[12:47:08 EDT(-0400)] <colinclark> He's doing a pretty good job of not regressing, given how foundational the refactoring is.
[12:47:10 EDT(-0400)] <Justin_o> athena7: just point me to where you need me to test, when you have it up
[12:47:15 EDT(-0400)] <athena7> will do
[12:47:17 EDT(-0400)] <colinclark> Awesome!
[12:47:29 EDT(-0400)] <athena7> maybe once i get it committed i can get gary to update the mercury version or something
[12:47:33 EDT(-0400)] <colinclark> Justin_o: We can also update our daily build of uPortal with the latest version. We're still running 2.5, I think.
[12:47:53 EDT(-0400)] <colinclark> If our code is in uPortal, we should be building it daily and testing against it.
[12:48:00 EDT(-0400)] <athena7> sounds good to me
[12:48:05 EDT(-0400)] <Justin_o> colinclark: that makes sense
[12:48:23 EDT(-0400)] <athena7> running 2.5 of uPortal??
[12:48:41 EDT(-0400)] <colinclark> sorry, 2.6
[12:48:43 EDT(-0400)] <colinclark> yes of uPortal
[12:48:46 EDT(-0400)] <athena7> ah
[12:48:50 EDT(-0400)] <athena7> ok
[12:49:12 EDT(-0400)] <colinclark> http://build.fluidproject.org/uPortal/
[12:49:14 EDT(-0400)] <athena7> 2.6 has some html structure differences that may make a difference
[12:49:21 EDT(-0400)] <athena7> yeah
[12:49:22 EDT(-0400)] <colinclark> yeah, totally.
[12:49:27 EDT(-0400)] <colinclark> We are long overdue to upgrade to the latest.
[12:49:30 EDT(-0400)] <athena7>
[12:49:40 EDT(-0400)] <athena7> i think the decision was to only integrate fluid into 3.1+
[12:49:49 EDT(-0400)] <athena7> and not into the 3.0 patches branch
[12:49:57 EDT(-0400)] <colinclark> If you think the uP3 codebase is stable enough, we'll just add uP's trunk to our continuum and build it every day.
[12:49:59 EDT(-0400)] <athena7> so you may want to build against the trunk for a while, not sure
[12:50:06 EDT(-0400)] <colinclark> athena7: Cool. We agree.
[12:50:17 EDT(-0400)] <athena7> i haven't been working on a lot of up3 stuff lately, so i'm not sure what the state is
[12:50:22 EDT(-0400)] <athena7> i know eric just put out a milestone release
[12:50:32 EDT(-0400)] <athena7> he'd be the one to ask about its stability though
[12:52:27 EDT(-0400)] <colinclark> okay, so i'll keep trolling through jira and will get a feel for where we're at
[12:52:56 EDT(-0400)] <colinclark> Bosmon is probably going to push through the weekend on some of his fixes, but we'll make a call on whether or not to do it in a branch...
[12:53:03 EDT(-0400)] <colinclark> since he's going on vacation to Scotland next week.
[12:54:35 EDT(-0400)] <colinclark> Justin_o: For the record, you totally rule.
[12:55:12 EDT(-0400)] <Justin_o> oh well thank you
[12:55:25 EDT(-0400)] <colinclark> I don't know what we did without you on the team to keep us honest!
[12:55:54 EDT(-0400)] <jessm> am i the only one who finds the listing out of existing issues exciting?
[12:57:52 EDT(-0400)] <ecochran> FYI: just noticed that there is a jQuery UI 1.5.2... haven't looked at the changes
[12:58:16 EDT(-0400)] <ecochran> "As a last comment, this is probably the last minor release before 1.6, which we will announce before the end of July, so watch out for a couple of awesome new components and enhancements soon!"
[12:58:38 EDT(-0400)] <ecochran> boy, have I not been paying attention
[12:58:52 EDT(-0400)] <ecochran> and boy, are they late!
[12:59:09 EDT(-0400)] <Justin_o> ecochran: would you happen to know off hand if there is an api for the doh.robot that was mentioned in the article you sent to the list
[12:59:25 EDT(-0400)] <ecochran> didn't see it, but then I didn't look
[13:00:15 EDT(-0400)] <Justin_o> ecochran: that's okay.. i didn't see it and i did look... mind you i may have just missed it..
[13:00:31 EDT(-0400)] <colinclark> athena7: Okay, I have something vaguely resembling a plan.
[13:01:02 EDT(-0400)] <colinclark> Goal: ensure LayoutCustomizer is looking really hot in uPortal in time for Infusion 0.5 beta and uP3.1.
[13:01:15 EDT(-0400)] <athena7> ooh, a plan!
[13:01:22 EDT(-0400)] <colinclark> Let's give Bosmon the day to continue his work, since he thinks he can make some further improvements.
[13:01:26 EDT(-0400)] <colinclark> He's on high alert for regressions.
[13:01:39 EDT(-0400)] <colinclark> There's some snarly code, so if things get rough he'll just use a branch.
[13:01:42 EDT(-0400)] <colinclark> So.
[13:01:50 EDT(-0400)] <athena7> cool
[13:02:02 EDT(-0400)] <colinclark> On Monday, we'll either: 1) use today's latest revision, which is looking good, but has a few quirks
[13:02:12 EDT(-0400)] <athena7> just let me know when you have a revision you'd recommend using to start out with in the portal?
[13:02:14 EDT(-0400)] <colinclark> or 2) if things go well with the refactoring, we'll grab the latest on Monday.
[13:02:18 EDT(-0400)] <athena7> awesome
[13:02:31 EDT(-0400)] <colinclark> At that point, let's get it into uP trunk so other people can actually see it and test it.
[13:02:50 EDT(-0400)] <colinclark> Again, aiming that we'll finalize on the 0.5beta version.
[13:02:55 EDT(-0400)] <colinclark> Does that seem reasonable?
[13:04:16 EDT(-0400)] <colinclark> athena7: ^
[13:04:32 EDT(-0400)] <athena7> yep
[13:04:37 EDT(-0400)] <athena7> sounds perfect
[13:05:34 EDT(-0400)] <colinclark> awesome
[13:05:55 EDT(-0400)] <colinclark> for the record, we're at revision 5361 at the moment, and it's looking decent.
[13:06:27 EDT(-0400)] <athena7> ok, sounds good
[13:06:44 EDT(-0400)] <colinclark> thanks for all your help with htis
[13:06:48 EDT(-0400)] <athena7> yeah, no problem
[13:06:55 EDT(-0400)] <colinclark> i'm pretty excited to see it all come together in uPortal./
[13:06:57 EDT(-0400)] <athena7> thank to you guys for helping us get everything sorted out
[13:06:59 EDT(-0400)] <athena7> yeah, me too!
[13:07:15 EDT(-0400)] <colinclark> Gary, jessm, and I met yesterday to talk about how we might get lots of other components into uPortal.
[13:07:28 EDT(-0400)] <athena7> oh yeah?
[13:07:29 EDT(-0400)] * jessm is excited too!
[13:07:31 EDT(-0400)] <athena7> sounds promising
[13:08:00 EDT(-0400)] <athena7> any specific ones you're looking at?
[13:10:39 EDT(-0400)] <colinclark> We're not totally sure yet, but Gary is excited about the new announcement portlet, since he sees a lot of the idioms that Fluid components tend to support.
[13:10:57 EDT(-0400)] <colinclark> Other ideas bounced around were to look at the admin tools that ship with uPortal, though I gather they're pretty rusty at this point.
[13:11:18 EDT(-0400)] <colinclark> Ideas are always appreciated, so if you have any thoughts... fire away.
[13:18:12 EDT(-0400)] <athena7> sounds good to me
[13:18:29 EDT(-0400)] <athena7> actually we'd talked about replacing the existing admin tools with new admin portlets
[13:18:41 EDT(-0400)] <athena7> i'd done some prototype work at the conference, but i haven't really had time to touch it since
[13:18:50 EDT(-0400)] <athena7> i'd love it if we had like a reusable groups selector type thing
[13:18:55 EDT(-0400)] <athena7> ajax-y and friendly
[13:19:08 EDT(-0400)] <athena7> to replace that awkward groups and categories picking functionality
[13:19:16 EDT(-0400)] <athena7> i've always found that to be confusing and hard to use
[13:44:42 EDT(-0400)] <colinclark> athena7: We have nice list picker, which Eli design and that we almost used as an example for the first JavaScript workshop.
[13:44:49 EDT(-0400)] <colinclark> It would be great for groups and users.
[13:44:59 EDT(-0400)] <athena7> i remember you mentioning that in the js workshop
[13:58:33 EDT(-0400)] <colinclark> Justin_o: Eli and I are screen sharing at the moment...
[13:58:36 EDT(-0400)] <colinclark> working on Uploader
[13:58:45 EDT(-0400)] <colinclark> and he just noticed the doh.robot documentation on my screen.
[13:58:58 EDT(-0400)] <colinclark> The API spec is actually within this tutorial, about a third of the way down.
[13:59:00 EDT(-0400)] <colinclark> http://dojotoolkit.org/2008/08/11/doh-robot-automating-web-ui-unit-tests-real-user-events
[13:59:06 EDT(-0400)] <Bosmon> So... we are around 30% faster in the drag loop now...
[13:59:07 EDT(-0400)] <colinclark> typeKeys: function(/Function/ sec, /String||Number/ chars, /Integer, optional/ delay, /Integer, optional/ speed){
[13:59:13 EDT(-0400)] <Bosmon> Unclear how much of this is simple savings on garbage
[13:59:45 EDT(-0400)] <Bosmon> Looks like the "new hit testing" is around 20% faster than the old one, despite being more useful
[14:00:27 EDT(-0400)] <colinclark> Bosmon: Those are pretty good numbers.
[14:00:35 EDT(-0400)] <colinclark> 75% more useful, and 20% faster!
[14:01:16 EDT(-0400)] <Bosmon>
[14:01:17 EDT(-0400)] <Justin_o> colinclark: thanks.. i was looking at that. I can't seem to get it to work on my machine though.. even if i copy and paste the source from their samples and adjust the paths to point to the correct locations... i'm probably doing something wrong.. just not sure what it is..
[14:16:52 EDT(-0400)] * simonwang (n=chatzill@swang.itservices.ubc.ca) has joined #fluid-work
[14:17:11 EDT(-0400)] <simonwang> Hi anastasiac
[14:18:20 EDT(-0400)] <anastasiac> hi, simonwang
[14:20:36 EDT(-0400)] <simonwang> when call fluid.initLayoutCustomizer, if the callback url is provided, then the callback function in options will not be used. Is this a documented feature?
[14:22:25 EDT(-0400)] <anastasiac> hm. I'll have to check... if you didn't see it in the docs, then I'd say it's not documented
[14:22:31 EDT(-0400)] <anastasiac> the question is: is that a feature, or a bug?
[14:24:32 EDT(-0400)] * anastasiac reviews the code
[14:24:49 EDT(-0400)] <simonwang> I think this should be called a feature. Because we have two ways to provide the callbacks to server, we can use only one of them, either the callback function, or the callback url.
[14:26:57 EDT(-0400)] <anastasiac> ok, simonwang, yes - this is the way it is designed. You can provide one or the other, and if the url is provided, it overrides any function.
[14:27:07 EDT(-0400)] <anastasiac> Thanks for catching the fact that it's not documented! I'll fix that
[14:29:20 EDT(-0400)] <simonwang> Thanks! and also if the callback function can be configured through the options is added to the doc (I may miss this), it would be very helpful for people to use it.
[14:31:40 EDT(-0400)] * jessm (n=Jess@c-76-19-199-61.hsd1.ma.comcast.net) has joined #fluid-work
[14:32:45 EDT(-0400)] <anastasiac> I'm not quite clear on what you're asking, simonwang?
[14:38:25 EDT(-0400)] <simonwang> When calling fluid.initLayoutCustomizer, the last parameter is options. options can carry orderChangedCallback to createLayoutCustomizer. This callback function will be used when a portlet is moved.
[14:39:27 EDT(-0400)] <simonwang> This way of passing the callback function is very useful for people using fluid.
[14:40:05 EDT(-0400)] <anastasiac> oh, so this is not documented?? well, that's certainly an oversight!!
[14:40:10 EDT(-0400)] <anastasiac> thanks for catching that!
[14:40:26 EDT(-0400)] <anastasiac> we really appreciate feedback from people who are using our documentation
[14:47:31 EDT(-0400)] <anastasiac> simonwang, are you using the 0.4 release bundle, or are you working from trunk?
[15:02:39 EDT(-0400)] <simonwang> I'm using the 0.4 release bundle.
[15:12:40 EDT(-0400)] * phiggins (n=dante@c-68-34-199-67.hsd1.tn.comcast.net) has joined #fluid-work
[15:14:14 EDT(-0400)] * ecochran (n=ecochran@dhcp-169-229-212-46.LIPS.Berkeley.EDU) has joined #fluid-work
[19:24:04 EDT(-0400)] * colinclark (n=colin@bas1-toronto09-1279543344.dsl.bell.ca) has joined #fluid-work
[20:33:46 EDT(-0400)] * ecochran (n=ecochran@adsl-70-137-136-44.dsl.snfc21.sbcglobal.net) has joined #fluid-work
[21:05:55 EDT(-0400)] * ecochran (n=ecochran@adsl-70-137-136-44.dsl.snfc21.sbcglobal.net) has left #fluid-work