fluid-work IRC Logs-2012-02-02

Owned by Fluid IRC Log Bot
Last updated: Feb 02, 2012Version comment
4 min read

[09:13:30 CST(-0600)] <Justin_o> jhung1: hello

[09:13:52 CST(-0600)] <jhung1> hey

[09:13:55 CST(-0600)] <jhung1> justin_o

[09:15:30 CST(-0600)] <Justin_o> jhung1: i'm just about wrapped up with the server side file validation.. just running some final tests. I have unit tests in place too.

[09:15:55 CST(-0600)] <jhung1> justin_o: great!

[09:16:22 CST(-0600)] <jhung> justin_o: maybe we can chat after you're done that. I'd like to show you what I have so far with the exporter UI.

[09:16:47 CST(-0600)] <jhung> justin_o: I'll need your ideas on how best to reveal the options for each export format.

[09:17:43 CST(-0600)] <Justin_o> jhung: sounds good.. i don't think i'll be too much longer

[09:18:18 CST(-0600)] <jhung> okay justin_o, ping me when you're done.

[09:19:38 CST(-0600)] <Justin_o> jhung: okay, will do

[09:30:38 CST(-0600)] <alexn> michelled, cindyli, anastasiac: I've updated Floe Iteration Plan. Added a current state for the JIRA I'm working on as well as added links to the branches with code. I also refactored mediaElement code to be infusion style so that if you decide to work on this ticket, it will be easier and more intuitive.

[09:31:36 CST(-0600)] <michelled> thx alexn. when you say you've refactored mediaElement, did you change their code?

[09:33:09 CST(-0600)] <alexn> michelled, I mean I just create a wrapper component around it as we did with captionator. Basically it is a component which has control over mediaElement and which we can extend to meet our needs.

[09:33:26 CST(-0600)] <michelled> ah, great

[09:35:16 CST(-0600)] <alexn> I called it nonHTML5Player … which is not a good name I know (smile) , but we can rename it anytime we want plus there still lots of work has to be done around it

[09:37:17 CST(-0600)] <jhung> justin_o: before we chat, you should pull down my decapod-ui repo so you can see what I'm talking about. https://bitbucket.org/jhung/decapod-ui

[09:54:30 CST(-0600)] <Justin_o> jhung: okay… i'll pull down your code now

[09:54:48 CST(-0600)] <jhung> ok justin_o

[09:56:15 CST(-0600)] <Justin_o> jhung: ready

[10:26:47 CST(-0600)] <cindyli> michelled, anastasiac, alexn, i'm looking at the iteration plan to find more work. The only jira left that no one has taken it on is 4586 - Add the detection of html5/non-html5 browser into framework. michelled, i vaguely rmb you mentioned that you like to work on it?

[10:27:31 CST(-0600)] <michelled> cindyli: I was thinking of picking it up after I'm done with universal subtitles but this is taking me longer than I had thought

[10:27:35 CST(-0600)] <michelled> cindyli: go ahead

[10:28:00 CST(-0600)] <michelled> cindyli: I also think that anastasiac has too much under her name - she will have to share her tasks at some point (wink)

[10:28:30 CST(-0600)] <cindyli> ok, michelled, anastasiac, let me know if any help you need

[10:28:41 CST(-0600)] <cindyli> meantime, i will work on 4586

[10:28:44 CST(-0600)] <anastasiac> no, I only have one JIRA right now, I've dropped the others

[10:29:06 CST(-0600)] <anastasiac> cindyli, you could have a look at 4567

[10:29:21 CST(-0600)] <cindyli> sure, anastasiac, 4567 first

[10:29:24 CST(-0600)] <cindyli> (smile)

[10:29:39 CST(-0600)] <anastasiac> I'm just double-checking how far I got - it wasn't far

[10:51:14 CST(-0600)] <anastasiac> cindyli, regarding FLUID-4567: I pushed what I have so far to github: https://github.com/acheetham/videoPlayer/tree/FLUID-4567-subcomponents-for-trees

[10:51:30 CST(-0600)] <cindyli> thanks, anastasiac

[10:51:38 CST(-0600)] <anastasiac> All I've done so far is to split the template for the controls into a separate file and modify the controllers component to load that new template

[10:51:50 CST(-0600)] <cindyli> that helps

[10:54:23 CST(-0600)] <michelled> anastasiac: here's the link to filament groups widget: http://filamentgroup.com/lab/jquery_ipod_style_and_flyout_menus/

[10:55:12 CST(-0600)] <michelled> in the 'download the script' section you'll find links to the jquery ui's work on it

[10:55:49 CST(-0600)] <anastasiac> thanks, michelled

[10:56:06 CST(-0600)] <anastasiac> I'll have a look

[12:01:53 CST(-0600)] <cindyli> Bosmon: r u there

[12:31:44 CST(-0600)] <Justin_o> colinclark: i've was looking at changing the response returned from the Decapod server on uploading an image to be 201

[12:33:13 CST(-0600)] <Justin_o> 201 is for "Created". I figure this is a bit more specific

[12:34:40 CST(-0600)] <Justin_o> however looking through the uploader code it looks as though anything but a 200 or 0 are treated as errors

[12:34:40 CST(-0600)] <Justin_o> https://github.com/fluid-project/infusion/blob/master/src/webapp/components/uploader/js/HTML5UploaderSupport.js#L95-108

[12:36:32 CST(-0600)] <Justin_o> was there any specific reason for not accepting more than just a 200 as a successful response?

[12:36:37 CST(-0600)] <Justin_o> colinclark: ^

[12:42:19 CST(-0600)] <colinclark> Justin_o: Nope

[12:42:23 CST(-0600)] <colinclark> I'd say file a JIRA about it

[12:42:37 CST(-0600)] <colinclark> and, if you want, submit a patch that accepts anything in the 200 range as success

[12:42:45 CST(-0600)] <colinclark> or if you'd rather, I can implement it

[12:42:51 CST(-0600)] <colinclark> but you've got exactly the right line number, etc.

[12:43:06 CST(-0600)] <Justin_o> colinclark: i should be able to file a jira and send a patch

[12:43:10 CST(-0600)] <Justin_o> thanks

[12:43:19 CST(-0600)] <colinclark> There are pretty extensive Uploader unit tests

[12:43:29 CST(-0600)] <colinclark> so take a look at those when you prepare your pull request

[12:44:50 CST(-0600)] <Justin_o> colinclark: thanks for the tip, will do

[12:49:36 CST(-0600)] <colinclark> Justin_o: by the way, I admire your dedication to REST's semantics

[12:49:39 CST(-0600)] <colinclark> super cool

[12:51:14 CST(-0600)] <Justin_o> colinclark: (smile) thanks.. i've been trying. I've been noticing all the mistakes I made for 0.5a and am trying to clean them up now.

[12:51:25 CST(-0600)] <colinclark> cool

[12:58:43 CST(-0600)] <Justin_o> colinclark: what would think makes more sense.. restricting the range to only valid 2xx responses that make sense specially for uploader.. or leaving it open to any 200 response.. which may help future proof it a bit, if more are added later