fluid-work IRC Logs-2009-01-07

Owned by Fluid IRC Log Bot
Last updated: Jan 07, 2009Version comment
4 min read

[08:42:05 EST(-0500)] * Justin_o (n=Justin@142.150.154.101) has joined #fluid-work
[09:04:23 EST(-0500)] * hydee (n=hydee@bas10-ottawa23-1088819434.dsl.bell.ca) has joined #fluid-work
[09:18:02 EST(-0500)] * apetro (n=apetro@ip68-3-207-51.ph.ph.cox.net) has joined #fluid-work
[09:29:44 EST(-0500)] * jessm (n=Jess@c-24-34-214-137.hsd1.ma.comcast.net) has joined #fluid-work
[09:46:40 EST(-0500)] * anastasiac (n=stasia@142.150.154.235) has joined #fluid-work
[09:46:45 EST(-0500)] * jessm_ (n=Jess@c-24-34-214-137.hsd1.ma.comcast.net) has joined #fluid-work
[09:49:33 EST(-0500)] * colinclark (n=colin@user144-96.wireless.utoronto.ca) has joined #fluid-work
[10:28:46 EST(-0500)] <fj4000> I've posted a patch for 2005: http://issues.fluidproject.org/browse/FLUID-2005 - would anyone mind having a look?
[10:45:19 EST(-0500)] * colinclark (n=colin@142.150.154.101) has joined #fluid-work
[11:15:50 EST(-0500)] * dlester (n=dlester@129.174.112.237) has joined #fluid-work
[11:17:34 EST(-0500)] * EricDalquist (n=dalquist@bohemia.doit.wisc.edu) has joined #fluid-work
[11:25:34 EST(-0500)] * dlester (n=dlester@129.174.112.237) has left #fluid-work
[11:26:14 EST(-0500)] * apetro (n=apetro@12.164.139.7) has joined #fluid-work
[11:26:53 EST(-0500)] * ecochran (n=ecochran@dhcp-169-229-212-24.LIPS.Berkeley.EDU) has joined #fluid-work
[11:44:08 EST(-0500)] <fj4000> I've posted a patch for 1986: http://issues.fluidproject.org/browse/FLUID-1986 - would anyone mind having a look?
[11:53:27 EST(-0500)] <fj4000> I've posted a patch for 1998: http://issues.fluidproject.org/browse/FLUID-1998 - would anyone mind having a look?
[11:53:44 EST(-0500)] <colinclark> fj4000 is churning out patches. (smile)
[11:54:04 EST(-0500)] <fj4000> everyone's so busy....so reviews yet (tongue)
[11:54:11 EST(-0500)] <fj4000> *so no
[11:54:24 EST(-0500)] <colinclark> Is this something ecochran could take a peek at?
[11:54:46 EST(-0500)] <fj4000> absolutely!
[11:54:56 EST(-0500)] <fj4000> they're all very small
[11:55:30 EST(-0500)] <ecochran> fj4000 and colinclark : I'll take a look
[11:55:41 EST(-0500)] <fj4000> (smile)
[11:55:46 EST(-0500)] <colinclark> Thanks, ecochran.
[12:08:43 EST(-0500)] * clown (n=clown@guiseppi.atrc.utoronto.ca) has joined #fluid-work
[12:27:05 EST(-0500)] * Bosmon (n=Antranig@ginger.caret.cam.ac.uk) has joined #fluid-work
[12:39:29 EST(-0500)] <ecochran> fj4000, colinclark, Justin_o : Both patches look good. I reviewed the code and tested the fix. Both check out. I'll add a comment to the JIRAs and leave it to you to check in the changes.
[12:39:44 EST(-0500)] <fj4000> thanks eli!
[12:40:05 EST(-0500)] <Justin_o> ecochran: thanks
[13:04:46 EST(-0500)] <ecochran> anyone for Standup?
[14:29:27 EST(-0500)] * michelled (n=team@142.150.154.197) has joined #fluid-work
[14:38:45 EST(-0500)] <anastasiac> ecochran, colinclark: either of you have a moment for a technical question about a specific thing in the Uploader code?
[14:38:51 EST(-0500)] <anastasiac> (I'm reviewing the tech docs)
[14:39:05 EST(-0500)] <ecochran> sure
[14:39:22 EST(-0500)] <colinclark> anastasiac: of course
[14:39:48 EST(-0500)] <anastasiac> in SWFUploadManager.js, in removeFIle(), afterFileRemoved is fired, passing the file object
[14:40:18 EST(-0500)] <anastasiac> in Uploader.js, in bindModelEvents(), the listener that is bound to afterFileRemoved doesn't take a parameter
[14:40:39 EST(-0500)] <anastasiac> am I missing something? or is this a small bug?
[14:40:49 EST(-0500)] <colinclark> anastasiac: (smile)
[14:41:05 EST(-0500)] <colinclark> Dynamically typed languages are great.
[14:41:34 EST(-0500)] <colinclark> So, in this particular case, the Uploader's afterFileRemoved listener isn't interested in which particular file was removed.
[14:41:39 EST(-0500)] <anastasiac> ok, I'm getting it now
[14:41:48 EST(-0500)] <anastasiac> see - I need to write more code!
[14:41:51 EST(-0500)] <anastasiac> I've forgotten how!
[14:41:55 EST(-0500)] <anastasiac> (smile)
[14:41:56 EST(-0500)] <colinclark> It just needs to update some overall state whenever files are removed.
[14:42:03 EST(-0500)] <colinclark> So as a result, it just omits the argument.
[14:42:11 EST(-0500)] <anastasiac> yes, I get it
[14:42:19 EST(-0500)] <anastasiac> I just haven't thought in Javascript lately
[14:42:25 EST(-0500)] <colinclark> In a statically typed language, this would be a problem, but in JavaScript you can just ignore arguments you're not interested in.
[14:42:30 EST(-0500)] <colinclark> anastasiac: We'll have to change that.
[14:42:32 EST(-0500)] <anastasiac> exactly
[14:42:38 EST(-0500)] <anastasiac> yes, I know all of this
[14:42:42 EST(-0500)] <anastasiac> I've just forgotten
[14:43:06 EST(-0500)] <anastasiac> sorry to bother you all with such silly questions!
[14:43:45 EST(-0500)] * phiggins (n=dante@c-68-34-199-67.hsd1.tn.comcast.net) has joined #fluid-work
[14:45:48 EST(-0500)] <colinclark> anastasiac: not silly at all
[14:46:33 EST(-0500)] <anastasiac> "there are no silly questions, only silly people who ask questions" :-P
[14:53:11 EST(-0500)] <anastasiac> colinclark, ecochran: another quick question
[14:53:19 EST(-0500)] <colinclark> shoot
[14:53:32 EST(-0500)] <anastasiac> If I see "that.queue.currentBatch.files" in the code, that's a list of all of the files in the current batch, as opposed to a specific file?
[14:56:09 EST(-0500)] <anastasiac> bueller?
[14:56:11 EST(-0500)] <anastasiac> bueller?
[14:57:11 EST(-0500)] <ecochran> anastasiac: not a specific file, could be thought of as a list of files but is really an object that contains a collection of file objects
[14:57:22 EST(-0500)] <ecochran> so that you can get data about each file
[14:57:33 EST(-0500)] <anastasiac> that.currentBatch = {
[14:57:33 EST(-0500)] <anastasiac> fileIdx: -1,
[14:57:33 EST(-0500)] <anastasiac> files: [],....
[14:57:39 EST(-0500)] <anastasiac> so it's an array, no?
[14:58:03 EST(-0500)] <anastasiac> no, not necessarily
[14:58:03 EST(-0500)] * anastasiac tries to figure out how to describe this object to the API users
[14:58:32 EST(-0500)] <ecochran> we needed a way to distinguish between the queue and the current batch
[14:58:47 EST(-0500)] <ecochran> current batch is a subset of the queue.files
[14:59:14 EST(-0500)] <ecochran> since queue.files contains files which have already been uploaded or that have errored
[15:00:08 EST(-0500)] <ecochran> ah, except that currentbatch also contains a little bit of data that help us keep track of where we are in the current upload, thus fileIndx
[15:00:13 EST(-0500)] <ecochran> fileIdx
[15:01:05 EST(-0500)] <anastasiac> currentBatch.files is what is provided when the event fires, i.e. is what is available to event listeners
[15:01:34 EST(-0500)] <anastasiac> so would I say that it's a list of file objects (qualifying that it's a subset)
[15:01:35 EST(-0500)] <anastasiac> ?
[15:01:44 EST(-0500)] <ecochran> yes
[15:01:57 EST(-0500)] <anastasiac> ok, cool - thanks so much for the clarification!
[15:03:08 EST(-0500)] <ecochran> anastasiac: it might be worth mentioning that the data in a file object could be different depending on which uploadmanager is being used, since the uploadmanager populates the file objects into the filequeue
[15:03:22 EST(-0500)] <anastasiac> ok, thanks
[15:03:25 EST(-0500)] <ecochran> I'm sure that we will need to gureentee some data elements
[15:03:36 EST(-0500)] <ecochran> but that others may be there that could be unexpected
[15:03:53 EST(-0500)] <ecochran> in fact right now there is data in the file object that we don't document because we dont use it
[15:16:03 EST(-0500)] <colinclark> ecochran, anastasiac: Clarifying the distinction between the queue and the current batch might be nicely accomplished with a little picture
[15:16:16 EST(-0500)] <colinclark> showing how files that are already done are part of the queue
[15:16:19 EST(-0500)] <colinclark> but not part of the current batch
[15:16:28 EST(-0500)] <colinclark> if you know what i mean (i am multiasking) (wink)
[15:17:01 EST(-0500)] <anastasiac> yes, colinclark - a screen shot of a queue in which some files are already uploaded, showing that the 'not yet uploaded' files would be considered the 'current batch'
[15:17:17 EST(-0500)] <colinclark> yeah, totally
[15:17:37 EST(-0500)] <colinclark> ecochran and I had to think through this distinction between the whole queue and the notion of a batch for awhile.
[15:18:19 EST(-0500)] <colinclark> So it might not be immediately obvious to users, but a picture would be cool.
[15:18:42 EST(-0500)] * michelled (n=team@142.150.154.197) has left #fluid-work
[15:33:24 EST(-0500)] * ecochran (n=ecochran@dhcp-169-229-212-24.LIPS.Berkeley.EDU) has left #fluid-work
[17:29:35 EST(-0500)] * clown (n=clown@guiseppi.atrc.utoronto.ca) has left #fluid-work
[20:38:35 EST(-0500)] * apetro (n=apetro@ip68-3-207-51.ph.ph.cox.net) has joined #fluid-work