fluid-work IRC Logs-2012-06-14

[09:41:57 CDT(-0500)] <jhung> justin_o: I will be doing a little testing of genpdf today, especially the DPI and width/height options. I want to see how these two options interact.

[09:42:24 CDT(-0500)] <Justin_o> jhung: great thanks.. i'm still testing out the 12.04 upgrade stuff

[09:43:19 CDT(-0500)] <jhung> justin_o: cool. I'm using 10.04

[09:45:35 CDT(-0500)] <Justin_o> jhung: okay.. good to start with that

[09:50:34 CDT(-0500)] <jhung> justin_o: I was just thinking about when we do automate the genpdf test plan, the output files can be named according to the input file(s) and the options used.

[09:51:16 CDT(-0500)] <Justin_o> jhung: that makes sense.. will help keep track of them

[09:51:24 CDT(-0500)] <Justin_o> and hopefully reduce confusion

[09:56:17 CDT(-0500)] <Justin_o> jhung: are we putting off the upgrade to Ocropus 0.5 till a later release?

[10:01:35 CDT(-0500)] <jhung> justin_o: I hope not. We need to get Hasan to give us a plan on how he expects to upgrade.

[10:01:58 CDT(-0500)] <Justin_o> jhung: yes.. from the last meeting it didn't sound like he wanted to upgrade at all

[10:03:10 CDT(-0500)] <jhung> justin_o: hesitant, yes, but I think he'd be willing to if given the right reasons (i.e. quality improvements).

[10:03:32 CDT(-0500)] <jhung> the tough part is that it's probably a heavy investment to do the upgrade.

[10:04:24 CDT(-0500)] <Justin_o> jhung: could be.. i guess we don't really know what's involved.. at least i don't

[10:04:36 CDT(-0500)] <jhung> yeah. Neither do I justin_o.

[10:04:49 CDT(-0500)] <jhung> I guess we should talk to him about it.

[10:04:53 CDT(-0500)] <Justin_o> jhung: okay

[10:04:59 CDT(-0500)] <jhung> But let's sort out the Ubuntu 12.04 issue first.

[10:05:11 CDT(-0500)] <jhung> Get that stable, then let's try to tackle Ocropus 0.5

[10:07:40 CDT(-0500)] <Justin_o> jhung: sounds like a plan..

[10:08:21 CDT(-0500)] <Justin_o> jhung: still trying to test out avatar's install changes.. but it's going slow.. also setting up a new dev vm in Ubuntu 12.04

[10:12:04 CDT(-0500)] <jhung> okay justin_o.

[10:44:52 CDT(-0500)] <jhung> justin_o: is it feasible to implement a unit picker for the exporter UI? Idea is the user can choose between inches, cm, and pixels, and labels and units change to reflect their choice.

[10:50:28 CDT(-0500)] <Justin_o> um.. i'm not sure i follow completely

[10:50:50 CDT(-0500)] <Justin_o> so we wouldn't expose the dpi option in that case?

[10:50:53 CDT(-0500)] <Justin_o> jhung: ^

[10:52:08 CDT(-0500)] <jhung> justin_o: the units is an internationalization preference.

[10:53:29 CDT(-0500)] <jhung> Example: there is a selector for output dimensions of common page sizes (i.e. A4, 8.5x11, etc). Their units would be displayed as cm, inches, or pixels.

[10:54:21 CDT(-0500)] <jhung> (although the pixels value for this selector would change depending on the DPI)

[10:57:13 CDT(-0500)] <Justin_o> jhung_away: yes i was specifically wondering about how we would handle that.. i suppose for inches we could just do the conversion in the UI.. the pixels would be the more confusing one for the user i think

[10:59:12 CDT(-0500)] <logiclord> yura : can we discuss about pagination issue ?

[10:59:28 CDT(-0500)] <yura> logiclord: sure

[11:00:10 CDT(-0500)] <logiclord> yura : now I have managed to parse and load chapter content for validated epub 2 and mostly epub 3 as well

[11:00:24 CDT(-0500)] <yura> logiclord: awesome

[11:00:43 CDT(-0500)] <logiclord> and the issue is how do I divide chapter (which you can think as an html file)

[11:01:07 CDT(-0500)] <logiclord> multiple solutions are there but I think we should according to our case

[11:01:28 CDT(-0500)] <logiclord> 1 preprocess entire page and divide to store in an array of pages

[11:01:42 CDT(-0500)] <logiclord> pro - easy next - prev

[11:02:13 CDT(-0500)] <logiclord> cons - even a small change in css by UI option component will reset our chapter

[11:02:27 CDT(-0500)] <logiclord> and no preview for UI option ?

[11:03:16 CDT(-0500)] <logiclord> other way could be that I tried to keep entire chapter separate and current page being maintained and extracted everytime we go next-prev

[11:03:30 CDT(-0500)] <logiclord> any other option you would like to suggest ?

[11:04:04 CDT(-0500)] <logiclord> and which to choose.. I am really confused

[11:04:27 CDT(-0500)] <logiclord> moreover editing features will make things even more complicated

[11:05:55 CDT(-0500)] <yura> logiclord: right, so for the second option you would need to recalculate things on the fly everytime presentation changes ?

[11:07:17 CDT(-0500)] <logiclord> yura : for presentation changes I would have to recalculate in both the cases but I would be easy in second case

[11:07:33 CDT(-0500)] <yura> logiclord: and what would be the drawback ?

[11:07:39 CDT(-0500)] <yura> for the second case

[11:08:36 CDT(-0500)] <logiclord> yura : for every next-previous page click we would have to recalculate (basically DOM tree traveral to reach nearest leaf)

[11:09:55 CDT(-0500)] <logiclord> yura : actually having images make things complicated

[11:09:57 CDT(-0500)] <cindyli> anastasiac: can you clarify what "current page has text shadow; get rid of in high-contrast" means in jira: http://issues.fluidproject.org/browse/FLOE-15

[11:11:08 CDT(-0500)] <anastasiac> cindyli, in the main navigation bar, whichever page is the current page (i.e. with the green background in the regular theme), the text has a shadow. We should get rid of the shadow in high-contrast

[11:12:11 CDT(-0500)] <yura> logiclord: and the calculation takes significant time ?

[11:12:58 CDT(-0500)] <cindyli> ok, thanks, anastasiac

[11:13:35 CDT(-0500)] <anastasiac> alexn, if you're looking for something to work on this one: "Search results "details" toggle" I didn't actually get anything done yesterday, so you could work on that

[11:13:37 CDT(-0500)] <logiclord> yura : actually I have not tried it

[11:15:11 CDT(-0500)] <yura> logiclord: I think in case of an actual e-book , it generally recalculate things once things update, so maybe it makes sense to test the second approach and see how demanding it is

[11:15:52 CDT(-0500)] <alexn> anastasiac: sure! I just need to push a pull request to Andrey and will start working on this

[11:16:06 CDT(-0500)] <logiclord> yura : okay I will implement second option and test it

[11:17:41 CDT(-0500)] <logiclord> yura : I think we should edit entire chapter in WYSIWYG editor rather then individual pages

[11:17:52 CDT(-0500)] <logiclord> yura : just from experience

[11:31:54 CDT(-0500)] <logiclord> yura : forgot to mention in second option we can't move directly to a particular page in a chapter but we can in first one

[11:32:39 CDT(-0500)] <logiclord> bascially second will not give much indication of content left and alreay read in current chapter

[11:43:28 CDT(-0500)] <anastasiac> michelled, my fix for the failed login accessibility is ready for your review: https://github.com/acheetham/OER-Commons/tree/584-failed-login

[13:05:18 CDT(-0500)] <jhung_away> justin_o: re DPI. I guess only inches and cm are required as a view option. So is this a feasible thing to do on the UI?

[13:06:17 CDT(-0500)] <Justin_o> jhung_away: sure i think so.. the conversion between the two shouldn't be too hard

[13:12:23 CDT(-0500)] <anastasiac> cindyli, you mentioned a way to configure screen readers to read the longest label/title/text. Do you know how to do this in Jaws and NVDA?

[13:13:34 CDT(-0500)] <cindyli> anastasiac: i will dig out from Jaws and let u know. not sure about NVDA. As alexn mentioned, the default NVDA setting might already reads out the label

[13:14:26 CDT(-0500)] <alexn> yes NVDA should read out the label - at least it is default behaviour

[13:14:29 CDT(-0500)] <alexn> although !

[13:15:06 CDT(-0500)] <alexn> if you use keys 7 and 9 to read through the content. NVDA just reads a chunk of text and then waits for user input so you have to press 7 or 9 multiple times through the content to listen

[13:15:09 CDT(-0500)] <anastasiac> alexn, NVDA is not reading out a label attached to a link that has link text, it's only reading the link text

[13:16:19 CDT(-0500)] <alexn> anastasiac: let me double check

[13:16:42 CDT(-0500)] <cindyli> anastasiac: with Jaws menu: settings center -> web/html/pdfs -> links -> "speak" section -> select the option "longest of above"

[13:17:04 CDT(-0500)] <alexn> anastasiac: NVDA reads it perfectly fine on the production website

[13:17:11 CDT(-0500)] <alexn> I'm using default settings

[13:17:15 CDT(-0500)] <alexn> and IE8

[13:17:15 CDT(-0500)] <anastasiac> alexn, what does it read?

[13:17:16 CDT(-0500)] <cindyli> btw, "settings center" inside menu "utility"

[13:17:27 CDT(-0500)] <jhung> justin_o: glad to hear it! So likely it'll appear as a pair of radio buttons near the top (near the reset link).

[13:18:02 CDT(-0500)] <anastasiac> cindyli, I choose "settings centre" and nothing happens!

[13:18:08 CDT(-0500)] <alexn> anastasiac: http://www.oercommons.org/ when I keyboard focus on No Strings Attached - it reads out No Strings Attached and then the content of the popup

[13:18:30 CDT(-0500)] <anastasiac> ok, alexn, I'll look at that for a model for the mockup

[13:20:12 CDT(-0500)] <Justin_o> jhung: i'm not sure how the rest of your ui looks.. would it be better to include that close to the actual units

[13:20:24 CDT(-0500)] <Justin_o> i'm assuming it's for entering units

[13:20:27 CDT(-0500)] <Justin_o> or is there emore to it

[13:20:34 CDT(-0500)] <Justin_o> jhung: ^

[13:24:54 CDT(-0500)] <michelled> alexn: I took a look at your 575 branch - looks good to me

[13:25:04 CDT(-0500)] <michelled> alexn: please issue a pull request against staging

[13:26:03 CDT(-0500)] <alexn> michelled: ok. some JS optimization there with fluid.each

[13:27:09 CDT(-0500)] <michelled> sorry, am I missing something alexn - is there some code duplication I didn't notice?

[13:29:44 CDT(-0500)] <alexn> well yeah. Andrey had like 4 copy pastes

[13:29:49 CDT(-0500)] <alexn> I made them all into 1 loop

[13:29:51 CDT(-0500)] <alexn>

[13:30:07 CDT(-0500)] <alexn> https://github.com/anvk/OER-Commons/commit/726207b9f9eadbdba96aaebdd3faf28aecce8c4c

[13:30:20 CDT(-0500)] <alexn> my branch has only 1 commit really

[13:30:25 CDT(-0500)] <alexn> so it is easier to see my changes here

[13:30:27 CDT(-0500)] <michelled> am I looking at the wrong branch alexn? https://github.com/anvk/OER-Commons/compare/ISKME:staging...OER-575

[13:31:10 CDT(-0500)] <alexn> oh sorry I asked you to review 2 pull requests for 545 and 575

[13:31:16 CDT(-0500)] <alexn> sorry - I thought you are talking about 545

[13:31:18 CDT(-0500)] <alexn>

[13:31:23 CDT(-0500)] <michelled> ah

[13:32:09 CDT(-0500)] <michelled> alexn: I'm still confused - according to our chart 545 is already on production

[13:32:17 CDT(-0500)] <anastasiac> cindyli, reinstalling Jaws worked - thanks!

[13:32:19 CDT(-0500)] <michelled> alexn: is there another branch that needs to go in?

[13:32:39 CDT(-0500)] <alexn> well my change is a part of that 545 major ticket about improving alt text

[13:32:44 CDT(-0500)] <alexn> should I create a separate ticket

[13:33:30 CDT(-0500)] <michelled> yes, you should create another ticket - that one was big enough to begin with

[13:33:36 CDT(-0500)] <alexn> ok my bad - I should open a separate ticket. For some reason I saw the issue in the list of things there hmm

[13:33:54 CDT(-0500)] <alexn> ok then please ignore my 545 branch for now

[13:36:02 CDT(-0500)] <michelled> anastasiac: you have 2 563 branches - which one should I look at for the login drop down fix?

[13:36:45 CDT(-0500)] <anastasiac> sorry michelled: look at 563-account-settings-menu

[13:36:55 CDT(-0500)] <michelled> thx anastasiac

[13:42:37 CDT(-0500)] <alexn> michelled: https://github.com/anvk/OER-Commons/tree/OER-595 is the branch now. not sure how to change the comment though.

[13:50:04 CDT(-0500)] <michelled> anastasiac: there's a conflict when I merge that branch in - could you take a quick look please?

[13:54:05 CDT(-0500)] <michelled> anastasiac: your 563-account-settings-menu branch looks good - I think you should issue your pull request for staging.

[13:54:17 CDT(-0500)] <anastasiac> k, thanks michelled

[13:55:10 CDT(-0500)] <anastasiac> michelled, my fix for the Add OER bookmarked is ready for review: https://github.com/acheetham/OER-Commons/tree/592-add-oer-button

[14:20:25 CDT(-0500)] <alexn> michelled: I submitted a pull request for OER-596 which should add MyInfusion on production website

[14:20:32 CDT(-0500)] <alexn> hopefully it will be merged soon

[14:23:40 CDT(-0500)] <michelled> thx alexn - good find!

[14:48:30 CDT(-0500)] <michelled> anastasiac: did you mean to add an id to the anchor in 592?

[14:48:59 CDT(-0500)] <anastasiac> ah, good catch, michelled. That's leftover from when I was testing the label solution. No longer necessary, without the label

[14:53:35 CDT(-0500)] <michelled> anastasiac: cool - once you remove it from your branch I think you should do a pull request to staging

[14:54:08 CDT(-0500)] <anastasiac> k, I'll do that now, michelled

[15:21:12 CDT(-0500)] <Justin_o> jhung: interesting thing happened.. was just trying to get port forwarding working in my vagrant vm for ubuntu 12.04 and avtar ended up finding a bug in our server code, pretty easy to fix, but could cause a bunch of problems for users trying to configure the server

[15:22:12 CDT(-0500)] <jhung> justin_o: great. Thanks avtar for catching that.

[15:22:48 CDT(-0500)] <avtar> glad i could have helped

[15:25:02 CDT(-0500)] <Justin_o> jhung: here's the jira http://issues.fluidproject.org/browse/DECA-285

[15:26:59 CDT(-0500)] <Justin_o> jhung: i've added it to our planning page too

[15:41:43 CDT(-0500)] <anastasiac> michelled, I have a branch for 598 (on of greg's findings) ready for review: https://github.com/acheetham/OER-Commons/tree/598-folder-delete-add-buttons

[15:42:46 CDT(-0500)] <michelled> thx

[15:45:19 CDT(-0500)] <michelled> anastasiac: I've looked at your branch for 584 and I think it looks good

[15:45:25 CDT(-0500)] <michelled> I think you should do a pull request to staging

[15:45:31 CDT(-0500)] <anastasiac> thanks, michelled, will do

[15:54:21 CDT(-0500)] <michelled> anastasiac: I think alex already started on 598 - can you check in with him tomorrow? I'm also thinking that we are better to use an image of an 'x' along with a title that says 'delete this folder'.

[15:55:11 CDT(-0500)] <anastasiac> ok, I'll check with alex tomorrow. I didn't know he was looking at that

[15:55:39 CDT(-0500)] <michelled> looks to me like cindyli might also have started on this

[15:56:03 CDT(-0500)] <anastasiac> how can youtell?

[15:56:07 CDT(-0500)] <michelled> actually no - I read her assembla issue wrong