fluid-work IRC Logs-2011-06-27

[08:37:52 CDT(-0500)] <jhung> jameswy: do you have time this morning to go over Decapod design?
[08:39:05 CDT(-0500)] <jameswy> jhung: Sure--later, say, 10:30ish? Need to catch up on some other things, including michelled's CSpace email (I haven't forgotten about it, michelled!)
[08:39:15 CDT(-0500)] <jhung> k
[08:40:07 CDT(-0500)] <michelled> thx jameswy
[09:12:35 CDT(-0500)] <cindyli> michelled: Justin_o, mlam, i've gone thru ui options bug parade list, the bugs either cannot be reproduced or Justin_o and mlam are working on. Anything you guys want me to work on? if not, i will start trying with antifying uiOptions.js
[09:14:54 CDT(-0500)] <michelled> cindyli: if they can't be reproduced can you check in with the person who opened them and then close them if they really are gone?
[09:15:04 CDT(-0500)] <Bosmon2> cindyli, harriswong, Justin_o - I am looking at trying to test Justin_o TOC issues
[09:15:21 CDT(-0500)] <Bosmon2> The original branch was Justin_o's FLUID-4209 branch, but it seems to have had quite a complex fate since then
[09:15:31 CDT(-0500)] <michelled> cindyli: after that I think it would be good to look through the other bug parade issues and see if you can tackle any of them
[09:15:45 CDT(-0500)] <michelled> we should leaving antifying for 1.5
[09:16:02 CDT(-0500)] <Bosmon2> Firstly it was branched by Harris who made a lot of commits, and then it seems to have been forked in two, and then taken over by cindyli as her FLUID-3742
[09:16:09 CDT(-0500)] <cindyli> ic, michelled
[09:16:27 CDT(-0500)] <Bosmon2> So, should I just test Justin_o's things from that most recent lineage?
[09:16:28 CDT(-0500)] <Justin_o> cindyli: did you make any changes to it?
[09:16:37 CDT(-0500)] <cindyli> Bosmon2: the two forked by me is to make use of the new toc
[09:17:04 CDT(-0500)] <Bosmon2> cindyli - do Justin_o's tests still fail in that lineage?
[09:17:30 CDT(-0500)] <cindyli> i think yes, Bosmon2
[09:19:18 CDT(-0500)] <heidi_> mlam tried to recreate http://issues.fluidproject.org/browse/FLUID-4060 but the demo on build will only let me add 3 files
[09:19:59 CDT(-0500)] <cindyli> Bosmon2: harriswong's branch has the latest toc component, am i right, harriswong?
[09:20:06 CDT(-0500)] <mlam> cindyli: ^^, is the default max number of files set to 3 for the uploader demo?
[09:20:25 CDT(-0500)] <cindyli> mlam: the new image gallery demo?
[09:20:33 CDT(-0500)] <mlam> cindyli: yes
[09:20:36 CDT(-0500)] <cindyli> i think it's unlimited
[09:20:39 CDT(-0500)] <cindyli> by default
[09:20:46 CDT(-0500)] <cindyli> double checking
[09:20:47 CDT(-0500)] <heidi_> mlam i can still click 'add more' tho even tho it's greyed out... bug?
[09:21:06 CDT(-0500)] <heidi_> cindyli i used http://build.fluidproject.org/infusion/demos/uploader/html/uploader.html
[09:21:47 CDT(-0500)] <mlam> heidi_: yah, then it's still a bug. We'll have to re-open FLUID-3999. It's the same issue as before then where we couldn't replicate locally, but it only happens on a server
[09:22:04 CDT(-0500)] <harriswong> yes, cindyli . The last commit was on show/hide unit test
[09:24:05 CDT(-0500)] <Bosmon2> harriswong - which commit was that?
[09:24:06 CDT(-0500)] <cindyli> mlam: confirmed the default is 3 in the new image gallery demo
[09:24:17 CDT(-0500)] <harriswong> Bosmon2: 2097a119e02180dc8996b36a577b9355458a693a
[09:24:31 CDT(-0500)] <mlam> ok, thanks cindyli! heidi_ ^^, the default limit is 3 on the demo
[09:24:42 CDT(-0500)] <Bosmon2> cindyli, harriswong - as far as I see from the graph, cindyli took on all of the most recent lineage of TOC at 50696bfa932f07b067abefb2d476d28e7d3cdc8a ....
[09:26:00 CDT(-0500)] <Bosmon2> ok, I see more stuff now
[09:26:02 CDT(-0500)] <Bosmon2> How confusing this is (tongue)
[09:26:13 CDT(-0500)] <cindyli> Bosmon2: i merged in the latest changes afterwards, into my forks
[09:26:53 CDT(-0500)] <Justin_o> Bosmon2: yes.. this is a bit confusing.. cindyli did you make any changes to the ToC?
[09:27:10 CDT(-0500)] <Bosmon2> I think we are exceeding the capabilities of the network graph to show enough of the history now (sad)
[09:27:17 CDT(-0500)] <Bosmon2> Unless I focus directly on harriswong, I don't see his branch at all
[09:27:39 CDT(-0500)] <cindyli> Justin_o, Bosmon2, no, i didn't make any change to toc component itself.
[09:28:10 CDT(-0500)] <Bosmon2> So, it looks like harriswong has 3 further commits on his FLUID-4209 since it was merged by cindyli into her lineage
[09:28:25 CDT(-0500)] <Bosmon2> No, wait, even those are merged too
[09:28:33 CDT(-0500)] <cindyli> Bosmon2: really? that's not good. checking..
[09:28:49 CDT(-0500)] <Bosmon2> So, I will continue to work with cindy's FLUID-3742
[09:29:06 CDT(-0500)] <Bosmon2> But I just wanted to check that the unit tests Justin_o wants me to look are are still failing there
[09:31:51 CDT(-0500)] <cindyli> Bosmon2: harriswong's last commit is 2097a119e02180dc8996. both of my forks have it merged. what 3 further commits did u refer to?
[09:32:48 CDT(-0500)] <Bosmon2> cindyli - I made a mistake, everything seems to be merged
[09:32:53 CDT(-0500)] <cindyli> Bosmon2: i have 2 forked branches 3742, 4295 that are branched off harriswong's 4209. but both of them change ui options scripts only without touching toc itself
[09:33:00 CDT(-0500)] <cindyli> great, Bosmon2
[09:33:59 CDT(-0500)] <cindyli> Bosmon2: 4209 is the original branch for toc component. would it make more sense that you work on harriswong's 4209 and i merge into my forks afterwards?
[09:34:29 CDT(-0500)] <Bosmon2> cindyli - it's probably best not to proliferate the number of "live historical branches"
[09:34:35 CDT(-0500)] <Bosmon2> The situation is confusing enough already
[09:34:46 CDT(-0500)] <cindyli> Bosmon2: ic
[09:34:47 CDT(-0500)] <Bosmon2> If your branch subsumes all of the historical ones, we should just work with that one
[09:35:01 CDT(-0500)] <cindyli> understand
[09:35:27 CDT(-0500)] <Bosmon2> Assuming that the test I mean to look at it still failing
[09:35:34 CDT(-0500)] <Bosmon2> I assume it is just part of the tests for the TOC component?
[09:36:10 CDT(-0500)] <cindyli> Bosmon2: i think so, harriswong is the better person to answer this question. (smile)
[09:37:42 CDT(-0500)] <harriswong> Bosmon2, cindyli: I think the test that failed is related to the issue Justin_o mentioned a while ago; that there is an extra 'Humans' above the 'CATT'
[09:37:42 CDT(-0500)] <cindyli> Bosmon2: i still think it would be very confusing if u work on my 3742, how can i merge the future new toc changes from 3742 into my another toc-forked-branch 4295
[09:38:22 CDT(-0500)] <Bosmon2> cindyli - I doubt there will be changes to toc directly, but most likely a fix to the core framework... anyway, we can cross that bridge when we come to it (tongue)
[09:38:36 CDT(-0500)] <cindyli> ok. thanks, Bosmon2
[09:42:41 CDT(-0500)] <cindyli> Justin_o: http://issues.fluidproject.org/browse/FLUID-2856 seems no longer re-producable. as u r the original jira creator, can u confirm?
[09:43:00 CDT(-0500)] <heidi_> mlam cindyli i can't add more then 3 files locally either (except i can in IE)
[09:43:10 CDT(-0500)] <heidi_> how do i make it so that i can add more than 3 in FF
[09:43:25 CDT(-0500)] <Bosmon2> MAKE IT SO!
[09:43:46 CDT(-0500)] <heidi_> mlam the 'add more' still working happens locally as well, after greyed out
[09:44:47 CDT(-0500)] <Justin_o> Bosmon2 === Jean-Luc Picard
[09:45:17 CDT(-0500)] <Bosmon2> cindyli, harriswong, Justin_o: I find quite a number of TOC tests failing
[09:45:18 CDT(-0500)] <mlam> Ok, thanks heidi_, I'll reopen FLUID-3999. heidi_ have u tried using the uploader with the new image gallery?
[09:45:54 CDT(-0500)] <Bosmon2> Tests 11 and 18 have quite a number of failing cases
[09:46:28 CDT(-0500)] <harriswong> Bosmon2: Yes, i think they are the related to the same issue that Justin_o mentioned.
[09:46:36 CDT(-0500)] <mlam> cindyli: what happened to the options for changing the file upload limit in the new image gallery demo?
[09:46:41 CDT(-0500)] <heidi_> mlam it's not FLUID-3999 tho
[09:46:41 CDT(-0500)] <cindyli> heidi_: interesting, the issue of 3 maxium files only happens @ http://build.fluidproject.org/infusion/demos/uploader/html/uploader.html, my local uploader demo works well
[09:46:42 CDT(-0500)] <Bosmon2> For me, test 11 fails on 1, and all of 4 onwards
[09:47:00 CDT(-0500)] <Bosmon2> Test 18 fails on 1, 20, 21, 22 and 23
[09:47:00 CDT(-0500)] <heidi_> cindyli the max 3 happens locally for me on FF in win/mac but not IE
[09:47:02 CDT(-0500)] <Justin_o> cindyli: I thought this might be fixed now, looks good
[09:47:17 CDT(-0500)] <Bosmon2> Justin_o - these test failures don't sound like the ones you mentioned
[09:47:22 CDT(-0500)] <heidi_> mlam this is when the uploader is greyed out, after reaching the max 3, it still opens the file dialog
[09:47:41 CDT(-0500)] <cindyli> heidi_: do you mean http://build.fluidproject.org/infusion/demos/uploader/html/uploader.html or new image gallery demo?
[09:48:48 CDT(-0500)] <cindyli> mlam: changing any settings in the new image gallery demo would re-instantiate uploader with the new settings
[09:49:09 CDT(-0500)] <mlam> heidi_: FLUID-3999 is the "Add more" button issue, right?
[09:49:11 CDT(-0500)] <harriswong> Bosmon2: I am guessing #11 is testing against heading that skips, ie, H1, H6, then it creates heading h1,h2,h3,h4,h5,h6, right Justin_o? For #18, it is a test with the component markup, #20~23 indicated an extra level is introduced which is similar to Justin_o's problem in the #11-Skipped heading test.
[09:50:59 CDT(-0500)] <heidi_> mlam yeah but when uploading
[09:51:17 CDT(-0500)] <harriswong> Bosmon2: to demonstrate #18 visually, you may want to look at src/webapp/standalone-demos/table-of-contents/html/TableOfContents.html. The last headings are "Humans", "Humans", "CATT", where it should be "Humans", "", "CATT".
[09:51:19 CDT(-0500)] <heidi_> cindyli the max 3 happens locally for src/webapp/demos/uploader/html/uploader.html
[09:51:41 CDT(-0500)] <Justin_o> harriswong, Bosmon2: yes.. was just looking at the test again.. and that's right... these are all failing becaue of the extra ToC items being added in
[09:52:07 CDT(-0500)] <Bosmon2> harriswong - as long as we are confident that #18 demonstrates the same issue as in the manual case, I will deal with it as #18
[09:52:14 CDT(-0500)] <cindyli> heidi_: um.. i cannot produce with my local src/webapp/demos/uploader/html/uploader.html, but it does happen with http://build.fluidproject.org/infusion/demos/uploader/html/uploader.html. all in ff
[09:52:25 CDT(-0500)] <Justin_o> Bosmon2: you can see the first test in both of them are failing because the number of links created is incorrect
[09:52:52 CDT(-0500)] <heidi_> cindyli it happens for me locally both mac/win FF, most recent copy of master
[09:52:56 CDT(-0500)] <Bosmon2> Justin_o - do both 11 and 18 represent essentially the same failure then?
[09:53:53 CDT(-0500)] <jameswy> jhung: Still want to chat Decapod this morning?
[09:54:04 CDT(-0500)] <Justin_o> Bosmon2: yes. i believe so.. I think one of them is a tests against the subcomponent.. while the latter one is more of an integration test, but they both hit the same issue
[09:54:30 CDT(-0500)] <cindyli> heidi_: u r absolutely right. i didn't get the most recent infusion
[09:54:42 CDT(-0500)] <Bosmon2> ok, thanks Justin_o - I will start looking at them now
[09:54:49 CDT(-0500)] <Justin_o> Bosmon2: great, thanks
[09:55:10 CDT(-0500)] <jhung> jameswy: sure
[09:55:14 CDT(-0500)] <heidi_> mlam should i create a new jira for the greyed out add more button still working after reaching max # files?
[09:55:24 CDT(-0500)] <heidi_> cindyli ah, phew
[09:55:29 CDT(-0500)] <jhung> jameswy: actually. let'
[09:55:46 CDT(-0500)] <jhung> s wait until after today's meeting. I think we may have some new stuff to consider after hearing from Tom.
[09:56:07 CDT(-0500)] <Justin_o> jhung: are you going to be calling us for the Decapod meeting?
[09:56:25 CDT(-0500)] <jhung> justin_o, yes I'll start the call.
[09:56:38 CDT(-0500)] <jameswy> jhung: Alright. Did we hear back from the Germany folks about the change in time for this week?
[09:56:38 CDT(-0500)] <Justin_o> jhung: great, thanks
[09:56:49 CDT(-0500)] <mlam> heidi_: I dont' think so. I think it's still related to FLUID-3999 about the Add More button not being properly disabled. The JIRA description is very similar. We can just add another note to it
[09:56:59 CDT(-0500)] <Bosmon2> Justin_o - in the meantime, do you think you could push FLUID-4301 for me, so that athena7 is not angry with us when she wakes up? (tongue)
[09:57:10 CDT(-0500)] <heidi_> mlam okay i'll do that
[09:57:20 CDT(-0500)] <mlam> Thanks heidi_
[09:57:22 CDT(-0500)] <Justin_o> Bosmon2: i'll take a look, we wouldn't want to make our users angry
[09:57:23 CDT(-0500)] <cindyli> mlam: heidi_, in src/webapp/components/uploader/js/Uploader.js, line 484, "fileUploadLimit: 3," that's probably the cause
[09:57:37 CDT(-0500)] <jhung> jameswy: yes. They were the ones who made the request, so I assume the time is good for them. (smile)
[09:57:39 CDT(-0500)] <Bosmon2> Justin_o - certainly, they might start shelling us (smile)
[09:57:45 CDT(-0500)] <heidi_> cindyli is this the default we're sticking with? might be too low
[09:57:56 CDT(-0500)] <jameswy> jhung: Ahh.
[09:58:19 CDT(-0500)] <harriswong> Bosmon2: I dug into it a bit and thought maybe it has something to do with left over 'cache' from maybe a recursion, since the extra heading is always its parent. Though Justin_o said that it's probably more complicated than that in the framework.
[09:58:28 CDT(-0500)] <cindyli> heidi_: i think it should be unlimited by default. mlam knows better tho
[09:58:50 CDT(-0500)] <heidi_> agreed
[09:59:18 CDT(-0500)] <mlam> heidi_: cindyli: yes, it's supposed to be unlimited by default. but maybe for the purposes of the demo, a limited as added
[09:59:23 CDT(-0500)] <mlam> *was
[09:59:48 CDT(-0500)] <heidi_> mlam that limit should be in the demo's options tho, not Uploader.js
[10:00:35 CDT(-0500)] <cindyli> mlam: but if you look a few lines down below, line 488, "demo: false", demo is turned off with fileUploadLimit 3
[10:00:47 CDT(-0500)] <Justin_o> michelled: would you be able to look at Bosmon2's pull-request for FLUID-4301
[10:01:01 CDT(-0500)] <michelled> yep, I'll look at it soon
[10:01:32 CDT(-0500)] <Justin_o> michelled: thanks... it will need to be added to the bug parade as well... so if you think it's good to go in, I'll add it on
[10:01:47 CDT(-0500)] <michelled> ok
[10:02:10 CDT(-0500)] <mlam> cindyli: heidi_: Yah, something's fishy there. We'll confirm with colinclark when he's in. Maybe it was a value that was left in mistakenly while testing the component
[10:02:26 CDT(-0500)] <cindyli> thanks, mlam
[10:02:31 CDT(-0500)] <heidi_> mlam i closed http://issues.fluidproject.org/browse/FLUID-4060 with cannot reproduce fyi
[10:02:50 CDT(-0500)] <mlam> cool, thanks heidi_ (smile)
[10:02:52 CDT(-0500)] <jhung> jameswy: I have opened a pull request for uploader styling. See https://github.com/fluid-project/infusion/pull/87
[10:05:17 CDT(-0500)] <jameswy> jhung: Great!
[10:05:22 CDT(-0500)] <jameswy> Am I doing the review?
[10:05:46 CDT(-0500)] <jhung> jameswy: visually I suppose.
[10:06:00 CDT(-0500)] <jhung> heidi: can you do the review of pull #87?
[10:06:23 CDT(-0500)] <heidi_> jhung sure ya
[10:06:32 CDT(-0500)] <jhung> coolness. Thanks!
[10:07:06 CDT(-0500)] <jhung> heidi: probably needs a quick test in some other browsers (i.e. I couldn't test safari)
[10:07:42 CDT(-0500)] <heidi_> jhung okay
[10:12:29 CDT(-0500)] <jhung> jameswy: I can help with some of the IDI stuff today. Maybe one of the services or the user registration/login/password?
[10:15:50 CDT(-0500)] <jameswy> jhung: Sure thing--let's coordinate after the Decapod meeting.
[10:17:40 CDT(-0500)] <jhung> jameswy: k
[10:19:12 CDT(-0500)] <mlam> colinclark: the default value for the fileUploadLimit of the uploader should be 0 (infinite), right?
[10:19:30 CDT(-0500)] <colinclark> Seems like a reasonable default, yes
[10:19:51 CDT(-0500)] <mlam> Ok, somehow a value of 3 snuck in there
[10:19:56 CDT(-0500)] <colinclark> ?!?
[10:20:02 CDT(-0500)] <colinclark> Do you know when/how?
[10:20:45 CDT(-0500)] <mlam> No, not sure at all. My guess is that it got in there while testing the component and it was never changed back before committing
[10:24:01 CDT(-0500)] <colinclark> yeah, that's my guess too
[10:30:35 CDT(-0500)] <jhung> colinclark, jameswy, kraemer: I'll be calling you on Skype for the meeting now...
[10:30:43 CDT(-0500)] <colinclark> ok
[10:31:05 CDT(-0500)] <jhung> ^justin_o too
[10:31:12 CDT(-0500)] <colinclark> jhung: Justin_o's with me
[10:38:29 CDT(-0500)] <heidi_> akkkk. a'ight next time i'll just keep going (smile) today i'm looking at UIO in IE7, FSS theme file clean p, and reviewing jhung's pull req
[10:58:11 CDT(-0500)] <michelled> anastasiac: are you waiting for review for and push for 4218 and 4287?
[10:58:40 CDT(-0500)] <anastasiac> michelled, I think heidi_ has reviewed and signed off; waiting for a push
[10:58:56 CDT(-0500)] <michelled> heidi_: is that right for both JIRAs?
[10:58:57 CDT(-0500)] <heidi_> yep looks good to me
[11:00:25 CDT(-0500)] <Bosmon2> Hi there athena
[11:00:31 CDT(-0500)] <athena> hey there
[11:00:38 CDT(-0500)] <athena> just saw a JIRA resolve come through
[11:00:39 CDT(-0500)] <Bosmon2> I made a fix for your issue from Friday which should be being pushed any moment now...
[11:00:44 CDT(-0500)] <athena> (big grin)
[11:00:46 CDT(-0500)] <athena> much appreciated
[11:13:43 CDT(-0500)] <anastasiac> Bosmon2, I have question about using demands, etc. to override default behaviour in a component.
[11:14:02 CDT(-0500)] <anastasiac> I'm putting together an example of customizing UIOptions by removing one of the three default controls blocks
[11:14:51 CDT(-0500)] <anastasiac> but UIOptions's own refreshControlsView() function calls the refreshView() function of each of the controls subcomponents - including the one I've replaced with an emptySubcomponent
[11:15:28 CDT(-0500)] <anastasiac> I'm guessing I could use the uiOptions final init function to override its refreshControlsView() with my own, which doesn't call the absent function. Does this seem reasonable, or would you recommend a different solution?
[11:16:36 CDT(-0500)] <Bosmon2> anastasiac - I would tend to wait on an issue like this until we can refactor UIOptions properly
[11:17:18 CDT(-0500)] <anastasiac> ok, so at this point, don't suggest to users this particular type of customization, Bosmon2?
[11:17:42 CDT(-0500)] <Bosmon2> anastasiac - at this point, I'm not sure we would suggest to users ANY type of customization for UIOptions (smile)
[11:17:54 CDT(-0500)] <Bosmon2> Above and beyond the simple things you can do with values from the current options structure
[11:18:18 CDT(-0500)] <anastasiac> gotcha. For now, we tell implementors "you can't customize the controls, other than changing limits, etc"
[11:18:24 CDT(-0500)] <anastasiac> thanks
[11:18:27 CDT(-0500)] <Bosmon2> I think that is sensible
[12:05:32 CDT(-0500)] <cindyli> Justin_o: mlam noticed our new image gallery at the build site doesn't work. is it ever built correctly?
[12:06:22 CDT(-0500)] <Justin_o> cindyli: oh yes.. this.. colinclark spotted this last week.. i'll try to take a look.. the build has been failing due to something with the infusion directory
[12:07:13 CDT(-0500)] <cindyli> Justin_o: i'm playing with the pull from https://github.com/fluid-project/image-gallery
[12:07:40 CDT(-0500)] <Justin_o> cindyli: okay
[12:07:42 CDT(-0500)] <Justin_o> any luck?
[12:07:53 CDT(-0500)] <cindyli> pull to my localhost, it throws me js error because the renaming of an uploader file
[12:08:14 CDT(-0500)] <cindyli> src/webapp/components/uploader/js/ErrorView.js has been renamed to src/webapp/components/uploader/js/ErrorPanel.js
[12:09:17 CDT(-0500)] <cindyli> Justin_o: but i'm not sure if it's related to the failing buld. the problem seems different
[12:10:40 CDT(-0500)] <jhung> anastasiac: I have uploaded round buttons to http://issues.fluidproject.org/browse/FLUID-4218
[12:11:39 CDT(-0500)] <anastasiac> ah. michelled closed that one when she merged it. I wonder if we should re-open? (michelle, it's an improvement on some of the images used for the high-contrast themes
[12:11:43 CDT(-0500)] <Justin_o> cindyli: yes.. if the error is just when you are running the file, then probably different
[12:12:04 CDT(-0500)] <athena> Bosmon2: confirmed the fix on my code, thanks (big grin)
[12:13:25 CDT(-0500)] <michelled> anastasiac, jhung: sure - as long as we make sure it's clear on the JIRA what gets merged in to the repo in each pull request I think it's fine
[12:14:36 CDT(-0500)] <anastasiac> jhung, did you attach them to 4218? I don't see anything new...
[12:15:23 CDT(-0500)] <anastasiac> ah, new dates on same file - you replaced the zip files. ok. jhung, is the only thing changed the button outlines?
[12:23:57 CDT(-0500)] <cindyli> Justin_o: the unresolved ui options bugs on the bug parade seem all having ppl working on. off the top of ur head, do u have any jira, probably out of ui options, for me to work on? or, do u want me to take a look at the failing build of the image gallery? if not, i will go through the bug parade list to find one
[12:25:06 CDT(-0500)] <Justin_o> cindyli: do you have a bit of time to looking into the failing build of the image gallery. hopefully it won't take too long to address, but we'll need it for testing for sure
[12:25:49 CDT(-0500)] <cindyli> sure, Justin_o.
[12:26:05 CDT(-0500)] <Bosmon2> athena - great
[12:26:09 CDT(-0500)] <Justin_o> cindyli: thanks
[12:26:18 CDT(-0500)] <cindyli> np
[12:26:35 CDT(-0500)] <Bosmon2> It's really appreciated you being the pioneer on this bleeding-edge framework stuff
[12:26:57 CDT(-0500)] <athena> and i appreciate the help (smile)
[12:27:01 CDT(-0500)] <athena> will probably have more questions tomorrow
[12:27:05 CDT(-0500)] <colinclark> cindyli: I think you just caught my mistake
[12:27:16 CDT(-0500)] <Bosmon2> yes, do speak up quickly as soon as you run into any other problems
[12:27:21 CDT(-0500)] <athena> will do
[12:27:23 CDT(-0500)] <colinclark> I have uncommitted changes here in my copy of the Image Gallery to do the renaming from ErrorsView.js to ErrorPanel.js
[12:27:23 CDT(-0500)] <Bosmon2> I think colinclark will be pushing the fix for your other issue shortly
[12:27:32 CDT(-0500)] <cindyli> colinclark: (smile)
[12:27:33 CDT(-0500)] <Bosmon2> FLUID-4285
[12:27:40 CDT(-0500)] <colinclark> yep, it's on my todo list for today
[12:27:44 CDT(-0500)] <Bosmon2> awesome
[12:28:33 CDT(-0500)] <colinclark> jameswy: I'll be curious to hear your thoughts about this at some point http://paperjs.org/
[12:28:47 CDT(-0500)] <jhung> anstasiac: yes, only the buttons changes. Other widgets are the same
[12:29:42 CDT(-0500)] <Justin_o> huslage: would you be able to create a team account for continuum for us
[12:33:56 CDT(-0500)] <Bosmon2> colinclark - "paperjs" looks interesting/bizarre (tongue)
[12:34:31 CDT(-0500)] <colinclark> Justin_o: My mother just called me in a rage, claiming Firefox 5 ruined her computer
[12:34:40 CDT(-0500)] <colinclark> So I think that's evidence that ordinary users are getting upgraded to it
[12:34:57 CDT(-0500)] <colinclark> she said it updated for her automatically, without choosing the upgrade
[12:35:02 CDT(-0500)] <Bosmon2> The biggest problem being that although they claim to have a "document object model" I see no way to actually acquire a "document" - I just see a "document API"
[12:35:26 CDT(-0500)] <colinclark> Bosmon2: Equally in the category of interesting/bizarre, I stumbled across a WebGL scene graph library called Scene.js recently
[12:35:32 CDT(-0500)] <colinclark> which has a "JSON-based API"
[12:35:37 CDT(-0500)] <Bosmon2> that sounds more promising
[12:35:38 CDT(-0500)] <colinclark> http://scenejs.org/
[12:35:56 CDT(-0500)] <colinclark> It reminded me a bit of what I've been trying to do with Flocking
[12:36:09 CDT(-0500)] <Bosmon2> Ah yes, this looks a lot better
[12:36:33 CDT(-0500)] <colinclark> And it doesn't look any crazier than, say, a renderer "proto tree"
[12:36:34 CDT(-0500)] <colinclark> (smile)
[12:37:23 CDT(-0500)] <Bosmon2> Yes, certainly no crazier than that
[12:37:27 CDT(-0500)] <colinclark> I've been doing some Canvas programming recently
[12:37:37 CDT(-0500)] <Bosmon2> This morning I encouraged Justin_o to reduce his craziness in this department a little
[12:37:57 CDT(-0500)] <colinclark> and also getting my head around the differences between retained and immediate mode APIs
[12:38:12 CDT(-0500)] <colinclark> which has become an important aspect of the Canvas a11y debate recently
[12:38:17 CDT(-0500)] <Bosmon2> Given he already has a recursive function generating the component tree for TOC, I don't see any benefit to trying to use the protocomponent expanders, they are confusing enough even in simple cases
[12:38:32 CDT(-0500)] <Bosmon2> Yes, this entered my discussion with Alex Russell too, when I was over at Portland
[12:38:37 CDT(-0500)] <colinclark> ah, really?
[12:38:39 CDT(-0500)] <colinclark> how so
[12:38:43 CDT(-0500)] <colinclark> this stuff is really fascinating to me
[12:38:51 CDT(-0500)] <Bosmon2> Which is why he started to promote the "concrete eggcups" offered by a PDF-like document model
[12:38:55 CDT(-0500)] <colinclark> I'm really climbing a steep learning curve when it comes to these sorts of things
[12:39:13 CDT(-0500)] <Bosmon2> Well, we were talking about exactly this issue, Canvas a11y
[12:39:48 CDT(-0500)] <Bosmon2> As well as being inaccessible, the current Canvas model also has really significant performance issues, the reasons for which I only partially understand
[12:40:18 CDT(-0500)] <Bosmon2> But in our conversation, Alex considered that both of these issues could/should be resolved by giving Canvas effectively a "retained mode API" which could really be considered as a kind of "actual DOM"
[12:40:29 CDT(-0500)] <Bosmon2> As opposed to the "shadow DOM" which is currently being kicked around as an a11y model
[12:40:51 CDT(-0500)] <Bosmon2> THis would turn Canvas into a slightly terrifying technology quite similar to what we currently have as "SWT" in the Java world
[12:41:29 CDT(-0500)] <Bosmon2> A tree which freely mixes together "native" and "synthetic" UI elements, and hoping that the browser's engine can figure out how to take care of all clipping and z-order issues well enough
[12:41:37 CDT(-0500)] <colinclark> So, this does indeed connect with the near-violence on the w3c lists about Canvas accessibility
[12:41:55 CDT(-0500)] <Bosmon2> I haven't been following them - what are the current weapons of dispute? (tongue)
[12:42:08 CDT(-0500)] <colinclark> People are, perhaps rightfully, pushing back against any notion that Canvas be given anything looking like a retained mode API
[12:42:18 CDT(-0500)] <colinclark> Microsoft seems to be currently at the forefront
[12:42:38 CDT(-0500)] <colinclark> "The retained mode solution for the Web should be SVG"
[12:43:09 CDT(-0500)] <colinclark> But I guess without any sort of object model, you're going to be pretty hard-pressed to have a clue what's on the Canvas, once it's been drawn
[12:43:55 CDT(-0500)] <Bosmon2> Interesting
[12:43:59 CDT(-0500)] <Bosmon2> Microsoft likes SVG?
[12:44:56 CDT(-0500)] <colinclark> I guess they do in regards to this argument
[12:45:07 CDT(-0500)] <Bosmon2> That's pretty remarkable
[12:45:16 CDT(-0500)] <colinclark> They have SVG support in IE9
[12:45:21 CDT(-0500)] <Bosmon2> Considering what a vested interest they have in their existing stable of vector graphics formats
[12:45:32 CDT(-0500)] <colinclark> It seems Microsoft is in transition (tongue)
[12:45:46 CDT(-0500)] <Bosmon2> Alex Russell was discouraging about SVG, and I think I would agree
[12:46:00 CDT(-0500)] <Bosmon2> Especially bearing in mind our explorations last year during the early Fluid Engage era
[12:46:04 CDT(-0500)] <colinclark> I'm not sure I know enough
[12:46:09 CDT(-0500)] <colinclark> it's certainly very complex
[12:46:18 CDT(-0500)] <Bosmon2> Even "SVG Lite" covers far too much ground to constitute the basis for an effective retained-mode 2d API
[12:46:22 CDT(-0500)] <colinclark> but libraries like Raphael.js seem to show its potential
[12:46:33 CDT(-0500)] <Bosmon2> yes - unfortunately they take it in the wrong direction (tongue)
[12:46:54 CDT(-0500)] <colinclark> So, your argument is that SVG Lite just is too complex?
[12:47:03 CDT(-0500)] <colinclark> too many features for a viable alternative to Canvas?
[12:47:06 CDT(-0500)] <Bosmon2> I think so, yes
[12:47:29 CDT(-0500)] <Bosmon2> Although I'm not sure I would plump for an "uncompressed PDF model" either
[12:47:46 CDT(-0500)] <colinclark> Do you know much about the PDF model?
[12:47:50 CDT(-0500)] <colinclark> I don't at tall
[12:47:51 CDT(-0500)] <colinclark> all
[12:48:06 CDT(-0500)] <Bosmon2> SVG certainly has the benefit of already naturally accommodating itself to the DOM idiom we already have, and a lot of experience backing it up
[12:48:14 CDT(-0500)] <Bosmon2> I don't know too much about PDF, but I know a man who does (smile)
[12:48:26 CDT(-0500)] <colinclark> Who's that?
[12:48:37 CDT(-0500)] <colinclark> It's also interesting to see Mozilla's PDF.js library
[12:48:42 CDT(-0500)] <Bosmon2> My friend Felix has been writing PS and PDF interpreters for about 10 years now
[12:48:43 CDT(-0500)] <colinclark> where they are rendering PDFs into Canvases
[12:49:04 CDT(-0500)] <colinclark> and of course encountering all the basic a11y problems we encountered with PDF readers back in the '90s
[12:49:18 CDT(-0500)] <colinclark> I had thought it was just an experiment to show off the power of the Web
[12:49:19 CDT(-0500)] <Bosmon2> At least they were encountered in the 90s
[12:49:33 CDT(-0500)] <Bosmon2> I'm not sure people have started to encounter accessibility issues with SVG at all so far (smile)
[12:49:36 CDT(-0500)] <colinclark> but I guess the plan is to productionize it to the point where it's the default PDF renderer in Firefox, one of these days
[12:49:49 CDT(-0500)] <colinclark> Yeah, that was the other side of the argument
[12:50:00 CDT(-0500)] <colinclark> Sword Sweeper was pretty inspiring in an interesting way
[12:50:34 CDT(-0500)] <colinclark> and said something to the effect of "look, we're not touching SVG accessibility until we either take care of Canvas first, or remove it from the HTML5 stable altogether"
[12:50:53 CDT(-0500)] <colinclark> Let's see if I still have a link to the email clown sent along last week
[12:50:59 CDT(-0500)] <Bosmon2> Well, what a mess this is going to be
[12:51:53 CDT(-0500)] <colinclark> It's gonna take awhile
[12:52:02 CDT(-0500)] <colinclark> Canvas brings us back to the old days, in a lot of ways
[12:53:19 CDT(-0500)] <clown> colinclark, you mean this one (Rich) ? http://lists.w3.org/Archives/Public/public-canvas-api/2011AprJun/0079.html
[12:53:24 CDT(-0500)] <Bosmon2> As far as I understand it, the performance issues with Canvas are related to the fact that it is not possible to take control over the clipping region, in the way it is with similar (and ancestral) 2D APIs
[12:53:32 CDT(-0500)] <colinclark> clown: That's the one! Thanks
[12:53:38 CDT(-0500)] <colinclark> Bosmon2: Hmm
[12:53:43 CDT(-0500)] <colinclark> Can you elaborate?
[12:53:46 CDT(-0500)] <colinclark> "Take control" how?
[12:53:52 CDT(-0500)] <Bosmon2> And given that one cannot violate the JS threading model, its hard to see exactly how this could happen, given that I think most browsers actually do a lot of rendering asynchronously by now
[12:54:01 CDT(-0500)] <clown> colinclark: wlcm. fyi, there has been more activity on that list – go "up a level".
[12:54:19 CDT(-0500)] <Bosmon2> For example in the ancestral Java 2d API, it was possible to issue a user-controlled clipping region for each drawing operation
[12:54:32 CDT(-0500)] <Bosmon2> This would be ANDed together with whatever clipping region the "OS" had already issued for the operation
[12:54:49 CDT(-0500)] <Bosmon2> As a result of this it was possible to get pretty performant animation, even given how slow Java was in those days
[12:55:46 CDT(-0500)] <Bosmon2> At JSConf, there were a lot of people complaining that Canvas was vastly too underperformant to write any decent kind of game or animation on a mobile device
[12:55:59 CDT(-0500)] <Bosmon2> I didn't manage to get to the bottom of the issue with any of them, but this is my "best guess" about what the reason is
[12:56:14 CDT(-0500)] <Bosmon2> (separate from any particular issues right now in implementation quality of Canvas runtimes)
[12:57:54 CDT(-0500)] <clown> colinclark: just to finish that thought: Rich is pretty succint in the message he sent today: http://lists.w3.org/Archives/Public/public-canvas-api/2011AprJun/0083.html
[12:58:08 CDT(-0500)] * clown retires to do other work, but continues to lurk.
[13:20:22 CDT(-0500)] <heidi_> taking a look at yr uploader styles now jhung
[13:20:23 CDT(-0500)] <heidi_> fyi
[13:20:33 CDT(-0500)] <jhung> heidi_: cool
[13:27:48 CDT(-0500)] <colinclark> hey huslage
[13:27:52 CDT(-0500)] <colinclark> Justin_o was pinging you earlier in the channel
[13:29:15 CDT(-0500)] <huslage> oh i missed it
[13:29:19 CDT(-0500)] <huslage> i had my music up
[13:29:30 CDT(-0500)] <huslage> Justin_o: i'll see if i can do it
[13:29:40 CDT(-0500)] <Bosmon2> Induced Inaccessibility (smile)
[13:29:45 CDT(-0500)] <huslage> sad
[13:29:48 CDT(-0500)] <colinclark> Justin_o: I don't know if this will be interesting or useful to us some day regarding automated acceptance testing http://www.theautomatedtester.co.uk/blog/2011/selenium-advanced-user-interactions.html
[13:30:32 CDT(-0500)] <Justin_o> huslage: thanks
[13:32:56 CDT(-0500)] <Justin_o> colinclark: that does look promissing
[13:38:39 CDT(-0500)] <huslage> Justin_o: i just msgd you
[13:39:32 CDT(-0500)] <Justin_o> huslage: thanks.. sorry i missed it
[13:47:18 CDT(-0500)] <heidi_> jameswy did you go over jhung's pull req for appearances?
[13:47:51 CDT(-0500)] <jameswy> heidi_: No, not yet. Does it have the thumbs up for code?
[13:48:22 CDT(-0500)] <heidi_> jameswy best to make sure it looks right first! but i'm comparing to the mock up and it's good so i'll just keep going
[13:48:52 CDT(-0500)] <jameswy> heidi_: Will take a look at it likely tomorrow morning.
[13:49:52 CDT(-0500)] <heidi_> jhung did you style the "server-detected errors" mockup (bottom of mock up page) ? is it possible for me to recreate this
[13:50:34 CDT(-0500)] <jhung> heidi_: I only did Client errors. Colinclark, do we have server side errors?
[13:51:20 CDT(-0500)] <colinclark> The error panel only covers queue errors
[13:51:35 CDT(-0500)] <colinclark> server-side errors are in that set of wireframes, but haven't been implemented yet
[13:51:46 CDT(-0500)] <heidi_> k
[13:55:25 CDT(-0500)] <huslage> colinclark: https://github.com/dsimard/ready.js
[13:55:40 CDT(-0500)] <colinclark> hmm, interesting
[14:03:10 CDT(-0500)] <huslage> Justin_o: can i stop continuum for a few minutes?
[14:03:42 CDT(-0500)] <huslage> fluid-everyone anyone have issues with me stopping continuum?
[14:03:50 CDT(-0500)] <Justin_o> huslage: i'm okay with that
[14:04:01 CDT(-0500)] <anastasiac> no problem here
[14:04:07 CDT(-0500)] <huslage> ok
[14:04:09 CDT(-0500)] <huslage> good 'nuff
[14:06:58 CDT(-0500)] <colinclark> Justin_o: Quick question...
[14:07:09 CDT(-0500)] <colinclark> I have the fix for the bug cindyli pointed out with the IG
[14:07:18 CDT(-0500)] <colinclark> Should I get it reviewed, or just push it?
[14:07:20 CDT(-0500)] <colinclark> IG is funny...
[14:07:31 CDT(-0500)] <colinclark> it's not part of the Infusion repo, but it's pretty central...
[14:07:46 CDT(-0500)] <colinclark> in that if it doesn't work, Uploader can't easily be QA'd
[14:10:29 CDT(-0500)] <Justin_o> colinclark: hmm..
[14:10:39 CDT(-0500)] <Justin_o> that's one of those grey areas then, but i think you can probably just push
[14:12:21 CDT(-0500)] <colinclark> it's one line (smile)
[14:12:28 CDT(-0500)] <colinclark> thanks for the permission, king
[14:12:52 CDT(-0500)] <Justin_o> colinclark: no problem, thanks for the fix
[14:13:35 CDT(-0500)] <colinclark> cindyli, Justin_o: Okay, it's in
[14:13:46 CDT(-0500)] <cindyli> thanks, colinclark
[14:13:50 CDT(-0500)] <Justin_o> colinclark: thanks
[14:14:12 CDT(-0500)] <colinclark> Bosmon2: I'm reviewing FLUID-4285 while I wait for you to reappear
[14:30:01 CDT(-0500)] <cindyli> huslage: in the past half an hour, i got 503 http error code when accessing http://build.fluidproject.org/continuum/
[14:30:09 CDT(-0500)] <cindyli> error detail: Service Temporarily Unavailable The server is temporarily unable to service your request due to maintenance downtime or capacity problems. Please try again later.
[14:30:45 CDT(-0500)] <cindyli> huslage: do u have an idea what's going on with the server? thanks.
[14:36:56 CDT(-0500)] <cindyli> huslage: no worries, the site is back. thanks.
[14:37:56 CDT(-0500)] <heidi_> jhung there's a strange border over-lap between the last file and the top of the status bar
[14:38:26 CDT(-0500)] <heidi_> jameswy's mockups aren't using that blue border anymore either
[14:39:05 CDT(-0500)] <jhung> heidi_ overlap: okay. How do you reproduce it? Does it happen all the time?
[14:39:24 CDT(-0500)] <heidi_> mlam when a max # files is set, the status should say the maximum right? (http://wiki.fluidproject.org/display/fluid/Uploader+Wireframes+%28Error+Handling%29 top img says "4 files maximum")
[14:39:36 CDT(-0500)] <heidi_> jhung all the time, FF on mac
[14:39:59 CDT(-0500)] <jhung> k. let me see.
[14:40:36 CDT(-0500)] <cindyli> Justin_o: the hourly build for image gallery is fixed. now fixing its demo @ build site: http://build.fluidproject.org/image-gallery/image-gallery.php
[14:40:37 CDT(-0500)] <heidi_> jhung sorry - it'd prob be easier and less annoying if i just made a list in the pull req. i can do that instead
[14:40:45 CDT(-0500)] <mlam> heidi_: we don't have that implemented, probably something we missed from the screenshots
[14:40:53 CDT(-0500)] <jhung> heidi: lol Sure. Save you time too. (smile)
[14:41:02 CDT(-0500)] <heidi_> jhung k (smile)
[14:41:08 CDT(-0500)] <heidi_> mlam should i make a jira for it?
[14:41:25 CDT(-0500)] <jhung> heidi: thanks!
[14:41:26 CDT(-0500)] <Justin_o> cindyli: great thanks
[14:41:27 CDT(-0500)] <cindyli> Justin_o: but i didn't find where it sits on the server, do u know about it?
[14:41:35 CDT(-0500)] <Justin_o> cindyli: maybe i'll come over
[14:41:38 CDT(-0500)] <Justin_o> one second
[14:41:42 CDT(-0500)] <cindyli> sure. thanks
[14:41:52 CDT(-0500)] <mlam> heidi_: sure, it's good to have it documented, thanks
[14:42:08 CDT(-0500)] <heidi_> mlam should i set to 1.4 or no
[14:42:35 CDT(-0500)] <mlam> heidi_: that i'm not sure of, my guess is no, but maybe Justin_o can let us know
[14:43:26 CDT(-0500)] <heidi_> mlam k. max # files seems like important-ish info
[14:48:57 CDT(-0500)] <jameswy> jhung: I've uploaded the vector files for the IDI mockups: http://wiki.fluidproject.org/display/fluid/IDI+website+mockups
[14:49:06 CDT(-0500)] <jhung> jameswy: thanks!
[14:49:20 CDT(-0500)] <jameswy> Have fun (smile)
[14:50:04 CDT(-0500)] <huslage> hi sorry
[14:51:08 CDT(-0500)] <colinclark> Bosmon2: https://github.com/colinbdclark/infusion/tree/FLUID-4285
[14:51:25 CDT(-0500)] <colinclark> The FileQueueView tests fail with your improved diagnostics
[14:51:34 CDT(-0500)] <Bosmon2> That's great, colinclark - I'll check it out
[14:51:43 CDT(-0500)] <Bosmon2> Just the kind of thing I was hoping a code review would expose (smile)
[14:51:44 CDT(-0500)] <colinclark> the question is why is the file Queue View or one of its subcomponents is getting this registeredFrom property
[14:51:49 CDT(-0500)] <Bosmon2> Although on the face of it the failure appears impossible
[14:53:48 CDT(-0500)] <heidi_> mlam fyi http://issues.fluidproject.org/browse/FLUID-4308
[14:53:59 CDT(-0500)] <mlam> coolio,thanks heidi_!
[14:55:30 CDT(-0500)] <colinclark> heidi_, mlam: jameswy can make a call on FLUID-4308's blockerishness
[14:56:23 CDT(-0500)] <mlam> jameswy: what are your thoughts on FLUID-4308?
[14:57:50 CDT(-0500)] <jameswy> heidi_, mlam: It's not a blocker as long as the rest of the errors are working alright (e.g., 'can't add, reached maximum'), but mark it as critical. How long would it take to fix?
[14:58:55 CDT(-0500)] <mlam> jameswy: definitely not long at all, but I'm not sure when I'll have the time to work on it
[14:59:00 CDT(-0500)] <heidi_> jameswy yep that warning does come up, but it feels like a surprise (tongue)
[14:59:28 CDT(-0500)] <jameswy> heidi_: Agreed.
[15:00:25 CDT(-0500)] <jameswy> If we have time for it, let's get it fixed.
[15:03:43 CDT(-0500)] <michelled> jameswy: I think this can now be closed - do you agree? http://issues.fluidproject.org/browse/FLUID-3947
[15:04:33 CDT(-0500)] <jameswy> michelled: Haha, yes. It's obsolete.
[15:04:40 CDT(-0500)] <michelled> (smile)
[15:04:51 CDT(-0500)] <heidi_> jhung didn't add numbering to file queue?
[15:05:16 CDT(-0500)] <jhung> That's not a styling issue.
[15:05:46 CDT(-0500)] <jhung> heidi, that's something the uploader doesn't do currently I think.
[15:06:12 CDT(-0500)] <heidi_> jhung ah right, it's a table not a list. mlam going to number files?
[15:11:22 CDT(-0500)] <jhung> anastasiac: do you have time to chat tomorrow morning to chat documentation platforms?
[15:12:03 CDT(-0500)] <mlam> heidi_: I'll see if I have time. If I do, then I'll number the files
[15:12:19 CDT(-0500)] <anastasiac> jhung, sure. I have a conf call from 9 to 10, but I'm open after that
[15:12:47 CDT(-0500)] <jhung> anastasiac: excellent. I'll ping you.
[15:13:57 CDT(-0500)] <jhung> jameswy: I found an interesting thesis about colour scheme selection for geographical maps. You might want to check this out and browse it when you have time.
[15:13:57 CDT(-0500)] <jhung> http://www.personal.psu.edu/cab38/ColorBrewer/Steve_Gardner_thesis_PSU.pdf
[15:15:02 CDT(-0500)] <jhung> Page 60 is where they discuss "sequential schemes" which may inspire how we use colours for the IDI website contrast themes.
[15:19:22 CDT(-0500)] <anastasiac> Justin_o, regarding FSS cahnges for 1.4: Here's a brief list: http://wiki.fluidproject.org/display/fluid/FSS+Changes+in+Infusion+1.4 The rest of the docs are still to be updated with the specific info for these changes, but it should give a sense...
[15:20:00 CDT(-0500)] <Justin_o> anastasiac: thanks
[15:27:25 CDT(-0500)] <colinclark> Bosmon2: I noticed UIEnhancer's tests are failing for a similar reason
[15:27:41 CDT(-0500)] <colinclark> Although in this case, it's complaining about the presence of container
[15:27:53 CDT(-0500)] <Bosmon2> oh dear
[15:44:09 CDT(-0500)] <heidi_> mlam if you add 3 files, and the max is set to 3, and you upload them.... should you be able to add 3 more? is it max upload forever or max upload at a time?
[15:45:05 CDT(-0500)] <mlam> heidi_: it's the max upload forever until u refresh the page
[15:47:43 CDT(-0500)] <heidi_> k
[15:51:44 CDT(-0500)] <heidi_> mlam the warning for one extra files says "1 were not added to the queue."
[15:52:35 CDT(-0500)] <mlam> are you sure that's not proper grammar? (smile)
[15:52:43 CDT(-0500)] <colinclark> lol
[15:52:46 CDT(-0500)] <mlam> I didn't see that one either. I'll add that to my list as well. THanks heidi_!
[15:52:57 CDT(-0500)] <heidi_> hehe
[15:53:12 CDT(-0500)] <heidi_> it kinda gives the uploader a hick personality... i sorta like it
[15:53:20 CDT(-0500)] <mlam> hahaha
[15:53:23 CDT(-0500)] <colinclark> ha!
[15:54:05 CDT(-0500)] <heidi_> jameswy i did a style/appearance review of jhung's pull request so you can prob wait till the next round
[15:54:51 CDT(-0500)] <heidi_> mlam another tiny one: bold the word 'not' in "The following files were not added:"
[15:55:50 CDT(-0500)] <mlam> ok
[15:56:06 CDT(-0500)] <heidi_> jameswy you can see my list as a comment on https://github.com/fluid-project/infusion/pull/87
[15:56:46 CDT(-0500)] <jameswy> heidi_: Many thanks! That lightens my load, (smile)
[15:56:53 CDT(-0500)] <heidi_> cool (wink)
[16:07:32 CDT(-0500)] <Justin_o> Bosmon2: i'm having trouble trying to convert the prototree used in the ToC to the old expanded style
[16:07:47 CDT(-0500)] <Justin_o> Bosmon2: would you like me to push up my changes so that you can see the issue
[16:08:33 CDT(-0500)] <Justin_o> Bosmon2: it currently is only supposed to work for the first level of the ToC.. haven't worked in the recursion yet
[16:10:01 CDT(-0500)] <Bosmon2> Ok - you mentioned that the "noexpand" options is not working for you?
[16:10:09 CDT(-0500)] <Bosmon2> I think this option hasn't been documented yet
[16:10:39 CDT(-0500)] <Justin_o> Bosmon2: yes.. i tried using that.. not sure if i'm using it wrong
[16:11:29 CDT(-0500)] <Justin_o> Bosmon2: https://github.com/jobara/infusion/blob/FLUID-4209/src/webapp/components/tableOfContents/js/TableOfContents.js#L275-323
[16:11:33 CDT(-0500)] <Justin_o> that's what i have so far
[16:11:45 CDT(-0500)] <Justin_o> still getting that "illegal cond -> cond transition" error
[16:12:04 CDT(-0500)] <Justin_o> it's been a while since i've used the older style of component tree, so i could just be missing something
[16:13:00 CDT(-0500)] <Bosmon2> Justin_o - that message only comes from the expander
[16:13:07 CDT(-0500)] <Bosmon2> So it implies you haven't managed to defeat it yet
[16:15:08 CDT(-0500)] <Justin_o> Bosmon2: I think so yes.. any suggestion on how to (smile)
[16:15:26 CDT(-0500)] <Bosmon2> Keep trying to make the "noexpand" option work (smile)
[16:16:31 CDT(-0500)] <Justin_o> Bosmon2: lol okay
[16:16:51 CDT(-0500)] <Bosmon2> "I can't see any reason why it shouldn't work"
[16:17:27 CDT(-0500)] <Justin_o> Bosmon2: okay.. hmm.. i'll have to try to convince it of that (smile)
[16:18:00 CDT(-0500)] <Bosmon2> Do feel free to trace through line 90 of RendererUtilities.js to increase your convincing effect (tongue)
[16:18:23 CDT(-0500)] <Justin_o> Bosmon2: okay. will do
[16:36:53 CDT(-0500)] <Justin_o> Bosmon2: okay i think i may have found it
[16:37:48 CDT(-0500)] <Justin_o> so in REnderUtilities.js on line 190.. it passes in the rendererFnOptions to the createRendererSubComponent functions
[16:38:10 CDT(-0500)] <Bosmon2> Oh I see - so you mean it is not a top-level option?
[16:38:12 CDT(-0500)] <Bosmon2> I guess that makes sense
[16:38:19 CDT(-0500)] <Justin_o> rendererRnOptions is created on line 154
[16:38:21 CDT(-0500)] <Justin_o> of the same file
[16:38:32 CDT(-0500)] <Justin_o> but it doesn not move the noexpand option into it's options
[16:38:51 CDT(-0500)] <Justin_o> so i think you could just add something there like noexpand: that.options.noexpand
[16:38:53 CDT(-0500)] <Bosmon2> Ok - so the option needs to be supplied as rendererFnOptions.noexpand then
[16:39:02 CDT(-0500)] <Justin_o> Bosmon2: `yes
[16:39:46 CDT(-0500)] <Justin_o> i can make this change locally to see if works.. but i would guess we should really have a new jira for it, to go into the project repo
[16:41:36 CDT(-0500)] <Justin_o> so that seems to have worked.. although my selectors are wrong.. but at least there's no error anymore
[16:41:57 CDT(-0500)] <Justin_o> Bosmon2: ^
[16:41:59 CDT(-0500)] <Bosmon2> great
[16:43:56 CDT(-0500)] <Justin_o> Bosmon2: i'll create a new jira for that and add it to bug parade.. i can also make a pull request if you'd like to review it
[16:44:04 CDT(-0500)] <Bosmon2> Justin_o - what will the jira say?
[16:44:31 CDT(-0500)] <Justin_o> Bosmon2: something to the effect that the no expand option doesn't work
[16:44:55 CDT(-0500)] <Bosmon2> Well, it just works differently
[16:44:59 CDT(-0500)] <Bosmon2> I thought you said you made it work? (tongue)
[16:45:11 CDT(-0500)] <Justin_o> i had to change the RendererUtilities.js file
[16:45:16 CDT(-0500)] <Bosmon2> ??
[16:45:19 CDT(-0500)] <Justin_o> oh maybe i don't.. hold on a second
[16:45:24 CDT(-0500)] <Bosmon2> I thought writing it as rendererFnOptions.noexpand would work
[16:45:39 CDT(-0500)] <Justin_o> right.. didn't realize that i had access to that at the top level
[16:45:43 CDT(-0500)] <Justin_o> okay.. no problem
[16:45:47 CDT(-0500)] <Justin_o> no jira (sad)
[16:46:56 CDT(-0500)] <Justin_o> and yes that does work
[16:47:11 CDT(-0500)] <Justin_o> now i'll have to find some real bug to right a jira about