fluid-work IRC Logs-2011-06-17

[08:25:09 CDT(-0500)] <jessm> jhung: have a look at this: http://www.readwriteweb.com/archives/mozilla_working_on_pdfjs_will_render_pdfs_in_html5.php
[08:27:01 CDT(-0500)] <jhung> jessm: that's excellent! The less use of Adobe Acrobat Reader the better.
[08:33:59 CDT(-0500)] <jhung> jessm: also, it'll allow Decapod to preview an exported PDF within the webapp instead of going off to a 3rd party program like Evince.
[08:34:11 CDT(-0500)] <jessm> jhung: yeppers, cool, eh?
[08:35:09 CDT(-0500)] <jhung> jessm: thanks for passing that to me. I'll keep an eye on that.
[08:40:38 CDT(-0500)] <jhung> jessm: from Chris Jones' blog... "Putting all this together, we currently plan on doing a fast first-paint of pages using canvas, concurrently building an SVG document for the page in the background, and when the SVG document is ready, switching to that. Or if that doesn’t work well, we could implement text-selection (and hopefully a11y) in pdf.js itself, on top of canvas, possibly creating new web APIs along the way. Or if, say, font load
[08:41:45 CDT(-0500)] <jessm> jhung: i wonder if there is anything the Decapod team could do to "help"
[08:42:47 CDT(-0500)] <jhung> jessm: possibly. Perhaps a question for tmb since he's more familiar with generating PDFs.
[08:43:34 CDT(-0500)] <jessm> jhung: yeah, i'm going to send out a threaded message this a.m. introducing all the new peeps – I wonder if once we've got that started we should start a thread about this. and when i say 'we' i really am thinking 'you'
[08:43:35 CDT(-0500)] <jessm> (smile)
[08:43:49 CDT(-0500)] <jhung> jessm: (big grin)
[08:43:53 CDT(-0500)] <jhung> sure
[08:57:26 CDT(-0500)] <jhung> jameswy: have you see this? California Academy of Sciences - http://www.nytimes.com/slideshow/2008/09/23/arts/20080924_ACADEMY_SLIDESHOW_index.html
[08:57:59 CDT(-0500)] <jhung> I've thought about putting grass on my balcony to help insulate the room below it...
[08:59:22 CDT(-0500)] <jameswy> Nice. I really like green roofs.
[09:00:38 CDT(-0500)] <jhung> The interior space is nice. Hard to see how that all fits in that structure. I assume a lot of it is subterranean (good for cooling in hot California weather).
[09:00:58 CDT(-0500)] <jameswy> You should make a roof like this for your home: http://inhabitat.com/amazing-green-roof-art-school-in-singapore
[09:01:45 CDT(-0500)] <heidi> hey Justin_o i noticed an error yesterday on the build server for rich inline edit
[09:01:48 CDT(-0500)] <heidi> not sure if it's known
[09:02:49 CDT(-0500)] <Justin_o> heidi: what's up?
[09:03:11 CDT(-0500)] <heidi> Justin_o for tiny mce, if you highlight some text and click the link icon, 3 errors appear
[09:04:07 CDT(-0500)] <heidi> let me try it now to make sure
[09:04:35 CDT(-0500)] <heidi> Justin_o Permission denied to access property 'tinymce'
[09:04:35 CDT(-0500)] <Justin_o> heidi: okay.. does it only happen then or whenever you use link.. i think because of the cdn anything that opens a dialog will break
[09:04:38 CDT(-0500)] <heidi> and a few others
[09:04:49 CDT(-0500)] <Justin_o> if it's the dialog issue.. then it's known
[09:04:52 CDT(-0500)] <heidi> okay
[09:04:54 CDT(-0500)] <Justin_o> it's a same origin problem
[09:05:04 CDT(-0500)] <heidi> okee doke
[09:05:20 CDT(-0500)] <Justin_o> thanks
[09:33:59 CDT(-0500)] <michelled> cindyli: I just made a pull request for the uiEnhancer refactoring
[09:34:03 CDT(-0500)] <michelled> can you take a look at it?
[09:34:21 CDT(-0500)] <heidi> jhung let me know if you work on UI layouts today - i'm working through james and your lists today
[09:34:39 CDT(-0500)] <cindyli> sure, michelled
[09:40:30 CDT(-0500)] <jhung> heidi: I'm going to spend a little time with IDI this morning, and I think I'm pitching in some design work for Uploader later this aft.
[09:41:31 CDT(-0500)] <heidi> jhung okee doke
[09:42:19 CDT(-0500)] <heidi> huslage wiki down?
[09:43:56 CDT(-0500)] <jhung> jamesy: here's something to fill your whimsy quota today. (Be careful, turn down the volume first (smile). http://www.belowtheclouds.com/2008/09/25/minilogue-animals/
[10:32:01 CDT(-0500)] <jessm> fluid-everyone: OCAD connect today
[10:32:07 CDT(-0500)] <jessm> https://connect.ocad.ca/fluid-work
[10:32:14 CDT(-0500)] <jessm> the server is back up
[10:45:08 CDT(-0500)] <Justin_o_> jhung: hello.. was wondering what issue you are having with UI Options in ie6
[10:45:11 CDT(-0500)] <Justin_o_> ?
[10:47:35 CDT(-0500)] <jhung> The UIO panel doesn't render. According to IE6's non-debugger, it's referencing Line 706 Char 13 "Object doesn't support this property or method."
[10:47:40 CDT(-0500)] <jhung> ^justin_o
[10:49:17 CDT(-0500)] <jhung> justin_o: however, if I load the current build of UIO in IE6, it renders fine.
[10:52:46 CDT(-0500)] <Justin_o_> jhung: i think it's probably a stray comma... if we're lucky.. so linting should fix that
[10:52:56 CDT(-0500)] <Justin_o_> you said it's only for the fatpanel right?
[10:52:58 CDT(-0500)] <Justin_o_> jhung:
[10:53:01 CDT(-0500)] <Justin_o_> jhung: ^^
[10:53:07 CDT(-0500)] <jhung> justin_o: all panels.
[10:53:16 CDT(-0500)] <jhung> I'll lint and see
[10:54:04 CDT(-0500)] <Justin_o_> cindyli, michelled: so mlam and I have figured out the issue that we were mentioning during standup, which is that the linespacing and textsize don't update properly.
[10:55:22 CDT(-0500)] <Justin_o_> cindyli, michelled: basically it's because the fatpanel initializes in a hidden state.
[10:55:34 CDT(-0500)] <michelled> Justin_o_: what's happening when they try to update?
[10:55:37 CDT(-0500)] <Justin_o_> when you try to get the computed sizes.. they don't exist
[10:55:52 CDT(-0500)] <michelled> is it happening too early?
[10:55:55 CDT(-0500)] <cindyli> ah, make sense. Justin_o
[10:56:02 CDT(-0500)] <Justin_o_> michelled: so the problem is with capturing the initial size... once that is done, everything else works, but on init they are getting NaN values
[10:56:28 CDT(-0500)] <Justin_o_> michelled: the panel is closed before uioptions even starts to init
[10:56:31 CDT(-0500)] <michelled> sounds like a timing issue that requires the introduction of an event
[10:56:54 CDT(-0500)] <michelled> cindyli: do you have more insight into the issue?
[10:57:12 CDT(-0500)] <Justin_o_> michelled: but then you would probably get some flashing on the screen or something
[10:57:52 CDT(-0500)] <cindyli> Justin_o_: michelled, probably the fetch of these initial values should happen when the panel opens, at "show" state
[10:59:22 CDT(-0500)] <cindyli> or, maybe the instantiation of the whole ui enhancer should happen at panel open
[10:59:33 CDT(-0500)] <Justin_o_> cindyli: that's interesting
[10:59:56 CDT(-0500)] <Justin_o_> but we woudn't want it to instantiate every time the panel opens?
[11:00:08 CDT(-0500)] <Justin_o_> this is do once operation i think
[11:00:16 CDT(-0500)] <cindyli> exactly
[11:00:41 CDT(-0500)] <michelled> so it would be lazy initialization
[11:00:51 CDT(-0500)] <cindyli> the fetch of those initial values only happens at the first time as well, Justin_o_
[11:01:24 CDT(-0500)] <cindyli> so, we only need to worry about the timing of the first instatiation
[11:03:17 CDT(-0500)] <Justin_o_> cindyli: yes, but the panel will open many times
[11:03:37 CDT(-0500)] <cindyli> true. (sad)
[11:06:04 CDT(-0500)] <cindyli> Justin_o_, can we do it this way, if (panel_open && undefined(uiEnhancer)) call pageEnhancer;
[11:09:36 CDT(-0500)] <Justin_o_> cindyli: i think maybe uiEnhancer should worry about it
[11:10:09 CDT(-0500)] <Justin_o_> so if when it goes to set it, it doesn't have a default initial value.. it goes to look for it again or something like that
[11:10:40 CDT(-0500)] <Justin_o_> this may not help our particular issue though.. but i think uiEnhancer should have some mechanism for finding the intial value later
[11:10:47 CDT(-0500)] <Justin_o_> michelled: any thoughts on that ^
[11:12:52 CDT(-0500)] <michelled> Justin_o_: conveniently getLineHeight has been put into the public names space in my recent pull request
[11:13:14 CDT(-0500)] <Justin_o_> michelled: that is convenient (smile)
[11:13:35 CDT(-0500)] <michelled> it would be a small change to also put the initalFontSize function into the public namespace and then lazily init them
[11:14:21 CDT(-0500)] <michelled> and in fact I think it will be better factoring - I'd probably make a little component to handle font size and another one for line spacing
[11:14:35 CDT(-0500)] <michelled> then those would become half ants in the great ant refactoring
[11:15:59 CDT(-0500)] <michelled> Justin_o_, cindyli: should I go ahead and do that?
[11:17:17 CDT(-0500)] <cindyli> michelled: sounds good to me
[11:21:57 CDT(-0500)] <Justin_o_> michelled: sounds good to me too
[11:50:51 CDT(-0500)] <michelled> writing tests is so much easier when things are broken out into little bits (smile)
[12:17:48 CDT(-0500)] <heidi> michelled wondering about adding two things to enhancer for "make inputs larger", at jameswy's suggestion... adding the style to dropdowns, and adding a different classname to checkboxes to make it larger
[12:20:40 CDT(-0500)] <heidi> michelled perhaps i'll just make a jira for this ... Justin_o 1.4 thing?
[12:20:46 CDT(-0500)] <heidi> i feel like maybe it is. jameswy?
[12:21:07 CDT(-0500)] <jhung> hi MartinKraemer, welcome to the IRC channel.
[12:21:13 CDT(-0500)] <MartinKraemer> hi thanks
[12:21:23 CDT(-0500)] <Justin_o> heidi: i'm not sure what that's for exactly
[12:21:50 CDT(-0500)] <heidi> Justin_o when a user in UIO checks "make inputs larger" checkboxes and selects should be affected as well as text boxes
[12:23:34 CDT(-0500)] <michelled> heidi: sounds like it was a bug in our previous implementation
[12:26:48 CDT(-0500)] <heidi> michelled i'll file a jira - and assign to you...?
[12:29:24 CDT(-0500)] <michelled> heidi: do you have a class that will make checkboxes larger?
[12:29:35 CDT(-0500)] <heidi> michelled no one will have to be added
[12:29:41 CDT(-0500)] <heidi> to set width/height
[12:30:05 CDT(-0500)] <heidi> http://issues.fluidproject.org/browse/FLUID-4294
[12:30:35 CDT(-0500)] <michelled> will we need to find out the actual height and width?
[12:31:11 CDT(-0500)] <michelled> heidi: ^
[12:31:29 CDT(-0500)] <Justin_o> yes.. sure.. i'll come over there
[12:31:30 CDT(-0500)] <heidi> michelled i would just set height: 2em width: 2em
[12:32:01 CDT(-0500)] <heidi> unfortunately the checkbox resolution gets kinda crumby but it's the only option i think
[12:32:34 CDT(-0500)] <heidi> 1.5em might be better
[12:35:24 CDT(-0500)] <mlam> michelled: do you expect to have your changes to the initilizeFontSize() function pushed in today?
[12:35:30 CDT(-0500)] <heidi> michelled the make inputs larger flag doesn't seem to be stored correctly - it doesn't stick
[12:36:00 CDT(-0500)] <heidi> cindyli maybe it's a UIO thing. "make inputs larger" isn't being saved in the store?
[12:36:10 CDT(-0500)] <michelled> mlam: that depends on the code review
[12:36:15 CDT(-0500)] <mlam> ok, cool
[12:36:18 CDT(-0500)] <michelled> I can push to my repo
[12:38:28 CDT(-0500)] <cindyli> heidi: it is saved in the store
[12:38:39 CDT(-0500)] <heidi> cindyli is it being applied to your content
[12:38:49 CDT(-0500)] <heidi> even after refreshing the page
[12:39:08 CDT(-0500)] <heidi> my box for it is checked, but the classname isn't there
[12:39:21 CDT(-0500)] <michelled> mlam: I pushed the font size change but didn't test it very well yet
[12:39:39 CDT(-0500)] <michelled> it's in my 4207 branch
[12:40:20 CDT(-0500)] <cindyli> heidi: i tried with tests/manual-tests/html/SomeKindOfNews.html, looks good. the larger inputs stay with page refresh
[12:40:44 CDT(-0500)] <cindyli> heidi: what was the problem, the setting is gone once page gets refreshed?
[12:41:30 CDT(-0500)] <heidi> cindyli try http://build.fluidproject.org/infusion/demos/uiOptions/FullNoPreviewUIOptions/html/uiOptions.html
[12:42:04 CDT(-0500)] <cindyli> ic, heidi
[12:42:30 CDT(-0500)] <heidi> 1. click inputs larger + save 2. input has class name fl-text-larger 3. refresh, classname gone, but box checked
[12:42:53 CDT(-0500)] <heidi> cindyli ^
[12:43:14 CDT(-0500)] <cindyli> heidi: yes, i can produce the same, even with our project repo. looking into it
[12:43:25 CDT(-0500)] <heidi> cindyli thanks!
[12:43:31 CDT(-0500)] <cindyli> NP
[12:43:46 CDT(-0500)] <michelled> cindyli: make sure it's using the cookie store
[12:43:56 CDT(-0500)] <michelled> that would be expected behaviour with the temp store (wink)
[12:44:45 CDT(-0500)] <cindyli> ah, thanks, michelled
[12:45:06 CDT(-0500)] <cindyli> should full no preview use the cookie store? michelled
[12:45:55 CDT(-0500)] <michelled> cindyli: anything that we expect to be a demo should use the cookie store
[12:46:57 CDT(-0500)] <mlam> ok, thanks michelled. i'll take a look
[12:47:05 CDT(-0500)] <cindyli> michelled: agree, trying to figure out how temp store is given instead
[12:47:35 CDT(-0500)] <michelled> cindyli: so that was the problem?
[12:48:07 CDT(-0500)] <cindyli> michelled: not sure yet. still looking. the behavior matches tho
[12:48:47 CDT(-0500)] <michelled> if it is the problem look for an incorrect type tag - temp store should be used in tests
[12:50:09 CDT(-0500)] <cindyli> michelled: tried more, other settings stay with page refresh. so, may not be the cause of the temp store
[12:52:31 CDT(-0500)] <jhung> colinclark: how is the progress on Uploader?
[13:17:51 CDT(-0500)] <michelled> cindyli: does 'getLineHeight' return the line height in pixels?
[13:18:08 CDT(-0500)] <cindyli> in em
[13:18:25 CDT(-0500)] <michelled> thx
[13:18:38 CDT(-0500)] <cindyli> np
[13:20:48 CDT(-0500)] <michelled> cindyli: if you have a moment can you come help me with this refactoring?
[13:21:00 CDT(-0500)] <cindyli> sure
[14:07:26 CDT(-0500)] <cindyli> heidi: michelled, i found out why the "make input larger" is not applied to ui options at the page refresh. it's because the ui options interface is not rendered yet when the function to "make input larger" gets called.
[14:08:03 CDT(-0500)] <cindyli> heidi: michelled, this also explains why this setting is applied to other parts of the page, but just not ui options itself
[14:08:25 CDT(-0500)] <heidi> ah, interesting
[14:10:03 CDT(-0500)] <cindyli> heidi: michelled, this function tries to find $("input", container), which is all the "input"s inside <body>, however, the "input"s of ui options are not rendered. the same thing for styling links.
[14:10:45 CDT(-0500)] <heidi> cindyli shouldn't all enhancer stuff wait until the page is done loading?
[14:11:16 CDT(-0500)] <cindyli> well, right now, ui enhancer always gets instatiated before ui options
[14:12:23 CDT(-0500)] <cindyli> cuz ui options relies on some sub-components from ui enhancer, say, settingStore, and classnameMap, change applier, etc
[14:13:52 CDT(-0500)] <heidi> hm, interesting debacle
[14:16:56 CDT(-0500)] <heidi> jameswy feels like when you click reset in full w/o preview, it should reset + save. otherwise feels like nothing happens.
[14:18:10 CDT(-0500)] <jameswy> heidi: Hm. I see your point.
[14:18:54 CDT(-0500)] <jameswy> They might not see the rest of the sliders or checkboxes is what you mean, correct?
[14:20:44 CDT(-0500)] <heidi> jameswy hm?
[14:21:15 CDT(-0500)] <jameswy> heidi: When the user clicks "reset", the sliders and checkboxes and all the other settings should go back to their defaults. You're suggesting that the user might miss that?
[14:21:34 CDT(-0500)] <heidi> jameswy right now when you click reset nothing happens till you click save
[14:21:50 CDT(-0500)] <heidi> just seems weird to have a button that doesn't really do anything
[14:22:16 CDT(-0500)] <heidi> i feel like it should reset and auto-save when that's pressed
[14:23:36 CDT(-0500)] <jameswy> heidi: "Nothing" isn't what should be happening. If you click "Reset", all the controls should move back to their defaults.
[14:24:01 CDT(-0500)] <heidi> jameswy so it should save as well
[14:24:05 CDT(-0500)] <heidi> thought so
[14:24:07 CDT(-0500)] <colinclark> jhung Sorry for the delay in responding
[14:24:15 CDT(-0500)] <heidi> right now it behaves the same was as it does in full w/ preview
[14:24:23 CDT(-0500)] <colinclark> I need to get code review for the Uploader error messages before it will be allowed into the project repo
[14:24:32 CDT(-0500)] <colinclark> Are you by chance set up to run PHP on your machine, jhung?
[14:24:54 CDT(-0500)] <jhung> colinclark: yes, I should be.
[14:25:12 CDT(-0500)] <heidi> jameswy but you don't have the preview to validate that 'something' happened
[14:25:40 CDT(-0500)] <colinclark> jhung: Okay, great
[14:25:46 CDT(-0500)] <colinclark> So if you grab the Image Gallery repo
[14:25:50 CDT(-0500)] <colinclark> and my branch
[14:25:55 CDT(-0500)] <colinclark> put them side by side
[14:25:55 CDT(-0500)] <colinclark> you'll be all set
[14:25:59 CDT(-0500)] <jameswy> heidi: Right, except for the fact that the controls themselves have moved back to their defaults.
[14:26:05 CDT(-0500)] <colinclark> lemme dig you up some URLs
[14:26:25 CDT(-0500)] <colinclark> jhung: Image Gallery https://github.com/fluid-project/image-gallery
[14:26:26 CDT(-0500)] <jhung> colinclark: thanks!
[14:26:30 CDT(-0500)] <heidi> jameswy ah i see, yeah that's easy to miss ... obviously (tongue)
[14:26:47 CDT(-0500)] <colinclark> jhung: My Infusion branch: https://github.com/colinbdclark/infusion/tree/FLUID-3878
[14:26:53 CDT(-0500)] <colinclark> You'll need to do three things:
[14:26:56 CDT(-0500)] <colinclark> 1. Clone them both
[14:27:10 CDT(-0500)] <colinclark> 2. Put them side by side in your PHP-enabled webserver directory
[14:27:30 CDT(-0500)] <colinclark> 3. Add a script tag for the new ErrorsView.js to the Gallery's PHP page
[14:27:38 CDT(-0500)] <jameswy> I hesitate to save immediately though, as the reverse can be said about reset--if you might've pressed reset accidentally, there's no telling whether you did or not, and saving it automatically would be detrimental if you didn't think you actually clicked it. Or something like that. My brain's fried.
[14:27:56 CDT(-0500)] <colinclark> jhung: Like this: <script type="text/javascript" src="<?php echo FLUID_IG_INFUSION;?>/src/webapp/components/uploader/js/ErrorsView.js"></script>
[14:28:38 CDT(-0500)] <jameswy> heidi: I think the better solution would probably be to get to the root of the problem itself: give better feedback that something was reset
[14:28:59 CDT(-0500)] <heidi> jameswy yeah... thoughts?
[14:29:17 CDT(-0500)] <jameswy> A background highlight on the controls that've been adjusted, for instance.
[14:29:46 CDT(-0500)] <heidi> jameswy i wonder if explicit feedback like "Your controls have been reset" would help
[14:29:54 CDT(-0500)] <heidi> not sure
[14:30:08 CDT(-0500)] <jameswy> Blah, I hate having to read stuff on UIs.
[14:30:08 CDT(-0500)] <jhung> colinclark: getting a "fatal: .../FLUID-3878/info/refs not found" error when cloning FLUID-3878
[14:30:26 CDT(-0500)] <colinclark> What command did you use, jhung?
[14:30:46 CDT(-0500)] <heidi> jameswy yeah... man i totally didn't realise 'reset' moves all the controls!
[14:30:48 CDT(-0500)] <jhung> colinclark, git clone https://....
[14:30:52 CDT(-0500)] <heidi> missed that completely
[14:31:04 CDT(-0500)] <jameswy> But yes, that might make sense too. Maybe both a highlight and a status message of some sort.
[14:31:06 CDT(-0500)] <colinclark> jhung: Send me the whole command (smile)
[14:31:27 CDT(-0500)] <jhung> git clone https://github.com/colinbdclark/infusion/tree/FLUID-3878 fluid-3878
[14:31:37 CDT(-0500)] <colinclark> ah
[14:31:41 CDT(-0500)] <colinclark> Your URL is just wrong
[14:32:04 CDT(-0500)] <colinclark> you need to use the URL to the repo, not the page for Github's source view of the branch
[14:32:06 CDT(-0500)] <colinclark> here's what I used
[14:32:11 CDT(-0500)] <jhung> https://github.com/colinbdclark/infusion.git
[14:32:14 CDT(-0500)] <colinclark> yep
[14:32:18 CDT(-0500)] <jhung> then grab the branch
[14:32:26 CDT(-0500)] <colinclark> " git clone git://github.com/colinbdclark/infusion.git testy-test"
[14:32:33 CDT(-0500)] <colinclark> then "git checkout FLUID-3878
[14:32:44 CDT(-0500)] <jhung> k thanks.
[14:32:47 CDT(-0500)] <colinclark> Alternatively, if you have your favourite clone of Infusion, you can just add me as a remote.
[14:32:54 CDT(-0500)] <colinclark> but that's the more SVN-ish way
[14:33:15 CDT(-0500)] <jhung> SV-what?
[14:33:19 CDT(-0500)] <jhung> (smile)
[14:42:47 CDT(-0500)] <colinclark> (smile)
[14:51:10 CDT(-0500)] <heidi> harriswong yr working on table of contents right?
[14:51:22 CDT(-0500)] <heidi> what is it your fixing? wondering if it's the same issue i'm having
[14:51:28 CDT(-0500)] <harriswong> heidi: adding more test cases, yes.
[14:52:20 CDT(-0500)] <harriswong> heidi: I am writing more unit tests to test the component itself and the some rendering. Now in the process of renaming the subcomponent
[14:53:09 CDT(-0500)] <heidi> harriswong i get errors when i turn table of contents on, save, then turn it off
[14:53:30 CDT(-0500)] <heidi> ASSERTION FAILED: Bound data could not be discovered in any node above [object HTMLDivElement]
[14:53:33 CDT(-0500)] <harriswong> heidi: is that on the manual test or UI?
[14:53:44 CDT(-0500)] <heidi> harriswong here: http://build.fluidproject.org/infusion/demos/uiOptions/FullNoPreviewUIOptions/html/uiOptions.html
[14:54:55 CDT(-0500)] <harriswong> heidi: I clicked on "Show table of contents" and "save and apply", but it didn't give me errors.
[14:55:03 CDT(-0500)] <heidi> harriswong now uncheck it
[14:55:06 CDT(-0500)] <heidi> and you'll get one
[14:55:10 CDT(-0500)] <harriswong> ;O
[14:55:18 CDT(-0500)] <heidi> yep boom!
[14:56:02 CDT(-0500)] <harriswong> what does "Bound data could not be discovered in any node above" mean?
[14:56:50 CDT(-0500)] <heidi> i've no idea
[14:57:12 CDT(-0500)] <harriswong> heidi: let me try on my branch and see if this is fixed.
[14:57:13 CDT(-0500)] <heidi> Justin_o seems to be gone but maybe bug him monday - i think he did TOC stuff??
[14:57:25 CDT(-0500)] <heidi> harriswong broken in my branch
[14:58:08 CDT(-0500)] <harriswong> great i can't even save on mine
[14:58:26 CDT(-0500)] <harriswong> My branch is from Justin's FLUID-4209.
[14:58:36 CDT(-0500)] <heidi> can't save TOC or anything?
[14:58:46 CDT(-0500)] <heidi> once it breaks once i find it makes everything wacky
[14:59:20 CDT(-0500)] <harriswong> Nope, i click "Show table of contents", nothing happen, good. I clicked "save and apply", and my console world collapsed
[14:59:38 CDT(-0500)] <heidi> harriswong my unit tests pass so maybe something else needs to be tested (tongue)
[14:59:48 CDT(-0500)] <heidi> yikes!
[15:00:33 CDT(-0500)] <harriswong> by any chance is FullNoPreview demo using the TOC's html test file?
[15:01:10 CDT(-0500)] <harriswong> 'cause i wrapped another <div> around the <div id="main"> in the test; advised from Justin
[15:01:52 CDT(-0500)] <harriswong> but i don't think it has anything to do with this... My unit tests passed too, except for 1 which was known by Bosmon and Justin.
[15:02:49 CDT(-0500)] <harriswong> my master breaks like the build site.
[15:06:53 CDT(-0500)] <colinclark> y'know, jameswy and heidi...
[15:07:04 CDT(-0500)] <colinclark> UI Options is really looking quite beautiful at this point
[15:07:22 CDT(-0500)] <heidi> colinclark thanks and all the tweaks aren't even in yet! (wink)
[15:07:26 CDT(-0500)] <colinclark> (smile)
[15:07:44 CDT(-0500)] <colinclark> I like this vision of Infusion....
[15:07:45 CDT(-0500)] <colinclark> polished
[15:07:47 CDT(-0500)] <colinclark> slick
[15:07:47 CDT(-0500)] <heidi> harriswong i think another unit test should be added to test whatever is breaking (tongue)
[15:07:49 CDT(-0500)] <colinclark> detailed
[15:07:57 CDT(-0500)] <colinclark> but deeply inclusive and personalizable
[15:08:05 CDT(-0500)] <colinclark> extensible and modular
[15:08:11 CDT(-0500)] <colinclark> this is us (smile)
[15:08:44 CDT(-0500)] <harriswong> heidi: ok. btw, i got a 404 error for "/fluid/infusion/src/webapp/framework/fss/css/fss-theme-blackyellow.css was not found"
[15:08:56 CDT(-0500)] <jameswy> (smile) Thanks heidi and jhung for your awesome stylin' work on UIO!
[15:10:15 CDT(-0500)] <jhung> jameswy: UIO be stylin'
[15:11:39 CDT(-0500)] <cindyli> heidi: do we have a jira for the issue that "make input larger" is not applied to ui options at page refresh?
[15:11:59 CDT(-0500)] <heidi> harriswong there's a bunch of new ui stuff not in trunk yet, but none of it would affect TOC
[15:12:22 CDT(-0500)] <heidi> cindyli not yet. just this one: http://issues.fluidproject.org/browse/FLUID-4294
[15:12:35 CDT(-0500)] <cindyli> ok thx, heidi
[15:12:46 CDT(-0500)] <harriswong> heidi: i just thought maybe i should let you know since i saw a 404 flew by.
[15:12:51 CDT(-0500)] <heidi> thanks
[15:13:03 CDT(-0500)] <heidi> harriswong where did it happen
[15:13:25 CDT(-0500)] <harriswong> demos/uiOptions/FullNoPreviewUIOptions/html/uiOptions.html
[15:14:27 CDT(-0500)] <heidi> harriswong yep just not in trunk yet
[15:16:58 CDT(-0500)] <jhung> colinclark: When I intentionally create an error, error messages are not appearing in the igStyle-serverErrors container.
[15:17:13 CDT(-0500)] <colinclark> The errors you are looking for are queue errors
[15:17:19 CDT(-0500)] <colinclark> So, adding files that are too big
[15:17:29 CDT(-0500)] <colinclark> or adding more files than the queue can hold
[15:17:39 CDT(-0500)] <colinclark> That should help
[15:17:45 CDT(-0500)] <heidi> harriswong actually wrong path name - so thanks
[15:18:31 CDT(-0500)] <jhung> colinclark: ah. Cool. I got them now.
[15:18:36 CDT(-0500)] <colinclark> wicked
[15:20:07 CDT(-0500)] <heidi> harriswong do you want to fix the TOC error? might need a jira
[15:20:42 CDT(-0500)] <michelled> cindyli: I think there's another bug in the line spacing code
[15:20:51 CDT(-0500)] <michelled> I've got a failing test that I'll push to my repo
[15:20:55 CDT(-0500)] <cindyli> oh, no
[15:21:03 CDT(-0500)] <cindyli> sure
[15:21:24 CDT(-0500)] <harriswong> heidi: Sure, I am tracing it now but still not sure what's causing the problem. i might have to pass it onto Justin for some insights since he did the changes in toc.js
[15:21:45 CDT(-0500)] <heidi> harriswong k, can you make a jira
[15:21:51 CDT(-0500)] <heidi> and assign to justin hehe
[15:21:51 CDT(-0500)] <heidi> (big grin)
[15:21:56 CDT(-0500)] <harriswong> sure
[15:22:04 CDT(-0500)] <heidi> thanks
[15:30:06 CDT(-0500)] <harriswong> heidi: added it to FLUID-4295
[15:30:44 CDT(-0500)] <heidi> thanks harriswong
[15:30:52 CDT(-0500)] <harriswong> heidi: anytime!