fluid-work IRC Logs-2010-04-14

[16:49:48 EDT(-0400)] <michelled> right now we aren't sure what the impact of the bug is. We just know that in a particular test we get into a state where an error is thrown. That's why I think we need to investigate a little more
[16:50:45 EDT(-0400)] <justin_o> jessm, michelled: I'm pretty sure that this is a regression from the fix to FLUID-3590... I should have caught this a lot sooner sorry.. i'm going to check out the old code from the repository so we can see what was happening in the tests before
[16:51:14 EDT(-0400)] <michelled> I think you're right
[16:54:20 EDT(-0400)] <michelled> ok, a little more looking as now we know that the -32768 index we are getting is being set by the plugin to denote that nothing is selected
[16:54:43 EDT(-0400)] <michelled> line 372 of the plugin has a bug - it needs to check that something is selected before calling 'blur' on it
[16:59:43 EDT(-0400)] <michelled> jessm: the bug will manifest if the user of the plugin programatically puts focus on something in that is under the control of the keyboard a11y plugin. It is a valid use case since it is using the keyboard a11y API.
[17:01:00 EDT(-0400)] <michelled> we don't use the plugin in that way and I'm not sure whether any of our users do
[17:01:18 EDT(-0400)] <michelled> we have two options here that I see
[17:01:42 EDT(-0400)] <michelled> 1. we call this a blocker, fix the bug (very easy), retest keyboard a11y and ship 1.2 a day later
[17:02:07 EDT(-0400)] <michelled> 2. we open the JIRA, ship 1.2 as is, fix the bug and put the patch on the JIRA
[17:02:24 EDT(-0400)] <michelled> in option 2. we would avoid all the retesting
[17:02:33 EDT(-0400)] <michelled> justin_o: what do you think?
[17:03:00 EDT(-0400)] <justin_o> michelled: i don't think it would take very long to do the retesting
[17:04:17 EDT(-0400)] <justin_o> we would only have to retest the keyboard related stuff and only for the reorderer and inline edit components
[17:04:33 EDT(-0400)] <justin_o> so i would guess about half a day
[17:04:41 EDT(-0400)] <justin_o> if i get some help
[17:06:14 EDT(-0400)] <justin_o> meaning probably yura and i could do it in a half a day
[17:07:44 EDT(-0400)] <justin_o> jessm, michelled: I think i'd rather have it fixed and redo the testing...
[17:07:53 EDT(-0400)] <yura> justin_o: I agree, it wouldn't take more than that to retest all keyboard accessibility stuff
[17:08:01 EDT(-0400)] <yura> i m glad to help
[17:08:09 EDT(-0400)] <michelled> justin_o: it would make me a lot happier to ship with no broken tests
[17:08:24 EDT(-0400)] <michelled> jessm: sound good to you?
[17:08:57 EDT(-0400)] <jessm> michelled: yura:justin_o: sounds good to me
[17:09:02 EDT(-0400)] <jessm> thanks for all your hard work on this
[17:09:09 EDT(-0400)] <jessm> sorry for all the do-overs!
[17:09:46 EDT(-0400)] <michelled> well, we should have caught this a long time ago - it's pointing to us not having automated running our tests yet.
[17:10:32 EDT(-0400)] <michelled> but it's nice to know we do have some good tests that catch regressions
[17:26:54 EDT(-0400)] * anastasiac (~team@142.150.154.193) has left #fluid-work
[17:34:31 EDT(-0400)] * justin_o (~jmo@142.150.154.101) has left #fluid-work
[18:48:13 EDT(-0400)] * sgithens (~sgithens@adsl-76-252-0-80.dsl.ipltin.sbcglobal.net) has joined #fluid-work
[19:21:26 EDT(-0400)] * michelled (~michelled@CPE001310472ade-CM0011aefd3ca8.cpe.net.cable.rogers.com) has joined #fluid-work
[19:58:09 EDT(-0400)] * jessm_ (~Jess@c-71-232-3-151.hsd1.ma.comcast.net) has joined #fluid-work
[21:20:04 EDT(-0400)] * michelled (~michelled@CPE001310472ade-CM0011aefd3ca8.cpe.net.cable.rogers.com) has joined #fluid-work
[23:08:31 EDT(-0400)] * fj4000 (~Main@CPE0018f85ab63e-CM001692f5798c.cpe.net.cable.rogers.com) has joined #fluid-work
[03:08:57 EDT(-0400)] * 94SAAD3MT (~kasper@0x5552c030.adsl.cybercity.dk) has joined #fluid-work
[07:22:49 EDT(-0400)] * michelled (~michelled@CPE001310472ade-CM0011aefd3ca8.cpe.net.cable.rogers.com) has joined #fluid-work
[08:04:03 EDT(-0400)] * anastasiac (~team@142.150.154.193) has joined #fluid-work
[08:41:56 EDT(-0400)] * justin_o (~jmo@142.150.154.101) has joined #fluid-work
[08:42:01 EDT(-0400)] * yura1 (~yura@206-248-152-58.dsl.teksavvy.com) has joined #fluid-work
[08:51:04 EDT(-0400)] * jessm (~Jess@c-71-232-3-151.hsd1.ma.comcast.net) has joined #fluid-work
[08:58:11 EDT(-0400)] <justin_o> yura1 so you've seen colin's e-mail about FLUID-3647.
[08:59:20 EDT(-0400)] <yura1> morning justin_o, yes, thinking a bit more about it, it seems that just unit test might not be enough and we might want to consider retesting at least the reorderer keyboard state tests
[08:59:55 EDT(-0400)] <yura1> what do you think?
[09:00:18 EDT(-0400)] <justin_o> yura1: i just re-read Colin's e-mail and i think it may actually be similar to what we were planning to do anyways
[09:00:28 EDT(-0400)] <justin_o> "Would it not be sufficient to write a unit test that shows the bug without the patch and passes once the patch had been applied? And then to follow that up with a reasonably quick overview test of the Reorderer and other keyboard-a11y code?"
[09:00:34 EDT(-0400)] <justin_o> so the first part is already done
[09:01:16 EDT(-0400)] <justin_o> I had suggested that we just redo the keyboard a11y tasks and unit tests for the components affected (reorderer and inline edit).
[09:01:17 EDT(-0400)] <yura1> yes
[09:01:31 EDT(-0400)] <justin_o> that i don't think would take too long
[09:01:58 EDT(-0400)] <justin_o> I don't think we have to go through every demo
[09:02:14 EDT(-0400)] <justin_o> so we could do one of each type of reorderer and inline edit and that should be sufficient
[09:02:25 EDT(-0400)] <justin_o> what do you think
[09:02:50 EDT(-0400)] <yura1> yes, that makes sense, especially given that that case only happens in the unit test and no programmatic blurring happens in those demos
[09:04:26 EDT(-0400)] <justin_o> yep... we just want to make sure that this doesn't have any side effects
[09:05:09 EDT(-0400)] <yura1> alright
[09:06:31 EDT(-0400)] * michelled (~michelled@142.150.154.101) has joined #fluid-work
[09:10:54 EDT(-0400)] <yura1> justin_o: so should I wait for the the patch to go in, or should I apply it and start retesting?
[09:11:44 EDT(-0400)] <justin_o> yura1: i think you should wait for it to go in, in case there are any changes to it
[09:11:56 EDT(-0400)] <yura1> alright
[09:12:06 EDT(-0400)] <justin_o> michelled: would you be able to review the patch on FLUID-3647 and commit it if it is okay
[09:12:33 EDT(-0400)] <michelled> sure justin_o
[09:12:46 EDT(-0400)] <justin_o> michelled: thanks
[09:19:58 EDT(-0400)] <michelled> justin_o: it's in
[09:20:38 EDT(-0400)] <justin_o> michelled: thanks
[09:20:43 EDT(-0400)] <justin_o> i'll rebuild the nightly
[09:21:46 EDT(-0400)] <justin_o> yura1: michelled has committed the patch, i'm just rebuilding the nightly.. so in a few minutes or so you can start running tests again...
[09:22:33 EDT(-0400)] <yura1> great
[09:22:36 EDT(-0400)] <justin_o> also michelled had suggested that we mix up which example we test with in the different configurations so if you test with the demo portal version of simple text inline edit in one configuration use one of the integration-demos for the next one
[09:22:37 EDT(-0400)] <yura1> I have win xp here
[09:23:08 EDT(-0400)] <justin_o> okay... thanks... what browsers do you have
[09:25:20 EDT(-0400)] <justin_o> yura1: could you grab all of the tasks that you want to do into your task list on the release testing tasks page and then i'll reorganize the rest
[09:26:23 EDT(-0400)] <yura1> i have ie6, chrome and ff
[09:26:37 EDT(-0400)] <justin_o> yura1: which ff?
[09:26:40 EDT(-0400)] <yura1> 3.6
[09:33:38 EDT(-0400)] * michelled (~michelled@2002:8e01:91bb:b:21e:52ff:fe75:8997) has joined #fluid-work
[09:34:32 EDT(-0400)] * justin_o (~jmo@user146-17.wireless.utoronto.ca) has joined #fluid-work
[09:34:34 EDT(-0400)] <justin_o> yura1: thanks
[09:36:45 EDT(-0400)] <michelled> justin_o, yura1: I can retest the keyboard part for the two that are in my list
[09:37:00 EDT(-0400)] <michelled> inline edit dropdown and richtext in IE7 Win XP
[09:37:05 EDT(-0400)] <justin_o> michelled: thanks
[09:37:31 EDT(-0400)] * jhung (~Asus@H37.C193.cci.switchworks.net) has joined #fluid-work
[10:09:48 EDT(-0400)] * justin_o (~jmo@142.150.154.101) has joined #fluid-work
[10:10:01 EDT(-0400)] * sgithens (~sgithens@149-166-133-175.dhcp-in.iupui.edu) has joined #fluid-work
[10:10:19 EDT(-0400)] * michelled (~michelled@142.150.154.101) has joined #fluid-work
[10:11:26 EDT(-0400)] * michelled (~michelled@142.150.154.101) has joined #fluid-work
[10:16:37 EDT(-0400)] * anastasiac (~team@142.150.154.193) has joined #fluid-work
[10:17:53 EDT(-0400)] <jhung> justin_o and jameswy: you guys free this morning to chat Decapod?
[10:18:11 EDT(-0400)] <jameswy> jhung: not this morning, but maybe early afternoon
[10:18:40 EDT(-0400)] * kasper (~kasper@0x5552c030.adsl.cybercity.dk) has joined #fluid-work
[10:19:11 EDT(-0400)] <justin_o> jhung: same as jameswy
[10:20:56 EDT(-0400)] <jhung> justin_o, jameswy: roger that. Let's try for 1:30p?
[10:21:21 EDT(-0400)] <justin_o> jhung: okay... please remind
[10:21:28 EDT(-0400)] <jhung> yup. thanks!
[10:23:11 EDT(-0400)] <jameswy> jhung: yep
[10:27:07 EDT(-0400)] <michelled> justin_o: done those two
[10:27:49 EDT(-0400)] <justin_o> michelled: thanks
[12:08:13 EDT(-0400)] * elicochran (~elicochra@dhcp-169-229-212-66.LIPS.Berkeley.EDU) has joined #fluid-work
[13:10:29 EDT(-0400)] * michelled (~michelled@142.150.154.101) has joined #fluid-work
[13:42:11 EDT(-0400)] <jhung> justin_o: ping
[13:43:51 EDT(-0400)] * yura1 (~yura@206-248-152-58.dsl.teksavvy.com) has left #fluid-work
[13:45:09 EDT(-0400)] <justin_o> jhung: hello
[13:55:14 EDT(-0400)] * yura (~yura@206-248-152-58.dsl.teksavvy.com) has joined #fluid-work
[13:56:30 EDT(-0400)] * anastasiac (~team@142.150.154.193) has joined #fluid-work
[14:00:24 EDT(-0400)] <justin_o> yura2: i think you've caught bosmon's naming increment virus
[14:01:00 EDT(-0400)] <justin_o> yura2: i'm done with the testing... i'm moving on to tagging and will have a test bundles ready for testing shortly
[14:01:02 EDT(-0400)] <yura2> yes yura wasn't available so i figured ill try yura2
[14:01:17 EDT(-0400)] <yura2> justin_o: great news, how can i help ?
[14:01:45 EDT(-0400)] <justin_o> yura2: hopefully in a few minutes or so i'll have some test bundles for us to do the release package testing on.
[14:01:57 EDT(-0400)] <yura2> ok
[14:01:59 EDT(-0400)] <yura2> great
[14:03:53 EDT(-0400)] <justin_o> yura2: http://wiki.fluidproject.org/display/fluid/Release+Package+QA+Test+Plan
[14:04:00 EDT(-0400)] <justin_o> that's the release package testing task page
[14:36:29 EDT(-0400)] <justin_o> yura2: okay the release packages to test are up in jira http://issues.fluidproject.org/browse/FLUID-3637
[14:37:17 EDT(-0400)] <justin_o> The testing tasks on the page i mentioned earlier will indicate which one to use.
[14:37:33 EDT(-0400)] <justin_o> which bundle that is
[14:47:54 EDT(-0400)] * mackrauss (~Armin@CPE001b114b4426-CM001ac35c768c.cpe.net.cable.rogers.com) has joined #fluid-work
[15:00:52 EDT(-0400)] <yura2> thanks, ill start testing then
[15:01:03 EDT(-0400)] <yura2> justin_o: ^
[15:01:17 EDT(-0400)] <justin_o> yura2: thanks
[15:38:02 EDT(-0400)] * michelled_ (~michelled@142.150.154.141) has joined #fluid-work
[15:45:48 EDT(-0400)] * justin_o (~jmo@142.150.154.101) has joined #fluid-work
[16:28:19 EDT(-0400)] * justin_o (~jmo@142.150.154.101) has joined #fluid-work
[16:33:16 EDT(-0400)] * jhung (~Asus@H37.C193.cci.switchworks.net) has left #fluid-work
[16:57:05 EDT(-0400)] * yura2 (~yura@206-248-152-58.dsl.teksavvy.com) has left #fluid-work
[16:57:43 EDT(-0400)] * yura2 (~yura@206-248-152-58.dsl.teksavvy.com) has joined #fluid-work
[16:58:22 EDT(-0400)] <yura2> justin_o: I just finished my bit of release testing
[16:59:40 EDT(-0400)] <justin_o> yura2: great... thanks... i've just got one more thing to do
[16:59:46 EDT(-0400)] <justin_o> and then we're all done with the testing