[08:22:02 CDT(-0500)] <michelled> alexn1: if you are fixing an issue in the tooltip, you'll need a JIRA for that work
[08:22:19 CDT(-0500)] <michelled> it would be related to the video player JIRA issue
[08:22:42 CDT(-0500)] <alexn1> michelled: ok and then submit a pull request to Infusion against master ?
[08:22:51 CDT(-0500)] <michelled> yep
[08:22:59 CDT(-0500)] <alexn1> michelled: ok will do. thx a lot !
[08:23:04 CDT(-0500)] <michelled> np
[08:49:42 CDT(-0500)] <alexn1> michelled: I submitted my pull request https://github.com/fluid-project/infusion/pull/238 
[08:52:38 CDT(-0500)] <michelled> thanks alexn1
[09:11:00 CDT(-0500)] <michelled> alexn1: I was just looking at your pull request and I'm wondering if there's another way to do this. it feels like we know too much about the implementation details
[09:11:54 CDT(-0500)] <michelled> alexn1: did you get a chance to look at the underlying jquery UI tooltip plugin to see if there's an API to update the content dynamically?
[09:12:07 CDT(-0500)] <alexn1> michelled: way of doing without .html() right ? I tried to search for the solution but it is the only one I could find
[09:12:21 CDT(-0500)] <alexn1> michelled: I checked it but unfortunately could not find one
[09:12:32 CDT(-0500)] <alexn1> apparently it is a known problem for many people
[09:12:38 CDT(-0500)] <michelled> alexn1: did you check to see if the tooltip plugin has been updated since we last pulled it?
[09:12:55 CDT(-0500)] <alexn1> here is an example of people having the same issue http://stackoverflow.com/questions/6650853/jquery-tools-tooltip-change-title
[09:13:18 CDT(-0500)] <alexn1> I was checking on the jquery tools website but I will double check one more time
[09:13:26 CDT(-0500)] <michelled> alexn1: did you try using the bodyHandler option? http://docs.jquery.com/Plugins/Tooltip/tooltip#options
[09:14:07 CDT(-0500)] <alexn1> michelled: nope. looking into it
[09:56:06 CDT(-0500)] <alexn1> michelled: jquery ui tooltip which we are using does not have bodyHandler
[09:56:56 CDT(-0500)] <alexn1> michelled: there are other jquery tooltip plugins which have it but not the one we are using. I tried to play with content function trying different things but it does not work for me.
[09:58:32 CDT(-0500)] <michelled> alexn1: is it because we haven't updated recently?
[09:58:45 CDT(-0500)] <alexn1> it just not part of it
[09:58:53 CDT(-0500)] <alexn1> it is other jquery plugins which have this setting
[09:58:59 CDT(-0500)] <alexn1> *jquery tooltip plugins
[09:59:13 CDT(-0500)] <alexn1> but not jquery ui tools tooltip which we are using
[10:00:38 CDT(-0500)] <alexn1> this is the tooltip plugin which has this property http://bassistance.de/jquery-plugins/jquery-plugin-tooltip/
[10:01:22 CDT(-0500)] <alexn1> but not the http://wiki.jqueryui.com/w/page/12138112/Tooltip
[10:11:08 CDT(-0500)] <michelled> alexn1: ok, let's have a quick conversation with Justin_o about this on Monday
[10:12:57 CDT(-0500)] <alexn1> michelled: sounds good. I tried lots of different things with content function of the tooltip we are using but no success
[10:13:17 CDT(-0500)] <alexn1> we should definitely chat about this on monday
[10:13:23 CDT(-0500)] <michelled> we should document this somewhere so we don't forget
[10:13:33 CDT(-0500)] <michelled> I'll comment on the pull request and you can reply with your findings
[10:46:08 CDT(-0500)] <alexn1> michelled: https://github.com/anvk/OER-Commons/tree/OER-725 this is one of them. but it is a small problem. I also was looking into 733 and 734 but they are not so obvious as I expected. I want to double check few things before I submit 733 for your review since I do not like the fix too much
[10:49:34 CDT(-0500)] <michelled> ok alexn1 sounds good
[10:55:45 CDT(-0500)] <michelled> alexn1: what did you use as your base branch for 725?
[10:55:55 CDT(-0500)] <alexn1> staging
[10:56:16 CDT(-0500)] <alexn1> if you git checkout staging
[10:56:23 CDT(-0500)] <alexn1> and then diff with my branch you will see the changes
[10:56:26 CDT(-0500)] <alexn1> there are few lines
[10:59:16 CDT(-0500)] <alexn1> michelled: I have 2 more pull requests https://github.com/fluid-project/videoPlayer/pull/46 and https://github.com/fluid-project/videoPlayer/pull/45
[10:59:26 CDT(-0500)] <michelled> thx alexn1
[10:59:47 CDT(-0500)] <alexn1> cindyli1: ayt ?
[10:59:54 CDT(-0500)] <cindyli1> ya, alexn1
[11:00:47 CDT(-0500)] <alexn1> cindyli1: actually nvm let me try one thing first
[11:00:56 CDT(-0500)] <cindyli1> ok
[11:15:12 CDT(-0500)] <michelled> alexn1: did you notice with 725 that if there is a scrollbar the header does not cover the portion of the page that's offscreen?
[11:15:30 CDT(-0500)] <michelled> header image that is
[11:15:45 CDT(-0500)] <michelled> alexn1: for some reason I can't get onto Assembla, so I can't see the details of the issue
[11:17:03 CDT(-0500)] <michelled> alexn1: I guess it's an issue that's not related to UIO text size changes
[11:17:54 CDT(-0500)] <michelled> alexn1: I think you should go ahead with your pull request to Andrey for 725.
[11:18:17 CDT(-0500)] <michelled> alexn1: can you please add 725 to the floe iteration wiki page so that we can make sure it doesn't fall off our radar.
[11:41:00 CDT(-0500)] <alexn1> cindyli1: ayt b?
[11:41:14 CDT(-0500)] <cindyli1> ya, alexn1
[11:41:38 CDT(-0500)] <alexn1> have you tried to uncomment fullscreen tests and see if the error http://issues.fluidproject.org/browse/FLUID-4673 still there ?
[11:41:49 CDT(-0500)] <alexn1> because I tried and error is still there
[11:42:06 CDT(-0500)] <alexn1> I'm not sure if the error you observe related to fullscreen in any way
[11:42:47 CDT(-0500)] <cindyli1> cannot recall that long time ago. trying now
[11:46:14 CDT(-0500)] <cindyli1> alexn1: confirmed, related. The tests pass in chrome once commenting out this 2 lines: https://github.com/fluid-project/videoPlayer/blob/demo/js/VideoPlayer.js#L460-461
[11:46:37 CDT(-0500)] <alexn1> not really
[11:46:40 CDT(-0500)] <alexn1> and I will tell you why
[11:46:58 CDT(-0500)] <alexn1> if I apply this https://github.com/fluid-project/videoPlayer/pull/45
[11:47:01 CDT(-0500)] <alexn1> OR
[11:47:11 CDT(-0500)] <alexn1> simply comment out fullscreen tests
[11:47:25 CDT(-0500)] <alexn1> because if you comment out fullscreen tests this function will never be called
[11:47:38 CDT(-0500)] <alexn1> the error you are observing is still there
[11:49:34 CDT(-0500)] <cindyli1> alexn1: "the error you are observing is still there"? what i see is the error is gone in chrome if not calling this function
[11:50:04 CDT(-0500)] <alexn1> ok wait
[11:50:10 CDT(-0500)] <alexn1> here is a simpler thing for you
[11:50:22 CDT(-0500)] <alexn1> checkout demo branch and comment out those lines you sent me earlier
[11:50:32 CDT(-0500)] <alexn1> then run the test
[11:50:41 CDT(-0500)] <alexn1> INDEX_SIZE_BLAH error is still there
[11:50:55 CDT(-0500)] <alexn1> now try to comment out the fullscreen tests completely
[11:50:59 CDT(-0500)] <alexn1> the same error is still there
[11:51:18 CDT(-0500)] <alexn1> I truly believe that this error is not related to the fullscreen functionality
[11:51:56 CDT(-0500)] <cindyli1> right. in debugger console. but without commenting out those 2 lines, the test fails worse on the screen
[11:52:12 CDT(-0500)] <alexn1> I know
[11:52:19 CDT(-0500)] <alexn1> I sent a pull request to fix this
[11:52:24 CDT(-0500)] <cindyli1> cool
[11:52:29 CDT(-0500)] <alexn1> but he error you reported
[11:52:34 CDT(-0500)] <alexn1> is not related to fullscreen
[11:52:41 CDT(-0500)] <alexn1> as well as the comment you places in fullscreen tests
[11:52:44 CDT(-0500)] <cindyli1> ok, can you comment on the jira and explain?
[11:53:01 CDT(-0500)] <alexn1> haha I wanted you to do it 
[11:53:38 CDT(-0500)] <alexn1> ok I will do this 
[11:53:39 CDT(-0500)] <cindyli1> my finding is that fullscreen function is related to the test failure
[11:53:45 CDT(-0500)] <alexn1> not really
[11:54:02 CDT(-0500)] <cindyli1> but what else causing the error in debugger, I have no idea
[11:54:29 CDT(-0500)] <alexn1> oh...
[11:54:34 CDT(-0500)] <alexn1> I see what you are saying
[11:54:44 CDT(-0500)] <alexn1> well JIRA is only about this error in debugger
[11:56:00 CDT(-0500)] <alexn1> ok anyhow let me comment on the JIRA and remove the comment from the code
[11:56:17 CDT(-0500)] <cindyli1> alexn1: well, not about the error in debugger, it was actually about the more explicitly error showed up in the jqunit test suite
[11:56:38 CDT(-0500)] <alexn1> you should've mentioned in the JIRA then
[11:56:49 CDT(-0500)] <alexn1> because there is nothing about this in JIRA
[11:57:00 CDT(-0500)] <cindyli1> i didn't notice the error in debugger if you didn't mention it
[11:57:27 CDT(-0500)] <alexn1> http://issues.fluidproject.org/browse/FLUID-4673
[11:57:29 CDT(-0500)] <alexn1> you mentioned it
[11:57:51 CDT(-0500)] <alexn1> I see where is the confusion - I was working on the fullscreen tests and saw your comment
[11:58:04 CDT(-0500)] <alexn1> I went to the JIRA and start looking closely at the error
[11:58:11 CDT(-0500)] <cindyli1> ok, alexn1, i will edit and improve this jira and let you know. can you have a look afterwards?
[11:58:15 CDT(-0500)] <alexn1> but mind that was after I had a pull request to fix the test
[11:58:50 CDT(-0500)] <alexn1> for sure
[12:04:27 CDT(-0500)] <cindyli1> alexn1: done - http://issues.fluidproject.org/browse/FLUID-4673
[12:04:51 CDT(-0500)] <alexn1> awesome ! thank you cindyli1
[12:05:05 CDT(-0500)] <cindyli1> np, alexn1
[12:05:08 CDT(-0500)] <alexn1> because I will be removing that comment line from the tests in my pull request
[12:05:31 CDT(-0500)] <alexn1> and jira should have enough information to explain on what is going on
[12:05:59 CDT(-0500)] <alexn1> actually almost
[12:06:18 CDT(-0500)] <alexn1> the #1 point is been thrown always
[12:06:26 CDT(-0500)] <alexn1> even when you do not have test #8
[12:07:08 CDT(-0500)] <alexn1> let me comment on it
[12:13:54 CDT(-0500)] <alexn1> cindyli1: I put a comment http://issues.fluidproject.org/browse/FLUID-4673
[12:14:41 CDT(-0500)] <cindyli1> thanks
[12:14:46 CDT(-0500)] <alexn1> np
[12:32:51 CDT(-0500)] <alexn1> Bosmon: ayt?
[12:42:10 CDT(-0500)] <alexn1> cindyli1: I have a tiny question
[12:42:28 CDT(-0500)] <cindyli1> go ahead, alexn1
[12:42:44 CDT(-0500)] <alexn1> do we have any ie8,ie9 specific css rules for oer commons ?
[12:43:02 CDT(-0500)] <alexn1> if I want to add a css rule which applies only for ie8 for example
[12:43:11 CDT(-0500)] <cindyli1> checking
[12:45:06 CDT(-0500)] <cindyli1> yes, alexn1: https://github.com/ISKME/OER-Commons/blob/master/project/templates/include/css.html#L49-53
[12:45:50 CDT(-0500)] <alexn1> oh sweet. thanks cindyli1 !
[12:46:00 CDT(-0500)] <cindyli1> np
[13:46:33 CDT(-0500)] <michelled> alexn2: did you get my comments about 725 before lunch?
[13:46:52 CDT(-0500)] <alexn2> to send a pull request
[13:47:03 CDT(-0500)] <michelled> yeah, and add it to the iteration page
[13:47:25 CDT(-0500)] <alexn2> yes I was looking into another oer issue but too many problems with it… so I decided to do another one right now
[13:47:35 CDT(-0500)] <alexn2> I will come back to the problematic one on Monday
[13:47:52 CDT(-0500)] <alexn2> I know the fix but just cannot test it
[13:48:25 CDT(-0500)] <michelled> alexn2: yeah, I think you should set aside the per commons ones now since you've got a fix for 725. let's get all your video players pulls in order
[13:48:43 CDT(-0500)] <alexn2> oh… I thought I need to have 2
[13:48:50 CDT(-0500)] <alexn2> 2 oer common fixes
[13:49:05 CDT(-0500)] <michelled> alexn2: no, one is enough
[13:49:31 CDT(-0500)] <michelled> alexn2: I commented on your pull request for 4779
[13:49:52 CDT(-0500)] <michelled> and merged and pushed your pull request for 4661
[13:54:43 CDT(-0500)] <alexn2> ok ok this will be my second one then https://github.com/anvk/OER-Commons/compare/ISKME:staging...anvk:OER-717
[13:54:44 CDT(-0500)] <alexn2>
[13:55:01 CDT(-0500)] <alexn2> to keep the idea of submitting 2 requests
[13:57:26 CDT(-0500)] <alexn2> michelled: where should I add 725 to the iteration page ?
[13:57:35 CDT(-0500)] <michelled> just at the top
[13:57:43 CDT(-0500)] <michelled> in the chart for this week
[13:58:05 CDT(-0500)] <michelled> I wonder why I can't get into assembla - are you able to alexn2?
[13:58:55 CDT(-0500)] <alexn2> https://www.assembla.com/spaces/iskme/tickets/725-header-image-background-for-oer-commons-does-not-scale-with-text-size-increases#last_comment
[13:58:58 CDT(-0500)] <alexn2> this is 725 one
[13:59:04 CDT(-0500)] <alexn2> yup I'm there all the time
[14:01:59 CDT(-0500)] <alexn2> michelled: I forgot should I submit a pull request to staging or into master as well ?
[14:02:16 CDT(-0500)] <alexn2> Bosmon: ayt?
[14:02:20 CDT(-0500)] <michelled> staging first, then you need to test it on staging once Andrey pushes it
[14:02:35 CDT(-0500)] <michelled> then you do a request to master, and then test that once it's merged
[14:02:47 CDT(-0500)] <michelled> that's why I want it on the iteration page - so we can track its progress
[14:04:40 CDT(-0500)] <Bosmon> Hi, ALEXEY!
[14:06:48 CDT(-0500)] <michelled> alexn2: go ahead with your pull request to staging for 717
[14:06:58 CDT(-0500)] <michelled> I'm glad you fixed that
[14:07:44 CDT(-0500)] <alexn2> sorry that it is not a big issue 
the big one appeared to be much bigger than I anticipated
[14:07:56 CDT(-0500)] <alexn2> but at least we got 2 issues submitted
[14:08:04 CDT(-0500)] <michelled>
[14:15:59 CDT(-0500)] <Bosmon> Anything I can help with?
[14:23:41 CDT(-0500)] <alexn2> hey Bosmon could you help me with a tiny thing here
[14:24:14 CDT(-0500)] <Bosmon> If I can
[14:24:47 CDT(-0500)] <alexn2> https://github.com/fluid-project/videoPlayer/blob/demo/css/VideoPlayer.css#L177-178
[14:24:54 CDT(-0500)] <alexn2> do you remember what those comments mean?
[14:24:55 CDT(-0500)] <alexn2>
[14:25:16 CDT(-0500)] <alexn2> they look like a warning sign but not sure what they warn about
[14:26:39 CDT(-0500)] <Bosmon> Oh yes
[14:26:53 CDT(-0500)] <Bosmon> They warn about the fact that the width and positioning of the volume bar I found unstable across the different browsers
[14:27:05 CDT(-0500)] <Bosmon> In the end, only by a pixel or two
[14:27:14 CDT(-0500)] <Bosmon> It's the kind of thing that jameswy might obsess about
[14:27:17 CDT(-0500)] <Bosmon> But that I think I would too : P
[14:27:32 CDT(-0500)] <Bosmon> Sometimes, one finds oneself supping with the DEVIL
[14:27:55 CDT(-0500)] <jameswy> Hahaha. Oh dear...
[14:27:56 CDT(-0500)] <alexn2> thx Bosmon
[14:28:34 CDT(-0500)] <Bosmon> In the end I picked some "compromise dimensions" that didn't look too bad across all the browsers