fluid-work IRC Logs-2013-03-26

[07:46:59 CDT(-0500)] <Justin_o> yzen: i think you were saying yesterday that you found a failing test case.. is this still a problem?

[07:47:19 CDT(-0500)] <yzen> Justin_o: nope , it was all me

[08:06:49 CDT(-0500)] <Justin_o> colinclark: don't see michelle online, but do you know if we are free to start pushing our code up to the demo branch simultaneously with our other branches now

[08:07:02 CDT(-0500)] <Justin_o> so that alexn can start pulling it in for the OER commons integration

[08:07:19 CDT(-0500)] <colinclark> yup, I think that's fine

[08:07:28 CDT(-0500)] <Justin_o> colinclark: thanks

[08:14:11 CDT(-0500)] <Justin_o> yzen: is your stuff ready for me to pull in yet?

[08:14:23 CDT(-0500)] <yzen> Justin_o: yes i think so

[08:14:29 CDT(-0500)] <yzen> it's all good

[08:16:07 CDT(-0500)] <Justin_o> yzen: thanks

[08:17:35 CDT(-0500)] <Justin_o> yzen: oh no.. now my demo is broken

[08:17:43 CDT(-0500)] <yzen>

[08:17:47 CDT(-0500)] <yzen> ok ill take a look

[08:17:54 CDT(-0500)] <yzen> but i was sure the tests were all passing

[08:17:57 CDT(-0500)] <yzen> do they for you ?

[08:18:53 CDT(-0500)] <Justin_o> yzen: i'll try them out now

[08:59:02 CDT(-0500)] <Justin_o> yzen just looking at your github repo.. i don't think the media panel is coming into UIO just yet

[08:59:18 CDT(-0500)] <Justin_o> for now it was still part of video player.. although we might move it over

[08:59:46 CDT(-0500)] <yzen> Justin_o: ok, so if you were to try my branch up to the second last commit ?

[08:59:54 CDT(-0500)] <yzen> i think it might be working just fine

[09:02:50 CDT(-0500)] <Justin_o> yzen: okay.. just have to back out the merge first then i'll try that out

[09:03:11 CDT(-0500)] <yzen> Justin_o: ya just point head to that commit

[09:03:30 CDT(-0500)] <yzen> Justin_o: i should've created a separate media branch

[09:03:37 CDT(-0500)] <yzen> Justin_o: actuaLLY

[09:03:44 CDT(-0500)] <yzen> if you wait a sec ill upadte my branch ?

[09:03:45 CDT(-0500)] <yzen> ok ?

[09:04:29 CDT(-0500)] <yzen> Justin_o: do you know if we have a branch for ui media work ?

[09:04:33 CDT(-0500)] <yzen> uio*

[09:08:25 CDT(-0500)] <yzen> Justin_o: I cleaned up my branch, no media commit there anymore'

[09:08:30 CDT(-0500)] <yzen> you can try pulling

[09:09:13 CDT(-0500)] <Justin_o> yzen: sorry, was on a call with jhung

[09:09:19 CDT(-0500)] <Justin_o> yzen: i'll try your cleaned up branch now

[09:09:28 CDT(-0500)] <yzen> Justin_o: hopefully it works

[09:09:32 CDT(-0500)] <Justin_o> yzen: no branch for media yet.. that stuff is all in VP

[09:09:53 CDT(-0500)] <yzen> Justin_o: ok i ll rename it once there's a JIRA

[09:09:57 CDT(-0500)] <Justin_o> yzen: alexn has started something with upgrading infusion there, but it's not all the way done yet

[09:10:03 CDT(-0500)] <Justin_o> yzen: thanks

[09:11:21 CDT(-0500)] <alexn> Justin_o, yzen: should I wait for your changes in demo branch, yzen? Or can I carry one with my upgrading?

[09:27:49 CDT(-0500)] <Justin_o> cindyli, heidiv, jhung: I had to pull a merge out of my branch.. so i had to reset things a bit.. if you had pull recently you might have to fix things up.. on your end

[09:30:17 CDT(-0500)] <heidiv> Justin_o ok will remerge

[09:34:04 CDT(-0500)] <Justin_o> heidiv, jhung: do you have time for a quick meeting in about 5 minutes

[09:35:32 CDT(-0500)] <jhung> sure Justin_o

[09:35:43 CDT(-0500)] <heidiv> jhung could you take the reigns? i'm going to have to lie down

[09:35:55 CDT(-0500)] <heidiv> Justin_o i'll get our branch ready first, one sec

[09:38:54 CDT(-0500)] <heidiv> Justin_o jhung will get the branch ready. i'll check in later.

[09:40:31 CDT(-0500)] <Justin_o> yzen: your updated branch works

[09:40:46 CDT(-0500)] <Justin_o> yzen: are you free for a UIO meeting in a few minutes?

[09:41:08 CDT(-0500)] <yzen> dont know yet, waiting to hear from michelled

[09:46:16 CDT(-0500)] <anastasiac_> yzen: michelled is in the UIO meeting, you should join

[09:47:25 CDT(-0500)] <alexn2> colinclark: ping. Do you want to join our UIO meeting?

[09:50:22 CDT(-0500)] <colinclark> alexn2: Yes I would

[09:50:27 CDT(-0500)] <colinclark> I'm just finishing another meeting

[09:50:31 CDT(-0500)] <colinclark> I will ping when I'm done

[09:50:48 CDT(-0500)] <alexn2> colinclark: ok. when you done could you skype michelle and join the call

[09:50:55 CDT(-0500)] <colinclark> Are you guys using conversat.io?

[09:50:58 CDT(-0500)] <colinclark> ah, skype

[10:51:57 CDT(-0500)] <jessm> colinclark: michelled: re: stable branch in OER-C for staging new UIO integration √√

[10:52:11 CDT(-0500)] <colinclark> sweet checkmarks, jessm

[10:52:15 CDT(-0500)] <colinclark> thanks so much

[10:52:35 CDT(-0500)] <michelled> thanks jessm!

[11:02:38 CDT(-0500)] <jessm> colinclark: danaayotte: keep your 3-4ish open – I think we'll skype then if that works?

[11:03:03 CDT(-0500)] <jessm> colinclark: danaayotte: make that 4-5

[11:04:37 CDT(-0500)] <danaayotte> OK

[11:04:42 CDT(-0500)] <colinclark> I have a 4-5 pm meeting at the moment

[11:04:58 CDT(-0500)] <colinclark> I can skip it, but it usually has a cost when I don't show up

[11:05:02 CDT(-0500)] <colinclark> as kasper_ can attest

[11:05:11 CDT(-0500)] <colinclark> Could we do 3-4 pm instead, by chance?

[11:06:19 CDT(-0500)] <colinclark> Justin_o: Can we repurpose tomorrow's community meeting as a quick check-in session for our Floe demo preparation?

[11:06:48 CDT(-0500)] <michelled> cindyli, jhung, yzen1: I just pushed to the demo branch

[11:06:58 CDT(-0500)] <Justin_o> colinclark: sure

[11:07:01 CDT(-0500)] <michelled> you'll find the new demo in the integration-demos folder

[11:07:07 CDT(-0500)] <cindyli> cool. thanks, michelled

[11:07:12 CDT(-0500)] <jessm> colinclark: i'll ask...

[11:07:37 CDT(-0500)] <michelled> jhung: if you're ready for me to push your styling, can you do a pull request to the demo branch?

[11:08:11 CDT(-0500)] <jhung> Not yet michelled. I'm just merging Justin_o's changes now

[11:08:20 CDT(-0500)] <jhung> having some conflicts which I have to resolve first.

[11:22:15 CDT(-0500)] <Justin_o> anastasiac: are you changes for FLUID-4323 in the demo branch?

[11:22:45 CDT(-0500)] <anastasiac> Justin_o, I believe michelled pushed them

[11:25:18 CDT(-0500)] <Justin_o> anastasiac: thanks

[11:26:33 CDT(-0500)] <Justin_o> michelled, anastasiac: i've created a jira for my work http://issues.fluidproject.org/browse/FLUID-4946

[11:26:47 CDT(-0500)] <michelled> thx Justin_o

[11:28:41 CDT(-0500)] <Justin_o> jhung: which jira number are you working on for the styling changes

[11:29:35 CDT(-0500)] <jhung> FLUID-4938.

[11:29:41 CDT(-0500)] <jhung> btw. I pinged you in skype Justin_o

[11:31:24 CDT(-0500)] <Justin_o> jhung: thanks.. i'll check skype

[11:38:40 CDT(-0500)] <jessm> danaayotte: colinclark:3ish your time now

[11:38:47 CDT(-0500)] <colinclark> excellent

[11:38:59 CDT(-0500)] <colinclark> sorry if i'm making for an inconvenient lunch

[11:39:04 CDT(-0500)] <danaayotte> ok

[11:39:43 CDT(-0500)] <jessm> colinclark: you owe me a taco

[11:39:51 CDT(-0500)] <colinclark> fish tacos!

[11:41:35 CDT(-0500)] <michelled> cindyli: I made a mistake on the JIRA number

[11:41:43 CDT(-0500)] <michelled> we should be working on FLUID-4323

[11:41:47 CDT(-0500)] <cindyli> ok

[11:42:06 CDT(-0500)] <cindyli> will change it

[11:42:28 CDT(-0500)] <michelled> cindyli: don't worry about your current pull request - I'll fix that

[11:42:38 CDT(-0500)] <michelled> cindyli: just change it for the work you are currently working on

[11:43:06 CDT(-0500)] <cindyli> ok, michelled

[11:54:12 CDT(-0500)] <Justin_o> arashs: do you know if we have the designs for all of the advanced preferences that are show in these designs http://wiki.fluidproject.org/display/fluid/User+Interface+Options+design+high+fidelity%2C+C.1

[12:02:53 CDT(-0500)] <jhung> michelled: I sent a pull request for my FLUID-4938 branch.

[12:03:03 CDT(-0500)] <jhung> It includes Justin_o's changes as well.

[12:08:15 CDT(-0500)] <michelled> thx jhung - I'll look at it soon

[12:08:43 CDT(-0500)] <michelled> anastasiac, yzen, jhung, Justin_o, cindyli: I just pushed to the demo branch

[12:09:22 CDT(-0500)] <Justin_o> michelled: thanks

[12:13:26 CDT(-0500)] <jhung> Justin_o, michelled - what should I look at next? The labels attached to the contrast radio buttons look pretty awkward. I think I should fix that next?

[12:13:47 CDT(-0500)] <Justin_o> jhung: sounds good

[12:14:45 CDT(-0500)] <arashs> Justin_o: let me look into it

[12:14:52 CDT(-0500)] <Justin_o> anastasiac: where does the demo live.. which directory?

[12:15:20 CDT(-0500)] <Justin_o> arashs: i found some stuff here http://source.fluidproject.org/svn/design/floe/user-interface-options/c.1/

[12:15:48 CDT(-0500)] <Justin_o> i am looking at the uio-highfidelity-toppanel.pdf

[12:15:50 CDT(-0500)] <Justin_o> is that one okay

[12:16:46 CDT(-0500)] <arashs> I think so

[12:17:23 CDT(-0500)] <anastasiac> Justin_o, sorry, missed your Q. The demo is in the integration-demos/uiOptions folder

[12:17:31 CDT(-0500)] <Justin_o> anastasiac: thanks

[12:17:45 CDT(-0500)] <arashs> Im not sure if these are the final designs

[12:17:51 CDT(-0500)] <Justin_o> arashs: okay.. thanks.. do you know if we have any examples of what the advanced preferences for content simplification will look like

[12:18:01 CDT(-0500)] <arashs> these are the latest ones

[12:18:20 CDT(-0500)] <arashs> no

[12:18:28 CDT(-0500)] <Justin_o> arashs: okay thanks.. this is just for a demo right now.. so it will be okay if they are iterated on more later

[12:18:33 CDT(-0500)] <Justin_o> okay.. that's fine

[12:18:57 CDT(-0500)] <Justin_o> arashs: did you make font icons for jhung and heidiv to use for UIO?

[12:18:58 CDT(-0500)] <arashs> but I have designed another ideation for keyboard shortcuts

[12:19:14 CDT(-0500)] <Justin_o> arashs: okay.. no problem.. i'm not sure i'll be mocking that one up just yet

[12:19:33 CDT(-0500)] <arashs> Justin_o: yes I did

[12:19:53 CDT(-0500)] <Justin_o> arashs: thanks.. i might need some more from you.. do you have a minute to chat

[12:20:09 CDT(-0500)] <arashs> sure

[12:20:13 CDT(-0500)] <Justin_o> thanks

[12:24:31 CDT(-0500)] <jhung> michelled: does display prefs with / without preview need to be done for this demo? Currently they're not in the new style.

[12:28:49 CDT(-0500)] <Justin_o> jhung: seems like we won't be showing that off in the demo.. we will need it done for master though at some point

[12:30:01 CDT(-0500)] <jhung> ok. thanks

[12:36:54 CDT(-0500)] <michelled> jhung: I think it would be good to have nice styling on the full page UIO in the existing demo - not the new one

[12:37:05 CDT(-0500)] <michelled> jhung: but that comes after the styling work on the new demo

[12:38:18 CDT(-0500)] <anastasiac> michelled, I've issues another pull request: https://github.com/fluid-project/infusion/pull/277 CSS changes to make the demo respond to UIO better

[12:38:37 CDT(-0500)] <michelled> thx anastasiac

[12:38:46 CDT(-0500)] <jhung> thanks michelled

[12:40:17 CDT(-0500)] <anastasiac> michelled, the high-contrast version is ok except for the graphics. Should I try to create those, or is there something more important I could contribute to?

[12:40:38 CDT(-0500)] <michelled> jhung: did you mean to commit changes to the .project file?

[12:41:29 CDT(-0500)] <jhung> no michelled.

[12:41:34 CDT(-0500)] <jhung> thanks for catching that.

[12:41:55 CDT(-0500)] <jhung> unless Justin_o did modifications?

[12:42:21 CDT(-0500)] <Justin_o> jhung: nope.. i don't use .project files.. i think that's an eclipse things

[12:42:23 CDT(-0500)] <Justin_o> thing

[12:42:50 CDT(-0500)] <jhung> no changes intended then michelled

[12:43:18 CDT(-0500)] <michelled> ok, jhung - do you want to pull that from your branch or do you want me to handle it?

[12:44:10 CDT(-0500)] <jhung> I'll pull it from my branch.

[12:44:28 CDT(-0500)] <michelled> thx!

[12:55:03 CDT(-0500)] <Justin_o> jhung: just looking at your templates there are some issues that i'm noticing right away. 1) i think the layout should probably remain as layout for now or table of contents.. since for the demo we are adding in simplified content separately

[12:55:20 CDT(-0500)] <Justin_o> jhung: also the "for" attribute points at "line-spacing"

[12:55:35 CDT(-0500)] <Justin_o> jhung: https://github.com/jhung/infusion/blob/FLUID-4938/src/webapp/components/uiOptions/html/UIOptionsTemplate-layout.html

[13:01:05 CDT(-0500)] <michelled> anastasiac, Justin_o, cindyli, yzen, jhung: i just pushed into the demo branch. there are markup changes in the new demo file.

[13:03:28 CDT(-0500)] <michelled> anastasiac: I think we should remove the background on the body when in high contrast

[13:03:43 CDT(-0500)] <michelled> firebug says line 686 in main.css

[13:03:59 CDT(-0500)] <anastasiac> right michelled, gotcha. I'm working on high-contrast right now. Thanks for the pointer

[13:04:16 CDT(-0500)] <michelled> np

[13:33:54 CDT(-0500)] <michelled> Justin_o, anastasiac, cindyli, yzen: I just pushed to the demo branch again

[13:36:56 CDT(-0500)] <cindyli> michelled: you might have seen my pull request for implementing simplified content. that is done. what else can I help?

[13:37:40 CDT(-0500)] <michelled> cindyli: awesome!

[13:37:47 CDT(-0500)] <michelled> can you see if yzen or Justin_o need a pair?

[13:38:33 CDT(-0500)] <cindyli> alrite, yzen & Justin_o, let me know if anything i can help with

[13:39:10 CDT(-0500)] <yzen> i m working on some awesome stuff ,that is way better than anyone else's so you should help me

[13:39:17 CDT(-0500)] <yzen> cindyli: ^

[13:40:24 CDT(-0500)] <cindyli> :-D sounds cool, yzen, what can i help

[13:41:27 CDT(-0500)] <yzen> cindyli: im working on self voicing enactor

[13:41:35 CDT(-0500)] <yzen> we can pair up if you want

[13:41:38 CDT(-0500)] <cindyli> sure

[13:41:41 CDT(-0500)] <cindyli> let's do it

[13:41:48 CDT(-0500)] <cindyli> coming

[14:18:12 CDT(-0500)] <arashs> jhung1 Justin_o are there other icons you would want me to add the the font, other than the ones we talked about?

[14:34:15 CDT(-0500)] <Justin_o> arashs: I think that was it for me, but i guess you should check with anastasiac, michelled, cindyli, and yzen

[14:35:12 CDT(-0500)] <jhung1> arashs: I don't have anything currently. Hopefully we'll get a chance to integrate it into the demo.

[14:37:46 CDT(-0500)] <arashs> ok cool

[14:45:56 CDT(-0500)] <michelled> anastasiac, cindyli, jhung1, yzen: I just pushed to the demo branch again

[14:46:24 CDT(-0500)] <michelled> cindyli: simplify content is looking good! I think we should pull more things out though.

[14:46:29 CDT(-0500)] <michelled> the resources, features and footer

[14:46:42 CDT(-0500)] <michelled> so it becomes just the article

[14:46:47 CDT(-0500)] <michelled> maybe the markup isn't right?

[14:46:54 CDT(-0500)] <michelled> I'll take a quick look

[14:47:09 CDT(-0500)] <cindyli> ya, michelled, adjusting the markup can achieve that

[14:47:32 CDT(-0500)] <cindyli> put whatever only for article inside <article> tag, michelled

[14:59:33 CDT(-0500)] <cindyli> michelle, the failure of the unit tests in jhung1's branch is because the reset button will be moved from inner iframe to the outer. The one on the outer hasn't been implemented yet. to fix the failure, we perhaps should stop testing the reset button in the iframe. what do you think?

[15:02:16 CDT(-0500)] <anastasiac> michelled, new pull request for you: https://github.com/fluid-project/infusion/pull/279 High contrast stuff

[15:02:58 CDT(-0500)] <michelled> cindyli: what do you mean, has not been implemented?

[15:03:08 CDT(-0500)] <michelled> do we no longer have reset functionality?

[15:04:26 CDT(-0500)] <cindyli> michelled: jhung1 mentioned the reset button on the main page has not been done yet, would that be done in the next a couple of days to make its way into the demo, jhung1?

[15:05:17 CDT(-0500)] <cindyli> another option is to wait until the full design is done and write proper tests at that point.

[15:05:18 CDT(-0500)] <jhung1> Not sure if the reset button will make it into the demo. it depends on what else needs to get done.

[15:05:40 CDT(-0500)] <michelled> jhung1: I think it's a bad idea to not have reset functionality

[15:05:44 CDT(-0500)] <michelled> I use it all the time when I demo

[15:05:50 CDT(-0500)] <michelled> if you get into a weird state etc.

[15:06:03 CDT(-0500)] <michelled> it's a lot easier to just hit a button and talk through that

[15:06:20 CDT(-0500)] <michelled> jhung1: couldn't we leave reset in the inner for now?

[15:06:51 CDT(-0500)] <jhung1> Possibly michelled

[15:07:04 CDT(-0500)] <jhung1> I'll take a look at putting it back into the panel itself.

[15:08:20 CDT(-0500)] <jhung1> michelled: my only problem is where we would put it into the panel. currently it scrolls horizontally, so it's possible that the reset will be off screen to the user.

[15:09:49 CDT(-0500)] <michelled> jhung1: better that then not having the functionality

[15:10:28 CDT(-0500)] <jhung1> michelled: I think we may have to think about this some more because I just did a test and the contrast themes don't work quite right (i.e. the buttons don't properly maintain colours when changing themes).

[15:11:35 CDT(-0500)] <michelled> jhung1: are you using the fl-uio-theme classes?

[15:11:56 CDT(-0500)] <jhung1> good question! let me check...

[15:13:04 CDT(-0500)] <jhung1> ok michelled. I'll toss the rest back into the panel somewhere. I'll look into this contrast issue later.

[15:27:40 CDT(-0500)] <arashs> jhung1: I have included new icons from UIO, and updated the icon font.

[15:27:55 CDT(-0500)] <jhung1> thanks arashs

[15:28:09 CDT(-0500)] <arashs> you can find it attached under this JIRA

[15:28:09 CDT(-0500)] <arashs> http://issues.fluidproject.org/browse/FLUID-4934

[16:25:28 CDT(-0500)] <jhung1> michelled: I have fixed the failing unit tests and added the reset back in. however, the non-fast-forward flag is preventing me from pushing up this change. Thoughts?

[16:26:36 CDT(-0500)] <arashs> jhung: I think she just left

[16:27:09 CDT(-0500)] <jhung> thanks arashs.

[16:31:14 CDT(-0500)] <jhung> michelled (logging this while you are away): I used the —force flag to push my update. By doing so, this removes the bad merge I did of jobara's code to my FLUID-4938 branch, merges in your FLUID-4938 branch, and adds back in the reset link so the tests pass again.

[16:32:07 CDT(-0500)] <jhung> commit 0188d12b1d3eb46745675f94adbc036589b038fa never happened. It was all a baaad dream…. it was all a dream….

[16:48:19 CDT(-0500)] <avtar> yzen: are you around?

[17:07:47 CDT(-0500)] <yzen> avtar: looks good

[17:07:55 CDT(-0500)] <avtar> poiiifect

[17:08:11 CDT(-0500)] <yzen> avtar: ill push my branch and hopefully it will work