fluid-work IRC Logs-2012-10-16

Owned by Fluid IRC Log Bot
Last updated: Oct 16, 2012Version comment
8 min read

[08:57:35 CDT(-0500)] <avtar> fluid-everyone: does anyone know if this confluence plugin was installed for any specific reason(s)? https://marketplace.atlassian.com/plugins/org.swift.confluence.html

[08:58:16 CDT(-0500)] <colinclark> avtar: If I had to guess, it may have been for flexibility of presentation in our documentation

[08:58:24 CDT(-0500)] <colinclark> anastasiac: Do you know, by chance?

[08:58:35 CDT(-0500)] <anastasiac> no, I have no recollection of that one at all

[08:58:56 CDT(-0500)] <anastasiac> I'm having a look at the wiki to see if anything looks horrible now that it's not working

[08:59:05 CDT(-0500)] <Justin_o> avtar: http://wiki.fluidproject.org/display/fluid/Renderer+Decorators

[08:59:14 CDT(-0500)] <Justin_o> that page is throwing an error because of it

[08:59:45 CDT(-0500)] <colinclark> Perhaps it was just used for fancy tables

[08:59:56 CDT(-0500)] <colinclark> tables were, at least at one point, a real weak spot for Confluence

[09:01:24 CDT(-0500)] <Justin_o> avtar, colinclark: it looks like it was the

macro.. so anything using that is dead..

[09:01:28 CDT(-0500)] <Justin_o> here's another example

[09:01:28 CDT(-0500)] <Justin_o> http://wiki.fluidproject.org/display/fluid/Progress

[09:01:41 CDT(-0500)] <colinclark> ah, interesting

[09:01:45 CDT(-0500)] <colinclark> so we were using it quite extensively

[09:02:06 CDT(-0500)] <colinclark> it looks like your First Component is probably now broken on all the component pages, Justin_o

[09:02:12 CDT(-0500)] <Justin_o> colinclark: quite possibly.. even the side bar has a problem

[09:03:11 CDT(-0500)] <colinclark> So I guess the way I interpret this is that our friend Bob Swift decided to start charging for his plugin?

[09:04:20 CDT(-0500)] <avtar> colinclark: or that going from an older version of confluence to a newer one means we have to license it all over again?

[09:04:33 CDT(-0500)] <colinclark> yeah

[09:04:43 CDT(-0500)] <anastasiac> perhaps we can find an alternative plug-in, one that doesn't cost anything

[09:04:46 CDT(-0500)] <colinclark> I guess I'd be surprised if we paid for it

[09:05:09 CDT(-0500)] <anastasiac> just browsing: https://marketplace.atlassian.com/plugins/confluence.macros.html

[09:05:13 CDT(-0500)] <colinclark> Yeah

[09:05:15 CDT(-0500)] <colinclark> Atlassian has one

[09:05:30 CDT(-0500)] <colinclark> with the delightful warning "DO NOT ENABLE IF YOU DON"T TRUST YOUR USERS"

[09:05:40 CDT(-0500)] <anastasiac> ah, right, there's a built-in macro

[09:06:00 CDT(-0500)] <avtar> do we trust alexn1?

[09:06:47 CDT(-0500)] <colinclark> honestly, I doubt we had any access control on the other plugin

[09:07:09 CDT(-0500)] <colinclark> Ideally, we'd limit the use of the HTML macros to administrators, just to avoid the worst sorts of issues

[09:08:51 CDT(-0500)] <michelled> colinclark: a while ago you gave alexn1 some feedback on a pull request that added a new testing utility. I've been cleaning that branch up a bit and I was hoping you could take a look. I'm not sure exactly what you were hoping would be implemented there.

[09:08:57 CDT(-0500)] <michelled> https://github.com/michelled/videoPlayer/compare/fluid-project:demo...FLUID-4787

[09:09:38 CDT(-0500)] <colinclark> yep, I can take a look today

[09:09:44 CDT(-0500)] <michelled> oh, I just realized that some of my changes got reverted in that branch, so please ignore "setupTestEnvironmentFeature" for now

[09:09:44 CDT(-0500)] <colinclark> it looks like you've made some nice improvements

[09:32:56 CDT(-0500)] <alexn1> michelled: I also have two branches for a review. This is one of them https://github.com/anvk/OER-Commons/compare/ISKME:staging...anvk:OER-791 related to the issue https://www.assembla.com/spaces/iskme/tickets/791 Could you review it whenever you have a chance.

[09:33:41 CDT(-0500)] <michelled> sure alexn1 - can you put links to the branches you need reviewed on the planning wiki page?

[09:33:53 CDT(-0500)] <alexn1> michelled: will do

[09:34:57 CDT(-0500)] <jessm> thank goodness for the log… i just about pinged you all about the plugin in the wiki – soooo hours ago i see

[09:40:32 CDT(-0500)] <alexn1> michelled: I updated floe iteration plan.

[09:40:42 CDT(-0500)] <michelled> thx alexn1

[10:19:05 CDT(-0500)] <Justin_o> cindyli, jhung: there is a slight mismatch between the errors reported by capture and those the ui wireframes are expecting

[10:19:11 CDT(-0500)] <Justin_o> http://wiki.fluidproject.org/display/fluid/Proposed+Decapod+Camera+Control+Server+Architecture

[10:19:18 CDT(-0500)] <Justin_o> http://wiki.fluidproject.org/display/fluid/Decapod+0.7+Stereo+Capture+UI+Design

[10:19:23 CDT(-0500)] <Justin_o> they are at the bottom of both of those pages

[10:19:48 CDT(-0500)] <Justin_o> the issue being that the ui is expecting an error for the camera resolution, and the server has an error for not being able to take a capture

[10:19:57 CDT(-0500)] <Justin_o> any thoughts?

[10:20:38 CDT(-0500)] <cindyli> Justin_o: as I rmb, we've decided to remove all the exceptions that are specifically for stereo capture

[10:20:56 CDT(-0500)] <cindyli> checking on camera resolution was one of those, there's another one, trying to rmb

[10:21:06 CDT(-0500)] <Justin_o> cindyli: matching pairs i think

[10:21:12 CDT(-0500)] <cindyli> right

[10:22:23 CDT(-0500)] <jhung> Justin_o: answers your Q?

[10:22:52 CDT(-0500)] <jhung> justin_o: of course Minimum MP may return depending on the results we get from Dewarp to genpdf. (tongue)

[10:24:21 CDT(-0500)] <Justin_o> jhung: okay.. so i guess that answers half of my question.. what error do you want to report in the client if the server reports a NO_CAPTURE eror

[10:24:23 CDT(-0500)] <Justin_o> error

[10:26:16 CDT(-0500)] <jhung> justin_o: I think there should be a new error case for the UI. "No Capture" doesn't fit into any of the other existing errors.

[10:26:23 CDT(-0500)] <jhung> I'll update that image.

[10:45:40 CDT(-0500)] <Justin_o> jhung: thanks

[10:59:59 CDT(-0500)] <jhung> justin_o, cindyli : Deca meeting now.

[11:34:00 CDT(-0500)] <jhung> justin_o, cindyli - I pushed up my changes to my fork. Try merging. (smile)

[11:34:23 CDT(-0500)] <Justin_o> jhung: thanks

[11:39:05 CDT(-0500)] <Justin_o> jhung, cindyli: the changes seemed to merge fine. I've pushed it up to my repo

[12:26:14 CDT(-0500)] <anastasiac> michelled, I've found another regression in the video player: http://issues.fluidproject.org/browse/FLUID-4805 (sad)

[12:27:22 CDT(-0500)] <michelled> that's unfortunate anastasiac - I think that worked fairly recently

[12:27:30 CDT(-0500)] <anastasiac> yeah

[12:27:46 CDT(-0500)] <anastasiac> if so, at least it should be reasonably easy to track down, michelled

[12:27:58 CDT(-0500)] <michelled> yeah

[12:30:51 CDT(-0500)] <michelled> alexn1: I looked at your branch for OER791 - it looks good to me, I think you should go ahead with it

[12:31:14 CDT(-0500)] <jhung> justin_o: error messages updated.

[12:31:22 CDT(-0500)] <alexn1> michelled: thx. I will.

[12:31:28 CDT(-0500)] <jhung> uh hold on justin_o.

[12:31:53 CDT(-0500)] <Justin_o> jhung: okay

[12:32:13 CDT(-0500)] <jhung> fixed. Forgot to rename the file properly.

[12:32:50 CDT(-0500)] <jhung> I changed the error message for Too Many Cameras slightly too justin_o.

[12:33:07 CDT(-0500)] <Justin_o> jhung: okay.. thanks

[12:33:30 CDT(-0500)] <Justin_o> jhung: see the changes now, thanks

[12:33:48 CDT(-0500)] <Justin_o> jhung: what is the help link?

[12:36:25 CDT(-0500)] <jhung> the help link goes to the Help documentation. Same thing that would happen if you clicked on the Help link at btop.

[12:38:10 CDT(-0500)] <Justin_o> jhung: okay.. good to know… that will require some changes to my implementation, but shouldn't be a big issue

[12:38:23 CDT(-0500)] <jhung> ok

[12:44:59 CDT(-0500)] <michelled> anastasiac: did you see Kate's comments on this ticket? https://www.assembla.com/spaces/iskme/tickets/807

[12:45:17 CDT(-0500)] <anastasiac> nope, looking now

[12:46:08 CDT(-0500)] <michelled> this one too anastasiac: https://www.assembla.com/spaces/iskme/tickets/836

[12:46:42 CDT(-0500)] <anastasiac> thanks, michelled, I'll follow up on these

[12:46:48 CDT(-0500)] <michelled> np

[13:33:55 CDT(-0500)] <jessm> anastasiac: did you ever go live with the equipment checkout form for IDI?

[13:34:34 CDT(-0500)] <anastasiac> jessm, no, my understanding was that we don't have actual from back from the legal department; is that a wrong understanding?

[13:34:50 CDT(-0500)] <jessm> not sure

[13:34:59 CDT(-0500)] <jessm> why don't i even see the functionality on the dev site? http://dev.inclusivedesign.ca/booking/

[13:35:56 CDT(-0500)] <anastasiac> jessm, I took it off the dev site because I needed to test something else for migration to the production site, and I didn't want to also migrate the booking to the production site

[13:36:06 CDT(-0500)] <jessm> anastasiac: roger that

[13:36:14 CDT(-0500)] <anastasiac> I can re-instate it with help from avtar or michelled, if you'd like

[13:36:16 CDT(-0500)] <jessm> and yes, it's being vetted still

[13:36:24 CDT(-0500)] <jessm> you'll need to eventually, but not right now

[13:36:38 CDT(-0500)] <anastasiac> ok, just let me know when, jessm

[13:54:46 CDT(-0500)] <Justin_o> cindyli: i've finished the first pass at the status component for capture, i'll merge in your changes and push everything up.. but then i'll have to modify the status component to be able to render out markup as there is now a help link for one of the error messages

[13:55:30 CDT(-0500)] <cindyli> i see. thanks, Justin_o

[14:22:01 CDT(-0500)] <Justin_o> cindyli: that's all pushed up to my repo now

[14:42:19 CDT(-0500)] <michelled> alexn1: I'm making my way through your other branch

[14:42:32 CDT(-0500)] <michelled> I'm curious about line 14 and 16 in this file: https://github.com/anvk/OER-Commons/blob/634bf61ed4da39331c3d9499c4c18aa282ec8f2e/project/media/javascripts/authoring/learning-goals-widget.js

[14:43:00 CDT(-0500)] <michelled> any reason you would combine those lines?

[14:43:33 CDT(-0500)] <michelled> this.params = params || {};

[14:43:55 CDT(-0500)] <alexn1> michelled: it is generated by coffee script. Let me take a look at the coffee file

[14:45:06 CDT(-0500)] <alexn1> michelled: it is a product of this coffee lines https://github.com/anvk/OER-Commons/blob/634bf61ed4da39331c3d9499c4c18aa282ec8f2e/project/media/javascripts/authoring/learning-goals-widget.coffee#L6-7

[14:45:11 CDT(-0500)] <alexn1> *these

[14:45:28 CDT(-0500)] <michelled> alexn1: is there a way in coffee script to set a default value for a parameter?

[14:46:17 CDT(-0500)] <alexn1> michelled: I'm not sure, let me double check on that

[14:47:41 CDT(-0500)] <alexn1> michelled: I think that I definitely can set the default value for @params by doing something like this "constructor: (@widget, @params = {} )->"

[14:47:56 CDT(-0500)] <alexn1> but not sure about @params.labelKeyword

[14:48:47 CDT(-0500)] <michelled> the labelKeyword seems to have been generated reasonable, so I don't think it's an issue

[14:49:19 CDT(-0500)] <alexn1> I will change code so that @params will have a default value

[14:50:43 CDT(-0500)] <alexn1> michelled: thx and let me know if you find anything else

[14:51:11 CDT(-0500)] <michelled> np alexn1 - I'll let you know

[14:55:22 CDT(-0500)] <michelled> alexn1: that was the only thing I saw there

[14:55:41 CDT(-0500)] <michelled> alexn1: I'm sure you tested this with some screen readers in different browsers, yes?

[14:57:00 CDT(-0500)] <michelled> alexn1: of course it should be fixed in the 3 places it was introduced.

[14:57:06 CDT(-0500)] <alexn1> I tested it before but as any other branch I will update it with the latest staging and make another extra tests for Safari text-to-speech, IE and FF with NVDA/JAWS before submitting a pull request.

[14:57:32 CDT(-0500)] <michelled> great - thx alexn1 - this looks like it was a lot of nit picky work - good job!

[14:57:40 CDT(-0500)] <alexn1> It is the fix for Describe step and all its widgets. I will take another extra careful look before submitting it

[14:59:04 CDT(-0500)] <alexn1> michelled: Thx a lot for finding time to review this nasty big branch.

[14:59:12 CDT(-0500)] <michelled> np

[14:59:29 CDT(-0500)] <alexn1> michelled: my next step is to update it with the feedback you provided and double test every browser and screen reader before submitting any pull request to staging

[14:59:43 CDT(-0500)] <michelled> sounds good alexn1

[15:03:24 CDT(-0500)] <alexn1> michelled: I have a little question.

[15:03:30 CDT(-0500)] <michelled> yeah?

[15:04:04 CDT(-0500)] <alexn1> I was going through the tickets and suddenly realized that we did not set a priority for one of the tickets. https://www.assembla.com/spaces/iskme/tickets/820

[15:04:17 CDT(-0500)] <alexn1> should it stay as it is or should it have a priority Highest

[15:04:26 CDT(-0500)] <alexn1> it was related to another ticket, let me find its number

[15:05:05 CDT(-0500)] <alexn1> michelled: here it is https://www.assembla.com/spaces/iskme/tickets/795

[15:06:31 CDT(-0500)] <michelled> alexn1: I think it should be left as is

[15:06:41 CDT(-0500)] <michelled> alexn1: are you running out of highest priority issues?

[15:08:03 CDT(-0500)] <alexn1> michelled: thx michelled. I was not sure about the ticket and wanted to double check. And I still have High priority opened oer commons tickets, so there is still work to be done.

[15:09:28 CDT(-0500)] <alexn1> that double name mentioning was unnecessary. Just noticed it.

[15:10:04 CDT(-0500)] <alexn1> thx for clarification since I never asked what priority should be set on that 820 ticket

[15:13:44 CDT(-0500)] <michelled> np alexn1

[18:38:00 CDT(-0500)] <sgithens> Any infusion/gpii folks around?