fluid-work IRC Logs-2013-08-27

Owned by Fluid IRC Log Bot
Last updated: Aug 27, 2013
8 min read

[09:56:32 CDT(-0500)] <cindyli> Justin_o: the changes for GPII-175 is pushed up and its pull request is ready for review

[09:57:00 CDT(-0500)] <Justin_o> cindyli: thanks.. i'll take a look at your two pull requests now

[09:57:12 CDT(-0500)] <cindyli> thanks, Justin_o

[10:26:09 CDT(-0500)] <Justin_o> cindyli: i merged your GPII-175 pull request,

[10:26:23 CDT(-0500)] <Justin_o> cindyli: but now there are merge conflicts for your GPII-165 pull request

[10:26:29 CDT(-0500)] <Justin_o> can you take a look at that

[10:26:33 CDT(-0500)] <cindyli> sure, Justin_o

[10:26:40 CDT(-0500)] <Justin_o> cindyli: thanks

[10:28:51 CDT(-0500)] <cindyli> Justin_o: conflict resolved and pushed up

[10:42:28 CDT(-0500)] <Justin_o> cindyli: thanks.. i'll take another look

[10:42:42 CDT(-0500)] <cindyli> thanks, Justin_o

[10:56:00 CDT(-0500)] <jhernandez> kasparnet: just pushed a new branch javihernandez/GPII-20

[10:57:08 CDT(-0500)] <jhernandez> it's tracking kaspermarkus/GPII-20

[10:57:17 CDT(-0500)] <kasparnet> are we in linux or universal?

[10:57:27 CDT(-0500)] <jhernandez> linux

[10:57:35 CDT(-0500)] <heidiv> Justin_o could you take a look at 171 again when you have time?

[10:58:12 CDT(-0500)] <jhernandez> now, I'll do the same with GPII-20, but for universal

[10:58:22 CDT(-0500)] <Justin_o> heidiv: will do

[10:59:35 CDT(-0500)] <Justin_o> jhung, cindyli: GPII-165/GPII-157 merged

[10:59:50 CDT(-0500)] <cindyli> great. thanks, Justin_o

[11:02:10 CDT(-0500)] <jhung> great Justin_o

[11:07:59 CDT(-0500)] <kasparnet> Jhernandez: did you want me to try and pull it down and test? Or should I wait up?

[11:10:39 CDT(-0500)] <Justin_o> heidiv: still getting the vertical scroll bars in IE 10 and IE 9 for GPII-171

[11:11:43 CDT(-0500)] <heidiv> Justin_o hm, my IE9 is fine

[11:11:47 CDT(-0500)] <heidiv> did you clear cache?

[11:12:00 CDT(-0500)] <Justin_o> heidiv: i'll clean it out and try again

[11:13:58 CDT(-0500)] <Justin_o> heidiv: still there.. so to be clear i see it when i open the discovery panel and shrink the width so that the horizontal scroll bar appears

[11:14:17 CDT(-0500)] <heidiv> Justin_o wish i could recreate - which win OS?

[11:14:48 CDT(-0500)] <heidiv> i'll get jhung to take a look too

[11:15:04 CDT(-0500)] <Justin_o> heidiv: win7

[11:15:15 CDT(-0500)] <Justin_o> heidiv: good idea to have jhung take a look too

[11:16:39 CDT(-0500)] <jhernandez> kasparnet: just made a pull request to your GPII-20

[11:20:16 CDT(-0500)] <heidiv> Justin_o yeah my win7/IE9 doesn't have vert bars. hmph

[11:22:31 CDT(-0500)] <kasparnet> jhernandez: perhaps to avoid total confusion, it might be easiest if I leave my linux GPII-20 branch be (or delete it), and we consider your branch the latest and greatest?

[11:22:45 CDT(-0500)] <Justin_o> heidiv: really.. okay.. i guess that will make jhung the tie breaker (smile)

[11:22:53 CDT(-0500)] <heidiv> hehe

[11:22:56 CDT(-0500)] <Justin_o> heidiv: are you sure you committed and pushed up all your changes?

[11:23:20 CDT(-0500)] <heidiv> Justin_o yeah

[11:23:20 CDT(-0500)] <kasparnet> jhernandez: but we keep GPII-20 on my account as the one to do GPII pull requests from?

[11:23:41 CDT(-0500)] <Justin_o> heidiv: okay.. then we'll leave it to jhung to look at (smile)

[11:23:46 CDT(-0500)] <heidiv> haha ok

[11:23:46 CDT(-0500)] <kasparnet> jhernandez: should I test your linux version, or do you want to push something to your universal/GPII-20 first?

[11:24:17 CDT(-0500)] <jhernandez> kasparnet: wait for my universal branch of all

[11:24:20 CDT(-0500)] <jhernandez> almost there

[11:24:21 CDT(-0500)] <jhernandez> (wink)

[11:28:18 CDT(-0500)] <kasparnet> sure np, got plenty to do myself

[11:34:26 CDT(-0500)] <Justin_o> heidiv: i just tested it out on a windows 8 machine we have in the office.. IE 10 was still showing the vertical scroll bar

[11:34:59 CDT(-0500)] <heidiv> Justin_o other browsers are ok? darn IE...

[11:35:09 CDT(-0500)] <heidiv> thanks for testing

[11:35:12 CDT(-0500)] <Justin_o> heidiv: yep.. the other browsers look fine..

[11:35:14 CDT(-0500)] <Justin_o> np

[11:36:26 CDT(-0500)] <Justin_o> heidiv: by the way, was going to look at your pull request for GPII-162, looks like it has merge conflicts with master right now

[11:44:29 CDT(-0500)] <avtar> Bosmon, heidiv, jhung, kasparnet: are any of you using windows 7 and/or 8?

[11:46:40 CDT(-0500)] <jhung> avtar: I have Win7 and Win8

[11:47:05 CDT(-0500)] <jhung> Justin_o: I'll take a look at GPII-171 now to see how it looks.

[11:49:36 CDT(-0500)] <avtar> jhung: what's your schedule like today? i was hoping to get some help with testing the openvpn windows client

[11:50:19 CDT(-0500)] <jhung> avtar: maybe around 2:30p?

[11:50:39 CDT(-0500)] <avtar> sounds good

[11:50:41 CDT(-0500)] <avtar> thanks

[11:51:06 CDT(-0500)] <jhung> np avtar

[11:52:18 CDT(-0500)] <jhernandez> kasparnet: https://github.com/javihernandez/universal/tree/GPII-89_GPII-72_GPII-20

[11:53:15 CDT(-0500)] <jhernandez> should work with https://github.com/javihernandez/linux/tree/GPII-20

[11:54:57 CDT(-0500)] <jhernandez> take into account that you need to include the changes on https://github.com/kaspermarkus/infusion/compare/GPII-177

[11:56:40 CDT(-0500)] <jhung> heidiv, Justin_o: On IE9 when I resize the window, both horizontal and vertical bars appear.

[12:00:25 CDT(-0500)] <jhernandez> kasparnet: aaand, the integration testing would not work because of the more-than-2-tests weird thing

[12:04:50 CDT(-0500)] <kasparnet> yzen: Is there some central place where I can put a breakpoint that'll catch all the errors thrown during the various promises, etc in the system

[12:05:31 CDT(-0500)] <kasparnet> yzen: it's driving me f!@#ing crazy to have to step through everything every time something silently goes wrong

[12:05:44 CDT(-0500)] <kasparnet> thanks jhernandez

[12:11:09 CDT(-0500)] <jhernandez> thanks to you (wink)

[12:15:15 CDT(-0500)] <jhernandez> kasparnet: yzen JFYI must leave now, brb 1 hour or so

[12:15:24 CDT(-0500)] <kasparnet> jhernandez: kk

[12:44:10 CDT(-0500)] <cindyli> Justin_o: i submitted a pull request https://github.com/fluid-project/prefsEditors/pull/35 to update discovery tool with the latest infusion library, can you take a look when you have a chance?

[12:45:23 CDT(-0500)] <Justin_o> cindyli: will do, thanks

[12:45:37 CDT(-0500)] <cindyli> thanks. Justin_o

[12:46:11 CDT(-0500)] <cindyli> Justin_o: is there anything you think i should work on or i will pick one from the iteration plan

[12:48:53 CDT(-0500)] <heidiv> Justin_o i merged master into GPII-162

[12:58:05 CDT(-0500)] <yzen> kasparnet: http://www.digitaltrends.com/wp-content/uploads/2011/09/you-mad-bro.png

[13:07:11 CDT(-0500)] <jhung> heidiv: I did some more testing in IE9. The vertical scroll would appear if the panel is open and then resized. If you then close the panel and re-open, the vertical scroll disappears.

[13:07:46 CDT(-0500)] <heidiv> jhung weird! ok

[13:08:13 CDT(-0500)] <jhung> I'm going to test IE10 now heidiv.

[13:08:34 CDT(-0500)] <heidiv> k thanks jhung

[13:09:04 CDT(-0500)] <Justin_o> jhung, heidiv: that sort of makes sense, because the panel determines it's height on open

[13:09:36 CDT(-0500)] <heidiv> Justin_o yeah

[13:09:55 CDT(-0500)] <avtar> jhung: i have a windows 7 vm now so i don't need to take up your time

[13:09:56 CDT(-0500)] <Justin_o> jhung, heidiv: if it's not easily fixed we could just file a new jira for it, if it is sized correctly on first load of a narrow screen that might be good enough for most cases

[13:10:39 CDT(-0500)] <jhung> avtar: ok cool. Let me know if I can help though.

[13:10:59 CDT(-0500)] <avtar> jhung: thanks

[13:11:01 CDT(-0500)] <heidiv> Justin_o and i'm still unable to recreate on my end. jhung's going to try a fix for me. i think IE is not acknowledging the overflow:none on iframe's html tag

[13:11:08 CDT(-0500)] <avtar> you could also review this important document http://i.imgur.com/FRD7RCC.jpg

[13:11:30 CDT(-0500)] <kasparnet> yzen

[13:11:37 CDT(-0500)] <yzen> kasparnet:

[13:12:14 CDT(-0500)] <jhung> avtar: kids and their fancy cloud computers.

[13:12:15 CDT(-0500)] <kasparnet> So there is some crazy weirdness in the integration testing framework

[13:12:33 CDT(-0500)] <kasparnet> yzen: adding three tests causes everything to explode

[13:12:59 CDT(-0500)] <kasparnet> ... and it doesn't seem to have anything to do with what tests have been run

[13:13:15 CDT(-0500)] <kasparnet> the error is nested somewhere in the IoC framework

[13:13:35 CDT(-0500)] <kasparnet> (or.. not really sure.. that's just where it's thrown)

[13:13:43 CDT(-0500)] <yzen> kasparnet: do you have this stuff committed anywhere?

[13:13:53 CDT(-0500)] <kasparnet> yes, all over the place actually :S

[13:14:15 CDT(-0500)] <kasparnet> yzen: Javi's linux branch: https://github.com/javihernandez/linux/tree/GPII-20

[13:14:31 CDT(-0500)] <kasparnet> and universal branch: https://github.com/javihernandez/universal/tree/GPII-89_GPII-72_GPII-20

[13:14:58 CDT(-0500)] <yzen> kasparnet: and i should run it in linux i assume

[13:14:59 CDT(-0500)] <kasparnet> And you need to do this hack: https://github.com/kaspermarkus/infusion/compare/GPII-177

[13:15:03 CDT(-0500)] <kasparnet> yzen:

[13:15:06 CDT(-0500)] <kasparnet> yes*

[13:15:28 CDT(-0500)] <yzen> that looks crazy

[13:15:29 CDT(-0500)] <yzen> (smile)

[13:18:17 CDT(-0500)] <kasparnet> what part of it?

[13:20:48 CDT(-0500)] <jhung> heidiv, Justin_o: it looks okay in IE10. It looks a bit strange with 2 horizontal scrollbars (one for the browser and one for the DT panel), but there are no vertical scrollbars.

[13:21:33 CDT(-0500)] <heidiv> jhung that second bar will be fixed with 176 i think - did you take a look at that one?

[13:21:57 CDT(-0500)] <heidiv> Justin_o if the issue is a vert scroll just in IE9, perhaps 171 can go in and i'll file another jira for that?

[13:22:27 CDT(-0500)] <Justin_o> jhung, heidiv: strange, i've seen it in both IE 10 and IE 9

[13:23:41 CDT(-0500)] <yzen> the hack (smile) but anyways , let me take a look

[13:24:18 CDT(-0500)] <jhung> heidiv: makes sense. I haven't looked at 176 yet.

[13:26:24 CDT(-0500)] <heidiv> k

[13:30:21 CDT(-0500)] <Justin_o> jhung, heidiv: i've filed a new jira for the vertical scroll bar http://issues.gpii.net/browse/GPII-178

[13:35:00 CDT(-0500)] <jhung> thanks Justin_o

[13:35:15 CDT(-0500)] <Justin_o> jhung, heidiv: merged in GPII-171

[13:36:02 CDT(-0500)] <heidiv> thanks Justin_o and jhung

[13:37:27 CDT(-0500)] <Justin_o> heidiv: of course now that i've merged in GPII-171 there is another merge conflict with GPII-162

[13:37:37 CDT(-0500)] <heidiv> Justin_o (smile) i'll update

[13:37:44 CDT(-0500)] <Justin_o> heidiv: thanks

[13:40:37 CDT(-0500)] <jhernandez> kasparnet: yzen back

[13:53:46 CDT(-0500)] <heidiv> Justin_o 162 merged

[13:55:11 CDT(-0500)] <Justin_o> heidiv: thanks

[13:57:35 CDT(-0500)] <Justin_o> heidiv: the labels and the preset icons don't line up in the discovery tool anymore

[13:57:49 CDT(-0500)] <heidiv> Justin_o checking...

[13:57:54 CDT(-0500)] <Justin_o> heidiv: thanks

[14:02:50 CDT(-0500)] <heidiv> Justin_o merge issue. fixed

[14:03:57 CDT(-0500)] <Justin_o> heidiv: thanks

[14:06:29 CDT(-0500)] <cindyli> Justin_o: i issued another pull request (https://github.com/fluid-project/prefsEditors/pull/36) for GPII-169, to fix the ie8 issue that self voicing enactor throws js error. can you review it when you have a chance?

[14:07:21 CDT(-0500)] <yzen> so kasparnet

[14:07:32 CDT(-0500)] <yzen> i tried with the branches you said, which particular user fails ?

[14:07:37 CDT(-0500)] <Justin_o> cindyli: will do

[14:07:48 CDT(-0500)] <cindyli> thanks

[14:14:25 CDT(-0500)] <Justin_o> heidiv: I'm still getting the overlap issue with safari for the focus styling of the presets when the contrasts are set

[14:16:39 CDT(-0500)] <heidiv> Justin_o ughhh ok haha… one sec

[14:24:09 CDT(-0500)] <Justin_o> cindyli: merged in GPII-169

[14:24:20 CDT(-0500)] <cindyli> nice. thanks. Justin_o

[14:28:22 CDT(-0500)] <kasparnet> yzen: sorry, not seeing this till now

[14:28:31 CDT(-0500)] <yzen> kasparnet: np

[14:28:33 CDT(-0500)] <kasparnet> ... none of the users fail, but the integration testing does

[14:28:38 CDT(-0500)] <yzen> oh duh

[14:28:40 CDT(-0500)] <yzen> one sec

[14:28:51 CDT(-0500)] <kasparnet> so in linux dir do: node tests/integrationTesting.js

[14:28:56 CDT(-0500)] <kasparnet> and watch it explode

[14:29:42 CDT(-0500)] <yzen> so you have 12/18 passing ?

[14:35:40 CDT(-0500)] <jhernandez> yzen: comment one integration test from integrationTesting.js

[14:35:47 CDT(-0500)] <jhernandez> and watch it working

[14:35:48 CDT(-0500)] <jhernandez> (tongue)

[14:36:03 CDT(-0500)] <yzen> one sec

[14:36:16 CDT(-0500)] <jhernandez> at least, this is what happens to me

[14:37:22 CDT(-0500)] <Justin_o> cindyli: Merged in FLUID-5116 into DT

[14:37:58 CDT(-0500)] <cindyli> yay! thanks, Justin_o

[14:38:07 CDT(-0500)] <Justin_o> cindyli: thank you

[14:47:23 CDT(-0500)] <yzen> kasparnet: jhernandez: I'm trying to figure out where you link test case holder to a test environment component

[14:49:48 CDT(-0500)] <kasparnet> yzen: is this what you mean? https://github.com/kaspermarkus/universal/blob/GPII-20/tests/IntegrationTests.js#L103-L116

[15:17:05 CDT(-0500)] <yzen> kasparnet, jhernandez hard to tell what the issue is but i think i saw this problem in my kettle tests. i would suggest just as an experiment to create a separate test case holder for each testDef and see if it works

[15:18:43 CDT(-0500)] <kasparnet> yzen: ok.. It just seems weird that it runs two tests, but not three

[15:18:54 CDT(-0500)] <yzen> perhaps Bosmon might have an idea

[15:19:07 CDT(-0500)] <kasparnet> I'm sure bosmon would disagree that 2 is significantly different from 3..*

[15:31:56 CDT(-0500)] <jhernandez> xDDDD