fluid-work IRC Logs-2013-08-13

[08:01:52 CDT(-0500)] <Justin_o> cindyli: did you get a chance to look at the comment i left on the GPII-130 pull request?

[08:02:49 CDT(-0500)] <cindyli> yes, i did. going to work on it after the builder munging test. are you waiting on it, Justin_o?

[08:03:59 CDT(-0500)] <Justin_o> cindyli: a little bit, i was going to use the message bundles you have there for adding in the sting for "Try Something New" in my GPII-128 branch

[08:04:26 CDT(-0500)] <cindyli> ok, will it first, Justin_o

[08:04:37 CDT(-0500)] <Justin_o> cindyli: thanks

[08:04:41 CDT(-0500)] <cindyli> np

[08:57:02 CDT(-0500)] <cindyli> Justin_o: your comment on GPII-130 is addressed

[08:57:50 CDT(-0500)] <Justin_o> cindyli: thanks

[08:57:50 CDT(-0500)] <cindyli> didn't find a good way to fix the delay at showing the icon when the panel closes.

[08:57:53 CDT(-0500)] <Justin_o> i'll take a look again

[08:58:14 CDT(-0500)] <Justin_o> cindyli: okay… could be an issue with the events from the sliding panel

[09:10:58 CDT(-0500)] <Justin_o> cindyli: did you push up your changes to GPII-130.. i don't see them on the pull request

[09:14:54 CDT(-0500)] <cindyli> u were right. sorry, Justin_o. pushed up

[09:15:30 CDT(-0500)] <Justin_o> cindyli: thanks

[09:15:35 CDT(-0500)] <cindyli> np

[09:24:38 CDT(-0500)] <jhung> Justin_o, cindyli - there's focus styling work to be done for GPII-130?

[09:25:47 CDT(-0500)] <cindyli> i think yes for the focus styling on show/hide link, jhung

[09:26:38 CDT(-0500)] <jhung> ok. I'll take a look at that cindyli

[09:26:52 CDT(-0500)] <cindyli> great, thanks, jhung

[09:55:01 CDT(-0500)] <heidiv> jhung need any help w 157?

[09:56:10 CDT(-0500)] <jhung> I'm good for GPII-157

[10:46:36 CDT(-0500)] <jessm> sorry to miss standup fluid-everyone: i'm working on the ORF-RI report today and meeting with Iris to do some TA magic and meeting with Colin to talk about the RFP. the end.

[11:31:39 CDT(-0500)] <heidiv> hey Justin_o , did we have a jira about moving focus to start of panel when panel opens?

[11:31:54 CDT(-0500)] <Justin_o> heidiv: not that I know of

[11:31:59 CDT(-0500)] <heidiv> i'm also thinking we need a skip to link for the DT tool since it's at the v bottom of the page

[11:33:00 CDT(-0500)] <Justin_o> heidiv: you might want to talk to vjoanna about that one.. in case there are any specific design decisions for why it's at the bottom

[11:33:57 CDT(-0500)] <heidiv> vjoanna - thoughts on keyboard users and having DT at very bottom?

[11:34:34 CDT(-0500)] <heidiv> Justin_o unless there's a way to position in it in the html at the top, but style it at the bottom. i think we moved it to the bottom in the html to get the sliding panel to work

[11:34:49 CDT(-0500)] <heidiv> but that might be confusing

[11:35:04 CDT(-0500)] <vjoanna> heidiv: hmm.. right now it's last in the tab order?

[11:35:26 CDT(-0500)] <heidiv> vjoanna right now you have to tab through the content before reaching the DT, yes

[11:36:29 CDT(-0500)] <Justin_o> heidiv: i think it would be confusing to have it at the top of the tab order but be visually at the bottom

[11:36:46 CDT(-0500)] <heidiv> agreed

[11:37:23 CDT(-0500)] <heidiv> "skip to discovery tool" won't mean anything to anyone though… "skiip to display preferences" maybe

[11:37:47 CDT(-0500)] <heidiv> but the panel bar doesn't say "display preferences" so that's sort of confusing too

[11:37:53 CDT(-0500)] <heidiv> it says "doesn't make sense?"

[11:38:37 CDT(-0500)] <heidiv> we could do "doesn't make sense? skip to display preferences at bottom of page" or something…

[11:38:57 CDT(-0500)] <heidiv> then you open the panel and have to back-tab to get to the prefs…

[11:39:25 CDT(-0500)] <heidiv> almost feels like the skip-to should open the panel

[11:39:52 CDT(-0500)] <vjoanna> heidiv, justin_o: how about having after all the top navigation?

[11:40:14 CDT(-0500)] <vjoanna> before the article

[11:40:56 CDT(-0500)] <heidiv> hm, that might be confusing too

[11:41:44 CDT(-0500)] <Justin_o> vjoanna: yah.. for the visual keyboard user having things out of order might be confusing

[11:42:03 CDT(-0500)] <Justin_o> heidiv: sounds like you are arguing for another method of opening the discovery tool

[11:42:18 CDT(-0500)] <Justin_o> perhaps there can be another button or a keyboard short cut

[11:42:30 CDT(-0500)] <Justin_o> vjoanna: what do you think of that?

[11:43:35 CDT(-0500)] <heidiv> Justin_o just brainstorming out loud.

[11:43:51 CDT(-0500)] <heidiv> tabbing through entire page to get to DT isn't ideal

[11:44:06 CDT(-0500)] <heidiv> then opening and back-tabbing also strange

[11:45:00 CDT(-0500)] <vjoanna> hmm, i'm hesitant about adding another button because it would be out of context, but a keyboard shortcut could work… we could underline the letter 'd' in 'doesn't make...'

[11:45:02 CDT(-0500)] <heidiv> i think i like a skip link that says "doesn't make sense? skip to display preferences at bottom of page" or something - it would be up to the implementor to include on the content page

[11:45:28 CDT(-0500)] <heidiv> shortcuts are iffy with AT, no?

[11:46:26 CDT(-0500)] <Justin_o> heidiv: in terms of conflicting with the AT's keyboard commands

[11:46:35 CDT(-0500)] <heidiv> ya

[11:46:39 CDT(-0500)] <Justin_o> that's true.

[11:47:11 CDT(-0500)] <vjoanna> it also doesn't seem too odd for me to have it first, because it's a persistent bar

[11:47:42 CDT(-0500)] <heidiv> vjoanna for tab order?

[11:47:46 CDT(-0500)] <vjoanna> yeah

[11:48:06 CDT(-0500)] <heidiv> is that typical for persistent bars?

[11:48:43 CDT(-0500)] <heidiv> i think hitting two tabs and being out of content would really confuse users

[11:50:27 CDT(-0500)] <heidiv> jhung any thoughts?

[11:50:41 CDT(-0500)] <vjoanna> I'm not sure, it's not common to have bars at the bottom

[11:50:47 CDT(-0500)] <jhung> heidiv: catching up...

[11:52:11 CDT(-0500)] <jhung> heidiv: so the question is about tab order of the DT?

[11:52:28 CDT(-0500)] <jhung> Should it appear after content or after nav bar?

[11:52:49 CDT(-0500)] <heidiv> jhung question is how to make it easier for kb users to reach DT. right now have to tab through entire content…. seems like there should be a better way?

[11:54:20 CDT(-0500)] <jhung> heidiv: I think it should be treated like a menu and therefore appear early in the tab order. In every way it's like a menu, except visually it's at the bottom of the screen.

[11:55:38 CDT(-0500)] <jhung> also, not saying it's correct, but in Windows, pressing TAB will put focus on the start menu / task bar, and subsequent tab places you on the first desktop icon.

[11:56:20 CDT(-0500)] <heidiv> jhung that way we'd have to make it that after tabbing to "doesn't make sense" first, the second tab would go to content

[11:56:48 CDT(-0500)] <heidiv> but what if they open the panel and (we should get) focus moves to start of panel prefs

[11:57:58 CDT(-0500)] <jhung> seems like expected behaviour when opening a slider heidiv. Seems okay to me.

[11:59:07 CDT(-0500)] <heidiv> jhung i mean, how does that work exactly, to get the second tab to go to content and/or a preference if panel is opened

[11:59:31 CDT(-0500)] <heidiv> and i still think first tab bringing you to bottom of page might be disorienting

[12:00:17 CDT(-0500)] <heidiv> i wonder if this discussion is mailing list worthy? Justin_o vjoanna ?

[12:02:04 CDT(-0500)] <jhung> if DT panel is open and focus is on the first item, pressing tab should put focus on the content. I think the DT should behave and feel like a menu. Arrow keys to navigate, space to enable, tab to put focus out of menu.

[12:04:59 CDT(-0500)] <heidiv> jhung can we do that w the markup

[12:05:20 CDT(-0500)] <jhung> heidiv: yeah.

[12:06:00 CDT(-0500)] <heidiv> jhung can you summarize what you're proposing for vjoanna (and me haha)

[12:06:11 CDT(-0500)] <jhung> sure.

[12:06:16 CDT(-0500)] <vjoanna> jhung: would the having focus on the DT button open it up?

[12:06:38 CDT(-0500)] <jhung> vjoanna: not quite. Here's what I'm suggesting...

[12:08:19 CDT(-0500)] <jhung> first tab puts focus on the DT. second tab puts focus on content. If space / enter / click on the DT button, the panel opens and focus is placed on the first item in the panel. Pressing tab with focus on first DT item will put focus back on the content. Pressing arrow keys with focus on DT item will move selection side to side.

[12:10:02 CDT(-0500)] <jhung> It's a little different from a menu because a typical menu collapses when focus is removed, in our case it doesn't.

[12:13:47 CDT(-0500)] <vjoanna> hmm.. i like that, my only worry is that the arrow key navigation might not be clear - the user might think that 'try something new' is the only way to activate the presets?

[12:13:58 CDT(-0500)] <vjoanna> ^jhung

[12:15:53 CDT(-0500)] <heidiv> jhung i like it too, in theory, but it might be hard to convey those commands to a user intuitively… it's different than how a typical website menu might work

[12:16:08 CDT(-0500)] <jhung> vjoanna: what if we put "try something new" at the end of the list and make it look slightly different?

[12:16:30 CDT(-0500)] <heidiv> jhung what do you think about a simple

[12:16:33 CDT(-0500)] <heidiv> skip link

[12:16:35 CDT(-0500)] <heidiv> at the top

[12:18:15 CDT(-0500)] <jhung> I feel a bit iffy about that heidiv because it feels a bit redundant. If first tab puts focus on the skip link which brings you to the DT panel, then why not just put first tab focused on the DT itself?

[12:19:04 CDT(-0500)] <heidiv> jhung orientation confusion, giving users explicit choice

[12:20:04 CDT(-0500)] <jhung> heidiv: I think the panel looks like it should be navigable by cursor keys. I think there's enough cues to imply some sort of navigation by keys.

[12:21:22 CDT(-0500)] <jhung> vjoanna: back to your concern about "try something new", I agree that this is a possible spot of confusion. I think perhaps if it were styled to resemble more of a DT button and perhaps worded different, it would be okay?

[12:22:24 CDT(-0500)] <vjoanna> jhung: 'try something new' might not work at the end of the list in situations where the list of presets is long and requires horizontal scrolling?

[12:22:55 CDT(-0500)] <vjoanna> what are thinking for the styling and wording?

[12:23:47 CDT(-0500)] <jhung> vjoanna: perhaps put "try something new" horizontal below the buttons. Then there's a stronger association that it's acting on the stuff above it?

[12:28:04 CDT(-0500)] <vjoanna> jhung: earlier it was mocked up horizontally above the buttons and some people i showed it to thought it was just label for the preset buttons with no functionality - that's why i moved it closer to the rest of the buttons

[12:28:55 CDT(-0500)] <danaayotte> jhung, vjoanna: I like the idea of it styled as another DT button

[12:28:57 CDT(-0500)] <jhung> vjoanna: I agree. Actually it still does look like a label.

[12:30:00 CDT(-0500)] <jhung> danaayotte: as an icon I'm imagining a gift-wrapped box with a bow.

[12:30:35 CDT(-0500)] <danaayotte> jhung: or one of those wind-up, pop-up toys??

[12:30:50 CDT(-0500)] <jhung> and when you select it, confetti and streamers rain down from the top of the screen. Maybe that requires some user testing.

[12:31:15 CDT(-0500)] <jhung> danaayotte: I hate those things. lol Always freaks me out.

[12:31:31 CDT(-0500)] <danaayotte> jhung: yes, they are scary!

[12:31:56 CDT(-0500)] <danaayotte> jhung, vjoanna: i think having it styled like a DT button might indicate that you can also select the others

[12:32:08 CDT(-0500)] <vjoanna> i don't think we should style it exactly like the preset buttons, because it functions differently.. but a fun large icon might help

[12:33:40 CDT(-0500)] <jhung> What if the try something new was put in a similar button, but separated by a chevron pointing to the right (toward the other options)?

[12:33:47 CDT(-0500)] <vjoanna> i would be worried about a user clicking it expecting to just be another preset, but instead it changes the presets they already selected

[12:37:59 CDT(-0500)] <danaayotte> vjoanna: I agree I can see that being an issue

[12:38:31 CDT(-0500)] <heidiv> i agree, i think styling it to look like a preset would imply it behaves like one

[12:58:59 CDT(-0500)] <Justin_o> jhung, heidiv, vjoanna: just catching up on the conversation.. i'd be careful about the arrow navigation because a screen reader user will still think it's a set of checkboxes and will try to interact as they would normaly.

[12:59:13 CDT(-0500)] <Justin_o> Bosmon: cindyli1 and I have a question for you

[12:59:20 CDT(-0500)] <Justin_o> Bosmon: about distribute options

[12:59:25 CDT(-0500)] <Bosmon> Hi Justin_o

[13:05:59 CDT(-0500)] <Justin_o> Bosmon: hello.. let me find you a link to some code

[13:07:06 CDT(-0500)] <Justin_o> Bosmon: https://github.com/fluid-project/infusion/blob/master/src/components/uiOptions/js/UIOptions.js#L47-L50

[13:07:40 CDT(-0500)]

[13:07:48 CDT(-0500)] <Justin_o> could we do one of the following instead

[13:08:13 CDT(-0500)]

[13:08:14 CDT(-0500)] <Justin_o> or

[13:08:29 CDT(-0500)]

[13:13:21 CDT(-0500)] <Bosmon> Justin_o and cindyli1, this is governed by http://issues.fluidproject.org:18080/browse/FLUID-5013

[13:13:33 CDT(-0500)] <Bosmon> Sorry, I don't know why the strange port number is in there

[13:13:45 CDT(-0500)] <Bosmon> avtar, do you happen to know why our JIRA is serving on port 18080?

[13:14:46 CDT(-0500)] <Bosmon> Justin_o - as it stands, the expression is very dubious, since it is unclear whether "templateLoader" is a component or not

[13:15:22 CDT(-0500)]

[13:15:31 CDT(-0500)] <Bosmon> Why is there an "options" trailing here?

[13:15:56 CDT(-0500)] <heidiv> Justin_o jhung vjoanna danaayotte i created this jira about the DT for kb users. please add any comments! http://issues.gpii.net/browse/GPII-163

[13:16:05 CDT(-0500)] <Bosmon> Given that "templateLoader" within the options structure can't be directly designating a component, it seems you could choose any options structure you like here

[13:16:08 CDT(-0500)] <heidiv> and maybe it should be discussed on list?

[13:16:18 CDT(-0500)] <Bosmon> And it seems you would prefer to choose one that omitted the extra "options"

[13:16:25 CDT(-0500)] <Bosmon> As for the target expression, the "options" cannot be omitted

[13:16:55 CDT(-0500)] <jhung> heidiv: sounds good . thanks for filing that jira.

[13:16:56 CDT(-0500)] <Bosmon> Since you really intend to hit the options of a real component - and since we have FLUID-5013, missing out "options" in the target will have a bad effect of trying to "distribute to top level"

[13:19:12 CDT(-0500)] <Justin_o> Bosmon: i'm not sure where the code i sent you originated, it is what is currently in master

[13:20:05 CDT(-0500)] <Justin_o> Bosmon: we were looking to revise it, but it seems like from what you are saying that it can be omitted from the source

[13:21:28 CDT(-0500)]

[13:21:50 CDT(-0500)] <Bosmon> Justin_o - it's up to you, since you are designing the top-level options structure

[13:22:05 CDT(-0500)]

[13:22:10 CDT(-0500)] <Bosmon> They are jsut "some options"

[13:23:45 CDT(-0500)] <Justin_o> Bosmon: okay, but the distribute options mechanism isn't automatically breaking down the options object for us

[13:24:01 CDT(-0500)] <Bosmon> Justin_o - can you explain what you mean by "automatically breaking down"?

[13:25:09 CDT(-0500)] <Justin_o> Bosmon: i'm just asking because you were curious as to why the source had ended in .options.. seemed that it might take an options object inside the source and just use that to forward

[13:25:28 CDT(-0500)] <Bosmon> Justin_o - as I said, there is no special meaning to "input options" since they are not attached to any components

[13:25:59 CDT(-0500)] <Bosmon> You can write whatever you like in a component's structure beginning with "options.*" .... unless you write it in "components" it has no special meaning to the framework

[13:28:33 CDT(-0500)]

[13:28:44 CDT(-0500)] <Bosmon> Justin_o - yes, that would be fine

[13:29:09 CDT(-0500)] <Justin_o> Bosmon: thanks

[13:29:23 CDT(-0500)]

[13:29:35 CDT(-0500)] <Justin_o> Bosmon: of an integrator ever wanted to change the type or container of a subcomponent they would have to do it directly?

[13:29:42 CDT(-0500)] <Bosmon> But I don't think this would be useful in this case since there are no other top-level configurations accepted by "templateLoader"

[13:29:47 CDT(-0500)] <Bosmon> it is configured entirely through options

[13:29:55 CDT(-0500)] <Bosmon> Although in general the only other top-level configuration there is "container"

[13:30:54 CDT(-0500)] <Justin_o> Bosmon: yes.. was wondering if we'd want to be able to pass "container" and "type" along as well

[13:31:02 CDT(-0500)] <Bosmon> Oh yes, "type" too

[13:31:41 CDT(-0500)] <Bosmon> Well, hopefully you could avoid the need for that by just using the facility to pass "gradeNames" from within the options

[13:32:27 CDT(-0500)] <Bosmon> In the case the use really wanted to replace the templateLoader's type wholesale, they could still fall back on good old-fashioned demands blocks : P

[13:33:50 CDT(-0500)] <Bosmon> the user

[13:34:19 CDT(-0500)] <Justin_o> Bosmon: cool thanks.. this isn't specifically for templateLoader we just want to make things consistent throughout uiOptions and the builder with regards to distribute options

[13:34:27 CDT(-0500)] <Bosmon> ok

[13:34:44 CDT(-0500)] <Bosmon> Well, in general it would seem desirable to avoid an extra level of nesting in the "overall input options"

[13:35:03 CDT(-0500)] <Bosmon> But perhaps that fights against consistency

[13:38:17 CDT(-0500)] <Justin_o> Bosmon: we would change all the cases of distribute options in uiOptions

[13:38:39 CDT(-0500)] <Justin_o> but you could argue that it isn't consistent with how options are usually specified, if that's what you mean

[13:50:21 CDT(-0500)] <avtar> Bosmon: where did you come across that url with the port number?

[13:50:31 CDT(-0500)] <Bosmon> avtar - in Google

[13:50:45 CDT(-0500)] <Bosmon> But there's the odd fact that it works : P

[13:52:48 CDT(-0500)] <avtar> it shouldn't work now

[13:59:35 CDT(-0500)] <Justin_o> michelled: i modified my pull request for FLUID-5110

[14:01:25 CDT(-0500)] <michelled> thx Justin_o

[14:02:00 CDT(-0500)] <Justin_o> jhung: are you all done with the changes for GPII-130

[14:02:01 CDT(-0500)] <Justin_o> ?

[14:02:08 CDT(-0500)] <Bosmon> Thanks, avtar!

[14:02:36 CDT(-0500)] <Bosmon> colinclark, michelled - what's a good time to have our "multiple CATT documentation session"?

[14:02:52 CDT(-0500)] <jhung> Justin_o: heidiv took over that work from me.

[14:02:59 CDT(-0500)] <colinclark> 5 pm EDT works for me, unless you guys want to meet sooner and I'll join you then

[14:03:05 CDT(-0500)] <Justin_o> avtar: it still works for me. is that because i'm local

[14:03:18 CDT(-0500)] <michelled> Bosmon: I can do either - start now or at 5pm eastern

[14:03:29 CDT(-0500)] <heidiv> jhung i did?

[14:03:31 CDT(-0500)] <Justin_o> jhung: okay thanks

[14:05:06 CDT(-0500)] <heidiv> jhung i didn't do anything for 130

[14:05:14 CDT(-0500)] <Justin_o> jhung, heidiv: maybe we can just do all the focus styling issues in GPII-162

[14:05:30 CDT(-0500)] <heidiv> sounds good. i'll wait till 130 goes in then?

[14:05:32 CDT(-0500)] <jhung> heidiv: neither did I. lol So Justin_o nothing has been changed.

[14:05:37 CDT(-0500)] <Justin_o> i'll just take a look at cindyli1's pull request for GPII-130 independently

[14:05:47 CDT(-0500)] <heidiv> Justin_o cool let me know when it's in

[14:05:48 CDT(-0500)] <jhung> sounds good

[14:05:51 CDT(-0500)] <Justin_o>

[14:10:39 CDT(-0500)] <avtar> Justin_o: could it be your browser cache?

[14:11:40 CDT(-0500)] <avtar> if you want to try it again http://issues.fluidproject.org:18080/

[14:13:15 CDT(-0500)] <Justin_o> avtar: still works.. i tried a different url now http://issues.fluidproject.org:18080/browse/FLUID-25

[14:14:00 CDT(-0500)] <Justin_o> heidiv, cindyli1: GPII-130 has been merged in

[14:14:14 CDT(-0500)] <cindyli1> yay! thanks, Justin_o

[14:14:14 CDT(-0500)] <heidiv> Justin_o k !

[14:19:48 CDT(-0500)] <avtar> Justin_o: could you try again?

[14:20:53 CDT(-0500)] <Justin_o> avtar: same, but it is showing a message that you should update the settings to go to the url without the port

[14:21:40 CDT(-0500)] <avtar> ok looks like the 205.211.169.2 ip is in the iptables state table on the jira vm

[14:22:25 CDT(-0500)] <avtar> but right now might not be the best time to flush it

[14:22:48 CDT(-0500)] <avtar> i'll do that after 6:00 once you all have left

[14:23:59 CDT(-0500)] <michelled> Justin_o: are you waiting for me to look at any more pull requests?

[14:24:41 CDT(-0500)] <Justin_o> michelled: did you look at FLUID-5110 after i modified it?

[14:24:50 CDT(-0500)] <michelled> yep, just pushed it

[14:26:23 CDT(-0500)] <Justin_o> michelled: thanks

[14:53:35 CDT(-0500)] <Justin_o> heidiv: i've finished updating the code for GPII-128. I think it's just waiting for any more styling changes.. if you are all done i can submit a pull request for it now

[14:54:05 CDT(-0500)] <heidiv> Justin_o what are your thoughts on the animation?

[14:54:14 CDT(-0500)] <heidiv> Justin_o sent pull req for gpii-162

[14:54:52 CDT(-0500)] <Justin_o> heidiv: looks better, i guess we'll need joanna to see it for sure, but she's not in the office.. i suppose that could be part of the review process though

[14:55:24 CDT(-0500)] <heidiv> Justin_o sounds good to send a pull then. the text moving during the animation is something we can maybe file afterward. i don't like it but got stuck on how to fix it

[14:58:02 CDT(-0500)] <Justin_o> heidiv: okay.. i think you might need to use z-index or something like that

[14:58:36 CDT(-0500)] <heidiv> Justin_o need to figure out how to make the layout of the unseen large checkbox not affect the position of the txt below. seems basic but my brain couldn't do it yesterday

[14:59:28 CDT(-0500)] <Justin_o> heidiv: i'm sure it's not that easy

[14:59:55 CDT(-0500)] <heidiv> Justin_o thanks

[15:02:25 CDT(-0500)] <Justin_o> heidiv: left some comments on your GPII-162 pull request

[15:03:54 CDT(-0500)] <heidiv> Justin_o what happened to the next arrow?

[15:04:45 CDT(-0500)] <Justin_o> heidiv: when you focus those to links, a small box is highlighted above them

[15:04:56 CDT(-0500)] <heidiv> Justin_o no i mean, the next arrow is missing in master

[15:05:24 CDT(-0500)] <Justin_o> yes.. you are right.. it seems to also be missing.. maybe it got lost when jhung updated the font?

[15:05:48 CDT(-0500)] <jhung> let me see Justin_o.

[15:08:24 CDT(-0500)] <jhung> Justin_o: seems to be there. The PUA probably changed. :/

[15:08:33 CDT(-0500)] <jhung> let me find the code.

[15:08:37 CDT(-0500)] <Justin_o> michelled: if you have time, can you look at https://github.com/fluid-project/prefsEditors/pull/24

[15:08:50 CDT(-0500)] <Justin_o> jhung: thanks

[15:11:48 CDT(-0500)] <jhung> Justin_o: should be E019.

[15:12:21 CDT(-0500)] <Justin_o> heidiv: could you fix that in GPII-162 as well

[15:12:39 CDT(-0500)] <heidiv> Justin_o sure yep

[15:12:43 CDT(-0500)] <Justin_o> heidiv: thanks

[15:12:59 CDT(-0500)] <Justin_o> i'm heading out now.. i'll take a look at your pull request again tomorrow

[15:13:23 CDT(-0500)] <heidiv> jhung that didn't do it

[15:13:55 CDT(-0500)] <jhung> heidiv: checking again...