[01:34:46 EDT(-0400)] * jayshao (n=jayshao@ool-45731411.dyn.optonline.net) has joined #fluid-work <Bosmon> <colinclark> .fl-component-inlineEdit span input /* auto generated input fields */
[08:26:18 EDT(-0400)] * Justin_o (n=Justin@142.150.154.171) has joined #fluid-work
[08:48:03 EDT(-0400)] * laurelw (n=Laurel@142.150.154.178) has joined #fluid-work
[09:09:20 EDT(-0400)] * anastasiac (n=stasia@142.150.154.189) has joined #fluid-work
[09:48:13 EDT(-0400)] * clown (n=clown@142.150.154.101) has joined #fluid-work
[09:53:00 EDT(-0400)] * fj4000 (n=Jacob@142.150.154.106) has joined #fluid-work
[10:13:01 EDT(-0400)] <Justin_o> anastasiac: in the standalone-demos/lib/jquery directory the folder containing the images is called "i" is this intentional or should it be renamed to images
[10:13:37 EDT(-0400)] * colinclark (n=colin@142.150.154.101) has joined #fluid-work
[10:13:49 EDT(-0400)] <anastasiac> Justin_o: the images in that folder are referenced from the jquery css files
[10:13:57 EDT(-0400)] <anastasiac> changing the folder name would require changing the css
[10:14:09 EDT(-0400)] <Justin_o> ah... and they aren't our css files, so i should leave them
[10:14:13 EDT(-0400)] <anastasiac> since they were jquery files, I thought best to minimize changes
[10:14:22 EDT(-0400)] <anastasiac> but I'm open to arguments
[10:14:59 EDT(-0400)] <Justin_o> i think it makes sense to leave it, thanks for letting me know
[10:15:06 EDT(-0400)] <anastasiac> np
[10:20:21 EDT(-0400)] * michelled (n=team@142.150.154.193) has joined #fluid-work
[10:41:31 EDT(-0400)] * ecochran (n=ecochran@adsl-70-137-183-216.dsl.snfc21.sbcglobal.net) has joined #fluid-work
[10:42:49 EDT(-0400)] <ecochran> Justin_o: I just noticed that you did some work on some of the Uploader files. I'm working on Uploader, fixing up all the selectors and styles. I'm almost done. I started this work before the reorg work so I need to land it into the new structure.
[10:43:21 EDT(-0400)] <Justin_o> oh okay...
[10:43:38 EDT(-0400)] <Justin_o> all i really changed was the paths
[10:44:20 EDT(-0400)] <ecochran> OK, cool. I'm already feeling a little nervous about my merge back
[10:44:34 EDT(-0400)] <Justin_o> yes... since pretty much everything has moved
[10:44:37 EDT(-0400)] <ecochran> This should all land this morning.
[10:45:00 EDT(-0400)] <ecochran> I'm heading into the office shortly
[10:45:31 EDT(-0400)] <Justin_o> oh okay.... that's good... let me know if you need anything from me, or need me to do anything to help.
[10:48:26 EDT(-0400)] <ecochran> Justin_o: nothing that I can think of, except that we'll need to test the *!%$& out of all of our components post-reorg
[10:49:34 EDT(-0400)] <Justin_o> yep... I'll probably need fj4000 and you to look at all of the components to make sure that none of the styling is broken
[10:49:58 EDT(-0400)] <fj4000> ok
[10:50:05 EDT(-0400)] <Justin_o> thanks
[11:13:33 EDT(-0400)] <colinclark> so satisfying to check out something called "infusion" instead of "fluid-components"
[11:13:47 EDT(-0400)] <anastasiac> 
[11:32:40 EDT(-0400)] * ecochran (n=ecochran@adsl-70-137-183-216.dsl.snfc21.sbcglobal.net) has joined #fluid-work
[11:44:16 EDT(-0400)] <Justin_o> anastasiac, Bosmon: the selectbox.css file references bg_select.png as though it were in the same directory... it has now been seperated in our repository... should we put the png file in the css directory or change the css file (it came from jquery)
[11:44:25 EDT(-0400)] * EricDalquist (n=EricDalq@adsl-76-208-69-153.dsl.mdsnwi.sbcglobal.net) has joined #fluid-work
[11:45:21 EDT(-0400)] <anastasiac> Justin_o, good question
[11:55:52 EDT(-0400)] <Bosmon> Oh well
[11:55:54 EDT(-0400)] <Bosmon> That is a problem
[11:56:08 EDT(-0400)] <Bosmon> I mean, I found I needed to change lots of the Sakai sample CSS to account for our new directory structure
[11:56:16 EDT(-0400)] <Bosmon> But this is a worse problem than that....
[11:57:27 EDT(-0400)] <Justin_o> Bosmon: could there be a newer version of the plugin that may be more inline with our directory structure
[12:05:03 EDT(-0400)] * ecochran (n=ecochran@dhcp-169-229-212-69.LIPS.Berkeley.EDU) has joined #fluid-work
[12:05:14 EDT(-0400)] <Bosmon> No, I don't think it is maintained
[12:05:24 EDT(-0400)] <Justin_o> 
[12:05:30 EDT(-0400)] <Bosmon> I mean, what random accident would move them over to our directory structure anyway 
[12:05:49 EDT(-0400)] <Justin_o> that would be random, but i mean using a seperate directory for images
[12:07:27 EDT(-0400)] * apetro (n=apetro@wsip-98-174-242-39.ph.ph.cox.net) has joined #fluid-work
[12:18:11 EDT(-0400)] <Justin_o> anastasiac, Bosmon, fj4000, colinclark: so what do you think about for the selectbox plugin that we don't seperate the files into subdirectories but just leave them all as children of the selectbox directory
[12:19:36 EDT(-0400)] <colinclark> Justin_o: I think that's probably fine. Beats having to patch their CSS files just to fit into our directory structure.
[12:25:19 EDT(-0400)] <Bosmon> Justin_o: THE KING, are you there?
[12:25:41 EDT(-0400)] <Justin_o> sorry just went to grab lunch
[12:25:59 EDT(-0400)] <Bosmon> Did you make a JIRA for FCKEditor?
[12:26:46 EDT(-0400)] <Justin_o> I didn't, thought it was caused by the restructuring
[12:26:56 EDT(-0400)] <Bosmon> Well, it was
[12:27:00 EDT(-0400)] <Bosmon>
[12:27:47 EDT(-0400)] <Justin_o> I suppose you could file it against that with a good comment on the commit... unless there are objections.. or it is more than just because it was moved
[12:27:58 EDT(-0400)] <Bosmon> Well, it is because it was moved
[12:28:08 EDT(-0400)] <Bosmon> But I am wondering whether fixing it actually requires a change to the framework....
[12:28:16 EDT(-0400)] <Bosmon> Or, "arguably", a change to the framework
[12:28:28 EDT(-0400)] <Justin_o> well... that may be a different story...
[12:28:40 EDT(-0400)] <Justin_o> so why does the framework need to change
[12:28:47 EDT(-0400)] <Bosmon> The relative path to fckeditor is actually encoded inside the file InlineEditIntegrations.js, I now see
[12:29:12 EDT(-0400)] <Bosmon> I guess we could say this is still just an effect of the refactoring
[12:29:34 EDT(-0400)] <Bosmon> But it brings up the issue that this is some configuration that people need to be aware of, if they want to host FCKEditor from elsewhere
[12:29:36 EDT(-0400)] <Justin_o> i think so, if it is just a path change
[12:29:40 EDT(-0400)] <Bosmon> I guess that is just a documentation issue
[12:29:55 EDT(-0400)] <Justin_o> Bosmon: so it isn't an option?
[12:30:06 EDT(-0400)] <Bosmon> I think it is an option
[12:30:09 EDT(-0400)] <Bosmon> I guess I will test this now
[12:30:22 EDT(-0400)] <Justin_o> okay
[12:30:42 EDT(-0400)] <anastasiac> Bosmon, Justin_o: I think we should update the path to reflect the new structure and file that change under 2401, and if it's not an option, we should file a separate JIRA for that issue
[12:30:55 EDT(-0400)] <anastasiac> sound reasonable?
[12:31:18 EDT(-0400)] <Justin_o> anastasiac: sounds reasonable to me
[12:32:10 EDT(-0400)] <anastasiac> so, Justin_o, I"m trying to catch up. Where are we at? What files still need to be updated, that I can help with?
[12:32:22 EDT(-0400)] <Bosmon> OK
[12:32:27 EDT(-0400)] <Bosmon> The issue is a little worse than this actually
[12:32:33 EDT(-0400)] <Bosmon> I think it might require a framework change....
[12:32:51 EDT(-0400)] <Bosmon> Well
[12:32:52 EDT(-0400)] <Justin_o>
[12:32:53 EDT(-0400)] <Bosmon> Let me think
[12:32:57 EDT(-0400)] <Justin_o> okay
[12:33:06 EDT(-0400)] <Bosmon> I have demonstrated at least that the option is successfully configurable
[12:33:14 EDT(-0400)]
[12:33:23 EDT(-0400)] <Bosmon> So, if you pass this in, in the options for the inlineEdit control, it now works
[12:33:41 EDT(-0400)] <Bosmon> The issue is that we need to make sure that the user doesn't need to specify this, if they are just using the path from our distribution
[12:33:50 EDT(-0400)] <Bosmon> At least, I think we would want to make sure of this?
[12:34:03 EDT(-0400)] <Bosmon> But if we did want to make sure of that, the issue is that the relative path offset is now "unknown"
[12:34:03 EDT(-0400)] <anastasiac> Bosmon, will our defaults system not work for this?
[12:34:10 EDT(-0400)] <Bosmon> anastasiac: listen
[12:34:14 EDT(-0400)] <Justin_o> anastasiac: Bosmon is looking at fck editor issue, there was a problem with the references in the selectbox plugin, so i'm going to remove the subdirectories from it, then we'll have to update the files that use it... also fj4000 was wondering why there is a lib directory in the standalone-demos
[12:34:32 EDT(-0400)] <Bosmon> The issue is that each new "user" of the FCKEditor codebase is at a different relative path
[12:35:01 EDT(-0400)] <Bosmon> Now, the path that you need to configure the load of FCKEditor from is relative to the html which forms the target sample, and not relative to any js file relative to the framework
[12:35:08 EDT(-0400)] <anastasiac> Bosmon, what do you mean when you say "user"?
[12:35:15 EDT(-0400)] <Bosmon> I mean, the person trying to use the component
[12:35:36 EDT(-0400)] <anastasiac> hm
[12:36:02 EDT(-0400)] * lessthanzero (n=FatalRem@CPE001ff342457c-CM001ac352aefc.cpe.net.cable.rogers.com) has joined #fluid-work
[12:36:03 EDT(-0400)] <Bosmon> I still have my thinking cap on.....
[12:36:09 EDT(-0400)] <Bosmon> But perhaps there is actually not a way out of this
[12:36:12 EDT(-0400)] <anastasiac> fj4000, there is a lib dir in standalone demos because one of the standalone demos uses jquery.tabs.js
[12:36:32 EDT(-0400)] <Bosmon> A JS file generally does not know its own location
[12:36:36 EDT(-0400)] <Bosmon> Unless we pull the "Dan Trick"
[12:36:44 EDT(-0400)] <Bosmon> Which is not something we are going to put into the framework at this point
[12:36:47 EDT(-0400)] <anastasiac> and what is the "Dan Trick"?
[12:37:08 EDT(-0400)] <Bosmon> The Dan Trick, of looking through your own <head> material to find a reference to something which looks like yourself
[12:37:17 EDT(-0400)] <Bosmon> Assuming, of course, you were even included in <head> in the first place....
[12:38:02 EDT(-0400)] <Bosmon> So.... I am struggling to see how we can now give this path a sensible default value....
[12:40:55 EDT(-0400)] <colinclark> Bosmon: I think there's no way out of this, and that the Dan Trick is probably overkill here.
[12:41:37 EDT(-0400)] <colinclark> Paths are inevitably relative to the HTML. This is something we also face in Uploader, in terms of allowing the user to override the paths to the Flash object and some images that the Flash object needs.
[12:41:46 EDT(-0400)] <fj4000> anastasiac: yes, but I was curious if it couldnt simply be factored into the existing jquery lib material
[12:42:01 EDT(-0400)] <fj4000> since it seems like thats what the contents are - jquery ui stuff
[12:42:12 EDT(-0400)] <fj4000> maybe its not though
[12:42:17 EDT(-0400)] <anastasiac> fj4000, I think the existing jquery lib material is the stuff that our core needs
[12:42:24 EDT(-0400)] <anastasiac> the lib in the demos is the stuff that the demos need
[12:43:56 EDT(-0400)] <colinclark> anastasiac, fj4000: That's correct.
[12:44:37 EDT(-0400)] * apetro_ (n=apetro@wsip-98-174-242-39.ph.ph.cox.net) has joined #fluid-work
[12:44:42 EDT(-0400)] <colinclark> None of our core components and framework depend on jquery.ui.tabs, so we shouldn't push that file up to the top level.
[12:47:13 EDT(-0400)] <fj4000> gotcha
[12:58:12 EDT(-0400)] <Justin_o> anastasiac: I think we're done with the restructuring of svn... except maybe for that fck thing that Bosmon was working on
[12:58:29 EDT(-0400)] <anastasiac> Justin_o - excellent!
[13:02:01 EDT(-0400)] <Bosmon> OK
[13:02:07 EDT(-0400)] <Bosmon> I have just committed a fix for the FCK thing
[13:02:10 EDT(-0400)] <Bosmon> Along the lines we have decided
[13:02:19 EDT(-0400)] <Bosmon> I just want to float one last-minutes suggestion -
[13:02:26 EDT(-0400)] <Bosmon> How about the use of "external", rather than "lib"?
[13:22:42 EDT(-0400)] <michelled> I'm ok with that. what do you think anastasiac, colinclark?
[13:23:22 EDT(-0400)] <anastasiac> hm... "external" is longer, but more explicit...
[13:24:08 EDT(-0400)] <lessthanzero> can I check the svn logs w/out a checkout?
[13:30:57 EDT(-0400)] <Justin_o> ecochran: just wondering if you were able to get the uploader class name changes in yet... or how long you think it would take?
[13:32:44 EDT(-0400)] <ecochran> Justin_o: I've done all the selector styles. It took a couple of hours. I'm now merging with the new directory structures (another 1/2 hours). Then I'm onto the styles, which I think will also take a couple of hours. It's a big component.
[13:33:05 EDT(-0400)] <colinclark> lessthanzero: Yep, you can use URLs.
[13:33:08 EDT(-0400)] <colinclark> So, for example:
[13:33:15 EDT(-0400)] <lessthanzero> colinclark: yep, just got the answer in #svn
[13:33:15 EDT(-0400)] <lessthanzero> 
[13:33:18 EDT(-0400)] <colinclark> cool
[13:33:20 EDT(-0400)] <lessthanzero> thanks.
[13:33:41 EDT(-0400)] <colinclark> Bosmon: At this point, I kind of feel like it's up to anastasiac and Justin_o, who have sunk a lot of time into restructuring.
[13:33:53 EDT(-0400)] <lessthanzero> colinclark: also, seems like those patches did get applied, were just allied to both. but I'm looking at the logs now, and comparing with JIRA. there are some patches missing. I'm rounding them up.
[13:33:55 EDT(-0400)] <michelled> fj4000: I'm a bit heads down with this build script. any chance you can handle the commits lessthanzero needs?
[13:34:07 EDT(-0400)] <anastasiac> I wonder if external might be confused with the notion of svn externals?
[13:34:09 EDT(-0400)] <fj4000> i am at the moment
[13:34:10 EDT(-0400)] <michelled> ah, looks like you may not need to
[13:34:11 EDT(-0400)] <colinclark> lessthanzero: Okay, great.
[13:34:12 EDT(-0400)] <fj4000> reviewing a few
[13:34:17 EDT(-0400)] <michelled> cool
[13:34:17 EDT(-0400)] <anastasiac> also, we'd now have to go back and update all of the files again
[13:34:27 EDT(-0400)] <lessthanzero> fj4000: tu es moi hero.
[13:34:38 EDT(-0400)] <anastasiac> that would be "mon hero"
[13:34:38 EDT(-0400)] <fj4000> lessthanzero: just reviewing 188 + 189
[13:34:47 EDT(-0400)] <fj4000> sorry if its a little late
[13:34:55 EDT(-0400)] <fj4000> can I safely commit them?
[13:35:01 EDT(-0400)] <lessthanzero> fj4000: yes sir.
[13:35:19 EDT(-0400)] <lessthanzero> fj4000: I am finding a few patches that were straight up missed, I'm organizing them now. Bsaically JIRA vs. svn log.
[13:35:24 EDT(-0400)] <Bosmon> Well, it would be very quick to change the name
[13:35:24 EDT(-0400)] <fj4000> ok
[13:35:33 EDT(-0400)] <Bosmon> It would be two renames, and a global search and replace
[13:35:44 EDT(-0400)] <Justin_o> Bosmon: what were the two renames
[13:35:52 EDT(-0400)] <ecochran> Justin_o: is that what you were looking for?
[13:35:54 EDT(-0400)] <anastasiac> Bosmon, it would be time consuming to test the global search and replace
[13:36:20 EDT(-0400)] <anastasiac> actually, three renames
[13:36:20 EDT(-0400)] <Justin_o> ecochran: yes sorry... i replied to you in my head, but not in irc... got caught up reading the channel... sorry
[13:36:26 EDT(-0400)] <Bosmon> ok, 3
[13:36:30 EDT(-0400)] <anastasiac>
[13:36:36 EDT(-0400)] <ecochran> Justin_o: understandable
[13:36:36 EDT(-0400)] <Bosmon> Do we have 3 things called "lib" now?
[13:36:52 EDT(-0400)] <anastasiac> Bosmon, yes: in the core, in standalone-demo, and in tests
[13:37:05 EDT(-0400)] <anastasiac> by core I mean in webapp
[13:37:20 EDT(-0400)] <fj4000> lessthanzero: 188 seems to have some conflicts
[13:37:24 EDT(-0400)] <fj4000> can we review them?
[13:37:30 EDT(-0400)] <lessthanzero> yes, hit me on im?
[13:37:37 EDT(-0400)] <fj4000> ok
[13:37:40 EDT(-0400)] <Justin_o> there is one other thing we have to move, the pager starting point example isn't ready... we need to put it somewhere else... any suggestions
[13:37:42 EDT(-0400)] <fj4000> if you roll that way
[13:38:12 EDT(-0400)] * anastasiac checks what the Pager file looks like
[13:38:35 EDT(-0400)] * anastasiac also wonders about the suggested new name of starting-points: quick-start-examples
[13:38:52 EDT(-0400)] <Justin_o> forgot about that one, thanks for bringing it up
[13:40:08 EDT(-0400)] <anastasiac> I think the Pager starting point/quick start example could probably just be deleted. There isn't much there, and I have a backup
[13:40:17 EDT(-0400)] <Justin_o> okay
[13:40:24 EDT(-0400)] <anastasiac> fj4000, what do you think about trashing the Pager springboard for now?
[13:40:31 EDT(-0400)] <anastasiac> and reconstructing it when we have time to do it right?
[13:41:28 EDT(-0400)] <fj4000> anastasiac: yes
[13:41:31 EDT(-0400)] <anastasiac> laurelw, what do you think about renaming "starting-points" to "quick-start-examples"? You were part of the original name change discussion...
[13:42:00 EDT(-0400)] <fj4000> anastasiac: ^ sounds better to me, for what its worth
[13:42:15 EDT(-0400)] <anastasiac> fj4000, cool
[13:42:27 EDT(-0400)] <laurelw> anastasiac: think we should pick one!
[13:42:43 EDT(-0400)] <laurelw> anastasiac: quick-start also sounds good
[13:43:04 EDT(-0400)] <laurelw> anastasiac: whoops I meant quick-start-examples
[13:43:10 EDT(-0400)] <anastasiac>
[13:43:28 EDT(-0400)] <laurelw> anastasiac: at least it is clear
[13:43:48 EDT(-0400)] <anastasiac> yes, laurelw, that was the thinking
[13:44:09 EDT(-0400)] <colinclark> Bosmon: Quick question?
[13:44:32 EDT(-0400)] <ecochran> fj4000: Do you know if the Uploader the only component using the progressive enhancement stuff?
[13:44:49 EDT(-0400)] <fj4000> I think it is
[13:45:04 EDT(-0400)] <ecochran> I noticed that you have some stuff in fss.layout.css
[13:45:38 EDT(-0400)] <colinclark> I'm linting Fluid.js... In fluid.setLogging(), you have a conditional that looks like this:
[13:45:43 EDT(-0400)] <colinclark> if (typeof enabled == "boolean") {
[13:45:51 EDT(-0400)] <Bosmon> ah
[13:45:54 EDT(-0400)] <colinclark> Any reason it shouldn't be ===?
[13:45:59 EDT(-0400)] <Bosmon> No, no reason
[13:46:02 EDT(-0400)] <colinclark> k, got it
[13:46:10 EDT(-0400)] <ecochran> fj4000: your comment in fss.layout.css indicates that maybe the base style would get changed... which I don't think is what you intend?
[13:46:13 EDT(-0400)] <Bosmon> That was probably written Very Long Ago...
[13:46:29 EDT(-0400)] <colinclark> Bosmon: Yep, that's what I figured
[13:46:41 EDT(-0400)] <colinclark> Just wanted to double check.
[13:46:50 EDT(-0400)] <ecochran> fj4000: I'm going to go ahead and change the styles to fl-ProgEnhance-basic and fl-ProgEnhance-enhanced per our conversation
[13:46:58 EDT(-0400)] <fj4000> ok
[13:47:45 EDT(-0400)] <Bosmon> I guess I could try to "update Reorderer class names"
[13:47:49 EDT(-0400)] <Bosmon> But it seems a bit daunting....
[13:48:01 EDT(-0400)] <Justin_o> Bosmon: thanks
[13:48:50 EDT(-0400)] <Justin_o> Justin_o: i'm going to try to update the inline-edit ones, without totally breaking the component.
[13:48:51 EDT(-0400)] <Bosmon> Especially since I have never been 100% clear whether some of these were considered to be visual or not
[13:49:06 EDT(-0400)] <Bosmon> Justin_o: You are talking to yourself?
[13:49:18 EDT(-0400)] <Bosmon> So, I guess all of these classes like "orderable-default", etc.
[13:49:23 EDT(-0400)] <Justin_o> Bosmon: i don't know how i did that... but am laughing about it now
[13:49:41 EDT(-0400)] <Bosmon> These should go to something like fl-orderable-default?
[13:49:43 EDT(-0400)] <Bosmon> Is that sufficient?
[13:49:52 EDT(-0400)] <Justin_o> sounds right, but let me double check
[13:49:57 EDT(-0400)] <Bosmon> Or does "reorderer" need to go in there somewhere
[13:50:12 EDT(-0400)] <Justin_o> http://issues.fluidproject.org/browse/FLUID-2372
[13:50:16 EDT(-0400)] <Justin_o> that has some examples
[13:51:07 EDT(-0400)] <colinclark> fj4000 made some documentation about the class name conventions.
[13:59:36 EDT(-0400)] <Bosmon> Is he going to be coming back?
[13:59:40 EDT(-0400)] <Bosmon> Yes, I am reading that JIRA
[14:02:45 EDT(-0400)] <anastasiac> Bosmon, colinclark, ecochran, fj4000: Jusin_o, michelled and I have been having a verbal conversation about naming conventions for component css files
[14:02:55 EDT(-0400)] <colinclark> ok
[14:03:03 EDT(-0400)] <anastasiac> I'll summarize what we've come up with so far, then open the floor for other input:
[14:03:34 EDT(-0400)] <anastasiac> I think we should name the component-specific css files to be consistent with the component-specific js and component-specific html
[14:03:43 EDT(-0400)] <anastasiac> i.e. ComponentName.ext
[14:03:53 EDT(-0400)] <anastasiac> so InlineEdit.css, UIOptions.css, etc
[14:04:18 EDT(-0400)] <anastasiac> I don't think we need the fluid.components. prefix if it lives inside component/foo/css folder
[14:04:28 EDT(-0400)] <anastasiac> we don't have fluid.components.reorderer.js
[14:04:47 EDT(-0400)] <anastasiac> I'd like fj4000's thoughts on the heads-up camel case convention
[14:05:00 EDT(-0400)] <anastasiac> michelled thinks maybe camel case in CSS file names is not at all common
[14:05:34 EDT(-0400)] <anastasiac> finally, any component-specific styles should be removed from fss-specific files and moved into their component's css folder
[14:05:39 EDT(-0400)] * anastasiac is done now
[14:05:54 EDT(-0400)] <anastasiac> michelled, Justin_o: did I miss anything?
[14:06:04 EDT(-0400)] <Justin_o> i think you got it all
[14:07:07 EDT(-0400)] <anastasiac> Bosmon, fj4000, colinclark, ecochran: any thoughts?
[14:07:45 EDT(-0400)] <Bosmon> Well..... that seems broadly reasonable
[14:07:49 EDT(-0400)] <Bosmon> What does fj4000 think?
[14:07:54 EDT(-0400)] <Bosmon> WAKE UP, O FARBER
[14:07:58 EDT(-0400)] <anastasiac> fj4000 is on a call right now
[14:11:55 EDT(-0400)] <ecochran> anastasiac: sorry, stepped out for a moment
[14:12:03 EDT(-0400)] <ecochran> anastasiac: that makes much sense
[14:12:16 EDT(-0400)] <ecochran> not sure about the casing ...
[14:12:24 EDT(-0400)] * athena (n=athena@dhcp128036158022.central.yale.edu) has joined #fluid-work
[14:12:28 EDT(-0400)] <anastasiac> yeah, neither am I, really
[14:13:33 EDT(-0400)] <ecochran> anastasiac: I guess I'm fine with the initial cap and the camelCase
[14:14:13 EDT(-0400)] <ecochran> anastasiac: I guess we should wait for the indomitable fj4000 before passing judgement!
[14:16:53 EDT(-0400)] * fj4000 is reading....and wondering why Bosmon is yelling at me
[14:16:55 EDT(-0400)] <colinclark> I have no real opinion about the subject. I'll defer to fj4000.
[14:18:33 EDT(-0400)] <colinclark> anastasiac: Just to confirm, this is just an issue of what to name the .css files for a component?
[14:18:54 EDT(-0400)] <fj4000> well, as for camel case, it sounds reasonable from a consistency point of view
[14:19:07 EDT(-0400)] <michelled> sounds good
[14:19:10 EDT(-0400)] <fj4000> now im wondering about the '.' then
[14:19:19 EDT(-0400)] <fj4000> should we ditch those and go for the '-' instead?
[14:19:25 EDT(-0400)] <anastasiac> which '.'??
[14:19:34 EDT(-0400)] <fj4000> fss.something.css
[14:19:37 EDT(-0400)] <fj4000> the periods
[14:19:41 EDT(-0400)] <michelled> so a component would have UIOptions.js UIOptions.html and UIOptions.css
[14:19:46 EDT(-0400)] <anastasiac> no - this is not for the fss file names
[14:19:47 EDT(-0400)] <fj4000> oh
[14:19:49 EDT(-0400)] <fj4000> I see
[14:19:59 EDT(-0400)] <anastasiac> only the component-specific css files
[14:20:03 EDT(-0400)] <michelled> but it's a good question about the fss files
[14:20:12 EDT(-0400)] <anastasiac> yes, michelled, true
[14:21:21 EDT(-0400)] * fj4000 needs to think about 10 more quesitons raised by anastasiac
[14:22:44 EDT(-0400)] <ecochran> fj4000: is Uploader getting fss themes now?
[14:24:02 EDT(-0400)] <fj4000> I think so
[14:24:07 EDT(-0400)] <fj4000> Val was helping with that
[14:24:15 EDT(-0400)] <fj4000> I have to review her patches
[14:24:20 EDT(-0400)] <ecochran> fj4000: I was surprised by it
[14:24:24 EDT(-0400)] <ecochran> np
[14:24:29 EDT(-0400)] <ecochran> just surprised
[14:24:47 EDT(-0400)] <ecochran> seems like a bit much to be adding right before 1.0
[14:25:26 EDT(-0400)] <ecochran> fj4000: what just showed up in Uploader.html uses the "<link type="text/css" rel="stylesheet" href="../../../framework/fss/css/fss.reset.css"></link>" syntax
[14:25:43 EDT(-0400)] <ecochran> I had been using the <link type="text/css" rel="stylesheet" href="../../../framework/fss/css/fss.reset.css" /> syntax
[14:25:54 EDT(-0400)] <ecochran> is there a preference?
[14:26:23 EDT(-0400)] <ecochran> also one of the links is unclosed
[14:26:43 EDT(-0400)] <ecochran> this feels unfinished, so I'm a little worried about it
[14:27:50 EDT(-0400)] <ecochran> fj4000: ^
[14:31:05 EDT(-0400)] <fj4000> sorry ecochran
[14:31:10 EDT(-0400)] <anastasiac> ecochran, sorry about the silence
[14:31:17 EDT(-0400)] <anastasiac> we're having a verbal discussion...
[14:31:19 EDT(-0400)] <fj4000> im just trying to figure out some stuff re: structure
[14:31:31 EDT(-0400)] <ecochran> yep
[14:31:31 EDT(-0400)] <fj4000> I think we already solved this issue, but I need to be sure
[14:31:43 EDT(-0400)] <ecochran> which issue?
[14:32:04 EDT(-0400)] <fj4000> the component css setup
[14:32:27 EDT(-0400)] <fj4000> oh, now I just read your other question
[14:32:56 EDT(-0400)] <fj4000> <link> in xhtml is self closing
[14:32:58 EDT(-0400)] <fj4000> I believe
[14:33:02 EDT(-0400)] <ecochran> yep
[14:34:47 EDT(-0400)] <ecochran> fj4000: the biggest question is whether this should be coming into the Uploader at this late date
[14:35:07 EDT(-0400)] <michelled> ecochran: what is being introduced?
[14:35:13 EDT(-0400)] <michelled> is it not just name changes?
[14:35:17 EDT(-0400)] <fj4000> thats what I was wondering
[14:35:42 EDT(-0400)] <ecochran> I just did an update on the Uploader and a bunch of fss css files where added to the head
[14:35:57 EDT(-0400)] <ecochran> these seem to have come in on Jacob's last commit
[14:36:12 EDT(-0400)] <fj4000> I could have started something but not finished it
[14:36:39 EDT(-0400)] <ecochran> fj4000: OK, I have a big commit that I need to do... can I delete these for now?
[14:36:53 EDT(-0400)] <fj4000> yes
[14:37:08 EDT(-0400)] <fj4000> I think so - my changes should be undone
[14:37:23 EDT(-0400)] <ecochran> fj4000: thanks... I'll make a note to myself to look at this later
[14:37:31 EDT(-0400)] <fj4000> i've been trying to fss - ify the uploader, and I ran into issues
[14:37:34 EDT(-0400)] <fj4000> hence Vals work
[14:37:54 EDT(-0400)] <ecochran> fj4000: but this is not for 1.0 is it?
[14:38:53 EDT(-0400)] * michelled is listening to fj4000 and anastasiac trying to figure out if the component css is part of fss or not.
[14:39:25 EDT(-0400)] <michelled> one theory is that individual component css files should be stand alone - not require fss
[14:39:40 EDT(-0400)] <michelled> yet we have templates that depend on fss for general styling
[14:39:43 EDT(-0400)] <ecochran> fj4000, anastasiac, michelled, Justin_o: I just checked in a big commit with the first half of my changes for FLUID-2408... all tests work, everything seems to be working
[14:39:53 EDT(-0400)] <anastasiac> the question is: is it ok for components to actually be dependent on fss
[14:39:55 EDT(-0400)] <michelled> thanks ecochran
[14:40:04 EDT(-0400)] <fj4000> i always thought they would be dependent
[14:40:16 EDT(-0400)] <fj4000> but now
[14:40:19 EDT(-0400)] <fj4000> im not sure at all
[14:40:35 EDT(-0400)] <fj4000> ecochran, what do yo uthink?
[14:41:37 EDT(-0400)] * ecochran_ (n=ecochran@dwin-wlan-89.AirBears.Berkeley.EDU) has joined #fluid-work
[14:47:20 EDT(-0400)] <fj4000> ecochran, Bosmon, et al: ok, so to bring everyone up to speed with how the conversation is going
[14:47:51 EDT(-0400)] <fj4000> some components have their own css file and html template file
[14:48:07 EDT(-0400)] <fj4000> those files should be built with the assumption the rest of the FSS will be available
[14:48:32 EDT(-0400)] <fj4000> and therefore should take advantage of anything already written in FSS proper (reset, layout, etc)
[14:53:00 EDT(-0400)] * anastasiac and fj4000 are still "discussing" the issue
[14:53:42 EDT(-0400)] <Bosmon> I see....
[14:55:09 EDT(-0400)] <Bosmon> I guess I am not completely clear on how the FSS supports component design
[14:55:44 EDT(-0400)] <Bosmon> If a component relies on particular css and html files, and those, in turn, cannot function correctly without the FSS, is this necessarily a desirable thing?
[14:55:56 EDT(-0400)] <Bosmon> Or indeed, something we should be trying to determine 1 day before a final release?
[14:56:14 EDT(-0400)] <Bosmon> We already ruled out making a single renaming change
[14:57:13 EDT(-0400)] <anastasiac> Bosmon: these are the questions that we are in the middle of discussion
[14:57:41 EDT(-0400)] <anastasiac> the status of the discussion right now is:
[14:57:57 EDT(-0400)] <anastasiac> right now, components are dependent on the FSS
[14:58:06 EDT(-0400)] <Bosmon> In what ways?
[14:58:07 EDT(-0400)] <fj4000> actually
[14:58:12 EDT(-0400)] <fj4000> right now - only SOME are
[14:58:16 EDT(-0400)] <anastasiac> right
[14:58:24 EDT(-0400)] <fj4000> Uploader, for example, is still being re-thought
[14:58:28 EDT(-0400)] <Bosmon> glarg
[14:58:28 EDT(-0400)] <fj4000> but nothing has changed there
[14:58:39 EDT(-0400)] <anastasiac> UIOptions uses FSS for layout of it's appearance
[14:58:49 EDT(-0400)] <fj4000> eactly - thats the other extreme
[14:59:01 EDT(-0400)] <fj4000> where UI Options is entirely done in FSS
[14:59:21 EDT(-0400)] <anastasiac> If we wanted to try to ensure that the visual appearance of the components was NOT dependent on the FSS, that would be way too much work for this stage of the game
[15:00:06 EDT(-0400)] <Bosmon> Well, that seems reasonable then
[15:00:16 EDT(-0400)] <anastasiac> my questions now are: what styles should exist in ..../webapp/components/foo/css/component.css, and what should stay in framework/fss/css/fss.*.css
[15:00:19 EDT(-0400)] <Bosmon> The only way we can avoid changing the status quo is to avoid making a decision
[15:00:47 EDT(-0400)] <Bosmon> Exactly those styles which are required for those components which do not depend on the FSS
[15:00:55 EDT(-0400)] <anastasiac> so Bosmon raises a good point
[15:01:12 EDT(-0400)] <anastasiac> maybe at this point, we should not be considering moving styles from one file to another
[15:01:29 EDT(-0400)] <anastasiac> as jf4000 pointed out, things work now
[15:01:40 EDT(-0400)] <anastasiac> and I often say "if it ain't broke, don't fix it"
[15:01:54 EDT(-0400)] <anastasiac> I do think that we want to address this at some point
[15:02:07 EDT(-0400)] <Justin_o> i agree... let's just get the name changes squared away, and leave this for another release
[15:02:14 EDT(-0400)] <anastasiac> but I'm not sure that our current svn restructuring requires this level of restructuring
[15:02:25 EDT(-0400)] <fj4000> absolutely - but this must be addressed sooner rather than later
[15:02:31 EDT(-0400)] <fj4000> as templates get only more complex
[15:02:52 EDT(-0400)] <fj4000> and interactions get more involved - we need to ensure we dont have a huge amount of refactoring ahead of us
[15:02:57 EDT(-0400)] <anastasiac> the remaining question: right now, some css files in components/foo/css are not called foo.css, they're called fluid.componetns/foo.css, or fss.componetns.foo.css
[15:03:00 EDT(-0400)] <fj4000> at least on the css side of things
[15:03:51 EDT(-0400)] <fj4000> ok
[15:03:54 EDT(-0400)] <fj4000> this makes sense
[15:04:06 EDT(-0400)] <fj4000> there shouldnt be the "fss.components.*." part
[15:04:13 EDT(-0400)] <fj4000> since they are not the FSS system
[15:04:19 EDT(-0400)] <fj4000> they are satellite files
[15:04:27 EDT(-0400)] <fj4000> relying on FSS, not part of it
[15:05:17 EDT(-0400)] <anastasiac> Justin_o, Bosmon, ecochran: are you ok with renaming these component-specific css files to follow the component.css naming convention?
[15:05:25 EDT(-0400)] <anastasiac> michelled: you too ^
[15:06:20 EDT(-0400)] <michelled> I'm happy with it
[15:06:22 EDT(-0400)] <Justin_o> anastasiac: i like that idea
[15:06:45 EDT(-0400)] <fj4000> makes sense as we're pulling more fss data OUT of them, the less they should have "fss" in their name
[15:07:52 EDT(-0400)] <ecochran_> anastasiac: I like it.
[15:11:54 EDT(-0400)] <anastasiac> ok, I'll update the inline edit files
[15:14:07 EDT(-0400)] <Bosmon> anastasiac: Can you be clear about what that means?
[15:15:22 EDT(-0400)] <anastasiac> Bosmon: what which means?
[15:16:13 EDT(-0400)] * ecochran_ (n=ecochran@dwin-wlan-89.AirBears.Berkeley.EDU) has joined #fluid-work
[15:16:13 EDT(-0400)] * apetro (n=apetro@wsip-98-174-242-39.ph.ph.cox.net) has joined #fluid-work
[15:16:13 EDT(-0400)] * EricDalquist (n=EricDalq@adsl-76-208-69-153.dsl.mdsnwi.sbcglobal.net) has joined #fluid-work
[15:16:13 EDT(-0400)] * laurelw (n=Laurel@142.150.154.178) has joined #fluid-work
[15:18:04 EDT(-0400)] * fj4000 (n=Jacob@142.150.154.106) has joined #fluid-work
[15:23:41 EDT(-0400)] <Bosmon> What does it mean to be "renaming these component-specific css files to follow the component.css naming convention?" ?
[15:34:57 EDT(-0400)] <michelled> it means that pager's css file would be named Pager.css instead of fluid.components.pager.css
[15:35:50 EDT(-0400)] * laurelw (n=Laurel@142.150.154.178) has left #fluid-work
[15:36:54 EDT(-0400)] <ecochran_> fj4000: I think that you should resend the email that you sent out a little while back with the selector renaming rules. Just to remind folks.
[15:37:50 EDT(-0400)] <anastasiac> thanks, michelled
[15:38:00 EDT(-0400)] <anastasiac> Bosmon: does what michelled said make sense?
[15:38:00 EDT(-0400)] <ecochran_> fj4000: also, in css, quotes around uri paths or not? I have both ways in the Uploader.css. Either is valid, I just think that we should standardize.
[15:38:48 EDT(-0400)] <Bosmon> anastasiac: Yes, that makes sense - is there any other decision we need to make?
[15:39:41 EDT(-0400)] <michelled> we need to decide whether to rename the fss base classes
[15:40:05 EDT(-0400)] <anastasiac> michelled meant the file names
[15:40:11 EDT(-0400)] <michelled> yes, I mean file names
[15:40:12 EDT(-0400)] <anastasiac> right now, they're fss.themes.hs.css
[15:40:43 EDT(-0400)] <michelled> in 0.8 they were named fluid.reset.css for example
[15:40:49 EDT(-0400)] <michelled> right now it's fss.reset.css
[15:40:54 EDT(-0400)] <anastasiac> the question is: should the be heads-up camel case like most other Fluid files?
[15:40:59 EDT(-0400)] <anastasiac> FSSThemesHC.css
[15:41:03 EDT(-0400)] <anastasiac> FSSReset.css
[15:41:15 EDT(-0400)] <Bosmon> I don't think it is worth becoming obsessed about case
[15:41:17 EDT(-0400)] <michelled> I don't like the '.' in the name
[15:41:19 EDT(-0400)] <Bosmon> They should just stay the way they are
[15:41:32 EDT(-0400)] <michelled> it's well known that after a '.' comes the extention
[15:41:38 EDT(-0400)] <Bosmon> We have 1 day to do all of our release testing!!
[15:42:02 EDT(-0400)] <michelled> the release was post poned. we have more then 1 day to test!
[15:42:06 EDT(-0400)] <Bosmon> glarg
[15:42:21 EDT(-0400)] <Bosmon> I think all common systems are quite happy with multiple periods in a name
[15:42:24 EDT(-0400)] <Bosmon> Even Windows is
[15:42:25 EDT(-0400)] <Justin_o> Bosmon: testing is supposed to start tomorrow and end on friday
[15:42:42 EDT(-0400)] <ecochran_> Justin_o, anastasiac, fj4000: sorry to be carrying on two conversations as once but I just noticed an issue in the way that head was changed for all the automated tests. The jqUnit files are all grouped together in the head, which is cool. Except that it breaks the general rule that all css should be declared before all scripts.
[15:44:09 EDT(-0400)] <anastasiac> systems are happy with multiple periods, yes, but people are accustomed to conventions
[15:44:14 EDT(-0400)] <Justin_o> ecochran_: I suppose that is something we can address in 1.1 as it won't affect backwards compatiblity
[15:44:23 EDT(-0400)] <Justin_o> if you don't mind writing up a jira for it
[15:44:30 EDT(-0400)] <anastasiac> Personally, I prefer only one . before the extension, but I'm not looking forward to modifying all the files again
[15:44:46 EDT(-0400)] <Bosmon> We can do it all with search and replace
[15:45:58 EDT(-0400)] <michelled> I'd much rather a '-' then a '.'
[15:45:59 EDT(-0400)] <anastasiac> ok, we're just discussing the fact that we're doing the class name changes anyway,
[15:46:14 EDT(-0400)] <anastasiac> and we're going to have to touch lots of files to do that
[15:46:18 EDT(-0400)] <anastasiac> and test all those files anyway
[15:46:29 EDT(-0400)] <anastasiac> so now really is the time to change the file names
[15:46:30 EDT(-0400)] <ecochran_> Justin_o: will do
[15:46:33 EDT(-0400)] <michelled> I know this is a pain but I really don't want to change the names from 0.8 - 1.0 and then go and change them again
[15:46:54 EDT(-0400)] <anastasiac> michelled, I agree - we can't be making these changes after 1.0 release
[15:46:58 EDT(-0400)] <Justin_o> ecochran_: thanks
[15:46:59 EDT(-0400)] <anastasiac> either we change them now, or we don't change them
[15:47:11 EDT(-0400)] <Justin_o> anastasiac: i agree that statement
[15:47:22 EDT(-0400)] <anastasiac> and since we're changing file names anyway, we should make them to be what we want
[15:47:25 EDT(-0400)] <Justin_o> i don't mind either the "." or the "-" as long as it's consistent
[15:47:59 EDT(-0400)] <Justin_o> I think using only camel case is hard to read
[15:48:00 EDT(-0400)] <anastasiac> well, replacing the dots with dashes would actually make the files more consistent with the rest of our files
[15:48:13 EDT(-0400)] <anastasiac> nothing else uses multiple dots...
[15:48:26 EDT(-0400)] <Justin_o> okay... if there are no objections lets switch to "-"
[15:48:33 EDT(-0400)] <anastasiac> ok
[15:49:48 EDT(-0400)] * ecochran (n=ecochran@dhcp-169-229-212-15.LIPS.Berkeley.EDU) has joined #fluid-work
[15:49:51 EDT(-0400)] <ecochran> +1
[15:50:58 EDT(-0400)] <anastasiac> ok: I will rename the fss css files to use - instead of ., and I will also update the HTML files that reference them
[15:51:07 EDT(-0400)] <anastasiac> I will NOT be doing any class name changes with this change
[15:51:13 EDT(-0400)] <anastasiac> I'll let you know when it's committed
[15:54:24 EDT(-0400)] <Bosmon> Which of our other files use dashes?
[15:54:29 EDT(-0400)] <fj4000> ecochran, Bosmon, michelled, anastasiac, Justin_o: so the class name convention wiki article has been updated
[15:54:35 EDT(-0400)] <fj4000> http://wiki.fluidproject.org/pages/viewpage.action?pageId=5900972
[15:54:38 EDT(-0400)] <fj4000> just fyi
[15:54:58 EDT(-0400)] <Justin_o> fj4000: thanks
[16:07:13 EDT(-0400)] <anastasiac> Bosmon, Justin_o, fj4000, ecochran, michelled: I've committed the changes to the FSS file names. Please update before continuing with other work
[16:07:23 EDT(-0400)] <anastasiac> and please feel free to double-check my work!
[16:07:28 EDT(-0400)] <michelled> thanks
[16:07:39 EDT(-0400)] <ecochran> anastasiac: thx!
[16:07:52 EDT(-0400)] <Justin_o> anastasiac: thanks
[16:09:20 EDT(-0400)] <ecochran> anastasiac: I've got an interesting question for you, anyone can chime in, I'm struggling with whether the images that are currently in the Progress component are really Progress images or images used by the Uploader in it's integration of Progress... and does that matter with the organization of the files... I think that it does
[16:27:24 EDT(-0400)] <Bosmon> So, fj4000 - I would like to update the reorderer
[16:27:34 EDT(-0400)] <Bosmon> But I am not really clear what the desired result is
[16:27:37 EDT(-0400)] <fj4000>
[16:27:41 EDT(-0400)] <Bosmon> Do we want this word "orderable" gone from the selectors?
[16:27:56 EDT(-0400)] <fj4000> depends - what is the full class name now?
[16:28:04 EDT(-0400)] * anastasiac looks at progress images
[16:28:15 EDT(-0400)] <Bosmon> fluid.defaults("fluid.reorderer", {
[16:28:15 EDT(-0400)] <Bosmon> styles: {
[16:28:15 EDT(-0400)] <Bosmon> defaultStyle: "orderable-default",
[16:28:15 EDT(-0400)] <Bosmon> selected: "orderable-selected",
[16:28:15 EDT(-0400)] <Bosmon> dragging: "orderable-dragging",
[16:28:16 EDT(-0400)] <Bosmon> mouseDrag: "orderable-dragging",
[16:28:18 EDT(-0400)] <Bosmon> hover: "orderable-hover",
[16:28:20 EDT(-0400)] <Bosmon> dropMarker: "orderable-drop-marker",
[16:28:22 EDT(-0400)] <Bosmon> avatar: "orderable-avatar"
[16:28:24 EDT(-0400)] <Bosmon> },
[16:28:26 EDT(-0400)] <Bosmon> selectors: {
[16:28:28 EDT(-0400)] <Bosmon> dropWarning: ".drop-warning",
[16:28:30 EDT(-0400)] <Bosmon> movables: ".movables",
[16:28:32 EDT(-0400)] <Bosmon> grabHandle: "",
[16:28:34 EDT(-0400)] <Bosmon> stylisticOffset: ""
[16:28:36 EDT(-0400)] <Bosmon> },
[16:28:38 EDT(-0400)] <Bosmon> Here is the current defaults block
[16:28:49 EDT(-0400)] <fj4000> yes - it looks like orderable turns into flc-reorderer
[16:28:56 EDT(-0400)] <Bosmon> ok
[16:29:02 EDT(-0400)] <Bosmon> Are you sure about that?
[16:29:11 EDT(-0400)] <fj4000> anastasiac, Justin_o: ^
[16:29:12 EDT(-0400)] <Bosmon> Are you sure it does not turn into fl-reorderer?
[16:29:16 EDT(-0400)] <fj4000> yes
[16:29:28 EDT(-0400)] <fj4000> fl is reserved for FSS only for styling
[16:29:35 EDT(-0400)] <Bosmon> I see
[16:29:37 EDT(-0400)] <anastasiac> ecochran: if some component other than uploader wanted to use the progress, should they have to provide images, or would it be nice if progress came with images?
[16:29:49 EDT(-0400)] <Bosmon> But the JIRA specifically talks about "visual styling class names"
[16:29:51 EDT(-0400)] <Bosmon> Which these are
[16:30:00 EDT(-0400)] <Bosmon> At least, the first 7 of them are
[16:30:09 EDT(-0400)] <Bosmon> OK, the first 5
[16:30:14 EDT(-0400)] <fj4000> i see
[16:30:33 EDT(-0400)] <fj4000> so the ones in styles are for visual styling?
[16:30:41 EDT(-0400)] <anastasiac> Bosmon, fj4000: I believe any reorderer-related class names used for DOM identification should be prefixed with "flc-reorderer-"
[16:30:43 EDT(-0400)] <Bosmon> Yes
[16:30:50 EDT(-0400)] <fj4000> ok, so on that note
[16:30:52 EDT(-0400)] <anastasiac> classes for styling would be "fl-reorderer-"
[16:31:08 EDT(-0400)] <fj4000> ^
[16:31:16 EDT(-0400)] <fj4000> but I think there might be more here too
[16:31:21 EDT(-0400)] <Justin_o> Bosmon: additionally i think if the class is overloaded for both styling and selection it should be broken apart into two classes
[16:32:44 EDT(-0400)] <fj4000> drop-marker now turns into dropMarker i believe
[16:32:47 EDT(-0400)] <fj4000> to look like
[16:32:55 EDT(-0400)] <fj4000> fl-reorder-dropMarker
[16:33:09 EDT(-0400)] <fj4000> sorry fl-reorderer-dropMarker
[16:33:13 EDT(-0400)] * apetro- (n=apetro@wsip-98-174-242-39.ph.ph.cox.net) has joined #fluid-work
[16:33:28 EDT(-0400)] <Bosmon> ok
[16:33:39 EDT(-0400)] <Bosmon> So, .drop-warning -> flc-reorderer-dropWarning?
[16:33:50 EDT(-0400)] <fj4000> that looks right
[16:34:41 EDT(-0400)] <Bosmon> Now, in "reorderLayout"
[16:34:45 EDT(-0400)] <Bosmon> We have some outer defaults it uses
[16:35:10 EDT(-0400)] <Bosmon> I guess .columns -> flc-reorderer-columns - or do we distinguish down to varieties of components?
[16:35:16 EDT(-0400)] <Bosmon> flc-layoutReorderer-columns?
[16:35:30 EDT(-0400)] <Bosmon> https://source.fluidproject.org/svn/fluid/infusion/trunk/src/webapp/components/reorderer/js/LayoutReorderer.js
[16:35:35 EDT(-0400)] <fj4000> i dont think we have anything that specific
[16:35:40 EDT(-0400)] <Bosmon> ok
[16:36:08 EDT(-0400)] <fj4000> are columns ONLY in layout reorderer?
[16:36:12 EDT(-0400)] <Bosmon> yes
[16:37:31 EDT(-0400)] <anastasiac> I was going to say flc-layoutReorderer-columns, but I think I'm outvoted
[16:37:35 EDT(-0400)] <fj4000> I would think it should just be flc-reorderer-columns, but anastasiac, Justin_o - what do yo uthink?
[16:38:30 EDT(-0400)] <Justin_o> i think just reorderer as well
[16:39:35 EDT(-0400)] <Bosmon> ok
[16:47:58 EDT(-0400)] <fj4000> Bosmon, ecochran, Justin_o, michelled, anastasiac : could you just mention which components you fixing the class names ?
[16:48:11 EDT(-0400)] <anastasiac> right: I'm working on InlineEdit stuff
[16:48:21 EDT(-0400)] <anastasiac> michelled is not working on renaming
[16:48:27 EDT(-0400)] <Justin_o> I'm working on pager
[16:48:31 EDT(-0400)] <Bosmon> I am dealing with reorderer
[16:49:40 EDT(-0400)] <fj4000> thanks!
[16:49:52 EDT(-0400)] <fj4000> so I will work on progress
[16:50:20 EDT(-0400)] * colinclark (n=colin@bas2-toronto09-1176131209.dsl.bell.ca) has joined #fluid-work
[16:55:48 EDT(-0400)] <Bosmon> Not to re-invoke this ancient issue
[16:55:57 EDT(-0400)] <Bosmon> But I am not sure that a class of "fl-reorderer-default" is particularly clear
[16:56:04 EDT(-0400)] <fj4000>
[16:56:11 EDT(-0400)] * athena (n=athena@99.129.100.66) has joined #fluid-work
[16:56:17 EDT(-0400)] <fj4000> so, can you add more info to it?
[16:56:34 EDT(-0400)] <Bosmon> Well, it would possibly become fl-reorderer-orderable-default
[16:56:38 EDT(-0400)] <Bosmon> But is that really what we want?
[16:56:57 EDT(-0400)] <fj4000> is this about it not being in a state or "reorder"ish ness
[16:57:01 EDT(-0400)] <fj4000> *of
[16:57:21 EDT(-0400)] <fj4000> ok
[16:57:29 EDT(-0400)] <fj4000> so i just asked what default meant in this case
[16:57:39 EDT(-0400)] <colinclark> lol
[16:57:52 EDT(-0400)] * colinclark can tell people have been debating names all afternoon.
[16:57:55 EDT(-0400)] <fj4000> and im wondering if something like fl-reorderer-static ?
[16:58:02 EDT(-0400)] <colinclark> It beats fluoride, but not by very much.
[16:58:04 EDT(-0400)] <fj4000> or resting
[16:58:18 EDT(-0400)] <fj4000> or immobile
[16:58:23 EDT(-0400)] <fj4000> or something like those?
[16:58:38 EDT(-0400)] <Bosmon> To be honest, I never completely understood what it meant
[16:58:46 EDT(-0400)] <Bosmon> It was that way when I inherited the component
[16:59:06 EDT(-0400)] <fj4000> I was just told its the state for the reorderer when no action is happening
[16:59:07 EDT(-0400)] <Bosmon> But I believe that this is some kind of "default" CSS class which is slapped on one of the reorderable elements, if they are not in any other "special" state
[16:59:15 EDT(-0400)] <fj4000> ^
[16:59:36 EDT(-0400)] <Bosmon> Well, it is not the state for the reorderer, but for just 1 cell
[17:00:16 EDT(-0400)] <fj4000> fl-reorderer-atRest ?
[17:00:43 EDT(-0400)] <Bosmon> !!!!!
[17:00:44 EDT(-0400)] <colinclark> I was about to ask why we bother with this at all, but it's too late in the 1.0 game to even ask that question.
[17:00:52 EDT(-0400)] <colinclark> fl-reorderer-default-state
[17:01:03 EDT(-0400)] <colinclark> fl-reorderer-unselected
[17:01:04 EDT(-0400)] <fj4000> yes, this thing looks weird
[17:01:05 EDT(-0400)] <Bosmon> The issue is not with the name of the condition
[17:01:08 EDT(-0400)] <Bosmon> But what it is the condition FOR!
[17:01:13 EDT(-0400)] <Bosmon> It used to have "orderable" in the name
[17:01:18 EDT(-0400)] <Bosmon> Which was not perfectly enlightening
[17:01:30 EDT(-0400)] <Bosmon> Since it didn't agree with the other name we had for this, "movable"
[17:01:34 EDT(-0400)] <Bosmon> But at least it was something
[17:02:16 EDT(-0400)] <colinclark> Bosmon: So is fl-reorderer-movable-default not sufficient?
[17:02:43 EDT(-0400)] <Bosmon> I guess we could try that
[17:02:46 EDT(-0400)] <Bosmon> It seems impossible verbose
[17:02:59 EDT(-0400)] <colinclark> I'm just riffing here. Other suggestions?
[17:03:05 EDT(-0400)] <fj4000> instead of movable why not use cell like you said
[17:03:14 EDT(-0400)] <Bosmon> Because "cell" is a word that appears nowhere
[17:03:17 EDT(-0400)] <Bosmon> Almost nowhere
[17:03:21 EDT(-0400)] <Bosmon> Except in some of the samples
[17:05:33 EDT(-0400)] <Bosmon> Hmm
[17:05:42 EDT(-0400)] <Bosmon> The presence of "avatar" in the "styles" structure is anomalous
[17:05:48 EDT(-0400)] <Bosmon> It doesn't seem to be used for styling, but as a hook
[17:06:33 EDT(-0400)] <Bosmon> avatar = $(options.avatarCreator(item[0], styles.avatar, dropWarningEl));
[17:06:35 EDT(-0400)] <Bosmon> It is used in this line
[17:12:43 EDT(-0400)] <ecochran> fj4000: sorry, I was in a meeting... I'm, of course, working on Uploader
[17:13:36 EDT(-0400)] <fj4000> ecochran: could you elaborate on what you were worried about earlier this afternoon to colinclark?
[17:14:08 EDT(-0400)] <ecochran> fj4000: which worry? I think that my brain already moved on...
[17:14:16 EDT(-0400)] <colinclark> ecochran: Sorry
[17:14:18 EDT(-0400)] <colinclark> I'm catching up.
[17:14:19 EDT(-0400)] <fj4000> i dont know...
[17:14:22 EDT(-0400)] <fj4000> ok ^
[17:14:29 EDT(-0400)] <colinclark> I saw in the channel that you were asking fj4000 about changes in the head of Uploader.html
[17:14:40 EDT(-0400)] <colinclark> And fj4000 gave you a kind of confused response, and then that was it.
[17:15:09 EDT(-0400)] <colinclark> And so I was wondering if fj4000 had given you a clear answer on whether stuff had changed in Uploader.html beyond just changing file paths.
[17:15:16 EDT(-0400)] <ecochran> fj4000, colinclark: oh yes, I was worried that some fss styling was sneaking into Uploader
[17:15:27 EDT(-0400)] <ecochran> yes, I think that we're clear
[17:15:38 EDT(-0400)] <colinclark> Ok, great. So no sneaking?
[17:15:43 EDT(-0400)] <ecochran> the sudden appearance of all the fss skins in Uploader was premature
[17:16:11 EDT(-0400)] <fj4000> just links in the <head> ?
[17:16:18 EDT(-0400)] <ecochran> that was all
[17:16:20 EDT(-0400)] <fj4000> or actually in the body too?
[17:16:22 EDT(-0400)] <fj4000> ok
[17:16:23 EDT(-0400)] <ecochran> just links in the head
[17:16:29 EDT(-0400)] <ecochran> I didn't see anything in the body
[17:16:44 EDT(-0400)] <ecochran> I did a diff and there was just a block of skin links that came in
[17:16:47 EDT(-0400)] <fj4000> ok - didnt think there would be
[17:17:03 EDT(-0400)] <colinclark> Right, I see that now. r6936, Jacob added several FSS files to the head.
[17:17:06 EDT(-0400)] <colinclark> Did this get reverted?
[17:17:27 EDT(-0400)] <ecochran> overwritten in my subsiquent commit... oops
[17:17:44 EDT(-0400)] <colinclark> ecochran, fj4000: Ok, is that a good thing, then?
[17:17:48 EDT(-0400)] <ecochran> yes
[17:17:58 EDT(-0400)] <ecochran> not procedure, but the same result
[17:18:21 EDT(-0400)] <ecochran> I might not have noticed except that it conflicted with my commit
[17:18:50 EDT(-0400)] <ecochran> then I noticed that the links were written wrong and then I started thinking about why they were there in the first place
[17:18:50 EDT(-0400)] <colinclark> No, that's fine. As long as it got removed.
[17:19:29 EDT(-0400)] <ecochran> fj4000: in the long conversation about .css file naming, a question for you from me got lost
[17:19:47 EDT(-0400)] <ecochran> fj4000: do you quote URIs in css or not?
[17:20:01 EDT(-0400)] <ecochran> background-image: url("foo.css")
[17:20:04 EDT(-0400)] <fj4000> I dont anymore
[17:20:12 EDT(-0400)] <ecochran> ah, I have both in my code
[17:20:19 EDT(-0400)] <fj4000> yes, i used to too
[17:20:20 EDT(-0400)] <ecochran> and I wondered if we should standardize
[17:20:28 EDT(-0400)] <ecochran> both are valid... hate that
[17:20:30 EDT(-0400)] <fj4000> but it seems it was only for things with spaces in the name
[17:20:34 EDT(-0400)] <fj4000> yes!
[17:20:42 EDT(-0400)] <fj4000> like font names too
[17:20:56 EDT(-0400)] <ecochran> font names are totally weird
[17:21:00 EDT(-0400)] <ecochran> but we digress
[17:21:27 EDT(-0400)] <ecochran> to quote or not to quote... you seem to be coming down on the not-side
[17:21:31 EDT(-0400)] <fj4000> I thought you had to quote them both
[17:21:44 EDT(-0400)] <fj4000> yes, i was reviewing the spec, and it really didnt
[17:21:50 EDT(-0400)] <fj4000> so I stoppped as well
[17:22:16 EDT(-0400)] <ecochran> I personally like quoting them
[17:22:23 EDT(-0400)] <ecochran> I think that it makes it clearer
[17:22:39 EDT(-0400)] <ecochran> unquoted just feels wrong
[17:22:59 EDT(-0400)] <ecochran> but then CSS is a weird language, or un-language
[17:23:50 EDT(-0400)] <ecochran> somewhere between a programming language and an declarative configuration language
[17:24:13 EDT(-0400)] <fj4000> I agree with you completelu
[17:24:17 EDT(-0400)] <fj4000> *completely
[17:24:28 EDT(-0400)] <ecochran> so maybe we don't need to standardize
[17:24:35 EDT(-0400)] <ecochran> forget I said anything
[17:24:36 EDT(-0400)] <fj4000> but in the end, for something that wasnt required it seemed more work
[17:24:49 EDT(-0400)] <ecochran> cool
[17:26:17 EDT(-0400)] <ecochran> colinclark and fj4000: another worry, that got lost in the hubbub (actually Justin_o and I handled it, just no one else chimed in) was that we now have some css file links in testing which are declared after some of the script links. I think that this was an oversight, and Justin_o suggested that we fix it post-1.0
[17:26:35 EDT(-0400)] <colinclark> ecochran: I just got to that section in the logs.
[17:26:36 EDT(-0400)] <ecochran> sorry, in tests
[17:26:55 EDT(-0400)] <ecochran> serves me right for trying to have more than one conversation at once
[17:26:56 EDT(-0400)] <colinclark> I agree with Justin_o that it's a good one to punt for 1.0 Thanks, ecochran for filing the JIRA about it.
[17:27:12 EDT(-0400)] <ecochran> haven't yet but will
[17:29:25 EDT(-0400)] <colinclark> anastasiac: How'd it go with the question of our daily builds? I guess you've probably been heads-down with other things?
[17:29:54 EDT(-0400)] <anastasiac> yes, heads-down with other things
[17:29:55 EDT(-0400)] <colinclark> Were you able to find out if the Ant scripts are a bottleneck to getting the daily build back, or if we're cool with Maven?
[17:30:00 EDT(-0400)] <anastasiac> I did get far, just didn't implement
[17:30:09 EDT(-0400)] <anastasiac> maven seems to work, but I was about to test first
[17:30:25 EDT(-0400)] <anastasiac> i.e. test the actual resulting war
[17:30:36 EDT(-0400)] <anastasiac> I think I actually deployed...
[17:30:42 EDT(-0400)] <colinclark> anastasiac: Makes sense. I was just trying that out as well.
[17:31:02 EDT(-0400)] <anastasiac> I was interrupted
[17:31:08 EDT(-0400)] <colinclark> no worries
[17:31:10 EDT(-0400)] <colinclark> busy day
[17:31:14 EDT(-0400)] <colinclark> lots of things to keep track of
[17:31:16 EDT(-0400)] <anastasiac> indeed!
[17:31:23 EDT(-0400)] <colinclark> lots of multi-threading in the channel
[17:32:01 EDT(-0400)] <anastasiac> renaming the css classes is revealing bugs - lack of style names, where the "flc-" style classes were being used for styling
[17:32:14 EDT(-0400)] <colinclark> yeah, doesn't surprise me
[17:32:21 EDT(-0400)] <colinclark> these are bugs that we can potentially live with...
[17:32:26 EDT(-0400)] <Bosmon> Should we try and move this selector now?
[17:33:03 EDT(-0400)] <anastasiac> I'm wondering if we should just use the flc- selector for styling, and file a JIRA
[17:33:09 EDT(-0400)] * clown (n=clown@142.150.154.101) has left #fluid-work
[17:33:10 EDT(-0400)] <Bosmon> ???
[17:33:14 EDT(-0400)] <anastasiac> this is getting hairy to keep track of
[17:33:29 EDT(-0400)] <ecochran> I'm ending up with lots of classname="flc-foo fl-foo" in elements which is probably fine
[17:33:38 EDT(-0400)] <anastasiac> there is already a new JIRA for InlineEdit missing a default style selector altogether
[17:34:04 EDT(-0400)] <anastasiac> yeah, I have some of those too
[17:34:09 EDT(-0400)] <anastasiac> not sure if that's acceptable
[17:34:27 EDT(-0400)] <ecochran> why not? in once case it's a selector in the other a style
[17:34:37 EDT(-0400)] <anastasiac> oh, right - I misread you
[17:34:46 EDT(-0400)] <anastasiac> yes, what you have is fine
[17:35:00 EDT(-0400)] <anastasiac> sorry, I thought I saw ".flc-foo fl-foo" i.e. in a css file
[17:35:11 EDT(-0400)] <ecochran> no, that would be bad
[17:35:29 EDT(-0400)] <ecochran> I personally think that flc- should never be in the css
[17:35:34 EDT(-0400)] <ecochran> if we're being good
[17:35:56 EDT(-0400)] <colinclark> ecochran: That's the idea, yes.
[17:36:42 EDT(-0400)] <anastasiac> so not sure how to deal with occasions of this bug
[17:36:45 EDT(-0400)] <anastasiac> at this stage of the game
[17:37:44 EDT(-0400)] <colinclark> anastasiac: Just to be clear, "this bug" is the fact that we're finding occurrences of the same classname being used for both selection and styling?
[17:38:36 EDT(-0400)] <ecochran> colinclark: I thought that was the clean up that we're doing... finding those "errors" and detangling them
[17:38:43 EDT(-0400)] <anastasiac> "this bug" is the fact that InlineEdit is missing a style selector for the text field
[17:38:44 EDT(-0400)] <ecochran> and yes, it's time consuming
[17:38:51 EDT(-0400)] <anastasiac> so the css is using the flc- selector for styling
[17:39:09 EDT(-0400)] <ecochran> just toss another classname at it
[17:39:13 EDT(-0400)] <ecochran> or am I missing something
[17:39:29 EDT(-0400)] <colinclark> Yeah, now's a good time to go ahead and clean it up.
[17:39:39 EDT(-0400)] <colinclark> I was just getting worried that we're feeling swamped. Everyone ok?
[17:39:40 EDT(-0400)] <colinclark>
[17:39:52 EDT(-0400)] <anastasiac> ecochran: I'd have to add the default style to the fluid.defaults() declaration in the js, and make sure that the code properly attaches the style at the right time
[17:39:59 EDT(-0400)] <anastasiac> and yes, I'm feeling swamped
[17:40:21 EDT(-0400)] <ecochran> ah! I see the issue
[17:40:30 EDT(-0400)] <anastasiac> the code has to attach the styling class at the right time
[17:40:32 EDT(-0400)] <Justin_o> what I have been doing in those cases was that if it was specific to a demo, i just didn't rename it in the style sheet and added the flc class to the html, if it was used for both by the component or in css in the component's directory i renamed it with the fl- and added the flc- to the html
[17:40:34 EDT(-0400)] <ecochran> yes, that makes sense
[17:41:14 EDT(-0400)] <ecochran> I was thinking about the Uploader which has its own HTML, not something like inline edit which "creates" its world
[17:41:15 EDT(-0400)] <Justin_o> just to be clear i'm talking about cases where it is using the selector class to also do styling
[17:41:20 EDT(-0400)] <ecochran> hmm
[17:41:59 EDT(-0400)] <ecochran> I think that this is an interesting case because we're doing extra work to what end?
[17:42:48 EDT(-0400)] <anastasiac> so colinclark, I'm not clear on this
[17:42:52 EDT(-0400)] <ecochran> colinclark: I'm feeling good now that Justin_o extended the schedule by a day
[17:43:00 EDT(-0400)] <anastasiac> above you said "now's a good time to go ahead and clean it up"
[17:43:11 EDT(-0400)] <ecochran> I might be able to help some other folks out tomorrow
[17:43:20 EDT(-0400)] <ecochran> that was colinclark
[17:43:26 EDT(-0400)] <anastasiac> would this include modifying the js to add a default style classname, and modify the code to programmatically add that classname?
[17:43:57 EDT(-0400)] <colinclark> anastasiac: I'm just thinking this through for a second here.
[17:44:02 EDT(-0400)] <anastasiac> k
[17:44:03 EDT(-0400)] <anastasiac> thanks
[17:44:17 EDT(-0400)] <colinclark> let's be concrete
[17:44:23 EDT(-0400)] <anastasiac> I think my brain is a bit tired - sorry if I'm confusing
[17:44:24 EDT(-0400)] <colinclark> which selector?
[17:44:32 EDT(-0400)] <colinclark> anastasiac: You're not confusing in the least.
[17:44:45 EDT(-0400)] <anastasiac> there is no style classname for the text field
[17:44:58 EDT(-0400)] <colinclark> this one?
[17:44:58 EDT(-0400)] <colinclark> edit: ".edit"
[17:45:13 EDT(-0400)] <anastasiac> no, that's a selector for dom manipulation
[17:45:17 EDT(-0400)] <anastasiac> I mean a style classname
[17:45:29 EDT(-0400)] <colinclark> right...
[17:45:35 EDT(-0400)] <colinclark> what i'm saying is
[17:45:36 EDT(-0400)] <anastasiac> the .edit you mention willl be renamed .flc-inlineEdit-edit
[17:45:51 EDT(-0400)] <colinclark> this guy is being used for both styling and selection: edit: ".edit"
[17:45:52 EDT(-0400)] <colinclark> yes
[17:45:54 EDT(-0400)] <colinclark> ?
[17:46:09 EDT(-0400)] <anastasiac> well, it's not being used at this point, but one "fix" would be to use if for styling
[17:46:22 EDT(-0400)] <anastasiac> but I thought we weren't supposed to use .flc- for styling
[17:46:50 EDT(-0400)] <colinclark> no
[17:47:35 EDT(-0400)] <colinclark> i mean, "you're correct"
[17:47:43 EDT(-0400)] <anastasiac>
[17:47:48 EDT(-0400)] <colinclark> so just to be very clear
[17:47:51 EDT(-0400)] <colinclark> we've got this thing...
[17:48:11 EDT(-0400)] <colinclark> a selector, currently called ".edit"
[17:48:20 EDT(-0400)] <colinclark> which we will change to ".flc-inlineEdit-edit"
[17:48:23 EDT(-0400)] <colinclark> yes so far?
[17:48:25 EDT(-0400)] <anastasiac> yes
[17:48:42 EDT(-0400)] <colinclark> and there is no corresponding presentational classname
[17:48:58 EDT(-0400)] <colinclark> say, for example, ".fl-inlineEdit-edit"
[17:49:01 EDT(-0400)] <colinclark> yes so far?
[17:49:04 EDT(-0400)] <anastasiac> yes
[17:49:16 EDT(-0400)] <colinclark> in the style sheet, we are styling it using a rather specific means
[17:49:29 EDT(-0400)]
[17:49:37 EDT(-0400)] <anastasiac> right
[17:49:57 EDT(-0400)] <colinclark> in this particular case, i think this is one we can live with for 1.0
[17:50:20 EDT(-0400)] * anastasiac realizes that selector is actually for the edit field and not the diplay text, but the issue remains
[17:50:22 EDT(-0400)] <colinclark> but it does look like you'll have to make the .flc-inlineEdit-edit change in two spots
[17:50:34 EDT(-0400)] <colinclark> on line 611
[17:50:48 EDT(-0400)] <colinclark> and line 347
[17:51:16 EDT(-0400)] <anastasiac> ack!
[17:51:21 EDT(-0400)] <colinclark> which is fine
[17:51:22 EDT(-0400)] <anastasiac> or rather, glarg!
[17:51:30 EDT(-0400)] <anastasiac> thanks for catching that
[17:51:33 EDT(-0400)] <colinclark> do you want me to do this one and you can move on?
[17:51:46 EDT(-0400)] <anastasiac> no, I'm already partway through
[17:51:49 EDT(-0400)] <colinclark> it doesn't look like terribly much work to add the .fl- class name to it as well
[17:52:04 EDT(-0400)] <anastasiac> but wouldn't that be added programmatically?
[17:52:16 EDT(-0400)] <colinclark> Does it need to be added programmatically?
[17:52:26 EDT(-0400)] <colinclark> I mean, it does need to be added at line 347, for sure
[17:52:41 EDT(-0400)] <colinclark> but otherwise, do you think it needs to be added programmatically?
[17:52:53 EDT(-0400)] <anastasiac> at this stage, I don't think I'm in a brain-capable state to make that determination
[17:52:57 EDT(-0400)] <anastasiac>
[17:53:19 EDT(-0400)] <colinclark> I don't see any reason why it would.
[17:53:27 EDT(-0400)] <colinclark> Am I missing something, Justin_o?
[17:53:29 EDT(-0400)] <colinclark> Or ecochran?
[17:53:47 EDT(-0400)] <anastasiac> we actually want the edit field selector, not display
[17:53:57 EDT(-0400)] <anastasiac> that's what fj4000's styles are trying to access
[17:54:11 EDT(-0400)] <colinclark> right
[17:54:20 EDT(-0400)] <anastasiac> yeah, ok - I think it's doable
[17:54:30 EDT(-0400)] <anastasiac> sorry for the confusion, it's been a long day
[17:54:44 EDT(-0400)] <colinclark> no worries at all
[17:54:53 EDT(-0400)] <colinclark> you're wicked
[17:55:15 EDT(-0400)] <colinclark> you've been carrying all these crazy details for the last few days
[17:55:24 EDT(-0400)] <colinclark> it's awesome
[17:55:36 EDT(-0400)] <colinclark> but go home after this change
[17:56:00 EDT(-0400)] <anastasiac> indeed!!
[18:00:17 EDT(-0400)] <colinclark> anastasiac: Just for the record, the M2 build seems to produce a sensible .war file that I can run in Tomcat.
[18:00:59 EDT(-0400)] <anastasiac> colinclark, good to know!
[18:21:59 EDT(-0400)] * anastasiac (n=stasia@142.150.154.189) has left #fluid-work
[18:57:34 EDT(-0400)] <Bosmon> colinclark:
[18:57:40 EDT(-0400)] <Bosmon> What do you think about "plurals" in selectors
[18:57:45 EDT(-0400)] <Bosmon> To me, they seem an anomaly
[18:57:48 EDT(-0400)] <colinclark> I guess it depends on the context.
[18:57:58 EDT(-0400)] <colinclark> It's often weird, yes.
[18:58:09 EDT(-0400)] <colinclark> In Uploader, we've got a selector called "row"
[18:58:16 EDT(-0400)] <colinclark> It returns all the things that are rows in the DOM.
[18:58:26 EDT(-0400)] <colinclark> Singular tends to make more sense when you're applying the class to a particular element.
[18:58:30 EDT(-0400)] <Bosmon> Well
[18:58:41 EDT(-0400)] <Bosmon> Don't you think it looks very odd, to see a plural class name sitting in the DOM?
[18:58:50 EDT(-0400)] <Bosmon> Attached to an element, reading, for example, "columns"
[18:59:22 EDT(-0400)] <colinclark> Bosmon: Yes, exactly.
[18:59:24 EDT(-0400)] <Bosmon> I am talking about the class name, not the name given to the selector in the DOM binder
[18:59:31 EDT(-0400)] <colinclark> right
[19:00:08 EDT(-0400)] <colinclark> If there was a class name called "columns" on a container containing columns, I wouldn't be so bothered by it.
[19:01:07 EDT(-0400)] <Bosmon> ok
[19:06:33 EDT(-0400)] <Bosmon> "columns" was a really terrible name for a default selector
[20:03:02 EDT(-0400)] * athena (n=athena@99.129.100.66) has joined #fluid-work
[20:10:31 EDT(-0400)] * EricDalquist (n=EricDalq@adsl-76-208-69-153.dsl.mdsnwi.sbcglobal.net) has joined #fluid-work
[20:17:11 EDT(-0400)] * apetro-_ (n=apetro@wsip-98-174-242-39.ph.ph.cox.net) has joined #fluid-work
[21:08:32 EDT(-0400)] * EricDalquist (n=EricDalq@adsl-76-208-69-153.dsl.mdsnwi.sbcglobal.net) has joined #fluid-work
[23:02:49 EDT(-0400)] * apetro (n=apetro@ip68-3-207-51.ph.ph.cox.net) has joined #fluid-work
Unknown macro: {FCKEditor}
Unknown macro: {margin}
Manage space
Manage content
Integrations