Skip to end of metadata
Go to start of metadata

You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 120 Next »

[08:42:37 CDT(-0500)] <heidi_> Justin_o misremembering is my new favourite word now (big grin)
[08:43:30 CDT(-0500)] <Justin_o> heidi_: (smile)
[08:49:00 CDT(-0500)] <mlam> colinclark: last night, you mentioned creating an XHR stub to test the HTML5 remote strategy. So in my stub, would I create a dummy onreadystatechange() function within the xhr stub and just call that function in my test?
[08:49:40 CDT(-0500)] <colinclark> mlam: That's the idea, yes
[08:49:45 CDT(-0500)] <mlam> ah ok
[08:49:53 CDT(-0500)] <colinclark> You'd need a stub for each of the properties used by your HTML5 remote
[08:50:09 CDT(-0500)] <colinclark> and then you'll be able to write tests that are equivalent to the ones you've got
[08:50:20 CDT(-0500)] <colinclark> but that actually test the implementation, not the test itself
[08:50:27 CDT(-0500)] <mlam> ok cool, thanks
[08:50:29 CDT(-0500)] <mlam> gotcha (smile)
[08:53:46 CDT(-0500)] <heidi_> Justin_o fl-centered doesn't appear to work on IE
[08:55:19 CDT(-0500)] <Justin_o> heidi_: really... we didn't change that one at all did we?
[08:56:32 CDT(-0500)] <heidi_> Justin_o hmm, it works in the layout.html demo, but not on my test page... so maybe i'm doing something wrong tho it centres in every other browser... i'll look into it
[09:00:14 CDT(-0500)] <Justin_o> heidi_: okay... IE (sad)
[09:00:36 CDT(-0500)] <heidi_> Justin_o i assigned a jira to you to review (no rush). it's that test page that doesn't centre in IE, fyi
[09:01:15 CDT(-0500)] <Justin_o> heidi_: thanks for the heads up..
[09:03:24 CDT(-0500)] <colinclark> mlam: The key thing you'll need to do is take that function you broke out...
[09:03:30 CDT(-0500)] <colinclark> the one that creates an XHR
[09:03:53 CDT(-0500)] <colinclark> and make it an invoker or at least put it in the public namespace so you can replace it with an alternative
[09:04:03 CDT(-0500)] <colinclark> that will create your stub XHR instead
[09:04:34 CDT(-0500)] <mlam> Ok
[09:05:42 CDT(-0500)] <mlam> colinclark: would you be able to quickly merge my new branch to fix the argumentMap value into the main repo?
[09:05:49 CDT(-0500)] <mlam> https://github.com/mlam/infusion/tree/FLUID-4185
[09:05:57 CDT(-0500)] <colinclark> yep
[09:06:02 CDT(-0500)] <mlam> I'll include test cases for this fix in my branch with the other tests
[09:06:13 CDT(-0500)] <heidi_> Justin_o i'm just assigning issues to you to review instead of sending a pull request. is that ok?
[09:06:23 CDT(-0500)] <heidi_> would rather get yr input first
[09:08:13 CDT(-0500)] <colinclark> mlam: Done
[09:08:20 CDT(-0500)] <Justin_o> heidi_: sure i guess that's fine
[09:08:28 CDT(-0500)] <mlam> thanks colinclark
[09:08:44 CDT(-0500)] <Justin_o> heidi_: sorry it's taking me so long to get through this pull request i'm working on
[09:09:56 CDT(-0500)] <heidi_> Justin_o no problem. hey did fluid-3880 (the focus fixes) get pulled in?
[09:10:07 CDT(-0500)] <heidi_> updating the 1.4 to-do list
[09:10:27 CDT(-0500)] <Justin_o> heidi_: it's in my branch
[09:10:32 CDT(-0500)] <Justin_o> not in the project repo yet though
[09:10:35 CDT(-0500)] <heidi_> k
[09:13:09 CDT(-0500)] <heidi_> Justin_o i'm going to pick up the fl-icon and hidden offscreen issues today
[09:14:29 CDT(-0500)] <Justin_o> heidi_: thanks
[09:18:49 CDT(-0500)] <mlam> colinclark: did you look at my branch containing the uploader integration tests?
[09:19:27 CDT(-0500)] <colinclark> I did a bit, yes
[09:19:38 CDT(-0500)] <colinclark> That was the one you sent in the channel last night?
[09:19:43 CDT(-0500)] <mlam> do you think I have sufficient coverage?
[09:19:44 CDT(-0500)] <mlam> Yes
[09:21:52 CDT(-0500)] <colinclark> I'll have to look more closely
[09:21:52 CDT(-0500)] <colinclark> in
[09:21:53 CDT(-0500)] <colinclark> pr
[09:22:03 CDT(-0500)] <colinclark> in practice in several spots you had no coverage, for obvious reasons
[09:22:08 CDT(-0500)] <colinclark> I'll look a bit more closely now
[09:47:10 CDT(-0500)] <colinclark> Wow
[09:47:12 CDT(-0500)] <colinclark> dramatic (smile)
[09:48:43 CDT(-0500)] <colinclark> So, we now have first access to all channels in the #fluid- namespace
[09:48:54 CDT(-0500)] <colinclark> I think we'll stick with just #fluid-work for now, still
[09:49:10 CDT(-0500)] <colinclark> but if we wanted a separate framework or design or talk room, we could make it
[09:49:13 CDT(-0500)] <jessm> colinclark: wicked cool
[09:49:21 CDT(-0500)] <Justin_o> colinclark: that's great
[09:49:24 CDT(-0500)] <colinclark> First step is to register then channel
[09:49:37 CDT(-0500)] <colinclark> and then I think I'll try to figure out how to share ops status
[09:49:53 CDT(-0500)] <jessm> colinclark: i think it's just ops + usr
[09:50:40 CDT(-0500)] <jessm> http://conshell.net/wiki/index.php/IRC_cheatsheet
[09:52:16 CDT(-0500)] <colinclark> Okay, #fluid-work is now officially registered
[09:52:41 CDT(-0500)] <jessm> how legit
[09:52:49 CDT(-0500)] <colinclark> jessm: I think there may be a more permanent way to assign ops status--in other words, at the moment, I'm the only "representative" of the "organization" of Fluid
[09:52:53 CDT(-0500)] <colinclark> talk about air quotes (tongue)
[09:53:03 CDT(-0500)] <jessm> colinclark: oh, you're right
[09:53:06 CDT(-0500)] <jessm> on login
[09:53:15 CDT(-0500)] <colinclark> What would be great, also, is to be able to have an IRC bot on command
[09:53:26 CDT(-0500)] <jessm> bots r fun too
[09:53:27 CDT(-0500)] <colinclark> like, so we could create an informal channel to chat about a specific topic
[09:53:31 CDT(-0500)] <colinclark> and have it logged automatically
[09:53:42 CDT(-0500)] <colinclark> perhaps the solution, ultimately, is to register a few more channels and place bots into them
[09:53:52 CDT(-0500)] <colinclark> I'm thinking specifically of yura_ here (wink)
[09:54:06 CDT(-0500)] <jessm> is yura_ a private channeler?!
[09:54:09 CDT(-0500)] <colinclark> lol
[09:54:19 CDT(-0500)] <colinclark> Well, I think out of respect
[09:54:37 CDT(-0500)] <colinclark> I gather he and Bosmon2 have a kind of always open Framework Help Line going
[09:54:48 CDT(-0500)] <jessm> nice
[09:54:52 CDT(-0500)] <colinclark> And it would be difficult, say, for heidi_ and Justin_o to have a productive FSS conversation going
[09:55:04 CDT(-0500)] <colinclark> while Bosmon2 and yura_ talked about the framework metaphorically as if it were a cat
[09:55:08 CDT(-0500)] <colinclark> or whatever it is that they do (tongue)
[09:55:25 CDT(-0500)] <jessm> teehee
[09:55:28 CDT(-0500)] <yura_> colinclark: (smile) we now try to move all conversations into the channel
[09:55:33 CDT(-0500)] <colinclark> wicked
[09:55:49 CDT(-0500)] <colinclark> I can imagine there are some real gems about troubleshooting Infusion and so on in those conversations
[09:56:05 CDT(-0500)] <colinclark> Well, let's keep it all here for now
[09:56:14 CDT(-0500)] <colinclark> and if we ever get to a point where there's an insane amount of noise
[09:56:19 CDT(-0500)] <colinclark> then we can think about alternatives
[09:56:32 CDT(-0500)] <jessm> colinclark: do we need a bot to handle permanent ops?
[09:56:52 CDT(-0500)] <colinclark> I don't think so, no
[09:56:56 CDT(-0500)] <jessm> i realize that IRC cheatsheet link is relatively useless
[09:57:17 CDT(-0500)] <jessm> on more than one command it says "if you don't know what this is you probably shouldn't be using it"
[09:57:20 CDT(-0500)] <colinclark> I really need to read up more on IRC and Freenode
[09:57:35 CDT(-0500)] <colinclark> Weirdly, I've been using IRC since I was in high school, but I don't actually know what we've got available to us on Freenode
[09:57:39 CDT(-0500)] <colinclark> I just know it's cool
[09:58:44 CDT(-0500)] <jessm> Any op can give ops to anybody else, and once that other person gains ops, he has the same power as you do, including the ability to remove your ops or "deop" you, or even to kick you out. This is known as a takeover. Don't share ops with others unless you trust them fully!
[09:58:51 CDT(-0500)] <marienz> err
[09:58:56 CDT(-0500)] <marienz> that's why we have services here
[09:59:27 CDT(-0500)] <marienz> as this channel is now registered a takeover like that wouldn't be permanent (chanserv has commands to undo all of it)
[09:59:35 CDT(-0500)] <marienz> it's still disruptive, so you still have to be careful, of course
[09:59:52 CDT(-0500)] <jessm> marlenz: do you have an IRC command primer online you recommend?
[10:00:06 CDT(-0500)] <marienz> http://blog.freenode.net/2008/04/registering-a-channel-on-freenode/ is where I'd start
[10:00:13 CDT(-0500)] <jessm> awesome! thanks
[10:00:44 CDT(-0500)] <marienz> also, most clients let you tab-complete nicks like mine (try typing mar<tab>), which has the advantage that you'll spell it right, which has the advantage that it'll highlight on my end (smile)
[10:00:57 CDT(-0500)] <jessm> i did that, but you didn't tab complete
[10:01:00 CDT(-0500)] <jessm> you're greyed out
[10:01:06 CDT(-0500)] <jessm> marienz: now you tab complete
[10:01:17 CDT(-0500)] <jessm> sorry for the type-o
[10:01:33 CDT(-0500)] <marienz> no worries
[10:01:45 CDT(-0500)] <jessm> colinclark: it's like a whole new frontier!
[10:01:56 CDT(-0500)] <colinclark> marienz: I have to say, you guys have been so helpful
[10:02:07 CDT(-0500)] <marienz> you can always ask #freenode if you're confused about something
[10:02:10 CDT(-0500)] <colinclark> You and JonathanD and Martinp23
[10:02:12 CDT(-0500)] <colinclark> Thanks so much
[10:02:29 CDT(-0500)] <marienz> no problem (smile)
[10:16:41 CDT(-0500)] <JonathanD> darn, did everything get fixed while I was fiddling with the printers?
[10:17:19 CDT(-0500)] <JonathanD> colinclark: I can walk you through some basic ircage if you'd like.
[10:27:42 CDT(-0500)] <jessm> JonathanD: is there a resource you could point us all to?
[10:28:05 CDT(-0500)] <JonathanD> There is a substantial amount of information on the freenode website itself.
[10:28:53 CDT(-0500)] <jessm> JonathanD: i guess a number of us have experience using IRC, but are rusty on the commands
[10:29:07 CDT(-0500)] <JonathanD> jessm: wait a bit, going to see if I can get you guys something more concise (smile)
[10:29:17 CDT(-0500)] <jessm> thanks muchly!
[10:30:17 CDT(-0500)] <anastasiac> fluid-everyone: I can't access york's connect - can anyone else?
[10:30:37 CDT(-0500)] <jessm> anastasiac: no, not me
[10:30:42 CDT(-0500)] <heidi_> me neither
[10:30:46 CDT(-0500)] <anastasiac> should we give ocad's another try?
[10:30:50 CDT(-0500)] <jessm> sure
[10:30:54 CDT(-0500)] <heidi_> url?
[10:30:54 CDT(-0500)] <jessm> anastasiac: do you have the link?
[10:31:32 CDT(-0500)] <anastasiac> looking
[10:31:49 CDT(-0500)] <jessm> Justin_o: do you have the url handy?
[10:32:18 CDT(-0500)] <anastasiac> https://connect.ocad.ca/. Login using your lastname first initial (e.g.
[10:32:18 CDT(-0500)] <anastasiac> lastnamef) only, with your usual OCAD password. Anyone with access can
[10:32:19 CDT(-0500)] <anastasiac> schedule a meeting and make it public if a remote participant has the
[10:32:40 CDT(-0500)] <jessm> anastasiac: but Justin_o set up a channel for us already – nudge him if he's nearby for the url
[10:33:21 CDT(-0500)] <jessm> https://connect.ocad.ca/r87258683/
[10:33:26 CDT(-0500)] <jessm> anastasiac: heidi_ ^
[10:33:45 CDT(-0500)] <jessm> this way folks w/o OCAD auth can get in
[10:34:28 CDT(-0500)] <heidi_> i'm in
[12:39:28 CDT(-0500)] <heidi_> Justin_o i'm feeling confused about the fss stuff in /lib/jquery/ui/css/ ... maybe this is an attempt at the merging w/ jquery ui we were just talking about? gonna look for documentation... anastasiac have you run into why this is?
[12:40:03 CDT(-0500)] <anastasiac> heidi_, not sure what the question is? what might I have run into?
[12:40:24 CDT(-0500)] <heidi_> anastasiac an explanation of the fss files in /lib/jquery/ui/css
[12:40:37 CDT(-0500)] <Justin_o> heidi_: those are so that the jquery ui widgets will match the fss-themes
[12:40:46 CDT(-0500)] <anastasiac> ah. I see...
[12:40:53 CDT(-0500)] <anastasiac> Justin_o, can you elaborate a bit?
[12:40:53 CDT(-0500)] <Justin_o> heidi_: i think that's what you are refering to
[12:41:13 CDT(-0500)] <heidi_> yeah... maybe?
[12:41:33 CDT(-0500)] <heidi_> i don't really get how this fits in - i second elaborating!
[12:42:20 CDT(-0500)] <Justin_o> so you can theme jquery ui widgets through theme roller. With jquery ui they do a bunch of markup injection to get there components the way they want them, so it can be tricky without themeroller to know how to style them..
[12:42:52 CDT(-0500)] <Justin_o> so what we have there is a set of themeroller jquery ui themes that are used in conjunction with fss themes to style the jquery ui widgets
[12:43:21 CDT(-0500)] <heidi_> oook...
[12:43:21 CDT(-0500)] <Justin_o> so when you are using the high contrast them, you'll use the corresponding jquery ui theme
[12:43:25 CDT(-0500)] <anastasiac> so Justin_o, these files could be thought of as extensions to their corresponding theme files?
[12:43:35 CDT(-0500)] <Justin_o> anastasiac: yes.. you could say that
[12:44:06 CDT(-0500)] <anastasiac> justin_o, do you know if it's necessary that they be named exactly the same as the fss theme files? that's seems confusing
[12:44:06 CDT(-0500)] <heidi_> Justin_o the jquery ui styles we've adopted are right here tho.... it seems weird to duplicate them in fss when we're already using them?
[12:44:52 CDT(-0500)] <Justin_o> anastasiac: i don't think so.. i think it's just so that you know what goes with what
[12:44:57 CDT(-0500)] <Justin_o> heidi_: not sure i understand
[12:45:32 CDT(-0500)] <heidi_> Justin_o i.e. the clearfix solutions, the reset, the hidden, the icon styles
[12:45:47 CDT(-0500)] <heidi_> are all in these css files
[12:45:52 CDT(-0500)] <Justin_o> heidi_: ah okay..
[12:46:03 CDT(-0500)] <Justin_o> heidi_: these only work with jquery ui though
[12:46:08 CDT(-0500)] <Justin_o> they are not general purpose
[12:46:37 CDT(-0500)] <Justin_o> so you may not be using any jquery ui widgets but still want a clearfix and etc.
[12:46:40 CDT(-0500)] <heidi_> yeah i sorta get what's happening but it seems.... like something's not quite right
[12:47:14 CDT(-0500)] <heidi_> Justin_o i guess it goes back to why use fss and not jquery ui. esp if you're using jquery widgets as well
[12:47:46 CDT(-0500)] <Justin_o> heidi_: i think in an ideal world we wouldn't have these jquery ui themes.. it's just that UI Options in particular, at the time, used a jquery ui widget and it needed to be styled
[12:48:15 CDT(-0500)] <heidi_> Justin_o and styling through jquery ui made more sense than using fss because... ?
[12:48:36 CDT(-0500)] <heidi_> i'm just thinking out loud... no agenda. just seems kinda messy
[12:49:00 CDT(-0500)] <Justin_o> heidi_: because we'd have to add .ui- namespaces to the fss.. or have to do a bunch of work in the js to add in the proper style names
[12:49:54 CDT(-0500)] <Justin_o> with infusion components we give the user control over class names and etc.. so it's easier to use what you want. with the jquery ui ones, unless this has changed, we have to take what they give us
[12:49:58 CDT(-0500)] <heidi_> i'm just thinking... all these great styles are right here, already included in infusion, and instead of using them, we copy parts into fss. maybe that makes sense but... hmm
[12:51:53 CDT(-0500)] <Justin_o> heidi_: i think i know what you mean.. but i think the FSS's goals are slightly different.. jquery ui is aiming to style their widgets. but the FSS is more of a light weight starting point that works with your styles and other frameworks
[12:52:25 CDT(-0500)] <Justin_o> heidi_: but as you can see from our demos.. our components don't require FSS
[12:53:44 CDT(-0500)] <heidi_> Justin_o but isn't the plan that they do?
[12:53:59 CDT(-0500)] <heidi_> for 1.5
[12:54:42 CDT(-0500)] <Justin_o> heidi_: the plan is for us to use it.. maybe not for 1.5 anymore (smile) , but they still won't require it
[12:55:07 CDT(-0500)] <Justin_o> at the moment the only thing that actually probably requires FSS is UI Options
[12:55:34 CDT(-0500)] <Justin_o> although in the future I think we'd like to make it work with anything, if that's possible
[12:58:04 CDT(-0500)] <heidi_> Justin_o was led to all this while researching fl-icon... am wondering if you know why we include the icon files in say /lib/jquery/ui/css/fl-theme-coal/images/ui-icons_333333_256x240.png
[12:58:28 CDT(-0500)] <heidi_> are we to make use of these somehow? chop em up?
[12:59:46 CDT(-0500)] <heidi_> Justin_o oh i see that the coal.css positions the image in such a way that the specified icon shows up in the 16x16 spot for the icon. interesting.
[13:00:02 CDT(-0500)] <Justin_o> heidi_: yep.. those are css sprites
[13:00:14 CDT(-0500)] <heidi_> Justin_o not sure fl-icon makes sense without using these
[13:00:31 CDT(-0500)] <Justin_o> heidi_: does fl-icon actually use them?
[13:00:54 CDT(-0500)] <heidi_> Justin_o no
[13:01:30 CDT(-0500)] <Justin_o> heidi_: have you determined yet what fl-icon is used for?
[13:02:46 CDT(-0500)] <heidi_> Justin_o sorta kinda. still confused. fss doc says "What the fl-icon does is set up your icons at a certain size (16 x 16 pixels), and allow you to place text in your anchors without it showing or compromising the visual aesthetic. Its does this by making the links block level elements with a large negative text indent to "pull" the text outside of their clipping region."
[13:02:50 CDT(-0500)] <heidi_> does that make sense to you?
[13:03:17 CDT(-0500)] <heidi_> i think it allows you to put text within a link, but hides the text and shows the icon
[13:03:29 CDT(-0500)] <Justin_o> ah okay
[13:03:43 CDT(-0500)] <Justin_o> and it's just a way to do that without specifying alt text?
[13:03:44 CDT(-0500)] <heidi_> Justin_o fss has a few icons... "more" and "close"
[13:03:53 CDT(-0500)] <heidi_> that might be it
[13:04:20 CDT(-0500)] <heidi_> looks like there's a delete img but no style for it
[13:05:03 CDT(-0500)] <heidi_> Justin_o yeah that's what i mean - for the jquery method it makes sense because you have one img with a bunch of icons and you need css to show it properly
[13:05:21 CDT(-0500)] <heidi_> fss isn't doing that so no real need to do the fl-icon stuff, you know?
[13:05:56 CDT(-0500)]

<heidi_> like the style for a more icon is : .fl-theme-coal .fl-widget .fl-icon-more

Unknown macro: {background-image}

which is straight fwd, doesn't req fl-icon


[13:07:12 CDT(-0500)] <heidi_> Justin_o so all this to say: i think fl-icon can go?
[13:07:18 CDT(-0500)] <Justin_o> heidi_: yah i'm not too sure about this one
[13:07:35 CDT(-0500)] <Justin_o> heidi_: possibly.. is it used for anything in the mobile styles?
[13:08:25 CDT(-0500)] <heidi_> Justin_o fss-mobile-layout.css references it but again, i don't know why or how it'd be used
[13:08:58 CDT(-0500)] <heidi_> i'm wondering if jacob got it orig from jquery ui, but didn't implement the full extent of it? or... maybe i'm missing something?
[13:09:05 CDT(-0500)] <Justin_o> heidi_: hmm.. you might want to checkout out the engage demo..
[13:09:31 CDT(-0500)] <Justin_o> heidi_: http://fluidengage.org/engage/home/home.html
[13:09:41 CDT(-0500)] <Justin_o> you should use a webkit browser, like safari to view
[13:10:04 CDT(-0500)] <Justin_o> heidi_: yah.. i'm not sure.. i wish jacob was around to help us understand some of these things..
[13:11:07 CDT(-0500)] <heidi_> Justin_o in the mobile implementations it seems to control the size of an image, to make them uniform. that makes sense but seems totally different than how it's used in fss-layout
[13:11:32 CDT(-0500)] <heidi_> i must be missing something
[13:13:19 CDT(-0500)] <Justin_o> heidi_: yah unfortunately i'm not sure.. it might just be that we don't have a good example of it
[13:14:58 CDT(-0500)] <heidi_> Justin_o yeah it's not used in any demos etc
[13:15:13 CDT(-0500)] <heidi_> i just wish i knew how to use it and what it's supposed to do ha
[13:15:32 CDT(-0500)] <heidi_> i guess i'll leave it for now
[13:25:06 CDT(-0500)] <Justin_o> heidi_: (smile)
[13:25:18 CDT(-0500)] <Justin_o> i guess we need better documentation for FSS
[13:26:09 CDT(-0500)] <anastasiac> I'm working on the FSS docs, I'm working on it! I'll catch up on your conversations, heidi_ and Justin_o, but it looks like you've been talking about the mobile stylesheets?
[13:26:24 CDT(-0500)] <Justin_o> anastasiac: (smile)
[13:26:33 CDT(-0500)] <heidi_> Justin_o my closest guess is that it makes a space for an icon, moves the text out, and let's the user add an icon to that space as a bg image if they have one.
[13:26:35 CDT(-0500)] <Justin_o> anastasiac: more so about fl-icon in general
[13:27:05 CDT(-0500)] <anastasiac> ah, I was wondering about that too. I was going to play with it a bit to see what it does.
[13:27:16 CDT(-0500)] <heidi_> however, it's confusing and possibly useless if fss doesn't provide icons for that purpose
[13:28:12 CDT(-0500)] <Justin_o> heidi_: possibly.. although if it is just the starting block it might make sense
[13:28:19 CDT(-0500)] <Justin_o> not sure yet though
[13:28:43 CDT(-0500)] <heidi_> why would anyone want a box of colour as an icon tho? the text would be far more useful on its own?
[13:28:47 CDT(-0500)] <heidi_> and accessible
[13:30:03 CDT(-0500)] <Justin_o> heidi_: yes.. i don't think you'd want a box of colour in most cases.. but i meant more as a helper when you have an image and want to turn it into an icon
[13:30:40 CDT(-0500)] <heidi_> Justin_o but even so, why not just use the img with alt text?
[13:30:56 CDT(-0500)] <Justin_o> heidi_: yes.. this is a good question
[13:30:58 CDT(-0500)] <heidi_> with the css sprites i can see the need for this, but otherwise not
[13:31:03 CDT(-0500)] <Justin_o> cause you could just set the size of the image
[13:33:49 CDT(-0500)] <heidi_> this is the example for fl-icon: <a href="#_bottom" class="fl-icon myCustomToolIcon" title="Tool Description">Tool A</a> anastasiac i guess we just need an example of what "myCustomToolIcon" would look like.
[13:34:20 CDT(-0500)] <heidi_> and maybe an explanation as to why bother vs. alt text on a sized img (smile)
[13:34:57 CDT(-0500)] <anastasiac> heidi_, I think one of the advantages is the high-contrast themes: if you switch to one of them, then things marked fl-icon will be replaced with the alt text only
[13:35:14 CDT(-0500)] <anastasiac> or some text - not sure which
[13:35:22 CDT(-0500)] * anastasiac is still learning
[13:35:32 CDT(-0500)] <heidi_> that's... interesting. does high-contrast usually mean replace imgs with text?
[13:35:47 CDT(-0500)] <anastasiac> I think so, not sure
[13:36:03 CDT(-0500)] <heidi_> then yeah, that makes sense i think...
[14:16:41 CDT(-0500)] <Justin_o> harriswong: just put up another comment on the pull request for FLUID-4164
[14:16:52 CDT(-0500)] <Justin_o> one more spot in the release notes to update...
[14:17:01 CDT(-0500)] <harriswong> Justin_o: thanks! ok
[14:17:02 CDT(-0500)] <Justin_o> when you have that in i'll push it up to the project repo
[14:24:49 CDT(-0500)] <Justin_o> colinclark, michelled: I think we were talking last week about github's built in issue tracker.. they just updated it https://github.com/blog/831-issues-2-0-the-next-generation
[14:25:19 CDT(-0500)] <colinclark> yep, apparently people really like it, Justin_o
[14:25:40 CDT(-0500)] <anastasiac> heidi_, that fl-icon class and its interaction with the high-contrast themes: it seems the background image is only replaced with the actual text if the fl-icon is inside fl-widget (which seems odd)
[14:26:15 CDT(-0500)] <heidi_> oh strange
[14:26:33 CDT(-0500)] <anastasiac> yes, I think it should work regardless of whether or not its in a widget
[14:26:41 CDT(-0500)] <anastasiac> the whole widget thing seems odd to me
[14:27:00 CDT(-0500)] <anastasiac> heidi_, do you understand the idea behind the fss "widget"?
[14:27:38 CDT(-0500)] <heidi_> anastasiac i think it's similar to a portlet idea
[14:28:07 CDT(-0500)] <heidi_> like with a titlebar, and an inner section, and controls etc
[14:29:30 CDT(-0500)] <colinclark> Justin_o: So do you think we should switch from one proprietary bug tracking platform to a hosted proprietary bug tracking platform?
[14:30:01 CDT(-0500)] <Justin_o> colinclark: i don't think we switch from jira to github's if that's what you mean
[14:30:08 CDT(-0500)] <colinclark> yeah
[14:30:10 CDT(-0500)] <colinclark> how come?
[14:30:20 CDT(-0500)] <colinclark> I don't think we should either, I'm just curious
[14:30:26 CDT(-0500)] <Justin_o> because i don't know how we could migrate to and from it, for one reason
[14:30:51 CDT(-0500)] * jamon chimes in with the usual tired plug for redmine
[14:31:01 CDT(-0500)] <Justin_o> jamon: (smile)
[14:31:20 CDT(-0500)] <Justin_o> colinclark: github's might make sense for that community / labs stuff though
[14:31:27 CDT(-0500)] <Justin_o> although i'm not sold on that yet either
[14:33:07 CDT(-0500)] <colinclark> jamon: I think the problem with Redmine is that it's missing a few key coordination features that we rely on in JIRA.
[14:33:18 CDT(-0500)] <colinclark> This isn't us rejecting Redmine because it isn't feature-rich enough for us
[14:33:23 CDT(-0500)] <colinclark> it's not us being pickyu
[14:33:39 CDT(-0500)] <colinclark> I'm sure we'd love to have the time to contribute those features to Redmine
[14:33:41 CDT(-0500)] <jamon> yes i think that we discussed it on the list
[14:33:44 CDT(-0500)] <colinclark> there's just only so much time in the day
[14:34:02 CDT(-0500)] <jamon> consensus being no, not the right time
[14:38:21 CDT(-0500)] <colinclark> mlam: How's the mocking going?
[14:38:49 CDT(-0500)] <mlam> it's coming along. i've removed a bunch of actual code from the tests
[14:39:05 CDT(-0500)] <Justin_o> heidi_: i was looking at FLUID-3880, it looks like you didn't update the coal theme
[14:39:07 CDT(-0500)] <Justin_o> https://github.com/jobara/infusion/compare/master...FLUID-3880
[14:39:11 CDT(-0500)] <Justin_o> was that intentional?
[14:39:14 CDT(-0500)] <mlam> however, i'm stuck on how to invoke my dummy onreadystate() function
[14:39:15 CDT(-0500)] <Justin_o> or just missed?
[14:39:23 CDT(-0500)] <heidi_> Justin_o oops, not intentional no
[14:39:37 CDT(-0500)] <Justin_o> heidi_: okay.. i'll add it in
[14:39:42 CDT(-0500)] <heidi_> cool
[14:39:56 CDT(-0500)] <colinclark> Stuck how, mlam?
[14:40:30 CDT(-0500)] <Justin_o> heidi_: do you think we should update the demos that use the themes to add the fl-focus class in?
[14:40:45 CDT(-0500)] <heidi_> Justin_o sure
[14:40:48 CDT(-0500)] <mlam> well, i created an xhr object containing a bunch of real xhr properties.
[14:41:36 CDT(-0500)] <Justin_o> heidi_: okay
[14:42:29 CDT(-0500)] <mlam> so setting the necessary properties makes sense to me. but now, when we're using a real xhr object, there's a listener for the onreadystatechange() function.
[14:43:16 CDT(-0500)] <mlam> I'm not sure how I would mock this function and invoke it
[14:43:31 CDT(-0500)] <colinclark> mlam: Hmm
[14:43:36 CDT(-0500)] <colinclark> flip it around in your head
[14:43:43 CDT(-0500)] <colinclark> You don't need to mock it
[14:44:13 CDT(-0500)] <colinclark> If you look at the HTML5Strategy code, you'll see that onreadystatechange is just a property on the XHR
[14:44:19 CDT(-0500)] <colinclark> the user sets it to a callback function
[14:44:22 CDT(-0500)] <mlam> right
[14:44:34 CDT(-0500)] <colinclark> Meaning, the Uploader takes care of registering a function for onreadystatechange
[14:44:38 CDT(-0500)] <colinclark> so you don't need to mock it
[14:44:43 CDT(-0500)] <colinclark> you just need to invoke it
[14:45:00 CDT(-0500)] <colinclark> And you should be able to do that, for now, whenever you need to
[14:45:10 CDT(-0500)] <colinclark> in other words, presumably you're calling some method in the Uploader
[14:45:20 CDT(-0500)] <colinclark> that will make an asynchronous request
[14:45:41 CDT(-0500)] <colinclark> you can "simulate" that request by just calling the onreadystatechange function whenever you need it, and then test that results are as expected.
[14:48:32 CDT(-0500)] <mlam> Hmm...ok, let me give this a shot
[14:49:31 CDT(-0500)] <harriswong> Justin_o: I have changed the "release note", https://github.com/fluid-project/infusion/pull/27
[14:49:42 CDT(-0500)] <Justin_o> harriswong: thanks
[14:52:06 CDT(-0500)] <Justin_o> heidi_: i've updated the FSS themes demo to use fl-focus.. any other demo you can think of
[14:53:41 CDT(-0500)] <Justin_o> harriswong: did you actually download the update on March 29?
[14:55:10 CDT(-0500)] <harriswong> Justin_o: I did a git fetch upstream and origin, then git merge upstream/master.
[14:55:57 CDT(-0500)] <Justin_o> harriswong: sorry.. meant the jquery ui update
[14:56:00 CDT(-0500)] <Justin_o> 1.8.11
[14:56:10 CDT(-0500)] <harriswong> Justin_o: oh. Let me check.
[14:57:15 CDT(-0500)] <Justin_o> harriswong: just asking because your update to the ui-FLUID-readme has the same day as the previous update. so was wondering if this was a mistake or a coincidence
[14:57:54 CDT(-0500)] <heidi_> Justin_o that should be fine, unless we want our focus on all demos
[14:58:00 CDT(-0500)] <heidi_> the default one
[14:58:01 CDT(-0500)] <harriswong> Justin_o: yes I did, haha, no it wasn't. It was Mar 29 as noted in the readme I modified.
[14:59:41 CDT(-0500)] <Justin_o> harriswong: that's pretty funny.. exactly 1 year to the day
[15:00:18 CDT(-0500)] <harriswong> Justin_o: yea, I thought you planned it actually.
[15:00:45 CDT(-0500)] <heidi_> anastasiac so i think removing fl-widget from the fl-icon style would be good to do. have you noticed anything else about it that needs tweaking?
[15:01:04 CDT(-0500)] <harriswong> Justin_o: and I was thinking to myself, wow that's some precise estimation...
[15:01:13 CDT(-0500)] <anastasiac> heidi_, not yet. I'm now playing with widgets, to learn just what they are/do
[15:01:27 CDT(-0500)] <anastasiac> but I agree that the benefit of icon high contrast should be available outside of widgets, too
[15:01:38 CDT(-0500)] <heidi_> yeah
[15:02:25 CDT(-0500)] <Justin_o> harriswong: i wish i was so forward thinking (smile)
[15:06:24 CDT(-0500)] <heidi_> anastasiac if you find any other fl-icon to do's, you can add it here: http://issues.fluidproject.org/browse/FLUID-4182 ... will make the changes for 1.4
[15:06:40 CDT(-0500)] <mlam> colinclark: thanks for getting me unstuck (smile)
[15:06:43 CDT(-0500)] <anastasiac> heidi_, thanks for the link
[15:16:12 CDT(-0500)] <Justin_o> harriswong: your pull request is in
[15:18:38 CDT(-0500)] <harriswong> Justin_o: Haha, extreme forward thinking! And yep, I got the email notification, thanks Justin!
[15:19:16 CDT(-0500)] <Justin_o> harriswong: no problem, thank you
[15:19:21 CDT(-0500)] <colinclark> mlam: When you get stuck, just ask
[15:19:25 CDT(-0500)] <colinclark> Early and often
[15:19:42 CDT(-0500)] <colinclark> between yura_, michelled, Bosmon2, and I, there should be lots of people help unstick you (smile)
[15:19:51 CDT(-0500)] <mlam> for sure, thanks!

  • No labels