Info |
---|
This page is intended to act as a guide for code reviewers. |
...
- The code should not contain any duplicated sections (cut 'n' paste), either with respect to the whole codebase and certainly not amongst any piece of new work
...
- There are passing tests for new functionality
...
- The code is internationalized - at a minimum all human readable text are in strings in the options block
...
- The public API is commented
...
- Core logic is available and testable through an API (hint: your event handlers often contain core logic)
...
- ARIA roles are used where appropriate
...
- All functionality can be navigated to and controlled via the keyboard
...
- Is responsive to different screen sizes
- Code is broken up into small, well named things, which are all independently testable in isolation from each other
...
- Errors are reported to the user clearly
All JavaScript files pass
...
- ESLint
- See Coding and Commit Standards for specific settings to use in jsHint.
- All HTML files pass the W3C validator
...
- All JSON files pass json lint