Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

infusion-all.js throws an error if required from the browser.

Description

In updating the dependencies in gpii-testem, I noticed that infusion-all.js now throws an error if you include it from a browser (Testem caught the uncaught exception and reported it as a test failure):

not ok 8 Opera 57.0 - [0 ms] - global failure --- stack: > http://localhost:7357/node_modules/infusion/dist/infusion-all.js:45605 message: > Uncaught ReferenceError: require is not defined Log: | ...

I tracked that down to this line in jquery.scrollTo:

https://github.com/flesler/jquery.scrollTo/blob/master/jquery.scrollTo.js#L17

I was hoping someone familiar with recent changes might be able to explain why we're passing that check and trying to "require" jQuery.

Environment

None

Activity

Show:

Tony Atkins [RtF]April 5, 2019 at 12:16 PM

This was automatically resolved, but there is still work to be done. I'm reopening and will work on running the new tests in CI shortly.

Tony Atkins [RtF]February 12, 2019 at 11:42 AM

In preparing a branch to test this, I verified that recent versions of the bundle are includable as long as module.exports isn't defined. I'm going to see what's defining that and causing the gpii-testem tests to fail, but it looks like the package itself is OK, which lowers the urgency.

Antranig BasmanFebruary 12, 2019 at 11:03 AM

I can't reproduce this in an infusion-all built from current trunk. You may have done something within gpii-testem or its instrumentation to dump a module object at top level into the browser?

Tony Atkins [RtF]February 12, 2019 at 10:48 AM

My initial thought is that we might have a stray global definition of module.exports that results in that check passing.

Tony Atkins [RtF]February 12, 2019 at 10:45 AM

I suspect the error was introduced in this commit, dev releases before that date include a copy of infusion-all.js that is safe to require. I'm sure we don't test with these because we want coverage data. As Testem catches and reports the error, I'd suggest creating a separate testem config that runs tests against the bundles. The test itself would just include the bundle and a trivial passing test. Since is largely out, I may just take this on while I'm thinking of it.

Fixed

Details

Assignee

Reporter

Components

Priority

Created February 12, 2019 at 10:32 AM
Updated July 22, 2024 at 2:35 PM
Resolved July 27, 2020 at 4:14 PM