Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

fluid.isArrayable faultily considers any object with a property named "jquery" is an array

Description

Our current implementation looks like this - 

which is extremely generous and will catch any object with a property named "jquery". We finally fell foul of this when passing our own package.json file through fluid.copy in a Kettle test and it ended up truncating the entire "devDependencies" block which now includes an entry for jQuery (for some reason).

We should tighten up this test so it cannot be tripped by any plain object.

Environment

None

Activity

Show:

Justin Obara October 17, 2018 at 4:23 PM

Merged PR ( https://github.com/fluid-project/infusion/pull/940 ) into the project repo at 787f7d5e5b9a3565f4843be491e64dcc9e5fe355

Justin Obara October 17, 2018 at 1:08 PM

jQuery is in the devDependencies because Infusion's dependencies are now pulled in from NPM. It's not in the dependencies block because the NPM package of infusion includes it in the dist builds. See

Fixed

Details

Assignee

Reporter

Components

Priority

Created October 17, 2018 at 1:46 AM
Updated October 18, 2018 at 12:46 PM
Resolved October 17, 2018 at 4:58 PM