Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Build/lint time has increased significantly post-FLUID-6315

Description

Build and lint check time for the Infusion repository has increased substantially.

Build time pre-FLUID-6315:

Build time post-FLUID-6315:

Lint time pre-FLUID-6315:

Lint time post-FLUID-6315:

Here is a failed CI build for FLUID-6315: https://buildkite.com/fluid-project/infusion/builds/365

i can reproduce these changes locally on my laptop (linting takes over 4min).

Environment

None

Activity

Show:

Justin Obara September 20, 2018 at 12:34 PM

Merged PR ( https://github.com/fluid-project/infusion/pull/930 ) into the project repo at 81c4c0572b8ac0ffd650fa675cc8dab43d422d11

Tony Atkins [RtF] September 4, 2018 at 11:03 AM
Edited

After some research, it became clear that the globbing used by Grunt, in combination with overly broad patterns like ./**/*.js resulted in scanning and then excluding all files in dist, node_modules, et cetera. There is a new pull that uses the new gpii-glob library and tighter patterns, which reduces the linting speed to 9-10 seconds.

https://github.com/fluid-project/infusion/pull/930

Tony Atkins [RtF] September 4, 2018 at 10:44 AM

I have reopened this as the speed was a separate issue. I'm submitting a pull shortly that brings the linting time down to 9-10 seconds.

Tony Atkins [RtF] August 22, 2018 at 12:21 PM

Thanks, I decided to sanity check via other means and submitted https://fluidproject.atlassian.net/browse/FLUID-6328#icft=FLUID-6328 with the few files that were not checked that should have been. I didn't find any evidence that files that shouldn't be checked were being checked, which was what I was worried about with the timing.

Giovanni Tirloni August 22, 2018 at 10:51 AM

Still running but it's successfully finished the build/lint phases: https://ci.fluidproject.org/job/infusion-pull-request/22

Fixed

Details

Assignee

Reporter

Components

Priority

Created August 21, 2018 at 4:30 PM
Updated July 22, 2024 at 12:56 PM
Resolved September 20, 2018 at 12:34 PM