Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

CI builds Infusion 2x and runs `npm install` 3x

Description

The CI pipeline for Infusion has not evolved over time to adapt for changes in the build process and other dependencies. As such, it's building Infusion 2 times inside the VM and running `npm install` 3 times – on `vagrant up` (see provisioning/vars.yml where grunt is called), immediately after that outside the VM and final time inside the VM once more.

According to provisioning/vars.yml, simply running `vagrant up` should:

  • setup VM

  • install node/npm

  • npm install

  • grunt (builds infusion)

From that point on, it's just a matter of running the tests with `npm run test:vagrant`

Environment

None

Activity

Show:

Justin Obara April 12, 2018 at 12:12 PM

Merged PR ( https://github.com/fluid-project/infusion/pull/896 ) into the project repo at 0144ae46b193478a3d7068ff164bba3c1701d23e

Giovanni Tirloni March 28, 2018 at 8:39 PM

thanks! Could you review my PR when you have some free time? I did a few more changes to it that are detailed in the PR's comments.

Alan Harnum March 28, 2018 at 2:24 PM

Reducing the needless steps seems completely reasonable to me, +1.

Fixed

Details

Assignee

Reporter

Components

Priority

Created March 28, 2018 at 2:22 PM
Updated April 12, 2018 at 12:12 PM
Resolved April 12, 2018 at 12:12 PM